[09:03:32] <grrrit-wm>	 (03CR) 10Adrian Lang: "I would prefer if this would reuse the logic from wb.utilities.ui.buildPrettyEntityLabel in order to reduce duplication. So, we should add" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE))
[09:25:44] <lbenedix>	 Lydia_WMDE: I've seen you in an infrastructure presentation a while ago... do you know if there is a central point for slides about wikimedias infrastructure? Something like this but more actual (and maybe very old slides for comparisson):  http://www.lugod.org/presentations/Wikimedia_Infrastructure_Utrecht_LUG_2011.pdf
[09:26:16] <Lydia_WMDE>	 erik gave one at fosdem last weekend
[09:26:21] <Lydia_WMDE>	 there should be a video
[09:29:47] <lbenedix>	 Eric == Eloquence?
[09:30:04] <DanielK_WMDE_>	 lbenedix: yes. Erik Möller.
[09:36:38] <lbenedix>	 thx
[09:52:07] <grrrit-wm>	 (03PS16) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 
[09:57:57] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang)
[11:41:51] <GerardM->	 Lydia_WMDE: I added you on https://bugzilla.wikimedia.org/show_bug.cgi?id=60867 ... according to aharoni it should be an easy one to fix :)
[11:42:00] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] cucumber.yml is no longer needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110357 (owner: 10Zfilipin)
[11:42:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: cucumber.yml is no longer needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110357 (owner: 10Zfilipin)
[11:44:00] <addshore>	 heh GerardM- I expect I will have to comment there as I am the one that wrote them :P
[11:44:19] <aharoni>	 addshore, GerardM- , Lydia_WMDE - I suspect that it is something that not only affects the messages' translations, but may be wrong in English as well, though I might wrong.
[11:45:20] <GerardM->	 addshore :) thank you ... I do not know who works on what :) but I do know the "boss man sir"
[11:50:48] <addshore>	 aharoni: GerardM- the messages as they are listed in english currenty are what the UI and Javascript have been using
[11:51:14] <addshore>	 we have been switching from from front end formatters to backend formatters
[11:51:38] <addshore>	 so these messages never had any i18n support before and were always in english as is currently written in the en section of the php i18n file
[11:51:50] <addshore>	 we could indeed probably tweak them now :)
[11:52:06] <addshore>	 I guess we just need to desice what to format them all as!
[12:07:19] <GerardM->	 addshore I am pretty certain that aharoni is expert in such matters
[12:14:41] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 031] [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher)
[12:18:04] <aharoni>	 addshore, GerardM- - yes, I'll gladly help, but I need to understand what do they mean.
[12:18:25] <aharoni>	 As I wrote in the bug report, I don't understand it now.
[12:18:28] <addshore>	 :>
[12:19:04] <addshore>	 okay, well when setting a time value in wikidata you set a precision as well, depending on the precision a different formatis presented to the user
[12:19:19] <addshore>	 your best bet is to hop onto https://www.wikidata.org/wiki/Wikidata:SandboxItem
[12:19:55] <addshore>	 and try adding some numbers and changing the precision, A time/date property you could use is 'point in time'
[12:22:30] <aharoni>	 addshore: looking...
[12:25:17] <grrrit-wm>	 (03PS2) 10Thiemo Mättig (WMDE): Avoid showing "null" in JavaScript tooltip for properties with no label. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 
[12:26:53] <aharoni>	 GerardM-, addshore: ZOMFG! the little advanced precision editing panel is completely broken with regard to right-to-left languages.
[12:27:54] <aharoni>	 so, currently if click on "day", I get a range of values from day, via 10,000 years, and ending with billion years.
[12:28:11] <aharoni>	 Are these represented as messages anywhere? Is this the thing that is going to change?
[12:28:52] <aharoni>	 (by "going to change" I refer to "replaced by the messages that I mentioned in https://bugzilla.wikimedia.org/show_bug.cgi?id=60867")
[12:30:20] <aharoni>	 addshore: ^
[12:31:02] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE))
[12:41:28] <addshore>	 aharoni: the messages you currently see are not handeled by i18n in any way, they are in static javascript
[12:41:48] <addshore>	 at the next deployment it will switch from this static javascript to the i18n messages
[12:51:19] <aharoni>	 addshore: OK, so that I overcame the shock from the broken RTL ( https://bugzilla.wikimedia.org/show_bug.cgi?id=60889 ), I see where the "in million years" message appears.
[12:51:26] <aharoni>	 however, I still don't understand what does it mean.
[12:51:42] <aharoni>	 Why is the word "in" used there?
[12:54:11] <aharoni>	 GerardM-: would you know? ^
[12:54:23] <Adrian_WMDE>	 aharoni: That's the unit of the value
[12:54:52] <GerardM->	 huh ?
[12:54:57] <aharoni>	 well yeah, but it doesn't make much sense to me.
[12:55:15] <JeroenDeDauw>	 addshore: REVIEEEEEEEEEEEEEEEEEEEEEEEEW ;p
[12:57:22] <aharoni>	 "point in time: in 1 million years"
[12:57:22] <aharoni>	 what does it mean?
[12:57:22] <aharoni>	 If I have to guess, than I would say that it refers to some time around year 1002014 CE, but I feel that this is not the intention.
[12:57:56] <aharoni>	 and why is there a full stop in "1. millennium"?
[13:01:35] <Adrian_WMDE>	 aharoni: Well, you have a value, and you know it for a precision of a million years, so you specify it 'in [the unit of a] million years'
[13:01:59] <Adrian_WMDE>	 And "1. millenium" is the first millenium, right?
[13:02:37] <aharoni>	 this may mean "the first millennium" in German, but I'm not sure that the full stop is used in this way in English.
[13:03:30] <aharoni>	 When I see "1" in English, I think "one", not "first". (I am not a native English speaker, but I suspect that I'm not the only one who feels this way.)
[13:04:15] <aharoni>	 Maybe saying something like "1 millennium CE" would make it clearer, and it would be even better to say "between 1 CE and 1000 CE".
[13:05:23] <aharoni>	 And about 'in [the unit of a] million years' - what actually appears on the screen is "point in time: in 1 million years", and it doesn't really convey this meaning.
[13:05:32] <aharoni>	 GerardM-, do you agree? :)
[13:06:25] <GerardM->	 I do agree that it is neither clear not obvious
[13:06:34] <Adrian_WMDE>	 I agree, too
[14:46:00] <github-wmde>	 01[13ValueView01] 15snaterlicious created 06listrotatorrtl (+1 new commit): 02http://git.io/EodLxQ
[14:46:00] <github-wmde>	 13ValueView/06listrotatorrtl 148b5f74e 15snaterlicious: Improved $.ui.listrotator's RTL detection
[14:47:49] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher)
[14:48:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher)
[14:49:36] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#8 (newcomponents - 1b1af7b : jeroendedauw): The build was broken.
[14:49:36] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/7158e043c954...1b1af7bff9ea
[14:49:36] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18274934
[14:52:45] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#10 (newcomponents - 66f3d41 : jeroendedauw): The build is still failing.
[14:52:45] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/1b1af7bff9ea...66f3d4155489
[14:52:45] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18275116
[14:59:20] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#12 (newcomponents - 35c3014 : jeroendedauw): The build is still failing.
[14:59:20] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/66f3d4155489...35c30146f119
[14:59:20] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18275790
[15:02:06] * JeroenDeDauw  blames addshore

[15:04:45] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#14 (newcomponents - 190a4e8 : jeroendedauw): The build is still failing.
[15:04:45] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/35c30146f119...190a4e8db0c2
[15:04:45] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18276140
[15:16:15] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#16 (newcomponents - 0636402 : jeroendedauw): The build is still failing.
[15:16:15] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/190a4e8db0c2...06364021a905
[15:16:16] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18276786
[15:20:53] <github-wmde>	 [13Time] 15addshore closed pull request #1: Time parser (06master...06timeParser) 02http://git.io/wl5V6g
[15:26:09] <hoo>	 Lydia_WMDE: Did someone create the branch now?
[15:27:23] <Lydia_WMDE>	 hoo: will do tomorrow it seems
[15:27:29] <hoo>	 Lydia_WMDE: Yikes...
[15:27:41] <Lydia_WMDE>	 ?
[15:27:56] <hoo>	 isn't that maybe a bit short sighted if we want to also deploy tomorrow
[15:28:05] <aude>	 deploy?
[15:28:08] <aude>	 branch?
[15:28:09] <Lydia_WMDE>	 no
[15:28:11] <hoo>	 aude: \o/
[15:28:14] <Lydia_WMDE>	 branch and deploy to test
[15:28:23] <aude>	 ok, on thursday
[15:28:30] <aude>	 which is tomorrow
[15:28:36] <hoo>	 Lydia_WMDE: mh... deploy calendar has no date for Wikdata deploy :/
[15:28:37] * aude  slightly confused

[15:28:41] <hoo>	 So I assumed also tomorrow
[15:28:45] <hoo>	 aude: +1
[15:28:46] <Lydia_WMDE>	 ah
[15:28:54] <Lydia_WMDE>	 yeah we need to clean that up tomorrow
[15:29:37] <hoo>	 aude: In Berlin now?
[15:29:53] <aude>	 yep
[15:30:09] <hoo>	 flew from Frankfurt to Berlin?
[15:30:21] <aude>	 yep
[15:30:34] <hoo>	 ah, that's faster than taking the train :)
[15:30:41] <aude>	 it is :)
[15:32:14] <hoo>	 DanielK_WMDE: hi... got time to have a look at the Lua things?
[15:34:07] <github-wmde>	 01[13Time01] 15addshore 04force-pushed 06timeParser from 1429f49e6 to 14492a976: 02http://git.io/TWCs7w
[15:34:07] <github-wmde>	 13Time/06timeParser 14492a976 15addshore: Implement basic TimeParser and Tests
[15:39:48] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#19 (newcomponents - 7393051 : jeroendedauw): The build has errored.
[15:39:48] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/06364021a905...7393051a9fff
[15:39:48] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18278102
[15:44:27] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#20 (newcomponents - ef1830e : jeroendedauw): The build has errored.
[15:44:27] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/7393051a9fff...ef1830efa8c6
[15:44:27] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18278532
[15:50:14] <grrrit-wm>	 (03PS3) 10Thiemo Mättig (WMDE): Avoid showing "null" in JavaScript tooltip for properties with no label. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 
[15:50:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Avoid showing "null" in JavaScript tooltip for properties with no label. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE))
[15:54:27] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "Looks fine, will test it a bit and merge" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106905 (owner: 10Hoo man)
[15:54:57] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#22 (newcomponents - 168495b : jeroendedauw): The build passed.
[15:54:57] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/ef1830efa8c6...168495b52cf6
[15:54:57] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18279280
[15:56:00] <hoo>	 DanielK_WMDE: At best take a look at the integration tests (last on the stack)...
[15:56:29] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE))
[16:25:40] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "looks fine, jens approves, will test manually" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man)
[16:32:45] <github-wmde>	 01[13Time01] 15addshore 04force-pushed 06timeParser from 14492a976 to 14097147c: 02http://git.io/TWCs7w
[16:32:45] <github-wmde>	 13Time/06timeParser 14097147c 15addshore: Implement basic TimeParser and Tests
[16:37:45] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "some minor questions left" (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 (owner: 10Hoo man)
[16:53:09] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] "works" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106905 (owner: 10Hoo man)
[16:53:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor the PHP part of the Lua library [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106905 (owner: 10Hoo man)
[16:57:48] <DanielK_WMDE>	 hoo: uh, if i do local entity = bla.getEntityObject(), how do i get the list of claims?
[17:09:59] <github-wmde>	 [13WikibaseDataModelSerialization] 15JeroenDeDauw closed pull request #7: Fix DeserializerBaseTest namespace (06master...06fixDeserialiserTestBaseNamespace) 02http://git.io/WGj7tw
[17:11:00] <github-wmde>	 01[13WikibaseDataModelSerialization01] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/gnc0fQ
[17:11:00] <github-wmde>	 13WikibaseDataModelSerialization/06master 1450547cf 15Jeroen De Dauw: Update .travis.yml
[17:12:55] <github-wmde>	 01[13WikibaseDataModelSerialization01] 15JeroenDeDauw pushed 3 new commits to 06master: 02http://git.io/dzZlzQ
[17:12:55] <github-wmde>	 13WikibaseDataModelSerialization/06master 1443cbff6 15Tpt: Adds qualifiers serialization in claims
[17:12:55] <github-wmde>	 13WikibaseDataModelSerialization/06master 143efe3c6 15Tpt: Fix typo
[17:12:55] <github-wmde>	 13WikibaseDataModelSerialization/06master 147f131aa 15Jeroen De Dauw: Merge pull request #8 from Tpt/qualifiers...
[17:15:49] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] Introduce mw.wikibase.entity Lua library (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man)
[17:54:16] <grrrit-wm>	 (03PS4) 10Thiemo Mättig (WMDE): Avoid showing "null" in JavaScript tooltip for properties with no label. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 
[18:00:22] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE))
[18:17:19] <hoo>	 DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/107206/18/client/includes/scribunto/mw.wikibase.lua did mw.wikibase.getEntity work for you in that case?
[19:03:25] <benestar>	 hoo: hi :)
[19:04:56] <hoo>	 hi benestar
[19:05:09] <hoo>	 wanted to ping you about the hook thingy
[19:05:17] <benestar>	 hoo: me too ;)
[19:05:23] <benestar>	 do we need the title of the page?
[19:05:25] <hoo>	 heh :)
[19:05:44] <hoo>	 I guess so... have you yet prototyped the implementation in Wikibase?
[19:06:02] <hoo>	 I doubt you'll be able to do that in a sane way without knowing the title
[19:06:55] <benestar>	 hoo: I also thought so but maybe the langlinktitle would be enough
[19:07:03] <benestar>	 however, I will add the title, will make things easier
[19:07:16] <benestar>	 and more useful for other usecases
[19:07:30] <hoo>	 benestar: Certainly... you wanted to look up the item for every link then...? That sounds horrible, tbh... rather use the title
[19:07:42] <benestar>	 hehe, you're right :)
[19:08:18] <hoo>	 :)
[19:08:18] <benestar>	 hoo: the title as second or third parameter?
[19:09:58] <hoo>	 benestar: mh... last one, I'd say... not sure we have a convention for that
[19:10:27] <hoo>	 aude: Around?
[19:12:52] <benestar>	 hoo: I've submitted another patch set
[19:13:11] * hoo  clicks

[19:14:50] <hoo>	 benestar: mh... the documentation could be a bit clearer... "Title of the page" ... which page?
[19:14:59] <benestar>	 hoo: the current page?
[19:15:10] <benestar>	 the page the link belongs to?
[19:15:17] <hoo>	 Would be nice if you could denote that $languageLinkTitle isn't a local title
[19:15:28] <hoo>	 benestar: Yep, that's about ok :)
[19:15:56] <benestar>	 hoo: isn't language link clear enough?
[19:16:13] <hoo>	 benestar: Probably, but as you're already amending ;)
[19:16:27] <benestar>	 ;)
[19:17:30] <benestar>	 hoo: maybe "Title of the external language link"
[19:18:16] <hoo>	 benestar: Title object belonging to the external ...
[19:18:30] <benestar>	 lol
[19:18:32] <benestar>	 ok
[19:18:46] <hoo>	 benestar: People assume the craziest things -.- ;)
[19:28:52] <benestar>	 hoo: finally, that's also fixed
[19:29:00] <benestar>	 so ready to get merged?!
[19:31:25] <hoo>	 benestar: Probably... if you can upload the Wikibase side of the patches, that would easy reviewing and testing ;)
[19:31:55] <benestar>	 hoo: how can it be tested then?
[19:31:59] <benestar>	 if it isn't on master
[19:32:47] <hoo>	 benestar: Just pull in both changes and test ;
[19:32:50] <hoo>	 * ;)
[19:32:59] <benestar>	 hoo: ah, ok
[19:40:10] <grrrit-wm>	 (03CR) 10Hoo man: "I tried very hard, but I couldn't reproduce... can you please ping me on IRC so that we can walk through it together?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man)
[19:44:02] <benestar>	 hoo: when to use wfProfileIn ?
[19:44:07] <benestar>	 just saw it
[19:45:20] <hoo>	 benestar: When you want to have a piece of code in the performance profiling (or someone else could want that): wrap it in wfProfileIn( __METHOD__ ); /* your code here... */ wfProfileOut( __METHOD__ );
[19:45:30] <hoo>	 There's probably more about that on mediawiki.org
[19:46:06] <benestar>	 hoo: when should I add it?
[19:46:11] <benestar>	 is it needed for the hook?
[19:46:37] <hoo>	 benestar: You mean the Wikibase side hook handler? Might be a good idea
[19:46:47] <benestar>	 ok
[19:46:52] <benestar>	 hoo: another question
[19:47:02] <benestar>	 we call the hook again for every language link
[19:47:07] <hoo>	 Yep
[19:47:13] <benestar>	 should we store the sitelinks anywhere?
[19:47:34] <benestar>	 because otherwise we would have to query everytime again
[19:48:20] <hoo>	 benestar: mh... just find out what seems smart about caching
[19:48:28] <hoo>	 not sure without knowing your implementation
[19:48:44] <benestar>	 hoo: so you cannot help me if I should reuse LangLinkHandler?
[19:49:00] <benestar>	 aude: around?
[19:49:26] <hoo>	 Why would you need that?
[19:51:14] <hoo>	 benestar: ^
[19:51:38] <benestar>	 hoo: it also queries sitelinks from repo
[19:54:11] <hoo>	 benestar: Just get the entity via a SiteLinkLookup instance
[19:54:19] <benestar>	 ah, great :)
[19:56:54] <hoo>	 I wonder whether https://www.wikidata.org/w/index.php?title=User:Yair_rand/checksitelinks.js still works or is even useful
[20:02:19] <benestar>	 hoo: should I create a new class for the badge feature?
[20:02:30] <benestar>	 or may I add the code into the function directly?
[20:03:09] <hoo>	 benestar: You should create a hook handler function
[20:03:17] <benestar>	 hoo: I have already
[20:03:22] <hoo>	 :)
[20:03:25] <benestar>	 I am not so stupid :P
[20:03:59] <hoo>	 benestar: Well, we used to not do that for a very long time
[20:04:13] <hoo>	 we only have two of these in client I think :P Most us the old static style
[20:04:25] <benestar>	 oh, so I misunderstood you
[20:04:27] <hoo>	 oh, I meant hook handler class
[20:04:28] <hoo>	 m(
[20:04:37] <hoo>	 ^-- self-facepalm, that
[20:04:39] <hoo>	 is
[20:04:44] <benestar>	 lol, I haven't created that ;)
[20:05:17] <benestar>	 hoo: so I should create a new class?
[20:05:31] <hoo>	 benestar: Yep
[20:05:46] <hoo>	 have a look at client/includes/hooks/
[20:06:29] <benestar>	 hoo: but where are they added in the WikibaseClient.php file?
[20:06:43] <hoo>	 just like normal hooks
[20:06:53] <hoo>	 look at WikbaseClient.hooks.php
[20:07:29] <benestar>	 hoo: but there is still code in WikibaseClient.hooks.php
[20:07:38] <hoo>	 Yep, that's unavoidable
[20:08:03] <hoo>	 Just what is needed to get a new instance of hte hook handler class
[20:08:40] <benestar>	 hoo: what name for the class?
[20:08:48] <benestar>	 LanuageLinkBadgeHandler?
[20:10:01] <hoo>	 why not, yes
[20:16:02] <benestar>	 hoo: may I store the site links in a static variable in the function?
[20:17:16] <hoo>	 benestar: You can cache statically, but please do so by Entity
[20:17:30] <benestar>	 hoo: ?
[20:17:56] <hoo>	 $fooCache['Q123456789'] = canIhazSomeData();
[20:18:15] <benestar>	 hoo: can we have several entities getting involved?
[20:19:04] <hoo>	 benestar: Probably that wont happen in "usual" operation, but might during unit tests or maintenance script runs or whatever
[20:19:20] <benestar>	 hoo: can I also use the title as key?
[20:19:28] <benestar>	 that would save us another lookup
[20:19:58] <hoo>	 it wouldn't... $entity->getId()->getSerialization();
[20:20:03] <hoo>	 don't like that
[20:20:11] <hoo>	 rather use the entity id
[20:20:35] <benestar>	 hoo: so one lookup for every language link...
[20:21:32] <hoo>	 benestar: I'm pretty sure that's cached anyway
[20:21:38] <hoo>	 in the entitylookup
[20:21:43] <hoo>	 * sitelinklookup
[20:21:49] <hoo>	 you might want to verify it though
[20:23:28] <hoo|away>	 away for some time... getting food
[20:24:39] <benestar>	 hoo|away: wait
[20:24:50] <benestar>	 we even don't need to save the sitelinks
[20:24:53] <benestar>	 they are also cached ;)
[20:52:34] <hoo>	 hah :) nice
[21:09:55] <benestar>	 hoo: maybe we should save the sitelinks in a variable anyway=
[21:09:57] <benestar>	 ?
[21:10:33] <hoo>	 benestar: Not sure... this has to scale up to maybe 250 calls, that's the most that hook will get
[21:11:02] <benestar>	 hoo: ok, I will create the static variable because we need exactly the same data again
[21:11:51] <hoo>	 benestar: Ok, might be better to just get it to work now and peformance optimize in code review...
[21:12:02] <hoo>	 might be that you have to change all that again anyway
[21:18:10] <benestar>	 hoo: oh no :(
[21:18:16] <benestar>	 SimpleSiteLink objects returned from this method will not contain badges!
[21:18:30] <benestar>	 we cannot use getSiteLinksForItem
[21:50:33] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111601 (owner: 10L10n-bot)
[22:02:58] <benestar>	 hoo: just submitting a patch
[22:03:32] <benestar>	 Lydia_WMDE: badges are coming closer :)
[22:03:45] <sjoerddebruin>	 BADGES!?!
[22:03:45] <Lydia_WMDE>	 \o/
[22:03:47] <sjoerddebruin>	 :D
[22:04:03] <grrrit-wm>	 (03PS1) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[22:04:12] <benestar>	 only the ui on repo is not started yet
[22:04:25] <sjoerddebruin>	 :(
[22:04:30] <hoo>	 benestar: Will you be working on that?
[22:04:50] <benestar>	 hoo: I'd have to investigate how the ui works
[22:05:10] <hoo>	 That's a little scary, actually... at least not easy to get through
[22:05:16] <benestar>	 it isn't the clearest part of wikibase to me
[22:05:35] <benestar>	 hoo: I think the team is currently rewriting the js part?
[22:06:05] <hoo>	 Not rewriting, but parts are getting overhauled, especially with performance in mind
[22:06:13] <hoo>	 also there's an UI redesign in process
[22:07:18] <sjoerddebruin>	 hoo: nice.
[22:07:38] <benestar>	 hoo: other topic, I try to write tests
[22:07:40] <benestar>	 :P
[22:08:03] <hoo>	 phpunit ones?
[22:08:03] <benestar>	 why is Q4880 always linking to dewiki:New Amsterdam?
[22:08:07] <benestar>	 yes
[22:08:16] <benestar>	 MovePageNoticeTest assumes taht
[22:08:19] <benestar>	 *taht
[22:08:20] <benestar>	 *that
[22:09:14] <hoo>	 benestar: It's mocking that, so nothing's leaking state there AFAIS
[22:09:20] <hoo>	 that's fine
[22:09:47] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[22:09:54] <benestar>	 lol :)
[22:10:01] <benestar>	 no tests -> build successful :D
[22:11:54] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "Also needs tests" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[22:12:07] <hoo>	 benestar: And where should the actual items come from?
[22:12:07] <benestar>	 hoo: look at commit message :P
[22:12:13] <hoo>	 Where will the classes be dfined?
[22:12:26] <hoo>	 benestar: Not a reason not to CR ;)
[22:13:07] <benestar>	 hoo: the actual items come from the entityLookup
[22:13:13] <benestar>	 what means defined??
[22:13:53] <hoo>	 benestar: I mean... where will the actual CSS be?
[22:14:02] <benestar>	 hoo: commit message?!
[22:14:24] <benestar>	 "The clients can then add an icon using their local Common.css page."
[22:14:25] <hoo>	 "The clients can then add an icon using their local Common.css page." really?
[22:14:33] <benestar>	 hoo: that's what Daniel suggested
[22:14:41] <benestar>	 in his mail to wikidata-tech
[22:14:57] <hoo>	 mh
[22:15:04] <benestar>	 "I would propose to add a css class for each badge that applies to a given language link. Per default, these classes would do nothing. Each client wiki can then define site CSS (or JS) to make some badges visible."
[22:17:02] <hoo>	 mh
[22:18:06] <hoo>	 I'll take to him about that... I'm not happy with that, but I'm also not sure we can come up with a better thing
[22:26:04] <benestar>	 hoo: how can I construct a test item?
[22:26:19] <hoo>	 benestar: For which use case?
[22:26:31] <benestar>	 hoo: for the getbadges method
[22:26:40] <benestar>	 the entitylookup returns an item
[22:26:59] <hoo>	 just mock entitylockup
[22:27:07] <hoo>	 * look :P
[22:27:57] <benestar>	 hoo: doing so
[22:28:02] <benestar>	 I mean construct it in php
[22:28:10] <benestar>	 but I already see ;)
[22:51:19] <grrrit-wm>	 (03PS2) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[22:51:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[22:52:19] <hoo>	 "private static ...." you don't need these
[22:52:41] <hoo>	 just create a function getLangueLinkHandler that does all the mocking
[22:52:46] <hoo>	 benestar: ^
[22:53:08] <benestar>	 hoo: hmm, good idea
[22:53:10] <benestar>	 thx
[22:57:04] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[23:01:15] <grrrit-wm>	 (03PS3) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[23:04:32] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] Insert badges for language links on client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[23:07:02] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)