[08:46:41] * hashar is upgrading Jenkins ... Half an hour downtime. [10:12:20] (03CR) 10Daniel Kinzler: [C: 032] Bad auto-summary when using the "wblinktitles" API call (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112933 (owner: 10Thiemo Mättig (WMDE)) [10:12:43] (03Merged) 10jenkins-bot: Bad auto-summary when using the "wblinktitles" API call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112933 (owner: 10Thiemo Mättig (WMDE)) [10:12:57] Lydia_WMDE: got a few minutes? [10:14:35] there is no lydia yet [10:15:01] hm, ok [10:15:06] aude: i just merged https://gerrit.wikimedia.org/r/#/c/108333/ [10:15:45] i don't quite remember, but i think it should make the JS config patch a bit simpler [10:16:09] hmmm, ok [10:16:13] i'll go over that one again now. [10:17:00] OK [10:17:03] ok* [10:48:28] uh, daily? [10:48:47] Tobi_WMDE, Lydia_WMDE, aude: i'm in the hangout [10:52:25] ok [10:52:27] [13ValueView] 15thiemowmde opened pull request #23: Arrow images are backwards in source header (06master...06toggler-rtl) 02http://git.io/FnOXYg [10:57:33] (03CR) 10Daniel Kinzler: "Should be adopted to new core features, but looks fine overall." (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [10:59:53] Change on 12meta_wikimedia a page Wikidata was modified, changed by 130.88.141.34 link https://meta.wikimedia.org/w/index.php?diff=7526031 edit summary: [-3] fixing dead link [11:04:55] Lydia_WMDE: hangout got stuck, but I guess we were mostly done anyway. Let me know when you got a few minutes, I'd like to discuss a couple of prioritites with you. [11:08:20] DanielK_WMDE: now is good :) [11:18:57] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=46160 [11:36:45] [13WikibaseDatabase] 15addshore 04force-pushed 06addshoreExpansion from 14a5c7c77 to 14c5def19: 02http://git.io/VC85uQ [11:36:45] 13WikibaseDatabase/06addshoreExpansion 14c5def19 15addshore: Cleanup and improve tests... [11:44:42] hoo|away: replied there [12:33:55] (03CR) 10Thiemo Mättig (WMDE): Bad auto-summary when using the "wblinktitles" API call (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112933 (owner: 10Thiemo Mättig (WMDE)) [12:40:34] Lydia_WMDE: Why do we have 2 wikidata channels again? [12:43:58] oh .. there is 2? Am I lurking in the right one then ? :D [12:44:30] Yes, you are [12:44:43] cool :) [12:44:51] Looks like the onwiki admins haven't been made admins here so I can't forward the other channel to here [12:45:35] Lydia_WMDE: You should make #wikimedia-wikidata invite online + forward to this channel and than kick everyone, see http://toxin.jottit.com/freenode_channel_modes for modes [12:46:41] multichill: that should already be the case for a long time [12:47:02] if not something broke [12:47:12] it definitely worked when we switched [12:47:29] Nope, the mode is +mnt [12:47:45] It was still in my favorites so I stumbled into the wrong channel [12:47:55] * aude got kicked out [12:47:58] but can join again now [12:48:17] no idea how to fix [12:48:41] Barras: Barras2: can you please have a look at the mode settings for #wikimedia-wikidata? it seems it is no longer forwarding to here as it should : [12:48:46] thanks :) [13:00:32] Lydia_WMDE: I see you brought up the whole user interface design part. Imho property pages (like https://www.wikidata.org/wiki/Property:P197 ) should be (re)designed focused on the reader/casual editor of Wikidata [13:01:38] multichill: please put stuff on the wiki page :) that's the only way things don't get lost [13:02:21] Is that in scope? I added an option to add things to property pages (see for example https://www.wikidata.org/w/index.php?title=Property:P492) but never came around to setting up an rfc on how to use that [13:02:52] there is no need for a rfc on this [13:03:27] and yeah it is in scope [13:03:45] What was the page again? [13:04:03] * multichill is working through a month of emails [13:04:59] https://www.wikidata.org/wiki/Wikidata:UI_redesign_input [13:15:11] ty, left a note [13:23:32] (03CR) 10Daniel Kinzler: [C: 032] Turn off translation of time precisions in backend [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112473 (owner: 10Addshore) [13:23:58] (03Merged) 10jenkins-bot: Turn off translation of time precisions in backend [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112473 (owner: 10Addshore) [13:25:14] addshore: "in $1 million years".... how does that work for dates in the past? [13:25:52] we'll probably need separate messages for past and future, right? [13:34:48] DanielK_WMDE: we have a discussion item for that on the board [13:35:05] but didn't want to block the time stuff even more [13:39:24] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Implement TimeParsers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [13:56:32] (03CR) 10Daniel Kinzler: [C: 04-1] Implement TimeParsers (0326 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [13:59:04] (03CR) 10Aude: Implement TimeParsers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:02:00] JeroenDeDauw: if you saw this diff between two objects would you say phpunit should detect them as equal? http://www.diffchecker.com/z72xj5vs [14:03:43] (03CR) 10Daniel Kinzler: [C: 04-1] Check for conflicts in ChangeOpsMerge preSave (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [14:04:11] addshore: the order of the indexes array is different [14:04:28] [13WikibaseDatabase] 15addshore pushed 2 new commits to 06addshoreExpansion: 02http://git.io/GsIfVQ [14:04:28] 13WikibaseDatabase/06addshoreExpansion 14f3705a9 15addshore: Implement TypeDefinition... [14:04:28] 13WikibaseDatabase/06addshoreExpansion 140653e22 15addshore: Add support for VARCHAR type in mysql & sqlite [14:07:44] JeroenDeDauw: thats just stupid! [14:07:46] :> [14:13:03] (03CR) 10Daniel Kinzler: Inject Guid Validator and Parser in ChangeOpClaim (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [14:15:30] [13WikibaseDatabase] 15addshore 04force-pushed 06addshoreExpansion from 140653e22 to 1448f1c8b: 02http://git.io/VC85uQ [14:15:30] 13WikibaseDatabase/06addshoreExpansion 1448f1c8b 15addshore: Add support for VARCHAR type in mysql & sqlite [14:21:28] (03PS2) 10Thiemo Mättig (WMDE): Encode URL parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112348 (owner: 10Gerrit Patch Uploader) [14:25:42] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Our documentation still mentions MediaWiki 1.21.0. The second parameter in getUrl( str, params ) did not existed in 1.21.0. Also the patch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112348 (owner: 10Gerrit Patch Uploader) [14:27:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112348 (owner: 10Gerrit Patch Uploader) [14:28:49] (03CR) 10Daniel Kinzler: "Depends on a Scribunto patch that has been abandoned. What's the status here?" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [14:52:18] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I agree there is a problem with the messages, e.g. "in ... years" should probably be "in the year ..."." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:54:16] (03CR) 10Addshore: Implement TimeParsers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:55:13] [travis-ci] wmde/WikibaseQueryEngine#4 (addshoreChanges - 2155ec8 : addshore): The build has errored. [14:55:14] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/commit/2155ec8a32a0 [14:55:14] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19041633 [15:02:13] DanielK_WMDE: my mind is sturggling to understand https://www.mediawiki.org/wiki/Extension:Wikibase_QueryEngine/SQL_schema_proposal >.> [15:03:01] meh, just saw the bit I was missing,.... [16:05:33] (03PS7) 10Daniel Kinzler: Refactor caching for EntityRevisionLookup service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 [16:05:55] (03CR) 10Daniel Kinzler: "done" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 (owner: 10Daniel Kinzler) [16:06:01] (03PS8) 10Daniel Kinzler: Refactor caching for EntityRevisionLookup service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 [16:13:04] (03PS7) 10Daniel Kinzler: Introducing WikiPageEntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 [16:14:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 (owner: 10Daniel Kinzler) [16:18:59] addshore: "Addshore expansion"? :) [16:19:13] you are expanding? cause of all the bbq sauce? [16:20:54] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: This does not need to be updated. And if you do, then the sentence above it should also be updated. 02http://git.io/AOhswA [16:21:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 (owner: 10Daniel Kinzler) [16:25:01] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: I'd rather wait with releasing 0.2 and first do some testing though usage via other components. In particular for the SQL builders I added. You can specify a dev branch as done [here](https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/composer.json#L47-51) or make a beta tag and then ref the tag or branch from query engine. 02http://git.io/n84VUA [16:26:11] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: type hint? 02http://git.io/eY9Yig [16:26:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 (owner: 10Daniel Kinzler) [16:28:02] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: type hint? 02http://git.io/xNcw8Q [16:29:40] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: minor style note: these two private methods make more sense right under the constructor 02http://git.io/ge7btg [16:30:15] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: int|self::NO_SIZE? We do not want people to actually check for null 02http://git.io/W3K5Wg [16:30:30] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: Same here 02http://git.io/loBteQ [16:33:02] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: Missing type hint. Though you could accept both an instance of TypeDefinition or simply the type name, and feed that to the TypeDefinition constructor, as it is the only required arg anyway. Then you'd not have to modify the tests as done now, which in some places is rather silly. 02http://git.io/oXoelQ [16:34:50] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: ohibid? what? :) 02http://git.io/VmpsmQ [16:36:18] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 14432f919: FieldDefinition? 02http://git.io/Rbw-Kg [16:37:08] addshore: looks mostly good [16:39:07] I started changing the QueryEngine stuff and now looks like I have one or two more things to poke in Database [16:47:58] (03CR) 10Jeroen De Dauw: Inject Guid Validator and Parser in ChangeOpClaim (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [17:30:09] Tobi_WMDE: Abraham_WMDE: this is interesting https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/201 [17:30:41] I'm expecting James to poke at getting such a thing up and running on TravisCI [17:30:51] JeroenDeDauw: cool, thx [17:54:02] (03PS1) 10Thiemo Mättig (WMDE): Don't display Babel-0 languages the user doesn't understand [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113799 [17:57:47] Noooooo — I want to be able to add names even in languages I don’t understand :-( [17:58:07] (03CR) 10Lydia Pintscher: [C: 04-2] "People actually explicitly add the -0 babel template to have those languages shown on items. So imho this should not go in." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113799 (owner: 10Thiemo Mättig (WMDE)) [17:58:13] xD [17:59:00] [13WikibaseDatabase] 15addshore 04force-pushed 06addshoreExpansion from 147d147bf to 14eafda57: 02http://git.io/VC85uQ [17:59:00] 13WikibaseDatabase/06addshoreExpansion 14eafda57 15addshore: Read back index size limits [17:59:06] hawke1: hehe just commented before i even saw your comment here [17:59:08] For real: I do like to have access to (mostly) place-names in Japanese and Russian, even though I can’t understand those languages. [18:00:19] addshore: you pick a place on http://www.lieferando.de/ - obviously evil places are not allowed [18:00:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113799 (owner: 10Thiemo Mättig (WMDE)) [18:01:09] what counts as evil JeroenDeDauw ? :) [18:02:58] JeroenDeDauw: their site fails for me >.> [18:03:02] addshore: anything I don't like - doh! [18:04:09] do you like BBQ? :P [18:08:32] (03CR) 10Thiemo Mättig (WMDE): "Ouch. This doesn't make much sense. xx-0 does mean "I don't understand that language at all". Why do you want to see labels you can not un" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113799 (owner: 10Thiemo Mättig (WMDE)) [18:11:06] (03CR) 10Lydia Pintscher: "Basically to add things like names where you know they are the same in that language." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113799 (owner: 10Thiemo Mättig (WMDE)) [18:17:24] addshore: no, so you can have all of it [18:19:30] addshore: so you picking a place? [18:19:39] the website wont work for me JeroenDeDauw :> [18:21:37] addshore: ok, w/e, usual place: http://www.lieferando.de/lieferservice-world-of-pizza-berlin#!cart [18:23:44] addshore: today its your turn to go get the food when its there [18:23:51] :> [18:23:59] Incorrect table definition; there can be only one auto column and it must be defined as a key [18:24:00] :< [19:11:02] [travis-ci] wmde/WikibaseQueryEngine#6 (addshoreChanges - c551244 : addshore): The build has errored. [19:11:02] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/2155ec8a32a0...c5512447d7db [19:11:02] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19058630 [19:30:39] [13WikibaseDatabase] 15addshore comment on pull request #12 14eafda57: done in next patch 02http://git.io/zzNOfQ [19:31:04] [13WikibaseDatabase] 15addshore comment on pull request #12 14eafda57: Done in next commit 02http://git.io/vUxyGg [19:33:49] [13WikibaseDatabase] 15addshore comment on pull request #12 14eafda57: fixed in next commit 02http://git.io/EsLx9A [19:34:19] [13WikibaseDatabase] 15addshore pushed 1 new commit to 06addshoreExpansion: 02http://git.io/cgaA8w [19:34:19] 13WikibaseDatabase/06addshoreExpansion 14c1f435b 15addshore: Many small fixes [19:51:59] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Stop trying to return a void value... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113356 (owner: 10Addshore) [19:59:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/18c1787 : Thiemo Mättig (WMDE) The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/19061416 [20:05:54] addshore: lolwat, why is the cleaning guy turning off the light here? :<0 [20:06:00] :P [20:06:05] he likes doing that xD [20:06:13] maybe he just doesnt see you :P [20:06:18] he left on the light on the wrong side of the room [20:08:35] addshore: ahhhhhh! are you trying to blind me?! [20:08:40] xD [20:08:44] should they both be off? ;p [20:08:53] this is fine [20:10:36] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: Please replace the two "changed to FieldDefiniton" with "TypeDefinition". 02http://git.io/bbFFWA [20:20:20] addshore: this was definitly easier to understand https://github.com/wmde/WikibaseQueryEngine#sqlstore-internal-structure ;p [20:20:52] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: stristr() is checking a haystack for a needle. Are you sure you want something like "varcharblobint" to return TYPE_BLOB? I guess att stristr() should be replaced with strcasecmp() or with a single switch( strtolower( $type ) ) { ... instead of the if ( ... ) { ... 02http://git.io/XJPh8Q [20:24:11] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: What's "subPart"? Sorry, but this doesn't sound like a good name for a method, even if it's private. Also there is a space missing. ;-) 02http://git.io/bbWlEw [20:27:24] addshore: you there? i'm struggeling with testBug58394SpecifiedIndexOutOfBounds [20:27:36] i'm failing to understand how that test ever worked :) [20:30:21] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: Shorthand for [^ \s] is \S. Also you could replace every space with \s+ to make this parser a little bit more flexible (will ignore multiple spaces and unwanted line breaks then). 02http://git.io/__DVOQ [20:34:29] [13WikibaseDataModelSerialization] 15Tpt opened pull request #22: Adds an EntityIdDeserializer as wrapper to EntityIdParser (06master...06EntityId) 02http://git.io/7yc-zw [20:34:59] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: Why the question mark? Why are there two identical methods (except for the question mark)? 02http://git.io/VelokQ [20:36:27] DanielK_WMDE: what appears to be the issue? [20:37:15] addshore: P1 and P" are hardcoded. there's no guarantee that they exiswt, and the call will fail if they don't. [20:37:19] *P2 [20:37:44] i'm seeing a couple more tests failing for simmilar reasons. i wonder why jenklins hasn't complained [20:37:46] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: Should be the exact same regex as in the getTypeSize() call(s) above. Something like /^\w+(\(\d+\))?$/. 02http://git.io/TV2Uwg [20:44:01] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: Probably bad "Name" vs. "Type" vs. "Field" mixture here. Judging from the line above all "type(s)" should be replaced with "name". And the comment be dropped. 02http://git.io/NZefnw [20:46:41] [13WikibaseDatabase] 15thiemowmde comment on pull request #12 1455e573b: You know AUTO_INCREMENT doesn't work like that on most SQL servers except for MySQL and SQLite? 02http://git.io/Duut9Q [20:49:07] (03PS8) 10Daniel Kinzler: Introducing WikiPageEntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 [20:52:14] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 (owner: 10Daniel Kinzler) [20:57:55] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113867 (owner: 10L10n-bot) [20:58:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e781e42 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/19065141 [20:58:16] [13WikibaseDataModelSerialization] 15Tpt opened pull request #23: Adds beginning of Entity and Property serialization (06master...06EntitySerializer) 02http://git.io/-RBZvA [21:25:10] (03PS9) 10Daniel Kinzler: Introducing WikiPageEntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 [21:31:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 (owner: 10Daniel Kinzler) [23:12:15] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #12 1455e573b: That is not really relevant for this commit. Though if you have a suggestion of how this could be better implemented, I'd love to hear it. 02http://git.io/J5Xhdg [23:20:45] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #22 143dde975: If you have multiple uses for asserting that something is a string, you can do something like this. You can even do it if you have just one, and want to throw a specific error message. In the later case you cannot give it a generic name though. assertEntityIdIsString would be better 02http://git.io/P0jtUw [23:23:56] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #22 143dde975: In this case I'd actually do the deserialization and throw a try catch around it. Not so nice to have a serializer that returns true on isDeserializerFor for all strings. 02http://git.io/TAAaZw [23:48:39] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #22 143dde975: It is somewhat nicer to create a stub or simple fake. Now it is also testing BasicEntityIdParser and is bound to it, while the class under test is not. 02http://git.io/FbtOLw [23:49:38] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #23 1463bd89f: 0.1 02http://git.io/lfBetw [23:59:30] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #23 1463bd89f: Not happy with this subclass thing. How about having this in a simple class that does not derive from anything and is not derived from? 02http://git.io/44sXBw