[10:04:34] [13DataValuesJavascript] 15adrianlang created 06dontRegisterStringFormatter (+1 new commit): 02http://git.io/ke2nXA [10:04:34] 13DataValuesJavascript/06dontRegisterStringFormatter 14f64f2a6 15Adrian Lang: Don't register StringFormatter in mw.ext.valueFormatters [10:05:37] [13DataValuesJavascript] 15adrianlang 04force-pushed 06dontRegisterStringFormatter from 14f64f2a6 to 14b82ec22: 02http://git.io/yus0hQ [10:05:37] 13DataValuesJavascript/06dontRegisterStringFormatter 14b82ec22 15Adrian Lang: Don't register StringFormatter in mw.ext.valueFormatters [10:06:03] [13DataValuesJavascript] 15adrianlang opened pull request #32: Don't register StringFormatter in mw.ext.valueFormatters (06master...06dontRegisterStringFormatter) 02http://git.io/mzehhg [10:12:13] [13DataValuesJavascript] 15adrianlang created 06updateValueFormatterDoc (+1 new commit): 02http://git.io/0sUa_A [10:12:13] 13DataValuesJavascript/06updateValueFormatterDoc 14d1cb3d4 15Adrian Lang: Update documentation of ValueFormatter::format [10:12:28] [13DataValuesJavascript] 15adrianlang opened pull request #33: Update documentation of ValueFormatter::format (06master...06updateValueFormatterDoc) 02http://git.io/pYGFJQ [10:34:33] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/pyx0fw [10:34:33] 13puppet-builder/06master 147e948cb 15addshore: move location of log file [10:36:13] (03PS15) 10Daniel Kinzler: (bug 62211) Refactoring EditEntity to use EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 [10:36:21] (03PS1) 10WikidataBuilder: New Wikidata Build - 06/03/2014 10:36 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117170 [10:36:23] (03PS3) 10Daniel Kinzler: (bug 61911) use localized number patterns. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 [10:36:51] (03CR) 10Tobias Gritschacher: [C: 04-1] "by comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [10:45:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [10:45:46] [13DataValuesJavascript] 15JeroenDeDauw comment on pull request #32 14b82ec22: What? You cannot have two releases without a date... 02http://git.io/LfSM9w [10:46:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [10:47:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117170 (owner: 10WikidataBuilder) [10:58:28] [13DataValuesJavascript] 15adrianlang comment on pull request #32 14b82ec22: This is a breaking change and 0.3.2 is not yet released. Probably we want to release 0.3.2 before merging this. 02http://git.io/Mttt8A [11:05:40] [13DataValuesJavascript] 15JeroenDeDauw comment on pull request #32 14b82ec22: Right. Either release that or create a new dev branch - one cannot have two dev versions on the same branch 02http://git.io/47QdEg [11:06:46] Thiemo_WMDE: I can haz review https://github.com/wmde/WikibaseInternalSerialization/pulls [11:07:07] I will have a look... [11:09:03] addshore: what where those fields? [11:09:15] the statement rank one and eentity_type [11:11:51] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/1NBIMg [11:11:51] 13WikibaseDatabase/06master 1494b0009 15Jeroen De Dauw: Update .travis.yml [11:13:00] (03CR) 10Aude: Add {{REPONAME}} magic word, remove references to Wikidata (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [11:18:25] [travis-ci] wmde/WikibaseQueryEngine#26 (addshoreChanges - 2a5c250 : jeroendedauw): The build is still failing. [11:18:25] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/0fb803743fdf...2a5c250b33aa [11:18:25] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/20201251 [11:20:25] [travis-ci] Wikidata-lib/PropertySuggester/travis_db_debug/7fb5833 : Tobias Gritschacher The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20201449 [11:22:23] [travis-ci] Wikidata-lib/PropertySuggester/travis_db_debug/02ce3c6 : Tobias Gritschacher The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20201506 [11:22:31] addshore: oh my - I added the fields to the schema but not to the actual store ... must have been sleeping [11:31:52] [13Number] 15brightbyte comment on pull request #2 140b644b8: We already dicussed this yesterday, but for the record:... 02http://git.io/zNBxaQ [11:39:54] [13WikibaseInternalSerialization] 15thiemowmde comment on pull request #3 1485fb0cd: Duplicate is_array check. Probably a matter of personal preference. I would switch this and do... 02http://git.io/KLKOTw [11:39:55] (03PS13) 10Daniel Kinzler: (bug 40157) store entity status in page_props [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [11:40:48] aude: could you have a look at this? ---^ [11:41:13] maybe after lunch [11:42:39] DanielK_WMDE: what's the status of https://bugzilla.wikimedia.org/show_bug.cgi?id=58032 ? [11:43:43] [13WikibaseInternalSerialization] 15thiemowmde comment on pull request #3 1485fb0cd: I know this is good design. But I don't really like the fact that this loops the array twice. Do you think the time needed for the extra loop will always be negligible? 02http://git.io/whb3pQ [11:45:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [11:47:04] aude: i have agreed on a plan with tim, see the last comment. i proposed it for this sprint, but it didn't make it it. I may have time to work on it anyway, since i already made good progress on the stuff i comitted to. [11:47:47] hm, we may want to change the string values for the item status to integers, though. [11:48:13] addshore: DanielK_WMDE where is this schema doc again? [11:48:17] somewhere on mw org? [11:48:18] right now we have ~8000 rows in page_props [11:48:52] JeroenDeDauw: https://www.mediawiki.org/wiki/Extension:Wikibase_QueryEngine/SQL_schema_proposal [11:48:56] obviously your patch makes it much bigger (though maybe ok without the indexes stuff, but not great perhaps) [11:49:23] aude: since there is no way to query it atm, it's not a problem :) [11:49:39] no way to query? [11:50:20] i'll have ot look at the patch [11:50:32] aude: yes. this patch just makes wikibase write stuff into page_props. it's not used anywhere [11:50:36] (yet) [11:50:54] enwiki has 27 million entries [11:51:09] a lot are from us, i suppose [11:52:09] on the client side, we already use page_props quite a bit, yes [11:52:17] * aude querying [11:52:19] this patch is about using it on the repo, for entirely different stuff [11:53:35] aude: hey :) [11:54:06] DanielK_WMDE: if we're to use the page_props in repo, would be good to have indexes soonish [11:54:16] sure [11:54:16] and would help in clients too, as side effect [11:54:31] only for things that have a numeric value [11:54:58] * aude eat [11:55:08] but it would make it easy to e.g. find items that have a lot of sitelinks, but few statements (or vice versa) [11:56:04] (03PS8) 10Zfilipin: Move BROWSER_TIMEOUT implementation to mediawiki-selenium gem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114454 [11:56:46] Thiemo_WMDE: for your doxygen patch... did you rebase and modify in the same patch set? that makes it very hard for me to see what you actually changed between ps2 and ps3... [11:57:23] aude: Did you make sure that today's MW deploy will also have our new built? [12:01:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114454 (owner: 10Zfilipin) [12:20:59] (03PS9) 10Zfilipin: Move BROWSER_TIMEOUT implementation to mediawiki_selenium 0.2.8 gem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114454 [12:21:50] (03CR) 10Zfilipin: [C: 032] Move BROWSER_TIMEOUT implementation to mediawiki_selenium 0.2.8 gem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114454 (owner: 10Zfilipin) [12:22:11] (03Merged) 10jenkins-bot: Move BROWSER_TIMEOUT implementation to mediawiki_selenium 0.2.8 gem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114454 (owner: 10Zfilipin) [12:26:13] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114454 (owner: 10Zfilipin) [12:29:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5c7868b : Zeljko Filipin The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20204138 [12:45:54] DanielK_WMDE: da? [12:51:54] hoo: jetzt wieder [12:52:30] DanielK_WMDE: Did I get that right: You want us to actively prevent people from creating mw.wikibase.entity objects using legacy data? [12:53:26] hoo: if the object then behaves differently, yes [12:53:35] that would be confusing [12:54:23] DanielK_WMDE: In master we support both styles in mw.wikibase.entity, but it might be confusing still [12:54:45] while all methods work the same, the raw data stored still is different [12:55:08] (metatables are a mixture of like an array storing plain data and objects with methods) [12:55:59] hoo: i think if we allow it, the data should be converted while the object is constructed [12:56:11] DanielK_WMDE: Don't want to support that, really [12:56:26] that would force us to do the whole array reindexing stuff again [12:56:27] -.- [12:56:42] so... let's just not support legacy data then. it's just confusing, and i don't see the benefit [12:56:48] ok :) [12:57:11] if we really need it, we can always add the conversion step later [13:04:48] damn Lua :P [13:05:24] [travis-ci] wmde/WikibaseQueryEngine#28 (addshoreChanges - 5e84713 : jeroendedauw): The build was fixed. [13:05:24] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/2a5c250b33aa...5e847137f6eb [13:05:24] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/20206244 [13:05:49] sometimes I think it should ship more functions per default [13:05:56] eg. one to copy a table :P [13:06:31] [13WikibaseInternalSerialization] 15JeroenDeDauw comment on pull request #3 1485fb0cd: This ended up like that due to me first implementing the isDeserializerFor method, which now no longer is there. If that had not been a requirement before, I'd have put it together, and this is what I will likely do for the next deserializer. I do not think it is worthwhile to change this here now. The code is clear and there is no known problem with it. Theoretic [13:07:57] [13WikibaseInternalSerialization] 15JeroenDeDauw comment on pull request #3 1485fb0cd: I considered this while writing. Think this is clearer. Feel free to submit a commit that changes it though if you think this is wortwhile. Then we can compare. 02http://git.io/ATxAHA [13:13:16] aude: I guess you got my mail about the test Wikidata config. change? [13:13:29] assume greg is ok w/ it [13:13:37] or hasn't objected [13:13:52] I guess so... [13:14:11] [13WikibaseInternalSerialization] 15thiemowmde closed pull request #5: Remove not needed isDeserializerFor method (06master...06remcandes) 02http://git.io/lvHzqg [13:14:12] we might want to bump the parser cache epoch for testwiki after [13:14:26] we might want to notify users on test2 (site notice), so they are not surprised [13:14:39] oh, good point [13:14:52] * aude test pages will break [13:15:06] (03PS2) 10Hoo man: Make mw.wikibase.getEntityObject() actually return non-Legacy data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116236 [13:15:37] aude: Will you put that up, or shall I? [13:16:08] also for testwiki, probaby [13:16:18] if you want, that's ok [13:17:22] (03CR) 10Hoo man: "We now disallow the creation of mw.wikibase.entity" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116236 (owner: 10Hoo man) [13:17:26] will do [13:17:32] thanks [13:20:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116236 (owner: 10Hoo man) [13:20:45] oh [13:21:13] 1) Wikibase\Test\Api\SiteLinkTargetProviderTest::testGetSiteList with data set #0 (array('foo'), array('site1', 'site2')) Invalid argument supplied for foreach() [13:21:18] unrelated, sigh [13:22:44] hoo: rebase [13:22:51] i fixed that a day or 2 ago :) [13:22:52] https://gerrit.wikimedia.org/r/#/c/116940/ [13:22:59] (03PS3) 10Hoo man: Make mw.wikibase.getEntityObject() actually return non-Legacy data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116236 [13:23:04] [= [13:23:10] addshore: ok :) [13:23:19] * aude wonders what changed in core? [13:23:32] aude: Oh, bene* expanded core's SiteArray [13:23:34] bene made a change to SiteList [13:23:39] or SiteList [13:23:42] hmmmm, ok [13:23:44] I approved that [13:23:45] or SiteArray ;p [13:23:53] addshore: :D [13:25:38] (03CR) 10Jeroen De Dauw: (bug 40157) store entity status in page_props (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [13:27:21] aude: Put the sitenotices up [13:27:53] hoo: great [13:28:13] Thiemo_WMDE: merge merge merge? https://github.com/wmde/WikibaseInternalSerialization/pull/3 [13:28:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116236 (owner: 10Hoo man) [13:28:47] i don't think that many users test on test2, but if they do... [13:28:53] they are informed [13:28:57] Yep [13:29:33] aude: Well, but many do on test, I guess [13:29:52] s/many/quite some/ [13:29:52] (03CR) 10Daniel Kinzler: [C: 04-1] "use numeric values to indicate status, for better indexing." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [13:29:57] i don't think so [13:30:11] [13WikibaseInternalSerialization] 15thiemowmde closed pull request #3: Add SiteLinkListDeserializer (06master...06SiteLinkListDeserializer) 02http://git.io/w9Xm0g [13:30:13] reason we have wikibase on test.wikipedia is to test scap [13:30:17] localisation cache stuff [13:30:26] [13WikibaseInternalSerialization] 15thiemowmde 04deleted 06SiteLinkListDeserializer at 1485fb0cd: 02http://git.io/dza1wA [13:30:31] didn't originally have wikibase there [13:31:27] Gosh - this Wikidata thing is a mess. Why don't you identify language branches of Wikipedia by an ISO code?.. :-/ [13:31:27] I've got a problem here: [13:31:43] speckmade: what's the iso code for simple english? [13:32:02] wikipedias don't necessarily correspond with languages [13:32:25] addshore: NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO https://scrutinizer-ci.com/g/wmde/WikibaseInternalSerialization/ [13:32:39] haxxxxxx! [13:33:08] Changing that code so it does not complain makes no sense here [13:33:36] Normally I can get around by finding an Ajax-capable browser - autocompletion suggestions give me the things I search when I begin typing. But not so with id:WP [13:34:42] haha JeroenDeDauw :> [13:34:54] speckmade: Which auto complete do you mean? [13:34:58] aude: well - we found a solution for the subdomains that is close to ISO codes. I'd like to have uniformity. [13:35:12] hoo: with interwiki linking [13:35:21] "add" [13:35:22] [13DataValuesJavascript] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/z-JVIg [13:35:22] 13DataValuesJavascript/06master 14f4dd62a 15thiemowmde: Merge pull request #33 from wmde/updateValueFormatterDoc... [13:36:03] speckmade: Works fine for me [13:36:14] aude: so - the "ISO code" for simple english is "simple", obviously... [13:36:42] [13DataValuesJavascript] 15thiemowmde 04deleted 06testsrefactoring at 147410b7b: 02http://git.io/qbJ-qA [13:36:44] hoo: when I begin typing "id" it suggests the Ido Wikipedia [13:36:51] I need Indonesian [13:37:15] id.wikipedia is not Ido Wikipedia. [13:37:30] speckmade: Works for me, it suggests for ido and idwiki [13:37:41] so I can just select idwiki [13:38:08] - for [13:38:49] hoo: now I see why it doesn't work: there's a wrong link to indonesian WP already... :-/ [13:39:12] ah :) [13:39:37] so - actually it was a different problem this time. :-) [13:40:18] still: is there any development happening to make Wikidata editable without Ajax? [13:41:08] even Google manages to provide Ajax alternatives... :-) [13:41:36] speckmade: There has been volunteer activity in that area and we already have support for eg. changing sitelinks with JavaScript disabled [13:41:39] JeroenDeDauw: QueryEngine is merged :D [13:42:09] speckmade: google also has about a gazillion more developers [13:42:10] ;-) [13:42:15] hoo: good to hear that. :-) [13:44:02] yeah - but I guess they would call it a public beta in the state Wikidata is in now and would not throw it into productive use with Wikipedia... [13:44:45] I like Ajax - but first things first. [13:46:12] It looks like I have another problem: In my case at hand here I have article redundancy in danish and indonesian Wikipedia and no possibility to link both articles in Wikidata. [13:47:09] (03PS4) 10Tobias Gritschacher: Browsertests: make config variables environment variables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114492 [13:47:17] (03PS5) 10Aude: Add {{REPONAME}} magic word, remove references to Wikidata [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 [13:47:38] (03CR) 10Daniel Kinzler: "I really don't like the thisWikiIsTheRepo stuff, but that wasn't introduced by this change..." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [13:48:19] do I need to go somewhere into the unreadable jungle of beatiful indonesian characters and yell around in english to get somebody to merge the articles? or should I wait until Wikidata has evolved to have me covered here? [13:49:27] (oh - indonesian actually has latin script... :-) ) [13:52:11] (03CR) 10Aude: Add {{REPONAME}} magic word, remove references to Wikidata (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [13:53:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114492 (owner: 10Tobias Gritschacher) [13:54:05] (03PS6) 10Aude: Add {{WBREPONAME}} magic word, remove references to Wikidata [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 [13:54:26] (03CR) 10Daniel Kinzler: Add {{WBREPONAME}} magic word, remove references to Wikidata (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [13:54:27] DanielK_WMDE: hoo how's the approach for making that translatable? [13:54:34] other ideas how to do? [13:54:59] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 06/03/2014 10:36 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117170 (owner: 10WikidataBuilder) [13:55:15] phew - I found a "redundancy - please merge" template... [13:55:21] aude: it's fine i guess [13:55:35] for wikidata, we can put something in wikimedia messages [13:55:42] So: I've got a solution for now. [13:55:47] aude: my point about adding a suffix is kind of mute if you intend it to be *set* to a message key [13:55:50] sounds ok, yes [13:55:53] moot even [13:56:03] so wikidata can be written in hebrew etc [13:56:05] [travis-ci] Wikidata-lib/PropertySuggester/travis_db_debug/d2102ee : Tobias Gritschacher The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20209143 [13:56:32] has Wikidata also got some solution in the oven for redundant articles? or should I put a feature request somewhere? [13:56:51] speckmade what are you trying to achieve ? [13:57:01] aude: Yeah... I guess we can do that via WikimediaMessages? [13:57:10] do you even understand what Wikidata is about ? [13:57:18] I have to deal with the fact that there are redundant articles [13:57:27] so [13:57:36] that has nothing to do with Wikidata [13:57:43] (03Merged) 10jenkins-bot: New Wikidata Build - 06/03/2014 10:36 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117170 (owner: 10WikidataBuilder) [13:57:55] wikidata does not have articles [13:57:59] speckmade: no, we intentionally limit ourselves to a one-to-one relationship over sitelinks. [13:58:27] speckmade: if the articles are truely redundant, one should be deleted. if it's a problem of different granularity, you can define language links locally. [13:58:49] speckmade: if you don't know what to do, go to https://www.wikidata.org/wiki/Wikidata:Interwiki_conflicts [13:58:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [13:59:06] rage [13:59:12] (03CR) 10Daniel Kinzler: [C: 031] "Looks pretty good, needs manual poking." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [13:59:24] needs rebase [14:00:20] But if I have two articles on the same subject I want to be able to put interwiki link - or else I... DanielK_WMDE: yes, that's a start. :-) [14:01:55] speckmade: two articles about the same subject on wikipedia -> merge them, delete one. [14:02:08] [travis-ci] Wikidata-lib/PropertySuggester/travis_db_debug/fd69d0b : Tobias Gritschacher The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20209476 [14:02:08] wikipedia should never have two articles about the same subject. [14:02:29] DanielK_WMDE: great suggestion - if you speak the language. [14:02:46] write to the talk page, in english [14:02:55] or their village pump equivalent [14:03:04] english should be acceoptable there, at least for a brief notice. [14:03:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [14:04:03] DanielK_WMDE: I deleted interwiki links from one article I picked at random and put a "redundancy - please merge" template on both. [14:04:21] sounds good :) [14:05:42] maybe Wikidata should have a error message that points you Wikidata:Interwiki_conflicts if you try to link more than one article of one language... [14:06:05] [travis-ci] Wikidata-lib/PropertySuggester/travis_db_debug/208f94a : Tobias Gritschacher The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20209712 [14:06:33] speckmade: good point. the error message should be localized, so ti should be possible to add that link to the respective MediaWiki:xyz page. [14:06:43] and at some point maybe also an assistant to walk you through... [14:06:51] if you can find the right message, i'm sure an admin will be happy to add the link [14:07:16] Lydia_WMDE: So, the algorithm to find the statements to return should look like: Return all with RANK_TRUTH, if none, all with RANK_NORMAL if none, ... right? ;) [14:07:30] speckmade: yea, wizards for workflows on wikis would be very nice. especially on wikipedia. [14:07:42] DanielK_WMDE: there is none so far - is there? It just refuses you the service - like a moment ago it did for me... [14:07:42] forgot preferred, but you get the idea :P [14:07:51] hoo: TRUTH?? [14:07:56] ah :P [14:07:59] const RANK_TRUTH = 3; [14:08:01] yes, that'S the algorith [14:08:14] :) [14:08:36] hoo: that should be implemented in the data model, not in the client. we should use the same code for lua as we use for generatign the query index [14:09:05] (03CR) 10Aude: Add {{WBREPONAME}} magic word, remove references to Wikidata (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [14:09:18] that's what I am thinking about, as that's going to be really messy if done in client [14:10:00] DanielK_WMDE: Where do you think it would fit? Wikibase\DataModel\Claim\Claims is the first I have in mind [14:10:33] DanielK_WMDE: regarding wizards for workflows - we have some great shit on Wikimedia Commons already!.. [14:10:34] hoo: yes :) [14:10:42] (03PS7) 10Aude: Add {{WBREPONAME}} magic word, remove references to Wikidata [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 [14:11:13] [travis-ci] Wikidata-lib/PropertySuggester/travis_db_debug/d46b844 : Tobias Gritschacher The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20209971 [14:11:27] DanielK_WMDE, speckmade, what kind of wizard workflows do you need for wikipedia? [14:11:31] speckmade: i'd call that "nasty hacks", but yea... go ahead, make wizards :) [14:11:59] Micru: requesting deletion, for instance? anything that has a "due process". [14:12:08] ah, ok :) [14:12:09] DanielK_WMDE: so - for an error message - maybe that is worth a feature request somewhere? is there a issue tracker for Wikidata devs? [14:12:31] hoo: yes, Claims is a decent place, the problem is just that it only applies to Statements.+ [14:12:42] DanielK_WMDE: maybe you can also see Mediawiki as a nasty hack for a media repository... ;-) [14:13:12] speckmade: the change you propose for the error message is specific to wikidata.org, it's not a software issue. so, request it on the project chat. it can be done on-wiki. [14:13:26] unless the error isn't localized. in that case, file a bug on bugzilla to get it localized [14:13:33] you'll want the WikibaseRepo extension [14:13:53] and yes, commons is a *very* nasty hack for a media repository. [14:14:31] DanielK_WMDE: can you come over if you have a few minutes later? [14:14:35] btw, DanielK_WMDE, totally unrelated, but this is a case where transitive searches would be useful >> https://www.wikidata.org/wiki/Wikidata:Project_chat#Persons_claimed_as_citizens_of_a_state_which_did_not_exist_at_that_time [14:14:38] just about now. [14:15:04] DanielK_WMDE: "the problem is just that it only applies to Statements." Is that really a problem? If so, I'm not sure how to avoid it, as Claims probably doesn't know whether it's a Statement or whatever [14:15:11] *transitive queries, sry [14:15:11] Micru: you don't have to convince me, i wrote catscan ;) [14:15:43] DanielK_WMDE, ok, ok, just in case you went into the dark side :P [14:16:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [14:21:16] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06SnakListDeserializer (+1 new commit): 02http://git.io/JC8P0w [14:21:16] 13WikibaseInternalSerialization/06SnakListDeserializer 149780205 15jeroendedauw: Add SnakListDeserializer [14:21:32] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #6: Add SnakListDeserializer (06master...06SnakListDeserializer) 02http://git.io/gKbWlg [14:25:12] Tobi_WMDE: addshore property suggester test works for me [14:27:07] [travis-ci] Wikidata-lib/PropertySuggester/travis_db_debug/e2b0e0d : Tobias Gritschacher The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20211053 [14:30:35] (03PS47) 10Addshore: Implement TimeParsers + poke TimeFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [14:36:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:59:29] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06ClaimDeserializer (+2 new commits): 02http://git.io/c87efQ [14:59:29] 13WikibaseInternalSerialization/06ClaimDeserializer 14b49dc51 15jeroendedauw: Added base for ClaimDeserializer [14:59:29] 13WikibaseInternalSerialization/06ClaimDeserializer 1421846e8 15jeroendedauw: Implemented basic checks and happy path deserialization in ClaimDeserializer [15:01:50] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #7: Add Claim deserializer (06master...06ClaimDeserializer) 02http://git.io/GX4wKw [15:01:51] (03CR) 10Tobias Gritschacher: [C: 032] Browsertests: make config variables environment variables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114492 (owner: 10Tobias Gritschacher) [15:01:59] super easy review is super easy https://github.com/wmde/WikibaseInternalSerialization/pull/6 [15:02:02] Tobi_WMDE: ^ [15:02:14] (03Merged) 10jenkins-bot: Browsertests: make config variables environment variables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114492 (owner: 10Tobias Gritschacher) [15:05:35] (03PS1) 10Addshore: Cleanup MediawikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 [15:06:32] (03PS48) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [15:06:33] [13WikibaseInternalSerialization] 15tobijat 04deleted 06SnakListDeserializer at 149780205: 02http://git.io/N0gMDA [15:06:34] (03PS1) 10Addshore: Move Time i18n Messages to corrent i18n file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117195 [15:06:36] (03PS1) 10Addshore: Correctly Format BC dates/times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 [15:06:38] (03PS1) 10Addshore: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 [15:06:47] (03CR) 10Aude: Cleanup MediawikiNumberUnlocalizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [15:07:38] (03PS2) 10Addshore: Cleanup MediawikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 [15:08:12] (03CR) 10Aude: [C: 031] "waiting for jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [15:09:53] DanielK_WMDE: Bringing that up again: Shall that function in DataModel throw if not running on Statements only or just also work with Claims? [15:09:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/32a8ce6 : Tobias Gritschacher The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20213591 [15:10:06] Claims also have a getRank function, so that works just fine [15:11:30] jenkins where are you? [15:11:54] :< [15:13:11] hi [15:13:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [15:13:31] (03CR) 10Aude: [C: 032] Cleanup MediawikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [15:13:46] (03Merged) 10jenkins-bot: Cleanup MediawikiNumberUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [15:19:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [15:20:05] (03CR) 10WikidataJenkins: "Browsertests for new build on beta were successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117170 (owner: 10WikidataBuilder) [15:20:46] [13WikibaseInternalSerialization] 15JeroenDeDauw 04force-pushed 06ClaimDeserializer from 1421846e8 to 146140ac2: 02http://git.io/YXQZiA [15:20:46] 13WikibaseInternalSerialization/06ClaimDeserializer 1454b00cc 15jeroendedauw: Added base for ClaimDeserializer [15:20:46] 13WikibaseInternalSerialization/06ClaimDeserializer 146140ac2 15jeroendedauw: Implemented basic checks and happy path deserialization in ClaimDeserializer [15:24:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117195 (owner: 10Addshore) [15:26:44] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/HAUlug [15:26:44] 13puppet-builder/06master 14f0ad3ff 15addshore: Update README.md [15:28:13] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/T0suYA [15:28:13] 13puppet-builder/06master 147d19724 15addshore: Update README.md [15:28:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 (owner: 10Addshore) [15:32:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [15:37:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [15:53:07] (03CR) 10Thiemo Mättig (WMDE): Don't display languages based on ULS heuristics if I have a Babel box (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [15:53:54] [13WikibaseDataModel] 15mariushoch created 06getHighestRankedClaims (+1 new commit): 02http://git.io/ESzBaA [15:53:54] 13WikibaseDataModel/06getHighestRankedClaims 14bd64702 15Marius Hoch: Introduce Claims::getHighestRankedClaims [15:54:49] DanielK_WMDE: ^ [15:55:47] [travis-ci] wmde/WikibaseDataModel/getHighestRankedClaims/bd64702 : Marius Hoch The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/20217164 [15:56:48] oh, forgot to pull request m( [15:57:33] [13WikibaseDataModel] 15mariushoch opened pull request #19: Introduce Claims::getHighestRankedClaims (06master...06getHighestRankedClaims) 02http://git.io/XO7L1w [16:09:41] [13WikibaseDataModel] 15brightbyte comment on pull request #19 14bd64702: The name isn't so great; for one thing, it's not completely true: if there are only deprecated claims, then this should return no claims.... 02http://git.io/DtGjlA [16:10:45] ah, I see [16:10:46] (03CR) 10Thiemo Mättig (WMDE): Add {{WBREPONAME}} magic word, remove references to Wikidata (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [16:11:01] [13WikibaseDataModel] 15brightbyte comment on pull request #19 14bd64702: This should really be renamed, it's simply wrong. a preferred statement is not necessarily universally accepted. There may in fact be multiple preferred claims, and a fierce debate over which one is right - which we would want to model, not resolve. 02http://git.io/MziQUw [16:11:56] [13WikibaseDataModel] 15brightbyte comment on pull request #19 14bd64702: This will include deprecated claims. That is not intended. 02http://git.io/bablQQ [16:12:16] "That is not intended. " oh :P [16:12:46] [13WikibaseDataModel] 15brightbyte comment on pull request #19 14bd64702: I would suggest to have a separate method for getting claims by rank - getClaims( $rank ), or getCLaimsByRank(), or getPReferredClaims(), etc. And use these here. 02http://git.io/6YZKuw [16:13:36] [13WikibaseDataModel] 15brightbyte comment on pull request #19 14bd64702: Rank IDs are arbitrary, tehre is no guarantee for them to be continuous or even in any particular order. Ranks are not quantities. 02http://git.io/zmFjpA [16:13:54] hoo: the method could take a list of acceptable ranks, if you like [16:14:28] I'd prefer that [16:15:10] DanielK_WMDE: $rank = Claim::RANK_TRUTH; do you want to rename the constant? [16:15:19] If so, that's another issue [16:15:47] yes and yes [16:17:27] [13ValueView] 15tobijat closed pull request #31: Remove one animation, make other durations user-definable (06master...06animation_duration) 02http://git.io/IZGTsw [16:23:52] (03CR) 10Thiemo Mättig (WMDE): "I found at least a typo in the test that should be fixed in an other patch." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [16:23:54] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/NfPukA [16:23:54] 13ValueView/06master 144813e0d 15Tobi Gritschacher: Update README.md [16:24:16] (03CR) 10Thiemo Mättig (WMDE): (bug 57742) Formatter for details of TimeValue (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [16:27:45] (03CR) 10Thiemo Mättig (WMDE): "Typo in @cover tags." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [16:36:30] (03PS8) 10Aude: Add {{WBREPONAME}} magic word, remove references to Wikidata [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 [16:37:11] (03CR) 10Aude: Add {{WBREPONAME}} magic word, remove references to Wikidata (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [16:42:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [16:43:47] hoo: did https://gerrit.wikimedia.org/r/#/c/115397/ get backported again? [16:44:02] it's going to be a bit more involved to fix this nicely in master [16:44:08] aude: Yep, did that yesterday [16:44:12] ok [16:44:15] oh wait [16:44:22] thought you meant the Lua bit [16:45:39] hasn't [16:45:48] i can make new buidl [16:45:55] (03PS1) 10Hoo man: Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117219 [16:46:01] would be nice [16:47:23] * aude waits for jenkins [16:51:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117219 (owner: 10Hoo man) [16:51:57] there you go :) [16:52:39] (03CR) 10Aude: [C: 032] Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117219 (owner: 10Hoo man) [16:58:54] (03Merged) 10jenkins-bot: Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117219 (owner: 10Hoo man) [17:13:31] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: Your comments appears to be based on the wrong assumption that this is RANK_PREFERRED. It is not. We have a 4th rank RANK_TRUTH, which is what Claim objects have. This rank cannot be set in Statement objects. This should be revisited when we (attempt to) change the relationship between Claim and Statement from inheritance to composition. 02http://git.io/xXKqbA [17:14:31] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: Also note how this does not affect this commit at all - it does neither introduce the rank or modify it. 02http://git.io/lPuTPQ [17:15:16] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.23-wmf17/9268fb9 : aude The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20221997 [17:15:37] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: yes, having a getClaims( $rank ) would be good. This reduces the complexity of the method and makes it usable from other contexts. 02http://git.io/c87OnA [17:18:21] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: Not sure how you end up with quantities in this comment, I don't see any connection.... 02http://git.io/V6n41w [17:21:19] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: It is very hard to understand what is actually going on here. One needs to read a lot of code and remember a pile of random details. I suggest using dedicated well named test methods that test one specific case, or at the very least naming the things in this data provider better so one does not have to find out what all the numbers actually mean. 02http://git.io/YnVMeA [17:23:24] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: Agree. Name is not good. To bad we have a rank called preferred, else getPreferredRanks would have worked. 02http://git.io/jESt9g [17:23:46] aude: re https://gerrit.wikimedia.org/r/#/c/101895/8 - the docs have the wrong hook name [17:24:03] that... [17:24:04] other than that, it should be fine. trying to manually verify now [17:24:32] i would like jon to review, ideally [17:24:51] but if you verify also, that would be helpful [17:24:54] (03PS1) 10Thiemo Mättig (WMDE): Doxygen comments updated in Summary related classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117227 [17:25:15] aude: i'd just go ahead and merge it. i'm kind of tired of the sluggishness of core review [17:25:40] i need to poke and give him say, until monday or tuesday [17:25:45] if not interested, then i say merge [17:25:54] * aude also needs to answer theimo's comment [17:27:20] aude: hey, I just did a first dumb pass at making a "access groupings after NDA signage", can you take a look/tell me what I'm forgetting (as someone who more recently when through the process): https://www.mediawiki.org/wiki/User:Greg_%28WMF%29/Scratch/NDA_access_groups [17:27:27] and DanielK_WMDE ^ [17:27:40] DanielK_WMDE: i am asking jon now [17:30:00] greg-g: what about ishmael? [17:30:12] I haven't had access to it in months [17:30:13] +1 ishmael [17:30:16] at least [17:30:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117227 (owner: 10Thiemo Mättig (WMDE)) [17:30:29] * greg-g nods [17:31:25] anything else? hoo? [17:31:37] i'm looking at my irc logs [17:31:42] :) [17:31:43] for links people gave me that i can't see [17:31:49] ishmael was one [17:33:39] greg-g: think that's it, but then there might be things i am unaware of that would be good [17:33:52] yeah, I'll run this by ops as well, of course [17:34:00] the process around this is abysmal [17:34:06] addshore: nomnomnom [17:34:11] for deployment, hoo and i are in wmf_deploy in gerrit [17:34:15] Abraham_WMDE: DanielK_WMDE omnom [17:34:27] right, that one is important [17:34:34] already done [17:34:38] and mortals? [17:34:52] if you want to document it [17:34:58] Yep, both needed for deploy [17:35:11] aude: Do yet have access to graphite or is that a WIP? [17:35:16] hoo: no [17:36:37] aude: hm... monobook and vector will not render the language-link portlet at all if there are no longuage links, it seems. [17:36:45] then the hook doesn't get called for that portlet either [17:36:47] DanielK_WMDE: Yep [17:37:05] that was very struggling when doing the linkItem client widget [17:37:08] DanielK_WMDE: that's how it is supposed to work [17:37:17] Thiemo_WMDE: you want a food? You are sometimes staying longer... [17:37:19] uls does evil stuff to make it show [17:37:37] aude: but that makes the hook at lot less useful. [17:37:42] JeroenDeDauw: yes, please. [17:37:43] Universal eviLnesS [17:37:49] Thiemo_WMDE: come over then [17:37:59] i suppose need ot make sure add links is there, but to address when we change that in client [17:37:59] anyway. that can be changed later [17:38:02] ulos IS evil. by definition. [17:38:03] * addshore thinks jenkins might be playing ball :> [17:38:10] * aude hides :) [17:40:17] addshore: 8.30 [17:40:22] [= [17:40:24] Thiemo_WMDE: 7.50 [17:40:33] sure. [17:40:36] BTC or LTC payment possible! [17:40:51] addshore: got your phone? :D [17:41:00] no ;p [17:41:06] visa? [17:43:48] addshore: luckily for you I also accept DOGE, PPC, FTC, QRC, NYAN, MAX and NMC [17:59:11] [13WikibaseDataModel] 15brightbyte comment on pull request #19 14bd64702: Oh, you are right! never mind then. Having TRUTH for claims is fine. 02http://git.io/Xju5EA [17:59:23] (03PS1) 10Thiemo Mättig (WMDE): Fixed tests covering themselves [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117235 [18:01:31] [13WikibaseDataModel] 15brightbyte comment on pull request #19 14bd64702: I was not referring to QuantityValue, i was referring to the fact that while ranks have numeric IDs, they are not comparable values (aka quantities).... 02http://git.io/Dfk_OA [18:05:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117235 (owner: 10Thiemo Mättig (WMDE)) [18:05:15] (03CR) 10Addshore: [C: 032] Fixed tests covering themselves [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117235 (owner: 10Thiemo Mättig (WMDE)) [18:19:21] (03CR) 10Daniel Kinzler: Don't display languages based on ULS heuristics if I have a Babel box (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [18:25:22] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 3 new commits to 06ClaimDeserializer: 02http://git.io/8rJyyQ [18:25:22] 13WikibaseInternalSerialization/06ClaimDeserializer 140567ad2 15jeroendedauw: Add qualifier deserialization [18:25:22] 13WikibaseInternalSerialization/06ClaimDeserializer 14181e82d 15jeroendedauw: Implement Statement deserialization [18:25:22] 13WikibaseInternalSerialization/06ClaimDeserializer 144ce4a3c 15jeroendedauw: Implement references deserialization [18:26:58] (03PS7) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [18:30:33] (03PS1) 10Aude: new build, cherry pick I5e62345 for ClaimHtmlGenerator [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 [18:30:42] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: Right now the code guarantees this property, not sure what we gain by dropping that guarantee. One can argue about what this guarantee means of course, and where one is allowed to rely on it. Further discussion seems out of scope of this commit - the commit makes sense given our current implementation, and if we want to change our current implementation, we will need to modi [18:31:24] addshore: revieeewww https://github.com/wmde/WikibaseInternalSerialization/pull/7 [18:34:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [18:39:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 (owner: 10Aude) [18:40:26] (03CR) 10Aude: [C: 032] new build, cherry pick I5e62345 for ClaimHtmlGenerator [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 (owner: 10Aude) [18:59:11] aude: Want to deploy that today? [19:23:33] hoo|away: around? :P [19:24:23] yus [19:28:46] hoo: would like to [19:28:55] not a blocker though [19:29:04] aude: Ping greg maybe? [19:29:47] either him and/or bryan [19:35:29] (03Merged) 10jenkins-bot: new build, cherry pick I5e62345 for ClaimHtmlGenerator [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 (owner: 10Aude) [19:35:51] that took forever! [19:36:54] [13WikibaseDataModel] 15lydiapintscher comment on pull request #19 14bd64702: BestClaims or TopClaims or HighestClaims are all fine with me. (weak preference in this order) 02http://git.io/qcA59A [19:53:49] I am seeing language cache problems again. [19:54:16] on https://www.wikidata.org/wiki/Wikidata:Property_proposal/Authority_control , all section headers end in " (Please translate this into қазақша.)" [19:55:11] a purge on the page fixes the problem [20:00:53] addshore: hoo: around? [20:01:00] or aude? [20:01:02] ya [20:01:22] addshore: am i imagining things or is there newer code on wikidata.org than there should be? [20:01:42] wmf16 [20:01:47] https://www.wikidata.org/w/index.php?title=Q7835&diff=0&oldid=114098971 for example has details formatters for quantities [20:01:58] we didn't have those did we? [20:02:01] what the [20:02:03] they ahve been there for ages ;p [20:02:04] in the last deploy [20:02:25] we just merged globe and time [20:02:30] ahhhhh [20:02:31] ok [20:02:34] right [20:02:39] puh :D [20:02:42] for quantities [20:02:43] no, its fine [20:02:45] the quantity one was deployed with or just after quantities if I remember [20:02:45] * it's [20:02:52] ok cool [20:03:00] all good then [20:03:02] hoo / aude, there are 2 small core patches for you to review ;p [20:03:13] about the headings, really not sure [20:03:21] * hoo pretends to be busy [20:03:30] :P [20:03:30] lol [20:03:42] * Lydia_WMDE hands addshore a long pointy stick [20:03:54] :D [20:04:21] addshore: will have a glance [20:04:31] they are small and easy [= [20:05:01] small easy changes always win ;p [20:05:18] one done, one to go :) [20:06:14] addshore: array_slice( func_get_args() :P [20:06:24] yummy :P [20:06:28] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2cb85bb : Translation updater bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20233236 [20:08:45] addshore: If you pass an array, it's supposed to ignore further params? Interesting... [20:09:00] apparently, well thats its current behaviour :P [20:09:15] Thiemo_WMDE: wants to poke it so I thought I would write some tests for it to make his life easier ;p [20:09:18] I needed a few moments to figure what the hell is that test testing for :P [20:17:37] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/VP8ibg [20:17:37] 13WikibaseQuery/06master 14da7993f 15jeroendedauw: Add minimum stability flag [20:20:27] [travis-ci] wmde/WikibaseQuery/master/da7993f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/20234427 [20:29:14] (03CR) 10Addshore: [C: 032] Doxygen comments updated in Summary related classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117227 (owner: 10Thiemo Mättig (WMDE)) [20:37:23] addshore: https://travis-ci.org/wmde/WikibaseQuery/jobs/20234428 [20:45:44] [travis-ci] wmde/WikibaseQueryEngine/blooooob/db58116 : addshore The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/20236184 [20:50:28] [travis-ci] wmde/WikibaseQuery/master/da7993f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/20234427 [20:53:25] [travis-ci] wmde/WikibaseQuery/master/da7993f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/20234427 [20:53:48] sgd [20:54:29] (03PS16) 10Daniel Kinzler: (bug 62211) Refactoring EditEntity to use EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 [20:56:06] [travis-ci] wmde/WikibaseQuery/master/da7993f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/20234427 [20:59:25] [travis-ci] wmde/WikibaseQuery/master/da7993f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/20234427 [21:00:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [21:02:46] (03CR) 10Addshore: [C: 032] (bug 62211) Refactoring EditEntity to use EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [21:06:28] [travis-ci] wmde/WikibaseQuery/master/da7993f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/20234427 [21:18:58] (03CR) 10Addshore: [C: 04-1] "looking good, just 1 nitpick" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [21:24:44] !admin http://i.imgur.com/FOsFFl7.png [21:24:46] OMG [21:25:00] somebody know how to fix? [21:25:16] I think a lot of template confuse mediawiki software. [21:25:34] DangSunM|cloud: oO [21:25:38] lol [21:25:42] will have a look [21:25:49] https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Bulk_deletion_request [21:25:55] see bottom of RFD [21:26:00] Hello! [21:26:12] Hi [21:26:20] Is there an admin on Wikidata here that could assist me with something? [21:26:51] ? [21:26:59] There's a bug with CirrusSearch that I'm trying to track down involving a deleted page. [21:27:14] In a nutshell, I need the page to be undeleted and deleted again. [21:27:44] Bonus points if it could be left undeleted for 5 minutes or so while the CirrusSearch index updates, but it's not strictly necessary if the content of the page is somehow objectionable. [21:28:06] It is garget? [21:28:28] I don't know what you mean by that. [21:28:32] It's this page: https://www.wikidata.org/wiki/Q9028640 [21:28:53] DangSunM|cloud: Post‐expand include size: 2047998/2048000 bytes [21:29:00] the page simply is to large [21:29:05] Yeah [21:29:10] (03CR) 10Nikerabbit: Cleanup MediawikiNumberUnlocalizer (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [21:29:17] so maybe some should going archive [21:30:46] ok [21:31:03] Deskana: see stalk word in the topic :) [21:31:15] Deskana: restored [21:31:38] DangSunM|cloud: Could you leave it there for five minutes or so, then delete it again? Thanks! [21:31:47] ok [21:32:21] hi Deskana [21:32:24] (03CR) 10Addshore: Cleanup MediawikiNumberUnlocalizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [21:32:31] I should stalk !admin? [21:32:35] O_o [21:32:36] howdy [21:32:38] DangSunM|cloud: The index has updated. Okay, you can delete it now. [21:32:59] Deskana: need some help? ;p [21:33:09] Deskana : Deleted [21:33:12] addshore: I did, but DangSunM|cloud is helping me. ) [21:33:15] * :) [21:33:19] =] [21:33:31] What the... [21:33:40] lol [21:34:01] Undeleting it made the problem worse, instead of better. Now that you've deleted it, the problem's gone back to the way it was before. [21:34:03] This makes no sense. [21:34:11] :D [21:34:14] yeah [21:34:19] is there a bug? ;p [21:34:34] (03PS2) 10Addshore: Move Time i18n Messages to corrent i18n file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117195 [21:34:40] (03PS2) 10Addshore: Correctly Format BC dates/times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 [21:34:45] (03PS49) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [21:34:53] (03PS2) 10Addshore: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 [21:35:04] addshore: Certainly. https://bugzilla.wikimedia.org/show_bug.cgi?id=61464 [21:35:41] addshore: After the page was undeleted and the index updated, the page appeared *twice* in the search results. [21:35:57] Now it's been deleted, it's gone back to only appearing once. Of course, since the page is deleted, it shouldn't be appearing at all. [21:36:20] guessing the item referenced in the bug is now fixed? and we are instead looking at Q9028640 ? [21:36:22] great, so it's leaking deleted content :S [21:36:23] * DangSunM|cloud is going to other work since https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions is overcrowded. [21:37:54] bye to [21:37:56] bye yo [21:38:21] interesting Deskana [21:38:29] I've been authorised to use my staff rights to fiddle around with it, so I'll do some more investigating. [21:38:35] so the version from 20:11, 21 November 2013 is stuck [21:39:00] rschen7754: it doesnt seem to leak any content [21:39:06] addshore [21:39:08] : [21:39:20] but doesn't it leak the title and description? [21:39:30] well, I added a label and a desc [21:39:46] they show when the item is not delete on both, then delete the item and they no longer show on the one that remains [21:40:10] (03CR) 10Nikerabbit: Cleanup MediawikiNumberUnlocalizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117194 (owner: 10Addshore) [21:40:17] What... [21:40:30] The index updated and now it shows that description you added on *both* entries. [21:40:36] Even the one from 21 November 2013. [21:40:50] yup :P [21:41:25] intrestingly the desc updates but the date and number of words e.t.c doesnt [21:41:44] or the byte count [21:42:05] Yeah... [21:42:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117195 (owner: 10Addshore) [21:43:05] Deskana: description not label ;p [21:43:26] * Deskana does not know all the Wikidata terminology. [21:43:43] well, the label doesnt seem to update on the old index, only the description [21:44:00] ... [21:44:03] where has ULS gone again [21:44:20] aude: hoo ? :< [21:44:47] addshore: ? [21:44:56] oh wait, I definatly didnt have JS disabled ;p [21:45:11] heh :D [21:46:47] im a bit confused as to why the labels of the items are not showing on the search page... [21:47:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 (owner: 10Addshore) [21:48:56] addshore: They were before. [21:49:18] addshore: Nope, that's a lie. They weren't. [21:49:35] yet they do show in other places https://www.wikidata.org/w/index.php?title=Special%3ASearch&profile=default&search=foo&fulltext=Search [21:50:23] heh, okay that is just the behavious if you get an exact match on an ID apparently [21:50:33] the label will not show.. [21:51:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [21:51:56] addshore: The appropriate phrase is "wtf". [21:52:01] Anyway, gotta go. Thanks for the help! [21:52:04] I'll investigate more later... [21:52:56] hehe, just filled https://bugzilla.wikimedia.org/show_bug.cgi?id=62348 , totally unrelated to your bug though ;p [21:54:02] <^d> Our bug is weird :\ [21:54:21] :D [21:55:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [22:09:23] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move Time i18n Messages to corrent i18n file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117195 (owner: 10Addshore) [22:14:24] (03CR) 10Bene: Created a SiteLinkProvider to query sitelinks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene)