[07:05:14] ... good morning ... [09:05:16] (03Abandoned) 10Tobias Gritschacher: Allow DataValueFactory to be injected into SnakObject and tests [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80802 (owner: 10Aude) [10:00:22] (03PS1) 10WikidataBuilder: New Wikidata Build - 13/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118438 [10:02:18] (03PS8) 10Thiemo Mättig (WMDE): Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 [10:03:21] [13DataTypes] 15snaterlicious created 06removedatavaluesdep (+1 new commit): 02http://git.io/vZErag [10:03:21] 13DataTypes/06removedatavaluesdep 14ffae6c5 15snaterlicious: Removed DataValues dependency from composer.json... [10:03:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [10:05:36] (03CR) 10Thiemo Mättig (WMDE): "> If I'm logged out, I do not see any boxes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [10:05:54] [travis-ci] wmde/DataTypes/removedatavaluesdep/ffae6c5 : snaterlicious The build passed. http://travis-ci.org/wmde/DataTypes/builds/20675811 [10:07:26] [13DataTypes] 15snaterlicious opened pull request #9: Removed DataValues dependency from composer.json (06master...06removedatavaluesdep) 02http://git.io/2vu3gQ [10:09:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [10:11:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118438 (owner: 10WikidataBuilder) [10:15:35] (03CR) 10Addshore: [C: 032] New Wikidata Build - 13/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118438 (owner: 10WikidataBuilder) [10:26:45] aude: would you have a look at https://gerrit.wikimedia.org/r/#/c/113941/ ? [10:26:52] it'S nice and small, and has been sitting there a while [10:28:02] (03PS2) 10Daniel Kinzler: (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 [10:30:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [10:33:46] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [10:34:18] JeroenDeDauw: Should I rewatch the developers cinema video? Hm, it's $1... [10:36:03] (03CR) 10Tobias Gritschacher: [C: 032] Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [10:36:30] (03Merged) 10jenkins-bot: Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [10:37:59] (03PS3) 10Daniel Kinzler: Check namespace before initializing on client. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 [10:39:02] (03CR) 10Tobias Gritschacher: [C: 031] "Please do not forget to update composer.json after making the new release of data-values/time." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [10:39:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [10:40:01] (03CR) 10Tobias Gritschacher: "can finally be merged after the release is made. :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [10:40:38] (03PS3) 10Daniel Kinzler: (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 [10:42:03] [13Time] 15addshore pushed 1 new commit to 06master: 02http://git.io/pSCS_w [10:42:03] 13Time/06master 14b019ca4 15addshore: Update README for 0.3 [10:42:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [10:42:16] [13Time] 15addshore tagged 060.3 at 06master: 02http://git.io/W7mlfQ [10:43:13] (03PS52) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [10:43:15] (03CR) 10jenkins-bot: [V: 04-1] Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [10:44:40] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2f7a279 : jenkins-bot The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20677835 [10:44:41] (03PS53) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [10:45:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [10:45:24] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [10:54:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [10:57:49] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [11:00:56] [13Time] 15addshore pushed 1 new commit to 06master: 02http://git.io/DNoHWQ [11:00:56] 13Time/06master 1412ecb82 15addshore: use --prefer-source for travis composer install [11:02:00] [13Common] 15addshore pushed 1 new commit to 06master: 02http://git.io/R-UjkQ [11:02:00] 13Common/06master 142791f9b 15addshore: use --prefer-source for travis composer install [11:02:07] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:02:10] [13Number] 15addshore pushed 1 new commit to 06master: 02http://git.io/Q_m_IA [11:02:10] 13Number/06master 14dd97608 15addshore: use --prefer-source for travis composer install [11:02:20] [13Serialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/bnhsbg [11:02:20] 13Serialization/06master 147005a4b 15addshore: use --prefer-source for travis composer install [11:02:35] [13Validators] 15addshore pushed 1 new commit to 06master: 02http://git.io/NmREng [11:02:35] 13Validators/06master 14cc0d6d7 15addshore: use --prefer-source for travis composer install [11:02:40] [13DataTypes] 15snaterlicious created 06automatequnittests (+1 new commit): 02http://git.io/2zOFKw [11:02:40] 13DataTypes/06automatequnittests 149c31a11 15snaterlicious: Released ResourceLoader dependency from running QUnit tests [11:02:55] [13Interfaces] 15addshore pushed 1 new commit to 06master: 02http://git.io/yFDJtQ [11:02:55] 13Interfaces/06master 144a4c841 15addshore: use --prefer-source for travis composer install [11:03:00] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:03:05] [13Geo] 15addshore pushed 1 new commit to 06master: 02http://git.io/sJTwZA [11:03:05] 13Geo/06master 14a2c8ff8 15addshore: use --prefer-source for travis composer install [11:03:15] [13DataValues] 15addshore pushed 1 new commit to 06master: 02http://git.io/mhtoJg [11:03:15] 13DataValues/06master 141f16c10 15addshore: use --prefer-source for travis composer install [11:04:28] [travis-ci] wmde/DataTypes/automatequnittests/9c31a11 : snaterlicious The build passed. http://travis-ci.org/wmde/DataTypes/builds/20679295 [11:09:57] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:19:01] [13DataTypes] 15snaterlicious 04force-pushed 06automatequnittests from 149c31a11 to 14b28ace4: 02http://git.io/UEeTKQ [11:19:01] 13DataTypes/06automatequnittests 14b28ace4 15snaterlicious: Released ResourceLoader dependency from running QUnit tests [11:19:11] (03PS3) 10Daniel Kinzler: (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 [11:20:00] (03PS54) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [11:20:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [11:22:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:25:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [11:29:53] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:31:59] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/H-OEQQ [11:31:59] 13scrumbugz/06master 148d7b7ca 15Christopher Johnson: fixed missing component field [11:33:07] (03PS55) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [11:33:33] Tobi_WMDE: I said last night it woudl end up being PS55 ;p [11:34:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:35:19] (03PS4) 10Daniel Kinzler: (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 [11:36:25] :P [11:36:58] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [11:39:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:41:54] (03CR) 10WikidataJenkins: "Browsertests for new build on beta were successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118438 (owner: 10WikidataBuilder) [11:44:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [11:54:25] [13WikibaseDataModel] 15mariushoch created 06claimsByRanks (+1 new commit): 02http://git.io/3tu75A [11:54:25] 13WikibaseDataModel/06claimsByRanks 14eae7bfa 15Marius Hoch: Add Claims::getByRanks to filter Claims by several given ranks [11:55:13] [13WikibaseDataModel] 15mariushoch opened pull request #26: Add Claims::getByRanks to filter Claims by several given ranks (06master...06claimsByRanks) 02http://git.io/t1YOTg [11:55:59] (03CR) 10Hoo man: "The Claims specific code is in https://github.com/wmde/WikibaseDataModel/pull/26 now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [11:56:11] [travis-ci] wmde/WikibaseDataModel/claimsByRanks/eae7bfa : Marius Hoch The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/20682243 [11:56:34] [13WikibaseDataModel] 15addshore comment on pull request #26 14eae7bfa: phpdoc or method signature is wrong re the params 02http://git.io/3giJQQ [11:56:37] hoo: ^^ [11:56:46] looking [11:56:53] oh right [11:57:03] :> [11:57:05] took that from my Wikibase patch... [11:57:24] maybe your wikibase patch is wrong too ;p [11:57:32] (03PS4) 10Daniel Kinzler: Check namespace before initializing on client. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 [11:57:56] [13WikibaseDataModel] 15mariushoch 04force-pushed 06claimsByRanks from 14eae7bfa to 147b948b5: 02http://git.io/xBXz7Q [11:57:56] 13WikibaseDataModel/06claimsByRanks 147b948b5 15Marius Hoch: Add Claims::getByRanks to filter Claims by several given ranks [11:57:56] addshore: Fixed [11:58:06] [13WikibaseDataModel] 15addshore 04deleted 06oseven at 14769d9c7: 02http://git.io/TAS7OA [11:58:26] [13WikibaseDataModel] 15addshore comment on pull request #26 147b948b5: also the next release is 0.8 ;p 02http://git.io/7wNr8Q [11:58:38] *sigh* [11:58:39] hoo ^^ ;p [11:58:45] [= [11:58:53] [13WikibaseDataModel] 15addshore comment on pull request #26 147b948b5: also please update the release notes :) 02http://git.io/zdwmcA [11:59:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [12:02:16] [13WikibaseDataModel] 15mariushoch 04force-pushed 06claimsByRanks from 147b948b5 to 14fa690d3: 02http://git.io/xBXz7Q [12:02:16] 13WikibaseDataModel/06claimsByRanks 14fa690d3 15Marius Hoch: Add Claims::getByRanks to filter Claims by several given ranks [12:02:56] :> [12:03:01] [13WikibaseDataModel] 15mariushoch 04force-pushed 06claimsByRanks from 14fa690d3 to 1410d20bf: 02http://git.io/xBXz7Q [12:03:01] 13WikibaseDataModel/06claimsByRanks 1410d20bf 15Marius Hoch: Add Claims::getByRanks to filter Claims by several given ranks [12:03:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [12:04:01] [travis-ci] wmde/WikibaseDataModel/claimsByRanks/fa690d3 : Marius Hoch The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/20682548 [12:06:41] [13WikibaseDataModel] 15addshore closed pull request #26: Add Claims::getByRanks to filter Claims by several given ranks (06master...06claimsByRanks) 02http://git.io/t1YOTg [12:13:31] (03PS14) 10Hoo man: Add {{WBREPONAME}} magic word [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [12:15:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [12:15:35] oh no [12:15:56] ignore one of the WikidataJenkins ! [12:16:00] there are 2 currently ;p [12:16:08] Oh, sounds sane :P [12:16:18] :> [12:19:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [12:33:38] why on earth do repo changes no longer replicate into my clients RC? [12:34:32] ah ok, they do... but don't show up on my watchlist [12:34:44] we have a bug for that [12:34:56] aude: Yikes... is that broken on master? [12:34:58] * aude making a patch [12:35:00] it is [12:35:26] Ok :P [12:35:28] something changed in core about the way the query is created [12:35:42] with all the recent changes / watchlist refactoring [12:35:48] sounds likely [12:35:55] the way we modify it is quite insane [12:36:02] indeed [12:36:46] !bug 62149 [12:36:53] (03CR) 10Hoo man: [C: 032] "Works fine, although I'm not a fan of more static code" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [12:36:58] (is there a bot for that?) [12:37:06] aude: Not in here :P [12:37:15] (03Merged) 10jenkins-bot: Add {{WBREPONAME}} magic word [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [12:37:50] aude: Actually, I guess I can take that client bug [12:38:00] if you want [12:38:12] i can put my patch up and you can work on it more [12:38:22] that sounds good :) [12:38:30] it involves moving stuff out of static methods [12:38:33] adding tests [12:38:39] that would catch this [12:39:13] :) [12:40:25] grrr "Fatal error: Class Wikibase\Lib\MediaWikiNumberLocalizer contains 1 abstract method " [12:40:28] unrelated [12:41:28] (03PS1) 10Aude: add SpecialWatchlistQueryHandler for client hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 [12:43:02] (03PS2) 10Aude: Fix watchlist hook query in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 [12:43:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [12:43:19] evil jenkins [12:44:42] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [12:44:52] hoo: the problem specifically is RC_EXTERNAL (5) is quoted now [12:45:01] with addQuotes() [12:45:19] didn't have quotes before [12:45:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/742c3ed : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20684330 [12:47:00] (03CR) 10Aude: [C: 04-1] "not ready yet" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [12:47:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [12:49:09] will have a look later... first some more code review... there's quite some stuff in gerrit [12:49:22] hoo: i need to make a follow up [12:49:37] patch has stuff htat wasn't indended to upload yet [12:50:18] ok [12:51:00] (03PS3) 10Aude: Fix watchlist hook query in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 [12:52:22] if ( in_array( $skin->getSkinName(), array( 'vector', 'monobook', 'modern' ) ) ) { [12:52:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [12:52:38] we could do !cologneblue [12:53:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [12:53:20] but then who knows what other skins are out there and maybe we shouldn't be styling them [12:53:23] might be better long term [12:53:27] mh [12:53:34] mobile, maybe [12:53:43] yeah, mobile is a valid skin now [12:54:09] our formatting definitely works appropriately with modern, monobook and vector [12:54:24] it "works" in cologne blue but is inappropriate for the skin [12:54:38] Ok for now... although we have to watch out for new skins and third party users will have fun :P [12:54:53] better to unstyle if we dont' know [12:55:08] then it will inherit skin stylign from the language list [12:56:56] (03PS3) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [12:58:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [12:58:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [13:00:41] Thiemo_WMDE: I would have time for the EntityIdFormatter stuff from 15:30 to 17:00. would that be ok for you? [13:02:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [13:12:57] (03CR) 10Hoo man: [C: 04-1] Use BaseTemplateAfterPortlet hook to add "edit / add links" link (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [13:17:28] addshore: 12 2 2342 [13:28:37] (03CR) 10Addshore: [C: 04-1] "Parsing the string '12 2 2342' seems to fail, which is odd, need to write a testcase for this and investigate a bit more...." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [13:32:57] [13DataTypes] 15snaterlicious pushed 1 new commit to 06automatequnittests: 02http://git.io/tGALtg [13:32:57] 13DataTypes/06automatequnittests 14eddc0d0 15snaterlicious: Run QUnit test via Travis [14:22:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118462 (owner: 10Thiemo Mättig (WMDE)) [14:24:26] addshore: http://de1.php.net/manual/en/datetime.formats.date.php [14:26:19] (03PS2) 10Henning Snater: Make entityselector work with deleted entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118262 (owner: 10Adrian Lang) [14:27:03] (03CR) 10Henning Snater: [C: 032] Make entityselector work with deleted entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118262 (owner: 10Adrian Lang) [14:27:31] (03Merged) 10jenkins-bot: Make entityselector work with deleted entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118262 (owner: 10Adrian Lang) [14:28:09] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118262 (owner: 10Adrian Lang) [14:32:05] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118262 (owner: 10Adrian Lang) [14:32:12] (03PS57) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [14:33:30] (03PS58) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [14:33:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:38:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:39:17] (03PS5) 10Hoo man: Use SiteList::getSiteByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [14:41:07] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [14:44:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:48:18] (03PS4) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [14:49:06] (03CR) 10Tobias Gritschacher: [C: 032] Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:49:20] \o/ [14:49:23] wooooooo! [14:49:30] (03CR) 10Tobias Gritschacher: [C: 032] Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:49:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [14:49:48] lies [14:49:53] (03Merged) 10jenkins-bot: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [14:58:00] hoo: now it died [14:58:41] ^d ^ [14:58:51] * aude doesn't know how or if i can restart gerrit [14:59:29] aude: We can't... only the gerrit admin group can do taht :P [14:59:42] * hoo read a lot of WMFs puppet recently... [15:01:24] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118462 (owner: 10Thiemo Mättig (WMDE)) [15:01:40] heh [15:02:29] mh, we have TestItemContents, but no TestItems, meh [15:03:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [15:04:53] gerrit is back [15:07:12] (03PS1) 10Addshore: Fix ALL of the phpdocs! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 [15:07:22] (03CR) 10jenkins-bot: [V: 04-1] Fix ALL of the phpdocs! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [15:08:08] addshore: Fix all is an alias for conflict everywhere ;) [15:08:17] ;p [15:08:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [15:10:08] addshore: @return string|void [15:10:12] string|null that is [15:13:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [15:15:52] (03PS1) 10Addshore: Removed unused stuff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 [15:17:05] hoo: which one was that in? [15:17:28] client/includes/hooks/MovePageNotice.php [15:17:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 (owner: 10Addshore) [15:17:57] you might want to make it explicitly return null or an empty string [15:18:06] php kind of sucks with this (as with a lot of other stufF) [15:18:22] (03PS2) 10Addshore: Fix ALL of the phpdocs! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 [15:19:12] (03PS3) 10Hoo man: (bug 62210) Avoid EntityContent::save in repo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 (owner: 10Daniel Kinzler) [15:19:19] (03CR) 10Siebrand: Removed unused stuff (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 (owner: 10Addshore) [15:19:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [15:20:30] (03CR) 10Siebrand: "Epic endeavour. Congrats :)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [15:20:50] gerrit slow again, yikes [15:21:05] (03CR) 10Hoo man: [C: 032] "Might be worth to introduce a TestItems class instead/ on top of the TestItemContents one. But that's unrelated. Despite of that, this loo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 (owner: 10Daniel Kinzler) [15:22:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 (owner: 10Daniel Kinzler) [15:22:30] (03PS2) 10Addshore: Removed unused stuff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 [15:23:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 (owner: 10Addshore) [15:23:49] I guess I'm just going to checkout the changes and review them locally now... :/ [15:24:06] haha [15:25:37] addshore: Your remove unused stuff change has a few misc. changes packed... :P [15:25:53] I'm ok with that, not perfect, but ok... once gerrit lets me, I'm going to +2 [15:27:07] :P [15:31:39] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 (owner: 10Addshore) [15:32:54] (03CR) 10Hoo man: [C: 032] ":)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 (owner: 10Addshore) [15:33:14] that two gerrit concept is quite nice :P The second one will then allow this to be merged... or not, if it fails :D [15:33:34] :P [15:34:49] [13DataTypes] 15tobijat 04deleted 06removedatavaluesdep at 14ffae6c5: 02http://git.io/TkV08w [15:36:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [15:39:13] [13DataTypes] 15tobijat pushed 1 new commit to 06master: 02http://git.io/HUiKRw [15:39:13] 13DataTypes/06master 145352f9d 15Tobi Gritschacher: Merge pull request #10 from wmde/automatequnittests... [15:39:58] (03CR) 10Aude: Use BaseTemplateAfterPortlet hook to add "edit / add links" link (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [15:40:03] (03PS7) 10Aude: Use BaseTemplateAfterPortlet hook to add "edit / add links" link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 [15:41:34] [13DataTypes] 15tobijat pushed 1 new commit to 06master: 02http://git.io/Y7M37Q [15:41:34] 13DataTypes/06master 14949ca2b 15Tobi Gritschacher: Merge pull request #11 from wmde/jsdatatypestore... [15:41:41] [13DataTypes] 15tobijat 04deleted 06jsdatatypestore at 14a5538c5: 02http://git.io/Sm8Ymg [15:41:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [15:41:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 (owner: 10Daniel Kinzler) [15:44:24] [13DataTypes] 15addshore pushed 1 new commit to 06master: 02http://git.io/ng8x8g [15:44:24] 13DataTypes/06master 145d5b1a5 15addshore: rm duplicate notification section from .travis.yml [15:46:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118470 (owner: 10Addshore) [15:46:17] [13DataValuesJavascript] 15tobijat closed pull request #34: Restructured QUnit test runner (06master...06testrunner) 02http://git.io/6BZbeA [15:46:50] (03CR) 10Aude: [C: 04-1] "typo in the setting name and see comments" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [15:47:23] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vagnbg [15:47:23] 13WikibaseDataModel/06master 14699ec7a 15Jeroen De Dauw: Update WikibaseDataModel.php [15:47:37] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/i_jlnA [15:47:37] 13WikibaseDataModel/06master 14b83899c 15Jeroen De Dauw: Update RELEASE-NOTES.md [15:47:56] "Welcome Reedy! In order to benefit from this site please add the Babel template to your user page" [15:47:57] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/mUgL0Q [15:47:57] 13WikibaseDataModel/06master 14ec07da7 15Jeroen De Dauw: Update Claims.php [15:48:05] Warning: Please do not use this template. Use {{#babel:...|...}} instead! [15:48:06] Sigh [15:48:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118543 (owner: 10L10n-bot) [15:50:58] (03CR) 10Hoo man: [C: 04-1] Fix ALL of the phpdocs! (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [15:51:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [15:53:45] (03CR) 10Aude: "note: this requires adding messages in WikimediaMessages (or some place) for "wikibase-otherprojects-wikivoyage" etc." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [15:55:56] (03CR) 10Hoo man: "re @aude" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [15:56:01] aude: ^ [15:56:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118543 (owner: 10L10n-bot) [15:56:08] * aude click [15:56:31] I think we have a slight misunderstanding there [15:57:00] ok, so just $title->exists check [15:57:11] yeah, should be enough [15:57:29] (03CR) 10Aude: Implements the "other project" section in sidebar (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [15:57:52] Just wanted to make sure you understand my rational (and the problem) ;) [15:57:57] i'd like to do another patch to move the hook code / add tests [15:58:21] yeah, makes sense [15:58:31] but we shouldn't have that "broken" on master [15:58:35] yep [16:01:02] hoo: it seems the css hides it for non existing pages but it's good to add the check and not put there in that case [16:01:14] aude: Well, it didn't work for me locally [16:01:26] huh [16:01:27] I saw the "In other languages" section on a non eixsting page [16:01:49] might have been a cache issue, but that's nto niece [16:02:36] (03PS8) 10Aude: Use BaseTemplateAfterPortlet hook to add "edit / add links" link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 [16:03:03] ah [16:03:37] (03PS9) 10Aude: Use BaseTemplateAfterPortlet hook to add "edit / add links" link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 [16:04:07] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [16:04:51] aude: Can you create a Data Model release? [16:04:58] hoo: no [16:05:04] JeroenDeDauw: ^ you? [16:05:05] ask JeroenDeDauw [16:05:27] hoo: what for? [16:05:33] the one function you just added? [16:05:52] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [16:06:52] (03PS10) 10Aude: Use BaseTemplateAfterPortlet hook to add "edit / add links" link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 [16:08:21] JeroenDeDauw: Yeah :P [16:08:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [16:08:38] If you don't think taht's worth it, we can keep the local thing in Wikibase for now [16:09:20] Lydia_WMDE: i am asking about incremental dumps [16:09:30] only ariel would know [16:09:32] hoo: generally doing this for one function is a bit silly. It can be wortwhile, though most of the time there is no need for releasing that right away if you do some planning [16:10:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [16:10:20] it's not an issue [16:10:33] we can do it locally for now and remove that once data model get bumped [16:11:08] Lydia_WMDE: http://lists.wikimedia.org/pipermail/wikidata-l/2014-March/003558.html [16:12:00] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=62315 [16:12:38] [13WikibaseDataModel] 15JeroenDeDauw created 06clean (+1 new commit): 02http://git.io/q9MyIQ [16:12:38] 13WikibaseDataModel/06clean 14e6ad55a 15jeroendedauw: Minor cleanup in ClaimsTest [16:12:45] hoo: well, that is also not optimal [16:13:07] not optimal, but IMO ok for 5 lines (or so) of cod [16:13:10] e [16:13:13] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #27: Minor cleanup in ClaimsTest (06master...06clean) 02http://git.io/P63RCQ [16:13:13] hoo: lets just create a tag than in this code [16:14:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [16:15:03] aude: Did you change anything else? If not, I guess I can approve [16:15:30] i changed the jquery selector [16:15:42] i changed how the css module is added [16:15:50] $out->addModules() depends on js [16:16:01] so it didn't work for non js correclty [16:16:31] Lydia_WMDE: http://lists.wikimedia.org/pipermail/wikidata-l/2014-March/003559.html [16:17:01] Depends... but using addModulesStyle makes sense in these cases [16:17:27] it was done with mw.load .... [16:17:29] hoo: https://github.com/wmde/WikibaseDataModel/pull/27 [16:17:55] Emtpy :D [16:17:58] hoo: I'm not thrilled by the format of the tests you added - they could be a lot simpler [16:17:59] Thanks, Jeroen [16:18:01] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/71GFrw [16:18:01] 13WikibaseDataModel/06master 14e15745c 15Marius Hoch: Merge pull request #27 from wmde/clean... [16:18:36] hoo: control structures inside of tests, such as if statements and loops, are generally a sign of something going wrong [16:18:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [16:18:55] The same is true for needing to add comments [16:18:59] oh, that is_array [16:19:16] That thing is indeed not nice [16:19:23] I didn't want to duplicate all/most of that [16:19:32] wasn't sure which way to go... [16:20:10] hoo: I'd not have mixed the data provider for the two dofferent methods like this [16:20:27] Now the comments in it are even misleading, as they are only correct in one of the contexts [16:20:53] mh [16:20:58] Anyway, not a big deal, we have a lot of tests like this or worse. Just keep an eye on simplicity in tests as well in the future [16:21:03] I could (have) made them independent [16:23:09] aude: Super weird... I know see two pencils beneath the edit links link [16:23:28] not the widget one, but the one linking to repo [16:24:21] works in private mode [16:25:19] [13WikibaseDataModel] 15JeroenDeDauw created 06oseventwo (+1 new commit): 02http://git.io/HB6Qzg [16:25:19] 13WikibaseDataModel/06oseventwo 1415a39cf 15jeroendedauw: Bump to 0.7.2 [16:25:21] hoo: ^ [16:25:29] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #28: Bump to 0.7.2 (06master...06oseventwo) 02http://git.io/gnHKzA [16:25:54] :) [16:26:11] merge merge merge [16:26:24] [13WikibaseDataModel] 15mariushoch closed pull request #28: Bump to 0.7.2 (06master...06oseventwo) 02http://git.io/gnHKzA [16:26:32] Will bump Wikibase in a moment [16:26:34] [13WikibaseDataModel] 15mariushoch 04deleted 06oseventwo at 1415a39cf: 02http://git.io/GynxRw [16:31:49] (03CR) 10Hoo man: [C: 04-1] Use BaseTemplateAfterPortlet hook to add "edit / add links" link (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [16:32:58] (03PS1) 10Hoo man: Bump the dependency on Wikibase DataModel to 0.7.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118556 [16:33:15] JeroenDeDauw: --^ :) [16:34:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118556 (owner: 10Hoo man) [16:34:43] (03Abandoned) 10Hoo man: Bump the dependency on Wikibase DataModel to 0.7.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118556 (owner: 10Hoo man) [16:34:47] not needed, whoops [16:35:21] ?? [16:35:44] JeroenDeDauw: It fetches 0.7.2 itself, no need to adjust the composer.json [16:36:00] hoo: think about what is going on [16:36:03] it is needed [16:36:14] (03Restored) 10Hoo man: Bump the dependency on Wikibase DataModel to 0.7.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118556 (owner: 10Hoo man) [16:36:16] (03PS3) 10Tpt: Implements the "other project" section in sidebar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 [16:36:18] if you so [16:36:23] * say so [16:36:29] hoo: do you understand why? [16:36:36] no, actually not [16:37:09] hoo: if the range remains ~0.7.0, then the dependency manager is free to pick anything in the range [16:37:20] Typically it will pick the latest thing that is stable [16:37:24] Not always though [16:37:33] That's not what I intended... ok :) [16:37:41] And some other constraint might cause 0.7.2 to be over the upper bound [16:37:54] So it might now actually fetch 0.7.0 or 0.7.1 [16:38:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [16:39:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118556 (owner: 10Hoo man) [16:39:42] hoo: we should be quite carefull about not making this mistake - if our code requirements diverge from the ones specified in composer.json, correctness of dependency resolving is no longer guaranteed [16:40:03] WikidataJenkins looks like to have a problem "nulljob/wikibase-repo-api-tests/65/ : FAILURE" here: https://gerrit.wikimedia.org/r/#/c/114979/ [16:40:19] Tpt: That's known.... there are two instance of the thing running [16:40:34] the right one will vote on your change soon ;) [16:40:41] hoo: Ok. Thanks [16:40:42] JeroenDeDauw: Indeed... [16:40:46] (03CR) 10Jeroen De Dauw: [C: 032] Bump the dependency on Wikibase DataModel to 0.7.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118556 (owner: 10Hoo man) [16:41:09] (03PS1) 10Karan: Special:MergeItems error message should be improved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 [16:41:35] this gerrit thing is slow... [16:42:07] today the ride is a little bumpy, yes... [16:42:09] (03PS2) 10Hoo man: Only use the best Claims in mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 [16:43:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 (owner: 10Karan) [16:44:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [16:46:18] (03CR) 10Tpt: "PS3: rebase and application of all comments for PS2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [16:50:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [16:51:51] (03CR) 10Hoo man: [C: 04-1] Special:MergeItems error message should be improved (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 (owner: 10Karan) [16:53:16] (03PS3) 10Hoo man: Only use the best Claims in mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 [16:54:10] (03CR) 10Hoo man: "Now using Claims::getByRanks from DataModel (per Daniel)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [16:55:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 (owner: 10Karan) [16:56:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [17:11:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/373e268 : Marius Hoch The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20702258 [17:11:41] (03CR) 10Hoo man: [C: 04-1] "Didn't yet look at the tests" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [17:12:55] oh well... we successfully broke our unit tests (again) [17:38:18] Lydia_WMDE, aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=57744#c5 [17:38:23] anything to add? [18:11:21] (03PS11) 10Aude: Use BaseTemplateAfterPortlet hook to add "edit / add links" link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 [18:11:33] (03CR) 10Aude: [C: 04-1] "tests are incomplete" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [18:12:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [18:13:02] ah, decided to factor that out :) [18:13:18] got too complext [18:13:44] when to include the widget is complicated and not sure how to make that nicer [18:13:45] Yeah... and to much breakage [18:13:58] we could probably deprecate the setting [18:14:28] Yep, it's default true anyway [18:14:46] * aude back in a bit [18:16:26] DanielK_WMDE_: thx :) will have a look [18:17:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [18:20:47] DanielK_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=62210 <- i'll mark this as fixed then based on your comment (deprecate EntityContent::save() (fix lots of tests)) [18:22:18] Lydia_WMDE: Not yet [18:22:22] bah [18:22:29] hoo: 2secs too late :P [18:22:34] hoo: what's missing? [18:22:35] There are a lot of tests missing... we only yet changed some :P [18:22:48] see daniel's last comment [18:23:07] he forgot the API unit tests for example... [18:23:13] ah [18:23:24] hoo: care to reopen with a comment about what is missing? [18:25:02] DanielK_WMDE_: writeup looks good :) [18:25:26] (03PS1) 10Daniel Kinzler: (bug 62491) make API tests not use EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118580 [18:25:34] Lydia_WMDE: ^ :D [18:26:05] heh [18:26:07] I don't think I need to reopen then... [18:27:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118580 (owner: 10Daniel Kinzler) [18:27:08] yeah [18:31:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118580 (owner: 10Daniel Kinzler) [18:46:27] (03PS1) 10Karan: Special:MergeItems error message should be improved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118583 [18:48:06] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118583 (owner: 10Karan) [18:48:14] (03CR) 10Hoo man: [C: 04-1] "Also please don't create a new change set for every amend" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118583 (owner: 10Karan) [18:52:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118583 (owner: 10Karan) [19:03:45] (03CR) 10Daniel Kinzler: "what'S wrong with WikidataJenkins?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [19:06:05] DanielK_WMDE_: which one? :P [19:06:53] aude: On that change only the broken one ran for some reason [19:07:02] probably because of a gerrit restart or so [19:12:44] uh, what's wrong with gerrit, now? [19:12:55] web seems fine, but I can't download changes [19:13:06] ah, now. it just took very very long... [19:13:43] yeah... had hiccups all day [19:15:29] Cannot redeclare class valueformatters\decimalformatter in /var/www/daniel/wikidata/extensions/Wikibase/vendor/composer/ClassLoader.php [19:15:37] what gives? that class only exists once! [19:16:18] mh... ran composer update? [19:16:45] (03PS30) 10Daniel Kinzler: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [19:16:46] yep [19:17:10] rebase fixed it [19:17:12] whatever [19:17:41] (03CR) 10Daniel Kinzler: "PS 30 is a (trivial) rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [19:18:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [19:19:18] DanielK_WMDE_: https://gerrit.wikimedia.org/r/117847 is that only blocked by WikidataJenkins running over it? [19:20:33] hoo: haven't looked again, i already gave a +1. will do more reviews tomorrow, too many meetings today [19:21:54] DanielK_WMDE_: Ok, didn't change anything except of moving the Claims logic into the Claims class [19:22:22] Lydia_WMDE: do we have a bug for the unit tests no longer passing on MySQL? [19:22:40] Error: 1137 Can't reopen table: 'terms0' (localhost) [19:22:42] i dont think so [19:22:48] get that locally and it's on travis [19:23:16] hoo, Lydia_WMDE: ran into that today too, and fixed it. in an unrelated commit :P [19:23:33] \o/ [19:24:03] :P [19:24:04] hoo, Lydia_WMDE: https://gerrit.wikimedia.org/r/#/c/118313/3/repo/includes/ChangeOp/ChangeOpsMerge.php [19:24:20] hoo: i'm about to leave the office, feel free to make a separate patch for this [19:24:24] it's a horribly nasty hack [19:24:35] the underlying reason is that mysql does nto support self joins on temp tables [19:24:36] will phase taht out, yeah [19:24:47] We had that before... already thought it was that [19:24:50] so code that uses self-joins must not be called in unit tests [19:24:52] yay [19:25:21] (this is annoying on so many levels) [19:27:33] yep... that's a known problem for 10(?) years, yet nobody fixed it... [19:27:53] more than 10, at least 12 [19:33:44] (03CR) 10Daniel Kinzler: [C: 032] "finally! let's hope this doesn't subtly break anything..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [19:33:49] *phew* [19:34:05] oh wow, finally [19:34:08] another backend performance boost [19:34:08] (03Merged) 10jenkins-bot: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [19:34:13] DanielK_WMDE_: Save that few for until after the deploy :P [19:34:14] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118583 (owner: 10Karan) [19:34:22] * phew [19:34:23] right :) [19:47:20] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ed1003f : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20714419 [21:45:10] (03PS1) 10Hoo man: Fix the unit tests on MySQL by introducing a hack in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118612 [21:45:34] aude: --^ [21:46:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118612 (owner: 10Hoo man) [21:51:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118612 (owner: 10Hoo man) [22:04:54] (03CR) 10Hoo man: [C: 031] "Looks good in general, didn't test" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [22:16:41] Fatal error: Call to a member function getId() on a non-object in /usr/local/apache/common-local/php-1.23wmf17/extensions/Wikidata/extensions/Wikibase/repo/includes/ContentRetriever.php on line 42 [22:21:04] https://bugzilla.wikimedia.org/show_bug.cgi?id=62624 [22:21:38] Reedy: Fixed on master [22:21:39] AFAIR [22:21:44] occuring often? [22:22:26] it was showing as 8 out of 1000 lines [22:23:04] so...? Next usual deploy is on March 20 [22:23:10] * regular [22:23:45] I'd say that was fairly regular [22:24:13] Reedy: I can make a backport and stuff if you want that... [22:24:27] Thursday now, so probably last change before Monday :P [22:24:38] * hoo eyes aude [22:24:41] It'd seem sensible [22:24:52] As long as it's not a really huge change [22:25:10] Reedy: Just check if ( !$foo ) { return null; } [22:25:13] * checks [22:25:25] WFM ;) [22:25:59] (03PS1) 10Hoo man: Check for deleted revision in ContentRetriever [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118618 [22:26:20] (03CR) 10Hoo man: [C: 032] Check for deleted revision in ContentRetriever [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118618 (owner: 10Hoo man) [22:27:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118618 (owner: 10Hoo man) [22:27:38] ignore that [22:27:41] (03CR) 10Hoo man: [C: 032] "Looks sensible, doesn't explode" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118580 (owner: 10Daniel Kinzler) [22:28:28] (03Merged) 10jenkins-bot: (bug 62491) make API tests not use EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118580 (owner: 10Daniel Kinzler) [22:30:53] * hoo wonders whether the real WikidataJenkins is going to show up... [22:31:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118618 (owner: 10Hoo man) [22:32:11] ah [22:40:35] (03PS1) 10Hoo man: Update build to prevent fatal in ContentRetriever [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118620 [22:43:52] (03CR) 10Hoo man: [C: 032] Update build to prevent fatal in ContentRetriever [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118620 (owner: 10Hoo man) [22:46:41] (03Merged) 10jenkins-bot: Update build to prevent fatal in ContentRetriever [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118620 (owner: 10Hoo man) [22:48:19] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/118620 (owner: 10Hoo man) [22:49:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/872d2fa : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20727152 [23:01:04] DanielK_WMDE_: hey [23:11:12] (03CR) 10Hoo man: [C: 032] Fix external change parameter validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118463 (owner: 10Aude) [23:11:37] (03Merged) 10jenkins-bot: Fix external change parameter validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118463 (owner: 10Aude)