[01:33:55] hi [07:32:52] [13Serialization] 15Tpt opened pull request #7: Run tests also with hhvm (06master...06hhvm) 02http://git.io/MIGc9A [07:57:08] do you have root access to test.wikidata.org ? [07:57:15] it is for a test [07:57:57] ... when names.php has a definition for rwr and when a messagefile exists, rwr should work form Wikidata [08:56:52] (03CR) 10Tobias Gritschacher: [C: 032] Make entityselector always trigger aftersetentity event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119988 (owner: 10Adrian Lang) [08:57:23] (03Merged) 10jenkins-bot: Make entityselector always trigger aftersetentity event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119988 (owner: 10Adrian Lang) [09:00:15] (03PS2) 10Tobias Gritschacher: Add ugly test for bug 62868. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119989 (owner: 10Adrian Lang) [09:03:14] (03PS4) 10Tobias Gritschacher: Browsertests for statements with item values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 [09:03:24] :) [09:03:46] Hoi sjoerddebruin [09:03:51] Hoi GerardM- [09:04:09] did you read my latest blogpost [09:04:30] aiming at Wikipedia red links and disambiguation pages [09:05:02] Ah. [09:05:36] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/819eb93 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21410303 [09:05:38] just consider when all Indian Wikipedias start using this [09:06:00] it means that labelling and statements in the subjects they care for gets a boost [09:06:09] :D [09:06:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119989 (owner: 10Adrian Lang) [09:09:04] (03CR) 10Tobias Gritschacher: [C: 04-1] "This should be done on top of https://gerrit.wikimedia.org/r/#/c/110966/ which already adds supporrt for testing statements with item-valu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119989 (owner: 10Adrian Lang) [09:09:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 (owner: 10Tobias Gritschacher) [09:21:02] (03PS6) 10Tobias Gritschacher: Update EntityId expert(s) to reflect changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:21:38] (03CR) 10Tobias Gritschacher: "PS6 was a rebase: conflict in EntityIdInput.js" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:23:14] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:31:18] (03PS13) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [09:32:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [09:38:56] [13Serialization] 15addshore pushed 2 new commits to 06master: 02http://git.io/GJA0Hg [09:38:56] 13Serialization/06master 149e3dca5 15Tpt: Run tests also with hhvm [09:38:56] 13Serialization/06master 1458963e0 15addshore: Merge pull request #7 from Tpt/hhvm... [09:44:06] (03PS7) 10Tobias Gritschacher: Update EntityId expert(s) to reflect changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:45:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:52:30] its a Tobi_WMDE [09:53:05] it's addshore ! [09:55:45] addshore: everything fine? [09:56:06] timeparsers.. we're getting there.. :P [09:56:29] hehe :) will be in the office in like 30 mins I guess :) [09:56:37] wohoo!!! [09:56:51] you decided not to leave us, right? [09:56:58] good decision.. [09:56:59] I'm leaving tongiht :) [09:57:01] :P [09:57:16] wo ist der addshore? :) [09:57:30] heh [09:59:25] somewhere near the U4 :P Victoria louise platz? [09:59:35] :) [10:00:21] (03PS1) 10WikidataBuilder: New Wikidata Build - 24/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120497 [10:06:27] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/3-Lpjg [10:06:27] 13DataValuesJavascript/06master 1423a0768 15Tobi Gritschacher: Bump version 0.4 [10:06:52] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/w2FVvQ [10:06:52] 13DataValuesJavascript/06master 14b2241cc 15Tobi Gritschacher: Update README.md [10:07:12] [13DataValuesJavascript] 15tobijat tagged 060.4 at 06master: 02http://git.io/vWY28g [10:14:13] (03PS5) 10Tobias Gritschacher: Browsertests for statements with item values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 [10:16:21] (03CR) 10Tobias Gritschacher: Browsertests for statements with item values (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 (owner: 10Tobias Gritschacher) [10:19:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 (owner: 10Tobias Gritschacher) [10:20:06] aude do you (the Wikidata team) have root access to test.wikidata.org ? [10:22:53] Tobi_WMDE: It’s fixed I see? :) [10:25:54] sjoerddebruin: yes, it's fixed. :) not yet deployed though. [10:26:09] And the deploy is when? [10:26:26] sjoerddebruin: not sure if it will make it into the deployment tomorrow.. [10:26:41] I'll ask [10:27:39] aude: what do you think? is https://gerrit.wikimedia.org/r/#/c/119988/ critical enough to backport? [10:27:54] aude: I mean https://bugzilla.wikimedia.org/62868 [10:28:16] I would say it's a major bug and we should backport [10:28:50] Tobi_WMDE: can you answer my question ? [10:29:41] GerardM-: I'm not sure what you mean with "root" access? do you mean root shell access to the instance? [10:29:48] yes [10:30:16] can you create an empty message file and can you add a line to names.php [10:30:22] GerardM-: I doubt that we have that. if, then most likely aude. [10:31:19] it is about a test to confirm that the lack of the configuration of the rwr language in names.php and the absense of a message file prevents us from editing in Wikidata [10:31:40] I discussed this with Amir Aharoni and Lydia [10:32:12] GerardM-: can you provide me the bug number where this is tracked? [10:33:11] (03CR) 10Aude: "appear to be various issues with the special pages:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [10:34:04] GerardM-: no we don't have such access [10:34:37] do you have a local installation on a personal pc or something ? [10:34:58] somewhere where you CAN test this ? [10:36:36] (03CR) 10Daniel Kinzler: [C: 04-1] "as per addshore" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120007 (owner: 10Daniel Kinzler) [10:36:49] bug 59905 [10:37:49] Lydia_WMDE needs to put this on our todo list [10:38:00] * aude working on things for deployment today [10:40:07] addshore: can you spot an issue here? https://github.com/wmde/jenkins-job-builder-config/blob/master/wikibase.yaml#L334 [10:41:11] seems the special pages are broken [10:41:16] Tobi_WMDE: do we have selenium tests for those [10:41:18] ? [10:41:38] aude: not in the new testsets.. unfortunately [10:41:45] :/ [10:41:46] ook [10:41:59] i'll see if it's quick and easy to fix those [10:42:15] aude: broken due to the entitycontent? [10:42:16] otherwise maybe revert https://gerrit.wikimedia.org/r/#/c/117858/ [10:42:34] those have inadequate tests and not sure anyone manually verified [10:43:23] aude: hmm.. guess it should be not to hard to fix. DanielK_WMDE probably just forgot a few spots.. [10:43:30] yeah [10:44:19] Tobi_WMDE: yes we want the afterentityselect thing [10:44:34] aude: ok [10:45:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120497 (owner: 10WikidataBuilder) [10:46:00] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 24/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120497 (owner: 10WikidataBuilder) [10:46:28] (03CR) 10Addshore: [C: 032] New Wikidata Build - 24/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120497 (owner: 10WikidataBuilder) [10:46:44] Tobi_WMDE: i'm hanging out... [10:47:25] DanielK_WMDE: we will try [11:03:57] (03PS7) 10Addshore: Make js config handling more robust when config is not in ParserCache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [11:04:47] (03PS3) 10Addshore: Add / allow injecting experimental mode param in LanguageFallbackChainFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [11:06:13] (03CR) 10Addshore: [V: 032] New Wikidata Build - 24/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120497 (owner: 10WikidataBuilder) [11:10:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [11:11:11] (03PS2) 10Addshore: Use DataValues/Time version ~0.5.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 [11:12:15] (03PS1) 10Aude: Fix reference to undefined EntityContent in SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120503 [11:15:19] (03CR) 10Addshore: [C: 032 V: 032] Fix reference to undefined EntityContent in SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120503 (owner: 10Aude) [11:15:34] aude: Ping [11:15:40] hi [11:15:47] hey :) [11:15:58] * aude bug fixing [11:16:03] (03PS1) 10Addshore: Fix reference to undefined EntityContent in SpecialModifyTerm [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120504 [11:16:05] A user just pinged me because we apparently didn't deploy to wikidata on Thursday [11:16:20] we don't deploy on thursdays to wikidata [11:16:24] we deploy tomorrow [11:16:28] :P [11:16:38] and no deploys on the weekend! [11:16:57] Thursday, March 20, 2014 Deploy to test.* and Wikidata [11:17:03] wtf [11:17:12] cut and paste error [11:17:18] oh crap, my fault even [11:17:20] * aude assumes [11:17:31] Can't remember even doing that [11:17:31] we made exception to do that last month [11:18:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [11:19:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [11:22:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a3365ae : Addshore The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21417697 [11:23:36] [13Time] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/tsdCqg [11:23:40] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120503 (owner: 10Aude) [11:24:21] [13Time] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/F3TIdQ [11:24:21] 13Time/06travisPHPversions 14c63fab9 15addshore: Also test php 5.6 and hhvm on travis [11:26:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120504 (owner: 10Addshore) [11:27:31] [13Time] 15addshore 04deleted 06travisPHPversions at 14c63fab9: 02http://git.io/vnQWYA [11:27:51] [13Common] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/JPZEQA [11:28:01] [13Interfaces] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/k7VimA [11:28:11] [13Serialization] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/lWeRnA [11:29:11] [13Common] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/pLQdaA [11:29:11] 13Common/06travisPHPversions 143d40eba 15addshore: Also test php 5.6 and hhvm on travis [11:29:20] (03PS1) 10Aude: Fix fatal error in Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120505 [11:29:21] [13DataValues] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/jVkYbA [11:29:21] 13DataValues/06travisPHPversions 149f6dfdf 15addshore: Also test php 5.6 and hhvm on travis [11:29:32] [13Interfaces] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/vyIoTw [11:29:32] 13Interfaces/06travisPHPversions 14a9127d2 15addshore: Also test php 5.6 and hhvm on travis [11:29:42] [13Validators] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/DXjO5Q [11:29:42] 13Validators/06travisPHPversions 14e259235 15addshore: Also test php 5.6 and hhvm on travis [11:29:52] [13Number] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/S0YZSw [11:29:52] 13Number/06travisPHPversions 141044d31 15addshore: Also test php 5.6 and hhvm on travis [11:31:23] (03CR) 10Addshore: [C: 032 V: 032] Fix fatal error in Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120505 (owner: 10Aude) [11:31:39] (03PS1) 10Addshore: Fix fatal error in Special:SetSiteLink [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120506 [11:32:30] (03Abandoned) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120230 (owner: 10Addshore) [11:32:35] (03Abandoned) 10Addshore: Fix RuntimeException in Special:Newitem with SpamBlacklist [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120324 (owner: 10Addshore) [11:35:48] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120505 (owner: 10Aude) [11:38:57] [13DataValues] 15addshore opened pull request #2: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/4fCecw [11:39:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120506 (owner: 10Addshore) [11:39:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/fefe4e6 : Addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21418639 [11:39:32] [13Common] 15addshore opened pull request #5: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/UmAgIA [11:39:42] [13Interfaces] 15addshore opened pull request #1: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/izJxxg [11:39:52] [13Validators] 15addshore opened pull request #1: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/ZOCgcA [11:40:00] Tobi_WMDE: enjoying the spam? :> [11:40:02] [13Number] 15addshore opened pull request #3: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/kw6hdg [11:40:32] [13Common] 15addshore 04deleted 06travisPHPversions at 143d40eba: 02https://github.com/DataValues/Common/commit/3d40eba [11:40:33] addshore: haha [11:40:34] yes [11:40:52] [13DataValues] 15addshore 04deleted 06travisPHPversions at 149f6dfdf: 02http://git.io/m7v-Lw [11:42:02] [13Geo] 15addshore 04deleted 06travisPHPversions at 14f250551: 02http://git.io/eE9EoQ [11:42:18] (03PS1) 10Aude: Remove require for 'includes/Exception.php' in core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120507 [11:43:55] [13Interfaces] 15addshore pushed 1 new commit to 06master: 02http://git.io/81GCrA [11:43:55] 13Interfaces/06master 14f8ec1f4 15addshore: Merge pull request #1 from DataValues/travisPHPversions... [11:44:49] [13Iri] 15addshore closed pull request #1: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/bu4jPg [11:47:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120507 (owner: 10Aude) [11:47:12] [13Validators] 15addshore 04deleted 06travisPHPversions at 14e259235: 02http://git.io/XLOsZQ [11:47:16] (03CR) 10Addshore: [C: 032] Remove require for 'includes/Exception.php' in core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120507 (owner: 10Aude) [11:47:47] [13Serialization] 15addshore 04deleted 06travisPHPversions at 144225f98: 02http://git.io/EF7lCA [11:49:12] [13Number] 15addshore pushed 1 new commit to 06master: 02http://git.io/4RU-SA [11:49:12] 13Number/06master 145d1c283 15addshore: Merge pull request #3 from DataValues/travisPHPversions... [11:53:38] [13Time] 15addshore created 06fixDvCommonCompos from 06master (+0 new commits): 02http://git.io/mJYDVw [11:54:08] [13Time] 15addshore pushed 1 new commit to 06fixDvCommonCompos: 02http://git.io/EFRJSA [11:54:08] 13Time/06fixDvCommonCompos 144ca9414 15addshore: composer DV/common ~0.2.0 [11:59:45] [13Time] 15addshore 04force-pushed 06fixDvCommonCompos from 144ca9414 to 1497a8dfd: 02http://git.io/mJYDVw [11:59:45] 13Time/06fixDvCommonCompos 1497a8dfd 15addshore: REL 0.5.1, use composer DV/common ~0.2.0 [12:08:01] Tobi_WMDE: https://github.com/DataValues/Time/pull/13 [12:08:10] [13Time] 15addshore opened pull request #13: REL 0.5.1, use composer DV/common ~0.2.0 (06master...06fixDvCommonCompos) 02http://git.io/6pCVZw [12:11:55] [13Time] 15tobijat 04deleted 06fixDvCommonCompos at 1497a8dfd: 02http://git.io/jHZY4g [12:12:40] aude: addshore: schnitzel? [12:12:51] mit pommes? [12:12:53] woooh! [12:12:57] yeah [12:12:57] Abraham_WMDE: can you give me any info on the topic of the call in 30 minutes? is there any thing specific wi'll discuss? [12:13:12] Abraham_WMDE: and how officious shoudl I look? [12:13:50] oh, this is via phone, so looks don't matter :) [12:13:51] [13Time] 15addshore tagged 060.5.1 at 06master: 02http://git.io/rdfbyA [12:17:40] DanielK_WMDE: you find the details in the calendar invite :) [12:19:08] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/test5.6andhhvm/71d72fd : Addshore The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21420704 [12:24:01] Abraham_WMDE: all i see there is a phone number [12:29:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/test5.6andhhvm/7ce2915 : addshore The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21420738 [13:12:39] (03PS1) 10Addshore: Make travis test against php 5.6 and hhvm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 [13:16:12] [13Serialization] 15addshore created 06travisPHPver from 06master (+0 new commits): 02http://git.io/-K3FTw [13:16:27] [13Serialization] 15addshore 04deleted 06travisPHPver at 1458963e0: 02http://git.io/Pc_o6g [13:16:50] [13WikibaseDataModelSerialization] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/EqXy0w [13:17:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 (owner: 10Addshore) [13:17:22] [travis-ci] wmde/Serialization/travisPHPver/58963e0 : addshore The build has errored. http://travis-ci.org/wmde/Serialization/builds/21424415 [13:17:30] [13WikibaseDataModel] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/HHoMDQ [13:17:37] [13DataTypes] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/XhhQZQ [13:17:45] [13WikibaseDatabase] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/_R1XHA [13:17:55] [13Diff] 15addshore created 06travisPHPversions from 06master (+0 new commits): 02http://git.io/J5U3IQ [13:18:20] [13WikibaseDataModelSerialization] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/UsPfLw [13:18:20] 13WikibaseDataModelSerialization/06travisPHPversions 14bcd623c 15addshore: Also test php 5.6 and hhvm on travis [13:18:37] [13WikibaseInternalSerialization] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/y6HGnQ [13:18:37] 13WikibaseInternalSerialization/06travisPHPversions 147073602 15addshore: Also test hhvm on travis [13:18:50] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/4urrTg [13:18:50] 13WikibaseDataModel/06travisPHPversions 143fda5ae 15addshore: Also test php 5.6 and hhvm on travis [13:19:00] [13DataTypes] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/7YmdQw [13:19:00] 13DataTypes/06travisPHPversions 143b133d9 15addshore: Also test php 5.6 and hhvm on travis [13:19:22] [travis-ci] wmde/WikibaseDataModelSerialization/travisPHPversions/76d075c : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/21424465 [13:19:55] [13WikibaseQuery] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/pRz8YQ [13:19:55] 13WikibaseQuery/06travisPHPversions 14a008408 15addshore: Also test php 5.6 and hhvm on travis [13:20:10] [travis-ci] wmde/WikibaseInternalSerialization/travisPHPversions/9d9a656 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/21424509 [13:20:30] [13AskSerialization] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/Sk5jWg [13:20:30] 13AskSerialization/06travisPHPversions 1488cbc7a 15addshore: Also test php 5.6 and hhvm on travis [13:20:41] [13Diff] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/5S0pOQ [13:20:41] 13Diff/06travisPHPversions 141058a02 15addshore: Also test php 5.6 and hhvm on travis [13:20:42] [travis-ci] wmde/WikibaseDataModel/travisPHPversions/d75eb4c : thiemowmde The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/21424516 [13:20:51] [13Ask] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/e7keKw [13:20:51] 13Ask/06travisPHPversions 1437bcbeb 15addshore: Also test php 5.6 and hhvm on travis [13:22:16] [13WikibaseDatabase] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/13dg2Q [13:22:16] 13WikibaseDatabase/06travisPHPversions 14b6aa93e 15addshore: Also test php 5.6 and hhvm on travis... [13:22:31] addshore: mw/core travis php 5.6 [OK] :-] [13:22:55] [13WikibaseInternalSerialization] 15addshore opened pull request #24: Also test hhvm on travis (06master...06travisPHPversions) 02http://git.io/Jxe_jA [13:22:55] [13DataTypes] 15addshore opened pull request #12: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/grXeoA [13:22:55] hashar: really? :P [13:22:56] [13Ask] 15addshore opened pull request #3: Also test php 5.6 and hhvm on travis (06master...06travisPHPversions) 02http://git.io/J1gXqQ [13:23:01] so we can move straight from 5.3 to 5.6 right? ;p [13:23:02] addshore: I merely approved your change :] [13:23:16] the vision is more or less to drop PHP entirely [13:23:21] xD [13:23:21] well in favor of hhvm [13:23:28] hack! [13:23:30] I dont think we will ever use 5.4 [13:23:44] hack hack! [13:23:48] hack hack hack [13:23:53] [travis-ci] wmde/WikibaseQueryEngine/travisPHPversions/d14b57d : addshore The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21424532 [13:24:30] [travis-ci] wmde/WikibaseQuery/travisPHPversions/da7993f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/21424540 [13:24:32] (03CR) 10Tobias Gritschacher: [C: 032] Use DataValues/Time version ~0.4.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119962 (owner: 10Addshore) [13:24:52] (03CR) 10Addshore: "Ran on a branch on github before making this commit." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 (owner: 10Addshore) [13:25:20] (03CR) 10Tobias Gritschacher: [C: 032] Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [13:25:42] [travis-ci] wmde/WikibaseDatabase/travisPHPversions/94b0009 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/21424544 [13:25:48] addshore: what's blocking https://gerrit.wikimedia.org/r/#/c/119051? [13:26:01] (03PS3) 10Addshore: Use DataValues/Time version ~0.5.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 [13:26:13] Tobi_WMDE: nothing :P [13:26:28] oh wait [13:26:32] i can ammend it slightly [13:26:46] did you address thiemos comments on ps7? [13:26:55] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [13:26:58] (03CR) 10Aude: [C: 032] Fix reference to undefined EntityContent in SpecialModifyTerm [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120504 (owner: 10Addshore) [13:27:09] Tobi_WMDE: I believe so, just doing jerones now [13:27:20] (03Merged) 10jenkins-bot: Fix reference to undefined EntityContent in SpecialModifyTerm [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120504 (owner: 10Addshore) [13:27:34] (03CR) 10Aude: [C: 032] Fix fatal error in Special:SetSiteLink [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120506 (owner: 10Addshore) [13:27:57] (03Merged) 10jenkins-bot: Fix fatal error in Special:SetSiteLink [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120506 (owner: 10Addshore) [13:27:58] [travis-ci] wmde/Diff#10 (travisPHPversions - 70133ea : Marius Hoch): The build passed. [13:27:58] [travis-ci] Change view : https://github.com/wmde/Diff/compare/travisPHPversions [13:27:58] [travis-ci] Build details : http://travis-ci.org/wmde/Diff/builds/21424572 [13:28:16] (03PS9) 10Addshore: Factor EraParser out from YearTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 [13:28:37] Tobi_WMDE: yup I address thiemos comment, even added the test in the PS before which is already merged [13:29:03] (03CR) 10Aude: [C: 032] Fix RuntimeException in Special:Newitem with SpamBlacklist [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120323 (owner: 10Addshore) [13:29:09] addshore: ok, then let's wait for jenkins and merge it in [13:29:12] :> [13:29:25] (03Merged) 10jenkins-bot: Fix RuntimeException in Special:Newitem with SpamBlacklist [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120323 (owner: 10Addshore) [13:29:32] [travis-ci] wmde/Ask#25 (travisPHPversions - 6a438b0 : addshore): The build passed. [13:29:32] [travis-ci] Change view : https://github.com/wmde/Ask/compare/travisPHPversions [13:29:32] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/21424576 [13:29:42] [13WikibaseInternalSerialization] 15addshore pushed 2 new commits to 06master: 02http://git.io/iVOuIQ [13:29:42] 13WikibaseInternalSerialization/06master 147073602 15addshore: Also test hhvm on travis [13:29:42] 13WikibaseInternalSerialization/06master 1482b47f2 15addshore: Merge pull request #24 from wmde/travisPHPversions... [13:30:16] (03PS1) 10Aude: Make entityselector always trigger aftersetentity event [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120519 [13:31:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [13:31:57] [travis-ci] wmde/WikibaseInternalSerialization/travisPHPversions/7073602 : addshore The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/21424667 [13:31:59] Tobi_WMDE: wtf :P [13:32:05] Tobi_WMDE: https://gerrit.wikimedia.org/r/119980 [13:32:21] one test failed saying it couldnt find 0.5.1, but the others all passed xD [13:32:43] [13WikibaseDataModelSerialization] 15addshore pushed 2 new commits to 06master: 02http://git.io/s30OqA [13:32:43] 13WikibaseDataModelSerialization/06master 14bcd623c 15addshore: Also test php 5.6 and hhvm on travis [13:32:43] 13WikibaseDataModelSerialization/06master 140e48be8 15addshore: Merge pull request #59 from wmde/travisPHPversions... [13:32:56] addshore: let's retrigger [13:33:10] addshore: I needed to force update packagist [13:33:17] :> [13:33:47] addshore: btw did you see that I've split off getEntitiesTest? [13:33:48] :) [13:33:55] no :O [13:33:55] wtf [13:33:58] it has it's own job now [13:34:01] * aude is confused what day it is [13:34:04] :D [13:34:23] [travis-ci] wmde/WikibaseDataModel/travisPHPversions/3fda5ae : addshore The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/21424678 [13:34:23] put todays deployments under last monday :p [13:35:17] (03CR) 10Hoo man: Move UpdateRepoOnMoveJob into repo using JobSpecification in client (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119306 (owner: 10Hoo man) [13:35:33] (03PS7) 10Hoo man: Move UpdateRepoOnMoveJob into repo using JobSpecification in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119306 [13:35:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [13:36:03] [travis-ci] wmde/DataTypes/travisPHPversions/3b133d9 : addshore The build passed. http://travis-ci.org/wmde/DataTypes/builds/21424692 [13:36:05] (03CR) 10Hoo man: "Addressed Daniel's documentation comment, should be good to go now" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119306 (owner: 10Hoo man) [13:36:19] DanielK_WMDE: https://gerrit.wikimedia.org/r/119306 [13:37:18] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06travisPHPversions: 02http://git.io/iy-mXQ [13:37:18] 13WikibaseDataModel/06travisPHPversions 149ddc09e 15addshore: Allow HHVM to fail on travis [13:37:47] [travis-ci] wmde/WikibaseQueryEngine/travisPHPversions/573572d : addshore The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21424720 [13:39:08] [travis-ci] wmde/WikibaseQuery/travisPHPversions/a008408 : addshore The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/21424737 [13:39:41] aaaah [13:39:44] "PHP Fatal error: Call to a member function getEntity() on a non-object " [13:39:51] EditEntity.php on line 488 [13:40:29] [travis-ci] wmde/AskSerialization#34 (travisPHPversions - 88cbc7a : addshore): The build passed. [13:40:29] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/1e36e117d311...88cbc7a08120 [13:40:29] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/21424776 [13:40:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120519 (owner: 10Aude) [13:42:41] [travis-ci] wmde/Diff#11 (travisPHPversions - 1058a02 : addshore): The build passed. [13:42:41] [travis-ci] Change view : https://github.com/wmde/Diff/compare/70133eaa50ab...1058a029beb4 [13:42:41] [travis-ci] Build details : http://travis-ci.org/wmde/Diff/builds/21424786 [13:44:34] [travis-ci] wmde/Ask#26 (travisPHPversions - 37bcbeb : addshore): The build passed. [13:44:34] [travis-ci] Change view : https://github.com/wmde/Ask/compare/6a438b07af37...37bcbeb6a4c5 [13:44:34] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/21424796 [13:45:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [13:46:31] (03CR) 10Tobias Gritschacher: [C: 032] Use DataValues/Time version ~0.5.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [13:47:06] (03PS1) 10Hoo man: Document the new paramter to mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120525 [13:47:09] (03CR) 10Tobias Gritschacher: [C: 032] Factor EraParser out from YearTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [13:47:39] (03Merged) 10jenkins-bot: Factor EraParser out from YearTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [13:47:46] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [13:48:04] [travis-ci] wmde/WikibaseDatabase/travisPHPversions/b6aa93e : addshore The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/21424861 [13:49:17] (03PS7) 10Tobias Gritschacher: Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [13:49:37] (03PS2) 10Tobias Gritschacher: Tidy up various bits of Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119960 (owner: 10Addshore) [13:50:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119306 (owner: 10Hoo man) [13:50:40] addshore: I guess you need to checkout and manually rebase the whole chain again [13:54:34] (03PS1) 10Addshore: Remove space thats in the wrong place [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120527 [13:55:09] (03PS6) 10Addshore: Support additional spaces in dates, e.g. 31. 12. 2013 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119958 (owner: 10Thiemo Mättig (WMDE)) [13:55:14] (03CR) 10Addshore: [C: 032] Support additional spaces in dates, e.g. 31. 12. 2013 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119958 (owner: 10Thiemo Mättig (WMDE)) [13:55:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120525 (owner: 10Hoo man) [13:55:30] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/94dca37 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21426743 [13:55:48] (03PS3) 10Addshore: Use DataValues/Time version ~0.4.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119962 [13:55:52] (03PS4) 10Addshore: Use DataValues/Time version ~0.5.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 [13:57:37] DanielK_WMDE: poke [14:00:05] (03PS2) 10Tobias Gritschacher: Document the new paramter to mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120525 (owner: 10Hoo man) [14:00:24] (03PS8) 10Tobias Gritschacher: Move UpdateRepoOnMoveJob into repo using JobSpecification in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119306 (owner: 10Hoo man) [14:01:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [14:03:48] (03CR) 10Hoo man: "Some replies @Daniel (please have a look so that I can amend this week)" (0310 comments) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [14:04:23] (03CR) 10Tobias Gritschacher: [C: 032] Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [14:04:47] (03Merged) 10jenkins-bot: Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [14:04:59] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [14:05:47] * aude finds the edit conflict handling code in EditEntity slightly confusing [14:06:01] https://bugzilla.wikimedia.org/show_bug.cgi?id=63009 if someone wants to work on it [14:06:12] DanielK_WMDE: ^ [14:06:30] Is that in the branch which is about to go livE? [14:06:36] it is [14:07:19] if latest rev can't be found, then i guess just use $new? [14:07:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119960 (owner: 10Addshore) [14:08:14] (03CR) 10Tobias Gritschacher: [C: 032] Tidy up various bits of Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119960 (owner: 10Addshore) [14:08:21] Tobi_WMDE: +2 https://gerrit.wikimedia.org/r/#/c/119962/ and https://gerrit.wikimedia.org/r/#/c/119980/ again? ;p [14:08:36] oh wait, or wait for jenkins else the other jenkins will just merge them :P [14:08:39] (03Merged) 10jenkins-bot: Tidy up various bits of Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119960 (owner: 10Addshore) [14:08:41] (03Merged) 10jenkins-bot: Support additional spaces in dates, e.g. 31. 12. 2013 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119958 (owner: 10Thiemo Mättig (WMDE)) [14:08:49] addshore: waiting for jenkins [14:08:56] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119960 (owner: 10Addshore) [14:09:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119958 (owner: 10Thiemo Mättig (WMDE)) [14:09:17] aude: I guess we can just return true if there's no entity right? [14:09:27] I mean there can't be a conflict in that case [14:10:03] or use isNew [14:10:04] hmmm, i guess [14:10:14] "whether the new content is new" heh :) [14:10:33] Will make a patch [14:11:00] ok [14:11:06] Not working on anything specific atm, so feel free to throw stuff at me *hides* [14:11:25] https://gerrit.wikimedia.org/r/#/c/119311/ should go in [14:11:31] [travis-ci] wmde/WikibaseDataModel/travisPHPversions/9ddc09e : addshore The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/21426051 [14:11:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4f5ba53 : addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21427951 [14:12:00] will have a look later [14:12:02] and doesn't have to be for the branch, but make the edit conflict code less confusing [14:12:17] it assigns $baseRev [14:12:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120527 (owner: 10Addshore) [14:12:22] then $latestRev [14:12:24] then $new [14:12:40] $newEntity would be more clear [14:12:45] yeah [14:13:10] then it assigns $this->newEntity [14:15:55] (03CR) 10Aude: [C: 032] Make entityselector always trigger aftersetentity event [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120519 (owner: 10Aude) [14:16:40] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119958 (owner: 10Thiemo Mättig (WMDE)) [14:16:47] (03Merged) 10jenkins-bot: Make entityselector always trigger aftersetentity event [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120519 (owner: 10Aude) [14:16:54] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120519 (owner: 10Aude) [14:19:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/58fc671 : Thiemo Mättig The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21428369 [14:20:12] ewww Tobi_WMDE ^^ thats an actual failure... [14:20:20] InvalidArgumentException: Data value type mismatch. Expected a StringValue. [14:20:26] Wikibase\Test\PropertyViewTest::testGetHtmlForClaims with data set #0 (Wikibase\DataModel\Entity\Property) [14:20:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119962 (owner: 10Addshore) [14:20:37] not on the branch??? [14:20:46] master [14:20:51] sure? [14:21:01] [travis-ci] wmde/Diff#13 (master - bef7279 : addshore): The build was broken. [14:21:01] [travis-ci] Change view : https://github.com/wmde/Diff/compare/70133eaa50ab...bef7279ea293 [14:21:01] [travis-ci] Build details : http://travis-ci.org/wmde/Diff/builds/21427930 [14:21:29] addshore: is it related to that change? [14:23:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [14:23:42] (03CR) 10Tobias Gritschacher: [C: 032] Use DataValues/Time version ~0.4.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119962 (owner: 10Addshore) [14:24:12] (03Merged) 10jenkins-bot: Use DataValues/Time version ~0.4.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119962 (owner: 10Addshore) [14:24:18] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119962 (owner: 10Addshore) [14:25:16] (03PS1) 10Hoo man: Don't assume we have a conflict if no base rev is known in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120529 [14:25:46] aude: ^ untested, but should fix it [14:27:13] (03CR) 10Addshore: [C: 031] Use DataValues/Time version ~0.5.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [14:27:29] (03CR) 10Tobias Gritschacher: [C: 032] Use DataValues/Time version ~0.5.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [14:27:31] i tried it [14:27:42] and? [14:27:53] Didn't really know how to reproduce [14:27:54] actually need to see you did same thing i tried [14:27:55] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119980 (owner: 10Addshore) [14:28:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120525 (owner: 10Hoo man) [14:28:21] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/120527/ [14:28:29] and Tobi_WMDE https://gerrit.wikimedia.org/r/#/c/120515/ [14:28:29] What I do is what core does AFAIR [14:28:42] there are still possibly situations where $latestRev is null [14:29:10] * aude can try to reproduce again [14:29:47] Tobi_WMDE: also see my comment on https://gerrit.wikimedia.org/r/#/c/110401/ [14:29:55] but then we wont have a base revision id either, right? [14:30:12] if we do, that sounds like something else is going wrong here [14:30:13] Fixed, again? :P [14:30:19] (03PS1) 10Aude: Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120530 [14:31:05] addshore: you'll have to talk to Lydia_WMDE about this. I was not able to convince her.. [14:32:06] Lydia_WMDE: are you here? :P [14:32:23] of course, i can't reproduce [14:32:37] aude: addshore: Lydia_WMDE: DanielK_WMDE: can we give some more +1 here.. otherwise this will not move. [14:32:38] https://gerrit.wikimedia.org/r/#/c/119032/ [14:32:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119306 (owner: 10Hoo man) [14:33:10] (03CR) 10Hoo man: [C: 04-1] Handle InvalidArgumentException in ClaimHtmlGenerator (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120530 (owner: 10Aude) [14:33:51] aude: addshore: anybody tried https://gerrit.wikimedia.org/r/#/c/118277/ ? [14:34:15] nope :/ [14:34:26] Didn't test the latest version either [14:36:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120529 (owner: 10Hoo man) [14:39:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120530 (owner: 10Aude) [14:39:38] * aude signs [14:39:41] sighs [14:40:24] if i edit a statement without refreshing the page, add a second snak, try to remove the first [14:40:27] Claim with guid Q317$36ae2e28-4a46-e8e5-ef9b-07aa503936bc not found [14:40:37] [13Number] 15addshore pushed 1 new commit to 06master: 02http://git.io/X7c_7Q [14:40:37] 13Number/06master 1414b856b 15addshore: Remove unused use statements [14:40:38] O_o [14:40:42] refresh the page it's gone [14:41:07] oO [14:42:25] aude: Can't reproduce [14:43:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/3d10714 : addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21429510 [14:43:17] (03CR) 10Tobias Gritschacher: [C: 032] (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [14:43:40] (03Merged) 10jenkins-bot: (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [14:43:44] used the import elements script [14:43:47] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [14:43:50] maybe it's more broken [14:44:01] import elements is broken for ages :/ [14:44:07] :( [14:44:28] Sitelinks work, but nothing except AFAIR [14:44:36] * aude thinks i know  [14:44:47] trying another item [14:45:18] nothing to be concerned about :) [14:46:20] hoo: and that's probably why i had no revision also [14:46:31] super edge case [14:47:42] (03CR) 10Aude: "would like daniel to review and probably doesn't need backporting" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120529 (owner: 10Hoo man) [14:48:14] [13Number] 15addshore pushed 1 new commit to 06master: 02http://git.io/kaPlzg [14:48:14] 13Number/06master 1466d041f 15addshore: Fix pwd in test bootstrap [14:48:43] aude: As you mention entity per page... do we rebuild that per cron now, btw? [14:49:30] we can [14:49:45] I can write a puppet patch [14:49:55] ok [14:51:04] (03CR) 10Aude: [C: 031] "+1 on things like improving the variable naming, and making it a bit more robust." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120529 (owner: 10Hoo man) [14:51:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e62e24a : addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21429780 [14:54:51] new record of monthly contributors! http://www.ohloh.net/p/wikidata/contributors/summary [14:55:01] :O [14:55:58] https://github.com/DataValues/Number/pull/4 <<<<<<<< [14:55:59] # [14:57:01] (03PS1) 10Addshore: Remove missleading note in MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120534 [14:58:01] (03CR) 10Hoo man: [C: 032] Remove missleading note in MonthNameUnlocalizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120534 (owner: 10Addshore) [14:58:01] primary language = html ? [14:58:06] wtf? [14:58:24] (03Merged) 10jenkins-bot: Remove missleading note in MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120534 (owner: 10Addshore) [14:58:43] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120534 (owner: 10Addshore) [15:00:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/73fcaab : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21430964 [15:00:55] (03CR) 10Tobias Gritschacher: [C: 032] Use BaseTemplateAfterPortlet hook to add "edit/add links" link. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [15:01:23] (03Merged) 10jenkins-bot: Use BaseTemplateAfterPortlet hook to add "edit/add links" link. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [15:01:30] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [15:01:53] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120534 (owner: 10Addshore) [15:07:08] https://www.wikidata.org/wiki/Q9696430 how can pt have linked a redirect page? [15:09:58] it wasn't a redirect page at the time when the item was created [15:10:13] ok, thanks [15:10:23] np :) [15:11:03] so, to link with redirects, we can transform temporarily this redirects in articles, link correctly to wikidata, then re-transforme in redirects ? [15:12:25] Harmonia_Amanda: That works, yes :( [15:13:03] that can be the solution for all the redirects which links with items of a list [15:13:20] that's very good to know [15:13:27] many thanks [15:13:57] Harmonia_Amanda: Don't manually link redirects [15:14:03] - manually [15:14:05] why not? [15:14:16] Because this is not supposed to be done [15:14:27] We already have thousands of such corrupt items around [15:14:33] it's a big mess [15:14:53] hoo: we demand that it could be done since wikidata come around [15:14:56] came* [15:15:11] we still use the old interwiki to maintain that [15:15:33] if it can be done properly on wikidata, that's a great thing [15:15:33] Yes, the old interwiki system should be used for this [15:15:38] it can't [15:15:50] someone will once have to clean that up -.- [15:16:25] hoo: I clean up many old interwikis manually since wikidata came [15:16:34] to centralize that should be so more easy [15:16:51] It's not [15:17:03] but why? [15:17:22] I can give you a list of several thousand items which link redirects which can't be resolved because another item already links to the main page [15:17:30] main page = redirect target [15:17:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9fba62f : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21432259 [15:18:04] hoo: yes, if the main page is a list, that's seems normal [15:18:04] (03CR) 10Tobias Gritschacher: [C: 032] Document the new paramter to mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120525 (owner: 10Hoo man) [15:18:27] (03Merged) 10jenkins-bot: Document the new paramter to mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120525 (owner: 10Hoo man) [15:18:33] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120525 (owner: 10Hoo man) [15:18:58] hoo: but why is that a problem? [15:19:40] hoo: addshore when we create new items in the api, what should the context title be? (these don't have entity id assigend yet) [15:19:53] * aude remembers now why i disabled spam blacklist on my wiki [15:19:54] aude: The titleblacklist thing again? [15:19:59] or spam blacklist [15:20:20] because it's not in line with the data model Wikidata builds up on [15:20:45] aude: I think last time we agree using a Special page would be fine [15:20:47] spamblacklist sucks [15:20:49] :> [15:20:50] * agreed [15:21:08] icky [15:21:25] I had the idea to use Q0 or even Q-1 in that case [15:21:55] [13Iri] 15addshore pushed 1 new commit to 06master: 02http://git.io/rcJW-w [15:21:55] 13Iri/06master 1469decf0 15addshore: use getcwd() instead of exec('pwd') [15:21:55] had i not disabled it, i would have noticed the special:newitem issue that addshore fixed [15:22:11] would prefer to keep it enabled, but if it makes tests fail... [15:22:23] [13Geo] 15addshore pushed 1 new commit to 06master: 02http://git.io/xgJNtg [15:22:23] 13Geo/06master 1464d3022 15addshore: use getcwd() instead of exec('pwd') [15:22:26] (03PS1) 10Daniel Kinzler: (bug 62425) Property of main snak must not change. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 [15:22:45] DanielK_WMDE: around? what do you think? [15:22:55] aude: Maybe we should make the tests run with it and enforce that by isntalling it on Travis? [15:23:08] agree [15:23:26] aude: hm? whut? [15:23:54] what should $title be when items are created via api (and don't have id yet) [15:24:07] for Special:NewItem, $title is the special page [15:24:18] (sometimes problematic because there is no wikipage for it) [15:24:22] oh, we ran into that before :/ [15:24:39] phpunit tests (api) fail because of this.... [15:24:40] i think i reverted a "fix" for this which broke other things at some point [15:24:56] maybe fixed when we decouple api and entity content more, but still can be an issue [15:24:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 (owner: 10Daniel Kinzler) [15:25:46] aude, hoo: for permission checks on items that have not yet been created (for checking the create right), we use a page with the title "/" in the respective entity namespace. [15:25:47] [13AskSerialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/YdEGjA [15:25:47] 13AskSerialization/06master 14012409e 15addshore: use getcwd() instead of exec('pwd') [15:26:01] hmmm, ok [15:26:36] aude, hoo: could do that again, but it might break some assumption somewhere. i only remember that there was *some* pitfall there. [15:26:48] let's hope i put a comment in the relevant place :) [15:26:49] the title is used in the spam blacklist log [15:27:11] aude: for the log, refering to the special page makes sense [15:27:17] yeah [15:27:24] Both kind of makes sense [15:27:33] (03CR) 10Tobias Gritschacher: Browsertests: convert performance test scenario to outline (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 (owner: 10Tobias Gritschacher) [15:27:39] then there is no wiki page, but that's other issue [15:27:51] (03PS9) 10Tobias Gritschacher: Browsertests: convert performance test scenario to outline [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 [15:27:55] but if it's triggered via tha api, then it's misleading [15:27:55] how exactly do the tests fail? [15:28:03] LinkTitles [15:28:24] got a link? [15:28:25] $content->getParserOutput (param #1) [15:28:32] should be a Title but is null [15:28:41] [13Ask] 15addshore pushed 1 new commit to 06master: 02http://git.io/KLfZew [15:28:41] 13Ask/06master 1465493c0 15addshore: use getcwd() instead of exec('pwd') [15:28:55] http://pastie.org/8964444 [15:29:06] evil entity content + evil spam blacklist [15:29:14] only in LinkTitles? [15:29:24] that's where phpunit crashes [15:29:40] we will get around the "problem" when we decouple entity content here [15:29:43] aude: but why is it null?... [15:29:54] but it still can occur, possibly in the real api [15:30:07] we use RequestContext::getMain in this case [15:30:12] i suppose [15:30:33] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/803d6d5 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21433573 [15:30:37] $context->getTitle() [15:31:27] mh [15:31:27] aude: $title = $context->getTitle() returns null when called by the spam blacklist? why? [15:31:50] actually, Context guarantees that getTitle will always return a title. [15:31:54] it should fall back on wgTitle and that one is hardly null AFAIR [15:32:01] * @return Title [15:32:15] I think "hardly" in the MediaWiki way means sometimes [15:32:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 (owner: 10Tobias Gritschacher) [15:32:34] not convinced [15:33:05] if $content->getTitle() happens at any point, then if it's new, $title is null [15:33:15] hoo, aude: the question is, what $context is used here, where does it come from, and why does it return null from getTitle()? [15:33:26] Because that's the bug. Context::getTitle must not return null. [15:33:46] falls back to $wgTItle [15:33:54] let's see what $wgTitle [15:33:54] is [15:34:04] aude: we can't get past EntityContent here, since SpamBlacklist expects a Content object. [15:34:17] fun! [15:34:17] aude: RequestContext falls back. There are various other implementations. [15:34:57] well, it should not be a problem to use EntityContent here. That'S what we have it for, as glue to MediaWiki's idea of page content. [15:35:16] wgTitle is null! [15:35:40] yep, that's what I said above [15:35:46] *gasp* [15:35:47] wgTitle *can* be null [15:36:10] like i say, if it does $content->getTitle then it's null in this situation [15:36:15] aude, hoo: RequestContext::canUseWikiPage() actually checks whether getTitle() returns null, even though it's dopcumented to never return null, [15:36:16] we don't have an entity id yet [15:36:24] so, i guess the documentation is wrong. [15:36:36] it certainly is [15:36:40] aude: so? that doesn't say anythign about the COntext used there [15:37:00] hoo: but we can't use the old system of interwikis for redirects, wikipedias like WP:es forbid to write old interwikis now [15:37:12] hoo: so we'll have to do this on wikidata [15:37:15] * aude no idea then [15:37:23] why would the Context care that we are trying to create an item? It should have *some* tilte set... [15:37:39] it doesn't [15:37:49] we can set one [15:37:52] DanielK_WMDE: Ok, I can prepare a core patch... two approaches: Either document gettitle to return null [15:37:58] Harmonia_Amanda: that's a strange rule. Wikidata explicitly does not cover all edge cases of language links. That's why we took care to allow local overrides and additions. [15:38:16] or use Title::newMainpage() (or so)... taht always returns a title and is often used as a last resort [15:38:27] Harmonia_Amanda: there should be exceptions - e.g. allow local language links to be used for cases that wikidata cannot cover. [15:38:32] DanielK_WMDE: it seems strange to me too, but I can't write an old interwiki on WP:es [15:38:38] You can [15:38:39] can be a "dummy" title [15:38:53] aude: Usually the main page is used for that in MW [15:39:00] Harmonia_Amanda: "can't"? what happens if you try? [15:39:13] DanielK_WMDE: error message [15:39:30] Harmonia_Amanda: what error message, exactly? [15:39:36] saying that old interwiki aren't to be used now that wikidata exists [15:39:43] i thought you were talking about some local policy... [15:39:48] Harmonia_Amanda: From an AbuseFilter? [15:39:57] hoo: yes exactly [15:40:05] Harmonia_Amanda: generated by an AbuseFilter rule, I assume. [15:40:09] yea [15:40:10] I should kill this extension [15:40:14] :'-( [15:40:15] well, change the rule [15:40:19] this doesn't make sense. [15:40:34] Harmonia_Amanda: Link to the filter? [15:40:35] DanielK_WMDE: i would like to, but I ain't active on WP:es [15:40:46] i just try to sort the interwikis [15:41:08] tell them they have a problem with this rule, then [15:41:18] Yep [15:41:30] but never, ever, ever convert redirects to link to them [15:41:36] someone will have to clean that up one day [15:41:46] hoo: ok, I understand :) [15:42:02] hoo: if i can link with old interwikis, I won't try that :) [15:42:47] DanielK_WMDE: So... saw my comments about changing core? [15:43:04] DanielK_WMDE: hoo https://es.wikipedia.org/wiki/Especial:FiltroAntiAbusos/14 [15:43:23] hoo: yes. fix the documentation. ideally, give examples of when this might typically be null (API calles?) [15:43:35] (maintenance scripts?) [15:44:42] action=ajax apparently [15:44:44] mh... that will probably need further digging [15:44:53] then they set dummy [15:45:03] action=ajax.... ugh [15:45:09] that's still there? [15:45:11] might be my fault that this still exists >_< [15:45:22] DanielK_WMDE: May I slap you? :D [15:45:35] I guess nobody ever ported CategoryTree to use the API :) [15:45:39] Harmonia_Amanda: Yikes... :/ [15:46:09] hoo: you understand now why i was happy that wikidata could be used for redirects ;) [15:46:21] aude: what'S the patch I should urgently review? [15:46:47] Harmonia_Amanda: actually, you shouldn't be able to select a redirect as the target for a sitelink... [15:46:56] it should automatically be resovled to the actual page title [15:46:58] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/119311/ [15:46:58] Harmonia_Amanda: Yeah... I will try to find someone to talk about that later... but doing stuff for now [15:47:16] DanielK_WMDE: That works :) [15:47:18] aude: will do [15:47:18] i can next poke at removing entity content there but not today [15:47:48] uh, wtf? [15:47:55] DanielK_WMDE: did you change removing enetitycontent from the API get merged? :> [15:48:37] addshore: yes [15:48:52] (03Abandoned) 10Addshore: Special:MergeItems error message should be improved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118583 (owner: 10Karan) [15:49:09] if we have entity content, waht is the recommended way to get namespace for it? [15:49:15] we have no title [15:49:43] ok, NamespaceUtils::getEntityNamespace( $model )? [15:49:45] uh... settings? :/ [15:49:58] Yeah, that one derives from the settings [15:50:06] not awesome, but ok [15:52:54] ok... after poking at the wgTitle thing... wtf [15:53:39] I'm not sure when it's going to be null and when not [15:56:02] Ok, the API sets a fake on, soe does index.php [15:56:09] but I'm not sure about maint. scripts [15:56:15] * one, so [15:57:08] i think there are hacks around for these edge cases in core [15:57:50] aude: I'm trying to get an overview [15:57:57] grep -r 'wgTitle =[^=]' [16:00:28] DanielK_WMDE: This whole thing is super messy (surprise :P) [16:01:31] (03PS2) 10Daniel Kinzler: (bug 62425) Property of main snak must not change. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 [16:03:29] hoo, aude: I suggest to make RequestContext issue a wfWarn when it hits wgTitle being null, and then fall back to the main page. [16:03:55] hmmm [16:03:57] this way, production code stays B/C, but tests will fail, hopefully leading to the issue being fixed... [16:04:38] in the case we have, what about making a dummy title 'NewItem' (in entity ns) [16:04:55] i think it would get set to the entity id once that is assigend [16:06:03] mh [16:06:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 (owner: 10Daniel Kinzler) [16:06:33] Tobi_WMDE: did you remove https://bugzilla.wikimedia.org/show_bug.cgi?id=62425 from the sprint? [16:06:48] addshore: here now ;-) wasup? [16:07:03] aude: well, who controls the Title returned from the context? How would be supply it to the hook? [16:07:28] to spam blacklist? [16:07:36] Lydia_WMDE: why we can not merge https://gerrit.wikimedia.org/r/#/c/110401/ ? :> [16:08:21] Lydia_WMDE: going to re-add it again as it is no longer blocked by https://bugzilla.wikimedia.org/show_bug.cgi?id=62927 [16:08:24] addshore: because i wanted redirects to be automatically created [16:08:30] Tobi_WMDE: ok thx [16:09:27] but but, Lydia_WMDE, people already merge items all the time :P [16:09:38] and redirects are not automatically created... as they dont exist [16:09:40] Tobi_WMDE: and https://bugzilla.wikimedia.org/show_bug.cgi?id=49583 ? [16:09:48] thus merging this and getting out of the review queue will change nothing! :P [16:10:20] addshore: i know - the difference is api vs ui [16:10:22] but alright [16:10:30] merge it already so you all shut up :P [16:10:39] Lydia_WMDE: this is blocked by https://bugzilla.wikimedia.org/show_bug.cgi?id=62927 and needs to be addressed after that. probably not in this sprint anymore.. [16:10:41] Lydia_WMDE: there is a gadget which has a merge tab in the UI :P [16:10:53] Tobi_WMDE: ok thx [16:11:55] addshore: stalking my GitHub repos now are we? [16:12:49] JeroenDeDauw: maybe ;p [16:13:11] Lydia_WMDE: see http://new.tinygrab.com/1becbe2e78a9e44da292bedb743a4b505048909f9a.png and http://new.tinygrab.com/1becbe2e78a2bedbba78bbe9f1d81d820dfd150b2f.png :P [16:13:20] aude: seems like the referenced entities have no labels at all after applying your patch [16:13:27] still poking at it [16:13:29] addshore: i know [16:13:37] huh [16:13:58] addshore: anyway - merge it - i'll remove my veto ;-) [16:14:27] (03CR) 10Addshore: "This is officially unblocked :P" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [16:14:49] (03CR) 10Tobias Gritschacher: "No longer blocked anymore according to Lydia_WMDE" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [16:15:09] (03PS8) 10Addshore: Take SpecialMergeItems out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 [16:15:10] addshore: lol [16:15:16] \o/ [16:15:18] rebase! :D [16:15:26] aude: oh, wait. i think it's just that my terms table is broken [16:15:33] and... we don't have a script to rebuild that, do we? [16:15:56] DanielK_WMDE: deleteAllData.php [16:15:58] ;) [16:15:59] lol guys [16:16:01] <3 [16:16:06] DanielK_WMDE: not that i know [16:16:11] grr [16:16:17] might just have to make one [16:17:49] [13Number] 15JeroenDeDauw comment on pull request #4 14924f4cb: bad addshore. 0.4 alpha 02http://git.io/8Ji1yQ [16:18:39] [13Number] 15JeroenDeDauw 04deleted 06un-localizer-names at 14924f4cb: 02http://git.io/wuYgwA [16:19:04] [13Number] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/xo9T9g [16:19:04] 13Number/06master 142369726 15Jeroen De Dauw: Update Number.php [16:19:34] Tobi_WMDE: tagged that one for the next sprint btw - then we can reevaluate [16:19:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [16:20:26] Lydia_WMDE: ok [16:20:33] you're here tomorrow? [16:21:28] (03PS1) 10Aude: Add check for EditFilterMergedContent handler registered in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 [16:22:02] Lydia_WMDE: ^^? [16:22:10] yes [16:22:14] ok [16:24:02] * JeroenDeDauw goes hunting for a breakfast [16:25:52] (03CR) 10Hoo man: [C: 04-1] Add check for EditFilterMergedContent handler registered in EditEntity (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [16:26:21] JeroenDeDauw: breakfast ? :O [16:26:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [16:28:09] hoo: what else would we return? [16:28:18] nothing? [16:28:24] hmmm [16:28:25] At least be consistent [16:28:37] make both return a status or make it null in all cases [16:28:43] but don't mix that up for no reason IMO [16:28:51] where does it not return status? [16:29:14] ah [16:29:15] ok [16:29:32] (03CR) 10Tobias Gritschacher: [C: 032] Take SpecialMergeItems out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [16:29:55] (03Merged) 10jenkins-bot: Take SpecialMergeItems out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [16:30:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [16:30:07] DanielK_WMDE: https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/22656/console [16:30:15] addshore: aude: can I haz a test changeset on Wikidata repository? [16:30:56] hoo: only one failure in core? sounds doable... [16:31:07] DanielK_WMDE: Nah, it skipped the other tests :P [16:31:11] API and stuff [16:31:18] hmh [16:31:32] but I guess those aren't affected as the API and index.php set a pseudo-title [16:32:38] well, just submit your patch, jenkins will tell you :) [16:33:01] yeah... will try to get this passing today [16:33:41] (03PS2) 10Aude: Add check for EditFilterMergedContent handler registered in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 [16:33:59] (03PS8) 10Tobias Gritschacher: Update EntityId expert(s) to reflect changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [16:34:02] (03PS14) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [16:34:20] (03CR) 10Aude: Add check for EditFilterMergedContent handler registered in EditEntity (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [16:34:32] Tobi_WMDE: ok [16:37:57] (03CR) 10Daniel Kinzler: [C: 032 V: 031] "works for me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [16:39:13] (03PS1) 10Aude: New build, bug fixes for special pages, entity selector [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120557 [16:39:19] (03Merged) 10jenkins-bot: Make js config handling more robust when config is not in ParserCache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [16:39:27] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [16:39:48] shall make another build with the last thing, but this one for tobi [16:39:58] Ok, was about to ask that [16:40:34] * aude hopes not to find any more bugs :) [16:40:57] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/120557/ [16:41:46] DanielK_WMDE: Any idea how the Context change could break Qunit tests? https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/17969/console [16:41:58] 16:39:02 Warning: PhantomJS timed out, possibly due to a missing QUnit start() call. Use --force to continue. [16:42:15] I think I see [16:42:58] "MainPage" will work as a fallback, i guess [16:43:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [16:43:29] but not totally safisfied with that for spam blacklist, but don't have better idea [16:43:54] * @author Katie Filbert < aude.wiki@gmail.com > [16:43:56] :P [16:43:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [16:44:03] huh [16:44:18] In the core test I just broke [16:44:32] a special page1 [16:44:32] ! [16:44:53] no like warnings [16:45:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [16:45:09] no like warnings << huh? [16:45:19] phpunit [16:45:46] (03PS8) 10Daniel Kinzler: Inject EntityPermissionChecker into EditEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 [16:46:10] we can set title there [16:46:23] aude: You mean for all tests? [16:46:33] I'm currently doing it per test [16:46:39] this test [16:46:54] yep, just did that :) [16:47:00] k [16:47:04] Still have to look at the Qunit's, though [16:48:14] hoo: i wonder how many places there are issues and no test coverage? [16:48:25] hope none [16:48:52] (03CR) 10Daniel Kinzler: [C: 04-1] "small doc issue. fine otherwise" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [16:48:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9ef9f50 : addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21439524 [16:48:57] mh, we only warn so that shouldn't be such an issue [16:49:55] if ( $this->context->getTitle() === null ) { [16:49:56] $this->context->setTitle( $this->parseTitle() ); [16:49:58] DanielK___WMDE, ^ [16:50:01] /db/DatabaseError.php:if ( $context->getTitle() ) { [16:50:05] not looked at that [16:50:07] What shall I do for such a case? [16:50:21] that of course triggers the warning [16:50:22] ugly [16:50:28] and it's supposed to return null [16:50:36] * hoo kills MediaWiki [16:50:39] hoo: well, it wqould be for calling code that relies on getTitle() to return null in some vitally important edge case. [16:50:42] it uses main page as a fallback there [16:51:06] in a complicated way [16:51:17] :P [16:51:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120557 (owner: 10Aude) [16:51:26] this is bad [16:51:27] gotta run and fix dinner [16:51:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [16:51:50] when it can just do TItle::newMainPage() [16:51:53] Title* [16:51:56] Having a function which says @return Title but people rely on it returning null at time [16:51:56] s [16:54:31] mh [16:54:45] not sure how to continue there [16:55:03] making it return a bogus title when people check for it being set sounds wrong [16:55:24] (03PS3) 10Aude: Add check for EditFilterMergedContent handler registered in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 [16:55:52] * aude will just disable spam blacklist for now, but not happy about it [16:56:37] decoupling api and entitycontent will make the test failure "disappear" but obviously the issue is still there [16:56:57] yeah... we need a solution [16:57:10] and if it's only to properly document that getTitle might return null [16:57:57] (03CR) 10Aude: Add check for EditFilterMergedContent handler registered in EditEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [17:00:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [17:00:35] (03CR) 10Hoo man: [C: 032] ":)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [17:00:49] one small thing :) [17:00:56] (03Merged) 10jenkins-bot: Add check for EditFilterMergedContent handler registered in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [17:01:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120551 (owner: 10Aude) [17:01:06] alright, time to go home, eat, nap [17:03:30] cu :) [17:05:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1e7ccff : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21440398 [17:08:45] wtf... I locally created a Property named number which is " Data type: Commons media file " [17:09:39] :P [17:16:31] (03CR) 10Bene: "Why abandoned?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [17:16:32] hoo: Did you create a media one with 'string'? If not, do it pls :D [17:16:59] :P [17:17:56] (03CR) 10Addshore: "Messy rebase, will just make a new clean patchset when we get around to removing it from experimental" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [17:18:08] (03CR) 10Addshore: "Unless you want to rebase it ;p" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [17:38:43] woo! my 'g' script now works with both github/git and gerrit [17:39:32] * hoo wonders what a g-script is [17:39:43] hoo: https://github.com/addshore/bin/blob/master/g :P [17:40:57] only got 1 more little feature to add to it really :P which is to checkout / cherry pick changesets straight from gerrit using the changeid :P [17:41:08] well, not the changeid the id in the url :P [17:41:42] addshore: A shorthand for git? :P [17:41:48] yus :p [17:41:50] and git's sub commands [17:42:00] I wonder whetever that's worth the time spend :P [17:42:02] g c [17:42:04] g p [17:42:04] * whether [17:42:07] done :P [17:42:26] "whetever" ... when you can't decide between whatever and whether... wtf brain [17:42:34] :> [17:43:46] it started off as a script so that I didnt forget git push origin HEAD:refs/publish/master xD [17:44:23] I could probably include my 'pullall' script in it also [17:51:04] (03PS1) 10Thiemo Mättig (WMDE): JSON dump generator: code clean-up and documentation update [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120567 [17:55:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120567 (owner: 10Thiemo Mättig (WMDE)) [18:14:06] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Inject EntityPermissionChecker into EditEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [18:15:07] (03Merged) 10jenkins-bot: Inject EntityPermissionChecker into EditEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [18:15:13] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [18:25:21] should we merge https://gerrit.wikimedia.org/r/#/c/120557/ ? [18:35:55] Tobi_WMDE: it's for you do to [18:35:57] to do* [18:36:19] when do selenium tests run? [18:37:02] aude: oh. yeah. thx! ;) seems it did not trigger the browsertests yet. that's good. let's see if they get triggered on merge [18:37:21] (03CR) 10Tobias Gritschacher: [C: 032] New build, bug fixes for special pages, entity selector [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120557 (owner: 10Aude) [18:40:48] (03Merged) 10jenkins-bot: New build, bug fixes for special pages, entity selector [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120557 (owner: 10Aude) [18:42:34] (03PS1) 10Hoo man: Fix scraping of quantity values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120570 [18:47:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120570 (owner: 10Hoo man) [19:33:16] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/mtrSSw [19:33:16] 13WikibaseInternalSerialization/06master 14d527b14 15Jeroen De Dauw: Update Terms.php [19:44:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120530 (owner: 10Aude) [19:59:29] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120557 (owner: 10Aude) [20:11:20] hah, the Diff tests actually run faster on hvvm https://travis-ci.org/wmde/Diff/builds/21427930 [20:11:21] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] (bug 62425) Property of main snak must not change. (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 (owner: 10Daniel Kinzler) [20:14:12] (03PS1) 10Hoo man: Fix change summary in SpecialSetSiteLink if no badges are set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120590 [20:15:31] (03PS2) 10Hoo man: Fix change summary in SpecialSetSiteLink if no badges are set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120590 [20:20:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120590 (owner: 10Hoo man) [20:24:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120590 (owner: 10Hoo man) [20:26:02] (03Abandoned) 10Tpt: Position the otherProjects section just before language links section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119101 (owner: 10Tpt) [20:26:26] Lydia_WMDE: Hi! [20:27:23] Lydia_WMDE: I've the community agreement for "other project" section in fr.wikisource: https://fr.wikisource.org/wiki/Wikisource:Scriptorium/Mars_2014#Activation_d.27une_automatisation_de_la_section_.22Compl.C3.A9ment.22 [20:30:33] Tpt: Nice :D [20:32:05] JohnLewis: fr.wikisource community love new tools and Wikidata. i belive that most of big contributor here have already made more than 100 contributions to Wikidata. [20:33:32] Nice to hear. I might shove fr.wikisource in next week's weekly summary if they make use of Wikidata's data (assuming phase 2 is out :p) [20:35:33] Tpt: yay! [20:35:49] Tpt: and that is really great to hear [20:36:00] Is Phase 2 even out on Wikisource Lydia_WMDE or am I making that up? [20:36:04] JohnLewis: good idea! [20:36:08] JohnLewis: it is [20:36:22] Well I guess I've got next week dealt with then :p [20:36:33] :D [20:37:12] Lydia_WMDE: I think that there are no blocker for deployment. I've abandonned https://gerrit.wikimedia.org/r/#/c/119101 that is I think unneded. [20:37:44] Tpt: ok cool [20:37:49] let's go for it then [20:38:54] Lydia_WMDE: I belive that the deployment of the code will be tomorrow, isn't it? [20:39:25] should be yes [20:39:37] unless anything unforseen happens [20:42:30] Tpt: Does this need a configuration change? [20:42:38] hoo: Yes [20:42:46] That's not scheduled yet [20:43:20] otherProjectsLinks should be set [20:45:30] I'm working on a wmf-config change [20:54:08] Lydia_WMDE: https://gerrit.wikimedia.org/r/#/c/120595/1 [20:55:00] Tpt: \o/ [20:58:40] Tpt: I'll open a bug unless you are doing it atm. [20:59:08] JohnLewis: Thanks. [20:59:13] Sorry for that... it's just the usual process for configuration changes [21:00:02] hoo|away: Meh :p Process were made to... be broken if you want to be punished/warned/that st00f :D [21:00:30] JohnLewis: :D [21:01:18] It's weird opening a bug and seeing myself as a default CC :/ [21:02:13] * Tpt love to say to other people to open bugs but really don't like to fill bugs. [21:05:19] JohnLewis: Thanks [21:05:48] Tpt: Done, +1'd myself and CC'd Lydia_WMDE to the bug :) [21:06:22] JohnLewis: Thanks a lot :-) [21:25:12] hoo|away: https://pl.wikipedia.org/w/index.php?title=Lossarnach&oldid=39099959&diff=prev if really the old interwikis system should be used instead of just wikidata for redirects, maybe *all* wikipedia need to know that, because reverts are frequent [21:29:31] hoo|away: if every wikipedia accepted the old interwikis, the problem wouldn't exist. But since wikidata exist, all WP seems to want to eradiacte the old interwikis [21:39:39] Harmonia_Amanda: *sigh* [21:40:40] hoo: hundred of my edits have been reverted when i tried to repair the old interwikis [21:45:20] !help [21:46:32] that was short :p [21:47:32] Lydia_WMDE: Fancy a comment on the above since you know, you job :p [21:47:45] *your [21:48:38] JohnLewis: to Harmonia_Amanda you mean? [21:48:43] Sí [21:48:48] hehe [21:49:06] You could comment on Autoniil if you want but, they left :p [21:49:18] Harmonia_Amanda: well there is not much i can say besides "there and will be cases that wikidata can't cover so local interwikis are still useful" [21:49:24] hehe [21:49:33] Lydia_WMDE: yes, I know :s [21:50:07] Lydia_WMDE: i don't really know what to do, but it's so tiring >< [21:50:15] i understand [22:16:59] aude: hey... what about the backports? [22:17:00] :) [22:19:23] have to make a new build [22:19:48] Yeah, thought so [22:20:25] (03PS1) 10Aude: Make js config handling more robust when config is not in ParserCache [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120628 [22:20:38] can wait for jenkins [22:25:05] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120676 (owner: 10L10n-bot) [22:27:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120628 (owner: 10Aude) [22:27:55] (03CR) 10Aude: [C: 032] Make js config handling more robust when config is not in ParserCache [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120628 (owner: 10Aude) [22:28:18] hoo: there is a filter too on WP:zh, which forbid old interwiki [22:28:59] *double sigh* [22:29:05] Not sure how to react to that [22:30:07] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120676 (owner: 10L10n-bot) [22:30:54] (03Merged) 10jenkins-bot: Make js config handling more robust when config is not in ParserCache [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120628 (owner: 10Aude) [22:31:00] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120628 (owner: 10Aude) [22:34:22] (03CR) 10Aude: [C: 032] Fix change summary in SpecialSetSiteLink if no badges are set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120590 (owner: 10Hoo man) [22:34:35] although i keep finding more and more other issues :/ [22:34:51] (03Merged) 10jenkins-bot: Fix change summary in SpecialSetSiteLink if no badges are set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120590 (owner: 10Hoo man) [22:34:58] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120590 (owner: 10Hoo man) [22:35:10] aude: We can delay it further w/o much harm, I guess [22:35:27] nothing urgent [22:35:29] tomorrow, I mean... not endless [22:35:44] only in special set site link (experimental) [22:36:35] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/acf252e : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21465296 [22:36:41] aude: That bug will also hit w/o exp. mode AFAIS [22:38:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=63036 [22:39:07] looking [22:39:11] the one you fixed, suppose i can put in :) [22:39:40] Ok, my fix is needed on the branch, that bug doesn't need to be fixed now [22:39:41] (03PS1) 10Aude: Fix change summary in SpecialSetSiteLink if no badges are set [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120686 [22:40:13] I hate it when the bot reopens my bugs -.- [22:40:26] there is more to do to cleanup special set site link (etc), add tests, de-duplicate more of the code with what api does etc [22:40:35] can be done tomorrow or whenever [22:40:46] * aude can poke at it maybe [22:43:41] (03CR) 10Aude: [C: 032] "there are hardly any tests for Special:SetSiteLink, so no use to wait for jenkins (manually verified this)" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120686 (owner: 10Aude) [22:44:04] (03Merged) 10jenkins-bot: Fix change summary in SpecialSetSiteLink if no badges are set [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120686 (owner: 10Aude) [22:44:11] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120686 (owner: 10Aude) [22:44:51] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120686 (owner: 10Aude) [22:49:39] (03PS1) 10Aude: New build, improves output page js config handling, fix SetSiteLink summary [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120688 [22:50:25] :) [22:50:31] Waiting for jenkins [22:50:32] wait for jenkins [22:50:55] :P [22:55:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/78cf447 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21466011 [22:57:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120688 (owner: 10Aude) [22:58:28] (03CR) 10Aude: [C: 032] New build, improves output page js config handling, fix SetSiteLink summary [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120688 (owner: 10Aude) [23:01:39] (03Merged) 10jenkins-bot: New build, improves output page js config handling, fix SetSiteLink summary [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120688 (owner: 10Aude) [23:24:41] (03PS1) 10Aude: Fix OutputPageBeforeHtmlRegisterConfig handler return value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120700 [23:25:23] no idea how i didn't get these issues on my dev wiki [23:25:30] (although don't have translate) [23:28:42] hoo: ^ [23:28:47] (03CR) 10Hoo man: [C: 032] Fix OutputPageBeforeHtmlRegisterConfig handler return value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120700 (owner: 10Aude) [23:29:07] that's why you shouldn't pass such stuff by reference [23:29:16] (03Merged) 10jenkins-bot: Fix OutputPageBeforeHtmlRegisterConfig handler return value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120700 (owner: 10Aude) [23:29:19] yeah [23:29:23] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120700 (owner: 10Aude) [23:29:40] I just found the same thing myself, so I assume it's really that [23:29:41] we kept changing how to handle $out [23:29:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120700 (owner: 10Aude) [23:30:45] (03PS1) 10Aude: Fix OutputPageBeforeHtmlRegisterConfig handler return value [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120702 [23:30:49] let's wait foro jenkins [23:30:51] for* [23:30:57] there or on the build? [23:31:06] both [23:31:08] I guess [23:31:40] master is done and jenkins said ok [23:31:49] although there are no tests for hooks [23:31:57] (there could be i suppose) [23:34:11] * aude impatient [23:34:12] It's possible, but a lot of work to get a decent coverage there [23:34:30] I just did some volunteer CR on a Varnish change while waiting :P [23:34:41] nice [23:35:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120702 (owner: 10Aude) [23:35:59] (03CR) 10Aude: [C: 032] Fix OutputPageBeforeHtmlRegisterConfig handler return value [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120702 (owner: 10Aude) [23:36:23] (03Merged) 10jenkins-bot: Fix OutputPageBeforeHtmlRegisterConfig handler return value [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120702 (owner: 10Aude) [23:36:30] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120702 (owner: 10Aude) [23:38:28] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/642bf4d : aude The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21469427 [23:39:42] (03PS1) 10Aude: New build, fix OutputPageBeforeHtml hook [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120706 [23:39:51] :) [23:39:52] * aude waits again [23:47:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120706 (owner: 10Aude) [23:47:44] (03CR) 10Hoo man: [C: 032] New build, fix OutputPageBeforeHtml hook [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120706 (owner: 10Aude) [23:47:46] (03CR) 10Aude: [C: 032] New build, fix OutputPageBeforeHtml hook [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120706 (owner: 10Aude) [23:47:49] hah [23:47:54] faster :D [23:48:05] +4! [23:48:19] heh :) [23:51:08] (03Merged) 10jenkins-bot: New build, fix OutputPageBeforeHtml hook [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120706 (owner: 10Aude)