[01:22:45] [13WikidataBuilder] 15JeroenDeDauw comment on commit 14f378c18: You realize you did not create a PR? 02http://git.io/e5t4PA [01:24:47] [13WikidataBuilder] 15JeroenDeDauw comment on commit 14f378c18: You can always do a wget for the latest version or exec the self-update command. Or have an option to point to an executable the system already has. Not sure this is worth the effort though. 02http://git.io/yvFLjQ [05:12:07] [travis-ci] wmde/WikibaseQueryEngine/string/fa5d068 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21734931 [05:16:03] [travis-ci] wmde/WikibaseQueryEngine/monotext/224984a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21734991 [05:19:37] [travis-ci] wmde/WikibaseQueryEngine/latlon/be13f54 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21735033 [05:23:46] [travis-ci] wmde/WikibaseQueryEngine/id/6fb2ab6 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21735171 [05:38:57] [travis-ci] wmde/WikibaseQueryEngine/sqlstoreintns/17bb809 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21735633 [05:43:59] [travis-ci] wmde/WikibaseQueryEngine/sqlstoreintns/19e7b77 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21735714 [05:56:28] [travis-ci] wmde/WikibaseQueryEngine/array/dd35b71 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21736099 [06:04:56] !nyan [06:04:57] ~=[,,_,,]:3 [06:05:21] Lydia_WMDE: why is the daily so late? I can't stay up that long. Crazy people! [08:46:21] [13ValueView] 15adrianlang created 06dontPassAutoCharacteristics (+1 new commit): 02http://git.io/HLozIw [08:46:21] 13ValueView/06dontPassAutoCharacteristics 1419075c3 15Adrian Lang: Don't pass precision and calendarmodel if set to auto [08:46:41] [13ValueView] 15adrianlang opened pull request #37: Don't pass precision and calendarmodel if set to auto (06master...06dontPassAutoCharacteristics) 02http://git.io/EufOpQ [08:48:15] [13ValueView] 15adrianlang 04force-pushed 06dontPassAutoCharacteristics from 1419075c3 to 145fc118a: 02http://git.io/Fcd9aQ [08:48:15] 13ValueView/06dontPassAutoCharacteristics 145fc118a 15Adrian Lang: Don't pass precision and calendarmodel if set to auto [09:42:43] (03CR) 10Tobias Gritschacher: [C: 032] Initialize ValueView on the correct DOM element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121374 (owner: 10Adrian Lang) [09:42:48] :O [09:42:59] Lydia_WMDE: everything is in italian :O [09:43:11] lolwat [09:43:14] (03Merged) 10jenkins-bot: Initialize ValueView on the correct DOM element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121374 (owner: 10Adrian Lang) [09:43:20] addshore: :D [09:43:34] addshore: but püeople seemed to have loved your talk judging from twitter [09:43:35] :P [09:43:43] just finished my talk ;p now its all switched back to italian :P [09:44:14] [travis-ci] wmde/WikibaseQueryEngine/coveralls/9c2e351 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21744279 [09:44:59] Lydia_WMDE: how can you tell? the tweets are in italian too :P Do you speak italian? [09:45:15] addshore: spanish helps and twitter has a translate feature :P [09:45:26] why I see no translate? [09:45:33] [13ValueView] 15JeroenDeDauw comment on pull request #37 145fc118a: The phrasing here is not optimal. It should inform the user about what changed, so something like this is much better:... 02http://git.io/TeNvdQ [09:45:37] go to an individual tweet's page [09:45:44] and then you should see a translate button [09:46:19] Lydia_WMDE: is everyone we expect today already here? If so, can haz daily at 11:00? Then I will attend ;p [09:46:23] addshore: also: add your slides to the folder ;-) [09:46:38] JeroenDeDauw: daniel is missing? and thiemo? [09:46:43] and katie [09:47:11] Lydia_WMDE: well do, and the ones from last week :) [09:47:18] \o/ [09:47:24] will, daily? [09:47:32] oh wait, thats in an hour right? [09:48:21] yes [09:51:10] JeroenDeDauw: did I see something about a changeopfactory/? :P [09:52:48] addshore: yes, danielk has been doing stuff, generally good [09:52:54] :D [09:52:57] https://gerrit.wikimedia.org/r/#/c/121316/ [09:53:06] and follow up [09:54:19] I will take a look at those :) [09:58:50] [travis-ci] wmde/WikibaseDatabase/pdoresult/b6db975 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/21745042 [09:59:05] [13ValueView] 15snaterlicious 04force-pushed 06rmmwext from 145ebf36c to 14f77b3f9: 02http://git.io/0-bn5w [09:59:05] 13ValueView/06rmmwext 14d4144ce 15snaterlicious: Renamed ExpertFactory to ExpertStore [09:59:05] 13ValueView/06rmmwext 141005b01 15snaterlicious: Update to DataValuesJavaScript version 0.4.0 [09:59:05] 13ValueView/06rmmwext 14f77b3f9 15snaterlicious: Removed mw.ext.valueView [10:00:23] (03PS1) 10WikidataBuilder: New Wikidata Build - 28/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 [10:01:53] [13ValueView] 15adrianlang comment on pull request #37 145fc118a: Maybe that's better, but it's not what we currently do in the change log. If we were to change that, we should do it for all the other entries, too. 02http://git.io/PhNCVA [10:03:18] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 28/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 (owner: 10WikidataBuilder) [10:03:33] [13ValueView] 15JeroenDeDauw comment on pull request #37 145fc118a: Looks like the change log did star off with the correct phrasing. 02http://git.io/2_lVQA [10:08:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 (owner: 10WikidataBuilder) [10:11:00] (03PS2) 10Addshore: New Wikidata Build - 28/03/2014 10:00 .. [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 (owner: 10WikidataBuilder) [10:12:57] Tobi_WMDE: around? [10:13:31] (03CR) 10Addshore: [C: 032] WikibaseRepo: Cleanup use section, comments and line lengths [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121362 (owner: 10Thiemo Mättig (WMDE)) [10:14:24] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 28/03/2014 10:00 .. [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 (owner: 10WikidataBuilder) [10:15:24] [13WikidataBuilder] 15filbertkm opened pull request #19: Update composer.phar (06master...06composer) 02http://git.io/27qRCw [10:15:24] (03PS2) 10Addshore: Make travis test against php 5.6 and hhvm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 [10:16:44] [13WikidataBuilder] 15addshore pushed 1 new commit to 06master: 02http://git.io/9K5SEQ [10:16:44] 13WikidataBuilder/06master 1459db4f0 15addshore: Merge pull request #19 from filbertkm/composer... [10:16:45] <7JTAADZX7> [13WikidataBuilder] 15addshore closed pull request #19: Update composer.phar (06master...06composer) 02http://git.io/27qRCw [10:16:50] \o/ [10:17:18] * aude doing all the github stuff on command line [10:17:34] [13ValueView] 15adrianlang created 06dontInitFormatterWithoutValue (+1 new commit): 02http://git.io/T82ydw [10:17:34] 13ValueView/06dontInitFormatterWithoutValue 1487cc81c 15Adrian Lang: Don't initialize formatter in _updateTextValue if no value to format [10:18:23] [13ValueView] 15adrianlang opened pull request #38: Don't initialize formatter in _updateTextValue if no value to format (06master...06dontInitFormatterWithoutValue) 02http://git.io/-_sG5A [10:18:33] [13WikidataBuilder] 15filbertkm 04deleted 06composer at 14f378c18: 02http://git.io/p0zyPg [10:18:41] aude, yay ;p [10:18:58] aude: you can make pull request from commandlinE? [10:19:07] https://github.com/github/hub [10:19:26] always annoys me to use the web interface for that [10:21:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 (owner: 10WikidataBuilder) [10:21:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 (owner: 10Addshore) [10:21:20] aude: see the above changeset, wmfjenkins dies in the tests, our jenkins works [10:21:33] that happened yesterday [10:21:45] don't know why but maybe some random issue [10:22:17] are we just ignoring it? ;p [10:24:21] does travis test the build? [10:24:34] maybe we can try tests locally? [10:25:58] [13WikibaseDatabase] 15addshore 04deleted 06pdoresult at 14b6db975: 02http://git.io/4B1SLw [10:26:10] aude: yes travis does [10:26:18] Slow dennyvrandecic is slow! https://bugzilla.wikimedia.org/show_bug.cgi?id=23030 [10:26:32] wait, ... wtf https://travis-ci.org/wikimedia/mediawiki-extensions-Wikidata/builds [10:26:54] aude: https://github.com/wmde/WikidataBuilder/issues/18 [10:27:22] what's the issue? [10:27:31] no .travis.yml? [10:27:38] yup [10:27:43] and the builder cant / wont currently copy it [10:27:44] rage [10:27:47] might be a nice easy fix [10:27:56] hahahaha [10:28:16] I'd have a look, though first need to install node, so not today [10:28:59] addshore: try closing and reopining more, perhaps that helps? https://github.com/wmde/WikidataBuilder/issues/18 [10:29:18] haha :P I doubt it [10:30:05] JeroenDeDauw: your stuff in query / engine is merged [10:31:13] addshore: weee [10:31:16] oh, all the things [10:31:29] :P [10:31:33] dont know where the bot went :P [10:33:33] woo, aude, installed hub :> [10:33:44] how to integrate it into my 'g' command ;p [10:34:03] :) [10:38:05] addshore: g toggles gravity on/off? [10:39:22] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/WOa9ZQ [10:39:22] 13ValueView/06master 141b60b06 15thiemowmde: Merge pull request #38 from wmde/dontInitFormatterWithoutValue... [10:39:43] No :p [10:40:52] I see no hangout for the daily " [10:42:08] same link every day [10:42:29] Got it :p [10:42:51] Apparently it doesn't appear in the Google calander ap on android.... [10:43:55] Mhhm, says I can't join anyway.... [10:51:26] I just finished a script to make P131 more precise :) [10:51:47] https://www.wikidata.org/w/index.php?title=Q564530&diff=prev&oldid=118097389 [11:07:40] addshore: hey [11:13:12] [13DataValuesJavascript] 15tobijat closed pull request #35: Renamed Value*Factory to Value*Store (06master...06rnfactories) 02http://git.io/LDfXrQ [11:13:32] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/3tx36g [11:13:32] 13DataValuesJavascript/06master 14197902e 15Tobi Gritschacher: Merge pull request #36 from wmde/rmmwext... [11:14:24] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/oYEw_A [11:14:24] 13DataValuesJavascript/06master 146f4ca5c 15Tobi Gritschacher: Update README.md [11:25:07] [13ValueView] 15adrianlang created 06setNullValue (+1 new commit): 02http://git.io/0dxqCA [11:25:07] 13ValueView/06setNullValue 14711b7cb 15Adrian Lang: Don't throw an error when setting null value on a ValueView [11:26:22] [13ValueView] 15adrianlang opened pull request #40: Don't throw an error when setting null value on a ValueView (06master...06setNullValue) 02http://git.io/pY6gMg [11:28:06] Adrian_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=63225 [11:29:02] \o/ fixit!! [11:32:55] Tobi_WMDE: any chance you can log into to the WikidataBuilder user on github and change the email :P [11:33:02] apparently it is currently my email :/ [11:57:42] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 28/03/2014 10:00 .. [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 (owner: 10WikidataBuilder) [12:00:03] Tobi_WMDE: get that email? [12:05:01] (03PS1) 10Thiemo Mättig (WMDE): Cleanup WikibaseClient "use" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121654 [12:09:47] (03CR) 10Tobias Gritschacher: "We were only using properties this way. It did not work for items yet (that's the reason I fixed it)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 (owner: 10Tobias Gritschacher) [12:10:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121654 (owner: 10Thiemo Mättig (WMDE)) [12:11:51] (03CR) 10Addshore: [C: 04-1] "Well..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121654 (owner: 10Thiemo Mättig (WMDE)) [12:12:09] (03CR) 10Adrian Lang: [C: 032] Browsertests for statements with item values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 (owner: 10Tobias Gritschacher) [12:12:35] (03Merged) 10jenkins-bot: Browsertests for statements with item values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 (owner: 10Tobias Gritschacher) [12:39:47] (03CR) 10Jeroen De Dauw: [C: 032] "This still has more build than needed, but whatever, can always kill one later" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 (owner: 10Addshore) [12:43:44] (03CR) 10Jeroen De Dauw: [C: 04-1] Cleanup WikibaseClient "use" section (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121654 (owner: 10Thiemo Mättig (WMDE)) [12:46:45] (03CR) 10Jeroen De Dauw: Cleanup WikibaseClient "use" section (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121654 (owner: 10Thiemo Mättig (WMDE)) [12:49:07] (03CR) 10Tobias Gritschacher: [C: 04-1] [WIP] Add Cucumber test for Special:SetLabel (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [13:12:37] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121608 (owner: 10WikidataBuilder) [13:19:49] (03CR) 10Addshore: "you can never have enough build ;p" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 (owner: 10Addshore) [13:24:50] aude: clearly noticed I found the code for qrpedia xD [13:25:54] ") [13:26:04] :) [13:29:01] (03PS3) 10Thiemo Mättig (WMDE): Refactoring of basic Cucumber steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 [13:31:32] tata for now, back in a bit [13:33:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [13:35:21] [13ValueView] 15snaterlicious 04force-pushed 06rmmwext from 14f77b3f9 to 14db983e5: 02http://git.io/0-bn5w [13:35:21] 13ValueView/06rmmwext 14db983e5 15snaterlicious: Removed mw.ext.valueView [13:38:49] (03PS7) 10Thiemo Mättig (WMDE): [WIP] Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 [13:43:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [13:45:41] (03Draft2) 10Aude: Add snak variation css class in non-JS claim html [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 [13:47:04] (03CR) 10Aude: "to have data type / value mismatch errors styled like in JS, we'll need to modify / put different css class here" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 (owner: 10Aude) [13:50:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 (owner: 10Aude) [13:51:34] (03PS1) 10Tobias Gritschacher: Get rid of term "handle" in the context of items in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121669 [13:55:26] Lydia_WMDE: we need a maintenance script for populatign the query index :) [13:56:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121669 (owner: 10Tobias Gritschacher) [14:06:34] (03PS8) 10Thiemo Mättig (WMDE): [WIP] Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 [14:07:26] (03CR) 10Thiemo Mättig (WMDE): "Half done. I still need to rebase this on the other change in review right now." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [14:07:30] DanielK_WMDE: done [14:11:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [14:13:01] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Get rid of term "handle" in the context of items in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121669 (owner: 10Tobias Gritschacher) [14:13:25] (03Merged) 10jenkins-bot: Get rid of term "handle" in the context of items in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121669 (owner: 10Tobias Gritschacher) [14:17:50] [13ValueView] 15snaterlicious 04force-pushed 06rmmwext from 14db983e5 to 14dc36f7e: 02http://git.io/0-bn5w [14:17:50] 13ValueView/06rmmwext 14dc36f7e 15snaterlicious: Removed mw.ext.valueView [14:21:12] [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/fRrEPg [14:21:12] 13DataValuesJavascript/06master 14f3e39bf 15snaterlicious: Bump to version 0.5 [14:21:28] (03PS1) 10Adrian Lang: Stop registering event handlers twice in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121674 [14:22:23] [13ValueView] 15tobijat closed pull request #34: Removed mw.ext.valueView (06master...06rmmwext) 02http://git.io/mKiatw [14:22:38] [13DataValuesJavascript] 15snaterlicious tagged 060.5 at 06master: 02http://git.io/ndaEDg [14:22:48] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=63225 [14:24:23] addshore: would the changed email cause any issues? [14:24:38] shouldnt do :) [14:26:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121674 (owner: 10Adrian Lang) [14:27:16] [13ValueView] 15adrianlang 04force-pushed 06setNullValue from 14711b7cb to 141754952: 02http://git.io/wKJoew [14:27:16] 13ValueView/06setNullValue 141754952 15Adrian Lang: Don't throw an error when setting null value on a ValueView [14:27:17] addshore: what should I change it to? [14:27:36] it's currently wikidata-services@wikimedia.de which is fine I think? [14:27:54] is it O_o [14:27:56] This doesn’t look good. :( https://www.dropbox.com/s/5h0cuvn2l5nius1/Screenshot%202014-03-28%2015.27.50.png [14:28:08] go to a changeset and type in adam. as a reviewer :p [14:28:15] and it suggests wikidatabuilder! [14:28:26] [13ValueView] 15snaterlicious 04force-pushed 06correctErrorHandling from 14b46fd05 to 14e904454: 02http://git.io/PSQ0mQ [14:28:26] 13ValueView/06correctErrorHandling 14e904454 15Adrian Lang: Handle single parameter returned by rejected ValueFormatter/Parser promise [14:28:36] addshore: you sait wikidatabuilder on GitHub [14:28:43] are you talking about gerrit? [14:29:17] yus :P [14:29:31] so gerrit? [14:30:15] addshore: the WikidataJenkins already has wikidata-services@wikimedia.de - not sure if I can add this to another user then [14:30:31] :< [14:30:57] wikidata-services+1@wikimedia.de [14:31:08] you can add as many as you want (usulL [14:31:13] usually [14:32:16] +1? xD that works? :P [14:32:27] +nyancat would also work :) [14:33:04] :O [14:36:33] [13ValueView] 15thiemowmde closed pull request #40: Don't throw an error when setting null value on a ValueView (06master...06setNullValue) 02http://git.io/pY6gMg [14:40:23] (03CR) 10Thiemo Mättig (WMDE): "Sorry, I don't understand. It doesn't look like it's executed twice." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121674 (owner: 10Adrian Lang) [14:41:25] [13ValueView] 15adrianlang 04force-pushed 06dontPassAutoCharacteristics from 145fc118a to 14abdc03f: 02http://git.io/Fcd9aQ [14:41:25] 13ValueView/06dontPassAutoCharacteristics 14abdc03f 15Adrian Lang: Don't pass precision and calendarmodel if set to auto [14:41:36] [13Common] 15filbertkm opened pull request #6: Introduce DataValueMismatchException (06master...06mismatch) 02http://git.io/IBEVQQ [14:41:44] wheee, command line :) [14:42:57] DanielK_WMDE: if you like to review https://github.com/DataValues/Common/pull/6 [14:43:04] (03CR) 10Adrian Lang: "Try to reproduce the linked bug." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121674 (owner: 10Adrian Lang) [14:44:21] i suppose the data value types (e.g. "string") would not be translated [14:56:33] Is there a good place to start re: adding datasets? Can't really say I'm getting how to do it. Is most stuff bot-inputed? [15:04:14] mvolz: a lot is. but you can just as well create a data item by hand. [15:05:13] mvolz: you would start on https://www.wikidata.org/wiki/Special:NewItem and then add more information to the item, bit by bit [15:05:31] mvolz: DanielK_WMDE: or semiautomatically edit/create items using some of https://www.wikidata.org/wiki/Wikidata:Tools [15:05:32] what do you want to do? what kind of datasets do you have? [15:05:56] whym_away: indeed [15:07:16] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Stop registering event handlers twice in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121674 (owner: 10Adrian Lang) [15:07:45] (03Merged) 10jenkins-bot: Stop registering event handlers twice in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121674 (owner: 10Adrian Lang) [15:22:30] (03Draft2) 10Aude: Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [15:23:42] (03PS3) 10Aude: Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [15:24:07] (03CR) 10jenkins-bot: [V: 04-1] Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [15:28:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [15:29:28] (03PS4) 10Aude: Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [15:30:20] [13ValueView] 15snaterlicious 04force-pushed 06correctErrorHandling from 14e904454 to 1417cd125: 02http://git.io/PSQ0mQ [15:30:20] 13ValueView/06correctErrorHandling 1417cd125 15Adrian Lang: Handle single parameter returned by rejected ValueFormatter/Parser promise [15:30:55] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/zNF5Rg [15:30:55] 13ValueView/06master 1448334ae 15Tobi Gritschacher: Merge pull request #36 from wmde/correctErrorHandling... [15:33:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [15:35:21] [13Common] 15filbertkm created 06mismatch (+1 new commit): 02http://git.io/Z5xHcw [15:35:21] 13Common/06mismatch 14e9d309b 15aude: Introduce DataValueMismatchException... [15:37:14] https://github.com/DataValues/Common/pull/7 [15:37:20] reeeeeeeeview! [15:37:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [15:43:11] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/JM-GKw [15:43:11] 13ValueView/06master 14633f54c 15Tobi Gritschacher: Update ValueView.php [15:46:03] (03Draft6) 10Henning Snater: Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 [15:48:48] [13ValueView] 15tobijat 04deleted 060.5 at 1448334ae: 02http://git.io/uarzQw [15:49:19] [13ValueView] 15tobijat tagged 060.5 at 06master: 02http://git.io/Ceup4w [15:50:24] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [15:51:30] (03PS1) 10Christopher Johnson (WMDE): Merge "Remove space thats in the wrong place" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121681 [15:57:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121681 (owner: 10Christopher Johnson (WMDE)) [16:04:33] (03PS6) 10Tobias Gritschacher: Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [16:04:35] (03PS3) 10Tobias Gritschacher: Handle specific parse errors returned by the API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121087 (owner: 10Henning Snater) [16:04:37] (03PS7) 10Tobias Gritschacher: Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [16:06:54] (03CR) 10Tobias Gritschacher: [C: 04-1] "When trying to add a statement of type time, I'm getting" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [16:07:44] Thiemo_WMDE: this change (and the 2 dependencies) would need review: https://gerrit.wikimedia.org/r/#/c/118968 [16:07:59] probably you can loog at these, I need to leave [16:08:02] *look [16:10:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [16:19:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [16:20:31] hashar: help! https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/22992/console [16:20:36] wtf is wrong there? [16:20:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [16:20:59] DanielK_WMDE: no clue, I am about to disappear sorry :( [16:21:15] so, there's nothign i can do to make it pass, it seems [16:21:20] *shrug* [16:21:21] oh, well [16:21:54] (03PS8) 10Henning Snater: Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 [16:25:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121087 (owner: 10Henning Snater) [16:27:20] DanielK_WMDE: don't you read the console ? :-] [16:27:30] 00:00:47.883 /srv/deployment/integration/slave-scripts/bin/mw-run-phpunit.sh: line 102: 24032 Segmentation fault (core dumped) php phpunit.php DanielK_WMDE: segfaulted :/ [16:27:43] we have another patch failing [16:27:47] we've had failures on our daily "wikidata" build the past few days [16:27:56] mystery failures that i suspect are same thing [16:28:04] I am afraid some PHP is borked [16:28:13] let me find the bug report [16:28:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=62623#c16 [16:29:00] skip straight to comment 16 [16:29:10] then Tim tracked it to a bug in PHP garbage collector [16:29:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [16:29:37] https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextensions-master/328/console failed at 97% [16:29:55] wikidata jenkins approved [16:30:45] hashar, aude: Tim says: Setting zend.enable_gc=0 should be a suitable workaround -- it worked for me. [16:31:11] that means that running tests would a) use even more memory and b) would become slightly faster... [16:31:51] and I can confirm that the build you linked previously had the same issue [16:31:57] so yeah enable_gc probably [16:31:58] Tobi_WMDE: --^^^ [16:32:06] too late to try it out tonight though [16:32:33] hashar: can you bump the affected change once you enabled the workaround? [16:33:02] the patch isn't urgent, but it needs review, and nobody is going to touch it if it sits there with a red x next to it. [16:33:24] [13ValueView] 15thiemowmde comment on pull request #37 14abdc03f: Feels like this needs more refactoring now. Having this.$precision checked in two completely different places confused me for a moment. Accessing the value should be moved inside the if, please. 02http://git.io/7rAhxA [16:33:34] Hi everyone! Can I get some feedback on what features are required by wikidata community other than mentioned. [16:33:34] https://www.mediawiki.org/wiki/Wikidata_annotation_tool [16:34:49] DanielK_WMDE: I have left instructions at https://bugzilla.wikimedia.org/show_bug.cgi?id=62623#c20 [16:34:56] sorry gotta finish a bunch of labs issues [16:35:09] hashar: ok, thanks [16:41:36] apsdehal: do you have something specific in mind? https://bugzilla.wikimedia.org/buglist.cgi?bug_severity=enhancement&component=Wikidata&component=WikidataClient&component=WikidataRepo&product=MediaWiki&resolution=--- lists numerous open enhancement requests about wikidata, but not sure if that helps you [16:42:54] andre_: I have applied to GSoC with proposal at https://www.mediawiki.org/wiki/Wikidata_annotation_tool. I require feedback for it. [16:43:25] apsdehal, ah, so your question is not generally about features required by wikidata community, but specifically about your proposal. I see. [16:43:30] wasn't clear to me, sorry [16:44:23] andre_: Can you provide some feedback on project, I would be really grateful. [16:44:35] apsdehal, I cannot, sorry [16:44:54] andre_: No problem [16:46:48] DanielK_WMDE: https://docs.google.com/spreadsheet/ccc?key=0AhjMHe-04ChzdHJ1aUVxR056akxwQzFEQWNJb29KMmc&usp=sharing does this seem like something that could [16:47:00] be inputted? [16:47:16] countries are already in there, and then the property would be immigration? [16:48:17] or immigration to, immigration from... [16:52:16] (03CR) 10Daniel Kinzler: (bug 62824) generic localization for API errors. (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [16:53:30] (03PS6) 10Daniel Kinzler: (bug 62824) generic localization for API errors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 [16:53:41] (03CR) 10jenkins-bot: [V: 04-1] (bug 62824) generic localization for API errors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [16:57:53] i would need a wikidata admin for a delicate matter, anyone around? (besides myself, obviously) [16:58:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [16:58:38] dennyvrandecic: Sí [16:58:44] awesome [16:59:00] I need to be around anyway for the summary and closing a discussion :p [17:04:00] (03CR) 10Daniel Kinzler: Check the content model of pages in EntityPerPageBuilder (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [17:06:20] Thiemo_WMDE: got lots of ui issues? [17:06:37] where? [17:06:48] just collecting them al. some are around since i started working here. ;) [17:06:53] *all [17:10:32] (03CR) 10Hoo man: "re" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [17:24:19] DanielK_WMDE: so many services in ApiWikibase now :P [17:24:45] entityLookup, entityStore, dataTypeLookup, summaryFormatter, permissionChecker :P [17:25:16] oh.. and title lookup and idparser :P [17:25:34] /TODO: provide a mechanism to override the services :D ding ding ding ding ding [17:28:26] addshore: well, forst of all, move stuff from the base class into helper classes. [17:28:31] that would already consense the list [17:29:03] i hate to say ti but sounds as it is all belongs in a generic ApiHelper xD [17:29:19] addshore: basically, this is wiating for the EntityContent stuff to be sorted out. then it becomes feasible to test API modules without the database. and then it becomes important to inject the services [17:29:20] ApiHelperHelper :P [17:29:41] addshore: i don't think so, there's two or three aspects ehre [17:30:09] especially if you look at ApiWikibase, ModifyClaim and ModifyEntity together (all three should kind of die or be converted into helper objects) [17:30:15] I guess an ApiLookupHelper, ApiEditHelper [17:30:21] yea [17:30:33] and an ApiErrorLocalizationHelper [17:30:41] heh, already got a claimModificationHelper :P [17:30:48] right [17:30:56] I guess I could start on this now though? [17:31:02] entitycontent is gone from the api right? [17:31:15] mostly. let me know if it isn't, [17:31:18] :> [17:31:45] for overriding services, it would be ideal if each module had a setServices method that would require exactly the services it needs. [17:31:50] the test case would then call that method [17:31:58] this doesn't work well with subclassing though [17:32:06] (03CR) 10Thiemo Mättig (WMDE): "A question and a mainly cosmetic issue." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121087 (owner: 10Henning Snater) [17:32:10] (maybe just kill sublcassing of API modules, then) [17:32:45] addshore: while I'd love to see this being done, please look at the current sprint and backlock first, and see if you find anythign there [17:33:04] but then - you are a volunteer now, right? [17:33:16] not for another month :P [17:34:28] oh, right! [17:34:52] indeed, but this and last week have just been consumed by travelling and working on the weekend :p [17:35:03] yea, i know what you mean... [17:35:07] anyway. have a go at it [17:35:14] i gotta run. will be back on monday [17:35:15] cu! [17:37:38] Thiemo_WMDE: https://gist.github.com/filbertkm/9838388 [17:40:22] aude: whats that? :P [17:40:41] addshore: A Gist :p [17:41:05] >.> that does? :P [17:41:17] Credits [17:42:30] if i run that on mediawiki's phpunit test directory, i see addshore and daniel are most git blamed for our tests (that we do have) [17:42:51] pastebin me the output? :O [17:43:02] wait, i guess i could just run it? xD [17:43:57] give me a sec [17:44:15] aude: works for me :> what are the numbers next to the names meant to represent? [17:44:23] number of lines [17:44:30] :> [17:44:31] i just tweaked it to add "-c" to blame [17:44:33] -C [17:44:47] which considers moving files [17:45:05] this makes the script take longer though :/ [17:45:06] I like this command :> [17:45:10] :) [17:45:23] might need to remove "-C" or make it an option [17:45:27] I might add it to my g script ;p [17:45:34] heh [17:49:52] later [17:58:21] (03CR) 10Thiemo Mättig (WMDE): Reject ApiBasedValueParser/Formatter promise with a single parameter (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [18:21:56] (03PS1) 10Addshore: Clean up Client Api Module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121705 [18:26:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121705 (owner: 10Addshore) [18:58:18] addshore: congratulations on your talk! [18:58:26] [= [19:07:59] wow, title value was merged :) \o/ [19:08:05] :D [19:08:10] JeroenDeDauw: around? [19:09:25] infact, ignore that, im reading the wrong class with the same name :P [19:18:41] https://github.com/wmde/WikibaseDataModelSerialization/issues/49 easier would just be to always serialize with the hash? [19:46:55] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121819 (owner: 10L10n-bot) [20:23:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler)