[00:01:24] <JeroenDeDauw>	 why the fuck do I get a captcha on an edit? >_>
[00:02:03] <JeroenDeDauw>	 JohnLewis: can http://wikiba.se/ be added to the "do not treat as spam stuff" list?
[00:02:43] <JohnLewis>	 JeroenDeDauw: What is catching it?
[00:05:23] <JeroenDeDauw>	 JohnLewis: idk, I'm getting a captcha on inserting that
[00:05:47] <JohnLewis>	 JeroenDeDauw: and you don't when not inserting that?
[00:07:14] <Vogone>	 JeroenDeDauw: you shouldn't get any captcha in case you logged in with your work account
[00:09:24] <JeroenDeDauw>	 Vogone: well, I got one
[00:09:34] <Vogone>	 :S
[00:09:37] <JeroenDeDauw>	 Guess JohnLewis demoted me to non-confirmed-user or whatever
[00:10:00] <Vogone>	 he isn't even able to :p
[00:10:49] <JohnLewis>	 JeroenDeDauw: Which account? :p
[00:11:33] <JeroenDeDauw>	 JohnLewis: Jeroen De Dauw
[00:11:49] <Vogone>	 pfff
[00:12:10] <Vogone>	 JeroenDeDauw: Jeroen de Dauw (WMDE) has the superpowers
[00:12:16] <JohnLewis>	 JeroenDeDauw: 00:12, 14 April 2014 John F. Lewis (A) (talk | contribs | block) changed group membership for User:Jeroen De Dauw from (none) to confirmed user (Trusted user)
[00:12:18] <JohnLewis>	 Solved :p
[00:12:31] <JeroenDeDauw>	 lolwat
[00:12:36] <JohnLewis>	 You weren't autoconfirmed :p
[00:12:42] <JeroenDeDauw>	 Vogone: it's not the oldest account tho?
[00:13:07] <JeroenDeDauw>	 JohnLewis: clearly I am not to be trusted to not abuse the wiki
[00:13:17] * JeroenDeDauw  goes get a sleepz

[00:13:22] <JohnLewis>	 JeroenDeDauw: Which is why I gave you confirmed.
[00:13:30] <JohnLewis>	 You're not ready for rollbacker yet! :p
[07:56:01] <gh-datavalues>	 [13Number] 15adrianlang created 06renameTest (+1 new commit): 02http://git.io/d86VyQ
[07:56:01] <gh-datavalues>	 13Number/06renameTest 14699a179 15Adrian Lang: Rename BasicUnlocalizerTest to BasicNumberUnlocalizerTest
[07:57:16] <gh-datavalues>	 [13Number] 15adrianlang 04force-pushed 06renameTest from 14699a179 to 1473ffdc6: 02http://git.io/Xv9Aiw
[07:57:16] <gh-datavalues>	 13Number/06renameTest 1473ffdc6 15Adrian Lang: Rename BasicUnlocalizerTest to BasicNumberUnlocalizerTest
[07:57:46] <gh-datavalues>	 [13Number] 15adrianlang opened pull request #6: Rename BasicUnlocalizerTest to BasicNumberUnlocalizerTest (06master...06renameTest) 02http://git.io/pxtH2Q
[08:00:20] <grrrit-wm>	 (03PS2) 10Adrian Lang: Introduce explit data-values/interfaces dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 
[08:00:22] <grrrit-wm>	 (03PS3) 10Adrian Lang: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 
[08:00:24] <grrrit-wm>	 (03PS3) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 
[08:00:26] <grrrit-wm>	 (03PS4) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 
[08:08:10] <grrrit-wm>	 (03CR) 10Adrian Lang: [C: 032] Cleanup some Ruby code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125170 (owner: 10Tobias Gritschacher)
[08:08:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup some Ruby code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125170 (owner: 10Tobias Gritschacher)
[08:12:04] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 (owner: 10Adrian Lang)
[08:13:40] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang)
[08:14:36] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang)
[08:15:26] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang)
[08:18:02] <gh-datavalues>	 [13Interfaces] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/_7JNzw
[08:18:02] <gh-datavalues>	 13Interfaces/06master 1438a04ae 15Adrian Lang: Release 0.1.4
[08:18:32] <gh-datavalues>	 [13Interfaces] 15adrianlang tagged 060.1.4 at 06master: 02http://git.io/1cftzg
[08:24:52] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c70e29a : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22932141
[08:32:20] <addshore>	 morning :)
[08:32:39] <Adrian_WMDE>	 Hi addshore
[08:32:54] <grrrit-wm>	 (03Abandoned) 10Addshore: New Wikidata Build - 12/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125563 (owner: 10WikidataBuilder)
[08:33:06] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] New Wikidata Build - 13/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125580 (owner: 10WikidataBuilder)
[08:33:43] <Jianhui67>	 yo addshore
[08:33:51] <addshore>	 hi Adrian_WMDE and Jianhui67 :)
[08:33:59] <Adrian_WMDE>	 addshore: merge stuff!
[08:36:43] <addshore>	 Adrian_WMDE: Got some of my stuff to poke first ;p
[08:36:52] <Adrian_WMDE>	 hmkay
[08:38:49] <grrrit-wm>	 (03PS15) 10Addshore: Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 
[08:39:00] <grrrit-wm>	 (03CR) 10Addshore: Fix formatting dates in most languages (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore)
[08:39:42] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude)
[08:41:32] <addshore>	 Adrian_WMDE: Jenkins says NO to a lots of your patches ;p
[08:42:00] <grrrit-wm>	 (03PS3) 10Addshore: Fallback to en formatting of dates on failure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 
[08:42:13] <Adrian_WMDE>	 Because packagist does not say YES for data-values/interfaces 0.1.4: https://packagist.org/packages/data-values/interfaces
[08:44:52] <addshore>	 :P
[08:45:21] <addshore>	 if youve tagged it and its not there it looks like the hook didnt fire properly or isnt set up
[08:45:49] <addshore>	 bit it is setup!
[08:45:54] <addshore>	 how odd its not updated yet :<
[08:46:10] <Adrian_WMDE>	 right
[08:48:56] <Adrian_WMDE>	 addshore: You are admin on these repos?
[08:49:06] <addshore>	 yup
[08:49:22] <Adrian_WMDE>	 FIXIT!
[08:50:23] <addshore>	 apparently I cant ;p not admin / owner on packagist
[08:50:28] <addshore>	 nothing I can really do from the github side
[08:50:38] <Adrian_WMDE>	 Ah, ok
[08:51:34] <gh-datavalues>	 [13Number] 15addshore 04deleted 06renameTest at 1473ffdc6: 02http://git.io/lYU3RQ
[08:54:55] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore)
[09:05:33] <gh-wmde>	 [13WikibaseQuery] 15adrianlang 04force-pushed 06snakview from 144f2840d to 14ba0ad84: 02http://git.io/29CD-Q
[09:05:33] <gh-wmde>	 13WikibaseQuery/06snakview 14ba0ad84 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page...
[09:07:39] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore)
[09:21:27] <Adrian_WMDE>	 damn packagist
[09:24:54] <addshore>	 :D
[09:25:02] <addshore>	 JeroenDeDauw: should be able to help if its stuck ;p
[09:27:35] <Adrian_WMDE>	 If he would be here
[09:29:15] <addshore>	 :/
[09:33:46] <grrrit-wm>	 (03Draft1) 10Addshore: Use private scope where possible in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125697 
[09:33:58] <addshore>	 breakfast time!
[09:43:08] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125697 (owner: 10Addshore)
[09:55:08] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125580 (owner: 10WikidataBuilder)
[10:00:24] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 14/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125699 
[10:02:46] <grrrit-wm>	 (03PS4) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 
[10:02:48] <grrrit-wm>	 (03PS5) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 
[10:05:38] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang)
[10:08:26] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang)
[10:19:13] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125699 (owner: 10WikidataBuilder)
[10:20:35] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] New Wikidata Build - 14/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125699 (owner: 10WikidataBuilder)
[10:23:31] <gameMaster>	 hello everyone
[10:23:51] <gameMaster>	 is somebody here who has tried this: http://tools.wmflabs.org/toolscript/index.html   ?
[11:00:14] <gh-wmde>	 [13WikibaseQuery] 15adrianlang 04force-pushed 06snakview from 14ba0ad84 to 1404467f0: 02http://git.io/29CD-Q
[11:00:14] <gh-wmde>	 13WikibaseQuery/06snakview 1404467f0 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page...
[11:10:35] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Introduce explit data-values/interfaces dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 (owner: 10Adrian Lang)
[11:11:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Introduce explit data-values/interfaces dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 (owner: 10Adrian Lang)
[11:30:10] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2fd530c : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22943101
[11:43:42] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125699 (owner: 10WikidataBuilder)
[11:45:30] <grrrit-wm>	 (03PS3) 10Addshore: Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 
[11:45:32] <grrrit-wm>	 (03PS7) 10Addshore: Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude)
[11:45:34] <grrrit-wm>	 (03PS16) 10Addshore: Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 
[11:45:36] <grrrit-wm>	 (03PS4) 10Addshore: Fallback to en formatting of dates on failure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 
[11:46:07] <Adrian_WMDE>	 addshore: I get an error in repo phpunit tests with wbq installed: Table 'wikibase_repo.unittest_test_wbq_mainsnak_boolean' doesn't exist
[11:46:34] <Adrian_WMDE>	 addshore: Shouldn't the test tables be set up correctly before running the tests? :D
[11:47:00] <addshore>	 did you run update.php?
[11:47:37] <Adrian_WMDE>	 yes, but does it do anything with unittest_test_?
[11:48:38] <Adrian_WMDE>	 I have wbq_mainsnak_boolean, I just don't have unittest_test_wbq_mainsnak_boolean.
[11:48:54] <Adrian_WMDE>	 I don't have any unittest_test_* tables
[11:49:11] <addshore>	 they should be created when the unit tests run
[11:49:41] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude)
[11:50:19] <Adrian_WMDE>	 Howwherewhenwho?
[11:51:32] <addshore>	 hmmh, im one of the test base classes I think
[11:51:39] <addshore>	 no doubt MediaWikiTestCaseTest
[11:51:47] <addshore>	 wiat.. MediaWikiTestCase
[11:51:48] <addshore>	 :P
[11:51:54] <Adrian_WMDE>	 :D
[11:52:11] <grrrit-wm>	 (03PS5) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 
[11:54:34] <grrrit-wm>	 (03PS8) 10Daniel Kinzler: Factor hard constraints out of EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124984 
[11:55:16] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore)
[11:58:23] <gh-datavalues>	 [13Time] 15addshore created 06rmTimeIsoFormatterInterface (+1 new commit): 02http://git.io/-Y_K8w
[11:58:23] <gh-datavalues>	 13Time/06rmTimeIsoFormatterInterface 14563728b 15addshore: Remove TimeIsoFormatter interface...
[11:59:03] <gh-datavalues>	 [13Time] 15addshore opened pull request #15: Remove TimeIsoFormatter interface (06master...06rmTimeIsoFormatterInterface) 02http://git.io/CFUWgA
[11:59:58] <Adrian_WMDE>	 MediaWikiTestCase does a lot of things
[12:05:46] <Adrian_WMDE>	 addshore: There seems to be an error with the prefix. The correct prefix is unittest_, but somehow wbq expects unittest_test_
[12:09:13] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude)
[12:13:00] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore)
[12:13:57] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] "Restoring previous +2" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore)
[12:15:36] <Adrian_WMDE>	 addshore: https://github.com/wmde/WikibaseQuery/issues/15
[12:18:18] <grrrit-wm>	 (03PS1) 10Addshore: Stop using TimeIsoFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 
[12:18:33] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore)
[12:24:44] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/8f14c32 : addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22946924
[12:25:01] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler)
[12:26:39] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "Sorry, we can do this for new code, but I don't think this is worth the hassle updating old code (also there are some changes in here whic" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125697 (owner: 10Addshore)
[12:29:04] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124984 (owner: 10Daniel Kinzler)
[12:29:12] <grrrit-wm>	 (03CR) 10Addshore: "As more extensions are built on top of Wikibase the importance of private vs protected vs public becomes ever clearer." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125697 (owner: 10Addshore)
[12:34:12] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 (owner: 10Addshore)
[12:44:50] <DanielK_WMDE>	 Thiemo_WMDE, aude: any chance to get a review of https://gerrit.wikimedia.org/r/#/c/124984/ and https://gerrit.wikimedia.org/r/#/c/124323/ ?
[12:51:06] <grrrit-wm>	 (03PS1) 10Addshore: Add comment to wgHooks stash in MwTimeIsoFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125713 
[12:51:08] <addshore>	 Adrian_WMDE: ^^
[12:52:07] <Adrian_WMDE>	 how about a change which just removes the stashing?
[12:54:27] <addshore>	 It would probably just get lost and forgotten about :P (especially as I am off in less than 2 weeks :O)
[12:57:43] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125713 (owner: 10Addshore)
[12:58:48] <JohnLewis>	 addshore: That soon? :p
[12:59:01] <addshore>	 yup :P
[12:59:30] <JohnLewis>	 No more abusive addshore then :D
[13:05:21] <Adrian_WMDE>	 addshore: DanielK_WMDE: Can you give me a quick sanity check? https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikibase.git/HEAD/repo%2Fincludes%2Fupdates%2FEntityModificationUpdate.php#L86 is wrong afaik
[13:06:23] <Adrian_WMDE>	 ModificationUpdates are instantiated for example in ItemContent::getSecondaryDataUpdates
[13:06:51] <Adrian_WMDE>	 getSecondaryDataUpdates often (always?) gets passed null as $old
[13:23:28] <Adrian_WMDE>	 DanielK_WMDE: ping?
[13:38:13] <Adrian_WMDE>	 mh, gotta go
[14:23:17] <grrrit-wm>	 (03PS1) 10Hoo man: Implement a rebuildItemsPerSite maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 
[14:29:39] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man)
[14:59:21] <reimann>	 do we have something like WDRDR (WikiData ReDirecteR) https://www.wikidata.org/wiki/Wikidata:Tools/External_tools/de#WDRDR_.E2.80.94_WikiData_ReDirecteR in working and reliable? A database provider asks for outgoing links to wikidata/pedias.
[15:24:19] <ToAruShiroiNeko>	 hi
[15:24:31] <ToAruShiroiNeko>	 what code was used to convert interwiki links to wikidata material
[15:24:45] <ToAruShiroiNeko>	 I dont know the procedure but I noticed some interwiki links for this purpose
[15:27:47] <JohnLewis>	 ToAruShiroiNeko: Hm?
[15:28:45] <ToAruShiroiNeko>	 my userpages had interwiki links
[15:28:55] <ToAruShiroiNeko>	 they still do, I'd rather have that moved to wikidata
[15:29:48] <hoo>	 That's outside of Wikidatas scope
[15:29:59] <ToAruShiroiNeko>	 oh?
[15:30:07] <hoo>	 yep
[15:30:11] <ToAruShiroiNeko>	 then I paniced over nothing
[15:30:36] * ToAruShiroiNeko  depanics

[16:32:20] <JeroenDeDauw>	 Lydia_WMDE: note: heating still on 2 or 3
[16:33:02] <Lydia_WMDE>	 JeroenDeDauw: k
[16:36:13] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Lets get this merged a.s.a.p. and fix nitpicks in follow-ups. (This includes my comment.)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124984 (owner: 10Daniel Kinzler)
[16:40:04] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/niJsmQ
[16:40:04] <gh-wmde>	 13WikibaseDataModel/06master 145e55209 15jeroendedauw: Improve doc
[17:06:20] <JeroenDeDauw>	 Thiemo_WMDE: nomnom?
[17:06:33] <Thiemo_WMDE>	 JeroenDeDauw: yes!
[17:10:12] <JeroenDeDauw>	 Thiemo_WMDE: what do you want
[17:43:22] <gh-datavalues>	 [13Time] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/TTd2cw
[17:43:22] <gh-datavalues>	 13Time/06master 148f0b7b1 15Jeroen De Dauw: Merge pull request #15 from DataValues/rmTimeIsoFormatterInterface...
[18:07:48] <gh-wmde>	 [13DataTypes] 15JeroenDeDauw closed pull request #14: Update Norwegian Bokmål (nb) translation (06master...06master) 02http://git.io/-U2jpQ
[18:11:39] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "I'd also not have made this change like this. However now the effort has been made, we can just as well merge it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125697 (owner: 10Addshore)
[18:13:11] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] "I'm approving this now as else we'll just end up with the effort being wasted." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125697 (owner: 10Addshore)
[18:20:13] <addshore>	 yay my php storm is broken
[18:21:13] <hoo>	 ok, so back to ed :D
[18:23:43] <addshore>	 https://www.irccloud.com/pastebin/qypqOBvA
[18:24:24] <JohnLewis>	 I don't use my phpStorm :p
[18:26:23] <addshore>	 wtf is this youtrack stuff... I cant find ow to file an issue....
[18:27:04] <addshore>	 ...oh ... register ...
[18:27:43] <JohnLewis>	 addshore https://intellij-support.jetbrains.com/anonymous_requests/new :p
[18:27:52] <addshore>	 >.>
[18:27:58] <JeroenDeDauw>	 JohnLewis vs addshore: 1 - 0
[18:29:09] <JeroenDeDauw>	 Thiemo_WMDE: 70 minutes.... djeeeez
[18:30:09] <addshore>	 guess its time to download 7.1.3 :D
[18:30:35] <JeroenDeDauw>	 addshore: that one has been released months ago!
[18:30:40] <JeroenDeDauw>	 slack slack slack!
[18:32:01] <JohnLewis>	 JeroenDeDauw: Last time I updated phpStorm was last Feb I think :p
[18:32:01] <addshore>	 hehe, I was waiting just incase the old version decided to die and not start up agin ;p
[18:32:22] <JohnLewis>	 (Last year that is)
[18:32:42] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See comments." (0314 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler)
[18:34:14] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/23415b6 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22973638
[18:40:10] <twkozlowski>	 Oi!
[18:40:32] <twkozlowski>	 aude, addshore, Lydia_WMDE
[18:40:39] <twkozlowski>	 Wikidata is damn fast! Awesome!
[18:40:46] <Lydia_WMDE>	 twkozlowski: :)
[18:42:57] <twkozlowski>	 Lydia_WMDE: Well done!
[18:43:00] * twkozlowski  so happy \o/

[18:43:48] <Lydia_WMDE>	 ;-)
[18:43:50] <Lydia_WMDE>	 good
[18:44:32] <twkozlowski>	 Editing Wikidata is pure pleasure now
[18:44:42] <twkozlowski>	 Just freaking awesome.
[18:44:46] <twkozlowski>	 Yay! \o/
[18:45:06] <Lydia_WMDE>	 that's great to hear
[18:45:14] <Lydia_WMDE>	 I'll forward that to the team :)
[18:45:32] <hoo>	 :)
[18:48:06] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Insert classes for badges on client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene)
[18:58:08] <JohnLewis>	 Lydia_WMDE: Now just the UI re-design and Wikidata will (hopefully) be flawless :D
[18:58:32] <Lydia_WMDE>	 JohnLewis: you wouldn't expect anything less from me would you? :P
[18:59:13] <JohnLewis>	 :p
[19:00:14] <hoo>	 Lydia_WMDE: If you want it be even more awesome add waffles with ice cream... we should really have those :P
[19:00:23] <Lydia_WMDE>	 haha
[19:00:25] <Lydia_WMDE>	 totally
[19:00:38] <Lydia_WMDE>	 and a small fluffy kitten on every page
[19:00:41] <Lydia_WMDE>	 actually
[19:00:46] <Lydia_WMDE>	 someone go and make a gadget? :D
[19:00:52] <twkozlowski>	 Pff.
[19:01:04] <twkozlowski>	 You want to give people a choice to not have a fluffy kitten on every page?
[19:01:10] <twkozlowski>	 Who are you?!!
[19:01:12] <Lydia_WMDE>	 good point
[19:01:15] <Lydia_WMDE>	 ok
[19:01:18] <Lydia_WMDE>	 no gadget
[19:01:22] <benestar>	 put it into Common.js
[19:01:25] <benestar>	 ;)
[19:01:28] <twkozlowski>	 .css
[19:01:30] <hoo>	 I don't think we should support that unlike use case of someone not wanting a kitten on their page
[19:01:31] <Lydia_WMDE>	 ;-)
[19:01:39] <Lydia_WMDE>	 hoo: yeah
[19:01:40] <Lydia_WMDE>	 true
[19:01:53] <benestar>	 twkozlowski: you are right, we have to support non-js users 
[19:01:55] <JeroenDeDauw>	 Lydia_WMDE: I'm picking up that kitten item
[19:01:57] <Lydia_WMDE>	 we don't want those people anyway!!!!111eleven
[19:01:59] <Lydia_WMDE>	 :P
[19:02:06] <Lydia_WMDE>	 JeroenDeDauw: -.-
[19:02:08] <Lydia_WMDE>	 :P
[19:02:47] <Lydia_WMDE>	 JeroenDeDauw: did you btw see how i herolike rescued our markers for the catwall?
[19:03:26] <JeroenDeDauw>	 Lydia_WMDE: ceiling cat sends his approval
[19:03:33] <Lydia_WMDE>	 \o/
[19:04:02] <Lydia_WMDE>	 for anyone who's not seen our catwall yet: https://twitter.com/nightrose/status/455740343669911556
[19:04:31] <benestar>	 Thiemo_WMDE: what do you mean here? https://gerrit.wikimedia.org/r/#/c/124605/4/client/includes/hooks/LanguageLinkBadgeDisplay.php
[19:05:28] <Thiemo_WMDE>	 benestar: as i said.
[19:06:31] <Thiemo_WMDE>	 switch the last two loops. use array_key_exists( ..., $badgeClassNames ) instead of looping this array.
[19:06:52] <Thiemo_WMDE>	 or !empty( $badgeClassNames[$badge] ).
[19:07:57] <benestar>	 Thiemo_WMDE: at the moment we depend somehow on the order of the badges in the config
[19:08:08] <benestar>	 this would not work with that approach
[19:08:17] <benestar>	 however, I'm not sure if this is a good idea anyway
[19:08:37] <benestar>	 because there is another independent order specified in the css file
[19:09:30] <Thiemo_WMDE>	 the order in the config is irrelevant from what i see.
[19:09:43] <Thiemo_WMDE>	 all that matters is the order in the css.
[19:10:03] <benestar>	 Thiemo_WMDE: this is not correct because we also add a title
[19:10:17] <benestar>	 and this title has to be unique and is added by the php code
[19:10:46] <Thiemo_WMDE>	 class="Q123 FA GA" and class="Q123 GA FA" are rendered the same. the oder of the class names does not matter. that's not how CSS works.
[19:10:54] <benestar>	 therefore there should also be only one extra css class per sitelink
[19:11:15] <benestar>	 Thiemo_WMDE: but we set a title as I already mentioned
[19:11:25] <benestar>	 this title can obviously not be added by css
[19:12:13] <Thiemo_WMDE>	 ok. then we have a problem with that approach. why are multiple badges per sitelink allowed if there is no way to render them?
[19:13:06] <benestar>	 Thiemo_WMDE: I don't know, ask Lydia_WMDE ;)
[19:13:19] <Lydia_WMDE>	 hmm?
[19:13:50] <grrrit-wm>	 (03PS5) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 
[19:13:54] <Lydia_WMDE>	 because more badges can be stored on wikidata than just one per sitelink
[19:13:57] <benestar>	 Thiemo_WMDE: anyhow, I see no problem in simply relying on the order of the ocnfig
[19:14:03] <Lydia_WMDE>	 for things other than good/featured article
[19:14:19] <hoo>	 benestar: We at some point agreed on using the order from the config, right?
[19:14:28] <benestar>	 hoo: I think so, yes
[19:14:33] <hoo>	 I don't see why that should be changed now
[19:14:37] <benestar>	 that's how I implemented it
[19:15:02] <benestar>	 Thiemo_WMDE complained a bit
[19:15:37] <Thiemo_WMDE>	 benestar: ok, no problem with the order. but there are simply to many loops nested where checking for an array key should be sufficient (and much faster).
[19:15:47] <benestar>	 Thiemo_WMDE: I removed one loop already
[19:15:54] <benestar>	 maybe you wanna take a look at the code now
[19:16:09] <benestar>	 perhaps we can even use a faster native method but I am not sure at that point
[19:18:47] <Thiemo_WMDE>	 are there tests for these cases? then we can try different implementations.
[19:19:32] <benestar>	 Thiemo_WMDE: the tests also test the ordering dependency
[19:19:53] <benestar>	 but how do you want to get the best implementation this way?
[19:20:29] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene)
[19:27:44] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I suggest to split "add CSS class names" and "add titles" into two patches that depend on each other. This would make reviewing and discus" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene)
[19:53:38] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125847 (owner: 10L10n-bot)
[19:57:34] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Clean-up ItemContentTest and Wikibase.hooks.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 
[20:06:42] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 (owner: 10Thiemo Mättig (WMDE))
[20:16:23] <JohnLewis>	 dennyvrandecic: Nice proposal on PC :p
[20:19:30] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2bf566b : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22981129
[20:22:23] <grrrit-wm>	 (03CR) 10Bene: "I don't think it makes sense to split up the title part from the rest because the title is connected to the css class. Otherwise we could " (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene)
[20:47:36] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Render links to deleted items in red [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 
[20:48:21] <grrrit-wm>	 (03Abandoned) 10Bene: Add documentation or badgeItems setting and fix the code accordingly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene)
[20:54:07] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE))
[20:54:51] <grrrit-wm>	 (03PS1) 10Bene: Add documentation for badgeItems setting on repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125875 
[20:55:01] <benestar>	 Thiemo_WMDE: a quick merge please :D
[20:59:28] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Make Link Formatter regular expressions more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125877 
[21:02:39] <grrrit-wm>	 (03PS2) 10Thiemo Mättig (WMDE): Render links to deleted items in red [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 
[21:03:43] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125875 (owner: 10Bene)
[21:10:24] <grrrit-wm>	 (03PS2) 10Thiemo Mättig (WMDE): Add documentation for badgeItems setting on repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125875 (owner: 10Bene)
[21:10:38] <Thiemo_WMDE>	 benestar: if thats ok for you, please hit +1 and i will hit +2.
[21:11:15] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125877 (owner: 10Thiemo Mättig (WMDE))
[21:12:17] <grrrit-wm>	 (03CR) 10Bene: [C: 031] Add documentation for badgeItems setting on repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125875 (owner: 10Bene)
[21:13:01] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add documentation for badgeItems setting on repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125875 (owner: 10Bene)
[21:13:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add documentation for badgeItems setting on repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125875 (owner: 10Bene)
[21:17:36] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE))
[21:19:21] <grrrit-wm>	 (03PS14) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 
[21:24:18] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125875 (owner: 10Bene)
[21:26:36] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE))
[21:36:04] <grrrit-wm>	 (03PS15) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 
[21:43:05] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE))
[21:43:55] <grrrit-wm>	 (03PS1) 10Bene: Create api module 'wbavailablebadges' to query all available badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 
[21:50:01] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (owner: 10Bene)
[22:12:26] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d2ed0cc : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22988628