[08:27:35] (03CR) 10Siebrand: [C: 032] Move the messages to describe novalue and somevalue Snaks to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129072 (owner: 10Hoo man) [08:29:10] (03Merged) 10jenkins-bot: Move the messages to describe novalue and somevalue Snaks to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129072 (owner: 10Hoo man) [08:39:30] (03CR) 10Daniel Kinzler: [C: 031] "Various small suggestions. Would be fine to merge though." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man) [08:43:40] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0b98383 : Marius Hoch The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23574868 [08:44:33] (03PS7) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [08:44:35] (03PS8) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [08:44:54] (03CR) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [08:50:25] (03CR) 10Adrian Lang: Localize error parameters. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [08:52:33] (03CR) 10Daniel Kinzler: [V: 031] "Verified manually. Not merging yet in case you want to look at my suggestions. Ready to go in though." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man) [08:52:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [08:54:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [08:57:26] (03PS8) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [08:57:28] (03PS9) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [08:59:13] (03CR) 10Daniel Kinzler: [C: 031] "Looks a lot more sensible now. Still need to verify manually." [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [09:02:42] (03CR) 10Daniel Kinzler: "@Jeroen: can you elaborate? I'm not sure what you are referring to. We do want to test API modules as such, so we can check parameter hand" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 (owner: 10Addshore) [09:04:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [09:06:01] (03CR) 10Daniel Kinzler: [C: 031] "Looks good on a first glance, will check again later." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [09:18:40] (03CR) 10Adrian Lang: [C: 04-1] "There are several very small changes hidden here which could be pulled out and merged pretty quickly." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [09:22:08] (03PS1) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [09:28:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [09:43:31] (03PS3) 10Adrian Lang: Add ugly test for bug 62868. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119989 [09:49:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119989 (owner: 10Adrian Lang) [10:00:22] (03PS1) 10WikidataBuilder: New Wikidata Build - 23/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129133 [10:09:58] addshore: aude: DanielK_WMDE: creating entities are causing a fatal error on beta, that's the reason why the browsertests are failing since a few days [10:10:13] ahh, do we have an exception? [10:10:17] PHP fatal error in /srv/common-local/php-master/includes/search/SearchEngine.php line 463: Class 'LuceneSearch' not found [10:10:27] O_o [10:10:29] try http://wikidata.beta.wmflabs.org/wiki/Special:NewItem [10:10:43] the item is created nevertheless [10:11:08] let me go find the stack trace :) If I remember where :P [10:11:13] but (if creating with e.g. wbeditentity) you'll get an API error first [10:11:38] odd that its a permissions error! [10:11:49] I guess that's why the browsertests are failing (although they're only failing when creating properties..) [10:12:19] addshore: yeah.. strange that the browsetests claim its a permission error [10:12:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129133 (owner: 10WikidataBuilder) [10:12:53] the API is just saying: Error performing API request [10:12:56] not more [10:13:17] so I'm not totally convinced the browsertest failures are related to that. but it's definitely a bug [10:13:30] and it should be fixed before I'm investigating further [10:14:39] addshore: also wondering how that error is related to the changes in https://gerrit.wikimedia.org/r/#/c/127224/ [10:14:55] could also be due to a core change that day..probably [10:15:09] probably a core change, the lucene error is in core anyway [10:15:27] hashar: deployment-bastion doesnt have any mediawiki log files :< [10:15:42] addshore: nice [10:15:51] (03CR) 10Thiemo Mättig (WMDE): (bug 49583) refactoring term validation (0315 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [10:15:54] (03CR) 10Thiemo Mättig (WMDE): Localize error parameters. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [10:16:04] addshore: known bug :-( [10:16:08] ;_: [10:17:55] Tobi_WMDE: have you opened a bug for this yet? [10:19:47] Ill make one for the lucene class thing [10:20:22] addshore: I suppose its only for PhpStorm yes - how is that an issue?? [10:20:40] addshore: you'll always have a key for just one IDE no? [10:20:45] JeroenDeDauw: I want one for the new Intelij ;p We have one for v12 but now v13 is released :) [10:23:45] addshore: presumably PhpStorm will soon follow [10:23:57] I'm waiting for it, hoping they fixed a PhpUnit bug [10:24:03] :O [10:24:20] Running tests via command line for now [10:24:35] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove slow array_unique from ReferencedEntitesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126235 (owner: 10Adrian Lang) [10:24:58] (03Merged) 10jenkins-bot: Remove slow array_unique from ReferencedEntitesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126235 (owner: 10Adrian Lang) [10:30:30] Lydia_WMDE: regarding https://bugzilla.wikimedia.org/show_bug.cgi?id=46361 is an output like "[...], no value, unknown value" sufficent here? [10:30:54] got that consistent for both Lua and the parser stuff [10:31:21] hoo: i was thinking we should show it in italics maybe? [10:31:29] but as a start we can do with no styling [10:31:49] i think it is nice to have a visual indication that this is different from the usual stuff [10:32:07] mh... I guess we would need other snak formatters then [10:32:16] like a client snak formatter [10:32:17] ok then let's not do it for now [10:32:52] hoo: oh and it probably shouldn't return "unknown value" but "unknown" instead [10:33:08] and "none" instead of no value [10:34:04] Lydia_WMDE: mh... do you want that also on repo? [10:34:07] (03PS2) 10Thiemo Mättig (WMDE): Don't use unchecked global jQuery variable in non-critical JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123092 [10:34:09] (03PS2) 10Thiemo Mättig (WMDE): Replace fade that doesn't fade with more flexible CSS class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 [10:34:18] no there it is fine i think [10:34:36] but if we show it in an infobox some value looks bad :P [10:34:41] for example [10:35:11] Lydia_WMDE: where did you run off to? [10:35:20] JeroenDeDauw: quarantine at home -.- [10:35:40] True... this is a little difficult as repo and client use the same snak formatter atm [10:36:44] Lydia_WMDE: what... not fair - you are escaping from the eviiiiil meetings [10:36:54] JeroenDeDauw: no - will call in ;-) [10:37:08] Still sort of counts as escaping [10:37:27] hoo: i see. something to discuss? [10:37:42] Tobi_WMDE: where even should this bug be filled? [10:37:49] DanielK_WMDE: do you know of any reason we should not kill serialize and unserialize from Entity? I can't find any place where it is used [10:38:03] Lydia_WMDE: Well, we could either have ClientSnakFormatters I guess or add more cruft to the current Snak formatters (not sure how exactly they work) [10:38:10] different bug? [10:38:26] hoo: sounds good [10:38:29] yes [10:38:51] Shall I file or do you want? [10:39:14] Tobi_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=64283 [10:39:17] could you please? you have more of the details [10:39:23] Sure [10:40:04] thx [10:42:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123092 (owner: 10Thiemo Mättig (WMDE)) [10:46:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/6968653 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23581163 [10:47:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 (owner: 10Thiemo Mättig (WMDE)) [10:47:55] (03PS3) 10Thiemo Mättig (WMDE): Replace fade that doesn't fade with more flexible CSS class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 [10:53:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 (owner: 10Thiemo Mättig (WMDE)) [10:59:33] JeroenDeDauw: http://confluence.jetbrains.com/display/PhpStorm/PhpStorm+Early+Access+Program phpstorm 8 ;p [11:05:59] (03PS2) 10Thiemo Mättig (WMDE): Reduce loading spinner toggle to a single 'loading' CSS class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 [11:09:13] (03PS3) 10Thiemo Mättig (WMDE): Don't use unchecked global jQuery variable in non-critical JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123092 [11:10:26] (03CR) 10Adrian Lang: "Needs manual rebase, again :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [11:12:55] (03CR) 10Adrian Lang: [C: 04-1] Cucumber tests for Special:SetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [11:13:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 (owner: 10Thiemo Mättig (WMDE)) [11:18:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123092 (owner: 10Thiemo Mättig (WMDE)) [11:18:30] (03CR) 10Jeroen De Dauw: "This commit message is a bit cryptic. If I come across this in git log, the thing is not linked. And I might not know where bugzilla is. A" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119989 (owner: 10Adrian Lang) [11:19:25] (03CR) 10Jeroen De Dauw: [C: 032] Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [11:22:11] (03CR) 10Jeroen De Dauw: [C: 04-1] Use expectedFormat for more specific ParseException localizing (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [11:29:01] Tobi_WMDE: will use the link that is in the sprint start appointment [11:29:33] (03PS9) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [11:29:35] (03PS10) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [11:29:40] (03CR) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [11:30:04] (03CR) 10Jeroen De Dauw: [C: 04-1] "Thanks for starting to split this up" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [11:36:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [11:37:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [11:41:50] [13Number] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/zWysJA [11:41:50] 13Number/06master 141c92182 15Jeroen De Dauw: Merge pull request #5 from DataValues/augmentParseException... [12:00:35] more ram for my laptop time :) [12:19:58] addshore: You'r around? I want to work on https://github.com/wmde/WikibaseQueryEngine/pull/21/files Am I free to touch this patch? [12:20:21] addshore: Can you deploy jenkins puppet changes? [12:20:33] go for it :) I havnt had much time to look at it again since the other time issues we had [12:20:45] hoo: for our jenkins? [12:21:02] yep [12:21:47] hoo looking at it now :) [12:25:08] hoo, the pull req needs to also fetch scrubunty [12:25:32] addshore: You sure about that? [12:25:38] Then something's broken [12:25:49] the only extension in the workspace currently is wWikibase [12:25:50] cause there's a script which is supposed to fetch Scribunto :/ [12:26:05] but is it being run ? [12:26:08] puppet-jenkins / files / mw-get-client-extensions.sh [12:26:12] it should [12:26:45] https://github.com/wmde/jenkins-job-builder-config/blob/master/wikibase.yaml#L110 [12:27:14] mw-get-master, mw-install-sqlite, mw-composer-install-ext, wb-apply-settings, mw-run-update-script, runtests [12:27:57] looks like you need to update jenkins-job-builder-config hoo :) [12:29:26] addshore: not sure how that wrks together, sorry [12:29:36] hoo, youll have to add a builder to https://github.com/wmde/jenkins-job-builder-config/blob/master/defaults.yaml that runs the bash script [12:29:51] and then just add the builder into the list of builder I linked you to above for the client jobs :) [12:30:22] once you look at them (especially the defaults.yaml) it should make sense :) [12:30:44] I can do... but expect breakage [12:30:57] hehe, you wont break anything ;p [12:32:44] [13jenkins-job-builder-config] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/PuMxMw [12:32:44] 13jenkins-job-builder-config/06master 14413c96f 15Marius Hoch: Add "mw-get-client-extensions" builder [12:34:19] [13jenkins-job-builder-config] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/iLHEig [12:34:19] 13jenkins-job-builder-config/06master 14ac9ce51 15Marius Hoch: Add the "mw-get-client-extensions" builder to "wikibase-client-tests" [12:34:41] addshore: All done (I guess) [12:35:39] hoo: looks good [12:35:43] ill go deploy it and see :P [12:37:23] hoo: deploying it http://wdjenkins.wmflabs.org/ci/job/jenkins-job-builder/30/console [12:38:13] it went past the client ones so woo!, will retrigger and random client build and see if scrubuntu appears :) [12:38:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129133 (owner: 10WikidataBuilder) [12:39:19] (03CR) 10Addshore: [V: 032] "Please ignore that Abort! :)" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129133 (owner: 10WikidataBuilder) [12:48:35] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [12:49:32] (03CR) 10Jeroen De Dauw: [C: 04-1] Use expectedFormat for more specific ParseException localizing (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [12:51:39] (03PS1) 10Addshore: DNM DNM Jenkins Test Commit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129163 [12:54:11] lol /tmp/hudson6655936607548552310.sh: 2: /tmp/hudson6655936607548552310.sh: /srv/scripts/mw-get-client-extensions.sh: not found [12:56:56] wtf [12:57:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129163 (owner: 10Addshore) [12:58:45] puppet is outdated on it :/ [12:58:48] so that file isnt there [12:58:50] poking it now [13:03:36] aude: Tobi_WMDE around? whats up with our jenkins? [13:03:46] the puppet stuff on the instance in no way reflects what is in the repo... [13:04:40] I dont really want to poke anything there right now :/ [13:05:19] Note: jenkins client tests will be broken untill puppet runs properly unless the 2 commits made by hoo are reverted [13:16:27] addshore: what did you do? [13:16:29] :-P [13:17:11] nothing :P hoo made 2 changes to jjbc, I ran the job on jenkins to update the configs and ran a test build and it failed as the file isnt there [13:17:13] addshore: it does not pull automatically. so if you want to have the puppet stuff from the repository there you'll need to pull manually [13:17:41] mw-get-client-extensions.sh is included in https://github.com/wmde/puppet-jenkins/blob/master/manifests/init.pp#L22 [13:17:59] but the wdjenkins instance doesnt even have this file [13:18:10] wait... [13:18:10] https://github.com/wmde/puppet-jenkins/tree/eqiad [13:18:18] the branch has never been merged into master! :@ [13:18:26] addshore: no [13:18:34] haha! we can do that now right? xD [13:18:37] we're running on branch eqiad [13:18:50] first let's fix the actual problem [13:18:50] Tobi_WMDE: https://github.com/wmde/puppet-jenkins/pull/21 [13:18:55] not too many things at once [13:19:05] well thats the problem, I pulled jenkins from master on the instance [13:19:38] addshore: WHY!!? [13:19:45] hehe [13:19:46] (03PS10) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [13:19:48] (03PS11) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [13:19:52] then just pull from eqiad [13:19:55] I just typed git pull :P but dont worry, it didnt work anyway :P [13:19:55] and run it again [13:19:58] that should work [13:20:12] I don't have time to look into it [13:20:20] probably not for the rest of the day [13:20:24] (03CR) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [13:20:27] can you have a look? [13:20:30] addshore? [13:20:37] err: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class wdjenkins::jenkins for wdjenkins.eqiad.wmflabs on node wdjenkins.eqiad.wmflabs [13:20:43] or just undo the jjbc changes [13:20:49] thats while running on the equid branch [13:20:51] Tobi_WMDE: will do :/ [13:20:54] if I dont find it [13:21:12] addshore: hmm.. yeah.. that sounds family [13:21:15] familar [13:21:33] missing class on wikitech? [13:21:47] looking on wikitech now [13:26:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [13:27:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [13:28:07] (03PS1) 10Thiemo Mättig (WMDE): Refactor type checks in EntityId formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129168 [13:28:09] (03CR) 10jenkins-bot: [V: 04-1] Refactor type checks in EntityId formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129168 (owner: 10Thiemo Mättig (WMDE)) [13:28:31] [13jenkins-job-builder-config] 15addshore pushed 1 new commit to 06master: 02http://git.io/A6gT7Q [13:28:31] 13jenkins-job-builder-config/06master 1488c41a0 15addshore: Revert "Add the "mw-get-client-extensions" builder to "wikibase-client-tests""... [13:30:02] [13jenkins-job-builder-config] 15addshore created 06clientExtensions (+1 new commit): 02http://git.io/TTmzVw [13:30:02] 13jenkins-job-builder-config/06clientExtensions 14bd23b63 15addshore: ReAdd mw-get-client-extensions builder to wikibase-client-tests [13:30:12] [13jenkins-job-builder-config] 15addshore opened pull request #8: ReAdd mw-get-client-extensions builder to wikibase-client-tests (06master...06clientExtensions) 02http://git.io/0vVDKg [13:30:41] hoo: reverted your second commit and then added it to a branch until the puppet issue can be resolved [13:30:50] updating jenkins configs now http://wdjenkins.wmflabs.org/ci/job/jenkins-job-builder/31/ [13:32:04] addshore: Should I resubmit stuff or is not fixed yet? [13:32:50] meh [13:33:51] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129168 (owner: 10Thiemo Mättig (WMDE)) [13:39:16] Adrian_WMDE: it is fixed [13:39:28] link me to them and ILl retrigger the jobs for you [13:39:31] *i'll [13:39:55] https://gerrit.wikimedia.org/r/#/c/125381/ [13:40:02] https://gerrit.wikimedia.org/r/#/c/125380/ [13:41:15] retriggered [13:41:48] thanks [13:44:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [13:45:06] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [13:45:42] (03PS2) 10Thiemo Mättig (WMDE): Refactor type checks in EntityId formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129168 [13:45:59] are there problems ? Things do not display well [13:51:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129168 (owner: 10Thiemo Mättig (WMDE)) [14:11:15] addshore: did you fix puppet? [14:11:40] nope, just reverted the jjbc change [14:12:05] ok [14:12:14] addshore: any idea why the class is not found? [14:14:39] no, i looked at it in a confused way for rather a long ammount of time and couldnt work it out [14:17:19] :( [14:53:47] (03CR) 10Thiemo Mättig (WMDE): (bug 40157) store entity status in page_props (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [15:28:07] Lydia_WMDE: hm, do we need a special copyright notice on SpecialSetLabel, etc? [15:28:28] tehre seems to be code for that... which isn't called anywhere. which is good, because it is broken... [15:28:46] DanielK_WMDE_: just the usual stuff that is used everywhere else. don't see why that should be special cased [15:29:14] hoo: ^ [15:29:14] "by clicking here you agree to release..." [15:29:22] that doesn't go there automatically [15:29:57] mh [15:30:28] DanielK_WMDE_: ah i guess it should to be on the safe side? [15:30:51] Looks fine to me, or am I missing something? [15:30:53] Well, as I said - there is code for this. unused and broken. [15:31:10] I guess it was used and not broken at some point :P [15:31:10] I see the license warning and I see the special "you are not logged in" blabla [15:31:30] hoo: without JS? [15:31:57] DanielK_WMDE_: Even in lynx, yes [15:32:02] addshore: what's the status of https://bugzilla.wikimedia.org/show_bug.cgi?id=63723? [15:32:10] can this be considered as done? [15:32:24] hoo: hm... i'll double check then. maybe that code is just dead wood. [15:33:03] the terms "some" (in the bug title) and "most" (in the last comment) doesn't give much information.. ;) [15:34:00] DanielK_WMDE_: Don't know what code you're talking about... I've only looked at the page in browsers and it's there... dunno how, but it is [15:35:34] addCopyrightText ? [15:36:42] DanielK_WMDE: do you know of any reason we should not kill serialize and unserialize from Entity? I can't find any place where it is used [15:38:25] JeroenDeDauw: it should be killed, yes. Entity should never operate on blobs, nor know about serialization formats. [15:40:16] JeroenDeDauw: (un)serialization (blob <-> array) of entities should be handled in a separate service (mostly just a wrapper around json_encode/json_decode). It will be needed by EntityContent as well as in WikiPageEntityRevisionLookup (which doesn't use EntityContent, because it has to work on the client, too). [15:40:27] DanielK_WMDE_: Would you consider it problematic to have recursion depths of over 100 (in client)? [15:40:52] hoo: yes, unless someone shows me a good use case. [15:40:55] can't think of any [15:41:21] DanielK_WMDE_: Well, if you want to use some client features, you have to set "xdebug.max_nesting_level = 200 [15:41:21] " [15:41:45] at least it hast to be over 100... maybe 110 would already sufficent... but I just thought that's a lot [15:41:51] + be [15:44:57] hoo: oh, you are talking about PHP, not Lua! [15:45:36] in PHP, 100 isn't much. 200 is probably still sane enough. Though it would be interesting to see which code actually needs that [15:46:05] basically, anything that traverses the internal structure of an entity might: serializer/desireializer, differ, validator, etc [15:47:23] DanielK_WMDE_: Lua is less of a problem :P I think it's stack is more efficient than PHP's :P [15:52:41] (03CR) 10Daniel Kinzler: Use expectedFormat for more specific ParseException localizing (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [16:02:15] [13WikibaseDataModel] 15thiemowmde created 06isEntitled (+1 new commit): 02http://git.io/7TKP0A [16:02:15] 13WikibaseDataModel/06isEntitled 1432794a1 15Thiemo Mättig: Refactor isEmpty a bit and add isEntitled [16:03:20] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06isEntitled from 1432794a1 to 14b8a47c5: 02http://git.io/HklWXw [16:03:20] 13WikibaseDataModel/06isEntitled 14b8a47c5 15Thiemo Mättig: Refactor isEmpty a bit and add isEntitled [16:04:25] [13WikibaseDataModel] 15thiemowmde opened pull request #70: Refactor isEmpty a bit and add isEntitled (06master...06isEntitled) 02http://git.io/AKmA3Q [16:06:44] [travis-ci] wmde/WikibaseDataModel/isEntitled/32794a1 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23603906 [16:29:54] Tobi_WMDE: yes [16:33:41] well, except for the 2 you posted in the bug [17:28:04] Is there any admin present? [17:28:30] more or less [17:28:41] https://www.wikidata.org/wiki/User:RJ._Ruben_Junnior [17:28:57] This is misuse, isn't it? [17:29:18] krd: Deleted. [17:29:22] thx [17:57:53] where is the best place to report/discuss wikibase installation issues? [18:02:14] addshore: guess we could close the bug and make a new one for the remaining languages with a lower priority.. will talk to Lydia_WMDE tomorrow [18:02:57] or is someone working on making this working for zh too? [18:18:38] (03PS11) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [18:18:40] (03PS12) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [18:19:02] (03CR) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [18:25:07] thebunni: if you have questions then the wikidata-tech mailinglist. if you have found actual bugs then bugs.wikimedia.org [18:25:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [18:27:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [19:08:24] (03PS2) 10Daniel Kinzler: (bug 64308) Localize error parameters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 [19:13:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [19:35:13] (03PS1) 10Daniel Kinzler: (bug 64309) Introducing ChangeOp::validate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 [19:40:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [19:40:39] Hi. [19:43:01] Is there an easy way to get an overview of how many languages links are there in articles? [19:44:00] aharoni: mh? I don't get your question [19:44:59] something like: [19:45:28] there are a 1000 items with at least 250 site links [19:45:41] there are 100,000 articles with at least 150 site links [19:45:42] etc. [19:46:30] mh... not that I'm aware of, but I guess that could be done using SQL rather easy [19:58:11] aharoni: i think magnus did some stats [19:58:17] maybe email him? [19:58:27] Lydia_WMDE: ok [19:59:04] aharoni: actually [19:59:09] see http://tools.wmflabs.org/wikidata-todo/stats.php?reverse at the bottom [19:59:12] is that useful? [19:59:36] then you'd just need to ask him to make it show more than 10 [20:02:05] kittens [20:02:24] very [20:02:35] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129286 (owner: 10L10n-bot) [20:07:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/96f230a : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23621190 [20:27:12] Lydia_WMDE: you have no idea who I am, clearly [20:33:20] Lydia_WMDE: ping [20:36:40] aude: hey [20:37:04] are we branching? [20:37:16] are time formatters fixed? [20:37:47] aude: calendar says we are. i am not sure. let me check bug [20:38:13] aude: do you mean https://bugzilla.wikimedia.org/show_bug.cgi?id=63733 ? [20:38:16] then not yet [20:38:30] hmmm [20:38:36] no not that [20:38:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=63723 [20:38:43] that one? [20:38:46] then only 2 left [20:39:54] * aude looks [20:42:32] so we simply standardize the formatting [20:42:40] i suppose fine [20:43:01] cool [20:43:18] wonder the issue with the 2 languages? [20:43:22] do we have bugs for those? [20:43:49] tobi wanted to make them [20:43:53] don't think he did yet [20:44:29] ok [20:46:25] hmmm, lzh formats a timestamp [20:47:25] !nyan [20:47:26] ~=[,,_,,]:3 [20:47:32] kittens! [20:47:44] !kittens\ [20:47:47] !kittens [20:47:57] and seems "setlang=zh-classical" does not work for me [20:48:09] no idea how to change to that [20:48:12] zh-progressive [20:48:34] uselang works [20:51:21] gah, if i type "1934-" or "1934--", the widget says it will be displayed as "ValueParsers\ParseException" [20:51:34] but can't acutally save [20:52:21] Lydia_WMDE: aware of that? [20:52:35] if you enter anything invalid, it says that [20:52:48] aude: meh [20:52:49] nope [20:52:59] will investigate tomorrow [20:53:01] i'll pull master to make sure [20:53:04] ok [20:53:05] * aude pulled this morning [20:53:05] thx [20:53:23] we can make a branch and then please have folks try on test.wikidata [20:53:49] anything to do with time or geo, since we are switching to the backend stuff for those [20:54:32] if i type "1934-01f", it will be "1 January 1934" (assumes i want a day) [20:56:36] "1934f" = Precision higher than "DAY" is not supported yet [20:57:36] 1934 february 10 = "Precision higher than "DAY" not supported yet" [20:59:21] for English, we are switching to british format dates? [20:59:54] aude: eh we shouldn't? [21:01:27] en = american english [21:01:30] no! [21:02:00] currently these are formatted american english on wikidata and should be british format with en-gb / en-ca [21:02:15] (or according to preferences ideally) [21:16:30] Lydia_WMDE: american dates are even more complicated [21:16:51] aude: can you elaborate? [21:16:54] appears handled by a setting $wgAmericanDates and en can use either [21:17:36] i suppose british dates is ok, but note we are changing from current formatting on wikidata (people will notice) [21:18:07] our formatting does not work with the setting, but i don't see it used in wmf config [21:18:44] people can use preferences, although i don't entirely understand how they work for formatting dates [21:19:08] hmmm ok [21:19:09] for spelling, en = american english [21:19:17] not necessarily dates, apparently [21:19:26] i will try to figure this out with tobi tomorrow [21:19:55] i'd say the change is okay (i don't like, but ok), but is a noticeable change for the community so beware [21:20:47] ideally they should work consistent with the setting and preferences, but not high priority [21:24:39] gah, why is $bookstoreList in MessagesEn (in core) with links to amazon and various bookstores? [21:40:30] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf2/96f230a : Translation updater bot The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23628213 [22:24:14] (03PS1) 10Aude: Fix handling of parse error in JS widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129314 [22:29:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129314 (owner: 10Aude)