[07:27:57] (03CR) 10Daniel Kinzler: [C: 04-1] "oops, you are right :) also, see my replies inline." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 (owner: 10Daniel Kinzler) [08:11:37] (03PS2) 10Aude: Handle mismatching data type / values in snak formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 [08:13:42] (03PS3) 10Aude: Handle mismatching data type / values in snak formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 (https://bugzilla.wikimedia.org/63299) [08:15:46] (03CR) 10Aude: [C: 04-1] "@todo make sure we have sufficient test cases to cover where mismatches and snak formatting occurs" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 (https://bugzilla.wikimedia.org/63299) (owner: 10Aude) [08:18:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 (https://bugzilla.wikimedia.org/63299) (owner: 10Aude) [08:21:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 (https://bugzilla.wikimedia.org/63299) (owner: 10Aude) [08:46:58] [13WikibaseQuery] 15snaterlicious comment on pull request #13 1411fcaf0: Breaks in PHP 5.3 since closure $this support was not introduced until 5.4. 02http://git.io/HsjaEg [09:33:28] (03PS2) 10Daniel Kinzler: Introducing EntityConstraintProvider [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 [09:33:47] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I'm not exactly sure what this part of the test is supposed to test. Maybe Bene* should have a quick look?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131633 (owner: 10Hoo man) [09:34:19] (03PS14) 10Daniel Kinzler: Move term validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) [09:40:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 (owner: 10Daniel Kinzler) [09:42:03] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=58032 [09:42:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [09:42:33] we should make separate bugs for the remianing tasks and close this one [09:42:34] https://test.wikidata.org/wiki/Special:PagesWithProp?propname=wb-claims&propname-other=&uselang=en [09:45:49] * DanielK_WMDE is dialing in [09:46:07] addshore: good morning :] [09:46:15] morning :) [09:46:21] addshore: I have been tasked in reviewing your changes to the phpunit.php wrapper :-( [09:46:26] haha :P [09:46:37] sucks to be you? :) [09:46:49] not really [09:46:54] but our bootstrapper sucks :] [09:47:16] indeed, I'll probably take another look at it once this change is megred, but this will mean we can use the phars!!! [09:47:17] i've poked at the bootstrap and it's a really hard problem, [09:47:30] DanielK_WMDE: coming [09:47:35] bootstrap is run in non-global scope and we have bazillion globals [09:47:50] I had a patch that would list the Globals, invoke MediaWiki initialization then inject the new globals [09:47:52] it's hacky and difficult ot make phpunit properly aware fo all our globals via --bootstrap [09:47:54] but it had a bunch of bugs [09:47:57] which bootstrap are we talking about? :P bootstrap.php or phpunit.php? :P [09:48:02] --bootstrap [09:48:10] option of phpunit [09:48:14] bootstrap.php is used by phpunit itself [09:48:19] jeroen's evil mediawiki bootstrap doeos not work fo rme [09:48:22] where as phpunit.php is a lame workaround for the globals [09:48:27] hashar: yep [09:48:41] anyway [09:48:45] I hate array_splice() https://gerrit.wikimedia.org/r/#/c/131450/1/tests/phpunit/phpunit.php :D [09:48:47] gl hf :P [09:49:13] hashar: not really another way I could think of doing that [09:49:34] unless I totally reconstruct the array and overwrite $_SERVER['argv'] once we have the new one [09:53:13] (03PS15) 10Daniel Kinzler: Move term validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) [09:54:35] addshore: any reason for moving the stuff to phpunit.php ? [09:54:57] (03CR) 10Daniel Kinzler: "PS15 is essentially a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [09:54:58] so we can get rid of the extension of the phpunit Command class [09:55:11] (03PS5) 10Daniel Kinzler: (bug 64309) Introducing ChangeOp::validate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 [09:55:26] MediaWikiPHPUnitCommand::main(); is run at the bottom of phpunit.php [09:55:45] thats what this was trying to get rid of, remove that and we can actually use the phpunit class [09:56:06] the thing is that MediaWikiTestCase.php has some getCliArg() and setCliArg() functions as well :-( [09:56:20] though that is to interact with our test suite (not PHPUnit itself) [09:56:38] I know, I touch them here https://gerrit.wikimedia.org/r/#/c/131488/1/tests/phpunit/MediaWikiTestCase.php :P [09:56:58] lets merge [09:57:01] :P [09:57:44] addshore: also I think you can add a .phar to include_path() [09:58:00] so you would not need yet another parameter i.e. --include-phar or something [09:58:28] so just point --phpunit-dir to the dir the phar is in? [09:59:00] *goes to test* I have no problem with that if it works :) [09:59:48] that is hearsay from my foggy brain [10:00:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [10:00:24] (03PS1) 10WikidataBuilder: New Wikidata Build - 06/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131678 [10:00:24] addshore: include 'phar:///path/to/myphar.phar/file.php'; [10:00:29] from http://php.net/manual/en/intro.phar.php [10:00:52] ahh [10:00:54] so phar:///phpunit.phar [10:01:07] and include( PHPUnit/Version.php ); might just work ™ [10:01:30] :D [10:02:33] hey hashar, hey addshore! [10:02:38] hi DanielK_WMDE :) [10:02:53] hashar: will you be in zürich? addshore, will you? [10:03:00] I will be :) [10:03:03] \o/ [10:03:23] DanielK_WMDE: I will be there [10:03:26] and probably going to hate it [10:03:37] cause 3 days is not long enough :-d [10:03:43] :D [10:04:15] * hashar cries [10:04:30] hashar: nice :) [10:04:40] phar:///phpunit.phar [10:04:46] I am lading on thursday at 10pm iirc [10:04:48] landing [10:04:54] we are coming late [10:04:59] leaving early sunday (plane at 5pm) [10:05:07] or 6 [10:05:21] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Looks good overall. Just a few mistakes in the documentation and a few nitpicks." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [10:05:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [10:10:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131678 (owner: 10WikidataBuilder) [10:10:45] * hashar merges [10:11:21] yay [10:12:15] addshore: are you modifying my patch? [10:16:14] Tobi_WMDE: https://github.com/wmde/WikibaseQueryEngine/pull/21 [10:19:23] addshore: that https://gerrit.wikimedia.org/r/#/c/131466/ one drop color output :-( [10:20:12] DanielK_WMDE: you realize that it's just utterly wrong to have ParserOutput::getProperty return false for unset properties and at the same time allow setProperty with bools? only one can be true, one must be just horribly wrong. [10:21:11] DanielK_WMDE: it seems we disagree in what to belief. i belief getProperty tells the truth. setProperty must be used with strings and no other type. [10:22:20] ... because a) all properties turn into strings anyway the moment they are stored and b) because getProperty tells me that. [10:23:28] urgh, hashar will take a look when I get time :) [10:23:39] sure :) [10:23:46] DanielK_WMDE: sorry, i will put this in an email. [10:24:05] addshore: if I am in the mood for it I might adjust your patch this afternoon [10:25:30] :P [10:26:04] tata for now [10:30:28] is there anyone from WMDE still maintaining toolserver? some more links went down [10:30:53] if so please comment --> https://bugzilla.wikimedia.org/show_bug.cgi?id=60220 [10:32:11] (03CR) 10Daniel Kinzler: [C: 04-1] Handle mismatching data type / values in snak formatter (0317 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 (https://bugzilla.wikimedia.org/63299) (owner: 10Aude) [10:38:30] (03CR) 10Daniel Kinzler: [C: 031] "seems ok, but needs another look" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [10:40:04] (03CR) 10Daniel Kinzler: [C: 032] "We should move away from using Title objects and use TitleValue objects instead. Problem solved :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131633 (owner: 10Hoo man) [10:40:24] (03Merged) 10jenkins-bot: Fix ClientSiteLinkLookupTest for contentlang != en [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131633 (owner: 10Hoo man) [10:45:06] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 06/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131678 (owner: 10WikidataBuilder) [10:49:27] (03CR) 10Daniel Kinzler: [C: 032] Don't defer error reporting in the parser functions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [10:49:47] (03Merged) 10jenkins-bot: Don't defer error reporting in the parser functions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [11:02:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7a64d30 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24523810 [11:05:01] Yaaaaaaaaaaaaaaaayyy :) [11:05:06] Fixed! [11:05:28] hurrah! [11:05:59] now to have travis on 4.1 phpunit [11:06:14] have the master changes been merged yet? [11:06:19] some of them [11:09:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0ad71c1 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24524249 [11:44:20] (03CR) 10Hoo man: Fix viewing older Entity revisions (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [11:45:00] (03PS3) 10Hoo man: Fix viewing older Entity revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) [11:45:21] (03CR) 10Hoo man: "Addressed Thiemo's style comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [11:50:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [11:57:38] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131678 (owner: 10WikidataBuilder) [13:02:12] aude: would it be possible to setup our own travis instance on labs ? :-) [13:02:28] aude: I am wondering whether we could get Zuul to rely on a wmf Travis instead of Jenkins [13:14:23] hashar: looks like most (all?) of their code is open source, so probably [13:14:47] not sure how easy [13:14:53] no clue either :( [13:15:13] think if we have questions or issues, though, they would be willing to give some advice [13:20:35] [13WikibaseQuery] 15adrianlang pushed 1 new commit to 06snakview: 02http://git.io/tdaq4A [13:20:35] 13WikibaseQuery/06snakview 14e341634 15Adrian Lang: Make ExtensionSetup.php compatible with PHP 5.3 [13:23:19] [travis-ci] wmde/WikibaseQuery/snakview/e341634 : Adrian Lang The build was broken. http://travis-ci.org/wmde/WikibaseQuery/builds/24533853 [13:24:57] hi! [13:25:03] http://martinvalasek.com/blog/pictures-from-a-developers-life [13:35:09] (03PS1) 10Thiemo Mättig (WMDE): Remove non-working help URLs from all Wikibase API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131692 [13:40:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131692 (owner: 10Thiemo Mättig (WMDE)) [13:48:00] (03CR) 10Christopher Johnson (WMDE): [C: 031] Remove non-working help URLs from all Wikibase API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131692 (owner: 10Thiemo Mättig (WMDE)) [13:57:40] (03CR) 10Thiemo Mättig (WMDE): Fix viewing older Entity revisions (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [14:19:41] legoktm: https://www.wikidata.org/w/index.php?title=Wikidata:Status_updates/Next&action=history <- looks like your bot is dead :( [16:51:19] [13WikibaseDataModel] 15JeroenDeDauw created 06sp (+1 new commit): 02http://git.io/JtVkzQ [16:51:19] 13WikibaseDataModel/06sp 145fbf563 15jeroendedauw: Split method in Property [17:06:56] [travis-ci] wmde/WikibaseDataModel/sp/5fbf563 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/24552894 [17:20:28] (03CR) 10Hoo man: Fix viewing older Entity revisions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [17:20:53] [13WikibaseDataModel] 15JeroenDeDauw created 06claims (+1 new commit): 02http://git.io/LZLqvA [17:20:53] 13WikibaseDataModel/06claims 141fd8c15 15jeroendedauw: Extract class with diff logic out of Claims [17:20:58] (03PS4) 10Hoo man: Fix viewing older Entity revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) [17:21:04] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #84: Extract class with diff logic out of Claims (06master...06claims) 02http://git.io/Rv4mEg [17:21:30] (03CR) 10Hoo man: "Simplified EntityContent::getEntityRevision (per Thiemo)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [17:26:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [17:29:23] [travis-ci] wmde/WikibaseDataModel/claims/1fd8c15 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/24555265 [17:30:05] (03CR) 10Jeroen De Dauw: "Some minor things" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [17:49:48] (03PS1) 10Hoo man: Don't set Content-Length in EntityDataRequestHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131746 (https://bugzilla.wikimedia.org/60003) [17:55:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131746 (https://bugzilla.wikimedia.org/60003) (owner: 10Hoo man) [17:58:27] [13Diff] 15JeroenDeDauw created 06evili18n (+1 new commit): 02http://git.io/HGa5wA [17:58:27] 13Diff/06evili18n 14bc4a6ee 15jeroendedauw: Remove not needed i18n support [18:00:35] (03CR) 10Jeroen De Dauw: [C: 04-1] Fix viewing older Entity revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [18:01:29] [13DataTypes] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/dun5MA [18:01:29] 13DataTypes/06master 14d9eac6c 15Jeroen De Dauw: Update README.md [18:02:14] [13DataTypes] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/15m0kA [18:02:14] 13DataTypes/06master 14fbebb43 15Jeroen De Dauw: Merge pull request #16 from wmde/noI18nCompat... [18:08:51] [travis-ci] wmde/Diff#32 (evili18n - bc4a6ee : jeroendedauw): The build passed. [18:08:51] [travis-ci] Change view : https://github.com/wmde/Diff/commit/bc4a6ee483fb [18:08:51] [travis-ci] Build details : http://travis-ci.org/wmde/Diff/builds/24558188 [18:10:50] (03CR) 10Hoo man: Fix viewing older Entity revisions (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [18:11:51] (03PS5) 10Hoo man: Fix viewing older Entity revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) [18:12:33] (03CR) 10Hoo man: "Addressed Jeroen's comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [18:13:25] (03PS1) 10Jeroen De Dauw: Update composer.json [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131751 [18:18:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [18:22:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131751 (owner: 10Jeroen De Dauw) [18:38:09] Lydia_WMDE: loooooooooong weekly tread is starting to be looong [18:41:20] (03CR) 10Hoo man: [C: 032] Update composer.json [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131751 (owner: 10Jeroen De Dauw) [18:41:44] (03Merged) 10jenkins-bot: Update composer.json [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131751 (owner: 10Jeroen De Dauw) [19:09:07] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ad5310a : jeroendedauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24561440 [19:09:20] oO [19:14:02] (03PS1) 10Hoo man: Insert TestSites in ItemDeletionUpdateTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131763 [19:14:08] JeroenDeDauw: ^ [19:14:09] if we just tagged something, then i assume packagist doesn't know [19:14:13] yet* [19:14:19] aude: ^ fix travis (again) [19:14:28] test sites is evil [19:14:34] do we really need that [19:14:36] I know :( [19:15:03] $store = WikibaseRepo::getDefaultInstance()->getEntityStore(); [19:15:05] bad [19:15:07] yes... TestItemContents' items rely on it [19:16:38] aude: ItemDeletionUpdate uses the global factories, so there's no way we can inject this (without doing bigger refactoring) [19:16:40] aude, hoo: as soon as we can inject a mock entity store for testing, especially into API modules, we no longer need it. [19:17:22] getEntityStore() is a small step towards that - we are still using SiteSQLStore::newInstance() in many places - which is way worse [19:17:27] DanielK_WMDE: Via setters or via screwing with the factories? [19:17:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=64743 [19:18:16] I see [19:18:36] makes sense [19:18:57] hoo: setters (or a setter - overrideServices(...) or some such) [19:19:13] addshore was working on that... let me see if i can find the patch [19:19:28] I know that thing [19:19:32] for getentieties [19:19:40] https://gerrit.wikimedia.org/r/#/c/127000/ [19:19:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131763 (owner: 10Hoo man) [19:19:53] hm, i guess i should look at this again and +2 it. [19:20:07] hoo: care to comment? will bump this in my dashboard, too :P [19:20:37] Looks like I already looked at that... but I think I wasn't entirely convinced [19:24:01] (03CR) 10Daniel Kinzler: [C: 04-1] Add method to override services in GetEntities API (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 (owner: 10Addshore) [19:43:09] hoo: uh [19:43:12] hoo: that worked? [19:43:27] JeroenDeDauw: What? The unit test patch? [19:43:39] hoo: no, the conflict spec in composer.json [19:44:10] it looked sane and composer didn't complain about it [19:44:33] but my composer doesn't even know about MediaWiki [19:53:41] hoo: hoo|away this only gets held into account when you install wb into mw with composer [19:54:02] hoo|away: your MW install then acts as a virtual package named mediawiki/mediawiki [19:54:10] With the version your MW install happens to be at [20:00:47] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131845 (owner: 10L10n-bot) [20:02:20] WikidataJenkins is complaining about https://gerrit.wikimedia.org/r/#/c/131822/ [20:02:53] I will override it [20:15:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/519e105 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24567953 [20:42:57] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Thanks for the changes." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [20:44:45] (03CR) 10Hoo man: "I agree that this test etc. is not perfect, but let's unbreak the tests for now, please." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131763 (owner: 10Hoo man) [20:45:53] (03CR) 10Hoo man: [C: 04-2] "must not be merged unless we drop MediaWiki 1.23 support" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 (owner: 10Adrian Lang) [20:51:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Insert TestSites in ItemDeletionUpdateTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131763 (owner: 10Hoo man) [20:51:29] (03Merged) 10jenkins-bot: Insert TestSites in ItemDeletionUpdateTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131763 (owner: 10Hoo man) [21:04:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Interesting. I checked and yes, the Content-Length header must either be set to the compressed length or not be set (as Apache does it whe" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131746 (https://bugzilla.wikimedia.org/60003) (owner: 10Hoo man) [21:04:37] (03Merged) 10jenkins-bot: Don't set Content-Length in EntityDataRequestHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131746 (https://bugzilla.wikimedia.org/60003) (owner: 10Hoo man) [21:16:47] mh, looks like travis is slacking off slightly https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds [21:18:31] could be that core is "blocking" us off https://travis-ci.org/wikimedia/mediawiki-core/builds as it's in the same org. [22:37:18] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2e74829 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24572445 [22:44:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f313c53 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24573595 [23:03:59] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vtNtmw [23:03:59] 13WikibaseDatabase/06master 14e3562eb 15Jeroen De Dauw: Update README.md [23:39:36] (03PS1) 10Aude: Fix typo in WikibaseRepo::getMessageParameterFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131906 [23:44:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131906 (owner: 10Aude)