[07:08:14] (03CR) 10Jeroen De Dauw: [C: 04-1] Accept array of HTML messages in tooltip JavaScript (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [07:50:14] um...I have a strange(?) problem with the Wikidata wiki [07:50:24] I wanted to insert this link "* [[Category:Sports_task_forces|Other sports task forces on Wikidata]]" [07:50:31] now take a look at https://www.wikidata.org/wiki/Wikidata:Sandbox [07:50:41] the link is just not there [07:56:59] [13ValueView] 15thiemowmde pushed 1 new commit to 06toggler-options: 02http://git.io/2tjjdw [07:56:59] 13ValueView/06toggler-options 1420dd538 15Thiemo Mättig: Update VALUEVIEW_VERSION [08:22:57] bthfan: try "* [[:Category:Sports_task_forces|Other sports task forces on Wikidata]]" [08:23:16] looks like it's added as a category now [08:44:06] aude: ah ok.. [08:44:29] [13ValueView] 15adrianlang 04force-pushed 06jQueryUi19 from 142f8b648 to 14a8c3b4c: 02http://git.io/UMzieQ [08:44:29] 13ValueView/06jQueryUi19 14a8c3b4c 15Adrian Lang: Make NativeEventHandler test compatible with jQuery UI 1.9... [08:50:15] (03PS2) 10Thiemo Mättig (WMDE): Accept array of HTML messages in tooltip JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) [08:56:04] [13ValueView] 15adrianlang comment on pull request #58 14e5a4e95: Non-custom values are numbers or strings. It's like this:... 02http://git.io/Nr24ew [08:57:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [09:00:12] i wasnt following wd for quite a big while. is it possible e.g. from wq to get corresponding wp article in the same language when both are set for an item? [09:07:35] Cladis: I think you can use the "normal" WD api for that [09:07:51] with WQ you mean http://wdq.wmflabs.org/api_documentation.html ? [09:21:03] bthfan i mean from an article like with properties. througyh api i never doubted it's possible :) [09:21:14] *through [09:21:59] i meant wq as wikiquote [09:24:22] ah.. [09:24:33] no idea on that, maybe someone else knows [09:44:24] (03PS1) 10Thiemo Mättig (WMDE): [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 [09:46:39] (03CR) 10Aude: [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [09:47:31] (03CR) 10Aude: [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [09:51:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [10:00:25] (03PS1) 10WikidataBuilder: New Wikidata Build - 11/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/138791 [10:10:03] the Dutch wikipedia seems to be the only Wikipedia that has an article for every national curling team in the world.. [10:10:30] (actually most Wikipedias don't have articles for national curling teams at all ;) [10:11:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/138791 (owner: 10WikidataBuilder) [10:11:17] (03CR) 10Aude: [C: 032] New Wikidata Build - 11/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/138791 (owner: 10WikidataBuilder) [10:14:22] (03Merged) 10jenkins-bot: New Wikidata Build - 11/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/138791 (owner: 10WikidataBuilder) [10:17:22] (03CR) 10Daniel Kinzler: [C: 032] Register GenericExceptionLocalizer in WikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138613 (owner: 10Aude) [10:17:36] (03Merged) 10jenkins-bot: Register GenericExceptionLocalizer in WikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138613 (owner: 10Aude) [10:19:40] (03CR) 10Daniel Kinzler: [C: 031] "looks good at a glance, but I'd like to test this manually." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 (https://bugzilla.wikimedia.org/65002) (owner: 10Hoo man) [10:26:14] (03CR) 10Adrian Lang: Factor out generation of site links HTML into own class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [10:27:32] (03PS7) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [10:27:34] (03PS1) 10Adrian Lang: Start refactoring SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138793 [10:29:26] Adrian_WMDE: is master broken currently? [10:29:43] [13Geo] 15thiemowmde created 06latlong-doc (+1 new commit): 02http://git.io/yz5zeg [10:29:43] 13Geo/06latlong-doc 14d75f451 15Thiemo Mättig: Document latlong vs. geocoordinate confusion [10:29:55] I'm getting lots of errors "Uncaught TypeError: Cannot read property 'push' of undefined" in Uncaught TypeError: Cannot read property 'push' of undefined [10:30:13] [13Geo] 15thiemowmde opened pull request #10: Document latlong vs. geocoordinate confusion (06master...06latlong-doc) 02http://git.io/sffNlw [10:30:14] sorry, in jquery.ui.widget.js line 130 [10:31:13] [13Geo] 15thiemowmde created 06globe-null (+1 new commit): 02http://git.io/1WfkuA [10:31:13] 13Geo/06globe-null 141af36a6 15Thiemo Mättig: Document that globe can be null [10:32:13] [13Geo] 15thiemowmde opened pull request #11: Document that precision can be null (06master...06globe-null) 02http://git.io/j4eZ3g [10:34:51] Tobi_WMDE: Specify. Which master with which master? What kind of broken= [10:37:16] Adrian_WMDE: Tobi_WMDE> I'm getting lots of errors "Uncaught TypeError: Cannot read property 'push' of undefined" [10:37:35] Adrian_WMDE: master of wikibase and "composer update" [10:37:50] Tobi_WMDE: Merge jQueryUi19 [10:38:12] aka yes, it is broken with core master [10:38:13] Adrian_WMDE: from where? [10:38:31] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/138627/ [10:38:36] ah, see [10:38:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [10:41:24] Adrian_WMDE: ok, JS errors are gone with that patch, but UI is still broken, e.g. buttons not disabled when adding a statement. input fields not shown when adding a sitelink, etc.. [10:44:11] Tobi_WMDE: That would probably be deadAutocomplete https://gerrit.wikimedia.org/r/#/c/138619/ [10:50:45] Tobi_WMDE: I'll have a short fixup for jQueryUI19 in a few minutes [10:53:38] (03PS2) 10Adrian Lang: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 [10:53:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138793 (owner: 10Adrian Lang) [10:54:10] aaaaah, untested code! [10:57:22] aude: It's not like that, I swear! I just didn't run ALL the tests [10:57:32] something else [10:57:45] branch is not broken though [10:58:02] No, it's my fault [10:58:20] thing i am looking at is not [10:58:43] imho, time to move / refactor the change dispatcher [10:58:45] Tobi_WMDE: ^ [10:59:33] Lydia_WMDE doesn't get happy when it breaks [11:01:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [11:05:33] (03PS2) 10Adrian Lang: Start refactoring SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138793 [11:08:08] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/138791 (owner: 10WikidataBuilder) [11:13:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138793 (owner: 10Adrian Lang) [11:21:24] (03PS1) 10Tobias Gritschacher: Get rid of old browsertest files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) [11:25:51] (03PS3) 10Adrian Lang: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 [11:26:14] Tobi_WMDE: Plz merge that jQueryUI19 thing [11:26:18] drives me crazy [11:33:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) (owner: 10Tobias Gritschacher) [11:33:48] [travis-ci] wmde/WikibaseQueryEngine/globe-dvh/2b9065f : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/27300558 [11:37:47] argh [11:38:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [11:42:05] (03CR) 10Aude: [C: 04-1] Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [11:55:19] [13Geo] 15thiemowmde created 06geocoord (+1 new commit): 02http://git.io/Ry6cMA [11:55:19] 13Geo/06geocoord 14a3775a5 15Thiemo Mättig: Delete GeoCoordinateValue [11:57:24] [13Geo] 15thiemowmde opened pull request #12: Delete GeoCoordinateValue (06master...06geocoord) 02http://git.io/0tXM3w [12:05:48] [13Geo] 15thiemowmde 04force-pushed 06geocoord from 14a3775a5 to 1460804bf: 02http://git.io/isRKzw [12:05:48] 13Geo/06geocoord 1460804bf 15Thiemo Mättig: Delete GeoCoordinateValue [12:10:25] (03PS4) 10Tobias Gritschacher: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [12:11:28] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [12:11:51] (03CR) 10Tobias Gritschacher: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [12:13:27] Tobi_WMDE: suppose it's too late already but does this mean wikibase is not compatible with mediawiki 1.23 ? [12:13:55] aude: waht do you mean exactly? [12:14:10] https://gerrit.wikimedia.org/r/#/c/138627/ works on older versions? [12:14:36] aude: not sure [12:14:58] but there are other changes that broke compability before.. :( [12:15:01] obviosuly important that master works [12:15:04] yeah [12:18:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [12:24:20] (03CR) 10Daniel Kinzler: [C: 04-1] Start refactoring SiteLinksView (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138793 (owner: 10Adrian Lang) [12:30:32] (03CR) 10Adrian Lang: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [12:37:49] (03PS2) 10Thiemo Mättig (WMDE): [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 [12:45:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [12:47:50] [13ValueView] 15thiemowmde comment on pull request #58 14e5a4e95: This variable name is misleading. Should be `_customValueIndex` or something like that. 02http://git.io/R9KPGQ [12:50:50] [13jenkins-job-builder-config] 15tobijat created 06adjust_browsertest_builds (+1 new commit): 02http://git.io/YsULuQ [12:50:50] 13jenkins-job-builder-config/06adjust_browsertest_builds 14264ebec 15Tobias Gritschacher: Adjust browsertest jobs to new location of browsertest files... [12:51:05] [13jenkins-job-builder-config] 15tobijat opened pull request #9: Adjust browsertest jobs to new location of browsertest files (06master...06adjust_browsertest_builds) 02http://git.io/g3ES_A [12:51:20] (03PS1) 10Tobias Gritschacher: Move browsertests from Wikibase.git into its own repository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138805 (https://bugzilla.wikimedia.org/66469) [12:54:33] [13ValueView] 15thiemowmde comment on pull request #58 14e5a4e95: We know `toPrecision` returns a string, right? Wouldn't `parseFloat` be better then? 02http://git.io/VxIvZg [12:54:48] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/bySzWA [12:54:48] 13Geo/06master 1444308d7 15Jeroen De Dauw: Merge pull request #12 from DataValues/geocoord... [12:55:07] [13jenkins-job-builder-config] 15tobijat closed pull request #8: ReAdd mw-get-client-extensions builder to wikibase-client-tests (06master...06clientExtensions) 02http://git.io/0vVDKg [12:55:58] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/AAUNJQ [12:55:58] 13Geo/06master 14681e468 15Jeroen De Dauw: Update README.md [12:56:33] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/X6Z8uA [12:56:33] 13Geo/06master 14c34ab0d 15Jeroen De Dauw: Update phpunit.xml.dist [12:57:33] [13Geo] 15JeroenDeDauw 04deleted 06globe-null at 141af36a6: 02http://git.io/UvvWMw [12:57:43] [13Geo] 15JeroenDeDauw 04deleted 06latlong-doc at 14d75f451: 02http://git.io/Jm6-Nw [12:59:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138805 (https://bugzilla.wikimedia.org/66469) (owner: 10Tobias Gritschacher) [13:02:58] [13ValueView] 15thiemowmde closed pull request #58: Support editing arbitrary precisions for GlobeCoordinates (06master...06editCoordPrecision) 02http://git.io/w4O40g [13:05:31] (03PS2) 10Daniel Kinzler: Use CacheOutput::unsetProperty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 (owner: 10Adrian Lang) [13:06:08] (03CR) 10Daniel Kinzler: "removing hoo's -2, since it referred to a 1.23 compat issue" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 (owner: 10Adrian Lang) [13:13:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 (owner: 10Adrian Lang) [13:16:21] [13ValueView] 15thiemowmde 04deleted 06jQueryUi19 at 14a8c3b4c: 02http://git.io/5e_5ZA [13:16:31] (03CR) 10Jeroen De Dauw: [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [13:21:15] https://github.com/wmde/ValueView/pull/65#issuecomment-45738977 [13:21:17] :D [13:21:59] Thiemo_WMDE is more and more getting JeroenDeDauw.. :P [13:22:28] at least they ahare the same library of lolcat pictures [13:22:32] Meow. [13:22:32] hah [13:25:27] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/riZmuw [13:25:27] 13WikibaseInternalSerialization/06master 14c66e57d 15Jeroen De Dauw: Update phpunit.xml.dist [13:25:37] (03PS3) 10Jeroen De Dauw: Move thing only used in repo from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136824 [13:25:40] (03PS8) 10Jeroen De Dauw: Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 [13:27:27] Thiemo_WMDE: just wondering whether https://github.com/wmde/ValueView/pull/58 was a breaking change.. [13:27:31] guess not, right? [13:30:39] [13WikibaseDataModel] 15thiemowmde 04deleted 06readd at 14e24aaae: 02http://git.io/LVchLA [13:32:30] [13ValueView] 15tobijat created 06update_rel from 06master (+0 new commits): 02http://git.io/OCG3Wg [13:36:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136824 (owner: 10Jeroen De Dauw) [13:37:09] [13ValueView] 15tobijat pushed 1 new commit to 06update_rel: 02http://git.io/-EYVMA [13:37:09] 13ValueView/06update_rel 145833af4 15Tobias Gritschacher: Update release notes and version [13:37:20] [13ValueView] 15tobijat opened pull request #67: Update release notes and version (06master...06update_rel) 02http://git.io/k_CVeQ [13:37:26] Thiemo_WMDE: https://github.com/wmde/ValueView/pull/67 [13:39:33] Thiemo_WMDE: we can also just add the missing release notes to your other pull request: https://github.com/wmde/ValueView/pull/66 [13:39:37] I'm fine with both [13:41:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [13:42:31] (03PS3) 10Thiemo Mättig (WMDE): [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 [13:43:58] Tobi_WMDE: i amended 66 long ago. o_0 [13:46:21] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/tcBRSg [13:46:21] 13ValueView/06master 142fd887a 15thiemowmde: Merge pull request #67 from wmde/update_rel... [13:48:43] Thiemo_WMDE: I know. my pull request was about the missing release note from adrian's change [13:49:30] I was just suggesting amening it to your change, as that would have avoided the merge conflict. [13:49:56] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/3q1QNA [13:49:56] 13WikibaseInternalSerialization/06master 148489a36 15jeroendedauw: Fix @covers tags [13:49:59] now you need to rebase https://github.com/wmde/ValueView/pull/66 [13:50:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [13:50:02] but should be easy [13:50:16] [13ValueView] 15thiemowmde 04force-pushed 06toggler-options from 1420dd538 to 1407bf4c2: 02http://git.io/zlG9VA [13:50:16] 13ValueView/06toggler-options 1407bf4c2 15Thiemo Mättig: Let me set toggler options [13:50:29] yay [13:50:42] Tobi_WMDE: done, please have a look at https://github.com/wmde/ValueView/pull/66 [13:51:03] Thiemo_WMDE: will try in a minute [13:51:20] Thiemo_WMDE: you no food? [13:51:33] after 4 months i'm slowly getting used to github. still strange. [13:51:59] JeroenDeDauw: thanks, not today. need to leave early(TM). [13:52:42] Thiemo_WMDE: does (TM) actually stand for your name? ;) [13:53:19] TMg# [13:53:22] -# [13:53:23] (03CR) 10Tobias Gritschacher: [C: 032] Remove dead calls to autocomplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138619 (owner: 10Adrian Lang) [13:53:42] (03Merged) 10jenkins-bot: Remove dead calls to autocomplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138619 (owner: 10Adrian Lang) [13:54:33] aude: are you fine with https://gerrit.wikimedia.org/r/#/c/138627/ now? [13:54:44] annoying hat master is broken.. [13:54:55] *that [13:55:03] needs backporting [13:55:15] all this stuff, imho [13:55:16] aude: needs merging first.. ;) [13:55:18] so yes [13:55:35] or people come crying on tuesday [13:55:40] (03CR) 10Jeroen De Dauw: [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [13:56:04] aude: so jQuery UI 1.9 will be deployed next tuesday then? [13:56:12] i don't know if the jquery migrate plugin covers jquery ui [13:56:12] hm [13:56:16] yes [13:56:19] ok [13:56:26] well [13:56:28] there's a setting for that that is false by default [13:56:32] then we should definitely backport [13:56:33] i'd have to try again [13:56:47] and anything in valueview that is relevant [13:56:54] (03CR) 10Tobias Gritschacher: [C: 032] Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [13:57:12] $wgIncludejQueryMigrate = true; [13:57:16] (03Merged) 10jenkins-bot: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138627 (owner: 10Adrian Lang) [13:57:22] false by default [13:58:13] i have migrate and it's broken [14:00:50] (03PS1) 10Aude: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/138818 [14:03:07] [13ValueView] 15tobijat closed pull request #66: Let me set toggler options (06master...06toggler-options) 02http://git.io/6DGAOA [14:05:48] (03Abandoned) 10Jeroen De Dauw: WIP - Add internal serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138310 (owner: 10Jeroen De Dauw) [14:06:17] (03PS1) 10Daniel Kinzler: Make EntityContentFactory rely on EntityHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 [14:12:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/138818 (owner: 10Aude) [14:13:21] (03CR) 10Aude: [C: 032] Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/138818 (owner: 10Aude) [14:13:39] (03Merged) 10jenkins-bot: Make TemplatedWidget and SnakTypeSelector compatible with jQuery UI 1.9 [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/138818 (owner: 10Aude) [14:16:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [14:28:16] (03PS1) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [14:30:19] Thiemo_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=65535 can be closed, right? [14:31:45] Tobi_WMDE: i think so, yes. [14:34:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [14:36:46] (03CR) 10Daniel Kinzler: [C: 032] Use CacheOutput::unsetProperty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 (owner: 10Adrian Lang) [14:37:00] (03Merged) 10jenkins-bot: Use CacheOutput::unsetProperty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 (owner: 10Adrian Lang) [14:39:39] (03CR) 10Daniel Kinzler: [C: 031] "I don't want to block this, it's not so horrible." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [14:43:08] (03CR) 10Daniel Kinzler: [C: 031] "seems good, but needs manual testing, since our test for the output of EntityView suck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [14:53:17] (03CR) 10Thiemo Mättig (WMDE): [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [14:57:52] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06one-degree from 14159baef to 14d84e3a7: 02http://git.io/qDcK8A [14:57:52] 13DataValuesJavascript/06one-degree 14d84e3a7 15Thiemo Mättig: Display 1 degree as number, not text [15:03:40] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "+1 plus +1 is +2, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [15:03:56] (03Merged) 10jenkins-bot: Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [15:08:43] Tobi_WMDE: are you sure we already reimplemented all the old tests? [15:10:10] no, that's what I mentioned in the commit message [15:15:57] (03CR) 10Tobias Gritschacher: [C: 031] "I've tested it manually and it works for deleted items as expected. We have bug 65533 for deleted properties." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 (https://bugzilla.wikimedia.org/65002) (owner: 10Hoo man) [15:19:02] (03PS1) 10Daniel Kinzler: Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 [15:24:12] [travis-ci] wmde/DataValuesJavascript/one-degree/d84e3a7 : Thiemo Mättig The build was broken. http://travis-ci.org/wmde/DataValuesJavascript/builds/27318529 [15:26:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [15:27:44] (03PS2) 10Daniel Kinzler: Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 [15:28:10] (03PS1) 10Daniel Kinzler: Use uncached EntityLookup during testin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138828 [15:30:45] (03PS2) 10Thiemo Mättig (WMDE): Refactoring/optimizing SpecialUnconnectedPages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138100 [15:33:31] loooooooooool [15:33:33] 12 fields [15:33:35] in SqlStore [15:33:38] >_> [15:40:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [15:43:54] (03CR) 10Jeroen De Dauw: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [15:46:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138828 (owner: 10Daniel Kinzler) [15:47:38] (03PS1) 10Thiemo Mättig (WMDE): Clean-up SqlStore::newEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138831 [15:49:37] (03CR) 10Daniel Kinzler: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [15:50:49] (03PS2) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [15:56:09] (03CR) 10Jeroen De Dauw: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [15:56:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138100 (owner: 10Thiemo Mättig (WMDE)) [15:58:07] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138831 (owner: 10Thiemo Mättig (WMDE)) [15:58:25] (03PS4) 10Jeroen De Dauw: Move thing only used in repo from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136824 [15:58:34] DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/136824/ [15:58:51] (03CR) 10Daniel Kinzler: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [15:59:30] (03PS3) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [15:59:43] JeroenDeDauw: already replied [16:01:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [16:04:44] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Pretty straightforward. I almost hit +2, but there are some mistakes (some older ones and a few new)." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [16:04:48] (03PS4) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [16:06:40] (03CR) 10Jeroen De Dauw: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:06:41] JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=66486 [16:08:44] (03CR) 10Daniel Kinzler: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:08:48] JeroenDeDauw: --^ [16:09:55] JeroenDeDauw: the basic idea is that EntityContent *should* be a value object, but can't because of the way the Content interface is defined. So I try to delegate any "smartness" to the respective EntityHandler instance [16:12:26] (03CR) 10Jeroen De Dauw: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:13:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136824 (owner: 10Jeroen De Dauw) [16:15:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [16:16:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [16:17:53] (03PS5) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [16:18:53] (03CR) 10Jeroen De Dauw: [C: 04-1] Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:25:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [16:26:57] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I would like to merge this and the depending I2b7269b2efb8c1f52aead1acfda199c04108e531 as they are and tackle all the nitpicks in follow-u" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:37:49] (03CR) 10Aude: Don't use services in EntityContent (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:42:04] (03PS6) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [16:42:55] (03CR) 10Daniel Kinzler: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:43:30] (03CR) 10Jeroen De Dauw: "My concern here is not a nitpick. I want to see it addressed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [16:44:29] JeroenDeDauw: regarding the logic behind moving getEntityView to EntityHandler: it'S exactly parallel to how this works for EntityDiffView. [16:44:53] I think having these consistent makes sense. [16:45:14] and it provides a single place for deciding which view class to use for which entity. [16:45:41] but i'll factor it out for now. we can discuss the alternative once you put up a patch. [16:49:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [16:49:39] (03CR) 10Tobias Gritschacher: [C: 031] "It's pretty straight forward. I did not see any issues with that, though I think a second pair of eyes would be good." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [17:02:51] (03PS1) 10Hoo man: No longer run tests for MediaWiki 1.23, run repo tests with MySQL [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138843 [17:03:26] aude: --^ [17:03:45] I was wtfed we're not running repo test w/ mysql [17:04:23] (03CR) 10Aude: Use new serializers for entity serialization (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [17:04:42] wtf, indeed! [17:06:37] * aude would be happier if Lydia_WMDE would merge it though :) [17:06:49] * hoo eyes Lydia_WMDE [17:06:54] hmmm? [17:06:54] so she's aware and maybe we want to tag some version of wikibase as 1.23 [17:06:54] :P [17:06:59] aude: Just talked to her about 1.23 compat [17:07:14] yeah we discussed this in the office last week or so [17:07:19] (03CR) 10Jeroen De Dauw: Use new serializers for entity serialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [17:07:23] probably mw1.23-wmf19 which is before the js bugs [17:07:26] Lydia_WMDE: ok :) [17:07:29] there is too much already we depend on from newer than 1.23 [17:07:39] yeah [17:08:00] we do not have automated testing for this do we? [17:08:04] no [17:08:12] we should for the next one [17:08:14] The unit tests still pass with the 1.23 rc [17:08:36] mmm [17:10:13] (03PS3) 10Daniel Kinzler: Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 [17:10:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138843 (owner: 10Hoo man) [17:11:47] JeroenDeDauw: ---^^ [17:14:26] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/jqp-8w [17:14:26] 13WikibaseInternalSerialization/06master 1419c11a2 15jeroendedauw: Have one pretty printed JSON file [17:14:42] (03CR) 10Aude: [C: 032] "lydia no want chocolate? :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138843 (owner: 10Hoo man) [17:14:55] (03Merged) 10jenkins-bot: No longer run tests for MediaWiki 1.23, run repo tests with MySQL [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138843 (owner: 10Hoo man) [17:15:09] done [17:15:14] * hoo hopes the repo tests still pass with MySQL [17:15:19] haven't run that combination for some time [17:15:35] they pass on jenkins, if it's worth anythiing [17:15:52] Does our jenkins use MySQL/Maria? [17:16:01] no idea [17:16:10] oh, it uses sqlite [17:16:12] :( [17:16:28] well i run the tests sometimes on mysql [17:17:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [17:22:40] (03CR) 10Aude: Use new serializers for entity serialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [17:26:57] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/cbvUbg [17:26:57] 13WikibaseInternalSerialization/06master 1428a685a 15jeroendedauw: Have one pretty printed JSON file [17:48:27] (03PS22) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [17:53:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [17:54:03] oh, that was supposed to stay a draft, duh [18:42:51] Hello, does anybody, by chance, have a link to a description of the currently used external JSON at hand? [19:47:25] thepwnco: hi :) [19:47:33] r u around? [19:47:39] benestar: hello there! I am indeed [19:48:04] thepwnco: do you also want to make the items tour live? [19:48:13] or only the statements atm? [19:49:12] both - if you don't see any problems with the items content ... and don't mind it replacing the current content that's there [19:51:28] thepwnco: did you already think about how the user will realize that he/she is on testwikidata? [19:51:53] I thought we might also add a big message to the top of the tour item with javascript [19:52:16] and/or add a link back to wikidata at the end of the tour [19:52:34] oh, that's a good idea. I just included it in the content itself (both at the beginning and at the end) [19:52:49] but I think a js message is also good to have [19:54:20] links at the end should be in there for statements - sorry, just added it to items [19:55:27] ok, great [19:55:33] I think this makes it clear [19:57:13] thepwnco: afk now, maybe I will back in a few hours, otherwise later [19:57:15] cu [19:57:25] sounds good! thanks. [20:30:16] JohnLewis: nice, re: mailing lists :) [20:30:30] aude: Thanks :) [21:07:32] I wonder if a item like [21:07:33] "2009 Dubai Tennis Championships (Q807962)" [21:07:59] should be tagged with "instance of Dubai Tennis Championships (Q299409)" ? [21:08:21] at least this would look like a reasonable choice to me to connect this.. [21:11:02] Yeah. [21:28:37] thepwnco: I won't have time today to implement the tours but one last notice [21:28:45] especially at the items tour some sections seem to be a bit long [21:28:55] eg dialogue 2 [21:29:20] you may think about splitting it into two dialogues or shorten it a bit [21:29:44] benestar: sure, I can do that [21:29:49] people won't love to read novels ;) [21:29:55] they want to click and see sth [21:30:04] I'll try to keep to the length you did for the first one [21:30:28] maybe such basic explanations can be done better in another medium [21:30:38] tours work best for actually doing someting [21:30:40] +h [21:32:01] for that purpose prezi is great [21:32:28] thepwnco: anyway, going to bed now, cu [21:32:45] ok, talk to you later