[04:55:29] (03PS1) 10Legoktm: Add simple script to "touch" pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) [05:03:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) (owner: 10Legoktm) [07:15:40] hi [08:14:31] [13ValueView] 15adrianlang comment on pull request #68 14a484682: Two? I see only _customValueIndex without declaration (will add that). 02http://git.io/UP0Dwg [08:58:40] * hoo waves [09:00:06] hey hoo :) [09:00:16] hoo: are you coming to the office this week? [09:00:26] Lydia_WMDE: I hope so [09:00:33] got my email yesterday? [09:00:34] \o/ [09:00:39] i did not [09:00:43] My evolution stopped working so I had to go to gmail [09:00:46] gnah [09:01:30] Lydia_WMDE: I'll deploy the suggester fix at 12:00 [09:01:37] \o/ [09:01:38] unless there's a reason not to [09:01:43] Tobi_WMDE: ^ [09:01:48] hoo: i think not [09:01:53] Thiemo_WMDE: ^ [09:02:36] ALL THE DEVS ^ [09:02:39] Lydia_WMDE: here you go :) [09:02:48] lazowik: lol. thank you! [09:03:00] how are you? [09:03:11] good [09:03:11] legoktm: :* @ script [09:03:19] but yet another thing popped out [09:03:25] ohnoes [09:03:33] not here [09:03:34] Lydia_WMDE: sure, talked with hoo about this yesterday. i think backport this is a good idea, however not 100% required. [09:03:44] k [09:04:09] Lydia_WMDE: other thing that I have to do before I'm finally free [09:04:16] gotcha [09:04:20] Thiemo_WMDE: I hope that this also fixes the bug many are reporting on Wikidata [09:04:34] but possible that it doesn't [09:04:45] Lydia_WMDE: and you? :) [09:05:19] pretty good [09:12:36] [13ValueView] 15mariushoch created 060.6.2 (+1 new commit): 02http://git.io/VQBZuQ [09:12:36] 13ValueView/060.6.2 14043d870 15Marius Hoch: Don't reset the input value on suggester blur... [09:15:41] [13ValueView] 15mariushoch pushed 1 new commit to 060.6.2: 02http://git.io/0kZC7A [09:15:41] 13ValueView/060.6.2 140bc1c00 15Marius Hoch: Update README [09:16:36] [13ValueView] 15mariushoch tagged 060.6.2 at 060.6.2: 02http://git.io/JgHvKg [09:18:56] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/_ALbtA [09:18:56] 13ValueView/06master 140834593 15Marius Hoch: Update README [09:20:57] (03PS1) 10Hoo man: Require ValueView 0.6.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139799 [09:21:05] easy peasy CR ^ [09:24:38] the auto discriptions in Wikidata are no longer working [09:24:58] it makes editing much more difficult [09:27:16] (03CR) 10Hoo man: [C: 04-1] "I don't think we want null edits, but we need to be able to filter the secondary data updates by class name." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) (owner: 10Legoktm) [09:28:18] Thiemo_WMDE: https://gerrit.wikimedia.org/r/139799 [09:28:22] please merge [09:28:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139799 (owner: 10Hoo man) [09:30:09] (03CR) 10Tobias Gritschacher: "@hooman: according to bug 64600 we want null-edits. if that needs to be discussed, please do so on the bug." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) (owner: 10Legoktm) [09:31:12] (03CR) 10Hoo man: "We had that discussion on IRC: As null edits can cause changes in the serialization they *can* show up in the edit history, thus we don't " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) (owner: 10Legoktm) [09:32:46] (03CR) 10Tobias Gritschacher: "Ok, then please let's update the bug." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) (owner: 10Legoktm) [09:34:32] Tobi_WMDE: https://gerrit.wikimedia.org/r/139799 merge? :D [09:35:35] the diff is minimal: https://github.com/wmde/ValueView/compare/0.6.1...0.6.2 [09:36:58] hoo: one moment [09:37:09] Sure [09:39:31] [13Geo] 15thiemowmde 04force-pushed 06globe-null from 140dff6aa to 14ebcd121: 02http://git.io/zftVaQ [09:39:31] 13Geo/06globe-null 14ebcd121 15Thiemo Mättig: Globe default value [09:40:32] hoo: generally it should not be necessary to update the version in wikibase as the semantic versioning would already include the highest released version <0.7 [09:41:40] Tobi_WMDE: Yeah, but Jeroen said we should do that because that's not enforced behaviour [09:41:51] Composer might also select the older version [09:42:03] hoo: in what cases? [09:42:10] (03CR) 10Tobias Gritschacher: [C: 032] Require ValueView 0.6.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139799 (owner: 10Hoo man) [09:42:29] (03Merged) 10jenkins-bot: Require ValueView 0.6.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139799 (owner: 10Hoo man) [09:42:48] (03PS1) 10Hoo man: Update ValueView to 0.6.2 to fix a suggester bug [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/139800 [09:42:51] [13ValueView] 15thiemowmde comment on pull request #68 14a484682: Unified diffs keep confusing me. "Two" as in `_customValue` and `_customValueIndex`. ;-) 02http://git.io/wuNG_Q [09:43:06] Tobi_WMDE: No idea :P [09:43:17] Not going to do it for the branch, just for master [09:43:31] I guess people are careful enough on the branch to notice that [09:44:37] Lydia_WMDE, Tobi_WMDE: i'll be in the hangout for the daily [09:44:49] DanielK_WMDE_: k - coming in 2 mins [09:47:31] hangout [09:47:32] DanielK_WMDE_: ^^ [09:50:42] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9527c2a : Marius Hoch The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/27666312 [09:50:50] wtf [09:51:18] oh, even my fault [09:53:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/139800 (owner: 10Hoo man) [09:55:50] (03CR) 10Hoo man: [C: 032] Update ValueView to 0.6.2 to fix a suggester bug [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/139800 (owner: 10Hoo man) [09:58:58] (03Merged) 10jenkins-bot: Update ValueView to 0.6.2 to fix a suggester bug [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/139800 (owner: 10Hoo man) [10:00:31] (03PS1) 10WikidataBuilder: New Wikidata Build - 16/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139801 [10:10:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139801 (owner: 10WikidataBuilder) [10:17:08] Lydia_WMDE: https://test.wikidata.org/w/index.php?title=Q22&action=history yikes :/ [10:26:22] Lydia_WMDE: Ok, stuff *should* be ok now. [10:26:33] I guess you can ask users to confirm npw [10:26:38] * now [10:59:34] (03PS1) 10Hoo man: Fix the FormatSnakValueTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139808 [10:59:43] that'll fix travis [10:59:52] (03CR) 10jenkins-bot: [V: 04-1] Fix the FormatSnakValueTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139808 (owner: 10Hoo man) [11:00:29] hoo: thanks! :) [11:00:33] will do after lunch [11:01:01] Lydia_WMDE: Already did taht :) [11:01:11] (03PS2) 10Hoo man: Fix the FormatSnakValueTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139808 [11:04:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139808 (owner: 10Hoo man) [11:11:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139808 (owner: 10Hoo man) [11:25:28] DanielK_WMDE_: Want to have a look at https://gerrit.wikimedia.org/r/139808 ? [11:25:45] I have no idea why these tests are always English, but whatever [11:33:00] Thiemo_WMDE: Can https://bugzilla.wikimedia.org/show_bug.cgi?id=65340 be closed? [12:02:35] (03CR) 10Henning Snater: Accept array of HTML messages in tooltip JavaScript (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [12:08:19] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Because it's a subclass of ApiTestCase which is a subclass of MediaWikiLangTestCase. There are other ways to solve this, see I623c2924a207" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139808 (owner: 10Hoo man) [12:08:33] (03Merged) 10jenkins-bot: Fix the FormatSnakValueTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139808 (owner: 10Hoo man) [12:09:09] Ah, thanks Thiemo_WMDE :) [12:09:21] sure. :) [12:16:30] DanielK_WMDE_: This is awry https://test.wikidata.org/w/index.php?title=Q22&action=history (see the last few diffs) [12:17:57] the content stays exactly the same (according to rev_sha1) [12:18:29] [13ValueView] 15adrianlang created 06addressReview (+1 new commit): 02http://git.io/WgIscw [12:18:29] 13ValueView/06addressReview 14b98289e 15Adrian Lang: Add missing private property declaration [12:18:42] [13ValueView] 15adrianlang opened pull request #72: Add missing private property declaration (06master...06addressReview) 02http://git.io/nTXrYg [12:19:34] trivial patch is trivial [12:19:38] [13ValueView] 15mariushoch closed pull request #72: Add missing private property declaration (06master...06addressReview) 02http://git.io/nTXrYg [12:19:45] [13ValueView] 15mariushoch 04deleted 06addressReview at 14b98289e: 02http://git.io/dM2A2A [12:21:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4bb4190 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/27675347 [12:21:29] \o/ [12:37:55] [13ValueView] 15adrianlang 04force-pushed 06mono from 14f4c2ecc to 14379125d: 02http://git.io/toJpag [12:37:55] 13ValueView/06mono 149f5425c 15Adrian Lang: Add monolingualtext expert [12:37:55] 13ValueView/06mono 14379125d 15Adrian Lang: Make sure LanguageSelector's value never automatically changes [12:39:05] Tobi_WMDE: ^ [12:39:20] got it. ;) [12:44:02] Thiemo_WMDE: DanielK_WMDE_: (json dumps) So we want an extra option for snippets... shall that then add [] to the first/ last shard or not at all? [12:44:06] I don't really care about that [12:44:44] hoo: i'm not sure if i'm right. but my point of view is: ... [12:45:00] 1. default behavior is to always return valid json. as it is now. [12:45:27] 2. with the option it returns substrings that need to be concatenated to get a single valid json blob. [12:45:54] Ok [12:46:05] If Daniel is ok with that, I'll do it [12:46:23] I really want this in the next branch so that we can finally get this going [12:47:13] are there other meaningful ways to do this? [12:47:51] Thiemo_WMDE: We could make it return snippets for all shards [12:48:14] (=> no []) [12:48:17] oh, is see. 3. add no [] at all. this could be an option too. what about an option thats can be set to 3 different string values? [12:49:32] foo=arrays (default), foo=snippets, foo=??? (no brackets). [12:49:33] Also an option, yes [12:49:57] call it shardformat=... or so. [12:51:07] what about this? shardformat=arrays, shardformat=substrings, shardformat=fragments [12:52:16] hoo: thats my suggestion, you decide. [12:52:22] Thiemo_WMDE: I like that :) [12:52:25] (03PS1) 10Daniel Kinzler: Re-implement undo for redirects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139816 [12:52:45] (03CR) 10jenkins-bot: [V: 04-1] Re-implement undo for redirects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139816 (owner: 10Daniel Kinzler) [12:57:11] bah [12:59:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139816 (owner: 10Daniel Kinzler) [13:01:59] (03Abandoned) 10Addshore: New Wikidata Build - 14/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139585 (owner: 10WikidataBuilder) [13:02:01] (03Abandoned) 10Addshore: New Wikidata Build - 15/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139671 (owner: 10WikidataBuilder) [13:20:32] Thiemo_WMDE: How about commas? [13:20:47] Shall they be set in substring mode? [13:21:08] hoo: at the end of each shard? with the substring option yes, with the other options no. in my opinion. [13:21:14] ok :) [13:21:51] (03PS3) 10Thiemo Mättig (WMDE): Accept array of HTML messages in tooltip JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) [13:23:25] (03CR) 10Thiemo Mättig (WMDE): "I added tests for all cases in PS3, please have a look if this is ok for you." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [13:29:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [13:36:32] (03PS9) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [13:36:34] (03PS1) 10Adrian Lang: Introduce Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139825 [13:37:15] (03CR) 10jenkins-bot: [V: 04-1] Introduce Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139825 (owner: 10Adrian Lang) [13:37:22] (03CR) 10Adrian Lang: "Merged back I6e44ad84de2e31320309438b8aa09ec929d15e8e into this and rebased it on top of the namespace change. Will address more issues in" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [13:37:24] (03PS7) 10Hoo man: Allow different sharding-formats in dumpJson [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 [13:38:07] (03CR) 10Adrian Lang: "Sorry, merged back I2a2fb26d8a43b1a2847b083872bdc0ca32b6d151, not the other change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [13:38:32] (03Abandoned) 10Adrian Lang: Start refactoring SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138793 (owner: 10Adrian Lang) [13:39:46] (03PS2) 10Adrian Lang: Introduce Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139825 [13:39:48] (03PS10) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [13:40:13] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [13:43:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139825 (owner: 10Adrian Lang) [13:46:52] Reviiiieeeewwww [13:46:54] https://github.com/wmde/WikibaseInternalSerialization/pull/30 [13:46:57] https://github.com/wmde/WikibaseDataModelSerialization/pull/66 [13:57:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [13:59:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139825 (owner: 10Adrian Lang) [14:04:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [14:13:04] current bug id is 66662. Anyone want 66666?... [14:17:54] DanielK_WMDE_: 66666 is already there [14:18:05] Amir got it [14:25:52] (03PS36) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [14:26:09] (03CR) 10jenkins-bot: [V: 04-1] Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:28:24] (03PS2) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [14:28:40] (03CR) 10jenkins-bot: [V: 04-1] Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [14:28:54] devilish amir [14:29:14] hoo: in case you're interested :) https://gerrit.wikimedia.org/r/#/c/134400/ [14:31:24] Nemo_bis: Is Reedy to lazy to review? :D [14:31:34] I can have a look, but not now, am fiddeling with something :) [14:34:09] sure sure [14:34:34] I suspect it'll be a case of merging it and seeing what actually breaks [14:34:58] nobody trusts me *teardrop* [14:35:30] It's more just it being a non trivial commit [14:35:38] ;) [14:36:01] Question being whether we actually need to schedule it [14:36:22] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06diff from 14da3c58a to 1463cd1f9: 02http://git.io/a5znOQ [14:36:22] 13WikibaseDataModel/06diff 14be1c60c 15jeroendedauw: Move diff classes into their own NS [14:36:22] 13WikibaseDataModel/06diff 1443cd8ed 15jeroendedauw: Move diff code out of Entity and derivatives [14:36:22] 13WikibaseDataModel/06diff 147db5fe2 15jeroendedauw: Type hint against a more narrow interface [14:36:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:38:07] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06diff: 02http://git.io/HNpxXQ [14:38:07] 13WikibaseDataModel/06diff 1467eb3f7 15jeroendedauw: Add description to EntityDocument [14:41:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [14:43:59] o_O [14:45:10] gah. My patch for supporting redirects in EntityContent clashes with the introduction of Deserializers\Deserializer [14:46:03] major refactoring needed. *sigh* [14:48:19] [13WikibaseDataModelSerialization] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/CMTjoA [14:48:19] 13WikibaseDataModelSerialization/06master 148688c7a 15thiemowmde: Merge pull request #66 from wmde/UnDeserializableValue... [14:59:04] BAAAH! Wikidata keeps crashing my browser...EVERY TIME! [15:00:18] Who has messed with Wikidatas codes? Someone who hates me? [15:00:39] Josve05a: use http://tools.wmflabs.org/wikidata-todo/autolist.html instead? [15:01:20] what is that? [15:02:32] [13WikibaseInternalSerialization] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/17tl9g [15:02:32] 13WikibaseInternalSerialization/06master 14cdec9d1 15jeroendedauw: Add DeserializerFactory::newClaimDeserializer [15:02:32] 13WikibaseInternalSerialization/06master 1443ce681 15thiemowmde: Merge pull request #29 from wmde/cd... [15:03:13] notice: Wikidata can't be run on Mozilla Nightly [15:07:54] Josve05a: tell mozilla? :) [15:08:38] and http://tools.wmflabs.org/wikidata-todo/autolist.html is a lighter way to edit wikidata with a minimal interface [15:12:21] (03CR) 10Daniel Kinzler: [C: 04-1] "Needs to be reworked based on the new Deserializers package." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [15:21:41] though https://it.wikipedia.org/w/index.php?title=Aiuto:Sportello_informazioni&curid=3861142&diff=66499240&oldid=66497447 claims Wikidata is down [15:21:54] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/2LVreA [15:21:54] 13WikibaseDataModelSerialization/06master 14ee0816e 15jeroendedauw: Update readme [15:22:09] [13WikibaseDataModelSerialization] 15JeroenDeDauw tagged 061.0.1 at 06master: 02http://git.io/9qc9yg [15:23:30] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/wgf5CQ [15:23:30] 13WikibaseInternalSerialization/06master 14f139e54 15jeroendedauw: Update readme for 1.1 [15:24:20] [13WikibaseInternalSerialization] 15JeroenDeDauw tagged 061.1 at 06master: 02http://git.io/OAJKIA [15:33:35] (03CR) 10Jeroen De Dauw: [C: 032] Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [15:33:40] (03CR) 10Jeroen De Dauw: [C: 032] Introduce Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139825 (owner: 10Adrian Lang) [15:33:54] (03CR) 10Jeroen De Dauw: [V: 032] Introduce Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139825 (owner: 10Adrian Lang) [15:34:26] (03PS2) 10Jeroen De Dauw: WIP stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 [15:37:36] [13WikibaseInternalSerialization] 15thiemowmde created 06deserializers (+4 new commits): 02http://git.io/uu1ycA [15:37:36] 13WikibaseInternalSerialization/06deserializers 141a72244 15Thiemo Mättig: Reuse existing methods [15:37:36] 13WikibaseInternalSerialization/06deserializers 14c8dea81 15Thiemo Mättig: Try current first [15:37:36] 13WikibaseInternalSerialization/06deserializers 148b6c9f8 15Thiemo Mättig: Don't store serialization [15:38:01] JeroenDeDauw: is there a reason for all the new serializers to share an interface? this seems dangerous, they are not interchangable. [15:39:29] also, where does the fallback for the legacy format happen? [15:39:59] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #31: Refactor Claim and EntityDeserializer (06master...06deserializers) 02http://git.io/VgmtKw [15:41:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [15:41:44] [travis-ci] wmde/WikibaseDataModelSerialization/1.0.1/ee0816e : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/27691118 [15:59:29] [travis-ci] wmde/WikibaseInternalSerialization/1.1/f139e54 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/27691278 [16:02:25] (03PS1) 10Daniel Kinzler: Move serializ logic into EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 [16:03:11] (03CR) 10Daniel Kinzler: "Needs to be rebased on I285c6b496b27971198cf2b30aeccf19be28b8bd8" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [16:03:30] JeroenDeDauw: --^ [16:10:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [16:11:38] [travis-ci] wmde/WikibaseInternalSerialization/deserializers/fcec74d : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/27692347 [17:03:20] (03PS1) 10Hoo man: Fix SectionEditLinkGeneratorTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139866 [17:03:33] DanielK_WMDE_: Thiemo_WMDE: ^ [17:04:13] * hoo|away heads back to the TV [17:11:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139866 (owner: 10Hoo man) [17:37:55] (03CR) 10Jeroen De Dauw: Move serializ logic into EntityContentDataCodec (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [17:40:09] Thiemo_WMDE: https://www.youtube.com/watch?v=DlJEt2KU33I [17:43:32] [13ValueView] 15thiemowmde comment on pull request #59 14379125d: But it does use ULS, doesn't it? 02http://git.io/7NBHXQ [18:01:11] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix SectionEditLinkGeneratorTest for non-English wikis (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139866 (owner: 10Hoo man) [18:01:27] (03Merged) 10jenkins-bot: Fix SectionEditLinkGeneratorTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139866 (owner: 10Hoo man) [18:18:18] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5426218 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/27704458 [18:22:35] (03PS1) 10Jeroen De Dauw: Update InternalSerialization version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139878 [18:30:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139878 (owner: 10Jeroen De Dauw) [18:31:31] Thiemo_WMDE: one line change https://gerrit.wikimedia.org/r/#/c/139878/ [18:35:44] JeroenDeDauw: Any breaking changes in there or harmless? [18:38:57] looked that up on github, seems sane [18:39:18] (03CR) 10Hoo man: [C: 032] "Changes in 1.1 look sane to me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139878 (owner: 10Jeroen De Dauw) [18:39:37] (03Merged) 10jenkins-bot: Update InternalSerialization version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139878 (owner: 10Jeroen De Dauw) [19:30:32] (03PS1) 10Thiemo Mättig (WMDE): Allow [[Special:SetSiteLink//enwiki]] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139895 [19:38:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139895 (owner: 10Thiemo Mättig (WMDE)) [19:45:37] (03CR) 10Hoo man: Allow [[Special:SetSiteLink//enwiki]] (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139895 (owner: 10Thiemo Mättig (WMDE)) [19:48:42] (03PS1) 10Thiemo Mättig (WMDE): Cleanup TermBoxView a bit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139911 [19:53:57] (03PS1) 10Thiemo Mättig (WMDE): Drop getFormattedIdForEntity methods from tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139968 [19:59:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139911 (owner: 10Thiemo Mättig (WMDE)) [20:00:14] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#130 (master - 61bc833 : Translation updater bot): The build has errored. [20:00:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/55191b652bf1...61bc833eb0a5 [20:00:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/27712922 [20:01:58] hoo|away: 1.0 => 1.1 should not have breaking changes [20:02:11] hoo|away: also note how 1.1 was already in the version range (~1.0) [20:02:23] ~1.1 just makes sure you don't have 1.0 [20:02:26] JeroenDeDauw: Already merge ;) [20:02:30] * merged [20:03:36] (03PS1) 10Thiemo Mättig (WMDE): Cleanup EntityView, SectionEditLinkGenerator and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 [20:04:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139968 (owner: 10Thiemo Mättig (WMDE)) [20:04:44] Lydia_WMDE: redesign \o/ [20:04:50] :) [20:05:08] now dat colors are *ugly* [20:05:13] (personal opinion) [20:05:14] awwwww [20:05:15] :P [20:05:35] also [20:05:41] http://practicaltypography.com/ [20:05:45] that is a good read [20:05:50] quite longish [20:06:00] lazowik: add all of the comments [20:06:04] (to the page) [20:06:58] yup [20:07:04] :) [20:11:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [20:13:49] (03PS2) 10Thiemo Mättig (WMDE): Cleanup EntityView, SectionEditLinkGenerator and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 [20:14:03] (03CR) 10jenkins-bot: [V: 04-1] Cleanup EntityView, SectionEditLinkGenerator and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [20:16:35] (03PS3) 10Thiemo Mättig (WMDE): Cleanup EntityView, SectionEditLinkGenerator and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 [20:19:10] Lydia_WMDE: added :) [20:19:17] thanks :) [20:19:21] much aprechiated [20:20:33] * lazowik hides from designers [20:21:37] :D [20:22:06] really this is not the final design [20:22:13] * JeroenDeDauw imagines lazowik holding a carbord sign that states "visibility:none" [20:22:15] which is why i am publishing it now to get feedback [20:22:20] JeroenDeDauw: :D [20:22:23] lol JeroenDeDauw [20:22:45] seriously though. if you all say it is terrible we'll start over [20:22:49] but hopefully not :P [20:24:40] JeroenDeDauw: https://i.chzbgr.com/maxW500/754427648/h754A2B4A/ [20:25:25] (03CR) 10Thiemo Mättig (WMDE): "Oh, and before you ask: No, this class doesn't have any tests. Bene? Want to write some tests? ;-)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139895 (owner: 10Thiemo Mättig (WMDE)) [20:25:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [20:26:20] Lydia_WMDE: there is one thing that limits the possibilities: the content is surrounded by mediawiki [20:26:34] namely, vector [20:26:45] sure [20:28:01] In that regard the draft blends pretty well [20:28:48] Lydia_WMDE: that's a mockup, right? [20:28:53] yes [20:29:05] no code yet [20:29:18] some kind of special program? [20:29:30] or just any gimp or photoshop? [20:29:42] photoshop i believe [20:30:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [20:31:27] ah, I see reusing colours from the logo, that's great :) [20:32:06] yeah [20:35:41] Lydia_WMDE: that thing that I told you I have to do first involved reading http://practicaltypography.com/ [20:35:53] so I might pretend that I know something now :p [20:36:03] :D [20:55:34] Lydia_WMDE: what's the action on these arrows next to edit icons? [20:56:49] lazowik: we were thinking about things like flagging [20:57:00] also setting ranks possibly [20:57:30] well, they look like they do something important :p [20:57:39] *nod* [20:57:56] we'll have to make detailed mockups for that and other areas once we have the big picture figured out [20:59:43] Lydia_WMDE: would you be mad if I *tried* doing some mockups? [20:59:55] hehe [20:59:59] no i would not [21:00:02] nothing to promise