[00:07:30] hello [00:07:39] https://meta.wikimedia.org/wiki/Special:CentralAuth/wikidata look [00:08:12] neat [00:08:27] we have to lock it? [00:08:46] idk [00:08:51] https://meta.wikimedia.org/wiki/User:WikiPedia [00:11:09] ajr look this one [00:11:09] https://meta.wikimedia.org/wiki/Special:CentralAuth/Wikivoyage [00:11:37] that's an lta though [00:12:02] we have to block wikidata in jawiki? [00:12:09] user:wikidata [00:14:08] https://ja.wikipedia.org/w/index.php?title=%E3%83%99%E3%83%AB%E3%82%BB%E3%83%AB%E3%82%AF_(%E6%BC%AB%E7%94%BB)&diff=prev&oldid=21836488 oh. one edit lol [00:17:20] !ca 홍길동 [02:16:00] My largest reference https://www.wikidata.org/w/index.php?title=Q4645579&diff=138828318&oldid=138827839 [10:00:36] (03PS1) 10WikidataBuilder: New Wikidata Build - 19/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140680 [10:11:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140680 (owner: 10WikidataBuilder) [11:30:28] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Still the regex as well as the wording of the documentation. Sorry." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [12:39:16] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "At least a test name is wrong now. Also I wanted to propose entityRedirectUpdated. Not sure if it's really better." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [12:47:36] hi :) [12:47:50] Hoi [13:45:13] (03PS1) 10Daniel Kinzler: Introducing EntityChangeFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 [13:45:35] How do I add peoples birthdays if it is like c. 1967 1? Should I use 1967+/-10 or something? [13:50:49] Josve05a: yes... 1967, with precision "decade" would probably be the right thing [13:51:29] The UI doesn't currently support 1967+/- 5 years, though the data model actually supports this. [13:52:10] ok. thank! [13:52:15] thanks* [13:52:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (owner: 10Daniel Kinzler) [13:59:51] DanielK_WMDE_ But if someone died around year 480, I don't want it to say 480s, bc he could have died 479...what should I then use? [14:00:45] Lydia_WMDE: aude: Shall I https://gerrit.wikimedia.org/r/140344 put for this evening? [14:00:59] (03PS2) 10Daniel Kinzler: Introducing EntityChangeFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 [14:02:11] hoo: sure [14:02:41] I would also like https://gerrit.wikimedia.org/r/139367 [14:03:13] * aude too but.... [14:03:13] DanielK_WMDE_: https://gerrit.wikimedia.org/r/139367 Can't you two just decide on something? I'll implement whatever you want, but I need to know what [14:03:19] DanielK_WMDE_: !!! [14:07:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (owner: 10Daniel Kinzler) [14:13:25] lolwat at this blog https://blog.inf.ed.ac.uk/sapm/ [14:13:56] off for food [14:14:36] Lydia_WMDE: Force Daniel and Thiemo to make a decision on the json stuff... or promise them cookies or whatever :D [14:15:25] hi, I get an error "evilsSeed isn't defined" thrown from wikibase.RepoApiError when clicking add link [14:15:42] hoo|away: hehe ok [14:15:48] eranroz: where exactly? [14:16:00] on hewiki, https://he.wikipedia.org/wiki/%D7%A2%D7%93%D7%99%D7%AA_%D7%A7%D7%99%D7%93%D7%A8 [14:16:24] (or you may prefer https://he.wikipedia.org/wiki/%D7%A2%D7%93%D7%99%D7%AA_%D7%A7%D7%99%D7%93%D7%A8?uselang=de :) ) [14:16:37] hoo|away: ^ [14:16:48] hoo|away: i get the error that i am not logged in on the central data repository [14:16:50] but i am [14:20:29] How do I add a date that is +/-1 year? I can only set it to "decade", which is "more" than I want to.... [14:21:42] http://ultimategerardm.blogspot.nl/2014/06/wikidata-bug-busted.html Please Lydia_WMDE make automated descriptions available to all of us [14:24:17] Amen. [14:26:07] +1 [14:27:02] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Introducing EntityChangeFactory. (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (owner: 10Daniel Kinzler) [14:28:24] i understand it's useful but there is no chance we can do this atm. simply too many other things [14:28:25] sorry [14:28:25] Huuh?! https://www.wikidata.org/w/index.php?title=Q16650331&diff=prev&oldid=138904189 [14:28:49] Yeah Josve05a, that happens sometimes. [14:30:08] reported to bitbucket https://bitbucket.org/magnusmanske/wikidata-game/issue/130/doiung-one-edit-removed-another [14:30:23] (03CR) 10Daniel Kinzler: [C: 032] Drop pointless null check and type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140154 (owner: 10Thiemo Mättig (WMDE)) [14:53:06] (03PS3) 10Daniel Kinzler: Introducing EntityChangeFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) [14:55:44] (03PS1) 10Daniel Kinzler: Replace ChangeNotifier with ChangeNotificationChannel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) [14:56:53] Lydia_WMDE: all that is needed for now is add one line in common.js [14:57:11] and when you have the bandwidth you can integrate it in the software itself [14:57:31] as you know Ori Levni looked at the code [14:57:38] it should behave [15:04:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) (owner: 10Daniel Kinzler) [15:08:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [15:14:46] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I'm aware this is a work in progress. Just a few quick comments to get started. Looks good overall. Good work." (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [15:16:22] Hi, Doesn anyone in here knows about badges API? [15:16:31] or a place that we can test it? [15:19:56] (03PS1) 10Aude: Force EditFilterMergedHook to be registered in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140722 (https://bugzilla.wikimedia.org/65727) [15:20:15] no idea [15:27:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140722 (https://bugzilla.wikimedia.org/65727) (owner: 10Aude) [15:30:03] wtf [15:30:27] (03CR) 10Aude: [C: 04-1] "this should fail, because master is broken" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140722 (https://bugzilla.wikimedia.org/65727) (owner: 10Aude) [15:31:11] Lydia_WMDE: No luck? [15:31:52] linkItem works for me on hewiki [15:40:51] DanielK_WMDE_: Thiemo_WMDE: Please come to a decision on https://gerrit.wikimedia.org/r/139367 [15:42:00] aude: How do you know master is broken if the tests pass? [15:42:17] fail for me and seems to depend on order tests run [15:42:25] inadequately covered code [15:43:02] yikes [15:43:20] easy fix but i want to make sure we have the code covered / tests run [15:43:31] yeah [15:46:57] Is there a script/gadget that can automaticly import things from templates on wikipedia to statements on wikidata? [15:47:08] (...that works) [15:50:24] (03PS1) 10Jeroen De Dauw: Remove unused var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140725 [15:53:26] (03CR) 10Hoo man: [C: 032] Remove unused var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140725 (owner: 10Jeroen De Dauw) [15:53:38] (03Merged) 10jenkins-bot: Remove unused var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140725 (owner: 10Jeroen De Dauw) [15:55:19] (03PS1) 10Jeroen De Dauw: Update Item reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140727 [16:01:16] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140725 (owner: 10Jeroen De Dauw) [16:05:10] For historical persons, is the citizenship linking to the state that existed during his lifetime (e.g. Prussia) or the legal successor of today (e.g. Germany)? [16:05:40] JeLuF: Historical state, I'd say [16:05:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140727 (owner: 10Jeroen De Dauw) [16:07:47] It is the historical state. [16:08:30] * aude rage [16:08:41] sorting out the bugs [16:08:48] (03CR) 10Hoo man: [C: 032] Update Item reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140727 (owner: 10Jeroen De Dauw) [16:09:01] aude: JavaScript ones? [16:09:02] (03Merged) 10jenkins-bot: Update Item reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140727 (owner: 10Jeroen De Dauw) [16:09:05] nope [16:09:10] EditEntity [16:09:39] it actually needs a RequestContext but sometimes is given something else (IContextSource) [16:09:57] easy to fix but i want to know the extent of the problems [16:10:55] or DerivativeContext is also ok, seems [16:12:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ec62272 : jeroendedauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/27967424 [16:13:46] ouh, waht [16:14:11] oh crap [16:14:15] segfaults again [16:14:19] :( [16:14:44] there's no common interface for RequestContext and DerivativeContext :( [16:15:20] MediaWiki... -.- [16:16:32] * aude see red [16:18:01] ok better [16:24:07] travis still segfaults [16:24:09] what the fuck [16:24:22] think it's unrelated to the thing i'm looking at [16:24:51] aude: Shall I revert https://gerrit.wikimedia.org/r/140725 ? [16:24:59] Although I don't think that's the real cause [16:25:57] maybe [16:26:25] (03PS1) 10Hoo man: Revert "Remove unused var" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140730 [16:26:53] (03CR) 10Hoo man: [C: 032 V: 032] "As this seems to make travis segfault. If it still segfaults, feel free to re-revert" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140730 (owner: 10Hoo man) [16:27:17] watch it segfault again... [16:27:22] * aude wouldn't be suprised [16:27:41] If that doesn't help, I'll probably have to fiddle up gdb again on travis which isn't nice [16:28:16] --debug usually helps [16:28:51] yeah, if it's just a fatal or so that can help [16:32:53] hoo: wtf segfault? ;p [16:33:27] Something relies on some side effect nof calling getOutput ? [16:33:49] might be [16:33:57] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140730 (owner: 10Hoo man) [16:33:58] let's see what travis makes out of it [16:35:59] (03PS1) 10Aude: Give EditEntity a valid context (RequestContext) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140733 [16:36:01] (03PS1) 10Aude: Context given to EditEntity must be RequestContext or DerivativeContext [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140734 [16:36:34] (03PS2) 10Aude: Give EditEntity a valid context (RequestContext) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140733 (https://bugzilla.wikimedia.org/66842) [16:36:44] (03PS2) 10Aude: Context given to EditEntity must be RequestContext or DerivativeContext [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140734 [16:37:53] * aude off [16:44:06] (03PS1) 10Daniel Kinzler: Move notification logic into ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) [16:48:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140733 (https://bugzilla.wikimedia.org/66842) (owner: 10Aude) [16:49:42] (03PS1) 10Hoo man: Make entityselector tests actually test user input [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140738 [16:49:44] (03PS1) 10Hoo man: Don't automatically select entity's on alias match in suggester [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140739 (https://bugzilla.wikimedia.org/66748) [16:56:53] (03CR) 10Hoo man: [C: 032] Make entityselector tests actually test user input [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140738 (owner: 10Hoo man) [16:56:58] (03CR) 10Hoo man: [C: 032] Don't automatically select entity's on alias match in suggester [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140739 (https://bugzilla.wikimedia.org/66748) (owner: 10Hoo man) [16:57:15] (03Merged) 10jenkins-bot: Make entityselector tests actually test user input [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140738 (owner: 10Hoo man) [16:57:17] (03Merged) 10jenkins-bot: Don't automatically select entity's on alias match in suggester [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140739 (https://bugzilla.wikimedia.org/66748) (owner: 10Hoo man) [16:58:30] (03PS1) 10Hoo man: Revert "Revert "Remove unused var"" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140740 [16:58:45] (03CR) 10Hoo man: [C: 032] "Reverting didn't help :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140740 (owner: 10Hoo man) [16:58:58] (03Merged) 10jenkins-bot: Revert "Revert "Remove unused var"" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140740 (owner: 10Hoo man) [17:01:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140734 (owner: 10Aude) [17:04:16] if I wbsetclaim a quantity with value amount:+0.044405586 , is it expected that the result is "success":1 with amount:+0.04440558599999999689345031583798117935657501220703125 [17:09:54] (03PS1) 10Hoo man: Update Wikibase to fix the entity selector [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140742 [17:14:41] [travis-ci] wmde/WikibaseQueryEngine/drop-value/ade0deb : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/27973545 [17:14:42] (03CR) 10Hoo man: [C: 032] Update Wikibase to fix the entity selector [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140742 (owner: 10Hoo man) [17:15:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140733 (https://bugzilla.wikimedia.org/66842) (owner: 10Aude) [17:17:51] (03Merged) 10jenkins-bot: Update Wikibase to fix the entity selector [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140742 (owner: 10Hoo man) [17:23:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf8/2ec7dc4 : Adrian Lang The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/27973805 [17:24:52] [travis-ci] mariushoch/mediawiki-extensions-Wikibase/master/16b2230 : Marius Hoch The build failed. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/27974292 [17:25:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140734 (owner: 10Aude) [17:29:43] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140742 (owner: 10Hoo man) [17:31:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [17:35:36] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140738 (owner: 10Hoo man) [17:36:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e806eed : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/27973912 [17:40:21] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140739 (https://bugzilla.wikimedia.org/66748) (owner: 10Hoo man) [17:45:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140740 (owner: 10Hoo man) [17:47:22] [travis-ci] mariushoch/mediawiki-extensions-Wikibase/master/98b9335 : Marius Hoch The build was fixed. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/27976352 [17:52:16] oO [17:52:26] o_O [18:22:34] [09:14:44 AM] there's no common interface for RequestContext and DerivativeContext :( <-- IContextSource? [18:23:32] [09:09:40 AM] it actually needs a RequestContext but sometimes is given something else (IContextSource) <-- why would it specifically need a RequestContext versus say a ContextSource? [18:25:03] thepwnco: hi [18:25:40] benestar: hello. How goes? [18:25:54] thepwnco: did you see my changes to the page? [18:26:09] it looks a bit ugly now but this is the way the script expects the html... [18:26:24] for now we can leave it that way imo [18:26:36] nothing on the Wikidata:Tours page [18:26:44] on the Items & Statements pages? [18:27:27] yes, the Items page [18:28:31] oh I see now [18:29:26] you mean ugly because of the repeated sections? [18:29:49] [travis-ci] mariushoch/mediawiki-extensions-Wikibase/master/bb1e05b : Marius Hoch The build was broken. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/27979525 [18:31:04] thepwnco: yep, but I think we can live with them :) [18:31:11] it looks ok to me.. :) besides, no one will really being looking at that page [18:31:33] shall I do the same for the Statements tour then? [18:31:53] thepwnco: yes, would be great [18:32:03] by the way, you say in the Items page "Action - go to the Earth item page on testwikidata" [18:32:28] yes? [18:32:36] does this mean that the tour starts on Wikidata:Tours and not at the item's page itself? [18:33:19] Yay! [18:34:02] you're right. For some reason I thought it was different on the current tour we have up on the site [18:34:12] but I see that it goes straight to the Paris page [18:34:31] yes, let me move that so it goes to Earth right away [18:38:40] thepwnco: ok, thanks [18:39:01] where do you want to place these instructions in future? [18:39:10] because at the moment they appear in the actual tour, too :/ [18:43:10] well initially I thought as these pages as just for the drafts [18:44:23] and I could put the final version (without instructions) as a sub-page immediately under Wikidata:Tours (like your Wikidata basics one) instead of as a sub-page of Project Plan [18:44:33] thepwnco: they aren't ;) https://www.wikidata.org/w/index.php?title=Q16943273&tour=wbitems [18:45:06] what works best for you? [18:45:10] but no problem, we can put another version as the final one at Wikidata:Tours/Items [18:45:14] I could put the instructions on the talk page? [18:45:41] thepwnco: the instructions are stored in the MediaWiki page anyway, but you may add them as HTML comments [18:46:14] * hoo eyes aude [18:46:20] around? [18:46:30] we might also give them a CSS class and hide them for the tour but that sounds a bit unnecessary [18:46:55] yep [18:47:12] so HTML comments are the way to go now? [18:47:23] (03PS1) 10Hoo man: Improve and extend the WikibaseLuaEntityBindingsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140766 [18:47:29] oh I see that they are stored in the MediaWiki but for initially communicating them to you [18:48:05] I also thought of adding some HTML tags like
[18:48:25] this way we could even get rid of putting any content into javascript pages [18:48:42] but this is rather something for a version 2.0 [18:49:30] Lydia_WMDE: "Jungle King" xD [18:49:37] benestar: ;-) [18:49:44] ok, I could also put them on the talk page like for here http://www.wikidata.org/wiki/MediaWiki:Guidedtour-tour-wbitems.js ? [18:49:52] benestar: discoveranjali's text :D [18:50:16] benestar: btw making progress on the visit. hope to have a final answer tomorrow [18:50:23] Lydia_WMDE: \o/ [18:50:28] \o/ indeed [18:50:30] Lydia_WMDE: FYI: Deploy went fine, verified it (you can tell the users, if there's an open thread). Right now I'm fixing the unit tests :P [18:50:41] hoo: excellent [18:50:47] hoo: lol, deploy first, then unit tests xD [18:50:53] thepwnco: I think it might be easier if the information was directly in the sections... [18:51:00] benestar: No, totally unrelated test failures... want to review? [18:51:15] hoo: if you want me to review ;) [18:51:21] is it lua? [18:51:31] * benestar does not like lua that much :/ [18:51:47] No, it's the PHP side of the Lua integration [18:51:56] benestar: https://gerrit.wikimedia.org/r/140766 [18:52:07] JeroenDeDauw: https://gerrit.wikimedia.org/r/140766 want to merge? That would fix travis... [18:53:07] benestar: ok, I can't seem to edit that page though (besides the talk page) [18:53:31] thepwnco: yes, MediaWiki pages are only editable by administrators... [18:54:01] that's the reason why I want to put as many content as possible into the Wikidata:Tours subpages [18:55:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140766 (owner: 10Hoo man) [18:59:50] benestar: ok, I am a bit confused. We are only talking about indicating what/when actions should happen? And getting that content out of the subpages, right? [19:00:21] thepwnco: did you try https://www.wikidata.org/w/index.php?title=Q16943273&tour=wbitems ? [19:00:58] I am playing with it now [19:01:04] looks good - but I see the problem [19:01:09] there the Action notices etc. are visible, so I'd suggest to put them into html comments ie [19:02:40] ok, so you don't need me to format/add overlays for the js? [19:03:06] thepwnco: hmm, I don't understand? [19:04:16] benestar: oops. sorry :/ I get it anyhow, so you can just ignore that last comment [19:04:42] I was wondering if you wanted me to actually prepare comments for use in http://www.wikidata.org/wiki/MediaWiki:Guidedtour-tour-wbitems.js [19:04:58] but I can just do html comments too [19:05:11] thepwnco: yes, that was my intention ;) [19:06:02] thepwnco: do you know javascript a bit? [19:07:33] a bit, yes [19:09:49] thepwnco: so you understand how overlays and attachements are created? [19:10:15] :O 505 [19:10:30] 503 [19:10:38] Josve05a: thx [19:10:55] (no difference....) [19:11:06] ;) [19:11:35] well I've also looked a bit on the GuidedTour extension page and info on building tours [19:11:48] I just tried to "save"....no I have to redo my entire edit...(I edited on my user page) [19:12:17] Josve05a: just press F5 [19:12:22] CSS selectors, etc.. [19:12:25] when the webpages is there again [19:12:27] still 503 [19:12:39] I know...but it will not remember the edit [19:12:47] Josve05a: it will... [19:13:06] doesn't it ask you if you wanna send the data again? [19:13:23] yes... [19:13:37] butI think I have cleared something (cookies/cashe....) [19:13:45] :/ [19:14:00] just leave the tab open [19:14:06] and try it again when the site is available again [19:14:17] it is actually [19:14:30] How long will it take...still 503 [19:14:34] * it was [19:16:00] I have 503 on https://wikidata.org/wiki/Wikidata:Tours [19:16:03] MediaWiki internal error. Exception caught inside exception handler. Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information. [19:16:05] jep [19:16:15] sode-wide issues on all wikimedia sites [19:16:20] ops is working on it [19:16:36] *side [19:17:01] it'll take a few minutes aparently [19:18:56] thepwnco: on the Statements tour [19:19:07] do you really want the user to switch from Earth to Neptune and back? [19:19:28] besides some technical difficulties this might also become a bit confusing [19:22:49] Yay! [19:27:13] benestar I was able to make the edit! https://www.wikidata.org/wiki/User:Josve05a#Stuff_I_want [19:27:36] ;) [19:34:12] benestar: if that's the case, then I think it's ok to get rid of [19:34:20] Let me update that page quickly [19:34:33] (I've changed the actions to comments for Items) [19:37:17] nevermind...apparently my changes didn't take [19:37:56] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140802 (owner: 10L10n-bot) [19:38:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e65ce48 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/27985253 [19:46:36] benestar: I think all is ok now [19:55:28] benestar: switching from Eath to Neptune will be trivial once we release Wikidata Wormholes 1.0 [19:56:00] JeroenDeDauw: yay :D [19:56:10] is there already a development plan? ^^ [19:56:34] benestar: yeah, but it's secret. Don't tell Lydia_WMDE or she'll get upset [20:00:36] thepwnco: hmm, Neptune still apperas in the tour? [20:00:41] or did I miss something? [20:01:06] also can you give me an example how the page should look like when the user starts the tour? [20:01:26] ie. which data should already be there [20:01:28] the word Neptune does but it does not need to go to the Neptune page [20:02:13] ok, so this is only a quiz without editing, I understand [20:02:16] I'll add to the page as html [20:04:52] (03CR) 10Jeroen De Dauw: [C: 031] "Looks good design wise" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) (owner: 10Daniel Kinzler) [20:09:31] benestar: ok, they are in there [20:09:41] some properties/items needed to be added to testwikidata still [20:09:54] which I can do [20:10:13] (03CR) 10Jeroen De Dauw: [C: 04-1] "Good direction in general" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [20:20:34] benestar: those are now added - there does seem to be a second "part of" property in testwikidata [20:20:45] and i can't figure out how to suppress it [20:44:03] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=66842 [20:44:24] how do you do $context->setTitle() on ContextSource? [20:44:38] ah. [20:44:57] so I'm the one who broke it :/ [20:46:08] well, jenkins does not test that code, etc [20:46:46] otherwise seems good change to me [21:34:33] thepwnco: not really ready, but see https://www.wikidata.org/wiki/Q16943273?tour=wbstatements [21:34:44] I am away now [21:34:46] cu [21:36:45] thepwnco: just wanne tell you that you are editing logged out [21:37:03] *wanna+ [21:43:35] *would like to [21:48:28] JeroenDeDauw: Y u no merge https://gerrit.wikimedia.org/r/140766 ? [22:09:01] (03CR) 10Hoo man: "Note: This will fix travis" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140766 (owner: 10Hoo man) [22:36:39] addshore: https://gerrit.wikimedia.org/r/140766 You'd fix travis with that! [22:38:23] why no mock hoo ? :< [22:38:37] addshore: No need to mock a value object :P [22:40:07] (03CR) 10Addshore: [C: 032] Improve and extend the WikibaseLuaEntityBindingsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140766 (owner: 10Hoo man) [22:40:13] if I wbsetclaim a quantity with value amount:+0.044405586 , is it expected that the result is "success":1 with amount:+0.04440558599999999689345031583798117935657501220703125 see https://bugzilla.wikimedia.org/show_bug.cgi?id=66580