[07:04:52] (03CR) 10Ori.livneh: "Ah, I see. Makes sense. Thanks for taking care of it!" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/141268 (owner: 10Ori.livneh) [07:05:04] (03Abandoned) 10Ori.livneh: Use !empty() to check wmf config vars, in case they are undefined [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/141268 (owner: 10Ori.livneh) [07:16:21] DanielK_WMDE: awake? [07:28:33] aude: Thiemo_WMDE DanielK_WMDE : hallo [07:28:38] have you heard reports about Wikidata brokenness on client RTL wikipedia? [07:28:52] for example, trying adding a link to https://he.wikipedia.org/wiki/%D7%91%D7%95%D7%9E%D7%91%D7%94_%D7%A6%D7%95%D7%A8 [07:28:55] uhoh. [07:29:28] click the "add link" element, [07:29:31] i dont see a problem. [07:29:40] the dialog opens [07:29:48] write "en" in the language field [07:29:57] check whether the auto-complete dropdown appears [07:30:11] monobook? [07:30:14] vector [07:30:42] works for me. can you try to force-reload the page? clear the browser cache first? [07:30:59] we know the bug and already fixed it. [07:39:34] Thiemo_WMDE: force-reloaded, purged, still happens [07:40:04] this is really odd. as said, works here. which browser? [07:40:10] if you are familiar with it and fixed it in master, did you deploy it on any test wiki? [07:40:12] Firefox [07:40:26] its backported to all wikis. [07:41:58] could you try the following in firefox: press ctrl+shift+i. click "console". type "localStorage.clear()" (without quotes) and hit enter. clear cache. shift+reload. [07:43:59] Thiemo_WMDE: did it, still can reproduce the bug [08:25:21] aharoni: :( [08:25:27] i get Uncaught TypeError: undefined is not a function [08:25:45] if( /right/i.match( orientation ) ) { [08:28:30] [13ValueView] 15adrianlang pushed 1 new commit to 06mono: 02http://git.io/YT4UbQ [08:28:30] 13ValueView/06mono 1410adbb2 15Adrian Lang: Make ULS dependency in LanguageSelector optional [08:29:56] do we have anything in bugzilla for this? [08:41:31] [13ValueView] 15filbertkm created 06rtl (+1 new commit): 02http://git.io/cze2zQ [08:41:31] 13ValueView/06rtl 14bb41572 15aude: Fix rtl flipping in jquery.ui.suggester.js [08:42:00] Adrian_WMDE: Henning_WMDE https://github.com/wmde/ValueView/pull/75 [08:42:01] [13ValueView] 15filbertkm opened pull request #75: Fix rtl flipping in jquery.ui.suggester.js (06master...06rtl) 02http://git.io/LgAPeA [08:42:23] changing this seem to do the trick [08:43:12] aude: That seems about right [08:43:18] RegExp objects have exec [08:43:31] and test [08:43:49] test would be even better, I think [08:44:26] /right/i.test( orientation ) [08:45:16] test instead of match? [08:45:25] * aude trying [08:46:03] that works [08:47:27] [13ValueView] 15filbertkm 04force-pushed 06rtl from 14bb41572 to 14056e9df: 02http://git.io/pcq3dg [08:47:27] 13ValueView/06rtl 14056e9df 15aude: Fix rtl flipping in jquery.ui.suggester.js [08:48:32] Adrian_WMDE: btw, https://bugzilla.wikimedia.org/show_bug.cgi?id=67067 seems another issue [08:49:31] [travis-ci] wmde/WikibaseQueryEngine/index-limit/d6a84e2 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/28388206 [08:49:42] aude: yep [08:50:00] i don't get the second bug, since i get the js error [08:50:03] maybe it goes away [09:23:55] [13ValueView] 15adrianlang pushed 1 new commit to 06mono: 02http://git.io/1kkpTg [09:23:55] 13ValueView/06mono 1431a1952 15Adrian Lang: Add README entry, bump version [09:27:15] [13ValueView] 15thiemowmde 04deleted 06mono at 1431a1952: 02http://git.io/ESPrvQ [09:27:18] (03PS1) 10Adrian Lang: Move FetchedContentUnserializer from wb.serialization to wb.store [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141910 [09:30:00] [13ValueView] 15thiemowmde 04deleted 06rtl at 14056e9df: 02http://git.io/Gu0rag [09:34:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141910 (owner: 10Adrian Lang) [09:34:40] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/0yVDSw [09:34:40] 13ValueView/06master 147acf020 15thiemowmde: Update README.md [09:36:12] aude: so could you reproduce it? [09:37:17] yes [09:37:30] suppowe se can deploy this later [09:37:40] gah suppose we [09:41:17] aharoni: you are talking about the js console error? [09:44:35] aude: the rtl error with adding links [09:45:06] try adding an interlanguage link to https://he.wikipedia.org/wiki/%D7%91%D7%95%D7%9E%D7%91%D7%94_%D7%A6%D7%95%D7%A8 [09:45:15] yeah, just fixed that [09:45:35] this is something we should backport obviously [09:46:23] aude: How do we backport ValueView changes? [09:47:02] DanielK_WMDE__: not joining the daily i assume? [09:47:17] aude: you neither because of badnwidth? [09:47:31] * aude is not rainproof ;) [09:47:35] lol [09:47:36] ok [09:47:37] i sent a mail [09:47:46] cool [09:48:10] Adrian_WMDE: normally make another tag but think it's not possible here [09:48:20] we did something alternative and i need to look [09:48:25] * aude could just patch the build [09:48:35] or make a branch [09:48:44] branch is probably best [09:52:35] [13ValueView] 15filbertkm created 06mw1.24-wmf8 (+1 new commit): 02http://git.io/GDGAOg [09:52:35] 13ValueView/06mw1.24-wmf8 14471b0c9 15aude: Fix rtl flipping in jquery.ui.suggester.js [09:52:42] aude: who will take care of backport / swat / whatever it is called? [09:52:59] it's bothering quite a lot of people (not just myself, that is :) ) [09:53:02] i can (or hoo) [09:53:05] agree [09:54:23] aude: a similar bug happens at the repo, too [09:54:35] when adding a new sitelink and searching for a language [09:54:40] does it fix that as well? [09:54:51] likely [09:54:55] try adding a sitelink at https://www.wikidata.org/wiki/Q42?uselang=he [09:55:18] ok, it looks similar, I'm just checking ;) [09:55:33] if you can test it on your test installation, it would be nice [09:55:35] almost 100% sure it's using the same code [09:55:40] i can verify [09:55:46] yes, that would be nice. thanks. [09:57:14] and I really don't like repeating myself and ordering people around, but it would be very nice if somebody would make sure that it's added to the next swat deploy [09:57:27] I'd do it, but you are probably much more familiar with the relevant patches [09:58:05] doing :) [09:58:33] * aude would deploy now, out of swat, but greg might not like that [10:00:32] (03PS1) 10WikidataBuilder: New Wikidata Build - 25/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/141915 [10:05:42] (03PS1) 10Aude: Update composer.json to use value view branch [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141916 [10:07:09] =o [10:07:40] * aude waves [10:10:42] it's an addshore! [10:10:49] oh hia Lydia_WMDE [10:13:08] aharoni: confirm this will also fix wikidata [10:13:34] aude: ack, thank you [10:14:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141916 (owner: 10Aude) [10:14:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/141915 (owner: 10WikidataBuilder) [10:15:09] (03CR) 10Aude: [C: 032] Update composer.json to use value view branch [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141916 (owner: 10Aude) [10:15:27] (03Merged) 10jenkins-bot: Update composer.json to use value view branch [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141916 (owner: 10Aude) [10:23:50] hey [10:24:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf8/a4c8861 : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/28394521 [10:26:00] [13ValueView] 15thiemowmde 04force-pushed 06class-class from 14686a37b to 14056b980: 02http://git.io/ylsatA [10:26:00] 13ValueView/06class-class 146153b7e 15Thiemo Mättig: Revert class name back to "valueview" [10:26:00] 13ValueView/06class-class 14056b980 15Thiemo Mättig: Suggested solution [10:26:38] [13ValueView] 15thiemowmde 04force-pushed 06class-class from 14056b980 to 141e7e692: 02http://git.io/ylsatA [10:26:38] 13ValueView/06class-class 141e7e692 15Thiemo Mättig: Revert class name back to "valueview" [10:28:24] hey lazowik :) [10:28:36] Thiemo_WMDE: what is the bug for https://github.com/wmde/ValueView/pull/74 ? [10:28:44] nevermind [10:29:10] for the gadgets [10:29:35] Lydia_WMDE: Thiemo_WMDE does it help to also backport that one? or are the hacks to the gadgets enough [10:29:50] aude: the hacks work [10:29:53] ok [10:29:55] no need to backport. the gadgets work for now. [10:30:45] [13ValueView] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/jH6b9g [10:30:45] 13ValueView/06master 141982db3 15Adrian Lang: Merge pull request #74 from wmde/class-class... [10:32:33] hmmm... one thing about gerrit that i miss on github is to put a commit hash in the search box [10:33:26] [13ValueView] 15thiemowmde tagged 060.6.3 at 06master: 02http://git.io/zDkA3g [10:33:56] (03PS1) 10Christopher Johnson (WMDE): changes names of deprecated hooks SpecialRecentChangesFilters and SpecialRecentChangesQuery to ChangesListSpecialPageFilters and ChangesListSpecialPageFilters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141921 [10:34:59] (03PS2) 10Christopher Johnson (WMDE): changes names of deprecated hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141921 [10:35:23] (03CR) 10Adrian Lang: "Thiemo explained some of the concepts introduced here and in the following patches to me; I find it quite strange to use an event/notifica" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [10:36:25] (03PS1) 10Adrian Lang: Bump ValueView dependency for monolingualtext expert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141922 [10:37:24] (03CR) 10Adrian Lang: "Might fail for some time because packagist is dead-slow." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141922 (owner: 10Adrian Lang) [10:40:54] aude: this is probably the bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=67067 [10:41:04] can you please link the relevant commits there? [10:44:20] aharoni: done [10:44:24] [13ValueView] 15thiemowmde created 06precision-order (+1 new commit): 02http://git.io/GiKd2g [10:44:24] 13ValueView/06precision-order 14d6b4599 15Thiemo Mättig: Reorder GlobeCoordinate precisions... [10:45:00] aude: thanks [10:45:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141921 (owner: 10Christopher Johnson (WMDE)) [10:47:30] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06one-degree from 14d84e3a7 to 14b19fab6: 02http://git.io/qDcK8A [10:47:30] 13DataValuesJavascript/06one-degree 14b19fab6 15Thiemo Mättig: Display 1 degree as number, not text [10:48:09] [travis-ci] wmde/DataValuesJavascript/one-degree/b19fab6 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/DataValuesJavascript/builds/28396251 [10:51:00] (03PS1) 10Aude: Fix rtl issue in jquery.ui.suggester.js [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) [10:53:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141921 (owner: 10Christopher Johnson (WMDE)) [10:53:39] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06one-degree from 14b19fab6 to 14f70e434: 02http://git.io/qDcK8A [10:53:39] 13DataValuesJavascript/06one-degree 14f70e434 15Thiemo Mättig: Display 1 degree as number, not text [10:55:21] (03PS2) 10Aude: Fix rtl issue in jquery.ui.suggester.js [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) [11:01:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141922 (owner: 10Adrian Lang) [11:02:18] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Are you sure? I can't find a documentation for the two new hooks. The documentations at https://www.mediawiki.org/wiki/Manual:Hooks/Specia" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141921 (owner: 10Christopher Johnson (WMDE)) [11:04:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) (owner: 10Aude) [11:12:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) (owner: 10Aude) [11:12:42] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Bump ValueView dependency for monolingualtext expert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141922 (owner: 10Adrian Lang) [11:13:06] (03Merged) 10jenkins-bot: Bump ValueView dependency for monolingualtext expert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141922 (owner: 10Adrian Lang) [11:17:44] (03CR) 10Daniel Kinzler: "@Adrian: this saves a change *notification*, which *is* an event. The database is used as a communication queue to the client wikis." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [11:17:48] aude: is dev-mw1.24-wmf8 a branch you made for backporting? [11:18:36] aude: so https://gerrit.wikimedia.org/r/#/c/141925/ doesn't need any additional review, right? [11:19:20] (03CR) 10Daniel Kinzler: "...in other words, the "Channel" is the SaveStrategy (which may not actually save, but send via UDP, or ignore, or whatever). And the "Not" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [11:19:25] DanielK_WMDE__: online? [11:21:44] (03PS3) 10Aude: Fix rtl issue in jquery.ui.suggester.js [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) [11:22:18] Thiemo_WMDE: if trivial, i can merge but prefer someone else (e.g. hoo) look [11:22:37] i've made a change https://gerrit.wikimedia.org/r/#/c/141925/3/composer.json [11:22:52] to help avoid deployment issues (rsync) we occasionally hve [11:22:59] aude: i wonder about some details. why is there dev stuff? [11:23:01] have* [11:23:21] Thiemo_WMDE: to get value view [11:24:11] lolol wat ... [11:24:12] https://gerrit.wikimedia.org/r/#/c/132906/ [11:24:17] Siebrand merged that :D [11:24:21] Thiemo_WMDE: aude ^ [11:24:54] hah :) [11:26:41] (03CR) 10Adrian Lang: "Hmm, ok. So the stuff in lib/includes/changes is about client notifications, exclusively? I think changes and notifications should then be" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [11:31:15] (03PS1) 10Adrian Lang: Remove duplicate dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141932 [11:31:17] (03PS1) 10Adrian Lang: Remove unused function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141933 [11:34:14] aude: yea, these changes in composer.json made me wonder. [11:34:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) (owner: 10Aude) [11:35:47] i'd like a better process for these backports, but don't know what that would be [11:36:25] we could make a new tag, somewhere between 0.6.2. and 0.6.3 but not sure it's the right thing to do [11:36:50] aude: i think i understand whats going on in your patch but i'm not sure. looks ok for me. [11:37:14] i want hoo to see the suffix thing [11:37:23] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks good to me but I don't feel competent enough. :-(" [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) (owner: 10Aude) [11:37:25] * addshore waves [11:37:47] aude: new tag between 0.6.2 and 0.6.3 ? Is this for a bug fix? [11:37:49] it solves a problem we've had [11:37:53] addshore: yes [11:37:57] aude: we have an other problem that needs to be backported to wikidata.org: https://gerrit.wikimedia.org/r/#/c/139400/ [11:38:01] I would just make a 0.6.2.1 then [11:38:12] addshore: hmmm, yeyah would work [11:38:39] make a branch from 0.6.2 , cherry pick the fixes, change the version number and release it :) [11:39:11] ok [11:39:17] let's do that [11:39:27] hi addshore! btw. ;) [11:39:35] It should then automatically get pulled in by composer once packagist and everything updates :) [11:39:37] oh hia Thiemo_WMDE ! [11:41:03] addshore: we miss you! [11:41:07] [13ValueView] 15filbertkm tagged 060.6.2.1 at 06mw1.24-wmf8: 02http://git.io/_dxRwQ [11:42:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141932 (owner: 10Adrian Lang) [11:44:11] Tag between 0.6.2 and 0.6.3?! [11:44:53] JeroenDeDauw: we need to packport a bit of 0.6.3. how to do that? [11:45:26] oh, to late i guess. [11:45:30] (03PS1) 10Aude: Use "data-values/value-view": "~0.6.2" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141934 [11:46:04] dev-mw1.24-wmf8 should also have worked [11:46:21] it does work [11:46:32] just requires minimum stability dev [11:46:44] aude: please have a look at https://gerrit.wikimedia.org/r/#/c/139400/ if your done with that. [11:46:58] https://gerrit.wikimedia.org/r/#/c/139400/ is already merged [11:47:24] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase.git/refs%2Fheads%2Fmw1.24-wmf8 [11:47:35] aude: the issue persists on the live site [11:47:43] Thiemo_WMDE: ^ [11:47:52] but? [11:47:58] bug? [11:48:29] https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Drop-down_properties [11:48:46] on wikidata? [11:48:49] yeah [11:48:53] that patch is client only [11:49:01] ah! [11:49:08] this is repo indeed [11:49:14] Thiemo_WMDE: ^ [11:49:15] probably the same css is needed [11:49:25] someone want to make apatch? [11:49:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141933 (owner: 10Adrian Lang) [11:50:31] aude: we're going for lunch now. will look into it after lunch [11:50:37] (03CR) 10Aude: "what we've done now in the build works. if we want this way, we can do it" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141934 (owner: 10Aude) [11:50:44] ok [11:51:58] aude: just cherrypick the client patch and do the same on wikidata.org. [11:52:14] its a hack that will go away but it solves the problem for now. [11:52:43] Thiemo_WMDE: the client thing is already deployed [11:52:46] an other idea is to edit MediaWiki:Commons.css on wikidata.org. [11:53:11] i know. same patch is needed on wikidata.org. [11:53:27] is this fiexed in master? [11:54:00] its in valueview. [11:54:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141934 (owner: 10Aude) [11:54:09] * Thiemo_WMDE needs food now [11:54:27] ok [11:54:51] * aude can't edit common.css [12:01:10] =o [12:01:21] aude: wikidata's common.css? what you want? :) [12:01:28] * addshore lets ebraminio do it ;p [12:02:18] (03PS1) 10Aude: Fix site selector css for both repo [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141939 [12:02:23] ah, ok [12:02:32] would be quicker :) [12:03:13] addshore: oh if you can also, I won't interfere ever :P [12:03:20] https://gerrit.wikimedia.org/r/#/c/141939/1/lib/resources/wikibase.css [12:03:36] just that added bit aude ? [12:03:38] yes [12:04:38] doing [12:04:44] thanks [12:04:51] is there anything I should add in the comment aude? [12:05:05] that it can be removed in ~a month [12:05:08] (less probably) [12:05:10] okay [12:05:11] temporary hack [12:05:42] (03Abandoned) 10Aude: Fix site selector css for both repo [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141939 (owner: 10Aude) [12:08:33] {{done}} [12:09:01] https://www.wikidata.org/w/index.php?title=MediaWiki:Common.css&diff=140266830&oldid=136909341 [12:09:12] aude: would you please fix a bug on suggestion also for me? similar to https://gerrit.wikimedia.org/r/#/c/23674/ but on wikibase, filing bug is not an option :) [12:10:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141939 (owner: 10Aude) [12:10:34] ebraminio: probably something Adrian_WMDE or henning has to do [12:11:30] to have the site link suggestions actually be links? [12:15:27] aude: The problem is described here https://bugzilla.wikimedia.org/show_bug.cgi?id=21167#c0 [12:17:30] an should be wrapped around every suggestion item and then something like https://gerrit.wikimedia.org/r/#/c/23674/33/resources/jquery/jquery.suggestions.js #540 // do not interfere with non-left clicks or [12:17:30] if modifier keys are pressed (e.g. ctrl-click) [12:18:19] ah, ok [12:18:26] sounds familiar [12:18:38] might already be a bug [12:19:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=66431 ? [12:20:27] Yes, as far as I know [12:21:04] we'll have to ask Lydia_WMDE and thiemo when they come back from lunch [12:21:20] aude: Thank you [13:10:49] (03PS1) 10Adrian Lang: Inject wikibase.dataTypes into wikibase.serialization.EntityUnserializer.propertyExpert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141955 [13:11:56] Adrian_WMDE: howto commit chain... [13:12:26] (03CR) 10Jeroen De Dauw: [C: 032] Move FetchedContentUnserializer from wb.serialization to wb.store [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141910 (owner: 10Adrian Lang) [13:12:41] (03CR) 10Jeroen De Dauw: [C: 032] Remove duplicate dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141932 (owner: 10Adrian Lang) [13:12:56] (03CR) 10Jeroen De Dauw: [C: 032] Remove unused function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141933 (owner: 10Adrian Lang) [13:13:31] JeroenDeDauw: I just wanted to start rebasing them [13:16:13] (03PS2) 10Jeroen De Dauw: Inject wikibase.dataTypes into wikibase.serialization.EntityUnserializer.propertyExpert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141955 (owner: 10Adrian Lang) [13:20:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141955 (owner: 10Adrian Lang) [13:24:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141955 (owner: 10Adrian Lang) [13:29:57] Thiemo_WMDE: you where asking for this now :D https://github.com/wmde/WikibaseDataModel/pull/111#issuecomment-47031364 [13:30:14] aude: just a ping :) [13:30:17] Is anyone revieweing https://gerrit.wikimedia.org/r/#/c/132606/ and https://gerrit.wikimedia.org/r/#/c/132613/ ? would be good to get that moving [13:31:15] >_> [13:31:36] (03PS10) 10Jeroen De Dauw: Provides a default to otherProjectsLinks configuration parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [13:31:51] (03CR) 10jenkins-bot: [V: 04-1] Provides a default to otherProjectsLinks configuration parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [13:32:06] aude: anything for the call with Nik from your side? [13:32:47] (03CR) 10Adrian Lang: [C: 04-2] "I will try another approach first." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141955 (owner: 10Adrian Lang) [13:34:17] (03CR) 10Jeroen De Dauw: Provides a default to otherProjectsLinks configuration parameter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [13:34:47] (03PS11) 10Jeroen De Dauw: Adds a beta feature for "Other project" sidebar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [13:36:04] (03CR) 10Jeroen De Dauw: [C: 04-1] "The new static code in the hooks file is not tested" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [13:36:16] Lydia_WMDE: reviewed [13:36:27] JeroenDeDauw: \o/ [13:36:28] thanks! [13:38:15] JeroenDeDauw: lol @ other review [13:39:30] Lydia_WMDE: that is what my meme folder is for right [13:39:38] obviously [13:40:13] JeroenDeDauw: i actually think you should be social and share that folder with all of us :P [13:40:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [13:44:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [13:45:47] Lydia_WMDE: https://cloud.githubusercontent.com/assets/146040/3385900/fb9f89a8-fc6e-11e3-8cbf-88166843d763.jpg [13:45:49] Lydia_WMDE: no [13:46:04] I'm totally not abusing GitHub now as image hosting service [13:46:28] (03CR) 10Christopher Johnson (WMDE): "The MW site docs are outdated. See docs/hooks.txt and SpecialRecentChanges line 234 (since 1.23)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141921 (owner: 10Christopher Johnson (WMDE)) [13:46:34] JeroenDeDauw: i no right? [13:46:37] aude: k [13:50:21] (03CR) 10Tpt: "Answer" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [13:51:50] is swat the same time as the call w/ nik? [13:51:50] Lydia_WMDE: Thanks for your email. I don't see how to solve the issue pointed for change https://gerrit.wikimedia.org/r/#/c/132606/11 [13:51:58] e.g. he's doing 2 things same tiem? [13:52:11] and no hoo? [13:56:55] JeroenDeDauw: see Tpt_'s comment above please [14:01:55] Lydia_WMDE: in case you missed, we have request to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=66431 [14:02:07] if someone has the time [14:02:27] aude: k thx [14:31:41] [13DataValuesJavascript] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/LwOW-w [14:31:41] 13DataValuesJavascript/06master 1469fa688 15Christopher Johnson (WMDE): add url and description for Special:Version [14:37:29] hoo: https://gerrit.wikimedia.org/r/#/c/141925/ [14:37:35] if you are not busy [14:38:23] looking [14:39:14] thanks [14:39:28] think we have a solution for the autoloader class name thing [14:39:31] aude: did you update composer? [14:39:47] yes, only valueview and wikibase [14:40:04] "autoloader-suffix": "wikidata_mw1_24_wmf8" [14:40:11] that needs to change length everytime we update [14:40:19] yes [14:40:29] not perfect but we can control that [14:40:45] Yeah, that's better than before at least [14:40:57] what i thought [14:41:24] (03CR) 10Hoo man: [C: 032] Fix rtl issue in jquery.ui.suggester.js [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) (owner: 10Aude) [14:41:29] thanks [14:44:29] (03Merged) 10jenkins-bot: Fix rtl issue in jquery.ui.suggester.js [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141925 (https://bugzilla.wikimedia.org/67067) (owner: 10Aude) [14:45:33] updating submodules [14:45:50] when do you plan to deploy? Soonish? [14:46:04] wat [14:46:06] swat [14:46:09] so 15 min [14:46:19] ok :) [14:46:23] we'll do test.wikidata / test2 then everything else [14:46:27] (03CR) 10Jeroen De Dauw: Implement redirects in ItemContent (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:48:37] https://bugzilla.wikimedia.org/show_bug.cgi?id=67067 <- can be closed as resolved? [14:49:14] ideally after deploy [14:49:23] k [14:49:29] although i'm 100% sure this fixes everything [14:49:34] 99.99% [14:51:49] Lydia_WMDE: ... I can just fix it for him I guess [14:52:17] aude: Any idea who else could review https://gerrit.wikimedia.org/r/138352 ? [14:52:40] hoo: not really [14:53:12] i really don't understand translation aids and how to enable them, and not sure who does [14:53:20] Lydia_WMDE: bug report at WD:PC :p [14:55:21] JeroenDeDauw: will check after call [14:55:22] thx [15:03:21] [13ValueView] 15JeroenDeDauw 04deleted 06precision-order at 14d6b4599: 02http://git.io/vT5Lgg [15:22:40] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "Turns out I'm right. The change is fine for the "filter" hook but not for the "query" hook." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141921 (owner: 10Christopher Johnson (WMDE)) [15:38:22] aharoni: fixed [15:38:31] aude: testing [15:39:05] aude: client looks good, testing repo [15:39:18] yay [15:39:34] repo looks good, too [15:39:38] thank you very much, aude [15:40:18] Thiemo_WMDE1: back now. spend most of the day at the DNB [15:40:18] thanks for poking us :) [15:42:13] (03CR) 10Daniel Kinzler: "@adrian: the only notifications we have are called "changes"." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [15:42:54] aude: did something break? [15:44:59] DanielK_WMDE__: javascript for rtl [15:53:04] hmpf [15:57:16] (03CR) 10Jeroen De Dauw: Implement redirects in ItemContent (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [15:57:38] DanielK_WMDE__: did you make the serialization format change yet? [15:57:43] with the simple wrapper? [15:58:24] JeroenDeDauw: no, got caught up in the discussion with thiemo about the ChangeNotifier [15:58:35] which btw has a -1 by you... not sure why [15:58:35] DanielK_WMDE__: ok, then I will do this [16:16:07] DanielK_WMDE__: around? wish you could have been here today. [16:17:24] Thiemo_WMDE: here now. will come in tomorrow, though i'm not sure yet whzen or for how long [16:17:59] Thiemo_WMDE: anythign special today? [16:18:12] unblocking you. it starts hurting. [16:18:19] :P [16:18:22] indeed [16:18:34] there are a few minor things i should fix before this gets merged though [16:19:39] let me look [16:28:59] (03PS4) 10Daniel Kinzler: Replace ChangeNotifier with ChangeNotificationChannel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) [16:29:21] (03CR) 10Jeroen De Dauw: Move notification logic into ChangeNotifier (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [16:31:39] (03CR) 10Jeroen De Dauw: [C: 04-1] Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [16:36:41] Thiemo_WMDE: failing at the rebase game. will try to do the folloow-ups tomorrow. [16:36:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [16:37:00] if you are ok to merge the first patch of the chain now, that would be greast :) [16:37:09] DanielK_WMDE__: as i said, don't change to much. i'm sure its easier to do this at the end of the patch chain. [16:37:25] fixed some whitespace and changed the names [16:37:30] didn't touch anything else [16:37:31] if i can make you understand what i mean. [16:37:45] need to go now. will try to merge later. [16:38:01] ok. dinner time. see you tomorrow [16:39:55] DanielK_WMDE__: don't go [16:40:27] have quick review coming [16:40:44] although thiemo or someone else can review [16:41:17] (03PS1) 10Aude: Fix getLatestRevisionId return value in WikiPageEntityLookup [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141997 [16:44:16] (03PS1) 10Aude: Fix getLatestRevisionId return value in WikiPageEntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141999 [16:48:01] aude: Want to have that merged soonish? [16:49:24] yes [16:49:34] omg, can't believe that one [16:49:35] ok, waiting for the jenkins then [16:49:49] we'll do swat again [16:49:56] Wanted to head for Thai food, but can wait a few more minutes [16:50:21] * aude hungry but it's raining again [16:50:45] oO [16:50:56] It hasn't rained for several weeks over here [16:51:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/141997 (owner: 10Aude) [16:55:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141999 (owner: 10Aude) [16:55:44]