[06:41:41] (03CR) 10Henning Snater: Removed generic event handling from entitysearch widget (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142510 (owner: 10Henning Snater) [06:52:57] (03PS4) 10Henning Snater: Apply widgetEventPrefix to snak type selector event listener [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142217 [07:01:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142217 (owner: 10Henning Snater) [07:37:38] (03CR) 10Daniel Kinzler: Make EntityHandlerTest setting independent (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142875 (owner: 10Hoo man) [07:39:58] (03CR) 10Daniel Kinzler: "@Thiemo: this change should not change the behavior for non-redirects; it should just define the behavior for redirects, which was undefin" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [07:40:42] (03PS11) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [07:49:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [08:23:18] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/dNDWYQ [08:23:18] 13WikibaseDataModelSerialization/06master 14c5afdc8 15jeroendedauw: Decrease visibility scope [08:51:40] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/XDNHqQ [08:51:40] 13WikibaseDataModelSerialization/06master 14f893085 15jeroendedauw: Improve naming [09:22:51] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06ne (+1 new commit): 02http://git.io/VI4Nvg [09:22:51] 13WikibaseDataModelSerialization/06ne 147f3b7ee 15jeroendedauw: Do not ommit labels, descriptions, aliases and sitelinks keys when empty arrays [09:23:11] [13WikibaseDataModelSerialization] 15JeroenDeDauw opened pull request #69: Do not ommit labels, descriptions, aliases and sitelinks keys when empty arrays (06master...06ne) 02http://git.io/3ORwSA [09:24:07] [travis-ci] wmde/WikibaseDataModelSerialization/ne/7f3b7ee : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/28761380 [09:24:08] (03PS1) 10Thiemo Mättig (WMDE): Rename "Data item" on client to "{{WBREPONAME}} item" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142993 [09:27:21] [13WikibaseDataModelSerialization] 15Tpt pushed 1 new commit to 06master: 02http://git.io/Uy1SLw [09:27:21] 13WikibaseDataModelSerialization/06master 14da6e104 15Thomas PT: Merge pull request #69 from wmde/ne... [09:31:11] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06ne at 147f3b7ee: 02http://git.io/fubmQQ [09:33:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142993 (owner: 10Thiemo Mättig (WMDE)) [09:46:20] (03CR) 10Aude: Make EntityHandlerTest setting independent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142875 (owner: 10Hoo man) [09:46:34] DanielK_WMDE_: joining for the daily? [10:00:46] (03PS1) 10WikidataBuilder: New Wikidata Build - 30/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/142996 [10:08:28] (03CR) 10Aude: Make EntityHandlerTest setting independent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142875 (owner: 10Hoo man) [10:11:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/142996 (owner: 10WikidataBuilder) [10:12:05] bah [10:12:28] DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/142996/ ! [10:12:50] (03Abandoned) 10Aude: New Wikidata Build - 30/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/142996 (owner: 10WikidataBuilder) [10:15:17] (03CR) 10Addshore: [C: 032] Fix error message in SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142953 (owner: 10Aude) [10:15:35] (03PS1) 10Thiemo Mättig (WMDE): Update some poor English messages in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 [10:19:29] (03CR) 10Aude: [C: 04-1] "mostly looks ok but small grammar nitpick" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (owner: 10Thiemo Mättig (WMDE)) [10:20:07] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=65847 [10:21:06] hey [10:22:06] hey lazowik [10:24:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (owner: 10Thiemo Mättig (WMDE)) [10:26:56] JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=66791 <- you said this can be closed? [10:27:51] Lydia_WMDE: https://github.com/wmde/WikibaseDataModelSerialization/pull/69 [10:28:20] are we using that version of serialiation in wikibase? [10:28:34] probably need a tag [10:29:07] aude: not needed yet [10:29:49] Lydia_WMDE: I'm not sure I fixed the full bug. Need to double check the existing format [10:29:57] cool [10:30:47] JeroenDeDauw: when is it needed [10:32:12] aude: when we ditch the old version of the API format serialization code and use this one [10:32:25] The change we have so far is just about the internal format [10:32:28] Which will now use this [10:32:35] Though for that the bug is not relevant [10:34:05] hmmmm, ok [10:39:33] (03PS12) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [10:40:18] Thiemo_WMDE, JeroenDeDauw: ---^ [10:40:30] will look into failures on master next [10:42:31] aude: when the new format is in the database, it is never recoded. never. no matter what the settings are. because the baypass check is hardcoded. [10:43:07] i'll poke at the test, need some food first [10:43:19] settings are odd then [10:43:30] yes they are [10:43:52] both are basically hacks. you can create an inconsistent setup using them. [10:44:22] if you have legacy serializer class and try to transform format on export, then think there should be an exception [10:44:23] bah. maybe i'll just merge hoo's patch. no big issues. [10:44:28] not proceed with magic [10:44:49] (03CR) 10Jeroen De Dauw: Check for redirect before calling getEntity(). (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [10:45:12] aude: difficult to find the right spot where we can know about both settings and the internal magic. i'll look. [10:45:16] the patch "fixes" the test but does not go far enough to reduce confusion about magic settings [10:45:46] at minimum, the test should be clear [10:48:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [10:50:07] aude: do you want a fix for the test, or a refactoring that makes more sense? [10:50:43] i see no way to write a sensible test for strange behavior. it would be good to fix the actual problem, but that's not easy... [11:00:35] ok, think think i have an idea now. patch in an hour or so. [11:50:56] aude: testExportTransform_dependingOnSettingsEitherNeverRecodeNonLegacyFormatOrSurpriseTheUser :D [11:52:40] :O [11:53:58] And I considered GlobalRenameUserCentralAuthDatabaseUpdates as to long for a class name :D [11:59:24] hoo: :) [12:00:04] DanielK_WMDE_: fix the test (meaning the name and what's expected depending with what settings) [12:00:19] or remove the setting, imho [12:00:32] I can fix the test, but I need to know what exactly it should test [12:00:53] given x and y settings, what format is expected? [12:01:02] never is never in this case [12:01:03] the whole functionality seems a little broken... maybe the export thing should just us the most up to date serializer and not care about settings? [12:01:16] which would justify the never [12:01:17] perhaps [12:01:30] errr, should use whatever the serializer class is [12:01:39] no need for yet another setting [12:12:03] Thiemo_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=45363 <- i think this can be closed with your latest changes? [12:13:37] Lydia_WMDE: There are issues with the page move propagation again :/ *sigh* [12:13:45] hoo: ohnoes :( [12:13:47] oh noes [12:13:50] hah [12:13:57] hoo: what's broken? [12:15:04] Lydia_WMDE: Some renames don't make it to Wikidata, although the jobs are being executed just fine [12:15:19] and we don't know why? [12:15:24] No idea, no [12:15:33] hmmmm [12:15:33] logs look totally fine [12:15:36] suck [12:15:50] what is "some"? [12:15:55] example? [12:15:57] anything else we can do to debug? [12:16:26] aude: https://www.wikidata.org/w/index.php?title=Q374172&action=history [12:16:51] the last change should have been done by a job (and the job ran minutes before that change) [12:16:58] (03PS2) 10Thiemo Mättig (WMDE): Update some poor English messages in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) [12:16:59] ok [12:17:26] Lydia_WMDE: I guess I can just try to test it myself or carefully re-read the code (which worked last time) [12:17:37] Kind of like self code review :P [12:17:39] main namespae [12:17:42] namespace* [12:18:00] Lydia_WMDE: do you know any articles or slides about collaboration between libraries and Wikidata or use of Wikidata by libraries? [12:18:15] (03PS3) 10Thiemo Mättig (WMDE): Update some poor English messages in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) [12:18:17] whym: notconfusing might have something [12:18:20] max [12:18:23] (03CR) 10Thiemo Mättig (WMDE): Update some poor English messages in Repo (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [12:18:25] yeah [12:18:49] hoo: hmm ok. let me know if there is anything you need help with [12:18:50] aude: right, I found some articles about his VIAFbot [12:19:02] Yeah :/ [12:19:08] whym: i am not aware of anything else right now [12:19:50] Lydia_WMDE: ok, thanks [12:20:55] I'm going to have a casual talk with someone from NDL (national library of Japan). [12:21:20] they are interested in linking their author pages to Wikipedia more intelligently. [12:21:43] and I thought using Wikidata is a straightforward solution. [12:22:43] maybe DanielK_WMDE_ has slides htough they might be in german [12:23:09] and lydia would probably be aware of them [12:24:19] (03PS1) 10Daniel Kinzler: Make tests for export transform independent of settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 [12:25:18] (03CR) 10Daniel Kinzler: "I have made a patch that addresses the issue in a more thorough way, see I33d7b352b7d4f. I suggest using that instead." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142875 (owner: 10Hoo man) [12:25:51] (03Abandoned) 10Hoo man: Make EntityHandlerTest setting independent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142875 (owner: 10Hoo man) [12:28:52] omg [12:30:35] (03CR) 10Aude: [C: 04-1] "test failures and warnings" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 (owner: 10Daniel Kinzler) [12:30:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [12:33:30] uh :/ [12:34:14] (03CR) 10Aude: [C: 04-1] "still slightly confusing to me" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [12:36:39] (03CR) 10Aude: "i'll take a look again at the javascript." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142523 (https://bugzilla.wikimedia.org/67244) (owner: 10Aude) [12:37:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [12:38:43] (03PS2) 10Hoo man: Rename "Data item" on client to "{{WBREPONAME}} item" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142993 (owner: 10Thiemo Mättig (WMDE)) [12:40:22] (03PS1) 10Daniel Kinzler: Skip redirect tests as long as redirect arn't supported [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 [12:41:34] (03CR) 10Daniel Kinzler: "@aude: perhaps the setup *is* inconsistent?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 (owner: 10Daniel Kinzler) [12:41:42] aude: ---^ [12:41:46] can't think of anything else. [12:41:51] no [12:42:03] why does the test depend onsettings? [12:42:39] aude: because construcitng a EntityHandler depends on settings. [12:42:46] and we construct EntityHandlers all the time [12:42:54] wtf [12:42:56] the tests that actually deal with serialization now force the settings [12:43:11] * hoo rages [12:43:12] but we can't force these in *all* tests just in case the local setup is screwed [12:43:20] my setup is *not* screwed [12:43:26] * aude raaaaaaaaaaages! [12:43:35] then i'm confused. i tried all combinations locally, and they all pass [12:43:36] Is adding sitelinks broken on master for anyone else? [12:43:45] hoo: it is [12:43:45] (JS UI) [12:43:50] https://gerrit.wikimedia.org/r/#/c/142523/ [12:43:53] ahh crap [12:43:56] aude: what are your settings for internalEntitySerializerClass and transformLegacyFormatOnExport ? [12:44:04] no setting for transform [12:44:08] legacy for serailizer [12:44:19] aude: that's inconsistent. transform is on per default. [12:44:23] gah [12:44:25] bad [12:44:31] look at the diff for options.wiki [12:44:34] i mention that there [12:44:41] bad [12:44:44] it's what you requested, actually [12:44:54] throw an exception in the case we can't handle nicely [12:44:58] these settings are so confusing [12:45:05] yes. they are B/C hacks [12:45:19] fiddeled in after the fact. not nicely designed.- [12:45:26] if we don't need them for Wikidata, we should kill them [12:45:39] hoo: we doo need them for migration. [12:45:42] then the tests are dependant on settings [12:45:46] not independent [12:45:53] kill them! [12:46:00] the test depend on a valid setup [12:46:12] we now detect an invalid setup early, and scream [12:46:14] the default transform setting should be false if i have the legacy thing set [12:46:29] i should not have to think about export [12:46:30] (03CR) 10Hoo man: [C: 032] "Works fine locally" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142993 (owner: 10Thiemo Mättig (WMDE)) [12:46:36] that could be done. but means more magic. [12:46:43] kill the setting then [12:46:46] magic defaults. we have a few of thjose. very tempting. [12:46:47] (03Merged) 10jenkins-bot: Rename "Data item" on client to "{{WBREPONAME}} item" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142993 (owner: 10Thiemo Mättig (WMDE)) [12:46:55] i can't image wanting to not transform when we have new serializers [12:46:59] imagin* [12:47:01] e* [12:47:02] aude: we introduced the settings because you said we need them for migration [12:47:19] we need the serializer setting [12:47:25] aude: "so we can turn that off if something goes wrong" ? [12:47:43] why do we need the export setting? [12:48:05] so we can control if and when dumps are converted on the fly. [12:48:15] why? [12:48:28] in case that breaks dumps? [12:48:28] when would we want that? [12:48:41] DanielK_WMDE_: aude I am wondering why this internalEntitySerializerClass takes a class name. That is very weird, and seems to force us to add another setting just for the claim deserializer also needed [12:48:41] want what? convert them? [12:49:05] to not transform? [12:49:20] aude: In Case That Breaks Too Much Stuff (tm) [12:49:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "See bug 67294 for the second issue I described." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142217 (owner: 10Henning Snater) [12:49:49] frankly, I don't care. Rip it out. [12:50:05] (03Merged) 10jenkins-bot: Apply widgetEventPrefix to snak type selector event listener [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142217 (owner: 10Henning Snater) [12:50:11] i think we'd temporarily halt the dumps if it's that bad [12:50:11] the flag was introduced before the serializer class thing. maybe we don't need it any more. [12:50:19] i really hope the code isn't that broken [12:50:19] *shrug* [12:50:27] uh huh [12:50:54] too much complexity imho [12:50:56] JeroenDeDauw: the deserializer should generally be able to deal with all possible input formats, so pürobably not. [12:51:06] JeroenDeDauw: the idea was to not hard-code the legacy class. [12:51:11] again, I don't care much. [12:51:55] DanielK_WMDE_: internalEntitySerializerClass serializer, not deserializer [12:52:08] As far as I can tell, all we needed was a boolean flag [12:52:20] The current thing is probelamtic in not one but two ways [12:53:17] aude, JeroenDeDauw: add a patch that rips out the transform flag. or fuse both settings into a single flag. [12:53:33] happy to do [12:53:50] Can we still do this? Or is WMF already putting the class name in their config? [12:54:02] JeroenDeDauw: can still do [12:54:39] JeroenDeDauw: the idea is that names like "legacy", "old", "new", etc, become confusing fast. We'll end up with legacy1, legacy2, etc. [12:54:53] would be nice if these were versioned [12:54:57] So my idea was to just have a setting to override the default class. [12:55:08] *shrug* [12:55:23] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142993 (owner: 10Thiemo Mättig (WMDE)) [12:55:44] anyway, i'll be afk for about an hour when my daughter comes home in a few minutes. [12:55:50] ok [12:56:59] aude: changing the default of transformLegacyFormatOnExport depend on whether internalEntitySerializerClass should be very simple. [12:57:07] ok [12:57:11] that would work for me [12:57:13] a few lines in wikibase.default.php [12:57:17] yeah [12:57:58] can add this to the current patch, i think that's still sane [12:58:14] ok [13:00:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 (owner: 10Daniel Kinzler) [13:02:04] (03PS2) 10Daniel Kinzler: Make tests for export transform independent of settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 [13:02:05] aude: --^ [13:03:01] aude: would also be nice if we had a list of legacy features, instead of a single legacy flag. [13:03:26] currently, it's unclear to me how to find all places that need to be changed to make redirects non-experimental. I *hope* it's just the one, but... [13:03:38] also unclear to me [13:03:51] err, i meant an "experimental" flag. [13:03:56] yep [13:04:07] yea... need a good convention, at least. if ( EXPERIMENTAL ) // redirects [13:04:15] somethign like that [13:04:17] *sigh* [13:04:38] feature flags would be better. [13:05:17] define( 'WB_ENABLE_REDIRECTS', defined( 'WB_EXPERIMENTAL' ) ) [13:05:24] that would do nicely. [13:05:57] easy to switch all, easy to find the right spots [13:11:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 (owner: 10Daniel Kinzler) [13:11:44] (03CR) 10Aude: "$( '.wb-editsection' ).not( 'td > .wb-editsection, td.wb-editsection' ); appears to work though we still need to fix the styling." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142523 (https://bugzilla.wikimedia.org/67244) (owner: 10Aude) [13:14:07] (03PS4) 10Thiemo Mättig (WMDE): Update some poor English messages in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) [13:14:49] (03CR) 10Thiemo Mättig (WMDE): "I once learned as a rule of thumb that you usually don't use any commas in English. ;-)" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [13:16:15] (03CR) 10Aude: [C: 032] "looks good :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [13:16:35] (03Merged) 10jenkins-bot: Update some poor English messages in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [13:17:40] (03PS1) 10Aude: Fix site links 'add' links button in javascript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143022 (https://bugzilla.wikimedia.org/67244) [13:18:38] (03CR) 10Aude: [C: 04-1] "appears to have problematic effects on non-purged pages" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143022 (https://bugzilla.wikimedia.org/67244) (owner: 10Aude) [13:26:25] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142997 (https://bugzilla.wikimedia.org/45363) (owner: 10Thiemo Mättig (WMDE)) [13:31:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143022 (https://bugzilla.wikimedia.org/67244) (owner: 10Aude) [13:40:07] (03CR) 10Aude: "with this patch, site links look like http://snag.gy/mrP9x.jpg (even when purged)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143022 (https://bugzilla.wikimedia.org/67244) (owner: 10Aude) [13:42:52] (03CR) 10Aude: "I would prefer the partial revert and then do a proper fix for this specific issue without such deadline as when we make deployment branch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143022 (https://bugzilla.wikimedia.org/67244) (owner: 10Aude) [14:12:52] (03CR) 10Aude: [C: 04-1] "appears to fix the issue with EntityHandler." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 (owner: 10Daniel Kinzler) [14:25:08] (03CR) 10Daniel Kinzler: "yea, will need to go through all tests that now deal with redirects. Damn, I was so proud I added test cases for that - and forget that I " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 (owner: 10Daniel Kinzler) [14:25:47] seems my links are gone on my client [14:25:59] DanielK_WMDE_: ^ [14:26:24] and change notificaiton jobs seem to be executed [14:28:19] seem not* [14:30:50] aude: on master? or with my patch? does this correlate with the serializer change, or redirects? [14:30:57] on master [14:31:09] seems not to matter if i'm using experimental mode or not [14:31:35] i'm willin gto look into this [14:33:58] they are in the job table [14:38:47] (03CR) 10Jeroen De Dauw: [C: 031] Make tests for export transform independent of settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 (owner: 10Daniel Kinzler) [14:48:30] aude: who/what is? [14:48:34] DanielK_WMDE_: problem solved :) [14:49:08] had temporarily disable wikibase to debug a core bug [14:49:13] :p [14:53:32] hehe [14:53:43] aude: i'm fixing the remaining test cases, patch in a few [14:53:47] i'll amend the existing change [14:53:57] happy to close bug as invalid :) [14:53:58] actualyl found a nasty bug in the process :/ [14:54:10] dispatching seems to work ok [14:54:16] despite the test failure [15:03:11] (03PS2) 10Daniel Kinzler: Skip redirect tests as long as redirect arn't supported [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 [15:03:19] aude: --^ [15:04:29] ok [15:12:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 (owner: 10Daniel Kinzler) [15:12:52] JeroenDeDauw: we spoke about rotting the code. https://gerrit.wikimedia.org/r/#/c/143032/ yea, great. [15:12:55] (03PS13) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [15:14:27] also: rage! review! DanielK_WMDE_! aude! https://github.com/DataValues/Geo/pull/15 [15:15:08] :) [15:15:25] meh, github. much colors. so confusing. [15:15:39] i don't have query installed at the moment :/ [15:18:57] (03CR) 10Aude: [C: 032] Skip redirect tests as long as redirect arn't supported [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 (owner: 10Daniel Kinzler) [15:19:12] (03Merged) 10jenkins-bot: Skip redirect tests as long as redirect arn't supported [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143020 (owner: 10Daniel Kinzler) [15:19:41] [13Geo] 15brightbyte comment on pull request #15 14c84d379: should be caleld EPSILON :) 02http://git.io/xtPRcg [15:21:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [15:22:15] [13Geo] 15brightbyte comment on pull request #15 14c84d379: This is just a normalizer. Why is it called "calculator"? If we want to add methods for comparing and combining, I suggest to call this "GeoMath". 02http://git.io/OE1EhQ [15:23:25] aude: the class thiemo wants reviewd is currently not used anywhere. it's a standalone thing. no need to install. [15:23:34] Thiemo_WMDE: am i right? [15:24:48] suppose so [15:25:49] aude: all the degrees confuse me :P [15:26:11] (and i had never though about the fact that latitude and longitude don't have the same range. huh) [15:54:43] [13Geo] 15thiemowmde comment on pull request #15 14c84d379: It's not limited to the earth. ;-) 02http://git.io/VT_1pQ [15:58:03] [13Geo] 15thiemowmde 04force-pushed 06geo-calculator from 14c84d379 to 14475e420: 02http://git.io/l0cY9Q [15:58:03] 13Geo/06geo-calculator 14475e420 15Thiemo Mättig: Add LatLongCalculator [16:14:18] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I can't wrap my head around this ugly test setup. I understand why it is how it is, but still. Not sure how to proceed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [16:22:31] git review -t exporttransform [16:22:34] gah [16:22:57] doesn't work :p [16:23:07] (03PS1) 10Aude: Provide sane default for transformLegacyFormatOnExport [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 [16:24:51] ah [16:26:08] (03PS2) 10Aude: Provide sane default for transformLegacyFormatOnExport [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 [16:31:44] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Am I right that all EntityLookup code is unused? (I'm aware that it is used in the following patch.) I still wonder why everything in this" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141710 (owner: 10Daniel Kinzler) [16:35:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 (owner: 10Aude) [16:37:15] (03CR) 10Aude: [C: 032] "looks good and works for me :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 (owner: 10Daniel Kinzler) [16:37:30] (03Merged) 10jenkins-bot: Make tests for export transform independent of settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143017 (owner: 10Daniel Kinzler) [16:40:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 (owner: 10Aude) [16:42:32] (03PS3) 10Aude: Add tests for transformLegacyFormatOnExport default setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 [16:47:47] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Some weird interfaces and property names in here. :-(" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141391 (https://bugzilla.wikimedia.org/66075) (owner: 10Daniel Kinzler) [16:51:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 (owner: 10Aude) [17:32:46] (03PS3) 10Thiemo Mättig (WMDE): Make LanguageFallbackChain aware of EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140197 [17:33:20] (03CR) 10Thiemo Mättig (WMDE): "Got rid of a nesting level and most duplication. Better now?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140197 (owner: 10Thiemo Mättig (WMDE)) [17:42:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140197 (owner: 10Thiemo Mättig (WMDE)) [20:35:48] (03CR) 10Daniel Kinzler: Cleanup in EntityRevision related code (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139173 (owner: 10Thiemo Mättig (WMDE)) [20:36:23] (03CR) 10Daniel Kinzler: Cleanup in EntityRevision related code (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139173 (owner: 10Thiemo Mättig (WMDE)) [20:39:07] [13Geo] 15brightbyte comment on pull request #15 14475e420: ...and I wrote DecimalMath for QuantityValue :) 02http://git.io/alTzwA [20:44:23] (03CR) 10Daniel Kinzler: [C: 031] Add tests for transformLegacyFormatOnExport default setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 (owner: 10Aude) [20:45:16] (03CR) 10Daniel Kinzler: [C: 032] Add tests for transformLegacyFormatOnExport default setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 (owner: 10Aude) [20:45:39] (03Merged) 10jenkins-bot: Add tests for transformLegacyFormatOnExport default setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143044 (owner: 10Aude) [20:48:34] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143142 (owner: 10L10n-bot) [20:49:37] (03CR) 10Daniel Kinzler: "@Thiemo: think of EntityRevisionLookup as the low level interface, on top of which the EntityLookup is implemented." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141710 (owner: 10Daniel Kinzler) [21:00:12] (03CR) 10Daniel Kinzler: "@Thiemo: and I was so proud of the elegant solution ;)" (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141391 (https://bugzilla.wikimedia.org/66075) (owner: 10Daniel Kinzler) [23:12:18] notconfusing: hi, do you happen to have a table of VIAF ID (URL) and Wikidata Q-ID for authors (and other entities)? [23:12:33] I recently learned about VIAFbot, and thought you might have such a list. [23:13:03] whym: not something I could easily link you to [23:13:40] but it can be made by dump, or by script [23:13:50] what are you looking to do? [23:14:51] notconfusing: NDL (national library of Japan) is interested in linking NDL ID and Wikipedia pages, disambiguating synonyms etc. [23:15:36] they are doing it by strings now, but I am going to suggest using Wikidata instead, because NDL IDs are already imported to Wikidata faily well. [23:16:03] whym that effort has already started https://www.wikidata.org/w/index.php?search=Property%3ANDL&title=Special%3ASearch&go=Go&uselang=en [23:16:25] i could help, but im a bit swamped atm [23:23:02] https://www.wikidata.org/wiki/Wikidata:Database_download looks pretty sparse regarding database format. :(