[00:02:01] uh [00:02:03] aude: Around? [00:02:24] (03CR) 10Hoo man: [C: 032] Accept array of HTML messages in tooltip JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [00:03:21] (03Merged) 10jenkins-bot: Accept array of HTML messages in tooltip JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [00:26:44] (03PS9) 10Hoo man: Inject RepoApi into old UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [00:32:41] (03CR) 10Hoo man: [C: 04-1] "This immediately broke my wiki in non-debug mode due to caching issues :/" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [00:36:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [00:41:41] (03PS3) 10Hoo man: Remove wikibase.entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [00:44:16] (03PS4) 10Hoo man: Remove wikibase.entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [00:44:59] (03CR) 10Hoo man: "Rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [00:55:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [01:00:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [01:17:31] (03PS5) 10Hoo man: Remove wikibase.entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [01:18:03] (03CR) 10Hoo man: "Fixed problems introduced by the rebase (I guess). Can't test this further because of the evilsSeed problems" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [01:27:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [03:56:02] (03PS1) 10Aude: Handle StorageException in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) [03:56:07] (03PS1) 10Aude: Split ModifyEntity::getEntityRevisionFromApiParams method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 [03:56:09] (03PS1) 10Aude: Move $flags member var above constructor in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 [03:59:25] (03PS2) 10Aude: Move $flags member var above constructor in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 [03:59:27] (03PS2) 10Aude: Split ModifyEntity::getEntityRevisionFromApiParams method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 [03:59:29] (03PS2) 10Aude: Handle StorageException in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) [03:59:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) (owner: 10Aude) [04:03:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 (owner: 10Aude) [04:06:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [04:07:18] bah [04:09:12] jenkins no can haz mediawiki :( [04:10:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [04:11:47] (03CR) 10Aude: "https://git.wikimedia.org/ is down at the moment so jenkins no can haz mediawiki :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) (owner: 10Aude) [04:13:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 (owner: 10Aude) [04:17:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) (owner: 10Aude) [04:27:19] (03PS3) 10Aude: Move $flags member var above constructor in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 [04:27:21] (03PS3) 10Aude: Split ModifyEntity::getEntityRevisionFromApiParams method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 [04:27:23] (03PS3) 10Aude: Handle StorageException in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) [04:42:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [04:50:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 (owner: 10Aude) [04:55:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) (owner: 10Aude) [08:47:38] (03CR) 10Tobias Gritschacher: [C: 04-1] "Needs a manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [08:48:45] (03CR) 10Tobias Gritschacher: "Also this should depend on a release of WikibaseDatamodelSerialization and not on dev-master I think.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [09:10:27] does someone want to quickly review https://gerrit.wikimedia.org/r/#/c/146689/ ? [09:19:23] hi [09:19:42] how can i get the actual path of an image on wikimedia commons? [09:19:53] the api for instance gives me "Flag of Germany.svg" [09:20:06] how can i get this file? https://upload.wikimedia.org/wikipedia/en/b/ba/Flag_of_Germany.svg [09:20:12] i mean link [09:22:57] Schisma______: http://www.wikidata.org/wiki/Special:FilePath/Flag of Germany.svg [09:23:55] cool [09:23:59] hoo: thank you [09:25:07] oh, cool, I wish I'd known about that before now. is there a way to do that while specifying the maximum width or height? [09:25:48] at least with svgs it doesn't make much of a difference ^^ [09:28:00] I was thinking about huge jpg photos [09:28:03] nikki: https://www.wikidata.org/w/api.php?action=query&titles=File:Flag%20of%20Germany.svg&prop=imageinfo&iiurlwidth=123&iiprop=url [09:28:03] [13WikibaseDataModelSerialization] 15thiemowmde created 06typehints (+1 new commit): 02http://git.io/vRLDtA [09:28:03] 13WikibaseDataModelSerialization/06typehints 14c8616b2 15Thiemo Mättig: General type hint cleanup [09:28:37] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #71: General type hint cleanup (06master...06typehints) 02http://git.io/t9geag [09:28:48] Search for prop=imageinfo on https://www.wikidata.org/w/api.php for more doc ;) [09:28:58] hoo: but should i link files like that? [09:29:08] [09:29:26] seems kind of whaky [09:29:48] [13WikibaseDataModel] 15thiemowmde created 06unalias (+1 new commit): 02http://git.io/YNVltw [09:29:48] 13WikibaseDataModel/06unalias 14e7d4142 15Thiemo Mättig: Fix hard-coded Snak alias [09:29:59] for that purpose I would indeed use the imageinfo API (see above) [09:30:51] ah, thanks [09:32:28] hoo: just tring to visualize wikidata [09:32:30] for fun [09:32:45] :) [09:35:24] Thiemo_WMDE: Saw my comment on https://github.com/wmde/DataValuesJavascript/pull/43 ? [09:40:24] [13WikibaseDataModel] 15thiemowmde created 06typehints (+1 new commit): 02http://git.io/hrStdw [09:40:24] 13WikibaseDataModel/06typehints 1480ee913 15Thiemo Mättig: General type hint cleanup [09:40:35] (03PS1) 10Aude: new deployment build, mw1.24-wmf14 [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146736 [09:40:39] [13WikibaseDataModel] 15thiemowmde opened pull request #123: Fix hard-coded Snak alias (06master...06unalias) 02http://git.io/SkWJgQ [09:41:46] aude: Are you backportin stuffs? [09:42:02] no [09:42:15] well, would like https://gerrit.wikimedia.org/r/#/c/146689/ backported [09:43:20] [13WikibaseDataModel] 15thiemowmde opened pull request #124: General type hint cleanup (06master...06typehints) 02http://git.io/z2ZoKA [09:43:35] ah ok... I would like to have https://gerrit.wikimedia.org/r/146484 in there, so that I can finally debug that job weirdness :P [09:44:24] do you want to address the nitpick? [09:44:42] not sure how :P [09:45:09] i see [09:45:46] (03CR) 10Aude: [C: 032] Log attemptSave failures in UpdateRepoOnMoveJob (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146484 (owner: 10Hoo man) [09:46:00] we will have to backport that [09:46:07] (03Merged) 10jenkins-bot: Log attemptSave failures in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146484 (owner: 10Hoo man) [09:46:17] ok [09:46:43] I'm kind of worried about the stability of current master, there have been a lot of changes [09:46:46] * aude get branch made now and then is off today [09:46:52] true [09:46:55] [travis-ci] wmde/WikibaseDataModelSerialization/typehints/c8616b2 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/30052246 [09:47:20] that's why i make the branch now and we can run tests, etc and have time to fix any problems [09:49:04] We really need to do that, yes [09:49:37] [13WikibaseDataModelSerialization] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/elB9xQ [09:49:37] 13WikibaseDataModelSerialization/06master 1426d7334 15Marius Hoch: Merge pull request #71 from wmde/typehints... [09:54:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146736 (owner: 10Aude) [09:56:11] (03CR) 10Hoo man: [C: 032] "Looks sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) (owner: 10Aude) [09:56:29] (03Merged) 10jenkins-bot: Handle StorageException in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146689 (https://bugzilla.wikimedia.org/68086) (owner: 10Aude) [09:56:34] aude: Want both cherry picked and then make a PS2 for the build? [09:57:00] (03CR) 10Aude: [C: 032] new deployment build, mw1.24-wmf14 [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146736 (owner: 10Aude) [09:57:05] sure, go ahead [09:57:19] * aude off at conference [09:57:22] (03PS1) 10Hoo man: Handle StorageException in ModifyEntity [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146740 (https://bugzilla.wikimedia.org/68086) [09:57:33] aude: Uh... what conference is going on? [09:57:49] (03PS1) 10Hoo man: Log attemptSave failures in UpdateRepoOnMoveJob [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146741 [09:58:18] open knowledge festival [09:58:33] later [10:00:10] (03Merged) 10jenkins-bot: new deployment build, mw1.24-wmf14 [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146736 (owner: 10Aude) [10:00:40] Ok, will update the build then :) [10:00:56] (03PS1) 10WikidataBuilder: New Wikidata Build - 16/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/146742 [10:02:56] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=66972 is in review, but I see no patches linked? can you point me to them? [10:04:16] DanielK_WMDE: and can you make an estimation for https://bugzilla.wikimedia.org/show_bug.cgi?id=66582? [10:10:41] https://www.evernote.com/shard/s294/sh/913cb3f4-7d7e-43ca-bf4b-e676151a5bad/553b72b7e36e80a56fd70e70d39fbd46/res/56b17cba-bb65-438f-bf4b-f8621e30bd7e/skitch.png?resizeSmall&width=832 [10:10:47] this is what i currently have [10:11:19] it shows a graph of countries according to the "shares border with" property [10:11:27] uh, nice [10:13:05] brazil shares a border with france? [10:13:27] yep [10:13:42] i guess the answer is EMPIRE! [10:16:58] unfortunately it takes ages until the flag is loaded [10:17:12] even though the files are tiny [10:17:48] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf14/4083f34 : Thiemo Mättig The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30054041 [10:17:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146740 (https://bugzilla.wikimedia.org/68086) (owner: 10Hoo man) [10:18:40] (03CR) 10Hoo man: [C: 032] Handle StorageException in ModifyEntity [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146740 (https://bugzilla.wikimedia.org/68086) (owner: 10Hoo man) [10:18:53] (03Merged) 10jenkins-bot: Handle StorageException in ModifyEntity [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146740 (https://bugzilla.wikimedia.org/68086) (owner: 10Hoo man) [10:24:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/146742 (owner: 10WikidataBuilder) [10:24:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146741 (owner: 10Hoo man) [10:29:56] [travis-ci] wmde/WikibaseDataModel/unalias/e7d4142 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30052996 [10:30:01] is there a download of all the flags on the commons? [10:33:16] doubt it [10:33:32] (03CR) 10Hoo man: [C: 032] Log attemptSave failures in UpdateRepoOnMoveJob [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146741 (owner: 10Hoo man) [10:33:48] (03Merged) 10jenkins-bot: Log attemptSave failures in UpdateRepoOnMoveJob [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146741 (owner: 10Hoo man) [10:34:05] https://github.com/seanherron/Flag-Webicons/tree/master/flags [10:34:14] unfortunatly this guy changed the filenames [10:39:24] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/WsXcEQ [10:39:24] 13WikibaseDataModel/06master 1435cf09c 15Marius Hoch: Merge pull request #123 from wmde/unalias... [10:39:34] [13WikibaseDataModel] 15mariushoch 04deleted 06unalias at 14e7d4142: 02http://git.io/Mir6Jg [10:39:59] [13WikibaseDataModelSerialization] 15mariushoch 04deleted 06typehints at 14c8616b2: 02http://git.io/hQG7jg [10:41:11] [travis-ci] wmde/WikibaseDataModel/typehints/80ee913 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30054594 [10:47:53] (03PS1) 10Hoo man: Update Wikibase [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146749 [10:51:56] (03CR) 10Hoo man: [C: 032] Split ModifyEntity::getEntityRevisionFromApiParams method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 (owner: 10Aude) [10:52:14] (03Merged) 10jenkins-bot: Split ModifyEntity::getEntityRevisionFromApiParams method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146690 (owner: 10Aude) [10:54:41] (03PS4) 10Hoo man: Move $flags member var above constructor in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [10:55:11] (03CR) 10Hoo man: "Removed trailing WS" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [10:55:17] (03CR) 10Hoo man: [C: 032] Move $flags member var above constructor in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [10:55:32] (03Merged) 10jenkins-bot: Move $flags member var above constructor in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [11:02:31] (03CR) 10Hoo man: [C: 032] "Works fine locally now. Merging after the branch has been cut." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [11:02:55] (03Merged) 10jenkins-bot: Remove wikibase.entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143858 (owner: 10Adrian Lang) [11:06:18] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/2Gs8qw [11:06:18] 13ValueView/06master 140ced08f 15Marius Hoch: Merge pull request #83 from wmde/underline... [11:06:33] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/At2ceA [11:06:33] 13ValueView/06master 1430fd8e0 15Marius Hoch: Merge pull request #84 from wmde/underline2... [11:06:57] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146691 (owner: 10Aude) [11:08:17] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/9cp0Ag [11:08:17] 13ValueView/06master 144f4e24a 15Marius Hoch: Merge pull request #85 from wmde/msg-fallbacks... [11:08:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146749 (owner: 10Hoo man) [11:11:00] (03CR) 10Hoo man: [C: 04-1] "You can just poke us to review changes in other components... feel free to make a 0.6.5 ValueView release now (or tell me and I'll do it)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145766 (owner: 10Thiemo Mättig (WMDE)) [11:12:43] JeroenDeDauw: Any idea why travis does this: https://travis-ci.org/wmde/ValueView/builds ? [11:15:43] Lydia_WMDE are you around ? [11:16:21] GerardM-: They're probably eating right now :P [11:17:24] (03CR) 10Hoo man: "Jeroen: What's the state here? Your unclear -1 is blocking the deployment of this feature for quite some time now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [11:18:29] thanks hoo [11:31:54] (03CR) 10Hoo man: [C: 032] Make LanguageFallbackChain compatible to EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140197 (owner: 10Thiemo Mättig (WMDE)) [11:32:13] (03Merged) 10jenkins-bot: Make LanguageFallbackChain compatible to EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140197 (owner: 10Thiemo Mättig (WMDE)) [11:40:36] (03PS3) 10Hoo man: Drop individual jquery.tipsy styles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145347 (https://bugzilla.wikimedia.org/67802) (owner: 10Thiemo Mättig (WMDE)) [11:46:30] GerardM-: now i am :) [11:50:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145347 (https://bugzilla.wikimedia.org/67802) (owner: 10Thiemo Mättig (WMDE)) [11:51:07] I *hate* caching issues -.- [11:51:23] (03PS5) 10Thiemo Mättig (WMDE): Roundtrip tests for Lib\Serializers vs. DataModelSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 [11:54:32] (03CR) 10Hoo man: [C: 032] Update Wikibase [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146749 (owner: 10Hoo man) [11:55:08] (03CR) 10Aude: [C: 032] New Wikidata Build - 16/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/146742 (owner: 10WikidataBuilder) [11:55:26] aude: Going to update the release tool [11:55:31] thanks [11:55:47] or is that a question? [11:56:37] hoo: if you merge https://github.com/wmde/ValueView/pull/82 i will tag a ValueView 0.6.5. [11:57:42] (03Merged) 10jenkins-bot: Update Wikibase [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/146749 (owner: 10Hoo man) [12:00:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [12:00:58] (03Merged) 10jenkins-bot: New Wikidata Build - 16/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/146742 (owner: 10WikidataBuilder) [12:02:08] (03CR) 10Hoo man: [C: 032] Drop individual jquery.tipsy styles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145347 (https://bugzilla.wikimedia.org/67802) (owner: 10Thiemo Mättig (WMDE)) [12:02:21] (03Merged) 10jenkins-bot: Drop individual jquery.tipsy styles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145347 (https://bugzilla.wikimedia.org/67802) (owner: 10Thiemo Mättig (WMDE)) [12:22:51] (03PS4) 10Hoo man: Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [12:23:18] (03CR) 10Hoo man: "Manually rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [12:28:17] Thiemo_WMDE: The evilsSeed stuff is crazy :/ [12:28:43] it drives you and me crazy, thats for sure. [12:28:44] Only other way to fix this I can think about is totally insane... so I guess we should kill the tests for now [12:29:07] i still dont understand the problem. all tests pass. in all browsers. [12:29:17] whats wrong and where and why? [12:29:23] Thiemo_WMDE: phantomjs delivers an old JavaScript engine [12:29:28] probably an old version of V8 [12:29:36] I've linked the bug in my comment [12:29:42] what is pahntomjs? who uses this? [12:30:03] Thiemo_WMDE: :D We do for running the tests headless on travis [12:30:17] why? why not update it then? [12:30:20] it's a test runner that can run headless [12:30:23] Thiemo_WMDE: it's a browser that runs in memory [12:30:31] ok. update it. done. [12:30:39] The issue isn't fixed on master of phantomjs https://github.com/ariya/phantomjs/issues/10522 [12:30:51] I even checked out the latest version via npm yesterday, no luck either [12:31:13] so we are running tests on a broken js engine? [12:31:22] somewhat, yes [12:31:30] but phantomjs is like an industry standard [12:31:41] I don't even know an alternative offhand that's not hacked up [12:32:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [12:36:21] "ReferenceError: evilsSeed is not defined" [12:36:21] -.- [12:36:35] hoo: wait. you realize what this means? we are required to support known bugs of a JS engine nobody uses in production like they are features? this mental model is just wrong. [12:37:05] Thiemo_WMDE: Just change the .travis.yaml to ignore failures and I'll merge that thing [12:37:18] I'm at the point where I don't care how, but I really want that bug fixed ASAP [12:37:47] we don't really need to support phantomjs there... if someone feels like we should, they can figure out a solution [12:38:16] ok. wait. removing that crap still is an option. [12:38:16] what will break? [12:38:29] If we remove the named function stuff? [12:38:29] yes. [12:38:46] I very briefly tried it yesterday and a couple of tests failed, but I didn't look at that further [12:39:28] might be fixable, I can have a look [12:40:14] what if i remove the test for that function? [12:40:31] wont work, everything depends on that [12:40:41] that was my question. [12:40:51] great. [12:41:23] hoo: Thiemo_WMDE I'm not sure if I understand the original problem with the evilSeed [12:41:31] i did. [12:41:33] ;) [12:41:55] ... :P [12:42:00] We're going in circles [12:42:08] its pretty simple in the end. [12:42:38] the eval() created a scope/closure that was in no way bound to the scope around it. [12:43:22] but it tried to access a variable of the outer scope. which works most of the time when the outer scope is still there and not gone because of GC or whatnot. [12:44:02] but there was no binding between these two scopes. the JS engine was free to remove the outer scope. [12:44:11] now it's bound. [12:44:51] i create a new closure that includes the required variable. [12:44:53] simple. [12:45:08] Thiemo_WMDE: but what exactly is the problem with debugging? [12:45:30] travis uses a JS engine with a known bug. [12:45:54] wait, what debugging? [12:45:59] phantomjs [12:46:00] I think we have this code there since a long time now and nobody had a problem with it. or do i understand something wrong? [12:46:14] I'm not talking about the phantomjs issue [12:46:16] Tobi_WMDE: It errors for me often during testing [12:46:24] I want to understand why the change needs to be made [12:46:25] and I'll kill something if we keep that for much longer [12:46:45] "ReferenceError: evilsSeed is not defined" just now on my local host [12:46:47] nobody except me and hoo and an unknown number of people that are reporting random breakages on wikidata? [12:47:08] hm.. ok [12:47:15] I was just never getting this [12:47:28] it's not hard to reproduce, really [12:47:28] just shift+f5 in firefox. thats it. [12:48:07] ffs [12:48:19] I can't even test Adrian's stuff anymore because everything falls apart right now [12:48:21] -.- [12:48:52] the users usually don't notice this. they get a js-less html version which is fine for reading. they can click "edit", the page reloads (which usually fixes the problem) and they can click "edit" again. [12:49:32] but its a big, big pain when debugging. [12:49:45] Yeah [12:50:08] is this happening on a specific item? I can still not reproduce [12:50:13] and now we cant merge it because this will break all tests omn travis. [12:50:32] Tobi_WMDE: Everywhere... try private mode maybe [12:50:47] private with debug=true most of the time breaks [12:50:52] at least for me [13:02:04] hoo: i will do an other patch that just removes this evil thing. [13:02:13] ok [13:02:42] * hoo goes crazy [13:02:47] wtf resource loader [13:05:33] (03CR) 10Hoo man: [C: 04-1] "For some reason I always get the following errors, no matter what I do (in multiple browsers):" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [13:06:04] Thiemo_WMDE: Tobi_WMDE: ^ can one of you please look at that? No idea why stuff is so screwed over there... that should never ever happen [13:07:23] hoo: I'm currently getting "Error: Unknown dependency: json" on master locally.. no idea why [13:07:35] did I miss something? [13:07:38] Tobi_WMDE: Update your core ;) [13:07:48] that's the new json polyfill [13:08:14] hoo: so how do I include it? [13:08:20] hoo: I did [13:08:24] I think I did [13:08:35] updated my code the first time after 4 weeks.. :) [13:08:43] because of vacation.. hehe [13:08:54] I'll check [13:15:48] hoo: Thiemo_WMDE: did you consider this approach? https://github.com/c9/smith/blob/master/tests/public/test.js#L2-L7 [13:16:11] it seemd towork for that guy, that of course doesn't mean it works for us [13:16:24] Tobi_WMDE: Did you read my comment? [13:16:37] There are Function.bind polyfills, but none for Function.apply [13:16:41] hoo: on what thread? [13:16:48] i have no phantomjs environment. hoo has. [13:16:50] oh, there [13:18:07] yep [13:19:30] Thiemo_WMDE: Regarding https://gerrit.wikimedia.org/r/123298 [13:19:37] I don't see spinners often at all [13:19:53] mostly stuff just hangs for a moment and then content appears, but the spinner is not getting drawn usually [13:20:30] thats odd. this patch doesnt change that. there is a spinner before and after the patch. [13:20:49] I mean I don't even see spinners on master [13:20:58] on wikidata.org? [13:21:02] I didn't even check that out yet [13:21:03] locally [13:21:09] can look at WD.org [13:21:56] because FF delays the page rendering. [13:22:17] but same seems to go for webkit and IE [13:22:51] i set my opera 12 to render immediately. good for testing. [13:24:25] just tested MSIE with Q142 on Wikidata... the page stays blank for ages and then everything just appears and is ready [13:24:33] not sure the spinner is of much use actually [13:24:51] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/146742 (owner: 10WikidataBuilder) [13:25:52] Thiemo_WMDE: The code looks sane, if you tested it, I can test it briefly and approve it [13:25:59] but I can't really test the functionality [13:29:37] I think I got enough JS for now... :P [13:41:04] (03PS1) 10Thiemo Mättig (WMDE): More basic refactoring in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 [13:44:03] (03PS2) 10Thiemo Mättig (WMDE): More basic refactoring in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 [13:53:25] (03CR) 10Aude: [C: 04-1] "generally ok, matter of style but have concerns about change in behavior of the code" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [13:54:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [13:58:15] (03CR) 10Hoo man: "Do you want hard to track down bugs? Because this is how you get hard to track down bugs... the interface is quite awry here as it's state" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [14:00:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [14:10:50] [13DataValuesJavascript] 15thiemowmde created 06unname (+1 new commit): 02http://git.io/bBapqw [14:10:50] 13DataValuesJavascript/06unname 145e3dc5c 15Thiemo Mättig: Remove broken optional debug feature [14:11:44] \o/ [14:11:57] We should make a release soonish [14:12:07] this is the single most annoying bug in quite some tim [14:12:08] e [14:15:36] [13DataValuesJavascript] 15thiemowmde opened pull request #45: Remove broken optional debug feature (06master...06unname) 02http://git.io/l9lRjA [14:15:56] (03CR) 10Daniel Kinzler: "@hoo: yes, this is optimized for performance, at the cost of prettiness. I agree though that it's annoying that some things depend so much" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [14:23:10] Lesson of the day: A feature made for easier debugging made debugging impossible in certain situations. [14:24:27] (03CR) 10Adrian Lang: "@Jeroen: `options` is what the constructor arguments are called in the old and the new ui." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [14:26:15] (03CR) 10Adrian Lang: "Sounds to me like there is a syntax error in wikibase.js" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:26:25] (03CR) 10Hoo man: Inject RepoApi into old UI (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [14:27:07] Adrian_WMDE: Nope, no syntax error [14:27:32] I added a console.log( 'Wikibase is here' ); to the bottom of the file and it only fired after the exceptions from wikibase.sites/ wikibase.Site [14:27:40] hoo: about the spinner patch. if you don't fully understand it and can't easily test it then don't merge it. all important details are split and already merged. what's left there is not relevant. [14:27:46] somehow the load order is screwed, but I've no idea why/ how [14:28:07] Thiemo_WMDE: I do understand it, I just can't test it [14:28:07] (03CR) 10Adrian Lang: Inject RepoApi into old UI (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [14:28:10] it's not complicated [14:28:48] the patch changes the design a bit so you should have a look at the difference in your browser. [14:29:10] hoo: I don't get it, how is that possible? :D [14:29:25] Thiemo_WMDE: that's why I'm worried a bit... I don't have any browser which actually show the spinner right now :P [14:29:26] Ah, I get [14:29:28] it [14:29:31] Circular dependency [14:29:38] hoo: as said, this is one of the few patches i don't care much about. ;) [14:29:51] Hm, no, not circular [14:29:57] Adrian_WMDE: Yep, also checked that [14:30:00] Just wrong [14:30:05] it's just screwed [14:30:11] can you reproduce at least? [14:30:13] wikibase depends on wikibase.sites [14:30:22] not in the Resource.js [14:30:27] but in reality, yes [14:30:30] * Resource.php [14:30:38] And wikibase.Site.js is in wikibase [14:30:44] Ok, well in my version it did/does [14:31:01] wikibase.js has to be moved to a different module [14:31:14] could move it to wikibase.common [14:31:16] or a wikibase.core [14:31:32] wikibase.__namespace or wikibase.init or whatever [14:31:32] than wikibase has to depend on that [14:31:32] and wikibase.sites too [14:31:44] wikibase.sites has to depend on that wikibase.whatever [14:31:57] Then wikibase.js is loaded before wikibase.sites before wikibase.Site [14:32:14] core works for me [14:32:16] Yeah, I guess so... although it should actually work in the current state [14:32:31] wikibase.sites should only be loaded after wikibase is there [14:32:46] and wikibase doesn't (in ResourceLoader) depend on wikibase [14:32:50] .sites [14:33:01] or am I missing something [14:33:09] Hm, I see [14:33:15] Maybe it is circular somehow [14:33:16] it's screwed, yes... but it should load [14:34:02] If it's circular resource loader will just dump stuff instead of loading it [14:34:22] without crying about it? [14:34:30] Yes [14:34:35] yikes [14:34:38] try debugging what resource loader loads why [14:34:45] Maybe you'll find the issue [14:35:06] The solution I proposed does not really apply with the current Resources.php because it looks fine already [14:35:28] Gotta go agai [14:35:28] n [14:35:34] ok, cu [14:41:39] (03PS3) 10Thiemo Mättig (WMDE): More basic refactoring in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 [14:42:35] (03CR) 10Thiemo Mättig (WMDE): "Behavior change was unintentional. Good catch, thanks! Fixed in PS3." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [14:48:09] aude: Did you start on https://bugzilla.wikimedia.org/show_bug.cgi?id=68029 yet or am I free to? [14:51:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [14:52:11] (03CR) 10Hoo man: [C: 032] More basic refactoring in ModifyEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [14:52:23] (03Merged) 10jenkins-bot: More basic refactoring in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [15:02:31] (03CR) 10Thiemo Mättig (WMDE): More basic refactoring in ModifyEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146765 (owner: 10Thiemo Mättig (WMDE)) [15:28:26] hoo: I think aude did not start yet (but not sure 100% though) [15:28:56] she's on a conference today and tomorrow and I don't think she's doing a lot of coding [15:29:09] Ok, I'll do it today then [15:29:09] so, I think it's fine if you start working on that [15:29:14] actuall I've already started [15:30:55] great :) [15:31:08] mh [15:31:16] can't find how the syntax was planned to look [15:31:29] {{#property:P123|from=@42}} ? [15:31:32] * Q42 [15:31:52] Lydia_WMDE: ^ [15:35:49] ah, of [15:44:43] hoo: she'll be online once she's at home [15:58:49] Is it just for me this isn't working? http://tools.wmflabs.org/reasonator/?&q=16067303 [16:42:07] hoo: https://meta.wikimedia.org/wiki/Wikidata/Notes/Inclusion_syntax_v0.4 was the plan [16:42:20] i think it makes more sense with of [16:43:06] Lydia_WMDE: That's what I'm going to do... it's a little ugly to get the parser functions to do what I want [16:43:12] wait [16:43:14] fuck [16:43:16] ? [16:43:41] I think aud.e did some refactoring on them recently, but I don't yet have that as I'm working on an old branch on top of the Lua stuff [16:44:52] Ok, not as bad as I thought [16:44:56] but still :/ [16:45:09] (03PS6) 10Hoo man: Lua: Allow arbitrary item access [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144965 (https://bugzilla.wikimedia.org/67538) [16:45:17] (03PS2) 10Hoo man: Lua: Add integration tests for the 'allowArbitraryDataAccess' setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 [16:45:29] I need to force someone to review that code :P [17:49:32] Is there a template that lets me return the value of a given property for a given item? [17:50:08] No, arbitrary item access has not be enabled yet, so that this can't be done in a template (yet) [17:50:19] hoo :( [17:50:40] hoo: It would be nice for data validation [17:51:19] On which Wiki do you want this? Wikidata directly? [17:51:34] hoo yeah… [17:52:16] ah... there are already hacks for that on Wikidata [17:52:28] and it will also be officially possible sometime soon [17:52:40] (can't name an exact date here as there are a few things that need to be done first) [17:52:45] i.e. {{whatever the template was|Q72896|P31}} would return human? [17:53:08] You could do that then like {{#property:father|of=Q1234}} [17:53:16] I'm working on that literally right now :P [17:55:18] hoo: What I’d like to do is, for the list of people that I’m working on, make a ‘subpage’ (i.e. fake local template) that ‘test’ for ‘instance of -> human”, “surname -> whatver”, “given name -> whatever” and so on... [17:56:35] Yeah, I see... not sure parser functions/ templates are the way to go there (might get slow with many items) [17:56:41] but that will work, yes [17:57:25] Even better would be an actual template, like (fake) {{validate-human}} that tests the ‘mandatory’ (not the right word, but you know what I mean) properties of a human being [17:57:54] You could write whatever you want with that... in Lua you have a lot of possibilities to use and mangle data :) [17:58:12] Yeah, I need to learn lua… [17:58:58] It's much nicer than handling wikitext ;) [17:59:18] Where is #property documented? [17:59:42] Not sure, but it doesn't do much right now anyway [17:59:53] you can only get stuff of the item that is linked with the current page [18:00:00] and it's not enabled on Wikidata at all atm [18:01:29] hoo: So basically it’s ‘not possible yet’ locally, but i could do it from enwiki… [18:01:34] Ye? [18:02:00] revent: It's more complicated than that [18:02:28] On wikidata: Not yet possible at all (if you ignore the ugly hacks). On wikipedia: You can access the item linked to the current page [18:03:03] so on Wikipedia you can only read data from the item linked to the current page (eg. the item about Berlin for the Berlin article) [18:03:25] https://www.mediawiki.org/wiki/Extension:WikibaseClient/Lua Our Lua API is documented quite well [18:04:29] hoo: Yeah, was actually looking at that yesterday… [18:05:55] hoo: Was trying to figure out (without any lua competency) how to return the label of the current linked page in a given language (i.e. not that of the local wiki) [18:06:28] easy [18:06:35] local entity = mw.wikibase.getEntityObject() [18:06:46] Right.... [18:06:48] return entity:getLabel( 'es' ) -- Spanish label [18:07:04] just wrap that in a module and it will work :) [18:07:20] However…. https://en.wikipedia.org/wiki/Module:Wikibase doesn’t ‘do it’ [18:07:39] that module is heavily outdated and uses stuff we advise people to no longer use [18:07:43] it's deprecated [18:07:47] well, it should be [18:07:47] and my ‘lue competency’ is nonexistent [18:10:40] Yeah, I seem to keep running up against things that are ‘not quite fully implemented’ and that are beyond my programming competency. [18:10:41] revent: It's really worth learning. The parser functions will of course also work for basic tasks, but if you plan more complex things you're better of with Lua [18:11:05] hoo: It’s on the ‘to-do list’ :) [18:11:09] Yeah, there's a lot of things missing in the puzzle from our side (you can track that on bugzilla), but we are working on it [18:12:44] hoo: FWIW, I’m really an enwiki peep, but very ‘meta’ (I don’t write content, but do things like fix crappy references)…I’ve been over here doing ‘bibliographic’ stuff… [18:15:39] I’m eagerly (very) awaiting the ability for [[Cite ISBN]] (which stores the actuall {{cite book}} on a a subpage) to be able to use WikiData. [18:16:37] Which, ofc, requites that unimplemented feature you mentioned (fetch data from an item that is not linked to the current page) [18:17:59] I'm not into that much (it's about using an item about a book as citation, right?), but that sounds doable. [18:20:57] hoo: Ye, but the {{cite book}} ends up getting parsed on the page of the article in which the citation is used… the only way I can figure out to do it is kind of an ugly hack (link the ISBN subpage to the book, and subst the citation template when writing the citation…it would fetch the data ‘once’ only… ick [18:22:28] that's evil, don't do that [18:22:43] You'll have to wait for the feature in this case [18:22:50] Yeah, like I said, ugly hack, and hella ick. [18:23:11] I’m emphatically NOT ‘doing it’ [18:24:43] But… I’m over here learning how to enter the bibliographic data ‘properly’ for when you guys make it possible... [18:26:03] By ‘properly’ I mean… I’m anal enough to actually use ‘authoritative references’ when ‘fixing’ book citations on enwiki, instead of crap like fetcing the data from one of the random duplicates in WorldCat…. [18:26:54] (a citation to a book that does not include a page number should be to the used ‘edition’ of the book, not to a specific ‘instance’ of that edition) [18:28:28] Or at least to the ‘principal’ copy of that edition, i.e. (when applicable) the “native country hardcover” printing of the edition, as opposed to the “US paperback” version…. [18:29:35] As opposed to having metadat grabbed from some random duplicate in worldcat) [18:31:21] Really more of an issue in ‘bibliographies’ of an author’s works, where the ‘item being referred to’ is the work, not a specifc edition or printing. [18:32:38] (I’ll stop ranting now, lol) [18:37:12] hoo: is this difflink working for you? https://gerrit.wikimedia.org/r/#/c/144668/20..21/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php [18:37:19] perhaps a gerrit bug -.- [18:39:37] doesn't seem to load [18:39:44] is that the thing I did? [18:39:49] I just checked out HEAD~1 [18:39:56] as HEAD was obviously broken [18:54:42] hoo: apparently you did it... [18:55:14] I did what? [18:59:21] (03CR) 10Bene: "@hoo: see https://gerrit.wikimedia.org/r/#/c/145554/ for a fix by Thiemo for the svg problem in non-svg browsers." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [19:00:58] (03CR) 10Hoo man: "Ah, that's great. If someone could sign off the changes I did to this I guess we can go for it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [19:04:01] hoo: you submitted the patch which caused gerrit to fail :P [19:04:05] *patch set [19:04:18] :P [19:04:38] I didn't do any black magic... I only reseted the file to the state from HEAD~1 [19:05:06] hoo: and now strange things happened with it :/ [19:05:39] try to rebase it, that often fixes weirdnesses :P [19:10:27] (03PS22) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [19:20:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [19:27:37] hoo|away: wanna look at my github pull request when you're back? [19:45:36] (03CR) 10Bene: [C: 031] "one nitpick but looks good from my side." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [19:51:58] Lydia_WMDE: found another problem with guided tours... [19:52:14] benestar: oh? [19:52:35] Lydia_WMDE: if the user's language is not en they will not find the property + item in the statements tour [19:53:08] benestar: meh right... - we can forse english for now? [19:53:27] Lydia_WMDE: well, with &uselang=en [19:53:40] yeah [19:53:41] but we need translations for the long time [19:53:49] not great but better than broken imho [19:53:49] yeah [20:08:23] Lydia_WMDE: it now redirects to ...&uselang=en if there is no translation available [20:10:50] great [20:10:54] thanks benestar! [20:11:20] benestar: how about we look into translation in one week? [20:11:31] by then we should have gotten enough feedback i guess [20:12:45] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146893 (owner: 10L10n-bot) [20:13:05] should then maybe even have its own translation group or whatever it is called [20:13:12] like we have for the weekly summary [20:13:16] Lydia_WMDE: if the feedback increases as fast as it did the last days I doubt we will have any feedback until then :P [20:13:29] heh [20:13:40] well that is fine as well i guess [20:16:37] Lydia_WMDE: did you get any feedback somewhere? [20:16:59] besides a highly retweetet anouncment [20:17:10] no just a lot of enthusiastic people [20:17:24] which is good in my eyes [20:17:27] * announcement [20:17:33] well, I hope so [20:17:46] i'd say we should go ahead and do the remaining tours and start translating [20:17:53] Lydia_WMDE: do you know if there is somebody who can check if the tours have an impact on new editors? [20:18:01] if we didn't get any negative feedback until now it is unlike it will come later [20:18:06] at least nothing big [20:18:39] yeah i can send an email and ask [20:18:46] will cc you and helen [20:18:50] would be interesting to know [20:19:00] I can try to create some usage statistics [20:19:13] but it would take more time to check if the users stay active after the tours etc [20:19:28] yeah [20:19:36] let me send an email and see [20:28:48] hoo: did you read my ping? [20:30:11] benestar: I might have a look later on or early tomorrow [20:30:40] going to work a bit more on the parser functions first and then re-review on of Adrian's changes [20:30:47] ok, that's fine [20:30:58] hoo: I will be on vacations the next week anyway [20:31:15] perhaps I will have some time on Friday but then one week without fast Internet :O [20:31:42] oO [20:31:53] No interwebs?! :P [20:46:03] well, cu later [21:08:48] nooooooooooooooooo [21:08:53] benestar|cloud: how will we survive? [21:08:58] how will you survuve?! [21:09:02] don't go! ;-) [21:16:54] (03Draft3) 10Aude: Restructure parser function code with more, better tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [21:19:10] (03CR) 10Aude: "can try to split in smaller patches if that helps" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [21:20:48] aude: Noooo [21:20:55] :P [21:21:08] I worked on that code quite some time today :/ [21:21:34] Implemented arbitrary access [21:21:52] still lacks tests and useful error messages, though [21:22:05] (03PS4) 10Aude: Restructure parser function code with more, better tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [21:22:24] aaaaaa [21:22:42] * aude panic :p [21:23:52] want to invert the dependencies and split things up, so we can do renderForItemId() whatever [21:23:57] aude: Yikes... if you rebase your stuff on top of my Lua changes, I can probably redo my changes on top of yours [21:24:34] let's see [21:26:04] aude: Mh... planned to finish my stuff today, but not sure now... what should I do? [21:26:24] is there a patch? [21:26:32] it's not on gerrit yet [21:26:43] I wrote it this afternoon [21:27:04] hmmmm [21:29:15] i have to look at the lua patches again [21:29:42] (03PS5) 10Aude: Restructure parser function code with more, better tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [21:30:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [21:36:55] (03CR) 10Aude: [C: 031] "looks good, tests pass and manually verified" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144965 (https://bugzilla.wikimedia.org/67538) (owner: 10Hoo man) [21:37:23] (03CR) 10Aude: [C: 031] Lua: Add integration tests for the 'allowArbitraryDataAccess' setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 (owner: 10Hoo man) [21:37:35] hoo: if daniel is around, he should look at lua again [21:39:31] aude: +1 [21:39:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [21:39:54] Lau kind of is the req. for parser functions [21:40:04] * Lua [21:40:11] because I introduce the setting in those changes [21:40:40] ok [21:40:52] in https://gerrit.wikimedia.org/r/#/c/145572/5/client/includes/DataAccess/PropertyParserFunctionHandler.php [21:41:15] i would then like some kind of 'factory' or something for the renderer that depends on the parser [21:41:22] (to determine language) [21:41:32] and kill mor eof the legacy code [21:42:00] then the factory would be injected [21:43:07] mh [21:43:43] aude: Is DataAccess supposed to be shared by the parser functions and Lua? [21:44:03] could be [21:44:13] open to other names or such [21:44:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [21:44:35] mh :/ We shouldn't be spending so much time on the parser functions [21:44:50] In the same time we could probably made them a small wrapper around Lua :/ [21:45:14] not sure [21:45:21] do we want the dependency on lua? [21:45:32] that's a tough question [21:46:03] rather the php code can be shared, either way [21:46:06] a bit of it [21:46:07] we probably want all this stuff in an own component anyway [21:47:01] yep [21:50:27] aude: is there a bug about the refactoring which you're doing? [21:51:11] blocker to bug 68029 [21:52:43] didn't make a bug [21:52:54] aude: Going to be in the office in a week... I think we should sit together (with Lydia, Daniel, possibly Thiemo, ...) and talk about these features [21:53:04] especially for Lua there's quite some stuff to do [21:53:10] +1 [21:53:15] eg. we don't support references yet and all stuff like that [21:53:30] I'm not sure how we want to implement this, so we should talk about that [21:53:38] yeah [21:54:06] People on dewiki wrote own formatters to show references... that's completely insane [21:54:28] not surprised [21:54:36] enwiki is using deprecated stuff only, pretty much [21:54:43] Yep, saw that also [21:55:06] no good examples :( [21:55:10] We need to improve our interfaces or people will hack up more evil stuffs [21:55:19] yep [21:58:07] (03CR) 10Aude: "i would like to do follow-up to inject a render factory or such instead of the renderers and move more code out of the 'handler' thing. t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [22:01:28] hoo: Cite ISBN… >) [22:02:03] revent: Yeah :P As told, we have this stuff on our to do... but resources are limited so stuff can take a bit of time [22:02:45] hoo: Don’t worry, I PROMISE not to do that… it would be really horrible. [22:04:34] Such home brewed solutions often end up being hard to maintain... we of course encourage people to use our data, but I doubt it's a good idea to reimplement our formatters [22:05:45] hoo: Yeah, you’d need a bot on enwiki monitoring wikidata recent changes and regenerating the template whenever someone fixed something on Wikidate….. an chain of epicfail [22:07:38] hoo: BTW, I only recently became aware that enwiki is using a version of {{authority control}} that uses Wikidata as a fallback if UINs exist that aren’t defined in the template call… is that a local hack, or ‘official’? [22:08:51] this… https://en.wikipedia.org/wiki/Module:Authority_control [22:09:49] revent: It uses our proper interface (but the deprecated one) [22:10:48] and then does some stuff with our data structure... that might be prone to fail if we change our interal data structures [22:14:46] hoo: I’ve noticed bugs in it…. it will trow a page in ‘identifiers that don’t match’ if Wikidata has two identifiers, one that matches and one that doesn’t… (in the particular case I noted, VIAF had an unmerged duplicate (that I reported to them) [22:21:13] :/ I guess it's pretty hard to write code that can decently well handle all possible cases... [22:23:02] Well, yeah, I just meant that it apparently only looks at one instance (shrugs) [22:39:34] (03PS10) 10Hoo man: Inject RepoApi into old UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [22:40:15] (03CR) 10Hoo man: "Manually rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [22:43:30] (03CR) 10Hoo man: [C: 032] "Transition to this seemed to work fine now... so I'm good with this :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [22:46:18] (03Merged) 10jenkins-bot: Inject RepoApi into old UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [22:49:35] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145237 (owner: 10Adrian Lang) [22:55:04] (03PS5) 10Hoo man: Inject API into parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [22:55:59] (03CR) 10Hoo man: "Rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [23:01:56] (03CR) 10Hoo man: [C: 031] "Looks good and seems to work fine, but someone should run the browser tests on this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [23:04:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [23:18:57] (03CR) 10Hoo man: [C: 04-1] "Lot of mostly nitpicks..." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [23:20:51] (03CR) 10Hoo man: "Another thought: All these class names are extremely long... maybe we should have a sub folder and namespace PropertyParserFunction so tha" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [23:50:00] Hi, can someone "merge" https://www.wikidata.org/wiki/Q3875012 with https://www.wikidata.org/wiki/Q15812131 ? The dewiki and enwiki article are about the same topic.