[03:24:33] Strange to find American engineers not covered in enwiki, but covered in ptwiki [03:29:07] <{soap|bed}> oh hi peoples [03:29:30] <{soap|bed}> not that theres a single person here who isnt on #en or anything [03:29:36] :P [03:29:59] Actually, there are... [03:30:24] (points at top person on list) :P [03:32:43] <{soap|bed}> chanserv is on #en [03:32:57] Not the bot, dork… [03:33:23] But yeah, you have a point. [06:30:46] [13WikibaseDataModel] 15thiemowmde 04deleted 06ediff at 1472040ed: 02http://git.io/F5hRtA [06:37:15] Meh. I get mixed up about what is right, and what is wrong…. I see axamples that are different. [06:41:34] Doesn’t it make sense to use alma mater as a modifier to the academic degree? If you use ‘alma mater’ and ‘academic degree’ directly on the person, you lose information…. which school they earned their degree at. [07:01:59] Oi, not that anyone listeneing, but I foun an answer, lol [08:20:54] hey :) [08:25:59] o/ [09:44:48] [13DataValuesJavascript] 15thiemowmde created 06globals (+1 new commit): 02http://git.io/NVE4fg [09:44:48] 13DataValuesJavascript/06globals 1470d9a7f 15Thiemo Mättig: Don't assume non-required global is set [09:45:34] [13DataValuesJavascript] 15thiemowmde opened pull request #46: Don't assume non-required global is set (06master...06globals) 02http://git.io/59RB2Q [10:00:41] (03PS1) 10WikidataBuilder: New Wikidata Build - 21/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148040 [10:05:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148040 (owner: 10WikidataBuilder) [10:07:44] Fatal error: Cannot redeclare class FileTest .... huh? [10:07:53] no such thing in wikibase! [10:26:31] Lydia_WMDE: I've read that I'm not the only one with problems regarding men. [10:27:01] sjoerddebruin: yeah i just replied on project chat. male was added as an alias to male animal [10:27:19] Does that affects all languages? [10:27:20] i suggest to remove it to fix it until we have better suggestions based on the student's work [10:27:31] it was added to english [10:28:02] we did fix the other issue that screwed up ranking [10:28:07] Yeah. [10:32:22] (03PS3) 10Aude: Introduce RendererFactory class for parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 [10:33:47] (03Abandoned) 10Aude: Add and improve test cases in RunnerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147430 (owner: 10Aude) [10:34:19] aude: Lydia_WMDE: Tonights first json dump failed, but I've hotfixed the script this morning before I headed of [10:34:34] hoo: \o/ [10:34:37] thx [10:34:59] I hope taht we can get Ariel to run it per hand, so taht we don't need to wait another week [10:34:59] Lydia_WMDE: Got my mail, btw? :P [10:35:13] (03PS3) 10Aude: Split parser function rendering and snaks finding code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 [10:35:17] hoo: yes! see you soon [10:37:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [10:38:03] rage [10:38:05] q [10:38:57] wtf, Fatal error: Cannot redeclare class FileTest [10:39:07] nothing to do with my patch and nothing to do with wikibase! [10:39:21] sounds like Core [10:40:12] :O [10:40:23] dun dun dun! [10:40:24] same error on the build today [10:40:31] uh [10:40:41] but not when wmf jenkins ran the tests [10:40:49] mh [10:40:57] nor wmf jenkins is failing for core patches / merges [10:41:09] can't really have a look now... Internet on the train ride is awry [10:41:17] (using mobile, not in train wlan stuffs) [10:41:19] aude: hoo think I have got it [10:41:23] oooo [10:41:33] https://github.com/wikimedia/mediawiki-core/blob/3fb5b3c16fc2c8db2dd4eb4612d0767e71a30772/tests/phpunit/includes/filerepo/file/FileTest.php [10:41:44] thats a new file, and the last commit says merge 2 FileTest files [10:42:09] what? [10:42:10] we did have a problem before on wbjenkins that wouldnt remove old files when they were deleted or renammed, that chould be it [10:42:21] think that got renamed [10:42:51] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [10:43:04] on my install, i have filerepo/files and filerepo/file [10:43:28] https://gerrit.wikimedia.org/r/#/c/147079/ [10:43:30] bug file/FileTest.php is declared as "FileRepoFileTest" [10:43:47] ah [10:43:50] =] [10:44:01] so we need to clean jenkins somehow [10:44:04] Tobi_WMDE: ^ [10:44:26] aude: hmm [10:44:36] how do we clean old stuff? [10:44:45] let me see [10:44:47] I did think we had fixed this issue [10:44:58] but maybe not :) [10:45:19] addshore: probably not after we used job builder [10:48:10] aude: addshore: try again. I wiped out all of the workspaces.. =) [10:48:14] yay [10:48:28] should happen automatically, not sure why it did not [10:48:43] (03PS4) 10Aude: Split property parser function rendering and snaks finding code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 [10:49:48] (03PS2) 10Aude: New Wikidata Build - 21/07/2014 10:00 :) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148040 (owner: 10WikidataBuilder) [10:49:54] hoo: and thx btw re cat picture :D [10:50:26] * aude eat [10:50:38] [= [10:51:17] :D [10:55:02] (03PS1) 10Amire80: Remove unneded prefixed CSS rules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148046 [10:59:27] WD edit counts go up silly fast…. interesting. [11:04:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [11:10:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148040 (owner: 10WikidataBuilder) [11:10:50] Anyone know Chinese? [11:11:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148046 (owner: 10Amire80) [11:34:06] (03PS1) 10Hoo man: Add an integration test for UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148050 [11:34:25] Wanted to do that for a long time now :P [11:34:46] Took me ages to figure out why my tests time out: SpamBlacklist always refetches the meta spam blacklist during tests [11:34:58] because caching is disabled during tests# [11:35:11] together with a high latency that can lead to timeouts :P [11:36:53] should probably be fixed in spam blacklist [11:39:19] will turn the notebook off now... see you in 1:30 or so :) [11:41:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148050 (owner: 10Hoo man) [12:05:46] (03CR) 10Aude: [C: 032] "jenkins approves!" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148040 (owner: 10WikidataBuilder) [12:08:56] (03Merged) 10jenkins-bot: New Wikidata Build - 21/07/2014 10:00 :) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148040 (owner: 10WikidataBuilder) [12:22:05] (03PS2) 10Aude: Remove unneeded prefixed CSS rules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148046 (owner: 10Amire80) [12:22:24] (03CR) 10Aude: [C: 032] Remove unneeded prefixed CSS rules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148046 (owner: 10Amire80) [12:22:36] (03Merged) 10jenkins-bot: Remove unneeded prefixed CSS rules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148046 (owner: 10Amire80) [12:24:56] (03PS4) 10Thiemo Mättig (WMDE): Introduce EntityTermLookups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 [12:25:24] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Ready to be reviewed in my opinion." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [12:33:17] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148046 (owner: 10Amire80) [12:39:10] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148040 (owner: 10WikidataBuilder) [12:40:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [12:41:10] Tobi_WMDE: http://wdjenkins.wmflabs.org/ci/job/wikibase-build-browsertests-saucelabs/84/ [12:42:12] sounds like something needs to be renamed in login_page [12:42:24] o_O [12:45:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [13:01:44] (03PS2) 10Thiemo Mättig (WMDE): Make ChangeNotifier an interface and introduce NullChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 [13:02:36] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/61e75e7 : Amir E. Aharoni The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30452318 [13:09:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [13:11:37] (03CR) 10Hoo man: "Can you abandon this then? confusing…" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [13:13:28] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add an integration test for UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148050 (owner: 10Hoo man) [13:13:43] (03Merged) 10jenkins-bot: Add an integration test for UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148050 (owner: 10Hoo man) [13:15:13] (03CR) 10Hoo man: [C: 032] "Works like a charm :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147412 (owner: 10Aude) [13:16:14] (03Merged) 10jenkins-bot: Rename and move PropertyParserFunction code to own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147412 (owner: 10Aude) [13:16:41] (03PS3) 10Hoo man: Move parser function code for site link lookup out of static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [13:17:11] (03CR) 10Aude: [C: 04-2] "can do -2" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [13:18:10] (03PS1) 10Aude: Move more parser function rendering code to Renderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 [13:19:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/70532bd : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30456226 [13:20:34] (03CR) 10Hoo man: "nit pick" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [13:24:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/394d8e6 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30456440 [13:28:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [13:33:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 (owner: 10Aude) [13:39:55] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/FuItrg [13:39:55] 13WikidataBrowserTests/06master 142571d3a 15Tobias Gritschacher: Enforce page-object version 1.0 as there is a bug in version 1.0.1 [13:40:04] aude: https://github.com/wmde/WikidataBrowserTests/commit/2571d3a24ab9fa93b6bae6e5ad22af69671c6308 [13:40:20] should be fixed [13:40:25] yay! [13:47:35] (03PS1) 10Thiemo Mättig (WMDE): Refactor ChangeNotifiers and weird "channel" concept [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148065 [13:50:03] (03PS1) 10Aude: Remove unused constructor params from parser function Runner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148066 [13:53:49] (03PS2) 10Aude: Move more parser function rendering code to Renderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 [13:53:50] (03PS4) 10Aude: Introduce RendererFactory class for parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 [13:53:52] (03PS2) 10Aude: Remove unused constructor params from parser function Runner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148066 [13:53:54] sorry jenkins! [13:53:55] (03PS5) 10Aude: Split parser function rendering and snaks finding code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 [13:53:57] (03PS3) 10Aude: Move constructor code out of parser function static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 [13:53:59] (03PS4) 10Aude: Move parser function code for site link lookup out of static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 [13:57:33] (03CR) 10Hoo man: [C: 032] Move parser function code for site link lookup out of static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [13:57:49] (03Merged) 10jenkins-bot: Move parser function code for site link lookup out of static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [14:00:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148065 (owner: 10Thiemo Mättig (WMDE)) [14:00:42] (03PS2) 10Thiemo Mättig (WMDE): Refactor ChangeNotifiers and weird "channel" concept [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148065 [14:04:26] let's kill the jenkins [14:04:55] more nodes!!! [14:06:06] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9cc4489 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30460265 [14:12:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148066 (owner: 10Aude) [14:13:08] (03PS1) 10Hoo man: Fix installing PHPUnit 3.7 via composer (on travis) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148068 [14:13:18] aude: ^ [14:14:01] (03CR) 10Aude: [C: 032] Fix installing PHPUnit 3.7 via composer (on travis) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148068 (owner: 10Hoo man) [14:14:11] not waiting for wikidata jenkins :) [14:14:19] (03Merged) 10jenkins-bot: Fix installing PHPUnit 3.7 via composer (on travis) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148068 (owner: 10Hoo man) [14:24:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 (owner: 10Aude) [14:35:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [14:36:10] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/b4XDxw [14:36:10] 13WikidataBrowserTests/06master 14a131f49 15Tobias Gritschacher: page-object gem got fixed, we can include the latest version again [14:38:20] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/919b923 : Marius Hoch The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30461623 [14:44:42] (03PS1) 10Hoo man: Don't end JSON snippets with new lines [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148084 [14:44:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148066 (owner: 10Aude) [14:45:13] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move constructor code out of parser function static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 (owner: 10Aude) [14:46:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove unused constructor params from parser function Runner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148066 (owner: 10Aude) [14:47:40] Tobi_WMDE: Did you open a bug yet or created a fix about the JS trouble you had? [14:47:42] (03Merged) 10jenkins-bot: Move constructor code out of parser function static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 (owner: 10Aude) [14:47:53] hoo: no [14:48:06] should I create a bug or are you looking into it right now? [14:48:23] can have a look now [14:48:30] ok [14:50:05] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Makes sense, tests succeed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 (owner: 10Aude) [14:52:02] Yikes, travis fails for real now after I've fixed composer :P [14:52:05] Will have a look [14:53:39] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Introduce RendererFactory class for parser function (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [14:54:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [14:56:21] (03CR) 10Aude: Introduce RendererFactory class for parser function (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [14:57:21] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Split parser function rendering and snaks finding code (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [14:57:33] (03PS1) 10Hoo man: Only try to insert TestSites if they aren't present already [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 [14:57:41] --^ fixes travis [14:57:50] hoo: so we don't forget: https://bugzilla.wikimedia.org/show_bug.cgi?id=68322 [14:58:01] ah good, yes [14:58:23] I looked very briefly at it and was like "WTF, how did this ever make sense" [14:59:09] (03CR) 10Aude: Split parser function rendering and snaks finding code (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [14:59:34] hoo: I can imagine.. there's code in there written by me in the beginning of April 2012.. ;) [14:59:45] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Only try to insert TestSites if they aren't present already (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 (owner: 10Hoo man) [15:00:32] :P [15:01:08] that's the file where everything started (at least the ui) [15:01:22] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "What's the other patch that should be merged before this so we don't accidentally create dumps with _no_ newlines?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148084 (owner: 10Hoo man) [15:02:14] (03CR) 10Hoo man: Only try to insert TestSites if they aren't present already (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 (owner: 10Hoo man) [15:03:34] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 (owner: 10Aude) [15:03:54] (03PS2) 10Hoo man: Clear test sites table before (re)inserting TestSites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 [15:06:01] (03CR) 10Hoo man: "The other patch is an operations one which I'll get merged after this change is live on Wikidata. That's a little hard to coordinate :S" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148084 (owner: 10Hoo man) [15:06:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Always add label for sitelink target on Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147863 (https://bugzilla.wikimedia.org/63485) (owner: 10Alex Monk) [15:07:00] (03Merged) 10jenkins-bot: Always add label for sitelink target on Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147863 (https://bugzilla.wikimedia.org/63485) (owner: 10Alex Monk) [15:07:52] // make it even harder to edit stuff, e.g. if someone is trying to be smart, using [15:07:52] // firebug to show hidden nodes again to click on them: [15:10:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f261d6e : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30464803 [15:11:45] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [15:17:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148065 (owner: 10Thiemo Mättig (WMDE)) [15:18:32] DanielK_WMDE: Bug created https://bugzilla.wikimedia.org/show_bug.cgi?id=68325 [15:18:59] thanks [15:22:25] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148068 (owner: 10Hoo man) [15:25:17] (03CR) 10Daniel Kinzler: "After thinking about this for a while, what we really want is a ChangeMulticaster implementing ChangeTransmitter, which would send the not" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [15:27:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148084 (owner: 10Hoo man) [15:28:04] this whole entity init stuff is so screwed [15:28:33] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/3fad5f0 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30466587 [15:31:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 (owner: 10Hoo man) [15:33:06] (03PS1) 10Hoo man: Fix triggering of 'restrictEntityPageActions' and 'blockEntityPageActions' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148093 (https://bugzilla.wikimedia.org/68322) [15:33:13] (03CR) 10Daniel Kinzler: [C: 04-1] "We definitely need a service interface for looking up labels and descriptions. But what exactly that interface should look like, especiall" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [15:34:05] (03PS2) 10Hoo man: Fix triggering of 'restrictEntityPageActions' and 'blockEntityPageActions' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148093 (https://bugzilla.wikimedia.org/68322) [15:43:02] (03PS2) 10Hoo man: Don't end JSON snippets with new lines [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148084 [15:43:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 (owner: 10Hoo man) [15:43:54] (03CR) 10Daniel Kinzler: [C: 04-1] "See comments. CR-1 mainly to mark this for discussion, it looks pretty good already." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [15:52:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148093 (https://bugzilla.wikimedia.org/68322) (owner: 10Hoo man) [15:57:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148093 (https://bugzilla.wikimedia.org/68322) (owner: 10Hoo man) [16:01:47] (03PS1) 10Aude: Introduce VariantsRenderer for property parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 [16:01:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148084 (owner: 10Hoo man) [16:06:24] (03CR) 10Daniel Kinzler: "Side note: please consider bug 68325." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [16:10:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [16:20:56] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Resolve redirects in EntityInfoBuilder (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [16:29:07] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I have no problem with making the unlocalizer aware of the genitive forms. But the change in the formatter is wrong in languages like Germ" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [16:33:12] (03CR) 10Aude: Split parser function rendering and snaks finding code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [16:33:16] (03PS3) 10Aude: Move more parser function rendering code to Renderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 [16:33:18] (03PS3) 10Aude: Remove unused constructor params from parser function Runner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148066 [16:33:20] (03PS6) 10Aude: Split parser function rendering and snaks finding code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 [16:33:22] (03PS2) 10Aude: Introduce VariantsRenderer for property parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 [16:33:24] (03PS1) 10Aude: Move more renderer construction code into RendererFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148103 [16:47:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 (owner: 10Aude) [16:50:18] [13DataValuesJavascript] 15JeroenDeDauw 04deleted 06globals at 1470d9a7f: 02http://git.io/CE0NcQ [16:54:13] [travis-ci] wmde/WikibaseQuery/importcli/3b5c881 : jeroendedauw The build was canceled. http://travis-ci.org/wmde/WikibaseQuery/builds/30418455 [16:58:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148066 (owner: 10Aude) [17:05:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [17:09:24] [13WikibaseQuery] 15JeroenDeDauw 04force-pushed 06importcli from 143b5c881 to 14cc11d35: 02http://git.io/pTiQzA [17:09:24] 13WikibaseQuery/06importcli 14cc11d35 15jeroendedauw: Use the latest version of the entity store. [17:09:35] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [17:09:58] (03Merged) 10jenkins-bot: Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [17:10:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [17:11:43] aude: aaaaah, y u long commit chain? [17:12:04] not #over9000 yet :) [17:12:28] :D [17:14:32] aude: you want over9000 stuck commits because the first one has a -1? [17:14:47] (03CR) 10Jeroen De Dauw: [C: 032] Introduce RendererFactory class for parser function (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [17:15:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148103 (owner: 10Aude) [17:15:51] hope not, but whatever [17:16:08] [travis-ci] wmde/WikibaseQuery/importcli/cc11d35 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/30478156 [17:21:56] (03PS1) 10Thiemo Mättig (WMDE): Make MonthNameUnlocalizer aware of genitive month names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 [17:24:39] (03PS1) 10Thiemo Mättig (WMDE): Drop unused parameter from MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148114 [17:31:16] (03PS4) 10Hoo man: Add empty badge icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [17:33:23] (03CR) 10Hoo man: [C: 032] "Looks fine :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [17:33:36] (03Merged) 10jenkins-bot: Add empty badge icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [17:34:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/093bcdc : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30478256 [17:34:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 (owner: 10Thiemo Mättig (WMDE)) [17:34:53] Thiemo_WMDE: https://gerrit.wikimedia.org/r/148087 [17:35:16] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Clear test sites table before (re)inserting TestSites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 (owner: 10Hoo man) [17:35:34] (03Merged) 10jenkins-bot: Clear test sites table before (re)inserting TestSites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148087 (owner: 10Hoo man) [17:37:08] (03PS1) 10Hoo man: Remove badges if a sitelink is being changed in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) [17:45:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148114 (owner: 10Thiemo Mättig (WMDE)) [17:47:08] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/fc358ac : Jeroen De Dauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30478681 [17:50:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [17:51:15] (03CR) 10Hoo man: [C: 04-1] "Looks good at first glance... one minor thing, though" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [17:54:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) (owner: 10Hoo man) [18:03:46] Question: changes like this (https://www.wikidata.org/w/index.php?title=Q17394537&diff=146381085&oldid=146380924) doesn't happen always. Is it because some users don't have a SUL? [18:04:09] (03PS1) 10Thiemo Mättig (WMDE): Refactor MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 [18:04:20] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7607aac : Thiemo Mättig The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30480276 [18:11:57] (03PS3) 10Thiemo Mättig (WMDE): Make ChangeNotifier an interface and introduce NullChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 [18:12:23] (03CR) 10Thiemo Mättig (WMDE): Make ChangeNotifier an interface and introduce NullChangeNotifier (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [18:12:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE)) [18:14:28] (03PS1) 10Aude: Move property id resolving code for parser function into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 [18:15:12] Thiemo, thanks for the review in https://gerrit.wikimedia.org/r/#/c/142519/. do you have a suggestion how to select the correct format based on the language? (in Ar/He/Uk... j xg Y is used, but in other languages such as De it is wrong) [18:16:07] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/73c35c1 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30480395 [18:16:32] (I see in .json of languages that there is 'january-date', 'february-date' etc which may give the correct form in different languages but I can't find anywhere where it is being really used [18:23:15] (03PS3) 10Thiemo Mättig (WMDE): Refactor ChangeNotifiers and weird "channel" concept [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148065 [18:23:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [18:28:44] (03CR) 10Jeroen De Dauw: Make ChangeNotifier an interface and introduce NullChangeNotifier (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [18:29:25] Thiemo_WMDE: ^ please check that, not an issue with your commit [18:29:31] But you merged the code introducing this interface [18:31:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [18:36:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148065 (owner: 10Thiemo Mättig (WMDE)) [18:43:04] (03CR) 10Eranroz: "see inline comment regarding the "correct format" for different languages." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [19:51:09] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148206 (owner: 10L10n-bot) [19:58:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c39e1d5 : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30491446 [20:37:15] (03PS7) 10Thiemo Mättig (WMDE): [WIP] Stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [20:37:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [20:38:42] JeroenDeDauw: overriding a method with an empty one isn't always an error. ;) [20:40:49] Thiemo_WMDE: haha, it'd have taken me a lot longer to find that probably ;p [20:41:14] always happy to help :) [20:45:46] (03PS8) 10Thiemo Mättig (WMDE): [WIP] Stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [20:48:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [20:48:42] * Jasper_Deng pokes multichill [20:48:54] If you have confirmed that your identity here is the same as your on-wiki identity [20:49:03] we can give you access to the admin channel [20:49:03] Jasper_Deng: I was just looking for my banhammer [20:49:43] multichill: I saw the PC comment; thanks for the EC :p [20:50:01] You want my personal computer to go to the European Commission? [20:50:09] edit conflict [20:50:35] Weird, mediawiki manages to survive to reverts since i started editing [20:51:43] Jasper_Deng: I generally don't do admin channels. I probably have access to several of them, but I already have too many channels open :P [20:54:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [21:02:10] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Tested, works, but found a mistake." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) (owner: 10Hoo man) [21:02:43] (03CR) 10Jeroen De Dauw: "Mostly looks good, though the binding in the test is unfortunate. Not opposed to merging this, though having a follow up fixing it would d" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [21:04:06] (03PS2) 10Hoo man: Remove badges if a sitelink is being changed in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) [21:04:25] (03CR) 10Hoo man: Remove badges if a sitelink is being changed in the UI (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) (owner: 10Hoo man) [21:04:54] (03CR) 10Hoo man: "Addressed Thiemo's comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) (owner: 10Hoo man) [21:08:14] (03CR) 10Aude: Split parser function rendering and snaks finding code (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [21:09:04] (03PS9) 10Jeroen De Dauw: Stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 [21:16:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) (owner: 10Hoo man) [21:19:34] (03CR) 10Jeroen De Dauw: [C: 032] Don't end JSON snippets with new lines [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148084 (owner: 10Hoo man) [21:19:53] hi [21:20:09] omg hi [21:21:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [21:22:02] (03CR) 10Jeroen De Dauw: [C: 032] "So you wrote the tests after the feature was completed and closed? ..." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [21:22:26] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Make ChangeNotifier an interface and introduce NullChangeNotifier (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [21:22:28] (03Merged) 10jenkins-bot: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [21:22:37] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/139610/ [21:26:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove badges if a sitelink is being changed in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) (owner: 10Hoo man) [21:26:35] (03Merged) 10jenkins-bot: Remove badges if a sitelink is being changed in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148117 (https://bugzilla.wikimedia.org/68155) (owner: 10Hoo man) [21:28:49] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [21:29:06] (03Merged) 10jenkins-bot: Stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [21:31:14] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4f41606 : Jeroen De Dauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30500048 [21:33:47] aude: Lydia_WMDE: http://dumps.wikimedia.org/other/wikidata/ \o/ [21:33:53] First json dump is there [21:34:04] it took longer and is larger than I thought, but it's there [21:34:19] can't verify it offhand, but I guess it's fine [21:35:12] \o/ :) [22:04:18] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/85b6dff : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30500280 [22:16:42] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/346a366 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30500586 [22:24:35] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1bc2be4 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30500813