[00:57:14] (03PS4) 10Hoo man: Specify the allowed badges as valid parameters for wbsetsitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150794 [01:05:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150794 (owner: 10Hoo man) [07:25:32] (03Draft2) 10Henning Snater: Using JS data model's Site and SiteLink objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 [07:33:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [07:39:04] (03PS3) 10Henning Snater: Using JS data model's Site and SiteLink objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 [07:46:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [09:34:12] (03PS1) 10Henning Snater: Fixed event handler management in wikibase.client.linkitem.init [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151047 [09:34:24] (03CR) 10jenkins-bot: [V: 04-1] Fixed event handler management in wikibase.client.linkitem.init [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151047 (owner: 10Henning Snater) [09:35:36] (03PS2) 10Henning Snater: Fixed event handler management in wikibase.client.linkitem.init [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151047 [09:45:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151047 (owner: 10Henning Snater) [09:49:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151047 (owner: 10Henning Snater) [10:00:31] (03PS1) 10WikidataBuilder: New Wikidata Build - 01/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151051 [10:03:45] (03PS4) 10Daniel Kinzler: Allow explicit keys for entities in API results. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150790 (https://bugzilla.wikimedia.org/45509) [10:03:49] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 01/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151051 (owner: 10WikidataBuilder) [10:13:30] [13ValueView] 15snaterlicious created 06suggestererror (+1 new commit): 02http://git.io/rRDnEQ [10:13:30] 13ValueView/06suggestererror 1412ee489 15snaterlicious: $.ui.suggester: Issue "error" event when gathering suggestions fails [10:14:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150790 (https://bugzilla.wikimedia.org/45509) (owner: 10Daniel Kinzler) [10:14:45] \o/ [10:14:47] jenkins is back! [10:15:03] \o/ [10:15:09] or rather: packagist talks to us again! [10:15:55] (03PS6) 10Daniel Kinzler: Resolve redirects in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) [10:16:03] (03PS2) 10Daniel Kinzler: Reduce the number of cases in GetEntitiesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150798 (https://bugzilla.wikimedia.org/68919) [10:16:09] (03PS3) 10Daniel Kinzler: Drop "sort" and "dir" options from GetEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150801 [10:16:52] [13ValueView] 15snaterlicious opened pull request #94: $.ui.suggester: Issue "error" event when gathering suggestions fails (06master...06suggestererror) 02http://git.io/sG6IRQ [10:17:13] (03PS2) 10Daniel Kinzler: Get tokens for testing API modules from User obj [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150802 [10:17:20] (03PS2) 10Daniel Kinzler: Make redirects non-experimental. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150847 (https://bugzilla.wikimedia.org/68851) [10:19:16] (03CR) 10Addshore: [C: 032] Reduce the number of cases in GetEntitiesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150798 (https://bugzilla.wikimedia.org/68919) (owner: 10Daniel Kinzler) [10:19:21] (03Merged) 10jenkins-bot: Reduce the number of cases in GetEntitiesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150798 (https://bugzilla.wikimedia.org/68919) (owner: 10Daniel Kinzler) [10:20:06] (03CR) 10Addshore: [C: 032] "No breaking change here. Having these params in requests will still return a result but will also return warnings!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150801 (owner: 10Daniel Kinzler) [10:20:11] (03Merged) 10jenkins-bot: Drop "sort" and "dir" options from GetEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150801 (owner: 10Daniel Kinzler) [10:21:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151051 (owner: 10WikidataBuilder) [10:28:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [10:39:16] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150798 (https://bugzilla.wikimedia.org/68919) (owner: 10Daniel Kinzler) [10:42:16] (03PS1) 10Daniel Kinzler: Do not use deprecated ApiMain::getFormats() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151054 [10:48:34] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150801 (owner: 10Daniel Kinzler) [10:53:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150802 (owner: 10Daniel Kinzler) [10:54:43] (03CR) 10Daniel Kinzler: [C: 032] Specify the allowed badges as valid parameters for wbsetsitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150794 (owner: 10Hoo man) [10:54:51] (03Merged) 10jenkins-bot: Specify the allowed badges as valid parameters for wbsetsitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150794 (owner: 10Hoo man) [10:58:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150847 (https://bugzilla.wikimedia.org/68851) (owner: 10Daniel Kinzler) [11:02:10] (03CR) 10Daniel Kinzler: ""RedirectToLinkedPage" is too technical imho: regular users may know about wiki redirects, but they don't know or care about http redirect" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [11:03:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151054 (owner: 10Daniel Kinzler) [11:08:27] (03CR) 10Hoo man: [C: 032] Get tokens for testing API modules from User obj [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150802 (owner: 10Daniel Kinzler) [11:08:36] (03Merged) 10jenkins-bot: Get tokens for testing API modules from User obj [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150802 (owner: 10Daniel Kinzler) [11:09:56] hoo, addshore: merge! merge! [11:10:02] * DanielK_WMDE does the happy dance [11:11:18] (03PS1) 10Hoo man: Remove unused WikibaseApiTestCase::getToken [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151057 [11:17:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151057 (owner: 10Hoo man) [11:18:31] (03CR) 10Hoo man: [C: 032] Do not use deprecated ApiMain::getFormats() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151054 (owner: 10Daniel Kinzler) [11:18:36] (03Abandoned) 10Addshore: New Wikidata Build - 30/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/150507 (owner: 10WikidataBuilder) [11:18:40] (03Merged) 10jenkins-bot: Do not use deprecated ApiMain::getFormats() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151054 (owner: 10Daniel Kinzler) [11:19:03] (03CR) 10Addshore: [C: 032] Remove unused WikibaseApiTestCase::getToken [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151057 (owner: 10Hoo man) [11:22:18] (03CR) 10Hoo man: [C: 032] "Can't harm :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151047 (owner: 10Henning Snater) [11:22:31] (03Merged) 10jenkins-bot: Fixed event handler management in wikibase.client.linkitem.init [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151047 (owner: 10Henning Snater) [11:25:25] Tobi_WMDE_SWE: My contract expired now, but I'm still going to finish putting the API js code into an own component [11:25:37] this weekend, hopefully [11:32:35] hoo: great! [11:32:38] thx [11:40:26] hoo: did the packagist issue just vanish yesterday or did you try some magic? [11:40:30] hoo: care to merge three more patches? that would complete my sprint :) [11:40:40] \o/ [11:40:44] Tobi_WMDE_SWE: No, it just went away [11:40:50] hoo: ok [11:40:54] DanielK_WMDE: I can do that [11:40:58] which means it will come back [11:41:07] yeah [11:41:35] hoo: I63f73533, Ica78bc830fed8, Ic5c4d211 [11:42:17] I mean we did not have that problem for over half a year now.. I hope we are back in WMF jenkins within the next half year [11:42:22] DanielK_WMDE: Did Lydia agree on making redirects non-exp. [11:42:45] hoo: yes, there's a sprint item for that. [11:42:49] ah ok [11:43:19] hoo: yes. it's in the sprint. [11:44:09] Tobi_WMDE_SWE: not quite true. packagist was down at least once before. but then it was really down, so people cared in fixed it. [11:44:25] this time, it was just not reachable for us. and nobody new why or what to do about it. [11:44:40] (03CR) 10Hoo man: [C: 032] Make redirects non-experimental. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150847 (https://bugzilla.wikimedia.org/68851) (owner: 10Daniel Kinzler) [11:44:46] true [11:44:50] (03Merged) 10jenkins-bot: Make redirects non-experimental. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150847 (https://bugzilla.wikimedia.org/68851) (owner: 10Daniel Kinzler) [11:54:54] (03CR) 10Hoo man: [C: 032] "Looks good, all usages replaced" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150790 (https://bugzilla.wikimedia.org/45509) (owner: 10Daniel Kinzler) [11:55:04] (03Merged) 10jenkins-bot: Allow explicit keys for entities in API results. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150790 (https://bugzilla.wikimedia.org/45509) (owner: 10Daniel Kinzler) [11:55:48] DanielK_WMDE: mh... noredirects... why not redirects and make it default to true? [11:56:12] hoo: because booleans cannot default to true in the API [11:56:43] because the api treated the param as true if it'S there, and false if it'S not there [11:56:49] so the default is always false. [11:57:30] hoo: from ApiBase: "Boolean parameters must default to false." [11:57:40] it sucks, i know [11:59:28] uh [11:59:29] ok [12:01:28] hoo: actually, hold on [12:01:42] i have an idea. i'll use an enum type: redirects=yes|no [12:01:46] that would be nicer. [12:01:50] certainly [12:02:13] but i can do that in a follow-up too. as you like. [12:02:20] off for lunch now, bbl [12:05:01] [13DataTypes] 15paladox2015 opened pull request #21: Update jquery.js (06master...06patch-2) 02http://git.io/4NYmKA [12:05:28] [13DataTypes] 15paladox2015 closed pull request #21: Update jquery.js (06master...06patch-2) 02http://git.io/4NYmKA [12:05:38] (03CR) 10Hoo man: [C: 04-1] "Looks good so far, except:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [12:19:43] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/Ue81TA [12:19:43] 13ValueView/06master 14ba9a8de 15thiemowmde: Merge pull request #94 from wmde/suggestererror... [12:33:45] (03PS6) 10JanZerebecki: Add go to linked page special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) [12:33:53] (03CR) 10jenkins-bot: [V: 04-1] Add go to linked page special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [12:35:43] (03CR) 10JanZerebecki: "PS6: rename from TitleByItem to GoToLinkedPage." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [12:39:05] (03PS7) 10Daniel Kinzler: Resolve redirects in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) [12:39:06] hoo: --^ [12:41:00] looks good, will have a more thorough look in a moment [12:43:41] (03PS7) 10JanZerebecki: Add go to linked page special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) [12:44:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [12:44:48] (03CR) 10JanZerebecki: "PS7: removing added newline at end of file to avoid the need for resolving a merge conflict" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [12:51:14] (03CR) 10Daniel Kinzler: "Some more nitpicks regarding documentation and naming. Would already be fine to merge though." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [12:51:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [12:56:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [12:58:11] Thiemo_WMDE: hoo: if possible, can you have a look at https://github.com/wmde/WikibaseDataModelJavascript/pull/11 please? [13:00:33] Tobi_WMDE_SWE: Commented [13:04:50] [13WikibaseQuery] 15thiemowmde created 06commands (+1 new commit): 02http://git.io/Xg38gQ [13:04:50] 13WikibaseQuery/06commands 14d00ea02 15Thiemo Mättig: Rearrange CLI command names [13:07:32] [travis-ci] wmde/WikibaseQuery/commands/d00ea02 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/31422812 [13:08:17] (03PS8) 10JanZerebecki: Add go to linked page special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) [13:08:26] (03CR) 10Anomie: Do not use deprecated ApiMain::getFormats() (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151054 (owner: 10Daniel Kinzler) [13:09:09] (03CR) 10JanZerebecki: "PS8: Adressed comments (documentation, method naming)." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [13:09:40] (03CR) 10Hoo man: Do not use deprecated ApiMain::getFormats() (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151054 (owner: 10Daniel Kinzler) [13:10:22] [13WikibaseQuery] 15thiemowmde opened pull request #48: Rearrange CLI command names (06master...06commands) 02http://git.io/SIBcWw [13:10:56] (03CR) 10Daniel Kinzler: "eek!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151054 (owner: 10Daniel Kinzler) [13:12:04] [travis-ci] wmde/WikibaseQueryEngine/commands/37caf0c : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/31422867 [13:12:31] (03PS1) 10Hoo man: Do not use deprecated ApiMain::getFormats() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151076 [13:12:45] DanielK_WMDE: https://gerrit.wikimedia.org/r/151076 [13:13:44] hoo: thanks. waiting for jenkins... [13:14:05] yeah :S [13:19:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [13:23:20] (03PS1) 10Daniel Kinzler: ApiWikibase: make fields private. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151077 [13:23:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151076 (owner: 10Hoo man) [13:24:08] (03CR) 10Daniel Kinzler: [C: 032] Do not use deprecated ApiMain::getFormats() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151076 (owner: 10Hoo man) [13:24:13] (03Merged) 10jenkins-bot: Do not use deprecated ApiMain::getFormats() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151076 (owner: 10Hoo man) [13:27:20] (03CR) 10Daniel Kinzler: [C: 032] Add go to linked page special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [13:27:33] (03Merged) 10jenkins-bot: Add go to linked page special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [13:28:23] Yay \o/ [13:28:34] jzerebecki: :D [13:29:56] that's what happens when you press ctrl + w in the wrong window :P [13:30:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151077 (owner: 10Daniel Kinzler) [13:33:56] [13ValueView] 15snaterlicious created 06suggesterlanguage (+1 new commit): 02http://git.io/Xo4Mng [13:33:56] 13ValueView/06suggesterlanguage 146e6911a 15snaterlicious: $.ui.suggester: Update menu language attributes when repositioning [13:35:24] jzerebecki: congrats :) [13:35:58] hoo: where you still going to look at wbgetentities, or should i try to bribe Thiemo_WMDE? [13:36:01] DanielK_WMDE: :) thx for the review [13:36:40] (03CR) 10Addshore: [C: 032] "As further cleanup you could probably remove the since tags from all the private fields." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151077 (owner: 10Daniel Kinzler) [13:36:49] (03Merged) 10jenkins-bot: ApiWikibase: make fields private. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151077 (owner: 10Daniel Kinzler) [13:37:58] DanielK_WMDE: Will do it [13:38:19] Sorting a lot of stuffs today... preparing for Wikimania and also other stuffs which shouldn't lay around till I'm back [13:39:03] [13ValueView] 15snaterlicious 04force-pushed 06suggesterlanguage from 146e6911a to 14b710b6a: 02http://git.io/S_iqpg [13:39:03] 13ValueView/06suggesterlanguage 14b710b6a 15snaterlicious: $.ui.suggester: Update menu language attributes when repositioning [13:40:19] [13ValueView] 15snaterlicious opened pull request #95: $.ui.suggester: Update menu language attributes when repositioning (06master...06suggesterlanguage) 02http://git.io/oG6lEA [13:46:59] :)# [13:47:30] (03CR) 10JanZerebecki: "Question regarding recursive redirects in the inline comments." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [13:50:09] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 as per Jan" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [13:50:52] (03CR) 10Hoo man: [C: 04-1] "Also what Jan says" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [13:51:50] (03Abandoned) 10Addshore: New Wikidata Build - 31/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/150780 (owner: 10WikidataBuilder) [13:54:20] (03CR) 10Hoo man: [C: 04-2] "As mentioned on github: Site object should not be in data model. It *should* be in core or an own extension (I prefer core)... having it i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [13:55:41] (03CR) 10Hoo man: [C: 032] "Makes sense" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150830 (owner: 10Jeroen De Dauw) [13:55:53] (03Merged) 10jenkins-bot: DM 1.0 compat: only call setClaims for entities that have the method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150830 (owner: 10Jeroen De Dauw) [13:56:24] (03PS2) 10Hoo man: DM 1.0 compat: do not use Claim::newFromArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150821 (owner: 10Jeroen De Dauw) [13:56:54] (03PS1) 10Daniel Kinzler: Some more cleanup in ApiWikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151080 [13:57:27] :) [13:59:47] [13WikibaseQuery] 15JeroenDeDauw comment on pull request #48 14d00ea02: As explained in my email to you, I think this is wrong 02http://git.io/Klj99w [14:04:31] (03PS8) 10Daniel Kinzler: Resolve redirects in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) [14:04:36] (03CR) 10jenkins-bot: [V: 04-1] Resolve redirects in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [14:05:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150821 (owner: 10Jeroen De Dauw) [14:06:35] (03CR) 10Hoo man: [C: 04-1] "1) Wikibase\Lib\Test\NoBadDependencyUsageTest::testNoClientUsageInLib" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150821 (owner: 10Jeroen De Dauw) [14:09:06] (03PS9) 10Daniel Kinzler: Resolve redirects in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) [14:09:13] More pair programming! https://www.youtube.com/watch?v=dYBjVTMUQY0 [14:09:16] hoo, jzerebecki: --^^ [14:12:56] DanielK_WMDE: Where did you address Jan's comment? [14:13:14] oh, doh [14:13:14] I see [14:13:18] * hoo hide [14:13:19] s [14:13:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151080 (owner: 10Daniel Kinzler) [14:14:22] (03CR) 10Addshore: [C: 032] Some more cleanup in ApiWikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151080 (owner: 10Daniel Kinzler) [14:15:06] DanielK_WMDE: mh... do we actually want to recursively resolve? [14:15:27] wait no, it sets the param to false [14:15:55] [13ValueView] 15thiemowmde closed pull request #95: $.ui.suggester: Update menu language attributes when repositioning (06master...06suggesterlanguage) 02http://git.io/oG6lEA [14:16:35] multitasking is bad :S [14:18:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [14:18:39] (03CR) 10Hoo man: "Why not use WikibaseApiTestCase::assertEntityEquals?" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [14:22:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [14:40:54] (03PS4) 10Henning Snater: Consolidated wikibase.Site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 [14:47:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [14:50:25] hoo: you might re-visit https://gerrit.wikimedia.org/r/#/c/150855/ [14:51:35] (03CR) 10Hoo man: "Architecture problems are (probably) gone now. Didn't yet find time to actually review." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [14:51:38] Tobi_WMDE_SWE: Done [14:52:26] is mr JeroenDeDauw around? [14:55:25] addshore: he's not round and not around :D [14:55:34] (03PS1) 10Thiemo Mättig (WMDE): Add more tests to MonthNameUnlocalizerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151090 [14:55:34] currently in a discussion [14:55:50] addshore: he's here, but afk [14:58:58] okay :) left him a pm! [14:59:22] and indeed Tobi_WMDE_SWE. I might try and mograte stuff into the time component a class at a time :P [14:59:36] especially as so much is changing the the classes on wikibase now [15:02:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151090 (owner: 10Thiemo Mättig (WMDE)) [15:05:52] (03PS10) 10Daniel Kinzler: Resolve redirects in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) [15:06:19] (03CR) 10Daniel Kinzler: Resolve redirects in wbgetentities. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [15:06:30] hoo: less evil dependencies --^ [15:07:18] ok, that make sense [15:08:09] (03CR) 10Hoo man: [C: 032] "Not depend on WikibaseApiTestCase is a good idea" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [15:08:16] (03Merged) 10jenkins-bot: Resolve redirects in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [15:12:18] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150623 (https://bugzilla.wikimedia.org/67031) (owner: 10Daniel Kinzler) [15:12:31] (03PS5) 10Henning Snater: Consolidated wikibase.Site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 [15:18:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [15:24:40] so DanielK_WMDE quick question about redirects (as I havnt looked at the code yet) :) [15:25:10] if I do getentites on Q12 and Q12 is a redirect to Q50 I will get a json entity with Q50 as a result correct? :) [15:25:36] but what happens if I try to add a label to Q12? Will it just edit Q50? :D [15:25:42] addshore: unless you set redirects=no [15:25:56] addshore: if you try to add a label to a redirect, it will fail [15:26:06] that reminds me: i should double check that this will fail *nicely* [15:26:18] hmm, okay [15:26:51] addshore: internally, the default EntityLookup will do redirect resolution, but the default EntityRevisionLookup will not [15:27:08] the idea is that if you request a specific revision, redirect resolution makes no sense. [15:27:28] also, EntityRevision is typically used as a basis of editing, and a redirect should never be the basis of an edit [15:27:32] okay, also whats the current method for creating a redirect? Will I be able to go back through the deletion log since the beginning of time and add in the redirects that should have been? [15:27:49] addshore: wbcreateredirect [15:27:54] *looks* :) [15:28:11] addshore: you can only create redirects by overwriting an existing but empty entity [15:28:26] the idea is to avoid stupid mistakes and silyl vandalism [15:28:28] I see. [15:30:06] addshore: you would have to undelete, then clear, then create the redirect. [15:30:17] for undeleting, your bot would need admin rights [15:30:29] that would probably work from most of them, I imagine some would not be able to be undeleted though [15:30:42] we *might* allow creating redirects from scratch, if the respective item was deleted. [15:31:13] addshore: because of conflicts? yea... if they weren't emtpied before deletion... that's actually annoying [15:31:14] might be nice, even if it needs an extra userright or something [15:31:49] DanielK_WMDE: indeed. I did some analysis of the deletion logs some time ago and it turns out (at the time) over 50% of deleted items say in the reason where they should be pointing :) [15:32:01] addshore: care to file a request? this seems sensible for our use case, even though "you can create a redirect over a deleted or empty entity" sounds kind of strange at first. [15:32:33] haha, I will do :) *adds to his list*. Final question, can double redirect occour? ;p [15:33:16] yes. If A redirects to B, you can still turn B into a redirect to C (but you can't create redirects pointing to A). [15:33:31] [= [15:33:37] douoble-redirects are not resolved, they will be treated like missing entities in most contexts [15:34:16] so if A points to B and B points to C and I ask for A it will appear missing? [15:34:21] yes [15:34:30] :/ [15:34:40] well, not if you load the page, then it will oook like a broken redirect, as it should [15:34:51] but wbgetentities will report it as missing [15:35:05] we could try to detect and automatically fix this situation... [15:35:05] Is there any plan to be able to fix such double redirects? [15:35:09] another feature request :) [15:35:23] you can fix them manually be overwriting A with a redirect to C [15:35:36] yup, definatly sounds like it needs to be done, otherwise Q123 redirecting to Q329141 might some day disappear :P [15:35:37] you mean, find and fix them automatically? in bulk? no plans, no [15:35:44] okay :) [15:35:54] yay [15:36:26] when are redirect due to be deployed? :P [15:36:40] it wouldn't really disappear though. but Q123 would be defunct if it was a redirect to a redirect [15:44:31] [13WikibaseQuery] 15thiemowmde 04force-pushed 06commands from 14d00ea02 to 143e51255: 02http://git.io/dqKnEw [15:44:31] 13WikibaseQuery/06commands 143e51255 15Thiemo Mättig: Rearrange CLI command names [15:50:47] (03PS1) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [15:51:33] (03PS2) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [15:59:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [16:02:36] (03PS8) 10Thiemo Mättig (WMDE): Introduce EntityContent::STATUS_UNTITLED [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 [16:06:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [16:08:42] (03PS1) 10Henning Snater: Fixed QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151100 [16:13:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [16:14:50] (03PS1) 10Thiemo Mättig (WMDE): Delete unused (badge) star icons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151101 [16:21:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151100 (owner: 10Henning Snater) [16:26:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151101 (owner: 10Thiemo Mättig (WMDE)) [16:51:33] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fixed QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151100 (owner: 10Henning Snater) [16:51:44] (03Merged) 10jenkins-bot: Fixed QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151100 (owner: 10Henning Snater) [16:53:07] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Doesn't help much since the dependency needs to be merged first, but gets this out of the way." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149004 (owner: 10Aude) [16:55:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Obvious change is obvious." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149002 (owner: 10Aude) [17:04:59] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks really good to me. Just one detail that can be improved further (either in this patch or later, doesn't matter)." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [17:07:53] Tobi_WMDE_SWE: Torturing Kai counts as "in discussion"? ;p [17:20:38] addshore: benestar|cloud: so you are now both official NyanData ambassadors to Wikiamnia, not a responsibility to take lightly [17:20:45] addshore: you are going to Wikiamnia right? [17:20:54] yup, I get there on tuesday =] [17:27:01] JeroenDeDauw: don't trust addshore :p [17:27:10] :O [17:32:42] !trust is https://dl.dropboxusercontent.com/u/7313450/entropy/abraham.jpg [17:32:42] Key was added [17:32:51] JohnLewis: only one person I trust [17:33:08] :D [17:33:21] * JeroenDeDauw realizes the really should find some picture of JohnLewis for great lulz [17:33:29] !trust | Abraham_WMDE [17:33:29] Abraham_WMDE: https://dl.dropboxusercontent.com/u/7313450/entropy/abraham.jpg [17:33:33] * JeroenDeDauw hides [17:34:21] JohnLewis: guess this is not you? http://colorlines.com/assets_c/2011/02/johnlewis-thumb-640xauto-2293.jpg [17:34:24] JeroenDeDauw: if anything, https://wikimedia.de/w/images.homepage/b/bd/Jeroen_DeDauw.jpg is a pretty cool picture :p [17:34:34] JeroenDeDauw: \o/ [17:34:43] overused picture now :p [17:35:14] :P [17:36:59] JohnLewis: that picture is bad. It does not convey this well enough https://dl.dropboxusercontent.com/u/7313450/entropy/teddy-bear.jpg [17:37:17] xD [17:37:56] DanielK_WMDE: Jenkins passes again - what was the issue? [17:38:21] JeroenDeDauw: nobody knows. it just recovered. [17:38:27] makes me think it will also fail again [17:39:11] JeroenDeDauw: oh, actually, we know why kenins failed: because composer couldn't load anything packagist [17:39:14] but we still have no idea why [17:39:36] this is not the first time a problem with packagist kileld our CI [17:39:43] we need to get rid of that single point of failure [17:43:34] DanielK_WMDE: you are very quick to blame packagist [17:44:13] JeroenDeDauw: i'm not sure it's the fault of their server. but i'm sure that us relying on them is a problem. [17:44:33] it's a single point of failure. whether the problem is their box, or our routing to them, or whatever, isn't relevant [17:45:27] it was curious. there was 10% to 20% packet loss between our jenkins instance and packagist.org. pinging other sites was fine. pinging packagist from other places was also fine. [17:45:30] no idea [17:45:50] or, well, one idea: they (or something in between) was throtteling packets. [17:45:54] DanielK_WMDE: jenkins is also a single point of failure, and its much less reliable than packagist [17:46:37] but we control it. so we can fix it. and we could/should run multiple instances (i.e. we should go back to using the foundation's setup) [17:46:55] also, when packagist was down in earnest a couple of months ago, that also killed travis and scrutenizer [17:47:32] JeroenDeDauw: i'm not saying we shouldn't use packagist. i'm saying we shouldn't rely on it being 100% available. [17:47:53] DanielK_WMDE: I will bet you we will have more downtime if we maintain this ourselves, and we'll defintily be sepnding more effort on it overall [17:48:02] the Ci needs to be more robust against service failure. this becomes increasingly important the more external services we use [17:48:19] JeroenDeDauw: maintain what ourselves? [17:49:26] my first idea was to set up a web proxy that caches whatever we load from packageist (or wherever) [17:50:01] that would be faster (depending on how often we need to check fro changes) and more robust (we could keep using the local copy) [17:50:56] JeroenDeDauw: anyway: as long as composer relies on a third pary service every time it runs, wmf jenkins will not use it. [17:51:14] that's not an immediate problem, but something to consider for the future [19:06:17] (03Draft1) 10Daniel Kinzler: Add simple logging to MockRepository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151144 [19:13:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151144 (owner: 10Daniel Kinzler) [19:19:25] (03PS1) 10Daniel Kinzler: Better handing for redirects in MockRepositors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 [19:26:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 (owner: 10Daniel Kinzler) [19:43:14] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151189 (owner: 10L10n-bot) [20:20:46] Hi. [20:21:28] Could anybody direct me to the discussion where Wiktionary guys talked about giving unique identifier to each meaning of each word ? [20:23:16] I mean that: ---> Bark - "Dog sound", "The body of the tree" <--- those two meaning should have identifiers... because now you are not sure which description would refer to the "Dog sound" and which to the "The body of the tree"... [20:24:21] The order isn't guaranteed. Anybody could change it to ---> Bark - "The body of the tree", "Dog sound" <--- [20:36:37] bluesm Wiktionary is not in the cross hairs of Wikidata for the foreseeable future (2 years) [20:37:24] GerardM-: What do you mean by "cross hairs" ? [20:37:25] there are two opportunities for this one theoretical and with no application to WIktionary.,. [20:37:55] lexical information is not considered for at least two years [20:38:22] the other is more practical and had Wiktionary in mind ... that one is OmegaWIki [20:39:03] GerardM-: I have trouble with understanding it you ... "here are two opportunities for this one theoretical and with no application to WIktionary.,." I'm unfortunately not the native english speaker :( [20:39:26] my native language is Dutch [20:40:07] GerardM-: But it seems that OmegaWIki haven't scraped data from Wiktionary unfortunately... [20:40:27] GerardM-: The definitions are different, and there seems to be less entries in OmegaWiki... [20:41:10] that would be rather difficult... what Wiktionary and for a given string how do you identify the meaning [21:03:00] aude: heya, ping on this patch https://github.com/wmde/WikibaseDataModel/commit/a0368552575eb2c96f0c9b702c7984658afd2463 do you think it could be deployed soon-ish? Aaron is saying that it is spamming the logs. [21:03:07] aude: the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=65698 [21:04:48] Lydia_WMDE ^ worth you taking a peek at that too [21:11:24] thanks JohnLewis [21:12:09] welcome greg-g :p [21:21:20] > Oppose: until wikidata is brought online... [21:21:26] <3 enwp [21:29:41] legoktm: where? :p [21:36:31] legoktm: oh found it xD