[10:00:26] (03PS1) 10WikidataBuilder: New Wikidata Build - 16/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154393 [10:17:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154393 (owner: 10WikidataBuilder) [10:24:03] (03PS9) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [10:26:39] (03PS10) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [10:29:43] (03PS4) 10Henning Snater: Refactored $.wikibase.toolbar* test definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 [10:31:47] (03PS8) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [10:32:50] (03PS3) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [10:34:34] (03PS6) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [10:45:44] (03PS7) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [10:51:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [11:09:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [11:23:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 (owner: 10Henning Snater) [11:31:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [11:39:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [11:48:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [11:56:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [12:25:51] hey :) [12:41:18] (03CR) 10Bene: [C: 04-1] "Reviewed my own code ^^" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154261 (owner: 10Bene) [15:08:04] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Decrease specificity in badge css selectors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154325 (owner: 10Bene) [15:08:12] (03Merged) 10jenkins-bot: Decrease specificity in badge css selectors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154325 (owner: 10Bene) [15:32:58] (03PS3) 10Thiemo Mättig (WMDE): Better handing for redirects in MockRepositors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 (owner: 10Daniel Kinzler) [15:47:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 (owner: 10Daniel Kinzler) [15:48:43] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I wonder. All places that are using this function currently check if it returns nothing and have a case-by-case fallback for this. This ch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [15:57:30] (03CR) 10Thiemo Mättig (WMDE): "You should really install PHPStorm. :-)" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [15:58:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Better handing for redirects in MockRepositors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 (owner: 10Daniel Kinzler) [15:58:15] (03Merged) 10jenkins-bot: Better handing for redirects in MockRepositors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 (owner: 10Daniel Kinzler) [16:06:01] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I'm not at all opposed to this but I wonder. Almost all these factory methods are called via:" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler) [16:10:31] (03CR) 10Thiemo Mättig (WMDE): "I don't think it's necessary to backport this. It's just a little inconvenience in my opinion. But I don't have a strong argument to block" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154279 (https://bugzilla.wikimedia.org/69608) (owner: 10Aude) [16:11:27] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Use consistently window.location.href instead of location.href [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154305 (owner: 10Gerrit Patch Uploader) [16:11:41] (03Merged) 10jenkins-bot: Use consistently window.location.href instead of location.href [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154305 (owner: 10Gerrit Patch Uploader) [16:16:14] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Good change, thanks. I would like to +2 this but found a tiny detail." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 (owner: 10Henning Snater) [16:18:28] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Improves readability, makes sense. Cool." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152021 (owner: 10Henning Snater) [16:24:43] (03Draft4) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [16:24:48] (03Draft6) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [16:25:01] (03Draft1) 10Henning Snater: Moved initializing basic entity widgets to entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 [16:25:05] (03Draft1) 10Henning Snater: Optimized copyright tooltip logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 [16:25:46] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "The code that used these variables was removed in change Ibb6ee84." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153712 (owner: 10Jeroen De Dauw) [16:25:53] (03Merged) 10jenkins-bot: Remove some presumably dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153712 (owner: 10Jeroen De Dauw) [16:28:37] (03PS11) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [16:28:45] (03PS4) 10Henning Snater: Allow listview items to have node names other than DIV [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151860 [16:28:49] (03PS4) 10Henning Snater: Removed alternating css classes from site links table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152008 [16:28:54] (03PS4) 10Henning Snater: Removed alternating css classes from term box table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152009 [16:28:58] (03PS4) 10Henning Snater: Allow toolbarcontroller definition to accept null selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152010 [16:29:02] (03PS5) 10Henning Snater: Added $container option to $.wikibase.toolbarbase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152016 [16:29:07] (03PS5) 10Henning Snater: Refactored $.wikibase.toolbar* test definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 [16:29:12] (03PS4) 10Henning Snater: Optimized edittoolbar retrieving parent widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152021 [16:29:16] (03PS5) 10Henning Snater: Improved $.wikibase.siteselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152038 [16:29:20] (03PS4) 10Henning Snater: Added badge template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 [16:32:54] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Allow toolbarcontroller definition to accept null selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152010 (owner: 10Henning Snater) [16:36:34] (03PS9) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [16:36:43] (03PS4) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [16:36:46] (03PS4) 10Henning Snater: Optimized jQuery.wikibase.sitelinkview.isInitialValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 [16:36:51] (03PS2) 10Henning Snater: Propagating editable state in SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 [16:36:55] (03PS4) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [16:36:58] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Allow listview items to have node names other than DIV [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151860 (owner: 10Henning Snater) [16:37:01] (03PS8) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [16:37:05] (03PS3) 10Henning Snater: Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 [16:40:50] (03PS5) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [16:41:01] (03PS7) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [16:41:07] (03PS2) 10Henning Snater: Moved initializing basic entity widgets to entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 [16:41:11] (03PS2) 10Henning Snater: Optimized copyright tooltip logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 [16:42:50] (03PS2) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [16:51:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [17:08:17] (03PS1) 10Henning Snater: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 [17:09:19] (03PS3) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [17:14:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 (owner: 10Henning Snater) [17:37:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 (owner: 10Henning Snater) [18:04:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 (owner: 10Henning Snater) [18:27:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [18:50:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151860 (owner: 10Henning Snater) [19:06:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152008 (owner: 10Henning Snater) [19:20:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152009 (owner: 10Henning Snater) [19:36:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152010 (owner: 10Henning Snater) [20:06:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 (owner: 10Henning Snater) [20:16:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152021 (owner: 10Henning Snater) [20:24:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152038 (owner: 10Henning Snater) [20:32:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 (owner: 10Henning Snater) [20:40:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [20:47:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [20:55:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 (owner: 10Henning Snater) [21:04:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 (owner: 10Henning Snater) [21:12:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [21:20:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [21:28:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [21:36:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [21:44:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 (owner: 10Henning Snater) [21:53:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 (owner: 10Henning Snater) [22:01:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 (owner: 10Henning Snater) [22:10:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [22:18:06] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 (owner: 10Henning Snater) [22:25:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater)