[07:58:55] (03PS17) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [07:58:55] (03PS17) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [08:05:26] (03PS1) 10Henning Snater: Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 [08:05:26] (03PS1) 10Henning Snater: Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 [08:13:38] (03PS2) 10Henning Snater: Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 [08:13:38] (03PS2) 10Henning Snater: Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 [08:15:32] (03PS8) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [08:15:32] (03PS8) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [08:16:39] (03PS9) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [08:16:39] (03PS9) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [08:22:54] (03PS3) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [08:22:54] (03PS3) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [08:29:05] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=70415 [08:29:05] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=70415 [08:29:24] do you know easy fix for that? or how we best fix? [08:29:24] do you know easy fix for that? or how we best fix? [08:31:54] (03CR) 10Tobias Gritschacher: [C: 032] Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [08:31:54] (03CR) 10Tobias Gritschacher: [C: 032] Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [08:32:09] (03CR) 10Tobias Gritschacher: [C: 032] Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 (owner: 10Henning Snater) [08:32:09] (03CR) 10Tobias Gritschacher: [C: 032] Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 (owner: 10Henning Snater) [08:32:24] (03CR) 10Tobias Gritschacher: [C: 032] Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 (owner: 10Henning Snater) [08:32:24] (03CR) 10Tobias Gritschacher: [C: 032] Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 (owner: 10Henning Snater) [08:32:37] (03CR) 10Tobias Gritschacher: [C: 032] Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 (owner: 10Henning Snater) [08:32:37] (03CR) 10Tobias Gritschacher: [C: 032] Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 (owner: 10Henning Snater) [08:32:52] (03CR) 10Tobias Gritschacher: [C: 032] Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 (owner: 10Henning Snater) [08:32:52] (03CR) 10Tobias Gritschacher: [C: 032] Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 (owner: 10Henning Snater) [08:36:56] aude: The easiest fix would be to just re-implement what has been removed in https://gerrit.wikimedia.org/r/#/c/151854/7/lib/resources/wikibase.RepoApi/wikibase.RepoApi.js ... [08:36:56] aude: The easiest fix would be to just re-implement what has been removed in https://gerrit.wikimedia.org/r/#/c/151854/7/lib/resources/wikibase.RepoApi/wikibase.RepoApi.js ... [08:37:04] hmmm, ok [08:37:04] hmmm, ok [08:43:14] (03Merged) 10jenkins-bot: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [08:43:14] (03Merged) 10jenkins-bot: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [08:43:42] Henning_WMDE: aude: so, should we then just try reverting the change until we found a solution to do it better? [08:43:42] Henning_WMDE: aude: so, should we then just try reverting the change until we found a solution to do it better? [08:44:07] No, it's a simple patch. [08:44:07] No, it's a simple patch. [08:44:07] (03Merged) 10jenkins-bot: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 (owner: 10Henning Snater) [08:44:07] (03Merged) 10jenkins-bot: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 (owner: 10Henning Snater) [08:44:09] (03Merged) 10jenkins-bot: Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 (owner: 10Henning Snater) [08:44:09] (03Merged) 10jenkins-bot: Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 (owner: 10Henning Snater) [08:44:11] Tobi_WMDE_away: i tried and was getting error [08:44:11] Tobi_WMDE_away: i tried and was getting error [08:44:31] might be i did something wrong [08:44:31] might be i did something wrong [08:44:53] ok, if it is simple to solve then let's do it [08:44:53] ok, if it is simple to solve then let's do it [08:45:06] and in worst case try the revert [08:45:06] and in worst case try the revert [08:45:11] Basically, I will rewind to patch set 3 of https://gerrit.wikimedia.org/r/#/c/151854 [08:45:11] Basically, I will rewind to patch set 3 of https://gerrit.wikimedia.org/r/#/c/151854 [08:45:38] alright [08:45:38] alright [08:45:43] looks good [08:45:43] looks good [08:49:38] ah, actually, no, it's patch set 1... [08:49:38] ah, actually, no, it's patch set 1... [08:49:53] ok [08:49:53] ok [08:52:44] (03Merged) 10jenkins-bot: Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 (owner: 10Henning Snater) [08:52:44] (03Merged) 10jenkins-bot: Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 (owner: 10Henning Snater) [08:52:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9acc1bc : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34474883 [08:52:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9acc1bc : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34474883 [08:54:57] (03Merged) 10jenkins-bot: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 (owner: 10Henning Snater) [08:54:57] (03Merged) 10jenkins-bot: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 (owner: 10Henning Snater) [08:57:34] (03PS1) 10Henning Snater: Revert RepoApi to explicitly query for token [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 [08:57:34] (03PS1) 10Henning Snater: Revert RepoApi to explicitly query for token [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 [08:57:51] aude: Tobi_WMDE_SWE ^ [08:57:51] aude: Tobi_WMDE_SWE ^ [09:00:58] it's probably me but i get "the external client site did not provide page information" [09:00:58] it's probably me but i get "the external client site did not provide page information" [09:01:02] investigating [09:01:02] investigating [09:03:49] aude: hi, if you see amir1 please let him know he.wiki css and js issues are resolved [09:03:49] aude: hi, if you see amir1 please let him know he.wiki css and js issues are resolved [09:03:57] matanya: ok [09:03:57] matanya: ok [09:05:51] ACTION made a bad page that does exist on enwiki [09:05:51] * aude made a bad page that does exist on enwiki [09:06:18] (03PS6) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [09:06:18] (03PS6) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [09:06:30] (03CR) 10jenkins-bot: [V: 04-1] Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [09:06:30] (03CR) 10jenkins-bot: [V: 04-1] Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [09:09:41] (03CR) 10Aude: [C: 031] "works for me on client + repo and looks sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 (owner: 10Henning Snater) [09:09:41] (03CR) 10Aude: [C: 031] "works for me on client + repo and looks sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 (owner: 10Henning Snater) [09:09:46] Tobi_WMDE_SWE: Henning_WMDE [09:09:46] Tobi_WMDE_SWE: Henning_WMDE [09:09:56] Tobi_WMDE_SWE: if you want to review, else i give +2 [09:09:56] Tobi_WMDE_SWE: if you want to review, else i give +2 [09:10:14] aude: give me one moment [09:10:14] aude: give me one moment [09:10:18] ok [09:10:18] ok [09:10:44] (03CR) 10Tobias Gritschacher: [C: 032] Refactor SpecialMergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [09:10:44] (03CR) 10Tobias Gritschacher: [C: 032] Refactor SpecialMergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [09:18:31] aude: Henning_WMDE: the add-sitelink widget on the client is not working for me (with that change). I'm getting "The external client site did not provide page information (The external client site did not provide page information for site 'enwiki')", but I choose dewiki as language [09:18:31] aude: Henning_WMDE: the add-sitelink widget on the client is not working for me (with that change). I'm getting "The external client site did not provide page information (The external client site did not provide page information for site 'enwiki')", but I choose dewiki as language [09:18:48] is that broken or am I doing something wrong? [09:18:48] is that broken or am I doing something wrong? [09:18:58] I know it worked in the past [09:18:58] I know it worked in the past [09:19:00] Tobi_WMDE_SWE: doing somethign wrong [09:19:00] Tobi_WMDE_SWE: doing somethign wrong [09:19:11] hehe [09:19:11] hehe [09:19:12] did you provide a 'valid' page [09:19:12] did you provide a 'valid' page [09:19:18] yes [09:19:18] yes [09:19:22] hmmm [09:19:22] hmmm [09:19:24] a valid page on dewiki [09:19:24] a valid page on dewiki [09:19:36] choosen from the suggester [09:19:36] choosen from the suggester [09:19:45] Tobi_WMDE_SWE: \o/ [09:19:45] Tobi_WMDE_SWE: \o/ [09:20:00] the error msg is odd: it says it does not find the page on ENwiki [09:20:00] the error msg is odd: it says it does not find the page on ENwiki [09:20:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a7f3d40 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34475573 [09:20:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a7f3d40 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34475573 [09:20:16] (03Merged) 10jenkins-bot: Refactor SpecialMergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [09:20:16] (03Merged) 10jenkins-bot: Refactor SpecialMergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [09:20:35] aude: so I can't test it really [09:20:35] aude: so I can't test it really [09:21:37] :( [09:21:37] :( [09:21:46] cache? [09:21:46] cache? [09:23:06] omg, beta is very broken [09:23:06] omg, beta is very broken [09:24:57] http://bits.beta.wmflabs.org/static-master/resources/src/jquery/jquery.placeholder.js [09:24:57] http://bits.beta.wmflabs.org/static-master/resources/src/jquery/jquery.placeholder.js [09:24:59] (03PS7) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [09:24:59] (03PS7) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [09:25:00] das ist verboten [09:25:00] das ist verboten [09:25:13] (03PS2) 10Henning Snater: Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 [09:25:13] (03PS2) 10Henning Snater: Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 [09:25:22] aude: o_O [09:25:22] aude: o_O [09:27:00] (03PS4) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [09:27:00] (03PS4) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [09:27:05] (03PS8) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [09:27:05] (03PS8) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [09:30:37] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/85edb0b : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34475694 [09:30:37] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/85edb0b : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34475694 [09:30:41] oh noes http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:UserLogin&returnto=0.23807060083400589+Moved [09:30:41] oh noes http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:UserLogin&returnto=0.23807060083400589+Moved [09:35:54] Tobi_WMDE_SWE: i propose to take https://bugzilla.wikimedia.org/show_bug.cgi?id=57745 for the next sprint. you just merged the last blocker for this :) [09:35:54] Tobi_WMDE_SWE: i propose to take https://bugzilla.wikimedia.org/show_bug.cgi?id=57745 for the next sprint. you just merged the last blocker for this :) [09:40:20] (03PS1) 10Henning Snater: Optimized applying wb-empty class in label/descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158606 [09:40:20] (03PS1) 10Henning Snater: Optimized applying wb-empty class in label/descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158606 [09:42:15] Tobi_WMDE_SWE: for the widget error, we can have it on master [09:42:15] Tobi_WMDE_SWE: for the widget error, we can have it on master [09:42:20] then see it works on beta [09:42:20] then see it works on beta [09:47:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9bf8aeb : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34477525 [09:47:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9bf8aeb : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34477525 [10:00:27] (03PS1) 10WikidataBuilder: New Wikidata Build - 05/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 [10:00:27] (03PS1) 10WikidataBuilder: New Wikidata Build - 05/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 [10:04:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 (owner: 10WikidataBuilder) [10:04:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 (owner: 10WikidataBuilder) [10:08:58] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 05/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 (owner: 10WikidataBuilder) [10:08:58] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 05/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 (owner: 10WikidataBuilder) [10:10:51] (03CR) 10Aude: [C: 032] Revert RepoApi to explicitly query for token [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 (owner: 10Henning Snater) [10:10:51] (03CR) 10Aude: [C: 032] Revert RepoApi to explicitly query for token [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 (owner: 10Henning Snater) [10:18:48] Tobi_WMDE_SWE: i tagged the property suggester as 1.1.2 so it gets in the build [10:18:48] Tobi_WMDE_SWE: i tagged the property suggester as 1.1.2 so it gets in the build [10:18:55] for define( 'PropertySuggester_VERSION', '1.1.1 alpha' ); what do i put as version ? [10:18:55] for define( 'PropertySuggester_VERSION', '1.1.1 alpha' ); what do i put as version ? [10:19:02] 1.1.2 alpha ? [10:19:02] 1.1.2 alpha ? [10:19:09] or 1.1.3 ? [10:19:09] or 1.1.3 ? [10:19:12] alpha [10:19:12] alpha [10:19:21] after the tag or for the tag? [10:19:21] after the tag or for the tag? [10:19:25] aude? [10:19:25] aude? [10:19:45] after you tagged, it should be changed to 1.1.3 alpha [10:19:45] after you tagged, it should be changed to 1.1.3 alpha [10:19:52] for the tag it should be 1.1.2 [10:19:52] for the tag it should be 1.1.2 [10:20:15] ok [10:20:15] ok [10:20:20] (03Merged) 10jenkins-bot: Revert RepoApi to explicitly query for token [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 (owner: 10Henning Snater) [10:20:20] (03Merged) 10jenkins-bot: Revert RepoApi to explicitly query for token [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158599 (owner: 10Henning Snater) [10:31:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f60a2d3 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34481871 [10:31:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f60a2d3 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34481871 [10:33:38] Tobi_WMDE_SWE: https://github.com/Wikidata-lib/PropertySuggester/pull/98 [10:33:38] Tobi_WMDE_SWE: https://github.com/Wikidata-lib/PropertySuggester/pull/98 [10:49:06] aude: I saw the log and I started my bot [10:49:06] aude: I saw the log and I started my bot [10:49:14] matanya: if you're here :) ^ [10:49:14] matanya: if you're here :) ^ [10:51:20] (03PS9) 10Bene: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 [10:51:20] (03PS9) 10Bene: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 [11:06:26] [13ValueView] 15snaterlicious pushed 1 new commit to 06actionhandling: 02http://git.io/FE0tpg [11:06:26] [13ValueView] 15snaterlicious pushed 1 new commit to 06actionhandling: 02http://git.io/FE0tpg [11:06:26] 13ValueView/06actionhandling 14c1ff89e 15snaterlicious: Re-apply "click" event to html [11:06:26] 13ValueView/06actionhandling 14c1ff89e 15snaterlicious: Re-apply "click" event to html [11:25:45] Amir1: :) [11:25:46] Amir1: :) [11:26:35] I almost finished removing them in these wikis: fa,de, en, sv, pl, nl, tg, ckb, [11:26:35] I almost finished removing them in these wikis: fa,de, en, sv, pl, nl, tg, ckb, [11:29:35] \o/ [11:29:35] \o/ [11:30:25] (03Abandoned) 10Aude: New Wikidata Build - 05/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 (owner: 10WikidataBuilder) [11:30:25] (03Abandoned) 10Aude: New Wikidata Build - 05/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158607 (owner: 10WikidataBuilder) [11:31:55] (03PS10) 10Bene: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 [11:31:55] (03PS10) 10Bene: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 [11:32:14] Lydia_WMDE: hey :D [11:32:14] Lydia_WMDE: hey :D [11:32:48] benestar: she is on holiday [11:32:48] benestar: she is on holiday [11:32:56] oh :O [11:32:56] oh :O [11:33:21] maybe responds to emails or is on irc at some point [11:33:21] maybe responds to emails or is on irc at some point [11:34:05] (03CR) 10Legoktm: "Does this fix bug 46358?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [11:34:05] (03CR) 10Legoktm: "Does this fix bug 46358?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [11:34:10] well, nothing urgent ;) [11:34:10] well, nothing urgent ;) [11:34:15] ok [11:34:15] ok [11:42:06] (03CR) 10Daniel Kinzler: Put other project links in parser cache (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [11:42:06] (03CR) 10Daniel Kinzler: Put other project links in parser cache (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [11:47:14] (03PS10) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [11:47:15] (03PS10) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [11:51:41] Henning_WMDE: http://da.wikipedia.org/w/index.php?title=Speciel%3AS%C3%B8gning&profile=default&search=Copenhagen&fulltext=Search [11:51:41] Henning_WMDE: http://da.wikipedia.org/w/index.php?title=Speciel%3AS%C3%B8gning&profile=default&search=Copenhagen&fulltext=Search [11:56:44] (03CR) 10Aude: Put other project links in parser cache (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [11:56:44] (03CR) 10Aude: Put other project links in parser cache (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [11:57:18] (03PS4) 10Aude: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) [11:57:18] (03PS4) 10Aude: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) [12:05:38] Henning_WMDE: rebase? https://gerrit.wikimedia.org/r/#/c/158354/ [12:05:38] Henning_WMDE: rebase? https://gerrit.wikimedia.org/r/#/c/158354/ [12:06:02] Henning_WMDE: nevermind, worked [12:06:02] Henning_WMDE: nevermind, worked [12:07:24] (03PS3) 10Tobias Gritschacher: Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 (owner: 10Henning Snater) [12:07:24] (03PS3) 10Tobias Gritschacher: Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 (owner: 10Henning Snater) [12:11:18] (03PS5) 10Tobias Gritschacher: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 (owner: 10Henning Snater) [12:11:18] (03PS5) 10Tobias Gritschacher: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 (owner: 10Henning Snater) [12:18:49] (03CR) 10Daniel Kinzler: [C: 032] "Works as designed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [12:18:49] (03CR) 10Daniel Kinzler: [C: 032] "Works as designed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [12:24:20] (03PS9) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [12:24:20] (03PS9) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [12:29:43] (03PS10) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [12:29:43] (03PS10) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [12:29:46] (03CR) 10Daniel Kinzler: Put other project links in parser cache (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [12:29:46] (03CR) 10Daniel Kinzler: Put other project links in parser cache (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [12:35:36] (03CR) 10Tobias Gritschacher: [C: 032] Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 (owner: 10Henning Snater) [12:35:36] (03CR) 10Tobias Gritschacher: [C: 032] Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 (owner: 10Henning Snater) [12:35:36] (03Merged) 10jenkins-bot: Don't use SkinBuildSidebar hook for other projects feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [12:35:36] (03Merged) 10jenkins-bot: Don't use SkinBuildSidebar hook for other projects feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [12:44:26] (03PS3) 10Bene: Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 [12:44:26] (03PS3) 10Bene: Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 [12:44:27] (03CR) 10jenkins-bot: [V: 04-1] Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 (owner: 10Bene) [12:44:27] (03CR) 10jenkins-bot: [V: 04-1] Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 (owner: 10Bene) [12:44:31] (03CR) 10Daniel Kinzler: [C: 031] "Looks pretty good, just a few thoughts/questions." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [12:44:31] (03CR) 10Daniel Kinzler: [C: 031] "Looks pretty good, just a few thoughts/questions." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [12:44:31] (03CR) 10Daniel Kinzler: "@legoktm: it should, but i have not verified." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [12:44:31] (03CR) 10Daniel Kinzler: "@legoktm: it should, but i have not verified." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [12:44:33] (03CR) 10jenkins-bot: [V: 04-1] Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 (owner: 10Henning Snater) [12:44:33] (03CR) 10jenkins-bot: [V: 04-1] Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 (owner: 10Henning Snater) [12:44:34] (03PS5) 10Aude: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) [12:44:34] (03PS5) 10Aude: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) [12:44:45] Tobi_WMDE_SWE: can we have selenium tests for the other projects feature? [12:44:45] Tobi_WMDE_SWE: can we have selenium tests for the other projects feature? [12:45:03] :D [12:45:03] :D [12:45:07] if someone writes them [12:45:07] if someone writes them [12:45:10] i don't know if i can help with that and would also help if beta was not broken all the time [12:45:10] i don't know if i can help with that and would also help if beta was not broken all the time [12:45:10] (also for the widget) [12:45:10] (also for the widget) [12:45:39] if beta was unbroken I would have finished the smoke test for an item [12:45:39] if beta was unbroken I would have finished the smoke test for an item [12:45:53] which is the most important thing at the moment [12:45:53] which is the most important thing at the moment [12:46:04] (03PS4) 10Bene: Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 [12:46:04] (03PS4) 10Bene: Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 [12:46:06] would catch most of the breakage [12:46:06] would catch most of the breakage [12:47:27] aude: that feature is only available at a client, correct? [12:47:27] aude: that feature is only available at a client, correct? [12:53:31] Tobi_WMDE_SWE: indeed [12:53:31] Tobi_WMDE_SWE: indeed [12:54:20] these should work on beta, as long as beta works [12:54:20] these should work on beta, as long as beta works [12:54:57] (03CR) 10Daniel Kinzler: [C: 032] Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [12:54:57] (03CR) 10Daniel Kinzler: [C: 032] Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [12:54:57] (03CR) 10jenkins-bot: [V: 04-1] Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [12:54:57] (03CR) 10jenkins-bot: [V: 04-1] Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [12:54:58] (03CR) 10jenkins-bot: [V: 04-1] Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 (owner: 10Bene) [12:54:58] (03CR) 10jenkins-bot: [V: 04-1] Refactor EntityParserOutput out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 (owner: 10Bene) [12:57:54] (03CR) 10Tobias Gritschacher: [C: 032] Implemented sitelinkgrouplistview (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 (owner: 10Henning Snater) [12:57:54] (03CR) 10Tobias Gritschacher: [C: 032] Implemented sitelinkgrouplistview (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 (owner: 10Henning Snater) [13:00:14] (03PS6) 10Aude: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) [13:00:14] (03PS6) 10Aude: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) [13:13:48] (03Merged) 10jenkins-bot: Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 (owner: 10Henning Snater) [13:13:48] (03Merged) 10jenkins-bot: Removed obsolete value supplement template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158595 (owner: 10Henning Snater) [13:13:52] (03Merged) 10jenkins-bot: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 (owner: 10Henning Snater) [13:13:52] (03Merged) 10jenkins-bot: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 (owner: 10Henning Snater) [13:23:16] aude: DanielK_WMDE: could you probably also give https://github.com/wmde/WikibaseDataModel/pull/182 a quick glance? [13:23:16] aude: DanielK_WMDE: could you probably also give https://github.com/wmde/WikibaseDataModel/pull/182 a quick glance? [13:27:41] Tobi_WMDE_SWE: looking [13:27:41] Tobi_WMDE_SWE: looking [13:28:48] done [13:28:48] done [13:29:00] [13WikibaseDataModel] 15filbertkm closed pull request #182: Add StatementList field to Property (06master...06propstatements) 02http://git.io/qRc0bw [13:29:00] [13WikibaseDataModel] 15filbertkm closed pull request #182: Add StatementList field to Property (06master...06propstatements) 02http://git.io/qRc0bw [13:29:10] [13WikibaseDataModel] 15filbertkm 04deleted 06propstatements at 143854fa0: 02http://git.io/-c4Z4w [13:29:10] [13WikibaseDataModel] 15filbertkm 04deleted 06propstatements at 143854fa0: 02http://git.io/-c4Z4w [13:29:40] aude: \o/ [13:29:40] aude: \o/ [13:34:40] aude: you uploaded a new patchset after the +2? https://gerrit.wikimedia.org/r/#/c/158381/ [13:34:40] aude: you uploaded a new patchset after the +2? https://gerrit.wikimedia.org/r/#/c/158381/ [13:34:43] :) [13:34:43] :) [13:43:10] Tobi_WMDE_SWE: because jenkins says no [13:43:10] Tobi_WMDE_SWE: because jenkins says no [13:43:25] ok [13:43:25] ok [13:43:26] :) [13:43:26] :) [13:43:28] still? [13:43:28] still? [13:44:46] aude: DanielK_WMDE can https://bugzilla.wikimedia.org/show_bug.cgi?id=70234 and https://bugzilla.wikimedia.org/show_bug.cgi?id=70393 be closed then? [13:44:46] aude: DanielK_WMDE can https://bugzilla.wikimedia.org/show_bug.cgi?id=70234 and https://bugzilla.wikimedia.org/show_bug.cgi?id=70393 be closed then? [13:59:03] Tobi_WMDE_SWE: yes, fixed. not sure what it would take to set them to verified. [13:59:03] Tobi_WMDE_SWE: yes, fixed. not sure what it would take to set them to verified. [14:00:59] DanielK_WMDE: I guess we just verify it when it is deployed and working [14:00:59] DanielK_WMDE: I guess we just verify it when it is deployed and working [14:01:33] well, usually we do that after a local demo. but it's a bit annoying to demonstrate [14:01:33] well, usually we do that after a local demo. but it's a bit annoying to demonstrate [14:01:37] so, let's just not forget [14:01:37] so, let's just not forget [14:02:30] (03CR) 10Tobias Gritschacher: [C: 032] "per Daniel" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [14:02:30] (03CR) 10Tobias Gritschacher: [C: 032] "per Daniel" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [14:02:30] \o/ [14:02:30] \o/ [14:02:35] (03CR) 10Tobias Gritschacher: [C: 04-1] "Found two issues (probably related):" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 (owner: 10Henning Snater) [14:02:35] (03CR) 10Tobias Gritschacher: [C: 04-1] "Found two issues (probably related):" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 (owner: 10Henning Snater) [14:02:36] (03Merged) 10jenkins-bot: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [14:02:36] (03Merged) 10jenkins-bot: Put other project links in parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158381 (https://bugzilla.wikimedia.org/70393) (owner: 10Aude) [14:04:11] Tobi_WMDE_SWE: if you want to close, but if i tag the bug in backports [14:04:11] Tobi_WMDE_SWE: if you want to close, but if i tag the bug in backports [14:04:16] then it gets reopened [14:04:16] then it gets reopened [14:04:21] and i have to close again [14:04:21] and i have to close again [14:04:39] aude: are you creating the backports now? [14:04:39] aude: are you creating the backports now? [14:04:47] on monday [14:04:47] on monday [14:04:52] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e29d402 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34497387 [14:04:52] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e29d402 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34497387 [14:05:00] these are nasty but not enough so for friday deploy [14:05:00] these are nasty but not enough so for friday deploy [14:05:02] ok [14:05:02] ok [14:05:18] the bugzillabot is not smart about that [14:05:18] the bugzillabot is not smart about that [14:05:23] unfortunately [14:05:23] unfortunately [14:05:24] heh [14:05:24] heh [14:26:11] ACTION waves from the US (for the last time) [14:26:11] * hoo waves from the US (for the last time) [14:26:16] :) [14:26:16] :) [14:28:03] hoo: we are deploying fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=70415 on monday [14:28:03] hoo: we are deploying fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=70415 on monday [14:28:11] along with some other bug fixes [14:28:11] along with some other bug fixes [14:31:13] ACTION still has to order new network stuffs for my home [14:31:13] * hoo still has to order new network stuffs for my home [14:31:28] if it's not there on Monday I'll go insane :D [14:31:28] if it's not there on Monday I'll go insane :D [14:31:43] oooo [14:31:43] oooo [14:31:49] aude: I'll be around, then (unless jet lags total ruins my rhythm) [14:31:49] aude: I'll be around, then (unless jet lags total ruins my rhythm) [14:31:57] * jet lag totally [14:31:57] * jet lag totally [14:36:04] aude: Oh, that RepoApi JS refactor stuff broke? :S [14:36:04] aude: Oh, that RepoApi JS refactor stuff broke? :S [14:36:10] :( [14:36:10] :( [14:36:37] we bascially reverted to the 1st patchset there [14:36:37] we bascially reverted to the 1st patchset there [14:36:41] Oh, it didn't even break where I thought it might break [14:36:41] Oh, it didn't even break where I thought it might break [14:37:06] then it was suggested to use postWithToken (?) from mediawiki.api [14:37:06] then it was suggested to use postWithToken (?) from mediawiki.api [14:37:11] jQuery is smarter now, compared to when I initially wrote all that mess :P [14:37:11] jQuery is smarter now, compared to when I initially wrote all that mess :P [14:37:17] and i missed seeing that [14:37:17] and i missed seeing that [14:37:27] doesn't that use the local token? [14:37:28] doesn't that use the local token? [14:37:30] yep [14:37:30] yep [14:37:38] it does, I see... duh [14:37:38] it does, I see... duh [14:37:43] that's the issue, trying to request to wikidata api with enwiki or whatnot token [14:37:43] that's the issue, trying to request to wikidata api with enwiki or whatnot token [14:37:47] invalid token! [14:37:47] invalid token! [14:37:49] mh [14:37:49] mh [14:38:00] i also want selenium tests for this [14:38:00] i also want selenium tests for this [14:38:10] Where did ours go? [14:38:10] Where did ours go? [14:38:13] but probably have to write them myself and unbreak beta [14:38:13] but probably have to write them myself and unbreak beta [14:38:18] we had selenium tests for that feature [14:38:18] we had selenium tests for that feature [14:38:21] not in cucumber yet? [14:38:21] not in cucumber yet? [14:38:25] possible [14:38:25] possible [14:38:36] but we certainly had tests... I know that because I fixed them at some point [14:38:36] but we certainly had tests... I know that because I fixed them at some point [14:38:43] i remember that [14:38:43] i remember that [14:40:13] So we totally abandoned the old tests? :( [14:40:13] So we totally abandoned the old tests? :( [14:41:29] think so :( [14:41:29] think so :( [14:41:41] ACTION rage to Tobi_WMDE_SWE ! [14:41:41] * aude rage to Tobi_WMDE_SWE ! [14:43:17] aude: hoo: we did not abandon them: https://github.com/wmde/WikidataBrowserTestsRSpec [14:43:17] aude: hoo: we did not abandon them: https://github.com/wmde/WikidataBrowserTestsRSpec [14:43:24] oh, i see [14:43:24] oh, i see [14:43:26] just nobody dares running them it seems [14:43:26] just nobody dares running them it seems [14:43:40] not sure they still work as nobody maintains them [14:43:40] not sure they still work as nobody maintains them [14:44:02] :/ [14:44:02] :/ [14:44:04] https://github.com/wmde/WikidataBrowserTestsRSpec/blob/master/client/tests/selenium/interwiki/edit_sitelinks_spec.rb [14:44:04] https://github.com/wmde/WikidataBrowserTestsRSpec/blob/master/client/tests/selenium/interwiki/edit_sitelinks_spec.rb [14:44:06] That's not much better [14:44:06] That's not much better [14:44:18] they probably need a lot of love now [14:44:18] they probably need a lot of love now [14:44:26] depending on when we last touched them [14:44:26] depending on when we last touched them [14:44:29] hoo: pretty much a rewrite [14:44:29] hoo: pretty much a rewrite [14:44:43] more people need to learn to write them [14:44:43] more people need to learn to write them [14:44:44] we don't use the RSpec architecture anymore [14:44:44] we don't use the RSpec architecture anymore [14:44:46] ACTION tried [14:44:46] * aude tried [14:44:53] need to try more [14:44:53] need to try more [14:45:02] yeah, I have no idea how to [14:45:02] yeah, I have no idea how to [14:45:02] :) [14:45:02] :) [14:45:15] Would be nice if I could do that myself for new features I introduce [14:45:15] Would be nice if I could do that myself for new features I introduce [14:45:31] hoo: you should come to the office again and I'll show you [14:45:31] hoo: you should come to the office again and I'll show you [14:45:34] :) [14:45:34] :) [14:45:35] and if we could get travis to run them at least on a regular schedule [14:45:35] and if we could get travis to run them at least on a regular schedule [14:45:47] the fundraising guys are currently writing lots of them [14:45:47] the fundraising guys are currently writing lots of them [14:45:56] but unfortunately not for wikidata .) [14:45:56] but unfortunately not for wikidata .) [14:46:00] Tobi_WMDE_SWE: Maybe mid-September, but can't tell yet [14:46:00] Tobi_WMDE_SWE: Maybe mid-September, but can't tell yet [14:46:02] :) [14:46:02] :) [14:46:18] We could have a smallish session maybe? [14:46:18] We could have a smallish session maybe? [14:46:23] hoo: we run them on a regular schedule - that is everytime we deploy to beta [14:46:23] hoo: we run them on a regular schedule - that is everytime we deploy to beta [14:46:32] I also need to get that set up for my environment, I guess [14:46:32] I also need to get that set up for my environment, I guess [14:46:36] but since beta is broken now for weeks, there's no instance that can be tested [14:46:36] but since beta is broken now for weeks, there's no instance that can be tested [14:46:38] also would help if beta was non-broken [14:46:38] also would help if beta was non-broken [14:46:47] Still broken due to HHVM? [14:46:47] Still broken due to HHVM? [14:46:53] once we tag wikibase 0.5 [14:46:53] once we tag wikibase 0.5 [14:47:16] then i will remove all usage of class aliases [14:47:16] then i will remove all usage of class aliases [14:47:21] e.g. move things into namespaces [14:47:21] e.g. move things into namespaces [14:47:35] Will that fix the trobules? [14:47:35] Will that fix the trobules? [14:47:44] although i do not understand why hhvm has such trouble with them [14:47:44] although i do not understand why hhvm has such trouble with them [14:47:50] hoo: that's what the error logs say [14:47:50] hoo: that's what the error logs say [14:48:04] we just should not use class alias.... they are buggy [14:48:04] we just should not use class alias.... they are buggy [14:49:04] couldn't we just switch towards using 'OurAlias extends RealClass{}'? [14:49:04] couldn't we just switch towards using 'OurAlias extends RealClass{}'? [14:49:10] hhvm surely supports that [14:49:10] hhvm surely supports that [14:49:36] problem is with namespaces [14:49:36] problem is with namespaces [14:49:46] there would be conflict with class alias [14:49:46] there would be conflict with class alias [14:50:28] :S [14:50:28] :S [14:50:53] did wikidata make a general announcement about global.js files? [14:50:53] did wikidata make a general announcement about global.js files? [14:50:54] me and thiemo spent a lot of time on this already and got stuck [14:50:54] me and thiemo spent a lot of time on this already and got stuck [14:51:25] phpunit always fails (non-hhvm) if i rename all the use Wikibase\EntityId (or whatnot) in the Wikibase namespace [14:51:25] phpunit always fails (non-hhvm) if i rename all the use Wikibase\EntityId (or whatnot) in the Wikibase namespace [14:51:37] as long as class_alias() is still there [14:51:37] as long as class_alias() is still there [14:51:40] as your users act xwiki, and with files like //www.wikidata.org/w/index.php?title=User:Yair rand/WikidataInfo.js it would be worth getting your users to not have to paste it to each wiki [14:51:40] as your users act xwiki, and with files like //www.wikidata.org/w/index.php?title=User:Yair rand/WikidataInfo.js it would be worth getting your users to not have to paste it to each wiki [14:51:51] sDrewth: not that i know [14:51:51] sDrewth: not that i know [15:02:11] hoo> Networks stuffs ordered and flights are in time, yay :) [15:02:11] hoo> Networks stuffs ordered and flights are in time, yay :) [15:02:13] time to leave... going to see Hoboken for a bit and then fly back [15:02:13] time to leave... going to see Hoboken for a bit and then fly back [15:02:15] cu tomorrow! :) [15:02:15] cu tomorrow! :) [15:02:21] have fun! [15:02:21] have fun! [15:02:37] aude: https://gerrit.wikimedia.org/r/#/c/157500 does that still take the sorting via MediaWiki:Sidebar into account? [15:02:37] aude: https://gerrit.wikimedia.org/r/#/c/157500 does that still take the sorting via MediaWiki:Sidebar into account? [15:02:52] hoo: as far as i can verify, yes [15:02:52] hoo: as far as i can verify, yes [15:03:21] Ah ok, fine then [15:03:21] Ah ok, fine then [15:03:35] enwiki moves it somehow [15:03:35] enwiki moves it somehow [15:03:36] was just worried about that breaking again, now that we tolled the wikis how to fi it [15:03:36] was just worried about that breaking again, now that we tolled the wikis how to fi it [15:03:44] why that? [15:03:44] why that? [15:03:47] -.- [15:03:47] -.- [15:05:44] aude: If someone asks: https://www.mediawiki.org/wiki/Topic:S17ttu1xclaso6ck use that for reference [15:05:44] aude: If someone asks: https://www.mediawiki.org/wiki/Topic:S17ttu1xclaso6ck use that for reference [15:05:53] going to leave now [15:05:53] going to leave now [15:05:54] :) [15:05:54] :) [15:05:58] ok [15:05:58] ok [15:08:52] [13WikidataBrowserTests] 15tobijat created 06reference_tests (+1 new commit): 02http://git.io/V0EPFA [15:08:52] [13WikidataBrowserTests] 15tobijat created 06reference_tests (+1 new commit): 02http://git.io/V0EPFA [15:08:52] 13WikidataBrowserTests/06reference_tests 14ef437e6 15Tobias Gritschacher: [WIP] Add browsertests for references [15:08:52] 13WikidataBrowserTests/06reference_tests 14ef437e6 15Tobias Gritschacher: [WIP] Add browsertests for references [15:53:31] o.O [15:53:31] o.O [15:53:37] howcome 2 wm-bots got in here lol [15:53:37] howcome 2 wm-bots got in here lol [15:53:42] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 2.6.1.0 [libirc v. 1.0.2] my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [15:53:42] @help [15:53:42] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 2.6.1.0 [libirc v. 1.0.2] my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [15:53:42] @help [15:53:43] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 2.6.1.0 [libirc v. 1.0.2] my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [15:53:43] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 2.6.1.0 [libirc v. 1.0.2] my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [15:53:47] omg [15:53:47] omg [15:54:03] hah [15:54:03] hah [15:54:41] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 2.6.1.0 [libirc v. 1.0.2] my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [15:54:41] @help [15:54:49] ok looks much better now :P [15:54:55] oh no! you killed one! [15:55:00] !nyan [15:55:01] ~=[,,_,,]:3 [15:55:04] how did you know which AI to kill?? [15:55:06] :) [15:55:16] because it was wm-bot3 responding [15:55:25] wm-bot was just dead node [15:55:26] maybe you got the one from our universe instead of the one from the evil mirror universe [15:55:45] maybe I am confused, though :) [15:56:18] but I can put it back :3 [15:56:29] This channel I never heard of :'( [15:56:29] @instance #wikidata wm-bot [15:56:36] Changed default instance of #wikidata to wm-bot [15:56:36] @instance wm-bot #wikidata [15:56:49] !nyan [15:56:49] ~=[,,_,,]:3 [15:56:57] better [16:05:02] (03PS2) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [16:09:03] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [16:49:02] (03PS1) 10Bene: [WIP] Some more refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [16:49:51] JeroenDeDauw: hey, are you here? [16:49:52] * benestar needs some input [16:50:30] it's a dennyvrandecic_ :D [16:50:44] hey benestar! [16:50:53] congrats on the badges progress, it is impressive! [16:51:00] thanks :D [16:51:14] dennyvrandecic_: currently killing EntityView ^^ [16:51:38] language in programming is quite full of metaphors from darker ages [16:51:58] ;) [16:52:04] I hope you are not meaning to ask me something about EntityView, because I don't know anything about it [16:52:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Some more refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [16:52:21] dennyvrandecic_: lol, just wanted to ask you about it :P [16:52:33] well, maybe you can help me anyway, just a design question [16:52:44] go ahead :) but take my answer with a grain of salt [16:52:45] it's a ball of mud [16:52:50] what i know :P [16:52:56] currently ItemView and PropertyView both inherit from EntityView [16:53:11] I know that expression very well. ball of mud was my favourite programming pattern in the early 90s [16:53:14] I reduced lots of code in it, it only has 80 lines [16:53:23] sweet [16:53:38] however, I'm now thinking if we should get rid of the inheritance entirely and kill both ItemView and PropertyView [16:53:56] we could introduce a View interface and add a list of views to the EntityView [16:54:11] which then gets rendered and EntityView does not actually know what's going on there [16:54:41] the other way would be to keep the inheritance and use the views inside of ItemView [16:55:29] let's think [16:55:35] one day we might have more types of entities [16:55:43] like lexemes or files [16:55:56] or quotations [16:56:02] yes [16:56:11] the question is, would it be easier to inherit [16:56:32] or to assemble these views from components to fit a common interface [16:56:38] in case people wonder, there are css / bits issues [16:57:05] wikidata may have "nostalgia" skin and ops are looking into this [16:57:22] some of these might have sub-entities (planned for lexemes) [16:57:33] some of these might have no description, but only a label [16:57:35] etc. [16:58:05] also being able to compose a view with subitems will probably be easier with an interface than with inheritance [16:58:17] what are your thoughts? [17:01:30] aude: is there a doc on the tech details of redirects in wikidata? [17:01:43] (wikipage, or bug or sth) [17:02:04] probably a question for daniel [17:02:09] not that i am aware of [17:02:22] yeah, but he's not online :) [17:02:27] rage! [17:02:31] :D [17:02:56] he is working to have redirects automatically created with merges [17:04:03] dennyvrandecic_: sorry, my firefox just died -.- [17:04:09] aude: that should be quite simple... [17:04:11] dennyvrandecic_: I thought labels and descriptions are tight together? [17:04:12] but basically you're right [17:04:14] * benestar will create some more super huge patches... [17:05:01] dennyvrandecic_: they shouldn't be [17:06:48] dennyvrandecic_ is talking to himself? :O [17:07:02] EOS [17:07:06] (early onset schizophrenia) [17:08:07] yes [17:08:12] (03PS3) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [17:08:15] it is called mumbling [17:08:46] and what shouldn't be? the label/description thing or the size of patches? [17:09:04] label/descriptions shouldnt be tied together [17:09:20] can I somehow see the raw data of https://www.wikidata.org/w/index.php?title=Q10000483&redirect=no [17:09:24] ? [17:09:41] well, they are tied in the UI which will make it hard to separate them [17:10:52] https://www.wikidata.org/w/index.php?title=Special:EntityData/Q10000483.json&redirect=no doesn't work -.- [17:10:55] will need to be untied then :) [17:10:57] or it actually works how id should [17:11:03] *t [17:11:10] ah, this works https://www.wikidata.org/wiki/Special:Export/Q10000483 [17:11:35] dennyvrandecic_: so lets first untie labels and claims [17:11:36] ;) [17:12:16] arent they doing that for the ui rework anyway? [17:12:29] for the babel in other languages thing it is also untied [17:14:03] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [17:33:04] (03PS4) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [17:37:49] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [19:42:08] benestar: I'm going to get dinner now, will be back in an hour or so. Feel free to send me the url of the stuff to review [21:03:16] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/fbcb9c4 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34534611