[08:24:36] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 147814592 to 1465748b4: 02http://git.io/qVv3IQ [08:24:36] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 1465748b4 15Jan Zerebecki: Do not inherit from EntitySerializer.... [08:26:41] [travis-ci] wmde/WikibaseDataModelSerialization/compose-EntitiySerializer/65748b4 : Jan Zerebecki The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35610832 [08:41:59] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 1465748b4 to 14bf567bb: 02http://git.io/qVv3IQ [08:41:59] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 14bf567bb 15Jan Zerebecki: Do not inherit from EntitySerializer.... [08:45:36] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 14bf567bb to 143eb4ba7: 02http://git.io/qVv3IQ [08:45:36] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 143eb4ba7 15Jan Zerebecki: Do not inherit from EntitySerializer.... [08:53:23] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 143eb4ba7 to 14e4091da: 02http://git.io/qVv3IQ [08:53:23] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 14e4091da 15Jan Zerebecki: Do not inherit from EntitySerializer.... [09:24:59] Lydia_WMDE: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Datatype_of_snak_is_missing [09:25:03] we should investigate [09:46:28] hi :) [10:00:47] (03PS1) 10WikidataBuilder: New Wikidata Build - 18/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161206 [10:01:42] (03Abandoned) 10Aude: New Wikidata Build - 18/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161206 (owner: 10WikidataBuilder) [10:16:52] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161206 (owner: 10WikidataBuilder) [10:36:06] all of the abandoned builds!! [10:37:00] meeeeeeerge! [10:37:07] https://gerrit.wikimedia.org/r/#/q/owner:%22WikidataBuilder+%253Cwikidata-services%2540wikimedia.de%253E%22+status:abandoned,n,z [10:37:15] https://github.com/wmde/WikidataBuildResources/pull/7 ! [10:37:55] [13WikibaseDataModelSerialization] 15JanZerebecki created 06serialize-statements-on-properties (+1 new commit): 02http://git.io/kxDm6g [10:37:55] 13WikibaseDataModelSerialization/06serialize-statements-on-properties 14bcb067b 15Jan Zerebecki: Implement serialization of statements on properties. [10:37:58] you can check that out, run composer install and see that it works to provide wikibase and all the things :) [10:38:01] aude: think I cannot test this locally for me [10:38:11] you no haz composer? [10:38:19] sure I have [10:38:20] try vagrant :) [10:38:29] and you can try this patch in vagrant [10:38:40] * aude can wait for hoo [10:38:57] no haz vagrant [10:39:05] rage :D [10:39:14] :D [10:39:44] [travis-ci] wmde/WikibaseDataModelSerialization/serialize-statements-on-properties/bcb067b : Jan Zerebecki The build failed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35619865 [10:40:17] (03Abandoned) 10Aude: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 (owner: 10Aude) [10:40:22] (03Abandoned) 10Aude: Fix missing options bug in GetClaims [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160644 (owner: 10Aude) [10:40:27] (03Abandoned) 10Aude: Add tests for api xml format [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160645 (owner: 10Aude) [10:42:53] aaaah, no should abandon them all [10:43:01] (03Restored) 10Aude: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 (owner: 10Aude) [10:45:13] (03PS3) 10Aude: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 [10:45:16] (03PS1) 10Aude: Fix missing options bug in GetClaims [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161212 [10:45:18] (03PS1) 10Aude: Add tests for api xml format [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161213 [10:45:20] (03PS1) 10Aude: Fix tag names generated in API XML output. [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161214 (https://bugzilla.wikimedia.org/70531) [11:12:54] DanielK_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=64586 <- if you have a minute please to add link to patch set :D [11:14:14] https://www.mediawiki.org/wiki/Extension_talk:Wikibase_Repository#Wikibase_extension_error_-_failed_to_deserialize_on_EntityFactor.php_48197 <- anyone who can answer this? [11:15:54] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06sitelinkgroup_edit: 02http://git.io/pHYlhA [11:15:54] 13WikidataBrowserTests/06sitelinkgroup_edit 14329d614 15Tobias Gritschacher: Fix test for sitelinklist full [11:17:28] (03PS8) 10Tobias Gritschacher: Moved edit feature from sitelinkview to sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [11:18:21] (03CR) 10Tobias Gritschacher: [C: 031 V: 032] "Browsertests are passing with the needed adjustments in https://github.com/wmde/WikidataBrowserTests/pull/9" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [11:25:00] Lydia_WMDE: https://www.mediawiki.org/wiki/Extension_talk:Wikibase_Repository#Wikibase_extension_error_-_failed_to_deserialize_on_EntityFactor.php_48197 [11:25:07] they either need to have items not in main ns [11:25:14] or move the page [11:25:19] i think the former [11:26:39] he also does not need require_once "$IP/extensions/Wikibase/client/WikibaseClient.php"; [11:26:44] btw [11:36:32] Lydia_WMDE: http://www.amazon.de/Elmar-David-McKee/dp/3522432029 [11:37:03] http://www.amazon.de/Unbekannt-EL7300-Thienemann-Elmar-Stofftier/dp/B0000XO2IS/ref=pd_bxgy_b_img_y [11:38:49] omg! :D [11:58:45] (03CR) 10Daniel Kinzler: Move SidebarBeforeOutput hook to SidebarHookHandlers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159515 (owner: 10Daniel Kinzler) [12:30:11] (03CR) 10Aude: [C: 032] Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 (owner: 10Aude) [12:30:28] (03CR) 10Aude: [C: 032] Fix missing options bug in GetClaims [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161212 (owner: 10Aude) [12:30:40] (03CR) 10Aude: [C: 032] Add tests for api xml format [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161213 (owner: 10Aude) [12:30:51] (03CR) 10Aude: [C: 032] Fix tag names generated in API XML output. [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161214 (https://bugzilla.wikimedia.org/70531) (owner: 10Aude) [12:46:08] (03Merged) 10jenkins-bot: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 (owner: 10Aude) [12:49:18] (03Merged) 10jenkins-bot: Fix missing options bug in GetClaims [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161212 (owner: 10Aude) [12:49:20] (03Merged) 10jenkins-bot: Add tests for api xml format [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161213 (owner: 10Aude) [12:50:08] (03Merged) 10jenkins-bot: Fix tag names generated in API XML output. [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161214 (https://bugzilla.wikimedia.org/70531) (owner: 10Aude) [12:57:24] !nyan [12:57:24] ~=[,,_,,]:3 [13:11:45] (03CR) 10Daniel Kinzler: "The regression test can be in a separate change, but i'd like to see it on gerrit before merging this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [13:23:11] (03PS1) 10Aude: Update Wikidata, fix broken xml api output [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161232 [13:24:18] Lydia_WMDE: do you have an apple-touch icon in mind? [13:24:20] e.g. http://bits.wikimedia.org/apple-touch/wikipedia.png [13:34:40] (03CR) 10Aude: [C: 032] Update Wikidata, fix broken xml api output [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161232 (owner: 10Aude) [13:34:56] Maybe a cat? <3 [13:35:05] heh [13:35:42] Maybe use a version without text? [13:37:27] sjoerddebruin: seems good to me [13:37:43] Text is displayed under the icon, so it would be double. [13:37:52] agree [13:38:04] might be unreadable at the size of an icon [13:38:20] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06serialize-statements-on-properties from 14bcb067b to 140835976: 02http://git.io/7Odp3Q [13:38:20] 13WikibaseDataModelSerialization/06serialize-statements-on-properties 140835976 15Jan Zerebecki: Implement serialization of statements on properties. [13:39:24] [travis-ci] wmde/WikibaseDataModelSerialization/serialize-statements-on-properties/0835976 : Jan Zerebecki The build is still failing. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35633363 [13:40:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161232 (owner: 10Aude) [13:41:31] aude: Do you have the tools to make a icon? [13:42:23] if i absolutely had to, probably could [13:42:33] but prefer someone more talented do it :) [13:42:52] and need to confirm what size it should be [13:42:55] 180 x 180 [13:43:06] agree [13:44:30] (03Merged) 10jenkins-bot: Update Wikidata, fix broken xml api output [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/161232 (owner: 10Aude) [13:50:24] aude: A mock-up with https://commons.wikimedia.org/wiki/File:Wikidata-logo.svg [13:50:25] https://www.dropbox.com/s/3wm4h8yz624lkkg/iOS-simulatorschermafbeelding%2018%20sep.%202014%2015.49.44.png?dl=0 [13:51:17] looks good [13:51:27] does it need any background, like the iwkipedia one? [13:51:31] wikipedia* [13:51:38] I think so. [13:52:25] Yes, it looks weird on the home screen. https://www.dropbox.com/s/zxq2sxszpvquqa3/iOS-simulatorschermafbeelding%2018%20sep.%202014%2015.52.14.png?dl=0 [13:52:45] We need the same gradient imo [13:53:00] +1 [13:53:33] And same padding. :P [13:54:06] [13WikibaseDataModelSerialization] 15JanZerebecki 04deleted 06serialize-statements-on-properties at 140835976: 02http://git.io/_G5EhA [13:55:33] [13WikibaseDataModelSerialization] 15JanZerebecki created 06statements-on-properties (+2 new commits): 02http://git.io/H7gXoA [13:55:33] 13WikibaseDataModelSerialization/06statements-on-properties 140835976 15Jan Zerebecki: Implement serialization of statements on properties. [13:55:33] 13WikibaseDataModelSerialization/06statements-on-properties 1442613eb 15Jan Zerebecki: Implement deserialization of statements on properties. [13:56:05] meh [13:56:11] going back to PHP 5.3 again sucks [13:56:26] Seriously, 5.6 was released >_> [13:56:28] [travis-ci] wmde/WikibaseDataModelSerialization/statements-on-properties/42613eb : Jan Zerebecki The build failed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35634620 [13:56:38] we've never been anywhere else :S [13:57:06] hoo: Wikibase is not the only software that exists ;p [13:57:50] hhvm is magical solution :p [13:58:08] solve all our problems :) [13:58:16] aude: is that 5.4 or 5.5? [13:58:29] neither [13:58:33] the core phpunit tests don't even fully work with 5.4 [13:58:39] not 5.3 also [13:58:43] aude: good luck with the Linker RFC btw [13:58:50] thanks [13:58:51] jzerebecki: oh, is that why they don't run on my box? [13:59:00] Let's choose this, aude. https://www.dropbox.com/s/iswtahksnu1zdaf/iOS-simulatorschermafbeelding%2018%20sep.%202014%2015.58.45.png?dl=0 [13:59:14] hah! [13:59:17] +2 [13:59:30] huh [13:59:35] What crazy Dutch stuff is that? [13:59:37] JeroenDeDauw: if they don't run at all that is a different issue [14:00:01] jzerebecki: they run, but with lots of nice red coloring [14:00:09] And no NyanCat [14:00:11] :( [14:03:14] JeroenDeDauw: lots of failures might be something else, also. last I checked there were less than 24 failures. but perhaps things changed and that was only 5.4 . [14:05:41] jzerebecki: it's serious fail for a PHP project to not run with the default PHP version comming with Ubuntu and whatnot [14:13:00] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06settings: 02http://git.io/QGLgVw [14:13:00] 13WikidataBuildResources/06settings 1482a5187 15aude: Fix path for tests in UnitTestsList handler [14:13:07] Fatal error: Call to a member function getOption() on a non-object in BetaFeaturesHooks.php on line 121 [14:13:16] and that's why i had disabled that extension :( [14:15:21] JeroenDeDauw: yes, now consider that it is run in production on an upstream version that is already end of life withouth security backports. (one could check if it is on the latest patch level that still was released when it was not EOL, but there are more important things to do than see how big the fail is.) [14:21:46] I've drafted our next Entity type [14:21:49] Lydia_WMDE: DanielK_WMDE_: http://pastebin.com/9PfAAy3j [14:22:08] Will submit a pull request with it soon [14:23:03] Is that for the new Wikikittens sisterproject? :D [14:23:28] jzerebecki: good point, shows the consistency of the security policy [14:23:49] JeroenDeDauw: \o/ [14:23:57] jzerebecki: sure, outlining the problem does not fix it. Though if people do not see there is a problem to begin with, fixing is hard [14:24:18] hoo: how did you guess? [14:24:36] aude: I trust you get this deployed to nyan.wikimedia.org ASAP [14:24:41] :D [14:27:12] meh. I already created such a fixture and then forgot about it :( https://github.com/wmde/WikibaseDataModel/blob/master/tests/fixtures/EntityOfUnknownType.php [14:27:37] das ist not unknown [14:29:18] JeroenDeDauw: that stuff should go on kittidata.org [15:00:24] [13Wikidata.org] 15Benestar pushed 1 new commit to 06master: 02http://git.io/A1zFmw [15:00:24] 13Wikidata.org/06master 14e989be1 15Bene: Remove internationalization [15:02:21] [13WikimediaBadges] 15Benestar pushed 1 new commit to 06master: 02http://git.io/sudIDQ [15:02:21] 13WikimediaBadges/06master 146cb8e19 15Bene: Remove internationalization [15:05:14] ..... [15:08:04] Lydia_WMDE: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#XML-Serialization [15:08:20] i think that probably is sufficient and we can also mention in weekly summary [15:10:24] Yes, please mention. :) [15:29:32] I thought github had a revert button now? [15:29:53] don't think so [15:30:11] wow, all the things gerrit has that github does not [15:30:49] Yeah, I still prefer it [15:38:50] https://github.com/wmde/WikimediaBadges/pull/12 was way too much work for a simple revert. [15:38:53] [13WikimediaBadges] 15legoktm opened pull request #12: Revert "Remove internationalization" (06master...06master) 02http://git.io/PvfLUw [15:39:18] You can revert commits. [15:39:31] from the web ui? [15:40:12] I see a option in the OS X-app. [15:40:38] https://www.dropbox.com/s/etptsrl8qcp726f/Schermafdruk%202014-09-18%2017.40.36.png?dl=0 [15:42:05] oh, I don't use that [15:42:17] [13WikimediaBadges] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/LqLgQQ [15:42:17] 13WikimediaBadges/06master 1426fcc0b 15Kunal Mehta: Revert "Remove internationalization"... [15:42:17] 13WikimediaBadges/06master 140d5623b 15Marius Hoch: Merge pull request #12 from legoktm/master... [15:42:33] It's weird that the web gui doesn't have the same options. [15:43:18] It's weird that there's a GUI app for soemthing like github IMO :P [15:44:15] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06statements-on-properties from 1442613eb to 14910a160: 02http://git.io/5Uw3Gg [15:44:15] 13WikibaseDataModelSerialization/06statements-on-properties 14910a160 15Jan Zerebecki: Implement deserialization of statements on properties. [15:45:12] [travis-ci] wmde/WikibaseDataModelSerialization/statements-on-properties/910a160 : Jan Zerebecki The build is still failing. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35645759 [15:45:53] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #196: [WIP] Clean up entity patching code (06master...06entitypatcher) 02http://git.io/oRr8IQ [15:48:02] hiho, i got a request from a user why https://www.wikidata.org/wiki/User:Joern/altLabels.js stopped working... when running it i see an error: "TypeError: $.toJSON is not a function"... [15:48:20] [13Wikidata.org] 15legoktm opened pull request #12: Revert "Remove internationalization" (06master...06master) 02http://git.io/z0YBsQ [15:48:42] jorn: You need to / can use JSON directly now [15:48:54] just do mw.loader.load('json') first [15:48:58] hoo: ^ one more btw [15:49:40] [13Wikidata.org] 15mariushoch closed pull request #12: Revert "Remove internationalization" (06master...06master) 02http://git.io/z0YBsQ [15:49:41] ah, so it's not passed into the function anymore? [15:49:44] legoktm: Ah... one can revert PRs... but not commits [15:50:44] anyways, I think we figured out why the messages aren't loading. [15:52:57] (03PS12) 10Daniel Kinzler: Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 [15:56:20] (03CR) 10jenkins-bot: [V: 04-1] Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [15:56:52] hoo, legoktm: sorry to ask again: so the $.*json* functions were deprecated and i instead shall do a JSON.* now? [15:56:57] yeah [15:57:06] yep [15:57:17] JSON.parse() / JSON.stringify() [15:57:30] and for that to work i need a mw.loader.load('json') first or not? [15:57:37] you need it [15:57:47] like you needed jquery.json before [15:57:47] cool thanks, will try [15:57:51] which you probably didn't do [15:58:02] because you wouldn't see these errors, if you did :P [15:58:16] no, cause $ is passed into the plugin as second parameter... [15:58:33] so? [15:58:45] [13WikimediaBadges] 15legoktm opened pull request #13: Move $wgMesssageDirs outside of the extension function (06master...06patch-1) 02http://git.io/sspIPA [15:59:52] well, my plugin once worked, so i assume that variable $ contained a jquery with .json stuff ;) [16:00:01] probably some other script was loading it [16:00:17] i didn't include another script [16:00:26] or plugin [16:00:48] so if that was the case then some standard script did [16:01:15] very possible [16:01:28] but the plugin's first line is still "( function ( mw, $ ) {"? [16:01:38] and i can still use $ from there just like jquery? [16:01:40] yeah [16:01:46] ok, cool [16:17:31] legoktm: thanks, that problem in the script is fixed... [16:17:40] :) [16:18:29] do you happen to know what to search for when i want to insert some stuff received via json from the api into html (so html escaping) and later on submit some of that html stuff back to the json api (so html unescaping) [16:18:30] ? [16:19:42] not off the top of my head, no [16:29:10] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 14e4091da to 14c15d4cb: 02http://git.io/qVv3IQ [16:29:10] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 14c15d4cb 15Jan Zerebecki: Do not inherit from EntitySerializer.... [16:32:03] [13WikibaseDataModel] 15Benestar comment on pull request #196 149153d4f: indentation issue 02http://git.io/5egSRg [16:33:21] JeroenDeDauw: hey, are you around? [16:33:47] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #196 149153d4f: wtf?? Guess I need to file a fifth PhpStorm 8.0 bug then! 02http://git.io/cpENIg [16:34:46] JeroenDeDauw: I want to create a class which is basically a ByPropertyIdArray... [16:34:54] however, I cannot call it that way because it already exists [16:35:07] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #196 149153d4f: Or not. Added in 186fbd7e7ef86505d4bc309fd9f82ca91ef4a373, so guess @WMDE-Fisch does not have his IDE set to tabs. Heresy! :) 02http://git.io/AMgI0Q [16:35:37] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06entitypatcher: 02http://git.io/7zxi1w [16:35:37] 13WikibaseDataModel/06entitypatcher 14caae679 15jeroendedauw: Fix indentation issue [16:35:47] so either I create a new class with a slightly different name or I rewrite ByPropertyIdArray which then will perhaps have less functionality [16:36:21] hoo: did you see https://github.com/wmde/WikidataBuildResources/pull/7 yet? [16:36:50] it's needed for us to once again deploy on beta [16:36:50] aude: Not yet, no [16:36:53] ok [16:37:02] not totally urgent [16:37:24] but would be nice to have new code on beta for a few days or a week before we go to test. again [16:37:48] Oh, sure :) [16:37:56] :) [16:39:16] then we tackle the issue for the builder to pull from here instead of have stuff inside the builder git repo itself [16:39:52] [13WikibaseDataModel] 15Benestar created 06propertyidprovider (+1 new commit): 02http://git.io/Ybrb-w [16:39:52] 13WikibaseDataModel/06propertyidprovider 14db0ee6c 15Bene: Update release notes [16:40:22] [13WikibaseDataModel] 15Benestar opened pull request #197: Update release notes for PropertyIdProvider (06master...06propertyidprovider) 02http://git.io/VNbyQw [16:41:43] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06addreference: 02http://git.io/sad10A [16:41:43] 13WikibaseDataModel/06addreference 14beac925 15Bene: Move release notes into one line [16:42:53] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/PBs-wg [16:42:53] 13WikibaseDataModel/06master 14db0ee6c 15Bene: Update release notes [16:42:53] 13WikibaseDataModel/06master 142e9ee47 15Jeroen De Dauw: Merge pull request #197 from wmde/propertyidprovider... [17:07:43] [13WikibaseDataModel] 15JeroenDeDauw pushed 3 new commits to 06entitypatcher: 02http://git.io/dcrIDg [17:07:43] 13WikibaseDataModel/06entitypatcher 14864705f 15jeroendedauw: split Statement patching code into its own class [17:07:44] 13WikibaseDataModel/06entitypatcher 141fa50cc 15jeroendedauw: split SiteLink patching code into its own class [17:07:44] 13WikibaseDataModel/06entitypatcher 14a1aa320 15jeroendedauw: Simplifications in SiteLinkListPatcher [17:12:23] legoktm: $(select).text() does this... [17:12:57] in contrast to .html() [17:28:16] (03PS1) 10Daniel Kinzler: Example for WikibaseTextForSearchIndex hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 [17:34:31] JeroenDeDauw: did you receive my previous messages in this channel? [20:46:09] [13WikibaseDataModel] 15Benestar created 06beststatementfinder (+1 new commit): 02http://git.io/OX404w [20:46:09] 13WikibaseDataModel/06beststatementfinder 1480e274b 15Bene: Create initial version of BestStatementFinder [20:47:52] [13WikibaseDataModel] 15Benestar opened pull request #198: [WIP] Create initial version of BestStatementFinder (06master...06beststatementfinder) 02http://git.io/_tzT9Q [20:49:27] [travis-ci] wmde/WikibaseDataModel/beststatementfinder/80e274b : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35673284 [21:18:23] [13WikibaseDataModel] 15Benestar created 06bypropertyidgrouper (+1 new commit): 02http://git.io/DaDIlQ [21:18:23] 13WikibaseDataModel/06bypropertyidgrouper 14e2b4adc 15Bene: Create initial version of ByPropertyIdGrouper [21:20:01] [13WikibaseDataModel] 15Benestar opened pull request #199: [WIP] Create initial version of ByPropertyIdGrouper (06master...06bypropertyidgrouper) 02http://git.io/1mNsGw [21:21:37] [travis-ci] wmde/WikibaseDataModel/bypropertyidgrouper/e2b4adc : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35676296 [23:16:07] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06entitypatcher: 02http://git.io/_xpziw [23:16:07] 13WikibaseDataModel/06entitypatcher 1400357dd 15jeroendedauw: Replace legacy patching tests with new ones [23:18:14] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06entitypatcher: 02http://git.io/1-RkyA [23:18:14] 13WikibaseDataModel/06entitypatcher 14a8b92f1 15jeroendedauw: Remove unused imports [23:21:19] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #199 14e2b4adc: Can you add `stub` to the end of the name? `provider` is kinda confusing in this context. 02http://git.io/lSjP2g [23:22:46] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #199 14e2b4adc: It is hard to find out what the intent behind each argument list is. Can you make dedicated methods instead? 02http://git.io/q3i9Cw [23:25:27] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #199 14e2b4adc: This method is not tested. I'm wondering if this behaves correctly in cases where you have an empty array for a property id. 02http://git.io/hylM7A [23:28:47] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #198 1480e274b: This is not how the original `ByPropertyIdArray` was intended to be used. You'd construct the thing where you wanted to map the data. You'd not demand the data in this form. 02http://git.io/jeonNA