[07:34:46] [13WikibaseDataModel] 15Benestar comment on pull request #196 1412de0d9: By the way, can we assume that every statement has a GUID here? Otherwise the code will behave unexpectedly. 02http://git.io/yY9WaA [08:12:51] [13WikibaseDataModel] 15Benestar comment on pull request #196 1412de0d9: I don't see the benefit of this interface. `EntityDocument` is only about ids and the ids will never get patched because they are immutable. Therefore we will also most likely kill the `EntityDiff` class entirely because it contains now `EntityStuff` but only stuff specific for fingerprints or claims/statements. 02http://git.io/6TgF9Q [08:13:59] [13WikibaseDataModel] 15Benestar comment on pull request #196 1412de0d9: I cannot see why we need this class. Per below we shouldn't have an `EntityPatcherStrategy` interface and then we also won't need and cannot have an `EntityPatcher`. 02http://git.io/8fKyTg [08:15:45] [13WikibaseDataModelSerialization] 15JanZerebecki closed pull request #83: Statements on properties (06compose-EntitiySerializer...06statements-on-properties) 02http://git.io/MYYSIQ [08:16:44] [13WikibaseDataModelSerialization] 15JanZerebecki opened pull request #86: Statements on properties (06master...06statements-on-properties) 02http://git.io/lV9aeA [08:19:42] [13WikibaseDataModelSerialization] 15JanZerebecki 04deleted 06compose-EntitiySerializer at 14ced7cec: 02http://git.io/qW_xIA [08:20:25] [13WikibaseDataModel] 15Benestar created 06statementlist (+1 new commit): 02http://git.io/nPxORg [08:20:25] 13WikibaseDataModel/06statementlist 14e7cbdbb 15Bene: Use service classes in StatementList and deprecate methods [08:20:40] [13WikibaseDataModel] 15Benestar opened pull request #200: Use service classes in StatementList and deprecate methods (06master...06statementlist) 02http://git.io/iGp07A [08:22:50] [travis-ci] wmde/WikibaseDataModel/statementlist/e7cbdbb : Bene The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/35796441 [08:27:28] [13WikibaseDataModel] 15Benestar created 06claimsbypropertyidgrouper (+1 new commit): 02http://git.io/k4BVAg [08:27:28] 13WikibaseDataModel/06claimsbypropertyidgrouper 140c1d280 15Bene: Use ByPropertyIdGrouper in Claims and deprecate ByPropertyIdArray [08:28:09] [13WikibaseDataModel] 15Benestar opened pull request #201: Use ByPropertyIdGrouper in Claims and deprecate ByPropertyIdArray (06master...06claimsbypropertyidgrouper) 02http://git.io/PyT5-w [08:29:42] [travis-ci] wmde/WikibaseDataModel/claimsbypropertyidgrouper/0c1d280 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35796630 [08:30:34] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06statementlist: 02http://git.io/ApJ-wg [08:30:34] 13WikibaseDataModel/06statementlist 1445f2873 15Bene: Fix StatementListTest [08:32:54] [travis-ci] wmde/WikibaseDataModel/statementlist/45f2873 : Bene The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35796742 [09:46:08] JeroenDeDauw: hey :) [09:56:56] [13WikibaseDataModel] 15Benestar closed pull request #191: Use StatementList instead of Claims in patchClaims (06master...06noclaims) 02http://git.io/_AqASA [09:57:06] [13WikibaseDataModel] 15Benestar 04deleted 06noclaims at 146202f10: 02http://git.io/UlhdjQ [09:58:51] [13WikibaseDataModel] 15Benestar 04deleted 06statementclaimconstructor at 14cf8df0e: 02http://git.io/QeOiAQ [10:00:25] (03PS1) 10WikidataBuilder: New Wikidata Build - 20/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161651 [10:09:20] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 20/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161651 (owner: 10WikidataBuilder) [10:15:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161651 (owner: 10WikidataBuilder) [10:23:46] Aloha. [12:55:32] Lydia_WMDE: around? :) [13:59:47] (03Abandoned) 10Aude: New Wikidata Build - 20/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161651 (owner: 10WikidataBuilder) [14:01:20] [13WikidataBuilder] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/Ztwa2w [14:01:20] 13WikidataBuilder/06master 149277e65 15Katie Filbert: Merge pull request #28 from wmde/wikidata... [14:01:38] [13WikidataBuilder] 15filbertkm 04deleted 06wikidata at 14a30b397: 02http://git.io/S7Yx2A [14:42:36] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #196 1412de0d9: The reason we have this interface is so that we can have `EntityPatcher`, or rather the functionality `EntityPatcher` provides. The users of DataModel have places where they have something of type `Entity` and need to patch it. In many cases having something of an unknown `Entity` types is bad, but still DM needs to support its current users. This dispatcher + strategy appr [14:48:06] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #200 1445f2873: I do not think it is wortwhile to remove this from this class, and think delegating to `ByPropertyIdGrouper` is not better than the original implementation. 02http://git.io/wzLY1g [14:48:57] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #200 1445f2873: This is a breaking change. You cannot do that in 1.1. 02http://git.io/4apbqQ [15:03:15] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #201 140c1d280: `ByPropertyIdArray` has all this moving stuff, which `ByPropertyIdGrouper` does not have. Unfortunately that stuff is needed. If it was not, we'd just be able to kill it and stick with a sane `ByPropertyIdArray`. 02http://git.io/Qr5FFQ [15:06:31] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06statements-on-properties at 142212818: 02http://git.io/1kxDpA [15:57:29] (03CR) 10Jeroen De Dauw: [C: 031] Remove removeClaim from AbstractedRepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160650 (owner: 10Adrian Lang) [15:58:28] (03CR) 10Jeroen De Dauw: [C: 032] Remove removeReferences from AbstractedRepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160649 (owner: 10Adrian Lang) [16:00:26] (03CR) 10Jeroen De Dauw: [C: 031] Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 (owner: 10Adrian Lang) [16:04:32] (03CR) 10Jeroen De Dauw: [C: 032] Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [16:21:42] (03Merged) 10jenkins-bot: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [17:23:16] * benestar gives lots of kudos to JeroenDeDauw :D [17:31:14] (03PS1) 10Jeroen De Dauw: Improve type hints in ValuesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161681 [17:35:34] (03PS1) 10Jeroen De Dauw: Use the moved version of PropertyDataTypeLookup and InMemoryDataTypeLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161682 [17:37:42] (03CR) 10jenkins-bot: [V: 04-1] Improve type hints in ValuesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161681 (owner: 10Jeroen De Dauw) [17:37:55] benestar: I'm trading those kudos for a merge of https://github.com/wmde/WikibaseDataModel/pull/196 [17:38:54] I'm still not that happy with the EntityPatcher... [17:39:29] there is nothing entity specific in the patching code [17:44:17] (03CR) 10jenkins-bot: [V: 04-1] Use the moved version of PropertyDataTypeLookup and InMemoryDataTypeLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161682 (owner: 10Jeroen De Dauw) [20:17:59] Lydia_WMDE: dev update? :p [20:19:31] benestar|cloud: seems like you do not understand the patterns applied there :) [20:40:56] JeroenDeDauw: you mean for the entity patcher thing? [20:45:23] benestar: yes [20:57:05] sjoerddebruin: Ran the new item bot, damn, lot of new items were created [20:57:13] I tought Amir was doing that house keeping [20:57:25] Oh, that's the reason why my list became shorter. [20:58:16] haha [20:58:35] Little bit annoying, because there was some stuff above the G that required some more attention [20:58:56] The back off time is very conservative [21:00:17] But really, no I don't like it. [21:02:30] Looks like someone broke it anyway [21:03:53] The items that I've ignored (not created a item for) had some serious issues. Now they are untrackable. [21:04:38] And I add properties to my new items. Now some shit bot only creates a item with a sitelink [21:04:56] My motivation is gone. [21:09:40] multichill: how much pages have you imported??? [21:10:29] It worked on https://tools.wmflabs.org/multichill/queries/wikidata/articles_not_wikidata.txt stopped at SDO_Hillegom [21:10:41] godver [21:12:12] ik vind dit echt niet leuk multichill. Elke dag was ik bezig om zorgvuldig een lijst af te gaan. [21:13:25] waarom kom ik op zulke dagen altijd thuis met teleurstellingen... [21:14:34] Vervelend om te horen, maar dat kan ik toch niet ruiken? [21:14:43] Ik heb er bijna dagelijks over gepraat. [21:17:12] Allemaal artikelen die waarschijnlijk kut zijn gecategoriseerd [21:17:18] nu moet ik weer kloten met autolist etc [21:18:39] :( [21:23:10] de manier waarop ongekoppelde pagina's werkte was voor mij perfect [21:23:16] f5 = update van lijst [21:23:23] ik kan niet werken met https://tools.wmflabs.org/multichill/queries/wikidata/noclaims_nlwiki.txt [21:25:36] (03PS2) 10Jeroen De Dauw: Use the moved version of PropertyDataTypeLookup and InMemoryDataTypeLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161682 [21:30:24] (03PS3) 10Jeroen De Dauw: Use the moved version of PropertyDataTypeLookup and InMemoryDataTypeLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161682 [21:30:28] (03PS4) 10Jeroen De Dauw: Use the moved version of PropertyDataTypeLookup and InMemoryDataTypeLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161682 [21:32:16] Nou multichill, kan jouw bot identificatiecodes, voornamen, volledige namen, alma maters, broers, zussen, vaders, moeders, werkgevers, geslacht, speelposities, sportteams, taxonomische rangen, wetenschappelijke namen, moedertaxons importeren? Want dat kan ik nu niet meer doen. [21:32:42] sjoerddebruin: Ik snap dat je het vervelend vindt, maar hier bereik je niets mee [21:32:55] Ik voel me nu helemaal kut. [21:33:44] Ik was al bezig een lijstje te maken van items die zijn aangemaakt [21:41:03] hup multichill [21:41:08] en kop op sjoerddebruin [21:44:09] sjoerddebruin: https://nl.wikipedia.org/wiki/Gebruiker:Multichill/Kladblok zijn de items die vanavond zijn aangemaakt [21:44:37] Ongeacht welke gebruiker het gedaan heeft btw [21:44:42] Ja, ik zie die van mij. :P [21:45:37] Kan het ook op naam sorteren, is nu op id [21:47:36] Heb je alleen de itemid's voor mij, een per regel? [21:47:56] Dan kan ik die in autolist gooien en filteren [21:48:21] Welk formaat? [21:48:43] Geen link, gewoon Q1337 [21:50:09] sjoerddebruin: https://tools.wmflabs.org/multichill/queries/wikidata/recent_nlwiki_items.txt zoiets? [21:50:19] jup, even testen [21:52:26] Dat werkt, nu P31 en P279 eruit filteren... [21:57:31] wel irritant dat die ook pagina's met een nominatiesjabloon importeert [21:59:30] Zek [21:59:34] Zelfs hiervoor een item https://nl.wikipedia.org/wiki/Kreuz_Bonn-Ost [21:59:51] EN DIE STAAT WEER GODVERDOMME NIET OP DE BEOORDELINGSLIJST [22:00:23] Het moet meer dan een week niet zijn aangeraakt voordat de bot iets doet [22:00:44] Verwijderlijst dingen komen er daardoor normaal niet op, tenzijn dat vergeten wordt natuurlijk.... [22:09:18] en dit werkt ook niet, als ik ergens op klik krijg ik eerst het item te zien [22:09:25] moet ik weer klikken naar het artikel [22:17:59] no Lydia_WMDE :( [22:20:17] JohnLewis: try emailing her [22:20:32] when do you need it? [22:21:04] well; the summary is supposed to go out today but it can wait til tomorrow tbh [22:21:26] It has been coming out on Sunday the last 3 out of 4 times. the other time it never happened. [22:23:18] if she doesn't respond by tomorrow, then maybe i can help :) [22:23:30] maybe you can :) [22:23:35] ok [23:36:17] Hi