[07:07:17] [13WikidataBrowserTests] 15tobijat opened pull request #10: Reference tests (06master...06reference_tests) 02http://git.io/_58hWQ [07:38:40] (03PS16) 10Tobias Gritschacher: Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [07:48:21] (03CR) 10jenkins-bot: [V: 04-1] Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [07:59:51] [13WikibaseDataModelSerialization] 15JanZerebecki created 06correct-covers (+1 new commit): 02http://git.io/uDmSiw [07:59:51] 13WikibaseDataModelSerialization/06correct-covers 14218d92b 15Jan Zerebecki: Correct @covers annotation. [08:00:11] [13WikibaseDataModelSerialization] 15JanZerebecki opened pull request #87: Correct @covers annotation. (06master...06correct-covers) 02http://git.io/ln6J4g [08:02:00] (03PS1) 10Henning Snater: Manage "save" button state when changing referenceview state [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161914 [08:02:30] [travis-ci] wmde/WikibaseDataModelSerialization/correct-covers/218d92b : Jan Zerebecki The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35913344 [08:17:01] [13WikibaseDataModelSerialization] 15Tpt pushed 1 new commit to 06master: 02http://git.io/-mpzlw [08:17:01] 13WikibaseDataModelSerialization/06master 149782910 15Thomas PT: Merge pull request #87 from wmde/correct-covers... [09:51:37] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06correct-covers at 14218d92b: 02http://git.io/TpNrsg [09:58:55] (03CR) 10Jeroen De Dauw: [C: 031] Fix CommonsMedia tracking [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161803 (owner: 10Bene) [10:50:01] (03PS4) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [11:01:35] (03PS1) 10Henning Snater: Initialize toolbars on existing DOM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161924 [11:11:39] (03CR) 10jenkins-bot: [V: 04-1] Initialize toolbars on existing DOM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161924 (owner: 10Henning Snater) [11:14:28] (03PS2) 10Henning Snater: Initialize toolbars on existing DOM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161924 [11:29:18] !r https://github.com/wmde/WikibaseDataModel/pull/196 [11:29:19] https://gerrit.wikimedia.org/r/#/c/https://github.com/wmde/WikibaseDataModel/pull/196/ [11:29:28] !m https://github.com/wmde/WikibaseDataModel/pull/196 [11:29:28] merge merge merge MERGEEEEEEEEEEEEE [11:29:39] (03PS1) 10Henning Snater: Deferred edittoolbar tooltip init to when switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161927 [11:29:40] !m del [11:29:40] Successfully removed m [11:29:54] !m is merge merge merge MERGEEEEEEEEEEEEE $1 [11:29:54] Key was added [11:29:57] !m [11:29:57] merge merge merge MERGEEEEEEEEEEEEE [11:30:06] !m https://github.com/wmde/WikibaseDataModel/pull/196 [11:30:06] merge merge merge MERGEEEEEEEEEEEEE https://github.com/wmde/WikibaseDataModel/pull/196 [11:30:20] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06reference_tests: 02http://git.io/nTCTFA [11:30:20] 13WikidataBrowserTests/06reference_tests 147883a73 15Tobias Gritschacher: Removed commented out lines [11:30:24] Henning_WMDE: ^^ [11:30:33] !m del [11:30:33] Successfully removed m [11:30:47] !m is $2 merge merge merge MERGEEEEEEEEEEEEE $1 [11:30:48] Key was added [11:30:50] also uncommented the line which will fail due to the save-button issue [11:32:53] Tobi_WMDE_SWE: this is kinda blocking work on the query things: https://github.com/wmde/WikibaseQueryEngine/pull/116 [11:34:02] JeroenDeDauw: will have a look [11:36:36] [13WikibaseQueryEngine] 15tobijat closed pull request #116: Make compatible with DataModel 1.0 (06master...06dm1) 02http://git.io/X74nTg [11:36:46] [13WikibaseQueryEngine] 15tobijat 04deleted 06dm1 at 1414097f9: 02http://git.io/5Vcqog [11:43:36] [travis-ci] wmde/WikibaseQueryEngine/master/0e4fb00 : Tobi Gritschacher The build was fixed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35927191 [11:46:35] JeroenDeDauw: https://github.com/wmde/WikibaseQueryEngine/pull/117 is ready to merge as well, right? [11:58:53] JeroenDeDauw: i was told that WikibaseDataModelSerialization had knowledge about if the serialization target is json. do you know where i can find that in the code? [12:03:19] [13WikibaseQueryEngine] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/VQhP3w [12:03:19] 13WikibaseQueryEngine/06master 142f45236 15Jeroen De Dauw: Merge pull request #117 from wmde/geo1... [12:08:31] [13WikibaseQueryEngine] 15JeroenDeDauw closed pull request #102: Add PropertyDataValueTypeLookupException (06master...06PropertyDataValueTypeLookupException) 02http://git.io/vVs4fw [12:09:22] Tobi_WMDE_SWE: yeah, merged it already now, that was making Wikibase Query uninstallable [12:11:01] [13WikibaseQueryEngine] 15JeroenDeDauw 04deleted 06PropertyDataValueTypeLookupException at 14f54a852: 02http://git.io/KnHcJA [12:11:33] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/F2iXkQ [12:11:33] 13WikibaseDataModel/06master 141eca92d 15Jeroen De Dauw: Update PropertyDataTypeLookup.php [12:15:51] [13WikibaseQueryEngine] 15JeroenDeDauw created 06exception (+1 new commit): 02http://git.io/_JqXwg [12:15:51] 13WikibaseQueryEngine/06exception 145d7a730 15jeroendedauw: Add PropertyDataValueTypeLookupException [12:16:16] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #118: Add PropertyDataValueTypeLookupException (06master...06exception) 02http://git.io/DmKwSA [12:20:42] [travis-ci] wmde/WikibaseQueryEngine/exception/5d7a730 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35929885 [12:25:09] [13WikibaseQueryEngine] 15JeroenDeDauw created 06pg (+1 new commit): 02http://git.io/2pwEnw [12:25:09] 13WikibaseQueryEngine/06pg 14e86d6e9 15jeroendedauw: Attmpt to make TravisCI work with Postgres [12:29:40] [travis-ci] wmde/WikibaseQueryEngine/pg/e86d6e9 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35930465 [12:30:03] This is so evil... https://youtrack.jetbrains.com/issue/WI-22887 [12:30:11] Give ALL of the +1's! [12:41:16] (03PS2) 10Henning Snater: Deferred edittoolbar tooltip init to when switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161927 [12:44:04] [13WikibaseQueryEngine] 15JeroenDeDauw created 06desc (+2 new commits): 02http://git.io/7iJWCQ [12:44:04] 13WikibaseQueryEngine/06desc 146b73bf3 15jeroendedauw: Simplify method [12:44:04] 13WikibaseQueryEngine/06desc 14e5e1ef3 15jeroendedauw: Simplify methods in DescriptionMatchFinder [12:44:44] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #119: Simplify methods in DescriptionMatchFinder (06master...06desc) 02http://git.io/opCwWQ [12:50:09] [travis-ci] wmde/WikibaseQueryEngine/desc/e5e1ef3 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35931993 [12:52:54] jzerebecki: please see https://github.com/wmde/WikibaseDataModelSerialization/issues/53 [12:53:35] jzerebecki: somewhat related: https://github.com/wmde/WikibaseDataModelSerialization/issues/50 [12:53:55] jzerebecki: we wwent through all options to see if they should be also implemented in the new code [12:54:09] k [12:54:21] jzerebecki: for most of them there was no need, either the feature was not needed, or it could be done in a better way [13:04:12] [13WikibaseQueryEngine] 15JeroenDeDauw 04force-pushed 06pg from 14e86d6e9 to 1486dd18f: 02http://git.io/v_T2EQ [13:04:12] 13WikibaseQueryEngine/06pg 1486dd18f 15jeroendedauw: Attmpt to make TravisCI work with Postgres [13:14:51] (03PS5) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [13:29:23] [13WikibaseQueryEngine] 15JeroenDeDauw 04force-pushed 06pg from 1486dd18f to 14891d9de: 02http://git.io/v_T2EQ [13:29:23] 13WikibaseQueryEngine/06pg 14891d9de 15jeroendedauw: Attmpt to make TravisCI work with Postgres [13:35:29] [travis-ci] wmde/WikibaseQueryEngine/pg/891d9de : jeroendedauw The build was broken. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35935874 [13:35:55] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06reference_tests: 02http://git.io/y_1UuA [13:35:55] 13WikidataBrowserTests/06reference_tests 144a615fc 15Tobias Gritschacher: Use different steps and selectors for mainsnaks and snaks [13:36:02] Henning_WMDE: ^^ [13:36:05] finally.. [13:37:38] [13WikibaseQueryEngine] 15JeroenDeDauw 04force-pushed 06pg from 14891d9de to 147ceed49: 02http://git.io/v_T2EQ [13:37:38] 13WikibaseQueryEngine/06pg 147ceed49 15jeroendedauw: Attmpt to make TravisCI work with Postgres [13:38:12] [13WikibaseDataModel] 15tobijat 04deleted 06entitypatcher at 1412de0d9: 02http://git.io/FsdxUg [13:39:54] (03PS1) 10Henning Snater: Implemented singlebuttontoolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161937 [13:44:14] [travis-ci] wmde/WikibaseQueryEngine/pg/7ceed49 : jeroendedauw The build is still failing. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35936693 [13:47:06] JeroenDeDauw: the tool to view the pofiling output is http://kcachegrind.sourceforge.net/html/Home.html it should be available as a package in your distribution [13:47:23] [13WikibaseQueryEngine] 15JeroenDeDauw 04force-pushed 06pg from 147ceed49 to 14b03f7b5: 02http://git.io/v_T2EQ [13:47:23] 13WikibaseQueryEngine/06pg 14b03f7b5 15jeroendedauw: Attmpt to make TravisCI work with Postgres [13:48:40] Tobi_WMDE_SWE: https://scrutinizer-ci.com/g/wmde/WikibaseDataModel/reports/ [13:51:57] [travis-ci] wmde/WikibaseQueryEngine/pg/b03f7b5 : jeroendedauw The build is still failing. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35937531 [14:00:01] [13WikibaseQueryEngine] 15JeroenDeDauw 04force-pushed 06pg from 14b03f7b5 to 14d927b53: 02http://git.io/v_T2EQ [14:00:01] 13WikibaseQueryEngine/06pg 14d927b53 15jeroendedauw: Attmpt to make TravisCI work with Postgres [14:05:35] [travis-ci] wmde/WikibaseQueryEngine/pg/d927b53 : jeroendedauw The build was fixed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35938590 [14:08:11] [13WikidataBrowserTests] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/ZBmBOQ [14:08:11] 13WikidataBrowserTests/06master 14e496c00 15snaterlicious: Merge pull request #10 from wmde/reference_tests... [14:08:19] \o/ [14:11:48] woha, found a class with 80ish methods [14:17:46] [13WikibaseQueryEngine] 15JeroenDeDauw 04force-pushed 06pg from 14d927b53 to 14af2ec8a: 02http://git.io/v_T2EQ [14:17:46] 13WikibaseQueryEngine/06pg 14af2ec8a 15jeroendedauw: Make TravisCI work with Postgres [14:22:22] [13WikibaseQueryEngine] 15JeroenDeDauw pushed 1 new commit to 06pg: 02http://git.io/DZxlYQ [14:22:22] 13WikibaseQueryEngine/06pg 14f16dcfd 15jeroendedauw: Make the postgres builds non-optional [14:22:32] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #120: Make TravisCI work with Postgres (06master...06pg) 02http://git.io/fwNE5w [14:24:13] jzerebecki: still have not rembered the name of this app? [14:30:13] Yay, another magnustool broken. :? [14:30:18] Warning: mysqli::mysqli(): (28000/1045): Access denied for user 's51211'@'localhost' (using password: YES) in /data/project/magnustools/public_html/php/common.php on line 101 Fatal error: Call to a member function real_escape_string() on a non-object in /data/project/magnustools/public_html/php/common.php on line 114 [14:36:24] (03CR) 10Tobias Gritschacher: [C: 031 V: 032] "Browsertests & QUnit passing." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [14:38:42] JeroenDeDauw: see above for this: the tool to view the pofiling output is http://kcachegrind.sourceforge.net/html/Home.html it should be available as a package in your distribution [14:39:52] ah, right, there's a new dev in the town! [14:39:56] !nyan | jzerebecki [14:39:56] jzerebecki: ~=[,,_,,]:3 [14:42:10] :) [14:43:11] (03PS1) 10Henning Snater: Reuse static toolbar button DOM nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 [15:42:34] (03PS1) 10Henning Snater: Suppress redrawing when initializing toolbar on existing nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 [15:44:47] jzerebecki: thnx [15:59:29] (03PS2) 10Aude: Move EntityViewPlaceholderExpander into Wikibase\Repo\View namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161783 [16:05:24] [13WikibaseDataModelSerialization] 15JanZerebecki created 06fix-empty-map (+1 new commit): 02http://git.io/tuwVOQ [16:05:24] 13WikibaseDataModelSerialization/06fix-empty-map 1469f095e 15Jan Zerebecki: WIP TODO Add OPTION_OBJECTS_FOR_MAPS. [16:09:17] (03CR) 10Daniel Kinzler: [C: 04-1] "please provide a regression test" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161803 (owner: 10Bene) [16:09:31] JeroenDeDauw: is this way for fixing the empty map problem good?: https://github.com/wmde/WikibaseDataModelSerialization/commit/69f095ec5624f1b619c7b4ea43f90a33ece4b434 [16:10:08] DanielK_WMDE_: https://github.com/wmde/WikibaseDataModelSerialization/commit/69f095ec5624f1b619c7b4ea43f90a33ece4b434 [16:11:22] [travis-ci] wmde/WikibaseDataModelSerialization/fix-empty-map/69f095e : Jan Zerebecki The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35952121 [17:04:02] (03PS2) 10Aude: Move client recentchanges classes into namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161784 [17:34:34] it's a jzerebecki :) [17:39:05] (03CR) 10Bene: [C: 032] Move EntityViewPlaceholderExpander into Wikibase\Repo\View namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161783 (owner: 10Aude) [17:42:56] (03CR) 10Bene: [C: 04-1] Move client recentchanges classes into namespace (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161784 (owner: 10Aude) [17:54:22] (03Merged) 10jenkins-bot: Move EntityViewPlaceholderExpander into Wikibase\Repo\View namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161783 (owner: 10Aude) [17:59:41] jzerebecki: generally better to @ ping me on the commit itself, on IRC I might lose track of it [18:01:48] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on commit 1469f095e: $serialization is a list, not a map. So this is not one of the places the behavior is wrong. Or I'm so sleepy I'm confusing myself :) 02http://git.io/sEZBuA [18:05:30] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on commit 1469f095e: This makes the serializer depend on the factory. And most of the problems you have with a generic options object are also present if you have a generic options bitfield.... 02http://git.io/pqxecg [18:08:13] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on commit 1469f095e: Why this dynamic field name? Does `$badges['0'] = 'Q42'` not work? If not, then `(object)array( '0' => 'Q42' )` does.... 02http://git.io/h6etuA [19:59:42] JeroenDeDauw: around? [20:00:01] * benestar just rewrote ByPropertyIdArray in 190 lines of code