[00:00:46] huh [00:01:05] Any idea what is doing that? [00:01:16] Seems like something does automatic submodule update [00:01:17] s [00:02:36] https://github.com/wikimedia/mediawiki-extensions-Wikidata/tree/REL1_22 [00:02:37] wow [00:03:12] I'd suggest to delete that branch... it's of no use to us [00:03:19] why??? [00:03:42] I don't see a reason to keep stuff like that around [00:04:35] agree [00:04:40] why does it exist? [00:05:06] been there for months... almost a year [00:05:23] mh... I guess a script created a REL1_22 branch of what was master of Wikidata back then [00:05:28] and gerrit keeps updating the submodules [00:06:07] delete sounds good [00:07:08] (03PS1) 10Hoo man: Update Wikibase to wmf/1.25wmf4 HEAD [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167130 [00:07:20] (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase to wmf/1.25wmf4 HEAD [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167130 (owner: 10Hoo man) [00:07:33] doh [00:07:35] master [00:07:38] (03Abandoned) 10Hoo man: Update Wikibase to wmf/1.25wmf4 HEAD [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167130 (owner: 10Hoo man) [00:08:08] (03PS1) 10Hoo man: Update Wikibase to wmf/1.25wmf4 HEAD [extensions/Wikidata] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167131 [00:09:01] aude: Ok, branch deleted [00:09:44] yay [00:09:45] I prevented the shared cache key update as nothing changed regarding cache [00:09:57] ok [00:10:06] although we override it, so noop in production [00:10:17] only for beta [00:10:31] I see [00:17:40] aude: Is wdjenkins still alive? [00:17:44] If not, +2 ? [00:18:28] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf4/a0561b1 : Marius Hoch The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38213847 [00:19:52] travis fails because I didn't backport the travis fix [00:20:00] to many backports... [00:20:17] as long as wmf jenkins approves [00:20:28] It does :) [00:20:31] (03CR) 10Aude: [C: 032] Update Wikibase to wmf/1.25wmf4 HEAD [extensions/Wikidata] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167131 (owner: 10Hoo man) [00:20:46] aude: What's up with the travis.yml in Wikidata, btw? [00:20:58] unused atm [00:21:10] i think we wanted to use it [00:21:14] mh [00:21:24] ok, in that case it also needs fixing [00:21:38] i don't know if it works [00:21:49] well, at least the file name thing needs to be fixed [00:21:52] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167130 (owner: 10Hoo man) [00:21:54] despite of that it might work [00:21:55] ok [00:25:22] 3MediaWiki extensions / 3WikidataClient: Calling mw.wikibase.entity.formatPropertyValues on Property fails with wikibase-error-invalid-entity-id - 10https://bugzilla.wikimedia.org/72124#c2 (10Marius Hoch) 5UNCO>3NEW I had another look, the thing seen here was simply that the template call {{List of prope... [00:29:20] (03Merged) 10jenkins-bot: Update Wikibase to wmf/1.25wmf4 HEAD [extensions/Wikidata] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167131 (owner: 10Hoo man) [00:29:38] finally [00:32:12] (03Draft1) 10Aude: Use DispatchingEntityIdParser instead of BasicEntityIdParser in repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167136 [00:32:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167131 (owner: 10Hoo man) [00:38:03] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf4/5ec51e0 : Marius Hoch The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38214865 [02:33:02] (03CR) 10Jeroen De Dauw: [C: 032] "This is also good design wise. Code that binds itself to BasicEntityIdParser does not support new types of entities. Production code parsi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167136 (owner: 10Aude) [02:49:40] [13WikibaseDataModel] 15JeroenDeDauw created 06BasicEntityIdParser (+1 new commit): 02http://git.io/KOMljg [02:49:40] 13WikibaseDataModel/06BasicEntityIdParser 14e952789 15jeroendedauw: Instantiate dependency of BasicEntityIdParser on construction and not on every parse call [02:49:47] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #246: Instantiate dependency of BasicEntityIdParser on construction and not on every parse call (06master...06BasicEntityIdParser) 02http://git.io/lA6nNA [02:51:05] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/SZLHRA [02:51:05] 13WikibaseDataModel/06master 14fb3f3ef 15Jeroen De Dauw: Update composer.json [02:52:52] wmde/WikibaseDataModel/BasicEntityIdParser/e952789 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38223798 [02:53:05] (03CR) 10Jeroen De Dauw: [C: 032] Some minor style changes in the scribunto code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167128 (owner: 10Hoo man) [02:56:00] (03CR) 10Jeroen De Dauw: Don't getContent in OutputPageBodyAttributes handler (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167127 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [02:56:39] (03CR) 10Jeroen De Dauw: [C: 031] Don't try to fetch non-existing extension data from ParserOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167123 (owner: 10Aude) [03:01:10] (03CR) 10Jeroen De Dauw: [C: 04-1] "Looks unused, so I'm thinking the behaviour changed now." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167116 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [03:07:52] 3MediaWiki extensions / 3WikidataRepo: Find a way to make global item ids - 10https://bugzilla.wikimedia.org/71996#c2 (10Jeroen De Dauw) I know I have discussed this with Markus before, since it was relevant for WDTK. Can't find where this was though. I've poked Markus now, since I want his input. [03:28:52] 3MediaWiki extensions / 3WikidataRepo: Find a way to make global item ids - 10https://bugzilla.wikimedia.org/71996#c3 (10Jeroen De Dauw) > using different prefixes (Q => Wikidata, C => Commons, Z => Wikiquote) Nope, not going back to configurable prefixes :) Guess you where not involved yet at the point whe... [03:34:35] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_bxP-w [03:34:35] 13WikibaseDataModel/06master 14a389b64 15Jeroen De Dauw: Update RELEASE-NOTES.md [04:56:10] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06q183 (+1 new commit): 02http://git.io/JeNDzQ [04:56:10] 13WikibaseDataModelSerialization/06q183 1451fa581 15jeroendedauw: Add Q183 to the test data [04:57:51] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06dmvm (+1 new commit): 02http://git.io/51iFqw [04:57:51] 13WikibaseDataModelSerialization/06dmvm 14c734c42 15jeroendedauw: Update DM versions in TravisCI build matrix [04:57:52] wmde/WikibaseDataModelSerialization/q183/51fa581 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/38229001 [04:59:53] wmde/WikibaseDataModelSerialization/dmvm/c734c42 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/38229064 [06:57:08] (03CR) 10Henning Snater: [C: 032] Remove legacy jshintignore file and fix hidden jshint errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166994 (owner: 10Adrian Lang) [07:06:09] (03Merged) 10jenkins-bot: Remove legacy jshintignore file and fix hidden jshint errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166994 (owner: 10Adrian Lang) [07:12:05] (03CR) 10Henning Snater: Avoid some TypeErrors in strict mode (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166978 (owner: 10Adrian Lang) [07:15:53] (03CR) 10Henning Snater: [C: 032] Make sure list item prototypes have a value method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166955 (owner: 10Adrian Lang) [07:24:40] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Like the changes very much in general, but agree to what Henning said. :-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166978 (owner: 10Adrian Lang) [07:25:25] (03Merged) 10jenkins-bot: Make sure list item prototypes have a value method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166955 (owner: 10Adrian Lang) [07:25:56] (03PS2) 10Henning Snater: Improve claimgrouplabelscroll code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 (owner: 10Adrian Lang) [07:27:42] (03CR) 10Henning Snater: "Patch set 2: Added jquery.ui.position dependency and some missing space characters." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 (owner: 10Adrian Lang) [07:34:21] (03PS4) 10Thiemo Mättig (WMDE): JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 [07:36:54] (03CR) 10Thiemo Mättig (WMDE): "I split this patch. Now this one contains only actual bugfixes. Can we agree on that, please? Pretty please?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [07:38:56] (03PS1) 10Thiemo Mättig (WMDE): Simplify background CSS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167173 [07:39:47] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/vwVM4Q [07:39:47] 13WikidataBrowserTests/06master 14269ee79 15Tobias Gritschacher: Fix some accessors after toolbarrefactoring [07:40:49] (03PS3) 10Aude: Remove duplicate getContentForRequest call in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167116 (https://bugzilla.wikimedia.org/72158) [07:41:26] (03CR) 10Aude: Remove duplicate getContentForRequest call in ViewEntityAction (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167116 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [07:51:05] (03CR) 10Aude: Remove duplicate getContentForRequest call in ViewEntityAction (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167116 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [08:13:42] (03PS1) 10Thiemo Mättig (WMDE): Add missing HTML element slashes to jQuery calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167174 [08:29:41] (03PS1) 10Thiemo Mättig (WMDE): Remove slashes from HTML elements that aren't allowed to be empty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167175 [08:46:55] <20WAAB00V> [13WikibaseDataModelSerialization] 15Tpt pushed 2 new commits to 06master: 02http://git.io/Hy3-4w [08:46:55] <20WAAB00V> 13WikibaseDataModelSerialization/06master 14c734c42 15jeroendedauw: Update DM versions in TravisCI build matrix [08:46:55] <20WAAB00V> 13WikibaseDataModelSerialization/06master 149df419d 15Thomas PT: Merge pull request #95 from wmde/dmvm... [08:46:56] <1JTAAPM3F> [13WikibaseDataModelSerialization] 15Tpt 04deleted 06dmvm at 14c734c42: 02http://git.io/_7Lwww [08:47:48] [13WikibaseDataModelSerialization] 15Tpt pushed 1 new commit to 06master: 02http://git.io/yJy3XA [08:47:48] 13WikibaseDataModelSerialization/06master 14b297e7e 15Thomas PT: Merge pull request #96 from wmde/q183... [09:06:55] 3MediaWiki extensions / 3WikidataRepo: Old revisions should not show edit links. - 10https://bugzilla.wikimedia.org/72177 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When viewing an entity in the context of a diff, or when viewing an old revision, the entity should not be editable.... [09:07:08] 3MediaWiki extensions / 3WikidataRepo: Old revisions should not show edit links. - 10https://bugzilla.wikimedia.org/72177 (10Daniel Kinzler) p:5Unprio>3High s:5normal>3major [09:09:26] 3MediaWiki extensions / 3WikidataClient: Create widget to edit site links in the client - 10https://bugzilla.wikimedia.org/72178 (10Henning) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Currently, while being on the client, one has to switch to the repository to edit site links. Changing to a completely... [09:15:51] (03PS1) 10Thiemo Mättig (WMDE): Don't show dead edit links in diff/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167177 (https://bugzilla.wikimedia.org/72177) [09:17:07] (03PS1) 10Adrian Lang: Use strict .jshintrc, fix typo, readd empty .jshintignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 [09:26:57] (03PS1) 10Adrian Lang: Correct some global references in JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167179 [09:27:22] 3MediaWiki extensions / 3WikidataRepo: aliases not editable through wbeditentity - 10https://bugzilla.wikimedia.org/67801#c1 (10Daniel Kinzler) 5NEW>3RESO/WOR The correct structure, as returned by wbgetentities, is: {"aliases":{"en":[{"language":"en","value":"foo"},{"language":"en","value":"bar"}]}} [09:27:42] aude: attempt to fix PropertySuggester: https://github.com/Wikidata-lib/PropertySuggester/pull/102 [09:27:58] seems the folder structure in the core-tar has changed [09:28:30] after this is fixed we can fix the issues related to tha datamodel 2.0 switch [09:28:44] (03PS1) 10Adrian Lang: Re-add .jshintignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167180 [09:29:25] (03CR) 10jenkins-bot: [V: 04-1] Don't show dead edit links in diff/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167177 (https://bugzilla.wikimedia.org/72177) (owner: 10Thiemo Mättig (WMDE)) [09:30:40] (03PS1) 10Adrian Lang: Fix conditional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167181 [09:33:42] Tobi_WMDE_SW: thanks [09:34:26] (03CR) 10jenkins-bot: [V: 04-1] Use strict .jshintrc, fix typo, readd empty .jshintignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 (owner: 10Adrian Lang) [09:35:18] (03PS2) 10Adrian Lang: Use stricter .jshintrc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 [09:35:37] 3MediaWiki extensions / 3WikidataRepo: The data structure representing an entity's claims differs betweeen wbgetentities and wbsetclaim - 10https://bugzilla.wikimedia.org/54267#c3 (10Daniel Kinzler) 5NEW>3RESO/WOR The output of wbsetclaim is now consistent with the output of wbgetclaims and wbgetentities... [09:38:23] 3MediaWiki extensions / 3WikidataRepo: Title should not be shown on old revision pages - 10https://bugzilla.wikimedia.org/41852#c5 (10Daniel Kinzler) This problem still exists [09:38:34] (03PS1) 10Thiemo Mättig (WMDE): Do not start any JavaScript in diffs/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167182 [09:40:47] (03CR) 10Thiemo Mättig (WMDE): "Note: Could be that a lot more resources do not need to be loaded in this case. Please just amend on top of this patch set or create a dep" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167182 (owner: 10Thiemo Mättig (WMDE)) [09:43:45] (03CR) 10Adrian Lang: Avoid some TypeErrors in strict mode (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166978 (owner: 10Adrian Lang) [09:43:50] (03PS2) 10Adrian Lang: Avoid some TypeErrors in strict mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166978 [09:45:04] (03CR) 10Daniel Kinzler: [C: 032] Display full year if precision is to high (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166622 (https://bugzilla.wikimedia.org/67604) (owner: 10Thiemo Mättig (WMDE)) [09:48:07] (03CR) 10Henning Snater: "OK, of course you are right. Then, why not have a new dedicated function in wikibase.js - which is, currently, acting as wrapper for ULS?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [09:50:48] (03CR) 10jenkins-bot: [V: 04-1] Use stricter .jshintrc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 (owner: 10Adrian Lang) [09:52:38] (03PS3) 10Adrian Lang: Use stricter .jshintrc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 [09:53:34] (03CR) 10jenkins-bot: [V: 04-1] Do not start any JavaScript in diffs/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167182 (owner: 10Thiemo Mättig (WMDE)) [09:54:45] (03CR) 10Daniel Kinzler: [C: 032] Remove duplicate getContentForRequest call in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167116 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [09:55:45] (03CR) 10Adrian Lang: [C: 032] Deferred edittoolbar tooltip init to when switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161927 (owner: 10Henning Snater) [09:57:01] (03CR) 10Henning Snater: [C: 032] Avoid some TypeErrors in strict mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166978 (owner: 10Adrian Lang) [09:57:03] (03CR) 10Adrian Lang: [C: 032] Implemented singlebuttontoolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161937 (owner: 10Henning Snater) [09:59:35] (03CR) 10Adrian Lang: [C: 031] "To me this appears to be merge-able at the current state. I also don't follow Jeroen's argument that it's bad to but improvable stuff up a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [10:01:01] (03PS2) 10Thiemo Mättig (WMDE): Don't show dead edit links in diff/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167177 (https://bugzilla.wikimedia.org/72177) [10:01:11] (03PS2) 10Thiemo Mättig (WMDE): Do not start any JavaScript in diffs/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167182 [10:02:57] (03Merged) 10jenkins-bot: Display full year if precision is to high [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166622 (https://bugzilla.wikimedia.org/67604) (owner: 10Thiemo Mättig (WMDE)) [10:04:27] (03CR) 10Thiemo Mättig (WMDE): "Whoops, that way me. Who merged that? ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167124 (owner: 10Aude) [10:09:53] jzerebecki: aude: tests for PropertySuggester are fixed: https://github.com/Wikidata-lib/PropertySuggester/pull/103 [10:09:59] yay [10:10:05] they were caused due to DM 2.0 [10:10:22] probably jzerebecki wants to have a look at the code if we missed something.. [10:10:27] so we need new tag now [10:10:32] otherwise we should merge and tag [10:10:33] too late :) [10:10:37] 3MediaWiki extensions / 3WikidataRepo: deep copy of Entity is made when calling Revision::getContent() - 10https://bugzilla.wikimedia.org/72158#c4 (10Daniel Kinzler) For cases where getContent() is called to look at the EntityContent, but getEntity() is never called on it, we could could give EntityContent a... [10:10:44] he can still look though [10:11:47] aude: we probably only want a new version with the dm fix [10:11:56] not with the other stuff that got in [10:12:00] not sure [10:12:13] ok [10:14:29] (03CR) 10Daniel Kinzler: [C: 031] "Looks good on a first glance, but should indeed be refactored to make review easier." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167127 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [10:18:00] (03Merged) 10jenkins-bot: Remove duplicate getContentForRequest call in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167116 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [10:18:05] (03Merged) 10jenkins-bot: Deferred edittoolbar tooltip init to when switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161927 (owner: 10Henning Snater) [10:18:17] (03Merged) 10jenkins-bot: Avoid some TypeErrors in strict mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166978 (owner: 10Adrian Lang) [10:20:03] (03Merged) 10jenkins-bot: Implemented singlebuttontoolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161937 (owner: 10Henning Snater) [10:20:09] aude: created a branch that includes the fixes: https://github.com/Wikidata-lib/PropertySuggester/tree/1.1.3_update_for_dm_2.0 [10:20:35] waiting for travis.. [10:20:42] :) [10:24:19] aude: should a make a 1.1.3 tag? [10:25:28] yes [10:25:39] done: https://github.com/Wikidata-lib/PropertySuggester/releases/tag/1.1.3 [10:25:47] note that the students have a pull request that we should review (thiemo already did) [10:25:52] and then would be 2.0 [10:26:06] will 1.1.3 be included automatically when making a new build? [10:26:13] it should be [10:26:34] https://github.com/wmde/WikidataBuildResources/blob/master/composer.json [10:27:16] aude: will try [10:28:22] ok [10:32:48] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 17/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167186 [10:33:31] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167013 (owner: 10Tobias Gritschacher) [10:41:40] aude: build fixed: https://gerrit.wikimedia.org/r/#/c/167186/ [10:41:45] merge? [10:42:05] \o/ [10:43:20] (03CR) 10Aude: [C: 032] "yay!" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167186 (owner: 10Tobias Gritschacher) [10:43:37] (03PS1) 10Thiemo Mättig (WMDE): Refactor RepoHooks::onOutputPageBodyAttributes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 [10:45:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167186 (owner: 10Tobias Gritschacher) [10:46:23] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Refactoring in Id32c100." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167127 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [10:49:36] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Don't try to fetch non-existing extension data from ParserOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167123 (owner: 10Aude) [10:50:15] aude: I think we could shut doen wdjenkins [10:50:20] *down [10:50:46] agree [10:51:00] it seems alive but then click on the links and they are broken [10:52:00] [13Geo] 15JanZerebecki 04force-pushed 06cleanup from 14947a523 to 1441d4c36: 02http://git.io/B6N7Ug [10:52:00] 13Geo/06cleanup 14cbd0c31 15Jan Zerebecki: Test GeoCoordinateFormatter with wrong target type. [10:52:00] 13Geo/06cleanup 144d82296 15Jan Zerebecki: Correct @return type of private functions to match implementation. [10:52:00] 13Geo/06cleanup 149a24738 15Jan Zerebecki: Remove unreferenced use statement. [10:52:10] (03Merged) 10jenkins-bot: New Wikidata Build - 17/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167186 (owner: 10Tobias Gritschacher) [10:52:29] aude: I don't see it in my resources on wikitech [10:52:41] or I'm probably looking at the wrong spot [10:52:45] probably [10:53:12] do we want to delete the instance already? [10:53:28] * aude doesn't see reason to keep it [10:53:35] aude: think so [10:53:51] * aude doing [10:53:58] under "instances" [10:54:09] Are you sure you wish to delete instance "wdjenkins"? [10:55:51] done! [10:57:52] (03Merged) 10jenkins-bot: Don't getContent in OutputPageBodyAttributes handler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167127 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [10:59:28] (03Merged) 10jenkins-bot: Don't try to fetch non-existing extension data from ParserOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167123 (owner: 10Aude) [10:59:57] aude: how to purge all the JS on beta? [11:00:03] looks broken [11:00:17] seems it is partially loading the old JS [11:01:59] shouldn't be [11:02:26] debug=true? [11:02:32] aude: probably I just need to be more acient [11:02:35] *pacient [11:02:37] probably [11:02:53] we can "touch" all the files but normally don't want to do that [11:03:08] needs to be automatic based on last modified timestamp of the js files [11:03:20] with debug=true it works [11:04:27] it says "wikibase is not defined" which is concerning [11:04:47] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Correct some global references in JavaScript (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167179 (owner: 10Adrian Lang) [11:04:52] also broken with debug=true [11:05:04] in private mode, it works [11:05:08] without debug=true [11:05:18] aude: did you try the link? [11:05:21] links [11:05:31] link? [11:05:45] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix conditional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167181 (owner: 10Adrian Lang) [11:05:46] aaaah 503 [11:05:48] aude: you're right. works [11:07:41] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Not exactly sure how to review this. I'm fine with a self-merge in this case. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 (owner: 10Adrian Lang) [11:07:48] aude: does not work with https [11:08:43] * aude forgets where the logs are on beta [11:09:01] Henning_WMDE: can you try http://wikidata.beta.wmflabs.org/wiki/Q11966 [11:09:15] the new JS code got deployed [11:09:29] gives a "wikibase is not defined" [11:09:50] when? [11:09:51] Henning_WMDE: with debug=true it works but has some layout-issues [11:10:02] it could mean a problem with resource loader dependencies [11:10:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Oh, found the reason for the failing test. Never mind." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 (owner: 10Adrian Lang) [11:10:20] Exception thrown by jquery.wikibase.toolbaritem [11:10:25] Henning_WMDE: when it got deployed? minutes ago.. [11:11:04] No, I had no error when loading the page initially, only after reload... [11:11:29] Henning_WMDE: local cache probably [11:11:40] error now happens always [11:11:41] shizzle [11:11:43] for me [11:11:45] :) [11:11:53] (03CR) 10Aude: "looks like an improvement, though untested." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [11:15:50] we are getting a bit of warnings like "PHP Warning: require() [function.require]: GC cache entry" ... was on gc-list for 601 seconds [11:16:01] suppose no surprise [11:16:15] (03Merged) 10jenkins-bot: Correct some global references in JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167179 (owner: 10Adrian Lang) [11:17:11] Tobi_WMDE_SW: Should be fixed with https://gerrit.wikimedia.org/r/#/c/167179/ (see jquery.wikibase.toolbaritem.js which does not have (and does not need) an RL dependency on wikibase) [11:17:55] (03CR) 10Thiemo Mättig (WMDE): "Oh, darn. This could actually clash with my I2cd252c because I'm suppressing the static toolbar buttons not only in non-editable diff/old " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 (owner: 10Henning Snater) [11:18:24] 3MediaWiki extensions / 3WikidataClient: Argument 1 passed to WikibaseLuaBindings::renumber() must be an array, integer given - 10https://bugzilla.wikimedia.org/72180 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Catchable fatal error: Argument 1 passed to Wikibase\Client\Scribunto\WikibaseLuaBi... [11:18:37] Henning_WMDE: ok. sounds good. [11:18:39] thx! [11:20:43] (03Merged) 10jenkins-bot: Fix conditional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167181 (owner: 10Adrian Lang) [11:21:23] (03Merged) 10jenkins-bot: Use stricter .jshintrc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167178 (owner: 10Adrian Lang) [11:23:13] aude: what do those warnings actually mean? [11:23:29] idk, other than a memory issue [11:23:51] apc related afaik [11:37:40] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Factor connection management into separate class. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165260 (owner: 10Daniel Kinzler) [11:52:14] (03CR) 10Daniel Kinzler: Rewrite label/description conflict detection. (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [11:52:37] (03PS6) 10Daniel Kinzler: Rewrite label/description conflict detection. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) [11:56:06] [13WikibaseSerializationJavaScript] 15adrianlang comment on pull request #6 14e04c69a: It's currently called UnUnserializableValue. 02http://git.io/PuVSLw [12:04:33] (03PS1) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [12:05:51] (03PS2) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [12:15:29] (03CR) 10jenkins-bot: [V: 04-1] Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 (owner: 10Henning Snater) [12:21:26] [13WikibaseDataModel] 15filbertkm created 06idparser (+1 new commit): 02http://git.io/VhbLrA [12:21:26] 13WikibaseDataModel/06idparser 14dabb5c8 15aude: Avoid use of BasicEntityIdParser... [12:22:44] [13WikibaseDataModel] 15filbertkm opened pull request #247: Avoid use of BasicEntityIdParser (06master...06idparser) 02http://git.io/PLOWYA [12:23:55] wmde/WikibaseDataModel/idparser/dabb5c8 : aude The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38255164 [12:46:13] [13WikibaseDataModel] 15mariushoch comment on pull request #246 14e952789: type hint here would have been nice 02http://git.io/pArH6A [12:46:23] [13WikibaseDataModel] 15mariushoch 04deleted 06BasicEntityIdParser at 14e952789: 02http://git.io/1eqHkw [12:52:53] DanielK_WMDE: Any opinion on https://gerrit.wikimedia.org/r/166522 ? [12:56:03] (03CR) 10Henning Snater: "Regardless of that the static toolbars should be there with proper links (the Special pages not existing is another issue though), this ch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 (owner: 10Henning Snater) [12:56:46] (03PS3) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [13:08:16] (03CR) 10jenkins-bot: [V: 04-1] Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 (owner: 10Henning Snater) [13:12:29] (03PS4) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [13:20:25] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=62188 [13:31:06] (03CR) 10Hoo man: [C: 032] Add missing HTML element slashes to jQuery calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167174 (owner: 10Thiemo Mättig (WMDE)) [13:34:12] JeroenDeDauw: https://github.com/wmde/WikibaseDataModelSerialization/pull/96#event-179901982 which version of Q183 was that? [13:34:42] the frozen (small) one or the large, new serialization one which broke [13:40:24] (03Merged) 10jenkins-bot: Add missing HTML element slashes to jQuery calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167174 (owner: 10Thiemo Mättig (WMDE)) [13:43:49] (03CR) 10Hoo man: [C: 032] "Nice now :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167173 (owner: 10Thiemo Mättig (WMDE)) [13:45:14] (03CR) 10Hoo man: [C: 032] JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [13:46:37] 3MediaWiki extensions / 3WikidataRepo: wbgetentities language fallback inconsistencies - 10https://bugzilla.wikimedia.org/72038#c1 (10Daniel Kinzler) In JSON, this is represented by the label's key being different from the value of the language field. I agree that it would be nicer to have this modelled expl... [13:48:25] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The serializer needs to be able to represent language fallback - that is, they key used for a label or... [13:48:37] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10Daniel Kinzler) [13:48:37] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10Daniel Kinzler) [13:49:57] (03CR) 10Hoo man: [C: 04-1] "Needs a rebase...fine despite ;)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167175 (owner: 10Thiemo Mättig (WMDE)) [13:57:28] (03Merged) 10jenkins-bot: Simplify background CSS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167173 (owner: 10Thiemo Mättig (WMDE)) [13:57:33] (03Merged) 10jenkins-bot: JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [13:58:10] (03CR) 10Aude: [C: 04-1] "manually tested and works as expected :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [14:06:53] (03PS18) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) [14:07:48] (03PS19) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) [14:12:56] (03PS4) 10Daniel Kinzler: Factor connection management into separate class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165260 [14:14:55] (03PS5) 10Daniel Kinzler: Factor connection management into separate class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165260 [14:15:21] (03CR) 10Daniel Kinzler: [C: 04-1] "needs rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 (owner: 10Adrian Lang) [14:17:21] !review https://github.com/DataValues/Geo/pull/25 [14:17:21] https://bit.ly/wdrieview [14:17:41] !merge https://github.com/DataValues/Geo/pull/25 [14:17:42] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/https://github.com/DataValues/Geo/pull/25/ [14:18:12] meeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeerrrrrrrrrrrge! [14:24:57] (03CR) 10Henning Snater: [C: 04-1] "Why are you doing that without any discussion? -> http://www.mediawiki.org/wiki/Wikibase/Coding_conventions#jQuery_DOM_element_creation" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167175 (owner: 10Thiemo Mättig (WMDE)) [14:24:59] (03PS16) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) [14:27:17] (03PS1) 10Adrian Lang: Introduce basic test for entityview, fix wrong template usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167204 [14:30:23] (03PS1) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 [14:30:53] (03CR) 10Adrian Lang: [C: 04-1] "work in progress." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [14:35:24] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [14:48:34] [13Geo] 15filbertkm comment on pull request #25 1441d4c36: agree... 'The GlobeCoordinateFormatter can only format instances of GlobeCoordinateValue.' would be ok here 02http://git.io/o_F21A [14:49:43] (03CR) 10JanZerebecki: [C: 032] Re-add .jshintignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167180 (owner: 10Adrian Lang) [14:51:49] mariushoch/mediawiki-extensions-Wikibase/hhvmTest/5025e40 : Marius Hoch The build passed. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/38268045 [14:52:49] Fatal error: String length exceeded 2^31-2: 2147483647 in /home/travis/build/mariushoch/phase3/extensions/Wikibase/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php on line 1681 [14:52:50] wooot [14:53:22] aude: ^ Any idea? [14:53:41] We had such things before, not sure how we fixed/ work arounded then [14:53:53] we need to use later version of phpunit [14:54:00] m( [14:54:03] but 72040 [14:54:05] That easy? [14:54:09] hhvm issue [14:54:46] probably, but then when i tried, i did something wrong and got another error [14:54:54] * aude doesn't know what i'm doing [14:55:49] mariushoch/mediawiki-extensions-Wikibase/master/c0eaf4f : jenkins-bot The build was canceled. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/38267958 [14:55:49] Ok... I'm looking a bit today [14:55:53] not sure I can get anything [14:55:53] done [14:55:54] great [14:56:01] should probably make travis not post here [14:56:05] if not, someone will look since it's in the sprint [14:57:39] Yeah, let's see how far I get [15:05:26] [13Geo] 15JanZerebecki 04force-pushed 06cleanup from 1441d4c36 to 1473a98dd: 02http://git.io/B6N7Ug [15:05:26] 13Geo/06cleanup 14c0beaed 15Jan Zerebecki: Use original class name instead of alias. [15:05:26] 13Geo/06cleanup 1480f05e3 15Jan Zerebecki: Remove instanceof check as the argument is already of that type. [15:05:26] 13Geo/06cleanup 14ae99e40 15Jan Zerebecki: Test GeoCoordinateFormatter with wrong target type. [15:06:35] (03Merged) 10jenkins-bot: Re-add .jshintignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167180 (owner: 10Adrian Lang) [15:10:37] 3MediaWiki extensions / 3WikidataClient: Parser function #ifeq with #property gives wrong result on zhwp - 10https://bugzilla.wikimedia.org/67988#c3 (10Marius Hoch) 5UNCO>3RESO/WON Per above, this is not anything we can easily change... the parser function should only be used for very simply display logi... [15:15:23] 3MediaWiki extensions / 3WikidataRepo: wbgetentities should apply basic normalization to titles in parameters. - 10https://bugzilla.wikimedia.org/45131#c4 (10Marius Hoch) 5NEW>3RESO/FIX Not sure when this was fixed, but it seems to be fixed now: https://www.wikidata.org/w/api.php?action=wbgetentities&si... [15:37:37] 3Wikimedia / 3Wikidata: $wgAppleTouchIcon is wrong for Wikidata (showing Wikipedia logo) - 10https://bugzilla.wikimedia.org/70996#c9 (10John F. Lewis) 5PATC>3RESO/FIX Seems fixed (confirmed). [15:39:09] HELLO [15:42:37] 3MediaWiki extensions / 3WikidataRepo: Add move gadget to Wikibase core - 10https://bugzilla.wikimedia.org/72019#c2 (10John F. Lewis) p:5Unprio>3Lowest s:5normal>3minor Lowest and Minor if we're undecided. In the core as a gadget probably not. In the core as a feature - yeah but likely to be obsolet... [15:49:37] 3MediaWiki extensions / 3WikidataRepo: Re-enable quick editing in Wikidata - 10https://bugzilla.wikimedia.org/71845 (10John F. Lewis) p:5Unprio>3Normal [15:50:52] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508 (10John F. Lewis) p:5Unprio>3Normal [15:54:08] 3MediaWiki extensions / 3WikidataClient: Create widget to edit site links in the client - 10https://bugzilla.wikimedia.org/72178 (10John F. Lewis) p:5Unprio>3Low [15:54:22] 3MediaWiki extensions / 3WikidataClient: Argument 1 passed to WikibaseLuaBindings::renumber() must be an array, integer given - 10https://bugzilla.wikimedia.org/72180 (10John F. Lewis) p:5Unprio>3Normal [15:55:07] 3MediaWiki extensions / 3WikidataRepo: maintenance/importDump.php fails for wikidatawiki XML incremental dump files - 10https://bugzilla.wikimedia.org/70898 (10John F. Lewis) p:5Unprio>3Normal [15:55:37] 3MediaWiki extensions / 3WikidataRepo: assertValidHtmlSnippet fails for lots of HTML generated in Wikibase - 10https://bugzilla.wikimedia.org/70232 (10John F. Lewis) p:5Unprio>3Normal [15:56:22] 3MediaWiki extensions / 3WikidataRepo: Create a Wikibase glossary - 10https://bugzilla.wikimedia.org/70763#c3 (10John F. Lewis) p:5Unprio>3Low s:5normal>3minor It is a fair idea looking at it basically. [15:56:52] 3MediaWiki extensions / 3WikidataRepo: eliminate settings closure in WikibaseLib.default.php - 10https://bugzilla.wikimedia.org/71565 (10John F. Lewis) p:5Unprio>3Normal [15:57:38] 3MediaWiki extensions / 3WikidataRepo: deep copy of Entity is made when calling Revision::getContent() - 10https://bugzilla.wikimedia.org/72158 (10John F. Lewis) p:5Unprio>3Normal [15:57:52] 3MediaWiki extensions / 3WikidataRepo: Label/Description uniqueness constraint is not enforced by Special:NewItem, leading to duplicates. - 10https://bugzilla.wikimedia.org/72085 (10John F. Lewis) p:5Unprio>3Normal [15:58:52] 3MediaWiki extensions / 3WikidataRepo: Wikidata should use style guide - 10https://bugzilla.wikimedia.org/71271#c3 (10John F. Lewis) p:5Unprio>3Normal I'll poke Lydia to look at this Jared. [15:59:37] 3MediaWiki extensions / 3WikidataRepo: Create a new datatype "count" similar to "quantity". - 10https://bugzilla.wikimedia.org/70341 (10John F. Lewis) p:5Unprio>3Low [15:59:52] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10John F. Lewis) p:5Unprio>3Normal [16:00:09] 3MediaWiki extensions / 3WikidataRepo: wbgetentities language fallback inconsistencies - 10https://bugzilla.wikimedia.org/72038 (10John F. Lewis) p:5Unprio>3Normal [16:09:08] 3MediaWiki extensions / 3WikidataClient: pencil icon for "Edit links" should use wikifont - 10https://bugzilla.wikimedia.org/65527#c5 (10Marius Hoch) I played with this for a bit and the icon doesn't look very nice (it's not identifiable as a pencil) downscaled to the size we need for the sidebar. [16:39:47] (03PS1) 10Daniel Kinzler: Defer entity deserialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167223 [16:39:55] (03CR) 10jenkins-bot: [V: 04-1] Defer entity deserialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167223 (owner: 10Daniel Kinzler) [16:40:44] (03PS2) 10Daniel Kinzler: Defer entity deserialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167223 [16:40:51] (03CR) 10jenkins-bot: [V: 04-1] Defer entity deserialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167223 (owner: 10Daniel Kinzler) [16:41:09] (03Abandoned) 10Daniel Kinzler: Defer entity deserialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167223 (owner: 10Daniel Kinzler) [17:08:32] Lydia_WMDE: I'm seeing a lot of "wikibase-conflict-patched"'s. Is that Wikibase acting up or did something change? [17:15:28] hoo: it's one from a recentish JSON dump. [17:15:43] Recently some bump broke and had to be fixed - this is from the one before [17:17:43] (03CR) 10Thiemo Mättig (WMDE): Refactor RepoHooks::onOutputPageBodyAttributes (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [17:20:10] (03PS1) 10Hoo man: Always show link to wikibase item in toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) [17:20:15] More static code :( [17:20:40] But that's one the paper cuts that I personally hit quite a bit :P [17:20:44] * one of [17:27:29] (03CR) 10Jeroen De Dauw: "Did a quick scan not looking at the details and did not spot any problems. +0.5" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [17:31:00] aude: :S Only way I found to run tests on travis with MW and latest phpunit is to load the phar and use that [17:31:11] the install by travis doesn't work with MW [17:31:29] Unless I missed anything [17:31:51] it seems to work for core... but even if I invoke stuff in the same way, they do, it doesn't work for me [17:32:15] if the phar works then ok with me [17:32:29] aude: Trying that on my github fork right now [17:32:41] ok [17:32:47] If I can make the tests pass, I'll of course submit changes to gerrit [17:36:08] 3MediaWiki extensions / 3WikidataRepo: timeout when editing an item alias or description - 10https://bugzilla.wikimedia.org/63763#c1 (10Marius Hoch) 5NEW>3RESO/WOR Works for me, even on Zend: https://www.wikidata.org/w/index.php?title=Q4167836&diff=165007263&oldid=164325411 [17:36:35] Lydia_WMDE: that video has a high amount of Lydianess [17:37:24] * hoo wants a link :D [17:37:39] overcurious hoo is overcurious again [17:38:12] * aude eat [17:38:46] aude: Pizza? :D [17:40:21] with new phpunit tests even fail on Zend :S [17:43:37] oh, that's stupid [17:43:40] just stupid :D [17:47:39] (03PS1) 10Hoo man: Don't access unset property in SnakSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167237 [17:58:16] hoo: what PHPUnit version? And what tests? Core? [17:58:47] our tests [17:59:24] JeroenDeDauw: https://s3.amazonaws.com/archive.travis-ci.org/jobs/38283915/log.txt [17:59:41] (search for "Undefined index: property" if you care) [18:00:13] Not sure how to handle assertTag, though [18:00:21] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/2hX3nQ [18:00:22] 13Geo/06master 146d2ba3b 15Jeroen De Dauw: Merge pull request #25 from DataValues/cleanup... [18:00:59] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/l1Twjw [18:00:59] 13Geo/06master 141c07f62 15Jeroen De Dauw: Update composer.json [18:01:11] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/km6EoA [18:01:11] 13Geo/06master 14b53995d 15Jeroen De Dauw: Update Geo.php [18:03:56] JeroenDeDauw: Merrrrgee? :) [18:04:55] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #246 14e952789: Small scope... I'd have added one if IDE was not able to figure out the type of the field, but it was 02http://git.io/zbKijA [18:16:52] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #247 14dabb5c8: good *catch* :D 02http://git.io/c-fR_Q [18:18:59] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06idparser at 14dabb5c8: 02http://git.io/0iDMnA [18:25:06] hoo: does this mean I have to rant even moar about WB.git? ;p [18:25:38] (03CR) 10Jeroen De Dauw: [C: 032] Don't access unset property in SnakSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167237 (owner: 10Hoo man) [18:25:50] hoo: oh ffs, another bunch of time wasted in that old serialization code [18:26:05] y no one kill it and use the new one instead?! ahhh [18:26:09] JeroenDeDauw: Well... you wont like how we replace assertTag... [18:26:20] As that's even worse :S [18:27:54] (03CR) 10Jeroen De Dauw: Always show link to wikibase item in toolbox (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) (owner: 10Hoo man) [18:29:41] (03PS1) 10Hoo man: Be evil and use MediaWikiTestCase::assertTag for phpunit 4.3 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167245 [18:31:14] JeroenDeDauw: https://gerrit.wikimedia.org/r/167245 :( [18:31:28] But only way forward I see to get compatibility now [18:36:36] (03Merged) 10jenkins-bot: Don't access unset property in SnakSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167237 (owner: 10Hoo man) [18:40:13] m( [18:40:19] so much brokenness [18:41:57] hoo: is MW itself still broken with PHPUnit 4.x? If not, then we can just stop caring about PHPUnit legacy? [18:42:22] JeroenDeDauw: No, it works with PHPunit 4 these days [18:42:27] but we arent... [18:43:30] (03CR) 10Jeroen De Dauw: [C: 032] "Eviiiiiiiiiiiiiiiiiiil" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167245 (owner: 10Hoo man) [18:43:45] JeroenDeDauw: I forgot one place [18:44:17] (03PS2) 10Hoo man: Be evil and use MediaWikiTestCase::assertTag for phpunit 4.3 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167245 [18:44:22] +2 again? :) [18:55:10] (03PS1) 10Hoo man: Make getLocationAgnosticMwApi work if both APIs are on the same domain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 [18:57:26] (03CR) 10Hoo man: "We had this in our old code, but it was removed during the API refactor (and I think I even approved that thinking jQuery was smart enough" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [18:58:00] DanielK_WMDE: JeroenDeDauw: Anyone +2 https://gerrit.wikimedia.org/r/167245 ? [18:58:19] (03CR) 10Jeroen De Dauw: [C: 032] "Ugh... this code has soooo many issues." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [18:58:55] benestar|cloud: rebaaaaaase https://gerrit.wikimedia.org/r/#/c/158641/ [18:59:30] (03CR) 10Jeroen De Dauw: [C: 032] Be evil and use MediaWikiTestCase::assertTag for phpunit 4.3 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167245 (owner: 10Hoo man) [18:59:37] JeroenDeDauw: \o/ [18:59:39] :) [19:02:30] hoo: your are now certified evil, level 3 [19:02:51] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [19:04:07] multichill: where are you seeing it? [19:04:10] :D [19:04:16] JeroenDeDauw: lol [19:05:56] (03PS1) 10Hoo man: Use latest phpunit (4.3.3) on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167253 [19:08:41] Unrecognized value for parameter 'action': wbgetentities [19:08:44] ouh [19:08:55] oh, I messed [19:20:32] (03PS2) 10Hoo man: Make getLocationAgnosticMwApi work if both APIs are on the same domain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 [19:22:22] time for a break [19:44:55] [19:49:39] (03PS2) 10Hoo man: Use latest phpunit (4.3.3) on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167253 [20:00:08] 3MediaWiki extensions / 3WikidataClient: Showing only language without project during linking pages to Wikidata item from client - 10https://bugzilla.wikimedia.org/69790#c8 (10Marius Hoch) (In reply to Lydia Pintscher from comment #6) > I don't see a link in the dialog. The text should probably be clearer to... [20:00:12] (03CR) 10Aude: [C: 032] "looks sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167253 (owner: 10Hoo man) [20:00:34] aude: Will still fail for hhvm [20:00:39] but were much close now [20:01:23] that's ok (well not really, but progress) [20:01:51] satisfies the sprint task [20:02:12] It's something :P [20:02:40] Well, it actually doesn't [20:02:45] going to comment on the bug, though [20:03:21] ok [20:03:52] I wouldn't have guest it's so much work [20:03:56] * guessed [20:04:08] Starting test 'Wikibase\Test\Api\GetClaimsTest::testGetInvalidClaims with data set #1 ('x$y$z')'. [20:04:08] ./build/travis/script.sh: line 7: 2991 Killed php phpunit.php --debug --group Wikibase [20:04:35] oh noes [20:04:37] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Travis is failing for Wikibase tests on HHVM - 10https://bugzilla.wikimedia.org/72040#c1 (10Marius Hoch) I just spent quite some time to actually make our tests work with PHPUnit 4 and made travis use phpunit 4. That was a pre-requirement towards having the tests... [20:07:53] 3MediaWiki extensions / 3WikidataClient: U+202F NARROW NO-BREAK SPACE not editable - 10https://bugzilla.wikimedia.org/60828#c3 (10Marius Hoch) It no longer blocks the interface, but also it's not changeable... that's probably because: 22:07:27.510 $.trim( ' ' /* U+202F NARROW NO-BREAK SPACE */ ) === '' 22:0... [20:08:39] (03Merged) 10jenkins-bot: Use latest phpunit (4.3.3) on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167253 (owner: 10Hoo man) [20:11:07] 3MediaWiki extensions / 3WikidataClient: U+202F NARROW NO-BREAK SPACE not editable - 10https://bugzilla.wikimedia.org/60828#c4 (10Marius Hoch) We should probably use a trim function in JS and in PHP which do exactly the same (that might mean making NARROW NO-BREAK SPACE not usable as label/ alias). [20:24:07] 3MediaWiki extensions / 3WikidataClient: Showing only language without project during linking pages to Wikidata item from client - 10https://bugzilla.wikimedia.org/69790 (10Marius Hoch) [20:24:07] 3MediaWiki extensions / 3WikidataClient: JS adding Interwiki tool shows wiki commons as english - 10https://bugzilla.wikimedia.org/69388#c2 (10Marius Hoch) 5NEW>3RESO/WOR Commons appears as commons for me (tested on a Wikipedia). [20:29:37] 3MediaWiki extensions / 3WikidataClient: Link for adding interwiki does not work on Swedish Wikipedia - 10https://bugzilla.wikimedia.org/66521 (10Marius Hoch) [20:29:52] 3MediaWiki extensions / 3WikidataClient: login issue with add language links widget - 10https://bugzilla.wikimedia.org/48389 (10Marius Hoch) [20:32:38] (03PS4) 10Ebrahim: Use wgULSLanguages for retrieving language names on users' UI language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 [20:43:56] (03PS5) 10Ebrahim: Use wgULSLanguages for retrieving language names on users' UI language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 [20:56:29] (03CR) 10Thiemo Mättig (WMDE): Display full year if precision is to high (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166622 (https://bugzilla.wikimedia.org/67604) (owner: 10Thiemo Mättig (WMDE)) [21:01:24] (03PS1) 10Thiemo Mättig (WMDE): Do not show year "minus zero" as fallback [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167313 [21:11:22] 3MediaWiki extensions / 3WikidataClient: Link for adding interwiki does not work on Swedish Wikipedia - 10https://bugzilla.wikimedia.org/66521#c6 (10Marius Hoch) 5NEW>3RESO/WOR I've just played around with this for a bit and couldn't reproduce the issues with the compact personal toolbar. The rest is bug... [21:13:10] 3MediaWiki extensions / 3WikidataClient: Insert link item for adding language links in PHP - 10https://bugzilla.wikimedia.org/61391#c1 (10Marius Hoch) I think we at some point decided that such a non-JS link would be confusing and is essentially unwanted? [21:14:25] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Sorry, I was going to merge that but wanted to run at least a quick manual test (start editing a label/description/alias and cancel). Didn" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166589 (owner: 10Henning Snater) [21:17:24] 3MediaWiki extensions / 3WikidataRepo: Lua error: Failed to serialize data. - 10https://bugzilla.wikimedia.org/71918#c1 (10Marius Hoch) 5NEW>3UNCO Do you have steps to reproduce or at least a test case where I can see the bug right now? If not, I assume this was just some kind of temporary hiccup... [21:52:53] (03PS2) 10Hoo man: Always show link to wikibase item in toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) [21:53:18] (03CR) 10Hoo man: Always show link to wikibase item in toolbox (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) (owner: 10Hoo man) [21:55:43] Lydia_WMDE: Bot [21:55:47] Every second edit [21:56:53] high latency talks... :D [22:19:35] (03PS3) 10Hoo man: Don't show dead edit links in diff/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167177 (https://bugzilla.wikimedia.org/72177) (owner: 10Thiemo Mättig (WMDE)) [22:24:03] (03CR) 10Hoo man: [C: 032] Don't show dead edit links in diff/old revisions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167177 (https://bugzilla.wikimedia.org/72177) (owner: 10Thiemo Mättig (WMDE)) [22:24:25] (03PS3) 10Hoo man: Do not start any JavaScript in diffs/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167182 (owner: 10Thiemo Mättig (WMDE)) [22:29:34] (03CR) 10Hoo man: [C: 032] "Can't find any regressions... and viewing diffs is extremely fast now. Awesome!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167182 (owner: 10Thiemo Mättig (WMDE)) [22:30:07] 3MediaWiki extensions / 3WikidataRepo: Old revisions should not show edit links. - 10https://bugzilla.wikimedia.org/72177 (10Marius Hoch) 5PATC>3RESO/FIX [22:39:28] (03Merged) 10jenkins-bot: Don't show dead edit links in diff/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167177 (https://bugzilla.wikimedia.org/72177) (owner: 10Thiemo Mättig (WMDE)) [22:40:19] (03Merged) 10jenkins-bot: Do not start any JavaScript in diffs/old revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167182 (owner: 10Thiemo Mättig (WMDE)) [22:42:59] Once you reach the point of installing gdb on travis... meh :P [22:52:22] (03CR) 10Hoo man: [C: 04-1] "Nice... should probably be rebased on top of the RL lazy loading stuff also in gerrit." [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/164560 (owner: 10Jackmcbarn) [22:59:21] hoo: your change is outdated and is based on another outdated change [22:59:30] can you rebase them on top of HEAD, then i'll rebase mine on top of them? [22:59:41] or can i just rebase mine on top of HEAD, then you rebase yours on top of mine? [23:00:35] Yeah... but not today, maybe tomorrow [23:00:57] hoo: can i go the second route then, just putting mine on top of HEAD? [23:01:36] My changes are rather small, so should be ok [23:06:23] 3MediaWiki extensions / 3WikidataClient: Showing only language without project during linking pages to Wikidata item from client - 10https://bugzilla.wikimedia.org/69790#c9 (10Beta16) (In reply to Marius Hoch from comment #8) > So... what should we do here? Only show links to other pages of the same > projec... [23:06:27] (03PS2) 10Jackmcbarn: Convert Capiunto to a delayed-load module [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/164560 [23:32:45] (03CR) 10Legoktm: Conditionally add the "capiunto.infobox.main" RL module (031 comment) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163065 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [23:37:39] wow... our tests seem to use almost 12gb of ram on travis with hhvm [23:37:41] wtf [23:46:52] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Travis is failing for Wikibase tests on HHVM - 10https://bugzilla.wikimedia.org/72040#c2 (10Marius Hoch) Right now this is failing because hhvm gets OOM killed on travis. This *might* be caused by hhvm nightly beeing broken (so just trying again next week might w... [23:47:13] that's fun [23:57:57] [13Diff] 15mariushoch created 06nonNyan (+1 new commit): 02http://git.io/dgnpvQ [23:57:57] 13Diff/06nonNyan 1452f8eed 15Marius Hoch: Don't use fancy printer