[08:08:51] (03CR) 10Adrian Lang: [C: 04-1] "I would prefer the old behavior to be replaced with the new one instead of adding a new function and leaving the old one without external " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [08:18:47] [13Wikidata.org] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/MNVSrw [08:18:47] 13Wikidata.org/06master 14e001c5a 15aude: Replace use of NamespaceUtils... [08:18:47] 13Wikidata.org/06master 14508da5a 15thiemowmde: Merge pull request #16 from wmde/namespaceutils... [08:24:36] (03CR) 10Adrian Lang: [C: 04-1] "Looks ok except two things." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [08:32:15] (03PS6) 10Adrian Lang: Simplify and generalize array handling in SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 [08:34:02] (03CR) 10Adrian Lang: [C: 04-1] "Needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) (owner: 10Daniel Kinzler) [09:08:50] Jenkins is being restarted [09:10:16] (03PS2) 10Thiemo Mättig (WMDE): Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 [09:10:43] (03CR) 10Thiemo Mättig (WMDE): "All done plus some more improvements." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [09:17:17] (03PS13) 10Adrian Lang: Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 [09:18:56] 3MediaWiki extensions / 3WikidataRepo: Find a way to associate Wikipedia article sections with Wikidata items - 10https://bugzilla.wikimedia.org/72347 (10dacuetu) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Some Wikipedias combine topics in one single article page, and that makes hard to connect each o... [09:19:24] 3MediaWiki extensions / 3WikidataRepo: Find a way to associate Wikipedia article sections with Wikidata items - 10https://bugzilla.wikimedia.org/72347 (10dacuetu) [09:19:38] 3MediaWiki extensions / 3WikidataRepo: Allow sitelinks to wikipedia and wikivoyage redirect pages to fix the 'Bonnie and Clyde problem' - 10https://bugzilla.wikimedia.org/52564 (10dacuetu) [09:33:26] (03PS3) 10Thiemo Mättig (WMDE): Use localized (in the UI language) language names in messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 [09:34:37] (03CR) 10Thiemo Mättig (WMDE): "Yea, "native" is misleading. I reworked the patch completely but kept the old function name for compatibility reasons (it's probably used " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [09:34:48] (03CR) 10Adrian Lang: [C: 031] Use localized (in the UI language) language names in messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [09:38:27] [13WikibaseDatabase] 15JeroenDeDauw created 06mvcore (+1 new commit): 02http://git.io/tVdZRw [09:38:27] 13WikibaseDatabase/06mvcore 143928a48 15jeroendedauw: Update git repo path of MW core [09:40:42] wmde/WikibaseDatabase/mvcore/3928a48 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/38692289 [09:43:24] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #50: Update git repo path of MW core (06master...06mvcore) 02http://git.io/PI_8Sw [09:46:07] wmde/WikibaseDatabase/master/11f78ca : Jeroen De Dauw The build was fixed. http://travis-ci.org/wmde/WikibaseDatabase/builds/38692623 [09:46:26] [13WikibaseDatabase] 15JeroenDeDauw 04force-pushed 06rmescp from 1489ec538 to 149c9fdf4: 02http://git.io/OPyywQ [09:46:26] 13WikibaseDatabase/06rmescp 149c9fdf4 15jeroendedauw: Remove escaper code [09:46:39] (03CR) 10jenkins-bot: [V: 04-1] Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [09:48:25] wmde/WikibaseDatabase/rmescp/9c9fdf4 : jeroendedauw The build was fixed. http://travis-ci.org/wmde/WikibaseDatabase/builds/38692855 [09:49:07] [13WikibaseDatabase] 15JeroenDeDauw created 06bootstrap (+1 new commit): 02http://git.io/f34Myw [09:49:07] 13WikibaseDatabase/06bootstrap 141b7faba 15jeroendedauw: Update PHPUnit boottsrap [09:50:47] [13WikibaseDatabase] 15JeroenDeDauw created 06rmtodo (+1 new commit): 02http://git.io/zk8bWQ [09:50:47] 13WikibaseDatabase/06rmtodo 14e08689b 15jeroendedauw: Remove TODO... [09:50:58] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #52: Remove TODO (06master...06rmtodo) 02http://git.io/DfhyoQ [09:51:23] wmde/WikibaseDatabase/bootstrap/1b7faba : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/38693062 [09:52:51] wmde/WikibaseDatabase/rmtodo/e08689b : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/38693178 [09:56:33] [13WikibaseDatabase] 15JeroenDeDauw created 06upreadme (+1 new commit): 02http://git.io/azCNNA [09:56:33] 13WikibaseDatabase/06upreadme 142f8c5fb 15jeroendedauw: Update the readme [09:56:43] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #53: Update the readme (06master...06upreadme) 02http://git.io/C-R5zw [09:58:20] wmde/WikibaseDatabase/upreadme/2f8c5fb : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/38693529 [10:08:51] (03CR) 10Jeroen De Dauw: [C: 032] Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 (owner: 10Adrian Lang) [10:17:48] (03CR) 10Jeroen De Dauw: "Rebase needed. More time wasted..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [10:19:53] (03PS2) 10Thiemo Mättig (WMDE): Fix code smell in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 [10:20:26] (03CR) 10Thiemo Mättig (WMDE): "Reworked, please have a look." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 (owner: 10Thiemo Mättig (WMDE)) [10:22:06] [13WikibaseDatabase] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/idTBhQ [10:22:06] 13WikibaseDatabase/06master 14906ecd3 15thiemowmde: Merge pull request #52 from wmde/rmtodo... [10:22:56] [13WikibaseDatabase] 15thiemowmde 04deleted 06bootstrap at 141b7faba: 02http://git.io/HYgtZQ [10:24:38] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "Please ignore this patch for now. I will move it to the end of the chain." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [10:51:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "How did that happen?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166974 (owner: 10Adrian Lang) [10:52:03] (03CR) 10Adrian Lang: "I did that happen." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166974 (owner: 10Adrian Lang) [10:52:39] (03PS2) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 [10:52:41] (03PS3) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [10:52:43] (03PS1) 10Adrian Lang: Add referenceview.isInitialValue test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168059 [10:59:23] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [11:02:34] (03Merged) 10jenkins-bot: Actually put wb.client.getMwApiForRepo in wb.client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166974 (owner: 10Adrian Lang) [11:25:22] 3MediaWiki extensions / 3WikidataClient: allow accessing data from an item not connected to the current page - arbitrary access (tracking) - 10https://bugzilla.wikimedia.org/47930#c16 (10Florian) (In reply to Sergey Vladimirov from comment #15) > Why is this bug depends on 44946 and 68029? Doesn't look like... [11:36:15] (03PS5) 10Daniel Kinzler: Check label/description constraint for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) [11:37:51] (03CR) 10Daniel Kinzler: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) (owner: 10Daniel Kinzler) [12:18:25] (03PS1) 10Adrian Lang: Fix inverted logic introduced in 835b57feb8470ff1d [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168064 [12:18:55] (03PS1) 10Henning Snater: Reapplied sitelinkgroupview/sitelinklistview focusing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168065 [12:21:57] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Still lots of confusing variable names and some confusing method names. I will change them in a (much later) follow up. Let's move on!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [12:22:40] (03CR) 10Aude: [C: 032] Fix inverted logic introduced in 835b57feb8470ff1d [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168064 (owner: 10Adrian Lang) [12:22:49] [13WikibaseDatabase] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/S7cumw [12:22:49] 13WikibaseDatabase/06master 14c082c10 15Marius Hoch: Merge pull request #53 from wmde/upreadme... [12:32:22] (03CR) 10jenkins-bot: [V: 04-1] Reapplied sitelinkgroupview/sitelinklistview focusing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168065 (owner: 10Henning Snater) [12:32:26] [13ValueView] 15snaterlicious created 06suggesterbackspace (+1 new commit): 02http://git.io/4b0J7A [12:32:26] 13ValueView/06suggesterbackspace 14889f16e 15snaterlicious: $.ui.suggester: Do not trigger search on backspace in empty input [12:32:38] (03PS3) 10Thiemo Mättig (WMDE): Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 [12:33:50] jzerebecki: DanielK_WMDE: ' A test that is annotated with @covers and executes code that is not listed using a @covers or @uses annotation will be marked as risky when this check is enabled. ' [12:34:06] (03CR) 10JanZerebecki: [C: 04-1] Rewrite label/description conflict detection. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [12:35:00] [13ValueView] 15snaterlicious 04force-pushed 06suggesterbackspace from 14889f16e to 14136c76d: 02http://git.io/uy5-FA [12:35:00] 13ValueView/06suggesterbackspace 14136c76d 15snaterlicious: $.ui.suggester: Do not trigger search on backspace in empty input [12:36:04] [13ValueView] 15snaterlicious 04force-pushed 06suggesterbackspace from 14136c76d to 14206e35d: 02http://git.io/uy5-FA [12:36:04] 13ValueView/06suggesterbackspace 14206e35d 15snaterlicious: $.ui.suggester: Do not trigger search on backspace in empty input [12:36:29] Adrian_WMDE: where is that from? [12:36:34] [13ValueView] 15snaterlicious opened pull request #117: $.ui.suggester: Do not trigger search on backspace in empty input (06master...06suggesterbackspace) 02http://git.io/gej86Q [12:36:50] jzerebecki: https://phpunit.de/manual/current/en/strict-mode.html#strict-mode.unintentionally-covered-code [12:37:32] nice! [12:38:16] (03Merged) 10jenkins-bot: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [12:38:24] (03Merged) 10jenkins-bot: Factor connection management into separate class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165260 (owner: 10Daniel Kinzler) [12:38:31] (03Merged) 10jenkins-bot: Fix inverted logic introduced in 835b57feb8470ff1d [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168064 (owner: 10Adrian Lang) [12:43:43] [13ValueView] 15mariushoch comment on pull request #117 14206e35d: This will also prevent updating of this._term which I'm not sure is intended, as that might have side effects. 02http://git.io/Bjp97w [12:44:08] (03PS2) 10Henning Snater: Reapplied sitelinkgroupview/sitelinklistview focusing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168065 [12:49:20] (03CR) 10jenkins-bot: [V: 04-1] Reapplied sitelinkgroupview/sitelinklistview focusing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168065 (owner: 10Henning Snater) [12:49:25] (03PS1) 10Henning Snater: sitelinkview: Do not invoke cancelEditing() in destroy [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168068 [12:53:02] [13ValueView] 15snaterlicious comment on pull request #117 14206e35d: Why should the term be reset when the input is empty already? The change is preventing side effects, for example: Backspace on an empty input is supposed to remove the input in the future under certain circumstances. If an asynchronous search operation is triggerd, a JS error will occur. 02http://git.io/oG3hRg [12:56:51] (03CR) 10jenkins-bot: [V: 04-1] sitelinkview: Do not invoke cancelEditing() in destroy [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168068 (owner: 10Henning Snater) [12:59:01] [13Diff] 15thiemowmde created 06killacat (+1 new commit): 02http://git.io/-vFp9g [12:59:01] 13Diff/06killacat 144c3b6c1 15Thiemo Mättig: Kill the cat [12:59:24] (03CR) 10Daniel Kinzler: Rewrite label/description conflict detection. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [13:00:08] [13Diff] 15thiemowmde opened pull request #17: Kill the cat (06master...06killacat) 02http://git.io/ja9RTA [13:01:31] wmde/Diff#74 (killacat - 4c3b6c1 : Thiemo Mättig): The build passed. [13:01:31] Change view : https://github.com/wmde/Diff/commit/4c3b6c12307a [13:01:31] Build details : http://travis-ci.org/wmde/Diff/builds/38707616 [13:05:28] [13Wikiba.se] 15adrianlang created 06addJsLibs (+1 new commit): 02http://git.io/14ceOA [13:05:28] 13Wikiba.se/06addJsLibs 142e00241 15Adrian Lang: Add JavaScript libraries [13:06:08] [13Wikiba.se] 15adrianlang opened pull request #29: Add JavaScript libraries (06master...06addJsLibs) 02http://git.io/nEt2XQ [13:07:53] (03CR) 10Adrian Lang: Simplify and generalize array handling in SqlUsageTracker (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 (owner: 10Adrian Lang) [13:23:43] (03PS1) 10Adrian Lang: Make CreateRedirectModuleTest actually assert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168070 [13:27:49] [13ValueView] 15snaterlicious 04force-pushed 06suggesterbackspace from 14206e35d to 143297d4d: 02http://git.io/uy5-FA [13:27:49] 13ValueView/06suggesterbackspace 143297d4d 15snaterlicious: $.ui.suggester: Do not trigger search on backspace in empty input [13:28:59] [13ValueView] 15snaterlicious 04force-pushed 06suggesterbackspace from 143297d4d to 14c183112: 02http://git.io/uy5-FA [13:28:59] 13ValueView/06suggesterbackspace 14c183112 15snaterlicious: $.ui.suggester: Do not trigger search on backspace in empty input [13:29:08] (03CR) 10jenkins-bot: [V: 04-1] Make CreateRedirectModuleTest actually assert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168070 (owner: 10Adrian Lang) [13:29:59] [13ValueView] 15thiemowmde 04deleted 06suggesterbackspace at 14c183112: 02http://git.io/XmmUVw [13:30:32] oh gah, master is broken? [13:30:56] * aude rage at the core folks [13:32:31] aude: How so? [13:32:40] token stuff changed [13:33:02] probably trivial to update our test [13:33:07] Ah, I see [13:33:14] Something was announced, wasn't it? [13:33:19] i think so [13:36:56] slooooooooooooooow tests [13:55:13] (03PS1) 10Henning Snater: Allow siteselector to dynamically retrieve site objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168072 [13:55:38] (03PS1) 10Aude: Update EditEntityActionTest, per change in core token handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168073 [13:57:05] Adrian_WMDE: Henning_WMDE ^ [13:57:09] meeeeeeeeeeeeeerge [13:57:21] :) [14:01:23] (03PS13) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [14:01:48] (03PS5) 10Adrian Lang: Introduce DescriptionsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 [14:02:02] (03PS5) 10Adrian Lang: Introduce LabelsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 [14:02:09] (03PS7) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (https://bugzilla.wikimedia.org/56246) [14:04:37] (03PS4) 10Adrian Lang: Remove wikibase.getRevisionStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166077 [14:05:35] Henning_WMDE, Adrian_WMDE: https://www.youtube.com/watch?v=pPBjvVgKAAM [14:08:12] (03CR) 10Ebrahim: [C: 031] Use localized (in the UI language) language names in messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [14:16:00] (03PS1) 10Henning Snater: Upgraded sitelinkview focus flow [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168075 [14:16:09] (03CR) 10jenkins-bot: [V: 04-1] Allow siteselector to dynamically retrieve site objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168072 (owner: 10Henning Snater) [14:16:11] (03CR) 10jenkins-bot: [V: 04-1] Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [14:16:13] (03CR) 10jenkins-bot: [V: 04-1] Introduce DescriptionsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 (owner: 10Adrian Lang) [14:16:15] (03CR) 10jenkins-bot: [V: 04-1] Introduce LabelsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 (owner: 10Adrian Lang) [14:16:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Update EditEntityActionTest, per change in core token handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168073 (owner: 10Aude) [14:18:30] (03PS1) 10Henning Snater: Optimized sitelinkgroupview toolbar definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168076 [14:23:06] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 143aa331d: "Simple" is like "new". Will lead to "more simple", "even simpler", ... ;-)... 02http://git.io/F4ECkg [14:23:20] (03CR) 10jenkins-bot: [V: 04-1] Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (https://bugzilla.wikimedia.org/56246) (owner: 10Adrian Lang) [14:23:22] (03CR) 10jenkins-bot: [V: 04-1] Remove wikibase.getRevisionStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166077 (owner: 10Adrian Lang) [14:23:36] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 143aa331d: Ok. 02http://git.io/kj7qqQ [14:26:48] (03CR) 10jenkins-bot: [V: 04-1] Upgraded sitelinkview focus flow [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168075 (owner: 10Henning Snater) [14:27:14] (03CR) 10jenkins-bot: [V: 04-1] Optimized sitelinkgroupview toolbar definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168076 (owner: 10Henning Snater) [14:27:16] (03Merged) 10jenkins-bot: Update EditEntityActionTest, per change in core token handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168073 (owner: 10Aude) [14:29:07] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 143aa331d: Oh. PHP keeps confusing me. You are right, but wait, isn't that a violation of the Liskov Substitution Principle we just discussed this Monday? 02http://git.io/Fg8B1A [14:50:42] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 143aa331d: Not sure if this is helpful or needed, but couldn't this be reimplemented by checking all inserters in the array? The class can still derive from the interface then. I think it makes sense to do this.... 02http://git.io/vpttwg [14:56:29] (03Draft1) 10Aude: Some cleanup in action tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168077 [14:58:11] (03PS1) 10Henning Snater: Added $.wikibase.sitelinkview.isEmpty() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168081 [15:04:14] (03CR) 10jenkins-bot: [V: 04-1] Added $.wikibase.sitelinkview.isEmpty() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168081 (owner: 10Henning Snater) [15:23:55] [13Wikiba.se] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/melOGg [15:23:55] 13Wikiba.se/06master 142e00241 15Adrian Lang: Add JavaScript libraries [15:23:55] 13Wikiba.se/06master 14e07d642 15Jeroen De Dauw: Merge pull request #29 from wmde/addJsLibs... [15:25:15] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 143aa331d: It is not. Think about it, and try to figure out why it is not :) 02http://git.io/7fwZjQ [15:26:36] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 143aa331d: I do not understand what you are getting at 02http://git.io/NKQtUA [15:27:21] (03PS14) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [15:27:42] (03PS6) 10Adrian Lang: Introduce DescriptionsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 [15:28:45] [13WikibaseQueryEngine] 15JeroenDeDauw 04force-pushed 06evidence-of-thiemo-killing-the-kittens from 143aa331d to 14d77eecc: 02http://git.io/ZN3M4w [15:28:45] 13WikibaseQueryEngine/06evidence-of-thiemo-killing-the-kittens 14d77eecc 15jeroendedauw: Have dedicated inserters for different entity types... [15:29:46] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 14d77eecc: Ok, used `Basic`. Not having any qualifier is odd, since it suggests there are no other things of this type. 02http://git.io/9w22yg [15:34:43] [13WikibaseQuery] 15thiemowmde created 06dm20again (+1 new commit): 02http://git.io/26Vakw [15:34:43] 13WikibaseQuery/06dm20again 141ea7661 15Thiemo Mättig: Fix composer update [15:35:45] [13WikibaseQuery] 15thiemowmde opened pull request #55: Fix composer update (06master...06dm20again) 02http://git.io/zitccQ [15:37:24] [13WikibaseQuery] 15thiemowmde 04deleted 06dm20 at 14a7ea6be: 02http://git.io/x4cXKw [15:39:34] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 14d77eecc: Because it's a spy and a spy is allowed to do nasty things? ;-) 02http://git.io/eQVlkQ [15:40:25] (03PS6) 10Adrian Lang: Introduce LabelsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 [15:40:32] (03PS2) 10Adrian Lang: Make CreateRedirectModuleTest actually assert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168070 [15:40:42] (03PS8) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (https://bugzilla.wikimedia.org/56246) [15:40:56] (03PS5) 10Adrian Lang: Remove wikibase.getRevisionStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166077 [15:42:55] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 14d77eecc: I wonder why you removed the interface. In my opinion the `EntityInserter` should still be of type `EntityInsertionStrategy`. 02http://git.io/e67n-g [15:46:17] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 14d77eecc: Overriding constructors is always ok and never a violation of anything? 02http://git.io/_R1qkw [15:47:37] wmde/WikibaseQuery/dm20again/1ea7661 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/38723265 [15:48:34] (03PS3) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 [15:48:36] (03PS4) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [15:48:38] (03PS2) 10Adrian Lang: Add referenceview.isInitialValue test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168059 [15:49:51] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 14d77eecc: There is no need for it to implement that interface, and I don't expect such need to arise either. So no need to add the extra method. 02http://git.io/Ars2Ew [15:50:33] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 14d77eecc: That's getting close, though still not quite correct. 02http://git.io/vx5IDA [15:51:53] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 14d77eecc: Close enough for me, I give up. ;-) Would be cool if you could explain the missing bit. 02http://git.io/xOoUMA [15:52:43] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 14d77eecc: Ok, after having an other look I agree. Never mind. 02http://git.io/mSBhSA [15:53:19] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [15:53:52] 3MediaWiki extensions / 3WikidataClient: Catchable fatal error: Argument 1 passed to Wikibase\EntityChange::setMetadata() must be an array, null given - 10https://bugzilla.wikimedia.org/72335#c1 (10Aude) now i get.... Fatal error: Call to undefined method Wikibase\DirectSqlStore::getItemUsageIndex() in /Lib... [15:54:13] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/X0_xhQ [15:54:13] 13WikibaseQueryEngine/06master 14fcf3267 15thiemowmde: Merge pull request #128 from wmde/evidence-of-thiemo-killing-the-kittens... [16:06:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Tests still run. Kewl." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168077 (owner: 10Aude) [16:08:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Missing a description in the commit message (is there a related bug?). But easy enough." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168059 (owner: 10Adrian Lang) [16:09:13] (03CR) 10Aude: Some cleanup in action tests (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168077 (owner: 10Aude) [16:10:49] (03PS1) 10Aude: Restore (still used) getItemUsageIndex in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168095 (https://bugzilla.wikimedia.org/72335) [16:14:07] 3MediaWiki extensions / 3WikidataClient: Catchable fatal error: Argument 1 passed to Wikibase\EntityChange::setMetadata() must be an array, null given - 10https://bugzilla.wikimedia.org/72335#c3 (10Aude) i think the issues i had in the first comment might be related to the version of wikibase + core I was us... [16:16:25] (03Merged) 10jenkins-bot: Some cleanup in action tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168077 (owner: 10Aude) [16:17:39] (03CR) 10jenkins-bot: [V: 04-1] Restore (still used) getItemUsageIndex in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168095 (https://bugzilla.wikimedia.org/72335) (owner: 10Aude) [16:19:58] (03PS2) 10Aude: Restore (still used) getItemUsageIndex in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168095 (https://bugzilla.wikimedia.org/72335) [16:23:59] (03CR) 10Aude: [C: 032] Make CreateRedirectModuleTest actually assert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168070 (owner: 10Adrian Lang) [16:27:53] * aude wonders if we have to purge parser cache again for next deploy? [16:28:05] think that is scary [16:28:35] (03CR) 10jenkins-bot: [V: 04-1] Restore (still used) getItemUsageIndex in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168095 (https://bugzilla.wikimedia.org/72335) (owner: 10Aude) [16:30:00] (03Merged) 10jenkins-bot: Make CreateRedirectModuleTest actually assert [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168070 (owner: 10Adrian Lang) [16:31:30] (03PS3) 10Aude: Restore (still used) getItemUsageIndex in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168095 (https://bugzilla.wikimedia.org/72335) [16:38:50] (03PS8) 10Daniel Kinzler: Rewrite label/description conflict detection. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) [16:50:05] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/mztMyQ [16:50:05] 13Wikiba.se/06master 14afb184a 15jeroendedauw: Add DataFixtures, JsonDumpReader and JsonDumpData [16:50:58] (03PS1) 10Aude: New Wikidata Build - 2014/10/22 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/168103 [16:51:24] (03CR) 10Daniel Kinzler: [C: 032] "oops, forgot that when splitting the patch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168095 (https://bugzilla.wikimedia.org/72335) (owner: 10Aude) [16:58:51] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/kM-8YA [16:58:51] 13Wikiba.se/06master 14995cc6d 15jeroendedauw: Fix depscription for WDTK [16:59:02] (03Merged) 10jenkins-bot: Restore (still used) getItemUsageIndex in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168095 (https://bugzilla.wikimedia.org/72335) (owner: 10Aude) [16:59:48] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/41vy-g [16:59:48] 13Wikiba.se/06master 1423343d5 15jeroendedauw: Improve wording [17:01:46] Are we missing any "community" components or tools here? http://wikiba.se/components/ [17:12:22] 3MediaWiki extensions / 3WikidataClient: Catchable fatal error: Argument 1 passed to Wikibase\EntityChange::setMetadata() must be an array, null given - 10https://bugzilla.wikimedia.org/72335#c5 (10Aude) 5PATC>3RESO/FIX version was indeed the issue. there was a breaking change in wmf/1.25wmf4 core, but t... [17:34:13] I am pressuring Magnus Manske on twitter to make a WD game that finds Commonscats with same names as items etc. He is currently working on it. Appearently there were 0.5 Million possible edits to be made. [17:34:23] JeroenDeDauw: can we get a minor / bug fix release of data model please? [17:34:27] not edits. Matches! [17:35:24] it has some small things worth to be in wikibase [17:48:14] Are there problems with timeouts ? [17:48:22] for a couple of days now ? [17:48:58] Josve05a: One-on-one matches or one to many matches like Category:Churches in Amsterdam? [17:50:24] I think "we" (haha...we) were going to focus in the beginning w/ taxons. Like Spicies with the same name on Wikidata (e.g. Item:foo) and on commons (e.g. Category:foo). ANd then expand to people with the same name. [17:51:18] Then possibly expand to Images on wikidata items, that doesn't have categories, to suggest those categories that photo is in...me is ...making less and less sense [17:52:09] and add the commons cat as a property on the wikidata item [17:57:48] Josve05a: Taxons? I think I already matched most of those last year [17:58:48] Josve05a: https://commons.wikimedia.org/wiki/User:Multichill/Commonscat_stats <- already matching since 2008 ;-) [17:59:59] well. don't ask me. that was what we "discussed in the begnning at least and then this: https://twitter.com/MagnusManske/status/524140895990722560 [18:00:07] and lastly https://twitter.com/MagnusManske/status/524481321972670464 [18:02:20] For the automatic matching i used a quite conservative approach and it was already some time ago so probably plenty of new matches [18:04:12] anyways, it will be fun to see how/if it will work [18:08:06] (03PS1) 10Aude: Use one instance of EntityIdParser in client factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168120 [18:18:25] sjoerddebruin: Does https://nl.wikipedia.org/wiki/Categorie:Wikipedia:Co%C3%B6rdinaten_niet_op_Wikidata need a bot run? [18:18:35] yes please [18:20:23] Ok, first running Italian, will do Dutch after that one [18:42:55] (03CR) 10Aude: [C: 032] New Wikidata Build - 2014/10/22 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/168103 (owner: 10Aude) [18:45:15] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/10/22 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/168103 (owner: 10Aude) [19:03:46] (03Draft3) 10Aude: Don't use BasicEntityIdParser in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168125 [19:25:42] (03CR) 10JanZerebecki: [C: 04-1] "Except inline comments it looks good." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [19:26:34] (03CR) 10JanZerebecki: "Please also update the commit message." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [19:28:10] 3MediaWiki extensions / 3WikidataRepo: description edit button is misaligned - 10https://bugzilla.wikimedia.org/72375 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs On beta, the edit button for description is misaligned compared to the one for label and other things. We deployed new code on beta... [19:29:37] 3MediaWiki extensions / 3WikidataRepo: description edit button is misaligned - 10https://bugzilla.wikimedia.org/72375#c1 (10Aude) http://wikidata.beta.wmflabs.org/w/index.php?title=Q3390&debug=true [19:54:51] Hey guys, I remember admins could change datatype of created property, is that changed? [19:56:11] legoktm: Hi.Can you change datatype of https://www.wikidata.org/wiki/Property:P1009 to Item? [20:04:19] ebraminio: it's not possible to change the datatype of a property [20:04:41] actualloy, it's never been possible [20:04:44] actually* [20:05:09] Stryn: Ok. Thank you [20:05:40] you have to just create a new item [20:11:34] Thank you [20:55:26] (03CR) 10Daniel Kinzler: Rewrite label/description conflict detection. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [21:49:05] legoktm: are there any Python libraries for working with Wikibase data? [21:49:41] pywikibot [21:50:00] yeah well sure, it has some WB stuff in there [21:50:01] but that'll come with a bunch of other stuff, and the implementation isn't perfect [21:50:07] But it has lots of unrelated things [21:50:29] legoktm: I'm looking for things to put in the community section here: http://wikiba.se/components/ [21:50:31] I'm not aware of anything in python that is *just* wikibase [21:50:47] There is PHP, JS and Java [21:50:54] Why no Python? ;p [21:51:11] because everyone uses pywikibot :) [21:51:27] * JeroenDeDauw declares pywikibot to be evil [21:52:46] I'm biased, but I'd just put pywikibot there as a "general MediaWiki Python library with Wikibase support" [21:53:34] there was a python wikibase project someone had a loooong time ago, but that was before properties even existed iirc [21:54:05] Why is the WB stuff not done in its own component and then used by pywikibot? [21:58:21] JeroenDeDauw: no reason, just that we haven't done it? [21:58:26] we probably could. [21:59:44] (un)related question: why are there still two separately maintained branched of pywikibot, after what, 7 years?... [22:00:24] legoktm: well, if you want a link from that page, you should :) [22:00:27] because we haven't killed off the legacy branch yet [22:00:48] make ALL of the components!!!!!111111111111111 [22:01:07] core (the new branch) is significantly better, but isn't fully feature complete yet [22:01:13] * JeroenDeDauw goes to sleep by counting components jumping over a CI gate [22:01:27] lol [22:10:25] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When I using wikidata in non-english (e.g. German) and enter a statement on Wikidta, with property... [22:38:38] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393#c1 (10Aude) this still happens on master