[02:08:25] 3MediaWiki extensions / 3WikidataClient: Add Wikibase API module that is usable from client wikis and available as a generator & prop module - 10https://bugzilla.wikimedia.org/72729#c6 (10Dan Garry) I second what Kaldari has said. Sure, it's sufficient, but it shouldn't be necessary. :-) [09:53:01] (03CR) 10Daniel Kinzler: [C: 032] Inject entity info into ParserOutputJsConfigBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171606 (owner: 10Aude) [09:58:17] (03CR) 10Daniel Kinzler: [C: 032 V: 031] Remove obsolete MakeGlobalVariablesScriptHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171556 (owner: 10Aude) [10:05:28] (03Merged) 10jenkins-bot: Remove obsolete MakeGlobalVariablesScriptHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171556 (owner: 10Aude) [10:06:43] (03Merged) 10jenkins-bot: Inject entity info into ParserOutputJsConfigBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171606 (owner: 10Aude) [10:07:12] (03PS1) 10Henning Snater: sitelinklistview._updateAutoInput: Check if last sitelinkview exists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171812 [10:09:02] (03PS17) 10Henning Snater: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [10:26:22] (03PS18) 10Henning Snater: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [10:28:55] (03PS1) 10Daniel Kinzler: Introduce EntityInfoTermLookup. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171813 (https://bugzilla.wikimedia.org/72307) [10:30:39] 3MediaWiki extensions / 3WikidataRepo: Implement a label lookup based on entity info - 10https://bugzilla.wikimedia.org/72307 (10Daniel Kinzler) [10:32:24] (03CR) 10Tobias Gritschacher: [C: 032] sitelinklistview._updateAutoInput: Check if last sitelinkview exists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171812 (owner: 10Henning Snater) [10:32:39] 3MediaWiki extensions / 3WikidataRepo: Implement a TermLookup based on entity info arrays - 10https://bugzilla.wikimedia.org/72307 (10Daniel Kinzler) [10:40:02] (03Merged) 10jenkins-bot: sitelinklistview._updateAutoInput: Check if last sitelinkview exists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171812 (owner: 10Henning Snater) [10:43:11] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Pressing TAB in siteselector should move focus to pagesuggester - 10https://bugzilla.wikimedia.org/73128 (10tobias.gritschacher) [10:43:12] 3MediaWiki extensions / 3WikidataRepo: BadgeSelector not enabled for new SiteLInks - 10https://bugzilla.wikimedia.org/73129 (10tobias.gritschacher) [10:43:25] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Not possible to jump to new sitelink using TAB - 10https://bugzilla.wikimedia.org/73127 (10tobias.gritschacher) [10:43:26] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Remove button should be disabled until entered sitelink is valid - 10https://bugzilla.wikimedia.org/73126 (10tobias.gritschacher) [10:43:40] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: BadgeSelector not enabled for new SiteLInks - 10https://bugzilla.wikimedia.org/73129 (10tobias.gritschacher) [10:50:53] DanielK_WMDE: aude: Any idea how to make use of getStatements when I can have any entity type? [10:51:06] I want to be able to gracefully handle entities that don't support it [10:52:13] * hoo doesn't want to hard code like $supportsStatements = array( Item::ENTITY_TYPE, PROPERTY::... ); [10:57:56] hoo: i don't think there is any way to do that right now. you could introduce an interface for this - StatementContainer or something [10:58:30] mh [10:58:30] hoo: no [10:58:53] is getStatements in the Entity interface? [10:59:11] it shouldn't be [10:59:27] no, it's not [10:59:27] https://github.com/wmde/WikibaseDataModel/blob/master/src/Entity/Entity.php [10:59:28] nope [10:59:41] I'm one step close to doing is_callable( ... ); [10:59:43] getClaims is not implemented for proprties and is deprecated [10:59:48] yep [10:59:50] Seen that [11:00:08] :S [11:01:09] is_callable( array( $entity, 'getClaims' ) ) [11:01:16] uh * getStatements [11:02:03] that sounds very evil [11:02:32] very evil :( [11:02:39] [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/jUMAoA [11:02:39] 13DataValuesJavascript/06master 143296640 15snaterlicious: Merge pull request #48 from wmde/test-for-calendar-issue... [11:02:56] but I seriously doubt Jeroen will approve the interface [11:06:20] (03PS3) 10Hoo man: Add UpdateRepoOnDeleteJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) [11:06:35] (03CR) 10Aude: "nitpicks" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171813 (https://bugzilla.wikimedia.org/72307) (owner: 10Daniel Kinzler) [11:07:15] think I'll at least put the PR to DM up later on [11:07:21] ok [11:07:27] will at least start a discussion [11:07:30] yeah [11:07:54] it's quite some issues we have with using getClaims all over [11:07:58] and really no good alternative [11:10:39] aude: we can just un-deprecate it [11:10:53] yeah and implement it in Property [11:11:00] * hoo would love that [11:11:09] :) [11:11:32] well, conceptually, getClaims doesn't belong in Entity. But our current code base relies on it. [11:11:47] As long as there is no viable alternative, we should just continue to use it [11:12:03] do we want some interface for entities that have claims or statements? [11:12:25] Deprecation without a concrete alternative is just blocking us [11:12:40] aude: I would like that [11:12:47] as told, I'll be working on that later on [11:12:53] ok [11:13:01] will try to bring the update repo on move thing into a mergeable state first, though [11:13:09] * delete [11:13:34] aude: i think that would be the correct approach. but you'd need an interface for "EntityWithStatements", not just "SomethingWithStatement", for type hints. Or you type hint against Entity, and then use instanceof to check for SomethingWithStatements. [11:13:38] both are not very nice [11:13:52] * aude nods [11:15:23] Like StatementContainingEntity [11:15:26] * hoo bad at naming [11:16:12] hoo: yea, but... no. You end up with crap like WEntityThatHasStatementsAndSitelinksAndAliassesToo. [11:16:25] this approach doesn't really work [11:16:41] I'd be ok with a StatementContainer interface [11:16:51] better to use "independent" interfaces like StatementContainer, and then use instanceof to check. [11:16:54] I type hint against Entity in the functiond def. anyway [11:16:57] not pretty, butb better than the alternative. [11:17:15] hoo: exactly [11:28:10] 3MediaWiki extensions / 3WikidataRepo: Special:ItemByTitle should preserve url parameters - 10https://bugzilla.wikimedia.org/48037 (10Lydia Pintscher) [11:29:39] 3MediaWiki extensions / 3WikidataClient: Changes on Wikidata should update the notification timestamp on the client - 10https://bugzilla.wikimedia.org/48440 (10Lydia Pintscher) [11:31:40] 3MediaWiki extensions / 3WikidataRepo: Prefixindex should show property title - 10https://bugzilla.wikimedia.org/52624 (10Lydia Pintscher) [11:34:10] 3MediaWiki extensions / 3WikidataRepo: Show details for "bad" values when formatting - 10https://bugzilla.wikimedia.org/55407#c1 (10Lydia Pintscher) 5NEW>3RESO/WON Given that we don't have complaints anymore about undeserializable values I'm going to close it as it'd be too much effort for not much gain. [11:35:25] 3MediaWiki extensions / 3WikidataRepo: Factor out FormatAutocomments hook code, improve and add tests - 10https://bugzilla.wikimedia.org/55783#c1 (10Lydia Pintscher) Still relevant? How important/urgent? [11:37:25] 3MediaWiki extensions / 3WikidataClient: Rendering URL datatype as wikitext should generate an external link instead of a bare URL - 10https://bugzilla.wikimedia.org/56763 (10Lydia Pintscher) [11:38:40] 3MediaWiki extensions / 3WikidataClient: After moving a page if the item has conflict in wikidata wikidataClient leave items without error - 10https://bugzilla.wikimedia.org/56457#c2 (10Lydia Pintscher) What's our realistic chance of fixing this? How much impact does it have? How hard would it be to fix? [11:40:40] 3MediaWiki extensions / 3WikidataRepo: Double escaping in restore failure message - 10https://bugzilla.wikimedia.org/57533 (10Lydia Pintscher) [11:41:42] 3MediaWiki extensions / 3WikidataClient: add selenium test for item id on action=info page - 10https://bugzilla.wikimedia.org/57466#c1 (10Lydia Pintscher) Is this really something we need to spent time on? [11:42:10] 3MediaWiki extensions / 3WikidataClient: After moving a page if the item has conflict in wikidata wikidataClient leave items without error - 10https://bugzilla.wikimedia.org/56457#c3 (10Marius Hoch) The impact is low (this shouldn't actually occur at all, it only does if we start with invalid data). Fixing... [11:43:40] 3MediaWiki extensions / 3WikidataClient: After moving a page if the item has conflict in wikidata wikidataClient leave items without error - 10https://bugzilla.wikimedia.org/56457#c4 (10Lydia Pintscher) 5NEW>3RESO/WON Ok then let's be honest with ourselves and admit that it is not going to happen. Sorry. [11:46:10] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06ieee from 14ca6eb30 to 1482e5401: 02http://git.io/TAeI9A [11:46:11] 13DataValuesJavascript/06ieee 1482e5401 15Thiemo Mättig: Don't compare floats without epsilon [11:47:10] 3MediaWiki extensions / 3WikidataRepo: Special:NewItem return error "Could not create a new page. It already exists." although it does not exist - 10https://bugzilla.wikimedia.org/46535#c10 (10Lydia Pintscher) 5PATC>3RESO/FIX I have not heard anymore complaints about this so I assume this is fine now. Pl... [11:49:01] <16WAAF8YZ> [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/ynDe2A [11:49:01] <16WAAF8YZ> 13WikidataBrowserTests/06master 1489ef238 15Tobi Gritschacher: Merge pull request #21 from wmde/siteLinks... [11:49:01] <17WAAGFFS> [13WikidataBrowserTests] 15tobijat closed pull request #21: Adapt to new site link edit ui (06master...06siteLinks) 02http://git.io/J3gnuQ [11:49:11] [13WikidataBrowserTests] 15tobijat 04deleted 06siteLinks at 1456c88f9: 02http://git.io/FTKgsA [11:49:42] https://bugzilla.wikimedia.org/show_bug.cgi?id=62707 seems stuck and I don't think bene currently has time to follow up on the review comment [11:50:42] wmde/DataValuesJavascript/ieee/80687a7 : Thiemo Mättig The build was broken. http://travis-ci.org/wmde/DataValuesJavascript/builds/40284385 [11:51:08] Lydia_WMDE: Tests are missing there... and writing them is not exactly fun [11:51:20] yeah :/ [11:51:41] (03CR) 10Daniel Kinzler: [C: 04-1] "The approach looks good, but needs some tweaking." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [11:51:46] (03CR) 10Tobias Gritschacher: [C: 031] "let's merge this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [11:53:02] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=69540 <- what is this waiting on currently? still foundation review? [11:54:08] Lydia_WMDE: Not really foundation, there's a volunteer coming up with ideas and stuff... and I haven't really found the time to bring that in a mergeable state and sort it together with my idea [11:54:19] * ideas [11:54:21] ok [11:54:44] And we also didn't yet agree on whether we want preprocessing... and if so how/ where [11:54:54] i see [11:55:03] thx [11:56:14] (03CR) 10Aude: Implement EntityParserOutputGeneratorFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [11:56:33] DanielK_WMDE: would you like to do your suggestions as follow up? [11:56:46] i think they are good ideas but too much for this patch [11:56:56] then it still needs tests also [11:57:14] Thiemo_WMDE: can https://bugzilla.wikimedia.org/show_bug.cgi?id=71289 be closed? [11:57:32] and i don't like the language fallback part but suppose it's what we have now [11:57:43] aude: writing tests for the current state is going to be harder than writing tests for what you'd get after splitting this up some more and using proper injection [11:57:54] 3MediaWiki extensions / 3WikidataRepo: eliminate settings closure in WikibaseLib.default.php - 10https://bugzilla.wikimedia.org/71565 (10Lydia Pintscher) 5PATC>3RESO/FIX [11:58:25] aude: i could work on that, but i'd rather concentrate con figuring our how to get the EntityInfo stuff into the SnakFormatter [11:58:26] 3MediaWiki extensions / 3WikidataRepo: Decide how to show correct values where it is unclear how to format them - 10https://bugzilla.wikimedia.org/71289#c4 (10Thiemo Mättig) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 67604 *** [11:58:28] Lydia_WMDE: done. [11:58:34] DanielK_WMDE: ok [11:58:40] 3MediaWiki extensions / 3WikidataRepo: time formatting issues with some precisions - 10https://bugzilla.wikimedia.org/67604#c9 (10Thiemo Mättig) *** Bug 71289 has been marked as a duplicate of this bug. *** [11:59:00] Thiemo_WMDE: thx [11:59:41] DanielK_WMDE: can https://bugzilla.wikimedia.org/show_bug.cgi?id=43734 be closed? [12:00:00] if not can we add what's missing? [12:00:50] (03PS19) 10Henning Snater: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [12:02:41] 3MediaWiki extensions / 3WikidataRepo: Class Wikibase\DataModel\Entity\Item has no unserializer in MemcachedClient.php on line 977 - 10https://bugzilla.wikimedia.org/70300 (10christian) [12:13:14] DanielK_WMDE: Mh... if I create a template class UpdateRepoJob, how should it handle setting services? [12:13:27] right now I have an initServices function [12:13:47] and the childs then call that in their initServices [12:14:54] but UpdateRepoJob also requires those services in its constructor, so they're effectively always get set twice during initialization [12:15:51] factory methods for jobs would be nice :D [12:20:49] (03PS11) 10Aude: Implement EntityRetrievingTermLookup which uses EntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [12:22:42] (03PS12) 10Aude: Implement EntityRetrievingTermLookup which uses EntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [12:26:12] 3MediaWiki extensions / 3WikidataRepo: Browsertests: Adjust/write new tests for dynamic input elements for sitelinks - 10https://bugzilla.wikimedia.org/72663#c2 (10tobias.gritschacher) 5ASSI>3PATC https://github.com/wmde/WikidataBrowserTests/pull/21 [12:26:12] 3MediaWiki extensions / 3WikidataRepo: Browsertests: Adjust/write new tests for dynamic input elements for sitelinks - 10https://bugzilla.wikimedia.org/72663 (10tobias.gritschacher) 5PATC>3RESO/FIX [12:29:25] (03CR) 10jenkins-bot: [V: 04-1] Implement EntityRetrievingTermLookup which uses EntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude) [12:33:27] (03PS20) 10Henning Snater: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [12:40:26] 3MediaWiki extensions / 3WikidataRepo: description edit button is misaligned - 10https://bugzilla.wikimedia.org/72375 (10Lydia Pintscher) [12:42:44] (03PS1) 10Henning Snater: Applied key handling to referenceview edit toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171824 [12:44:55] 3MediaWiki extensions / 3WikidataClient: langlinks table not updated on interwiki link change - 10https://bugzilla.wikimedia.org/59962 (10Lydia Pintscher) [12:47:18] DanielK_WMDE: is https://bugzilla.wikimedia.org/show_bug.cgi?id=42957 fixed with one of your latest changes? also see my comment there [12:48:39] 3MediaWiki extensions / 3WikidataClient: Client should ignore changes to deleted entities. - 10https://bugzilla.wikimedia.org/44964 (10Lydia Pintscher) [12:49:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=42719 <- still something we should do? [12:50:59] [13DataValuesJavascript] 15thiemowmde pushed 1 new commit to 06ieee: 02http://git.io/-3niPA [12:50:59] 13DataValuesJavascript/06ieee 14b379035 15thiemowmde: Update globeCoordinate.GlobeCoordinate.tests.js [12:51:10] (03CR) 10Tobias Gritschacher: [C: 031 V: 032] "Finally the browsertests succeed. Yay!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [12:51:41] (03CR) 10Henning Snater: [C: 032] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [12:51:49] (03PS8) 10Henning Snater: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [12:52:13] wmde/DataValuesJavascript/ieee/b379035 : thiemowmde The build is still failing. http://travis-ci.org/wmde/DataValuesJavascript/builds/40288670 [12:53:12] 3MediaWiki extensions / 3WikidataClient: Move the sort order out of Wikibase Client and generalize - 10https://bugzilla.wikimedia.org/45004#c2 (10Lydia Pintscher) Is this still relevant? [12:53:41] 3MediaWiki extensions / 3WikidataRepo: Non-English letters aren't linked - 10https://bugzilla.wikimedia.org/45126 (10Lydia Pintscher) [12:56:40] (03CR) 10Tobias Gritschacher: [C: 032] Applied key handling to referenceview edit toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171824 (owner: 10Henning Snater) [12:58:59] (03PS9) 10Henning Snater: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [13:00:40] (03CR) 10Henning Snater: [C: 032] Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [13:04:10] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: BadgeSelector not enabled for new SiteLInks - 10https://bugzilla.wikimedia.org/73129 (10Lydia Pintscher) p:5Unprio>3High [13:04:26] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Pressing TAB in siteselector should move focus to pagesuggester - 10https://bugzilla.wikimedia.org/73128 (10Lydia Pintscher) p:5Unprio>3Normal [13:04:40] 3MediaWiki extensions / 3WikidataRepo: Update Wikibase to use version 1.0 of DM-JS and Serialization-JS - 10https://bugzilla.wikimedia.org/72757 (10tobias.gritschacher) 5PATC>3RESO/FIX [13:04:55] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Not possible to jump to new sitelink using TAB - 10https://bugzilla.wikimedia.org/73127 (10Lydia Pintscher) p:5Unprio>3Normal [13:05:24] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Remove button should be disabled until entered sitelink is valid - 10https://bugzilla.wikimedia.org/73126 (10Lydia Pintscher) p:5Unprio>3Normal [13:05:25] (03Merged) 10jenkins-bot: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [13:05:33] (03Merged) 10jenkins-bot: Applied key handling to referenceview edit toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171824 (owner: 10Henning Snater) [13:07:40] 3Wikimedia / 3Wikidata: Add irc schema to urlSchemes configuration - 10https://bugzilla.wikimedia.org/73091 (10Lydia Pintscher) p:5Low>3Normal s:5trivia>3normal [13:07:54] 3MediaWiki extensions / 3WikidataRepo: Ensure transactional integrity of uniqueness constraints - 10https://bugzilla.wikimedia.org/42957#c2 (10Daniel Kinzler) 5NEW>3RESO/WON MediaWiki doesn't give us enough control to assure full transactional integrity. Generally, MediaWiki chooses performance over db i... [13:07:57] Lydia_WMDE: --^ [13:08:09] (03Merged) 10jenkins-bot: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [13:08:26] 3MediaWiki extensions / 3WikidataRepo: Efficient entity label lookup (tracking) - 10https://bugzilla.wikimedia.org/73087 (10Lydia Pintscher) p:5Unprio>3High [13:11:10] 3MediaWiki extensions / 3WikidataRepo: Make parse errors in wbparsevalue have the same structure as normal api errors - 10https://bugzilla.wikimedia.org/72947 (10Lydia Pintscher) p:5Unprio>3Low [13:17:57] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/07 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/171825 [13:19:25] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Sorry, but I have to agree to Daniel. This change is very suspicious without a test. I tried to read the code but couldn't understand what" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [13:22:04] (03CR) 10Thiemo Mättig (WMDE): "I think an other way to fix the same bug is to change the line" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [13:22:19] +18001, -6546 since Wednesday. Impressive. [13:23:25] 3MediaWiki extensions / 3WikidataRepo: Create a SpecialPage that allows to edit label, description and aliases together - 10https://bugzilla.wikimedia.org/70174 (10Lydia Pintscher) p:5Low>3Normal [13:24:35] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2014/11/07 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/171825 (owner: 10Tobias Gritschacher) [13:26:35] (03Draft1) 10Aude: Remove unused newEntityIdLabelFormatter method in client factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170067 [13:27:18] [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06ieee: 02http://git.io/dSrS8A [13:27:18] 13DataValuesJavascript/06ieee 14bb7d239 15snaterlicious: Removed tests that need a separate fix [13:27:40] 3MediaWiki extensions / 3WikidataRepo: can't save changes that only change case in sitelinks - 10https://bugzilla.wikimedia.org/46451 (10Lydia Pintscher) [13:28:23] (03PS13) 10Aude: Implement EntityRetrievingTermLookup which uses EntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [13:28:55] 3MediaWiki extensions / 3WikidataRepo: Distance between tooltip icon and sitelinks edit button - 10https://bugzilla.wikimedia.org/69901 (10Lydia Pintscher) [13:28:55] 3MediaWiki extensions / 3WikidataRepo: Implement new SiteLink UI - 10https://bugzilla.wikimedia.org/68903 (10Lydia Pintscher) [13:29:11] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: BadgeSelector not enabled for new SiteLInks - 10https://bugzilla.wikimedia.org/73129 (10Lydia Pintscher) [13:29:11] 3MediaWiki extensions / 3WikidataRepo: Implement new SiteLink UI - 10https://bugzilla.wikimedia.org/68903 (10Lydia Pintscher) [13:29:24] 3MediaWiki extensions / 3WikidataRepo: Implement new SiteLink UI - 10https://bugzilla.wikimedia.org/68903 (10Lydia Pintscher) [13:29:25] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Pressing TAB in siteselector should move focus to pagesuggester - 10https://bugzilla.wikimedia.org/73128 (10Lydia Pintscher) [13:29:28] [13DataValuesJavascript] 15snaterlicious closed pull request #53: Don't compare floats without epsilon (06master...06ieee) 02http://git.io/bM399w [13:30:33] * aude is on master and am getting 'UsageException: Unrecognized value for parameter 'action': wbformatvalue' test failures [13:31:16] and for parser value [13:31:18] parsevalue [13:31:26] Exception: Global with key wgValueParsers doesn't exist and cant be stashed [13:31:57] aude: did you composer update? [13:32:04] i did [13:32:13] * aude deleting the vendor directory adn try again [13:33:12] aude: I'll try [13:34:00] suspiciously related but think not [13:34:28] jenkins approves https://gerrit.wikimedia.org/r/#/c/171530/ [13:36:22] I am on master now and everything works fine for me [13:36:27] (03PS14) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [13:36:36] hope that is clear enough for DanielK_WMDE ^ [13:36:59] ugh [13:37:23] updated core also [13:37:44] api tests are huge pile of fail :( [13:39:00] api tests also run very fast [13:39:54] [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/B8Iokg [13:39:54] 13DataValuesJavascript/06master 14b2e6c22 15snaterlicious: Bump version to 0.6.1 [13:40:31] and the api modules themselves seem ok [13:41:02] [13DataValuesJavascript] 15snaterlicious tagged 060.6.1 at 06master: 02http://git.io/Qz8jMQ [13:41:06] I'll try the tests [13:41:13] ok [13:41:21] * aude probably done something wrong [13:42:15] [13ValueView] 15snaterlicious closed pull request #126: Fix broken precision auto detection (06master...06coordPrecision) 02http://git.io/STAs_Q [13:42:26] (03PS4) 10Hoo man: Add UpdateRepoOnDeleteJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) [13:42:36] (03CR) 10Hoo man: Add UpdateRepoOnDeleteJob (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [13:43:03] https://www.irccloud.com/pastebin/GQp27ZrM [13:43:09] aude ^^ [13:43:15] on master [13:43:20] looks fine [13:43:45] ooooooooh! [13:43:52] ? [13:43:55] (03PS5) 10Hoo man: Add UpdateRepoOnDeleteJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) [13:44:01] * aude is trying to run api tests from the client :P [13:44:06] ha! [13:44:18] much better now :D [13:44:25] good [13:44:29] :) [13:44:33] :) [13:44:39] 3MediaWiki extensions / 3WikidataRepo: Implement new SiteLink UI - 10https://bugzilla.wikimedia.org/68903 (10Lydia Pintscher) [13:44:49] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10Lydia Pintscher) [13:44:49] 3MediaWiki extensions / 3WikidataRepo: Allow excludeNamespaces to be defined per sitelink section - 10https://bugzilla.wikimedia.org/60647#c2 (10Lydia Pintscher) *** Bug 45581 has been marked as a duplicate of this bug. *** [13:44:49] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10Lydia Pintscher) [13:44:49] 3MediaWiki extensions / 3WikidataRepo: Create a SpecialPage that allows to edit label, description and aliases together - 10https://bugzilla.wikimedia.org/70174 (10Lydia Pintscher) [13:44:50] 3MediaWiki extensions / 3WikidataRepo: [UI] Load widgets on demand - 10https://bugzilla.wikimedia.org/60341 (10Lydia Pintscher) [13:44:51] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Not possible to jump to new sitelink using TAB - 10https://bugzilla.wikimedia.org/73127 (10Lydia Pintscher) [13:44:52] 3MediaWiki extensions / 3WikidataRepo: Implement new SiteLink UI - 10https://bugzilla.wikimedia.org/68903 (10Lydia Pintscher) [13:44:53] 3MediaWiki extensions / 3WikidataRepo: do not accept talk pages as sitelinks - 10https://bugzilla.wikimedia.org/45581#c6 (10Lydia Pintscher) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 60647 *** [13:45:13] but..... seems we have a problem with SpamBlacklist again [13:45:45] Argument 1 passed to Wikibase\EntityContent::getParserOutput() must be an instance of Title, null given [13:48:57] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10Lydia Pintscher) [13:48:57] 3MediaWiki extensions / 3WikidataRepo: Tag protected items with a padlock - 10https://bugzilla.wikimedia.org/62554 (10Lydia Pintscher) p:5Low>3Normal s:5minor>3normal [13:49:25] 3MediaWiki extensions / 3WikidataRepo: SitelinksUI: Remove button should be disabled until entered sitelink is valid - 10https://bugzilla.wikimedia.org/73126 (10Lydia Pintscher) [13:49:34] (03CR) 10jenkins-bot: [V: 04-1] Add UpdateRepoOnDeleteJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [13:49:57] [13ValueView] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/Vrt1OQ [13:49:57] 13ValueView/06master 149ee15e5 15snaterlicious: Bump version to 0.8.1 [13:50:43] (03PS15) 10Aude: DANIEL!!!! Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [13:50:48] [13ValueView] 15snaterlicious tagged 060.8.1 at 06master: 02http://git.io/V_VMcA [13:50:48] ^ [13:50:50] :D [13:50:52] * hoo screams [13:51:02] (03PS16) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [13:51:26] also https://gerrit.wikimedia.org/r/#/c/170067/ [13:51:27] easy [13:51:38] and then i will need to rebase [13:52:13] DanielK_WMDE_: My question about initialization of services still stands [13:53:14] hoo: sorry, i have been switchign context a bit too often today... which question, exactly? [13:53:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=73133 [13:53:26] not again! [13:53:38] DanielK_WMDE: Mh... if I create a template class UpdateRepoJob, how should it handle setting services? [13:53:39] right now I have an initServices function [13:53:39] and the childs then call that in their initServices [13:53:41] it could be our tests that are the problem [13:53:57] (03PS6) 10Henning Snater: Added suggestions placeholder to $.wikibase.entitysearch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171226 [13:54:03] DanielK_WMDE_: I need some services in the abstract class [13:54:13] (03PS7) 10Henning Snater: Added suggestions placeholder to $.wikibase.entitysearch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171226 [13:54:15] lydia closes lots of bugs, /me makes new ones :P [13:54:17] see the change in gerrit to get an idea (it fails jenkins for this exact reason) [13:54:30] aude: you evil problem creator :D [13:54:30] (03PS3) 10Henning Snater: Added .foucs() to $.ui.TemplatedWidget and child widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171554 [13:54:35] (03PS4) 10Henning Snater: Removed focus smartness from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171555 [13:54:50] what change? [13:54:54] hoo: oh, you mean because the signature of the initServices function would be different in the subclasses? yea, ran into that with API modules. [13:55:05] oh, that [13:55:05] yeah :/ [13:55:16] How did you fix it? [13:55:22] (03PS5) 10Henning Snater: Removed focus smartness from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171555 [13:55:39] hoo: best solution i could think of: use differen function names. initRepoJobServices(), initRepoMoveJobServices(), etc [13:55:52] yeah, that sounds ok [13:56:03] hoo: the alternative is to pass an array of services, with service names as the keys.... ick. [13:58:05] (03PS4) 10Henning Snater: Added .focus() to $.ui.TemplatedWidget and child widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171554 [14:00:45] (03PS6) 10Hoo man: Add UpdateRepoOnDeleteJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) [14:04:05] (03CR) 10Hoo man: "Addressed Daniel's comments and improved the tests (they no longer use the DB and cover all cases now)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [14:06:20] (03PS2) 10Hoo man: Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) [14:11:26] 3MediaWiki extensions / 3WikidataRepo: Recent changes should show watched items as bold on client - 10https://bugzilla.wikimedia.org/46329 (10Lydia Pintscher) [14:17:40] 3MediaWiki extensions / 3WikidataClient: make maintenance script to update user recent changes preferences - 10https://bugzilla.wikimedia.org/62054#c2 (10Lydia Pintscher) 5NEW>3RESO/WON Agreed. [14:21:22] Henning_WMDE: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Can.27t_change_rank_only_2 [14:25:32] (03CR) 10Hoo man: [C: 032] Remove unused newEntityIdLabelFormatter method in client factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170067 (owner: 10Aude) [14:30:43] (03Merged) 10jenkins-bot: Remove unused newEntityIdLabelFormatter method in client factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170067 (owner: 10Aude) [14:35:46] (03PS17) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [14:36:59] (03PS18) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [14:38:35] (03PS7) 10Aude: [DO NOT MERGE OR REVIEW] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 [14:38:43] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE OR REVIEW] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [14:45:12] (03CR) 10Daniel Kinzler: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude) [14:47:14] (03PS2) 10Daniel Kinzler: Introduce EntityInfoTermLookup. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171813 (https://bugzilla.wikimedia.org/72307) [14:50:14] * hoo rages about people poking him, keeping him from doing anything -.- [14:51:25] * hoo not responsible for fixing people application docs -.- [14:52:38] oh noes [14:53:14] (03CR) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude) [14:53:16] I worked like 3:30h today... and the rest of the time I spent helping people or fixing stuffs [14:53:27] (unrelated to Wikimedia) [14:53:29] -.- [14:53:36] (03PS19) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [14:53:44] maybe do what ha-shar does for a day :) [14:54:09] or if it's unrelated, then [14:54:12] don't know [14:54:29] Killing XMPP, Facebook and WhatsApp would help a lot [14:55:01] IRC is not a problem today :) [14:55:07] yeah [14:55:24] * aude never looks at facebook during the day [14:55:31] and doesn't use the other things [14:56:14] I have my pidgin running all the time with FB... usually barely anyone messages me there, but today ... [14:56:27] :( [14:57:51] Time to warm up some food or so... [14:58:05] Hopefully I'm more productive later on [14:58:31] :) [14:59:30] Lydia_WMDE: Corresponding bug report: https://bugzilla.wikimedia.org/show_bug.cgi?id=71554, unable to reproduce the other issue as well (API returns "normal" rank for both statements). [15:02:28] Henning_WMDE: ok thanks! [15:04:56] aude: [DO NOT MERGE OR REVIEW] :) [15:05:12] [DO NOT MERGE, REVIEW OR EVEN READ THE TITLE] [15:05:27] :) [15:05:52] that's to help daniel [15:06:39] * hoo|away just killed all communications except mails/ IRC [15:06:51] * means of communication [15:07:06] and made my phone go offline [15:20:32] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #58: Remove incorrect class ref (06master...06cr) 02http://git.io/4aXoqg [15:25:12] wmde/WikibaseDatabase/cr/f509607 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/40302515 [15:33:20] (03PS3) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [15:33:35] (03CR) 10Aude: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [15:34:39] (03PS4) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [15:34:54] (03CR) 10Aude: "rebased more" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [15:50:10] (03PS3) 10Hoo man: Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) [15:50:59] (03CR) 10Hoo man: Apply page deletions to the repo (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [15:52:16] (03CR) 10Hoo man: "Restored the (atm) unused hook handler function parameters (per Thiemo)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [15:53:00] Now merge!!11 :D [15:53:44] (03CR) 10Hoo man: "Manually tested PS3 (with both moves and deletions)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [15:54:03] (03PS5) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [15:54:27] hoo: shall take a look [15:54:34] \o/ [15:54:44] do i need central auth for this? [15:55:00] would like to manually test [15:55:02] Yeah... but as a hack you can comment taht part out [15:55:08] I have CA, though [15:55:10] or i can enable it [15:55:12] (as a CA developer :D) [15:55:22] Thiemo_WMDE: where are you? [15:55:23] * aude disables it because it disrupts wikibase tests [15:55:34] about cloning tables or such [15:55:45] if ( !defined( 'MW_PHPUNIT_TEST' ) ) { [15:55:46] yep [15:56:00] I wrapped the inclusion of it in my LocalSettings with the above ;) [15:56:03] ah, i should do that [15:59:21] (03PS6) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [15:59:55] JeroenDeDauw: Do you have a moment to talk about data model? :D [16:01:13] hoo: sure [16:01:27] hoo: as long as you do not want to kill the NyanCat :@ [16:01:37] JeroenDeDauw: Idea is to make all entity types that support statements implement a StatementContainer interface [16:01:49] No, my ideas aren't *that* evil :D [16:04:02] (03PS1) 10Henning Snater: Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 [16:06:38] hoo: sure [16:06:46] hoo: where do you need this though? [16:07:16] hoo: https://github.com/wmde/WikibaseDataModel/blob/master/src/Term/FingerprintProvider.php [16:07:27] I thought this would be useful [16:07:31] JeroenDeDauw: Lua integration for example... user gives us some entity and asks us to do things with it [16:07:33] But I'm not sure it is actually used [16:07:42] And now I'm not sure where it would be either [16:07:55] oh, I'll make use of it as fast as I can [16:08:02] I have a change being blocked by taht [16:08:12] (or undeprecate/ fix Entity::getClaims) [16:08:43] hoo: the only thing to fix with Entity::getClaims is to remove it entirely [16:09:07] That's why I want that interface [16:10:31] hoo: if you know a certain Entity has a Fingerprint, then you could pass it to a function expecting a FingerprintProvider [16:10:42] But why would you do that? [16:10:43] (03CR) 10jenkins-bot: [V: 04-1] Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 (owner: 10Henning Snater) [16:10:54] Why not just get the fingerptint and pass that to the function instread? [16:11:07] It's nicer for a function to expect a Fingerprint than to expect a FingerprintProvider [16:11:15] And for the caller it makes little difference [16:11:18] (03PS7) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [16:11:31] JeroenDeDauw: Agreed, but with Lua user interaction this doesn't work [16:11:36] The tricky part is finding out if the entity type has fingerprints or not [16:11:38] (03PS2) 10Henning Snater: Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 [16:11:41] Which you need to do in both cases [16:11:53] but that's easier with an interface [16:12:02] How would you do it without? [16:12:07] checking is_callable? :P [16:12:08] hoo: I'm guessing the bad assumptions about entities are very pervailent in the lua interface? [16:12:57] It's supposed to be very easy to use [16:13:12] hoo: ah... so when you get an entity of unknown type you will do an "if instanceof FingerprintProvider" and if it is, pull the fingerprint out of it? [16:13:14] that's why it doesn't consider any differences between entity types [16:13:42] Like that... and if not, I'll just return something which can make Lua fail graceful [16:13:48] hoo: that is going to make it difficult to use the more prominent the differences between entities get ;p [16:14:03] [13WikibaseDatabase] 15thiemowmde closed pull request #58: Remove incorrect class ref (06master...06cr) 02http://git.io/4aXoqg [16:14:11] hoo: ok, I guess the instanceof thing can be quite usefull for this [16:14:21] Had not thought about that [16:14:35] hoo: so yeah, go ahead and add a thing for statements if you want [16:14:39] :) [16:14:42] On that [16:14:55] hoo: please follow the same naming pattern though [16:15:22] which would be? [16:15:24] FingerprintProvider, StatementsContainer and SiteLinkListHolder is going to be fail ;p [16:15:40] so, what do you suggest? [16:16:26] StatementProvider ? [16:16:34] hoo: ye [16:16:40] ok with me [16:17:09] hoo: assuming you will just put getStatements in there [16:17:20] hoo: nowait, it would be StatementListProvider ;p [16:17:37] JeroenDeDauw: I also have setStatements in there right now, but don't need it personally [16:17:48] might be taht aude / aude-wiki needs it for her things though [16:19:39] hoo: you can getStatementList()->addStatement [16:19:59] Indeed cannot replace the whole list though [16:20:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=72879 is where we have issues [16:20:25] statements on properties [16:21:03] doesn't mean it's 'my' thing though [16:21:27] This ChangeOp code is much loved :) [16:23:54] [13WikibaseDataModel] 15mariushoch created 06StatementListProvider (+1 new commit): 02http://git.io/Lf2i-A [16:23:54] 13WikibaseDataModel/06StatementListProvider 144719d0f 15Marius Hoch: Introduce the StatementListProvider interface... [16:24:17] [13WikibaseDataModel] 15mariushoch opened pull request #274: Introduce the StatementListProvider interface (06master...06StatementListProvider) 02http://git.io/brbvlQ [16:24:30] there we go [16:25:06] (03CR) 10Henning Snater: [C: 031] "All QUnit tests and the Selenium tests for aliases pass." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 (owner: 10Henning Snater) [16:25:17] (03CR) 10Henning Snater: [V: 031] Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 (owner: 10Henning Snater) [16:25:37] (03CR) 10Hoo man: [C: 04-1] "Will make use of https://github.com/wmde/WikibaseDataModel/pull/274 here" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170504 (https://bugzilla.wikimedia.org/72124) (owner: 10Hoo man) [16:27:41] (03PS1) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171845 [16:29:25] 3MediaWiki extensions / 3WikidataRepo: support statements on properties in changeops - 10https://bugzilla.wikimedia.org/72879#c3 (10Jeroen De Dauw) Demonstration of how the pressing issue can be resolved: https://gerrit.wikimedia.org/r/#/c/171845/ Commit description also points to the two remaining issues t... [16:29:48] aude: hoo ^ [16:30:05] No changes in DM needed to make this code not break for statements on props [16:30:36] Still, it should be cleaned up so it does not break with new entity types, for which these provider interfaces can indeed be usefull [16:31:04] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Added suggestions placeholder to $.wikibase.entitysearch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171226 (owner: 10Henning Snater) [16:31:29] and disrupted again [16:31:36] noe people call me [16:31:44] :P [16:31:51] smash the phone :P [16:31:55] hoo: scream fanatically at them untill they stop calling [16:32:07] aude: no, smash _their_ phone [16:32:54] JeroenDeDauw: what do we use instead of Claims [16:33:22] it handles putting things in the correct index order etc [16:36:32] (03Merged) 10jenkins-bot: Added suggestions placeholder to $.wikibase.entitysearch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171226 (owner: 10Henning Snater) [16:36:38] oh ffs [16:37:21] * hoo now needs to explain how to remove malware stuffs from Windows [16:37:23] *sigh* [16:37:28] omg [16:37:41] install linux [16:37:46] easy :) [16:38:33] he doesn't even want to reinstall Windows [16:43:49] Amir1: Are you importin the creator templates? [16:44:05] yes [16:44:22] All of them or some subset? [16:44:23] multichill: It will be finished soon [16:44:34] almost all of them [16:44:36] https://commons.wikimedia.org/wiki/Category:Creator_templates_without_Wikidata_link <- soon? [16:44:41] if they have viaf [16:44:42] 3000 items to create? [16:45:34] some of them have viaf [16:46:05] I should some other criteria to import more [16:47:05] *sigh* [16:47:16] I'm almost approaching the point to just import the remaining ones [16:47:24] To get it over with ;-) [16:48:12] I afraid to make duplicates otherwise I don't have any issues to create all of them together [16:48:23] "You can now log in to any wiki site of the Wikimedia Foundation without creating a new account" [16:48:27] yay, wmf specific code [16:49:28] aude: which app [16:49:31] aaaaaaaaaaa, suspicious edits on my wiki [16:49:35] hoo: central auth [16:49:41] maybe there is a setting [16:49:48] multichill: last night I wrote a code to add P31 based on analyzing the first sentence in en.wp [16:50:02] I used some libraries of grammer analysis [16:50:05] Oh, that's a bit like my birth date adding code [16:50:12] aude: Yeah, it indeed sucks a bit.. :/ [16:50:31] I'm using one of the extensions that provides the first few sentences of an article without an infobox and other crap [16:51:13] hoo: removing malware from a windows? You mean formatting the disk? [16:51:22] errors are very low but still too high to run in big scale [16:51:32] I should work on it [16:51:33] * hoo would be happy if people could stop annyoing me today [16:52:00] multichill: I'm harvesting creator template data too [16:52:12] (03PS1) 10Aude: Add @group Database to ApiXmlFormatTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171849 [16:52:20] that explains things [16:52:24] Do you use other authority control besides viaf Amir1? [16:52:35] no [16:52:55] I use them while I'm harvesting data but for finding duplicates no [16:53:14] * hoo still on the phone [16:53:41] Can you add a category if the wikidata link is missing but authority exists? so I can see what I can do [16:53:47] I'm not sysop at commons [16:54:01] multichill: ^ [16:54:02] You don't need that I think [16:54:39] Just look for templates in https://commons.wikimedia.org/wiki/Category:Creator_templates_without_Wikidata_link , but not in https://commons.wikimedia.org/wiki/Category:Creator_templates_without_authority_control_data [16:55:02] I can do it if you like [16:55:03] * hoo still on the phone... [16:55:41] 3MediaWiki extensions / 3WikidataRepo: fix the issue of people not seeing the suggestion in the main search box - 10https://bugzilla.wikimedia.org/53476 (10Henning) 5PATC>3RESO/FIX [16:55:57] do mean a sql query? [16:56:46] Thiemo_WMDE: I am currently working on creating the DBAL adapter in WB DB. You got that right? [16:57:55] * hoo still on the phone...... [16:58:03] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06StatementListProvider: 02http://git.io/4yfCzQ [16:58:03] 13WikibaseDataModel/06StatementListProvider 14bf62747 15Jeroen De Dauw: Update StatementListProvider.php [16:58:59] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/s0JkUw [16:58:59] 13WikibaseDataModel/06master 14e6c6b5b 15Jeroen De Dauw: Merge pull request #274 from wmde/StatementListProvider... [16:59:23] hoo: up rel notes plz [16:59:38] Amir1: Yup [17:00:01] hmm, ok [17:00:13] JeroenDeDauw: Once no longer on zhr phone [17:01:27] Is it "everyone distract me"-Friday? :D [17:01:29] -.- [17:02:25] * aude probably done something wrong but http://snag.gy/bAZih.jpg doesn't look right for the special:mergeaccounts page [17:03:53] [17:04:01] aude: Ignore that [17:04:03] and the form is wrapped in that [17:04:18] I know that problem [17:04:22] it's your setup [17:04:26] so it acts like a link when i mouse over "confirm account" [17:04:28] :( [17:04:36] I know that problem [17:04:39] sure it used to work [17:04:56] wmde/WikibaseDataModel/StatementListProvider/bf62747 : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/40313239 [17:05:26] aude: I had that as well, I can't exactly remember what it was, though [17:05:32] and my wiki is invalid [17:05:33] woha, 1000 commits to DM [17:05:36] * aude sees stacktrace [17:05:47] it was valid on my repo [17:06:07] think i see [17:06:08] do you have the whole $wgConf mess set up? [17:06:30] Finally of the phone, btw... hope he's not going to call back [17:06:40] Amir1: 276 rows in set [17:06:59] it's not much [17:07:06] Less than 10% [17:07:11] CentralAuthWikiList [17:07:17] now it seems attached [17:07:24] I should think of something else [17:07:47] Next time I'm going to print the code and go far away from civilization in order to then change it with a pen :P [17:07:53] oh [17:08:53] * hoo goes back to work [17:08:55] Amir1: https://tools.wmflabs.org/multichill/queries/commons/creators_auth_no_wikidata.txt [17:09:08] Just import those [17:09:16] thanks [17:11:47] Amir1: Already 15.000 creator templates are linked with Wikidata [17:13:14] yes :) [17:13:22] that's awesome [17:14:06] When do you think your first run will be done? I found quite a few items like https://commons.wikimedia.org/wiki/Creator:Charles_Fichot [17:16:23] Amir1: ^? [17:16:34] running [17:16:35] :) [17:16:57] https://www.wikidata.org/wiki/Q18511482 [17:18:12] multichill: I'll add more data to items soon [17:20:25] my knowledge of php is not enough to understand where is wrong https://gerrit.wikimedia.org/r/167795 [17:22:00] Amir1: Add me as reviewer and I'll try to have a look later on [17:22:15] thanks [17:22:29] added [17:22:36] :) [17:23:05] Amir1: I wonder if your bot will pick up https://www.wikidata.org/wiki/Q18511489 [17:23:47] multichill: I should add something to do that [17:24:18] the code is finished [17:24:34] almost all of them should be added now [17:28:40] Amir1: Are you working on the list I made next? [17:28:46] hoo: rel noteeeeeeeeeeeeeees [17:28:56] right [17:28:58] on that [17:29:01] https://tools.wmflabs.org/multichill/queries/commons/creators_auth_no_wikidata.txt ?? [17:29:04] I finished this [17:30:07] You imported them all? [17:30:12] And linked them? [17:30:28] Amir1: That's fast! [17:30:40] almost all of them [17:30:44] I had the code ready [17:31:07] I haven't add P1472 yet which I will do soon [17:32:11] Amir1: Any idea why https://commons.wikimedia.org/wiki/Creator:August_Weger wasn't created? [17:32:38] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/nu3l_A [17:32:38] 13WikibaseDataModel/06master 14f5f093d 15Marius Hoch: Update release notes for StatementListProvider [17:33:49] Amir1: The list went from 277 to 263 so you seem to be missing something [17:34:08] yes, I'm checking why [17:36:25] It can't load the magnus tool [17:38:08] multichill: it's okay now [17:38:11] re-running [17:40:12] (03CR) 10Aude: [C: 04-1] "Strict standards: Non-static method Wikibase\NoLangLinkHandler::getNoExternalLangLinks() should not be called statically, assuming $this f" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159762 (owner: 10Daniel Kinzler) [17:40:35] (03CR) 10Aude: Make NoLangLinkHandler testable. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159762 (owner: 10Daniel Kinzler) [17:40:54] Amir1: Maybe next up all creators that have country = nl, saves me some work ;-) [17:41:22] :) [17:42:31] While clicking around I found a lot of painters that also exist in RKD artists [17:42:58] heya! is this the proper channel to ask people about the wikidata-test labs instances? [17:43:26] YuviPanda: Yeah, somewhat :D [17:43:47] hoo: Cron /usr/bin/php maintenance/runJobs.php --wiki enwikisource 2>&1 >> /var/log/wikidata/runjobs-enwikisource [17:43:51] Could not open input file: maintenance/runJobs.php [17:44:02] that cronjob needs the full path :) [17:44:05] I'm cleaning up cronspam [17:44:11] who takes care of wikidata-test? [17:44:29] hoo: thanks [17:44:36] hoo: weird order of the points though ;p [17:44:57] I ordered it by random.... ascending :D [17:45:04] No, I just wrote it down somehow [17:45:07] also, Cron /usr/bin/php /srv/common/maintenance/runJobs.php --wiki enwiki 2>&1 >> /var/log/wikidata/runjobs-enwiki [17:45:12] /bin/sh: 1: cannot create /var/log/wikidata/runjobs-enwiki: Permission denied [17:45:25] YuviPanda: Dunno whether we still need it, aude might know [17:45:39] aude: hmm, would be nice to kill the instance if we still don't need it :D [17:45:52] labs is in a *little* bit of a crunch atm (we will have new nodes online next week, I think) [17:46:01] hoo: please do make create a bug on bugzilla stating our queries should support sorting by "random... ascending" [17:46:22] YuviPanda: How did one faulty cable manage to take down the whole cluster? [17:46:34] multichill: it took out NFS, and login keys are in NFS [17:46:35] err [17:46:36] ssh keys [17:46:51] I know that if storage fails, all else fails too [17:47:13] So how did one faulty cable take down a whole storage array? That's scary [17:47:47] mwdeploy 2114 0.0 0.6 200680 55776 ? Ss Oct02 0:00 php /usr/local/bin/composer install --prefer-source [17:47:48] wtf [17:48:49] stupid sudo rules: hoo@wikidata-test:~$ sudo sudo -u mwdeploy crontab -l [17:48:51] :D [17:48:52] hoo: is that on the instance? [17:48:56] haha [17:48:59] yeah, just killed [17:49:04] hoo: yay! [17:49:40] hoo: I got added to root alias, and bam, in about 10mins I've like a million emails :) [17:50:21] I guess some are pretty funny... but most just stupid-ish? [17:50:24] YuviPanda: When I get new engineers, one of the first thing I learn them is how to setup proper email filtering :P [17:50:50] multichill: :D true, but I figured everyone filters, so lots of errors are being missed [17:50:51] like this one [17:51:10] Yes, it's good to sometimes look at these folders and kill some of the spam [17:51:20] multichill: yeah, I'm doing that now :) [17:51:26] hoo: there's a bunch more! let me list' [17:51:33] aude: ^ [17:51:34] Cron /usr/bin/php /srv/common/maintenance/runJobs.php --wiki enwikisource 2>&1 >> /var/log/wikidata/runjobs-enwikisource [17:51:36] Pareto's principle works really well here [17:51:41] Can we kill that instacne, looks good to kill to me [17:51:41] /bin/sh: 1: cannot create /var/log/wikidata/runjobs-enwikisource: Permission denied [17:51:56] oooh, that'll be nice too :) [17:51:58] YuviPanda: Already looked at the crontabs [17:52:08] messy stuff [17:52:09] hoo: both root and mwdeploy seem to be executing them [17:52:22] yeah, seen that as well [17:53:19] Amir1: https://commons.wikimedia.org/wiki/Special:Contributions/Dexbot looks stalled [17:53:30] I'm rewriting someparts [17:53:33] to make it better [17:54:54] multichill: can you give me rollbacker right in commons? [17:55:01] I need to revert some of my bot edits [17:55:04] uh oh [17:56:36] Amir1: Done [17:56:46] thank you [17:57:45] And I even slapped a template on your talk page Amir1 ;-) [17:57:46] YuviPanda: After poking some more... the puppet git checkout it has is fairly recent (Oct 30), so it might be that someone was playing around [17:57:57] :) [17:58:03] * hoo no idea who set that thing up [17:59:19] and I answered you ;) [18:05:50] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Code looks very good, just one thing I miss." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169729 (https://bugzilla.wikimedia.org/66433) (owner: 10Henning Snater) [18:07:10] [13ValueView] 15thiemowmde created 06caseInsensitive (+1 new commit): 02http://git.io/Co782w [18:07:11] 13ValueView/06caseInsensitive 145d80802 15Thiemo Mättig: caseInsensitive default to true [18:08:01] [13ValueView] 15thiemowmde opened pull request #130: caseInsensitive default to true (06master...06caseInsensitive) 02http://git.io/E0pQKg [18:09:54] (03PS1) 10Henning Snater: Use wb.datamodel.Term in labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171860 [18:12:25] 3MediaWiki extensions / 3WikidataRepo: Stop using EntityFactory::singleton - 10https://bugzilla.wikimedia.org/65583 (10Lydia Pintscher) [18:12:43] multichill: I think it's done now [18:15:03] about 50 of them are made now [18:15:09] I should work on it more [18:18:54] aude, hoo: any idea if is potentially wikibase-related? [18:19:04] (03PS3) 10Henning Snater: Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 [18:19:14] (03PS2) 10Henning Snater: Use wb.datamodel.Term in labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171860 [18:21:10] ori: No idea, no [18:22:24] JeroenDeDauw: PDO::FETCH_OBJ [18:23:06] setFetchMode( PDO::FETCH_OBJ ) [18:23:27] Amir1: Back, still 212 in the list [18:24:21] yeah, I'm working on it [18:25:24] Thiemo_WMDE: does that method exist in ResultWrapper? [18:25:33] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Confirmed with a regex search." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 (owner: 10Henning Snater) [18:25:43] Where the fuck is this class anyway? [18:25:56] (03PS1) 10Hoo man: Move the linkItem dialog to the top [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171862 (https://bugzilla.wikimedia.org/72687) [18:26:19] whoops [18:26:40] (03PS2) 10Hoo man: Move the linkItem dialog to the top [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171862 (https://bugzilla.wikimedia.org/72687) [18:26:59] Oh, in "DatabaseUtility.php" [18:27:00] >_> [18:27:40] sounds like core [18:28:09] ori: anything is possible [18:28:11] * aude looks [18:28:25] Thiemo_WMDE: we can call setFetchMode on the DBAL result, so it works without duplicating the thing [18:28:41] Thiemo_WMDE: then we still need to change more stuff in QueryEngine though, and thenobject things is not as nice [18:29:03] Thiemo_WMDE: if ResultWrapper where to have this method - and it easily could - then we could just change the MW thing [18:29:13] YuviPanda: i would delete the instance [18:29:32] nobody needs it currently and it's mostly puppetized and/or could use labs vagrant instead [18:29:33] ResultWrapper::setFetchMode? Hm... [18:29:38] Ye [18:29:43] aude: cool, can you delete it? [18:29:46] yes [18:29:53] it's working [18:30:05] wikidata beta mostly is sufficient now :) [18:30:57] ori: do we have any idea what type of queries? [18:31:15] or which tables? [18:31:34] Amir1: Seems to be dropping now :-) [18:32:34] wow, the automatic updating of wikidata-test seems to still work [18:32:39] Warning: require(/srv/common/php-master/extensions/Cite/SpecialCite.php): failed to open stream [18:32:48] but otherwise not maintained, so deleting it [18:32:54] Thiemo_WMDE: we could also just create our own Iterator that holds a ResultWrapper instance and forewards calls to next to ResultWrapper::fetchRow [18:33:09] If only we could use a Generator... That'd be just a few lines of code... [18:33:18] multichill: my main issue now is how to get label [18:33:24] but I'll fix it [18:33:29] I have to go [18:33:31] The label? [18:33:36] Just use the name of the page [18:34:09] Lydia_WMDE: Hey hey! Got any Google Code-In tasks for Wikidata? Need some rough task proposals until European Monday noon on the planning page; can polish later. :) [18:35:20] YuviPanda: how can i tell what all instances that i created? [18:35:29] aude: ah, hmm. I'm unsure. [18:35:38] or from https://wikitech.wikimedia.org/wiki/Nova_Resource:I-0000050a.eqiad.wmflabs [18:35:43] pretty sure i made those [18:36:55] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Found something! ;-) And I miss a little bit of explanation why all these methods are necessary? Are they a prerequisite for something?" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171554 (owner: 10Henning Snater) [18:38:30] Lydia_WMDE: around? [18:38:34] jzerebecki: ? [18:38:42] ? [18:38:48] i want to delete the wikidata-test instance [18:39:06] it is not maintained, mostly puppetiezd or can be recreated with labs vagrant easily [18:39:17] just want to see if anyone cares :) [18:39:34] i think wikidata beta satisfies our needs for the most part [18:39:54] not me [18:39:59] ok [18:40:02] * aude deletes [18:40:16] it's been broken Warning: require(/srv/common/php-master/extensions/Cite/SpecialCite.php): failed to open stream [18:40:24] no one cared or noticed [18:42:02] aude: hey [18:42:03] IMO: delete it [18:42:24] andre__: i've been thinking about it. nothing too useful yet but will think more over the weekend [18:42:38] Lydia_WMDE: too late [18:42:44] *sniff* [18:42:53] * aude deleted the test instance on labs as it is unmaintained [18:42:55] and was broken [18:43:00] ah [18:43:00] ok [18:43:03] :) [18:43:05] easily can be recreatedif/when we need [18:43:09] cool [18:43:16] since it is in puppet or we can use labs vagrant (even better) [18:43:20] Lydia_WMDE: I see. If I can help somehow just say (I think I sent an email with links to the wikidata mailing list to save you some work). Would be awesome to have at least two or three Wikidata tasks on Monday [18:43:29] k [18:43:41] Lydia_WMDE: or maybe someone else from the team has ideas? Research tasks also highly welcome: weird ideas! :P [18:43:53] andre__: hehe ok [18:44:19] andre__: for code in? [18:44:47] aude: thanks! :) [18:44:51] yay less cronspam! [18:45:32] aude: yesh! Anything welcome! Just need 25 rough tasks by Monday European noon, can polish them later. If you have ideas, share them! [18:45:41] (03PS1) 10Hoo man: Allow submitting linkItem form with enter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72807) [18:47:08] Working on these low hanging UI things is kind of relaxing :) [18:47:52] hoo: no, make some of them Google Code-In tasks. :) [18:47:58] (ok, I'll shut up now with GCI) [18:48:40] I'll share it, if something comes to my mind ;) [18:52:40] (03PS2) 10Hoo man: Allow submitting linkItem form with enter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72712) [18:53:25] 3MediaWiki extensions / 3WikidataClient: Page should not be reloaded if the user press ESC to close the "Link with page" popup - 10https://bugzilla.wikimedia.org/72807#c2 (10Marius Hoch) 5PATC>3NEW Accidentally uploaded a change with the wrong bug number. [18:54:08] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Code looks good. Would love to have an second team member have a second look and +2 this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72712) (owner: 10Hoo man) [18:55:42] 3MediaWiki extensions / 3WikidataClient: Page should not be reloaded if the user press ESC to close the "Link with page" popup - 10https://bugzilla.wikimedia.org/72807#c3 (10Marius Hoch) The page is being refreshed on all popup closes (after successful linking) on purpose, I'm not sure we want to change this... [18:59:06] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "A step forward is a step forward, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171845 (owner: 10Jeroen De Dauw) [18:59:44] Lydia_WMDE: Did Daniel leave yet? [19:00:14] well, it's 8pm on a Friday, so wouldn't be surprising :P [19:01:06] hoo: a while ago [19:01:10] Yeah :/ [19:01:23] I would like to do something about https://bugzilla.wikimedia.org/show_bug.cgi?id=72678 [19:02:04] Not listing redirects would require changing the entity batch stuff, but should be doable [19:02:29] * aude nods [19:02:33] But would like to hear his opinion first [19:02:43] 3MediaWiki extensions / 3WikidataRepo: json dumps have duplicate items (one for the redirect, one for the target) - 10https://bugzilla.wikimedia.org/72678#c3 (10Ori Livneh) See: http://tools.ietf.org/html/rfc6901 [19:02:44] hoo: check out http://tools.ietf.org/html/rfc6901 [19:04:43] (03Merged) 10jenkins-bot: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171845 (owner: 10Jeroen De Dauw) [19:04:45] mh [19:05:29] (03PS1) 10Henning Snater: Use wb.datamodel.Term in descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171878 [19:05:44] thinking about it: That would horribly not work, although it might be semantically nice [19:06:08] our JSON has close to 40gb now (or so), thus people usually read it line by line and not as a one json [19:06:58] (03PS3) 10Henning Snater: Use wb.datamodel.Term in labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171860 [19:07:02] (03PS2) 10Henning Snater: Use wb.datamodel.Term in descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171878 [19:10:10] 3MediaWiki extensions / 3WikidataRepo: json dumps have duplicate items (one for the redirect, one for the target) - 10https://bugzilla.wikimedia.org/72678#c4 (10Marius Hoch) (In reply to Ori Livneh from comment #3) > See: http://tools.ietf.org/html/rfc6901 thinking about it: That would horribly not wo... [19:12:54] (03CR) 10Thiemo Mättig (WMDE): "Not sure. Would love to have a second opinion. Henning?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171862 (https://bugzilla.wikimedia.org/72687) (owner: 10Hoo man) [19:13:01] Thiemo_WMDE: look, I'm improving the support of kitten deletion in DBAL https://github.com/doctrine/dbal/pull/722/files [19:13:07] (03PS5) 10Henning Snater: Added .focus() to $.ui.TemplatedWidget and child widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171554 [19:13:35] Thiemo_WMDE: It only does the 50px if there's space to do so [19:13:43] If not, then it just goes straight to the top [19:15:35] (03PS6) 10Henning Snater: Removed focus smartness from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171555 [19:15:37] (03PS2) 10Henning Snater: Removed obsolete $.TemplatedWidget alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 [19:15:43] (03CR) 10Hoo man: Move the linkItem dialog to the top (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171862 (https://bugzilla.wikimedia.org/72687) (owner: 10Hoo man) [19:23:49] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Still not sure if 50 is ok. It's good enough for me, so whoever looks at this, feel free to merge." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171862 (https://bugzilla.wikimedia.org/72687) (owner: 10Hoo man) [19:24:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Added .focus() to $.ui.TemplatedWidget and child widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171554 (owner: 10Henning Snater) [19:28:21] (03CR) 10Hoo man: [C: 032] "I think the regexp could even be a bit simpler, but this works." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171538 (owner: 10Adrian Lang) [19:28:33] fuck that spacing [19:28:35] ahhhhhhh [19:28:53] hah :) [19:29:01] evil mediawiki habits [19:29:59] mhhh [19:30:02] evil PSR-2 [19:30:46] aude: did you succeed testing the delete stuffs, btw? [19:31:20] no :( [19:31:37] oh :( [19:31:50] need to check my settings [19:31:56] (03PS2) 10Hoo man: [WIP] Rewrite SpecialUnconnectedPages to use QueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 (owner: 10Ladsgroup) [19:32:05] (03Merged) 10jenkins-bot: Added .focus() to $.ui.TemplatedWidget and child widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171554 (owner: 10Henning Snater) [19:32:06] * aude knows it used to work [19:32:34] or i could try vagrant maybe [19:32:37] CA is very hard to set up correctly [19:33:16] we even have it for wikimedia dc wikis [19:33:19] it works there [19:33:28] single sign on :D [19:33:51] print_r($dbrg); :P [19:35:59] (03Merged) 10jenkins-bot: Actually make resources work from vendor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171538 (owner: 10Adrian Lang) [19:36:14] Hmm, is there a thing anywhere that shows the plan/status for adding certain other sites to wikidata (like a bug or dev timeline or something along those lines) or is it just watching the Status Update pages? [19:38:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Rewrite SpecialUnconnectedPages to use QueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 (owner: 10Ladsgroup) [19:38:30] [13WikibaseDatabase] 15JeroenDeDauw created 06DBALQueryInterface (+1 new commit): 02http://git.io/TZB-Dg [19:38:30] 13WikibaseDatabase/06DBALQueryInterface 147250653 15jeroendedauw: Add DBALQueryInterface [19:38:31] WMF sites? [19:38:41] Yeah [19:39:43] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #60: Add DBALQueryInterface (06master...06DBALQueryInterface) 02http://git.io/0JLYeQ [19:41:12] (03CR) 10Hoo man: [C: 04-1] "Tests need to be adapted to this (this is why jenkins -2s), also the 'special-unconnectedpages' needs to be renamed to 'unconnectedpages'." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 (owner: 10Ladsgroup) [19:42:29] wmde/WikibaseDatabase/DBALQueryInterface/7250653 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/40328177 [19:43:00] (03CR) 10Hoo man: [WIP] Rewrite SpecialUnconnectedPages to use QueryPage (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 (owner: 10Ladsgroup) [19:44:45] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06DBALQueryInterface: 02http://git.io/M_BOpA [19:44:45] 13WikibaseDatabase/06DBALQueryInterface 1466d4178 15jeroendedauw: Split select method in DBALQueryInterface [19:45:40] https://github.com/wmde/WikibaseEntityStore is that being used anywhere? [19:45:50] Seems to consist entirely of duplicates [19:46:33] WikibaseQuery/composer.json: "wikibase/entity-store": "~0.2.0@dev" [19:46:35] *sigh* [19:47:30] hoo: duplicates? [19:47:48] JeroenDeDauw: Well, you can achieve all that with just Wikibase [19:48:56] hoo: as far as I remember, there was an equivalent for one of the fetchers [19:49:08] hoo: but note that these implement a different interface [19:49:15] BatchingFetcher [19:49:37] hoo: which means they can be used as follows: https://github.com/JeroenDeDauw/BatchingIterator/#batchingiterator [19:49:51] hi Amir1 :) [19:49:58] hi :) [19:50:23] I don't know It's worked correctly or not [19:50:39] JeroenDeDauw: They have rewind? That's like the only difference I see from what we have in Wikibase [19:50:54] Amir1: The output looks good to me at a glance [19:51:13] oh cool, it's my first real patch in php [19:51:54] * hoo just realized he has no pages actually connected on his test wiki :P [19:51:59] Been playing around to much today [19:53:16] hoo: please link the Wikibase code [19:53:58] (03CR) 10Jeroen De Dauw: [C: 032] Add @group Database to ApiXmlFormatTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171849 (owner: 10Aude) [19:55:12] EntityPerPageIdPager [19:55:19] but you're right, your interface offers more things [19:55:48] (03CR) 10Jeroen De Dauw: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude) [19:56:21] aaaah [19:56:53] hoo: EntityPerPageIdPager is equivalent to one of the fetchers. That duplication is indeed silly [19:57:03] The important part is that you can also iterate over it [19:57:32] hoo: also, Wikibase.git is not a library [19:57:33] (03PS20) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [19:57:49] You cannot use the stuff in it from anything that is not an extension to it [19:58:02] but WikibaseQuery is exactly that [19:58:19] hoo: sure, so it _can_ do that [19:58:26] It is still not nice to do so though [19:58:46] Using a well defined library is much better than using something from a ball of stuff [19:58:50] WikibaseEntityStore also depends on WB master [19:59:12] ah, it uses store logic [19:59:13] I see [19:59:21] It does indeed [19:59:34] It allows the user to continue using the existing code without binding to it so much [19:59:42] It's an intermediate step of course [19:59:55] The end goal is to have a stand alone library [20:00:08] Which is used by Wikibase.git and by Wikibase Query, without depending on either [20:00:40] Which is then a good place to have a lot of the stuff currently in Wikibase Lib, bringing us one step closer to killing that thing [20:00:42] multichill: done now [20:00:47] let's see how many left [20:01:01] hoo: any help with moving in that direction is much appriciated [20:01:04] JeroenDeDauw: that sounds like a good idea [20:02:05] (03PS3) 10Jeroen De Dauw: Add package definitions for each component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 [20:02:13] !merge [20:02:13] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c// [20:02:21] !merge 171481 [20:02:21] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/171481/ [20:02:45] heheh [20:02:56] oh wow [20:02:58] sounds like me [20:03:21] JeroenDeDauw: Will that confuse stuffs if we have multiple composer.json in there before the actual split? [20:03:25] or me [20:06:12] (03CR) 10Aude: Add package definitions for each component (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [20:06:59] hoo: no it will not [20:07:10] hoo: only the composer.json file in the root is used [20:08:21] I see [20:08:32] yeah [20:08:33] * hoo could use some review candy now :D [20:08:48] * aude uses the build (resources) which has composer.json [20:09:22] don't htink it would know about the other composer.json files [20:09:36] until we specify those packages [20:10:58] Already having these files makes the split a little easier [20:11:31] !nyan | Abraham_WMDE [20:11:31] Abraham_WMDE: ~=[,,_,,]:3 [20:12:10] @return Iterator [20:12:16] huh, is that valid php doc [20:12:39] C++ called, it wants it's syntax back [20:13:00] (03PS3) 10Ladsgroup: [WIP] Rewrite SpecialUnconnectedPages to use QueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 [20:13:02] Oh dear... [20:13:14] hoo: there is a PSR discussion on standardizing that [20:13:39] And things such as int[] or array [20:13:40] hoo: heh [20:14:01] Apparently internals wants array [20:14:05] I checked some of mediawiki core tests and none of query page special pages had test. strange [20:14:08] So many people are sad now [20:14:18] javaizing php [20:14:48] aude: you mean giving PHP a propertype system? [20:14:55] Java is not the only language that has that [20:14:56] aude: And they started with having a crappy gc? [20:15:20] aude: we should just use hack already [20:15:38] gradual typing <3 [20:16:49] :) [20:18:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Rewrite SpecialUnconnectedPages to use QueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 (owner: 10Ladsgroup) [20:19:57] wtf [20:20:09] I just free 1.8gb of ram by restarting apache locally [20:21:25] * freed [20:30:54] aude: do you have anything you want reviewed or so? [20:31:00] If not, I think I'll call it a day [20:31:22] Changing lua to use label lookup still seems blocked [20:32:03] hoo: https://gerrit.wikimedia.org/r/#/c/171530/ [20:32:53] mh, that could actually be used for the Lua stuffs [20:32:53] i would need to take another look at lua to see what might be a good solution [20:32:58] it can [20:33:11] So you answered both of my questions with one link, well done :D [20:33:14] it's doing what is done now, but beind the interface [20:33:21] behind* [20:33:37] not for Lua... Lua does round trips between PHP and Lua, which are heavy [20:33:59] (mostly memory wise) [20:33:59] hmmm [20:34:07] yeah [20:34:17] So this could actually give us an edge [20:34:17] i wonder if the lua format can be cached [20:34:36] define "lua format" [20:34:48] one sec [20:34:51] the array serialization, the renumbered array serialization, or the lua table [20:34:55] or something else [20:35:53] the results of $this->wbLibrary->getEntity in Scribunto_LuaWikibaseLibrary [20:36:43] not sure that would be worth it [20:37:07] it certainly wouldn't once we move beyond the point of putting all entities into Lua just to get the label out of the table there [20:37:20] true [20:37:39] I think I'll do that later on, shouldn't be that hard if your classes are nice to reuse [20:37:51] ok [20:39:09] hoo: what are you complaining about ram? Don't be a noob and http://www.downloadmoreram.com/ [20:41:15] Jeroen_gaming: Awesome, but will it run on Windows Word? because that's what I run on my Computer [20:42:10] (03CR) 10Hoo man: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude) [20:43:55] aaaah [20:44:17] good catch [20:45:16] (03PS21) 10Aude: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 [20:47:58] looks good at a glance, will poke more later [20:47:59] on [20:48:17] thanks [20:48:47] Amir1: 109 [21:02:45] Amir1: Hi, back :-0 [21:02:53] :) [21:03:00] Amir1: 109, that's what is left at https://tools.wmflabs.org/multichill/queries/commons/creators_auth_no_wikidata.txt [21:03:11] I'm writing a code to harvest dob and dod from creators [21:03:33] I can do other things to make it even less [21:03:40] multichill: Do you want it? [21:04:06] Want what? I would like to see those last 109 imported if possible :-) [21:05:48] sure [21:11:35] Amir1: Maybe some more can be matched using the category or the image, but I doubt that will turn up a lot [21:11:53] we can merge them later [21:11:58] :D [21:13:21] True [21:14:36] Amir1: Can you just go over the category and import every creator template where | Nationality = nl ? [21:14:57] multichill: [21:14:59] sure [21:15:02] Quite a few people are working on that so the dupes will be cleared quickly I think [21:15:10] I'm sure GerardM- will help too ;-) [21:17:28] :) [21:18:48] https://www.wikidata.org/wiki/Q18511839 [21:19:28] Briseis Painter ? [21:19:48] Right [21:19:58] I'm creating the items [21:20:07] I'm also harvesting their dob and dod [21:20:39] Also adding backlinks on Wikidata? [21:21:16] do you mean P1472? [21:22:44] multichill: ^ [21:24:09] Amir1: Yes, that one [21:24:26] Yes, I'll add it too [21:24:42] I'm waiting this one to finish [21:25:37] If it has dob or dod, you can add instance of human [21:26:34] yes I add that too [21:26:53] do you have creators that are not human? [21:26:54] :) [21:27:13] dobi the painting elephant ? [21:27:24] Amir1: Yes, sometimes, companies etc [21:27:38] A non trivial amount [21:28:23] Amir1: https://www.wikidata.org/wiki/Q18511605 is still rather empty [21:28:36] Probably best to add the creator claim on first edit [21:29:01] ok, fixed it [21:29:07] I haven't started it yet [21:29:11] (I just started) [21:30:34] creators of what? [21:30:39] https://www.wikidata.org/w/index.php?title=Q18511605&action=history <- because now someone is adding it by hand [21:31:23] oh please [21:31:29] It'll be done by the next hour [21:31:34] wait a minute [21:32:45] People have stalklists, if you wait too long, they'll beat your bot to it Amir1 [21:32:46] Nemo_bis: hey, Creator namespace in commons [21:33:00] :D [21:33:31] https://www.wikidata.org/wiki/Special:Contributions/Dexbot [21:42:41] Looks good Amir1! [21:43:23] Is there a link about this namespace? [21:44:23] Nemo_bis: https://commons.wikimedia.org/wiki/Template:Creator [21:45:07] I know the template on commons; I don't know anything about a namespace on wikidata [21:45:34] Namespace on Wikidata? [21:45:40] Ah, I misread [21:45:54] We're just linking the creator templates with items and importing stuff [21:45:58] Sorry, I should clearly sleep [21:46:31] I hope the creator template on Commons will benefit from all data which got imported from it.wiki [21:46:35] Amir1: 22 left on https://tools.wmflabs.org/multichill/queries/commons/creators_auth_no_wikidata.txt . [21:46:39] {{bio}} is still not using it, hmpf [21:47:00] First step is to get every creator template linked to Commons [21:47:07] And move some data [21:47:27] We first need to have some software improvements before we can actually access the data on Commons [21:47:42] Yep. it.wiki did both of that but still didn't get any data in use, sob sob [21:49:06] Keep up the good work Amir1, I'm going to sleep [21:52:31] I was afk [21:52:38] :) [21:52:52] I'll import more [22:28:53] (03PS3) 10Hoo man: Allow submitting linkItem form with enter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72712) [22:29:48] (03CR) 10Hoo man: "I just remembered that using keypress might not work reliably cross-brower, so I changed this towards keydown now. New version tested in F" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72712) (owner: 10Hoo man) [22:31:28] why did I use towards in that sentence? :P Sometimes I surprise myself... [22:33:13] aude: hoo can you guys add me to the wikidata project on labs? [22:33:21] or wheverever wikidata-jenkins* hosts are? [22:33:24] * YuviPanda is fixing some cronspam in them [22:33:35] YuviPanda: I think they are a part of a new project [22:33:40] that I'm not even member of [22:33:45] awww, damn [22:34:03] I'm cloudadmin, so I can add myself to any project, except 2fa and my phone is kind of dead now... [22:34:07] https://wikitech.wikimedia.org/wiki/Nova_Resource:Wikidata-build [22:34:10] and I don't want to use my backup keys [22:34:24] If aude is still around, she can help [22:36:21] jzerebecki: ^ [22:37:27] YuviPanda: trying to add you [22:37:43] jzerebecki: sweet! :D [22:38:05] You might also want to add me, while you're on it [22:41:15] Jeroen_gaming: Is WikibaseDatabase even Wikibase specific? At a glance it looks more generic than that [22:41:17] * hoo just wondering [22:41:19] YuviPanda: done [22:41:45] jzerebecki: thanks! [22:43:52] hoo: done [22:51:12] jzerebecki: thanks :) [22:59:13] (03CR) 10Hoo man: [C: 032] Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude) [22:59:40] I think the first in was supposed to be "a" :P [23:05:46] (03Merged) 10jenkins-bot: Use in LabelLookup (w/ EntityRetrievingTermLookup) in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude)