[09:16:21] 3MediaWiki extensions / 3WikidataRepo: DatabaseBase::deadlockLoop: Transaction already in progress (from RefreshLinks::fixLinksFromArticle) - 10https://bugzilla.wikimedia.org/73456 (10Sam Reed (reedy)) 5PATC>3NEW [09:32:06] Lydia_WMDE: https://en.wikipedia.org/wiki/New_Forest [09:46:40] (03CR) 10Hoo man: "Looks good, but needs a manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [09:47:02] (03CR) 10Hoo man: [C: 04-1] Move RepoApi files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [09:59:49] [13WikibaseDataModel] 15mariushoch created 06removeAllTheCruft (+1 new commit): 02http://git.io/2c9WYw [09:59:49] 13WikibaseDataModel/06removeAllTheCruft 14b0ab330 15Marius Hoch: Remove unused StatementList::getBestStatementPerProperty and BestStatementsFinder [10:01:03] [13WikibaseDataModel] 15mariushoch opened pull request #279: Remove unused StatementList::getBestStatementPerProperty and BestStatementsFinder (06master...06removeAllTheCruft) 02http://git.io/ob64EA [10:01:44] wmde/WikibaseDataModel/removeAllTheCruft/b0ab330 : Marius Hoch The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41146181 [10:05:15] [13WikibaseDataModel] 15mariushoch 04force-pushed 06removeAllTheCruft from 14b0ab330 to 148ac8e85: 02http://git.io/jgXAJQ [10:05:15] 13WikibaseDataModel/06removeAllTheCruft 148ac8e85 15Marius Hoch: Remove unused StatementList::getBestStatementPerProperty and BestStatementsFinder [10:07:17] wmde/WikibaseDataModel/removeAllTheCruft/8ac8e85 : Marius Hoch The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41146334 [10:24:39] Hi [10:41:53] (03PS4) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [10:48:34] (03CR) 10jenkins-bot: [V: 04-1] API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [10:54:40] (03CR) 10Hoo man: [C: 04-1] API PageTerms (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [11:17:29] (03PS5) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [11:44:33] I'm not able to find any "friendship" property [11:44:46] does it exist, or do I need to create one? [11:46:04] (03PS3) 10Addshore: Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 (owner: 10Thiemo Mättig (WMDE)) [11:51:16] zorun: I don't think it exists. [11:51:32] And I don't think friendships are very relevant. [11:53:07] sjoerddebruin: actually, our use-case is to add information about fictional characters [11:53:36] hmm [11:55:51] hmm, maybe wikidata is not the right place for this [11:56:20] there are already items about some characters [11:56:23] for instance http://www.wikidata.org/wiki/Q2661864 [12:49:39] (03CR) 10Hoo man: [C: 04-1] "Still lacking tests, but should be good despite." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [13:17:51] 3MediaWiki extensions / 3WikidataClient: Special:SetAliases (or SpecialModifyTerm) should properly validate / normalize label/alias input - 10https://bugzilla.wikimedia.org/60828#c5 (10Marius Hoch) Changing this bug, because it's only a result of invalid data... you shouldn't have been able to set that alias... [14:46:54] 3MediaWiki extensions / 3WikidataRepo: benchmark new data model implementation in php - 10https://bugzilla.wikimedia.org/73485 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The new data model implementation is said to be considerably slower than the old one. We need to benchmark this... [14:47:20] 3MediaWiki extensions / 3WikidataRepo: benchmark new data model implementation in php - 10https://bugzilla.wikimedia.org/73485 (10Lydia Pintscher) p:5Unprio>3High [14:48:14] (03CR) 10Jeroen De Dauw: "What is the -1 for?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [14:48:31] (03CR) 10Jeroen De Dauw: [C: 031] Move RepoApi files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [14:50:41] Amir1: Online? [14:50:49] How are the creator templates going? [14:51:10] Can you also match institution templates? Plenty of them in https://commons.wikimedia.org/wiki/Category:Institution_templates_without_Wikidata_link [14:51:18] multichill: hey [14:51:52] I'm waiting for the Institution property to be created and I will migrate the data afterwards [14:52:32] multichill: https://www.wikidata.org/wiki/Wikidata:Property_proposal/Organization#Commons_Institution_page [14:53:10] (03PS6) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [14:53:20] Lydia_WMDE: ---^ [14:58:52] (03CR) 10jenkins-bot: [V: 04-1] API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [14:59:08] Jenkins says no [15:01:25] (03PS7) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [15:06:49] (03CR) 10jenkins-bot: [V: 04-1] API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [15:08:26] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #279 148ac8e85: No date please, you do not know when the next rel is 02http://git.io/rXw7ow [15:16:55] Where do the Item() and Property() classes get called? [15:17:11] (or, initialized, really) [15:27:02] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #279: Remove unused StatementList::getBestStatementPerProperty and BestStatementsFinder (06master...06removeAllTheCruft) 02http://git.io/ob64EA [15:28:20] GPHemsley: that is an application and context specific question [15:28:41] JeroenDeDauw: Which application does it for Wikidata? [15:29:54] And where do I report a bug for Wikibase? [15:30:23] Amir1: Right, I just created that property [15:30:30] Amir1: https://www.wikidata.org/wiki/Property:P1612 [15:30:41] fantastic [15:30:45] thanks :) [15:30:46] GPHemsley: if you want to know how these classes get constructed when viewing their associated wiki page: Wikibase Repo pulls a json blob from the database and hands it over to Wikibase Internal Serialization, which returns the deserialized entity (and thus does the construction of the object) [15:30:56] https://github.com/wmde/WikibaseInternalSerialization/ [15:31:27] sheesh, there sure are a lot of moving parts [15:46:18] * Amir1 is writing scripts to harvest data [15:49:47] (03PS8) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [15:50:17] * GPHemsley notes that somebody isn't developing with error_reporting set to E_ALL [15:52:35] 3MediaWiki extensions / 3WikidataClient: Add Wikibase API module that is usable from client wikis and available as a generator & prop module - 10https://bugzilla.wikimedia.org/72729#c8 (10Daniel Kinzler) I have implemented a pageterms module, see I9b6b52f6b75e4d6a [15:56:42] (03CR) 10jenkins-bot: [V: 04-1] API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [16:05:07] why jenkins, why? [16:05:14] )-; [16:30:04] (03PS9) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [16:35:52] (03CR) 10jenkins-bot: [V: 04-1] API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [16:39:19] https://commons.wikimedia.org/wiki/Special:Contributions/Dexbot [16:43:32] (03CR) 10Daniel Kinzler: "@jeroen: The comment reflects to original rationale of using" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [16:44:58] (03CR) 10Jeroen De Dauw: "Never said it should block the change. Did not even give a -1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [16:48:34] (03PS10) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [16:49:03] JeroenDeDauw: never said you said that :) [16:50:45] DanielK_WMDE_: and I never said you said I said that? [16:55:14] (03CR) 10jenkins-bot: [V: 04-1] API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [17:00:51] * hoo waves [17:00:58] Lydia_WMDE: aude: Around? [17:03:21] * hoo needs someone to test something with Wikibase, preferably master [17:06:05] Typical that I notice such breakage in the train... [17:09:15] [13WikibaseDataModel] 15mariushoch created 06propertyClaims (+1 new commit): 02http://git.io/_XDWzw [17:09:15] 13WikibaseDataModel/06propertyClaims 14e0f5721 15Marius Hoch: Add the deprecated Claim handler functions to Property... [17:11:50] wmde/WikibaseDataModel/propertyClaims/e0f5721 : Marius Hoch The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41168650 [17:13:57] ah crap [17:19:26] * hoo fighting with spotty mobile networks [17:20:29] [13WikibaseDataModel] 15mariushoch 04force-pushed 06propertyClaims from 14e0f5721 to 1428e612a: 02http://git.io/m39jnA [17:20:29] 13WikibaseDataModel/06propertyClaims 1428e612a 15Marius Hoch: Add the deprecated Claim handler functions to Property... [17:24:01] wmde/WikibaseDataModel/propertyClaims/28e612a : Marius Hoch The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41169377 [17:24:24] [13WikibaseDataModel] 15mariushoch 04deleted 06removeAllTheCruft at 148ac8e85: 02http://git.io/PWHI-Q [17:25:58] [13WikibaseDataModel] 15mariushoch opened pull request #280: Add the deprecated Claim handler functions to Property (06master...06propertyClaims) 02http://git.io/mkbUng [17:55:52] (03PS1) 10Hoo man: Don't include redirects in json dumps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173664 (https://bugzilla.wikimedia.org/72678) [18:17:29] (03PS4) 10Hoo man: Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) [18:17:47] (03CR) 10Hoo man: "Manually rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [19:11:00] Hi. I've a annoying issue with Wikidata. Logged out, all works. Logged in, every gadget disabled, no custom code in userspace js, settings reseted to default, when I want to edit a value I got a "ypeError: mw.template is not a function" error. [19:11:28] I wanted to investigate where it comes from and so I add ?debug=1 to the URL. But, in such a case, it works :/ [19:12:25] Do you have a global js? [19:14:21] No, I don't. [19:14:32] Hmmm. [19:15:37] (03PS1) 10Hoo man: Move UpdateRepo hook handlers into a dedicated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 [19:17:12] (03PS2) 10Hoo man: Move UpdateRepo hook handlers into a dedicated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 [19:17:29] This seems to be browser specific too. I launched another instance of Firefox, with another user profile, and it works. [19:17:50] (03CR) 10Hoo man: "@Daniel: Moved the hook handlers into a dedicated class in a follow up." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [19:20:46] calling it a day [20:32:10] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #280 1428e612a: StatementList has an isEmpty 02http://git.io/SkZ6jg [20:53:53] 3MediaWiki extensions / 3WikidataRepo: Remove incorrect Entity assumptions from EntityParserOutputGenerator - 10https://bugzilla.wikimedia.org/73495 (10Jeroen De Dauw) 3NEW p:3Unprio s:3normal a:3Wikidata bugs EntityParserOutputGenerator contains assumptions about entities that do not hold. (For inst... [21:06:53] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) 3NEW p:3Unprio s:3normal a:3Wikidata bugs This is a bug to track the issues in Wikibase Repository that prevent it from working with new types of Entities, and thus the blockers... [21:07:37] 3MediaWiki extensions / 3WikidataRepo: Remove incorrect Entity assumptions from EntityParserOutputGenerator - 10https://bugzilla.wikimedia.org/73495 (10Jeroen De Dauw) [21:07:50] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [21:10:45] (03PS1) 10Jeroen De Dauw: Do not pass whole Entity when not needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173676 [21:13:09] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in RdfBuilder - 10https://bugzilla.wikimedia.org/73497 (10Jeroen De Dauw) [21:13:09] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in RdfBuilder - 10https://bugzilla.wikimedia.org/73497 (10Jeroen De Dauw) 3NEW p:3Unprio s:3normal a:3Wikidata bugs RdfBuilder suffers from the issues described in https://bugzilla.wikimedia.org/show_bug.cgi?id=73496 [21:13:09] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [21:14:55] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in EntitySearchTextGenerator - 10https://bugzilla.wikimedia.org/73498 (10Jeroen De Dauw) 3NEW p:3Unprio s:3normal a:3Wikidata bugs EntitySearchTextGenerator suffers from the issues described in https://bugzilla.wikimedia.org/show_bug.cgi?id... [21:15:06] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in EntitySearchTextGenerator - 10https://bugzilla.wikimedia.org/73498 (10Jeroen De Dauw) [21:15:08] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [21:18:36] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [21:18:37] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188#c3 (10Jeroen De Dauw) This also blocks https://bugzilla.wikimedia.org/show_bug.cgi?id=73496 since the old code contains a lot of the issues it tracks. [21:26:35] 3MediaWiki extensions / 3WikidataRepo: use WikibaseInternalSerialisation in data model - 10https://bugzilla.wikimedia.org/62789#c4 (10Jeroen De Dauw) 5NEW>3RESO/FIX Closing this as it really makes no sense [21:28:05] 3MediaWiki extensions / 3WikidataRepo: make constructor args of SerializerFactory mandatory - 10https://bugzilla.wikimedia.org/66020#c1 (10Jeroen De Dauw) 5NEW>3RESO/WON Superseded by https://bugzilla.wikimedia.org/show_bug.cgi?id=62188 [21:29:52] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in EntityView - 10https://bugzilla.wikimedia.org/73499 (10Jeroen De Dauw) [21:29:52] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [21:29:55] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in EntityView - 10https://bugzilla.wikimedia.org/73499 (10Jeroen De Dauw) 3NEW p:3Unprio s:3normal a:3Wikidata bugs EntityView suffers from the issues described in https://bugzilla.wikimedia.org/show_bug.cgi?id=73496 [21:31:37] 3MediaWiki extensions / 3WikidataRepo: Fix OCP violation in ChangeOps - 10https://bugzilla.wikimedia.org/73500 (10Jeroen De Dauw) [21:31:38] 3MediaWiki extensions / 3WikidataRepo: Fix OCP violation in ChangeOps - 10https://bugzilla.wikimedia.org/73500 (10Jeroen De Dauw) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The ChangeOps suffer from the OCP violation tracked by https://bugzilla.wikimedia.org/show_bug.cgi?id=73496 [21:31:50] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [21:49:16] (03PS1) 10Jeroen De Dauw: Update type hints to not use Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173701 [21:52:25] (03PS1) 10Jeroen De Dauw: Update comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173724 [22:53:50] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [22:53:52] 3MediaWiki extensions / 3WikidataRepo: Refactor EntityContent (tracking) - 10https://bugzilla.wikimedia.org/69752 (10Jeroen De Dauw) [22:54:05] 3MediaWiki extensions / 3WikidataRepo: basic support for Wikimedia Commons (MediaInfo entity type) - 10https://bugzilla.wikimedia.org/64288 (10Jeroen De Dauw) [22:54:20] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [22:59:35] 3MediaWiki extensions / 3WikidataRepo: serialization is missing the datatype field - 10https://bugzilla.wikimedia.org/70995#c3 (10Jeroen De Dauw) Not sure this is something we actually should do. The internal format never had this information. Did we actually check there is a valid use case here? [23:17:22] (03PS6) 10Hoo man: Make mw.wikibase.entity.formatPropertyValues work for non-items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170504 (https://bugzilla.wikimedia.org/72124)