[00:20:06] bd808: Hm.. What I'd do is delete hook from https://github.com/wikimedia/simplei18n/settings/hooks and then on https://travis-ci.org/profile "Sync now" then on the left Wikimedia>simplei18n->on [00:20:15] rrr. chan mixup [03:04:23] um, logging into wikidata keeps giving me a 503 message ... this is happening for a quite some time, i'm able to login to other projects just fine ... [03:54:49] how do you create new properties? [04:00:42] Pharos: you can't [04:00:52] you need to have the property creator right [04:01:35] the community needs to approve the creation of new properties [04:01:39] Pharos: see https://www.wikidata.org/wiki/Wikidata:Property_proposal [04:01:44] propose them there [04:01:55] thanks! [04:03:11] sure np [04:03:14] cheers [04:03:43] Pharos: do you need any other help? wikidata? etc. [04:04:17] Eurodyne: what are the relevant rules about COI for the project? [04:04:29] has this been an issue that has come up yet? [04:05:05] no i don't think so... [04:05:09] but i'm not 100 percent sure [04:05:19] maybe JD|Cloud can help [04:05:30] Jasper, what are the COI rules for Wikidata? [04:05:41] Pharos, idk if he is online... [04:08:21] someone suggested we might have properties related to financial data or ratings of companies [04:08:29] hm... [04:08:37] i think there is a section for that on WD:PP [04:08:38] ... [04:09:32] yes, I was just browsing https://www.wikidata.org/wiki/Wikidata:Property_proposal/Economics now [04:11:08] is https://www.wikidata.org/wiki/Wikidata:List_of_properties/Summary_table actually complete? [04:12:47] ah, i think has the closest information on existing properties: https://www.wikidata.org/wiki/Wikidata:List_of_properties/Organization [04:44:03] Eurodyne: use common sense [04:44:07] we make as few policies as possible [04:44:17] JD|Cloud hi there okay [04:44:32] sorry Pharos, I was away [04:45:13] no problem Eurodyne [04:45:20] :) [04:46:19] if a company wanted to pay someone to edit Wikidata, would that beb a problem? [04:47:13] i;m trying to think thru where the common sense on COI applies for this type of project [04:47:39] obviously it's different in some major ways from Wikipedia, for example [05:25:48] erm anyone around? [05:55:33] PROBLEM - check if wikidata.org dispatch lag is higher than 2 minutes on wikidata is CRITICAL: No route to host [06:55:38] RECOVERY - check if wikidata.org dispatch lag is higher than 2 minutes on wikidata is OK: HTTP OK: HTTP/1.1 200 OK - 1509 bytes in 0.857 second response time [08:10:40] "Conferma che le pagine mostrate qui sotto sono quelle che si desidera collegare con questa pagina." But there isn't any other page listed below and confirming doesn't do anything. Ading the sitelink on wikidata itself worked: https://www.wikidata.org/w/index.php?title=Q18152337&diff=175455260&oldid=175455207 [08:11:02] (That is, I did it manually rather than using the dialog on the target page) [08:29:12] [13WikidataBuildResources] 15tobijat 04deleted 06composer at 14a43aa28: 02http://git.io/3U68hw [08:30:44] 3MediaWiki extensions / 3WikidataRepo: Can't use tab while adding sitelinks - 10https://bugzilla.wikimedia.org/73642 (10Nemo) 3NEW p:3Unprio s:3normal a:3Wikidata bugs 1) Visit an entry, e.g. https://www.wikidata.org/wiki/Q18152337 2) Click "edit" next to a "Pages..." header, e.g. https://www.wikidat... [08:34:15] FYI https://translatewiki.net/w/i.php?title=MediaWiki%3AWikibase-concept-uri%2Fqqq&diff=5872881&oldid=5663891 [08:42:23] 3MediaWiki extensions / 3WikidataRepo: Can't use tab while adding sitelinks - 10https://bugzilla.wikimedia.org/73642 (10tobias.gritschacher) p:5Unprio>3High [09:03:52] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c32 (10Thiemo Mättig) (In reply to JulesWinnfield-hu from comment #31) > why not minute? I'm afraid there is no single perfect solution. Currently I see three ways to parse 47°42'0.00"N, 15°27'0.00"E:... [09:18:32] [13Geo] 15thiemowmde created 06edgeCase (+1 new commit): 02http://git.io/GGfVBw [09:18:32] 13Geo/06edgeCase 140e95212 15Thiemo Mättig: Add edge case to GlobeCoordinateParserTest [09:19:18] [13Geo] 15thiemowmde opened pull request #34: Add edge case to GlobeCoordinateParserTest (06master...06edgeCase) 02http://git.io/bR4M-Q [09:44:29] aude: problem is, currently deployed version of property suggester is 1.1.4 but 1.1.5 contains a fix for the new datamodel JS. so things might be broken. [09:46:46] [13Common] 15thiemowmde created 06covers (+1 new commit): 02http://git.io/0cgGsQ [09:46:46] 13Common/06covers 142427a3a 15Thiemo Mättig: Add missing @covers tags [09:48:33] [13Common] 15thiemowmde opened pull request #12: Add missing @covers tags (06master...06covers) 02http://git.io/gSiO1A [09:51:10] 3MediaWiki extensions / 3WikidataRepo: EntityChange in lib depends on EntityContent in repo - 10https://bugzilla.wikimedia.org/73643 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3Wikidata bugs EntityChange::setRevisionInfo uses EntityContent. EntityChangeTest even constructs an ItemContent, which execu... [10:35:05] [13WikibaseDataModel] 15thiemowmde created 06testNamespace (+1 new commit): 02http://git.io/sCm3XA [10:35:05] 13WikibaseDataModel/06testNamespace 1421a7e84 15Thiemo Mättig: Normalize namespaces of all tests [10:36:41] [13WikibaseDataModel] 15thiemowmde opened pull request #299: Normalize namespaces of all tests (06master...06testNamespace) 02http://git.io/d-3ykA [10:37:26] wmde/WikibaseDataModel/testNamespace/21a7e84 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41585191 [10:41:23] 3MediaWiki extensions / 3WikidataClient: Wrong smart keyword on Wikidata - 10https://bugzilla.wikimedia.org/58467#c3 (10Fomafix) There is not bug in Firefox. It converts the s in the form to a query string like in HTML. The reason are the two s. Why are there two s? They seams to be redu... [10:41:24] I'm unable to login to wikidata, can someone else confirm if they are facing the same issue ? [10:42:09] (03PS1) 10Adrian Lang: Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174667 [10:43:25] (03PS1) 10Adrian Lang: Remove static from WikibaseValueFormatterBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 [10:43:26] Tobi_WMDE_SW, Lydia_WMDE: daily hangout? [10:43:27] (03PS1) 10Adrian Lang: Introduce LabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 [10:43:34] k [10:44:04] uwe: will check [10:44:13] Adrian_WMDE: orrr, i also wrote a LabelLookupFactory - it has no tests yet, so i didn't publish the draft... [10:44:20] :P [10:44:52] uwe: works fine here [10:44:52] 3MediaWiki extensions / 3WikidataRepo: Refactor EntityView Instantiation - 10https://bugzilla.wikimedia.org/73264#c3 (10Adrian Lang) I think I started a third approach: https://gerrit.wikimedia.org/r/174669 [10:45:06] DanielK_WMDE: I don't know if yours is as stupid as mine [10:47:21] DanielK_WMDE: in the hangout now [10:47:37] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c33 (10JulesWinnfield-hu) (In reply to Thiemo Mättig from comment #32) I think there is no reason for 3. We can justify only 1 and 2. If the point is to respect what the user enters, then it should be... [10:58:36] DanielK_WMDE: Are you available at some point in time until 4pm? [11:05:29] (03PS2) 10Adrian Lang: Introduce LabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 [11:21:49] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 140c7765a to 14ad9cda8: 02http://git.io/uH6jlQ [11:21:49] 13WikibaseDataModel/06emptyFingerprint 14ad9cda8 15Thiemo Mättig: Allow constructing empty Fingerprint [11:23:34] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 14ad9cda8 to 14a230769: 02http://git.io/uH6jlQ [11:23:34] 13WikibaseDataModel/06emptyFingerprint 14a230769 15Thiemo Mättig: Allow constructing empty Fingerprint [11:36:39] Adrian_WMDE: in 15 min oder so [11:36:49] k [11:36:50] sobald ich die neue version of pageterms hochgeladen habe [11:42:36] (03PS14) 10Daniel Kinzler: Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [11:44:02] Thiemo_WMDE, jzerebecki: please review, the mobile team is waiting for this ---^ [11:44:22] Adrian_WMDE: chat now, or shall i look at your code first? [11:44:29] Look first [11:44:42] [13WikidataBrowserTests] 15tobijat 04force-pushed 06statements_url from 149dfae26 to 14f51ab6b: 02http://git.io/VM8l4w [11:44:42] 13WikidataBrowserTests/06statements_url 14f51ab6b 15Tobias Gritschacher: Add tests for URL type statements [11:47:33] (03CR) 10Daniel Kinzler: "We do want client side editing at some point. Does it make sense to move edit related functionality to the repo now?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [11:47:55] (03CR) 10Daniel Kinzler: [C: 032] Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174667 (owner: 10Adrian Lang) [11:48:20] (03CR) 10jenkins-bot: [V: 04-1] Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [11:48:39] (03CR) 10Adrian Lang: "Yes: JS and PHP view code has to be in the same repo, and we want to do 73020 pretty soon." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [11:49:31] aaaa, label lookup factory :) [11:49:51] Yeah :) [11:50:23] * aude uploading new patch which is kind of similar [11:50:27] but no factory class yet [11:50:37] if it gives any ideas to help you [11:51:33] (03CR) 10Daniel Kinzler: Remove static from WikibaseValueFormatterBuilders (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 (owner: 10Adrian Lang) [11:53:10] (03PS4) 10Aude: Use EntityInfoTermLookup in EntityView classes [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174618 [11:53:13] there ^ [11:53:29] bascially the old patch but adjusted to use the lookup [11:53:31] (03Merged) 10jenkins-bot: Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174667 (owner: 10Adrian Lang) [11:53:50] tests will fail, since it is WIP (and fine with going with one of your patches) [11:54:49] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/20 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174676 [11:56:21] (03CR) 10Daniel Kinzler: [C: 04-1] "I like I9fa6c6baa7eb better :)" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 (owner: 10Adrian Lang) [11:57:44] (03CR) 10jenkins-bot: [V: 04-1] Use EntityInfoTermLookup in EntityView classes [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174618 (owner: 10Aude) [11:57:55] (03CR) 10Daniel Kinzler: "I prefer I3c6ead36f501d; the approach used here causes too many unwarranted dependencies, and seems inflexible." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [11:58:28] (03CR) 10Tobias Gritschacher: "I see no I9fa6c6baa7eb :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 (owner: 10Adrian Lang) [12:00:33] (03CR) 10Daniel Kinzler: Introduce EntityViewFactory and adjust SnakFormatterFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:00:58] (03CR) 10Aude: "this is abuse of formatter options and thus don't like it so much, but shall take close look at this and other patch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [12:01:06] (03Draft2) 10Daniel Kinzler: Extract FormatterLabelLookupFactory [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 [12:01:46] I'll push my inject patch soon [12:01:48] DanielK_WMDE: i would like to abandon or replace https://gerrit.wikimedia.org/r/#/c/172590/ with https://gerrit.wikimedia.org/r/#/c/174618/ [12:01:51] FYI [12:01:57] Tobi_WMDE_SW_NA: try again now. it was a draft, it'S missing tests. [12:02:42] aude: ok, but... that's even more complex... i'll have a look [12:03:12] (03CR) 10Aude: [C: 04-1] "see I2c268d2 instead, attempt to inject and use the EntityInfoTermLookup" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:04:15] DanielK_WMDE: how do you plan for labels to be formatted for properties in claim view and snakhtml? [12:04:32] (03CR) 10Daniel Kinzler: "@aude: I do see it as the lesser evil. It's a deliberate violation of the Gaia Principle (aka Kitchen Sink anti-pattern). I think it's jus" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [12:05:45] (03CR) 10Daniel Kinzler: "oh, and I would be fine with adding special functions or interfaces for injecting services, to keep them distinct from options, but using " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [12:06:29] aude: provide an EntityIdFormatter instead of passing around the entityInfo array. [12:06:56] actually, *replace* the entityInfo param with an propertyIdFormatter param. [12:07:10] also started that somewhere... [12:07:11] (03CR) 10Aude: "think this would be a better approach :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [12:07:24] (03PS2) 10Adrian Lang: Remove static from WikibaseValueFormatterBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 [12:07:26] (03PS3) 10Adrian Lang: Introduce LabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 [12:07:28] (03PS1) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [12:07:32] that's what my patch does [12:07:39] (03CR) 10Adrian Lang: "rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 (owner: 10Adrian Lang) [12:07:44] feel free to borrow ideas from it [12:07:45] aude: then i'm happy with that bit [12:07:53] (03CR) 10Adrian Lang: "rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 (owner: 10Adrian Lang) [12:08:25] Adrian_WMDE: ok, let's chat. I only have an hour left, and still need to write some mails [12:08:52] on other topic, please review https://gerrit.wikimedia.org/r/#/c/174113/ [12:09:03] and i can take a look at PageTerms or other stuff today [12:09:03] I'm not sure we can resolve this remotely [12:09:23] Adrian_WMDE: i leave it to you and daniel [12:10:05] aude: pageters would be great, Dan is really eager to see this in the branch [12:10:13] [13WikibaseDataModel] 15thiemowmde created 06scrutIssues (+1 new commit): 02http://git.io/RHtLGw [12:10:13] 13WikibaseDataModel/06scrutIssues 147c2bcfe 15Thiemo Mättig: Fix some Scrutinizer issues [12:10:37] Adrian_WMDE: we kind of have to. we need the performance boost in the next branch. the current situation is really bad. [12:11:30] Then we should each line up the exact changes we propose (like, list of patch sets to be merged) and let somebody check if they actually fix the situation [12:12:28] Of those that do we can then determine the smaller change [12:12:30] wmde/WikibaseDataModel/scrutIssues/7c2bcfe : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41593360 [12:12:58] I mean, if this is about fixing an issue asap, we shouldn't judge based on coding style :) [12:14:24] the "inject LabelLookup" patch is intended to address the performance issue. I have not verified this yet, though. [12:14:38] [13WikibaseDataModel] 15thiemowmde opened pull request #300: Fix some Scrutinizer issues (06master...06scrutIssues) 02http://git.io/_FUz0A [12:14:45] I don't have a profiling setup, but i can step in and check that we are not hitting the database any more. [12:15:19] * aude eats.... back later [12:15:40] (03CR) 10jenkins-bot: [V: 04-1] Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [12:16:22] DanielK_WMDE: https://gerrit.wikimedia.org/r/174678 should do the same as soon as it passes [12:17:11] The tests pass with hhvm [12:17:14] :D [12:18:18] (03CR) 10Daniel Kinzler: Use EntityInfoTermLookup in EntityView classes [WIP] (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174618 (owner: 10Aude) [12:18:57] jzerebecki, aude: did you see that tonight the dispatch lag went over 2 minutes? do you know if this was something serious or just a fluke? [12:19:11] And the tests pass with PHP 5.6 [12:19:20] (03PS2) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [12:19:28] Let's see if this works better [12:19:46] Lydia_WMDE: the alert i got said that it had no route to the host it uses to look at the dispatch lag [12:20:28] Lydia_WMDE: do we log the dispatch lag somewhere? [12:20:30] ah ok [12:20:36] (03CR) 10Adrian Lang: "Stupid old PHP version :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [12:20:51] we did [12:20:56] let me see if i can find it [12:22:21] (03PS3) 10Adrian Lang: Extract FormatterLabelLookupFactory [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [12:22:31] (03CR) 10jenkins-bot: [V: 04-1] Extract FormatterLabelLookupFactory [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [12:22:45] jzerebecki: can't find it [12:22:57] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06sl from 14c42558b to 1448facd8: 02http://git.io/44ZgmQ [12:22:57] 13WikibaseDataModel/06sl 140c0ea30 15jeroendedauw: Add two more filter methods to StatementList [12:22:57] 13WikibaseDataModel/06sl 1448facd8 15Thiemo Mättig: Avoid in_array [12:23:07] aude: legoktm: do you have the link to the page that tracked the dispatch lag over time? [12:23:42] Lydia_WMDE: they seem to have powered down the whole esams datacenter, which is where the check ends up: 06:27 < bblack> !log ~30m to esams power out, starting equipment shutdown and such for OE13/OE15 [12:23:52] ah [12:23:52] ok [12:24:05] then that's probably it [12:24:16] so nothing to worry about from our side [12:24:51] yup [12:26:24] (03CR) 10Daniel Kinzler: "My problem with this approach is mainly that it spreads knowledge about which services may be overwritten when and where. Wrapping it in a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [12:26:44] Lydia_WMDE: although making sure we send stats like the dispatch lag somehwere to log and graph them, like graphite.w.o would be a good idea [12:26:54] agreed [12:28:32] Adrian_WMDE: my main argument for my approach, as outlined in the commit message, is that it keeps knowledge about overriding services away from most classes. In fact, we could remove the options-based mechansim for this later, without touching much code. Or use it for more services. [12:28:52] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06sl: 02http://git.io/ophwqg [12:28:52] 13WikibaseDataModel/06sl 14ed7c166 15Thiemo Mättig: Remove unsupported call [12:29:10] graphite currently only has archived stats that mention wikidata or wikibase or lag [12:29:56] DanielK_WMDE: The number of classes touched for this is equal in our changes, isn't it? [12:30:14] (03CR) 10Daniel Kinzler: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [12:30:28] If you exclude WikibaseRepo [12:30:40] And WikibaseValueFormatterBuilders [12:32:21] Lydia_WMDE: do we have any other statistics or statuses we have somewhere besides dispatch lag that we should log/graph? [12:32:49] From my point of view this is a very specific issue (having a service later than usual) [12:33:06] And I don't worry about the fix being very specific [12:33:33] I do worry about that, but not that much. [12:33:46] jzerebecki: we have an open bug for some db health indicators. let me look it up [12:33:54] I think we could benefit from this mechanism quite a bit, not just for labels [12:34:08] If we find another service we need to inject late, we should really think about how we do things generally [12:34:30] [13WikibaseDataModel] 15thiemowmde comment on pull request #295 14ed7c166: We have a `BestStatementsFinder` class. Shouldn't this be reused here? If not, should we rename the class to `BestStatementsByPropertyFinder`, if that's what it does? (CC @Benestar)... 02http://git.io/5ibGVg [12:34:57] jzerebecki: https://bugzilla.wikimedia.org/show_bug.cgi?id=45533 and https://bugzilla.wikimedia.org/show_bug.cgi?id=66025 [12:35:12] 3MediaWiki extensions / 3WikidataRepo: Add monitoring interface to wikibase - 10https://bugzilla.wikimedia.org/45533 (10Lydia Pintscher) [12:35:12] 3Wikimedia / 3Wikidata: monitor size of some database tables - 10https://bugzilla.wikimedia.org/66025 (10Lydia Pintscher) [12:35:14] 3Wikimedia / 3Wikidata: make sure dispatch lag gets logged/graphed somewhere - 10https://bugzilla.wikimedia.org/73647 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Make sure dispatch lag gets logged/graphed somewhere. Like graphite.wikimedia.org . [12:35:22] Adrian_WMDE: i don't think that indicates a problem, really. It's a classic case of DI conflicting with lazy loading (resp with prefetching) [12:36:03] abstraction, by definition, hides information. to re-use information, we have to break abstraction to a degree [12:36:06] oh, whatever [12:36:46] Adrian_WMDE: i'd do some follow-ups now, get my patches up to date. is there still anything urgent to discuss? [12:37:14] DanielK_WMDE: I don't know; I guess we know where we stand [12:38:10] 3MediaWiki extensions / 3WikidataRepo: Add monitoring interface to wikibase - 10https://bugzilla.wikimedia.org/45533#c3 (10Jan Zerebecki) Also make sure that if it makes sense this information is also logged/graphed somehwere, e.g. graphite.wikimedia.org . [12:38:10] 3Wikimedia / 3Wikidata: make sure dispatch lag gets logged/graphed somewhere - 10https://bugzilla.wikimedia.org/73647 (10Jan Zerebecki) [12:38:12] at three solutions, and no agreement ;) [12:38:24] maybe we can figure it out tomorrow. [12:38:59] From my point of view, my three changes improve code quality except for WikibaseRepo and EntityViewFactory, where we need ugly code to solve a problem we don't have a pretty solution for yet. [12:39:07] I'm not working tomorrow :P [12:40:10] And I can't say the same about the other approaches [12:45:23] 3MediaWiki extensions / 3WikidataClient: Wrong smart keyword on Wikidata - 10https://bugzilla.wikimedia.org/58467#c4 (10Thiemo Mättig) Turning an unnamed input into index.php?=%s is clearly a bug in Firefox. I'm not aware of a server side language that supports unnames GET variables. In PHP that would be $_G... [12:49:45] (03CR) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [12:49:53] (03CR) 10Adrian Lang: Remove static from WikibaseValueFormatterBuilders (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 (owner: 10Adrian Lang) [12:50:04] (03PS3) 10Adrian Lang: Remove static from WikibaseValueFormatterBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 [12:50:06] (03PS4) 10Adrian Lang: Introduce LabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 [12:50:08] (03PS3) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [12:50:10] (03CR) 10Adrian Lang: Introduce LabelLookupFactory (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 (owner: 10Adrian Lang) [12:53:35] (03CR) 10Adrian Lang: Extract FormatterLabelLookupFactory [WIP] (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [12:56:43] (03CR) 10Adrian Lang: "I dislike using options (as we all do), and I think Iea8191e88a19113eba929e6bb9b74081384ba46d is a viable alternative to doing this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [13:02:11] 3MediaWiki extensions / 3WikidataRepo: "Uncaught TypeError: Cannot call method 'click' of undefined" when "Edit pages on double click" is enabled - 10https://bugzilla.wikimedia.org/57713#c5 (10Thiemo Mättig) (In reply to Helder from comment #3) > all non-Wikidata pages have a "ca-edit" link The code is in c... [13:06:03] Lydia_WMDE: when is the meeting? [13:06:37] 3MediaWiki extensions / 3WikidataRepo: Introduce factory for JS views - 10https://bugzilla.wikimedia.org/73380 (10Lydia Pintscher) [13:06:52] 3MediaWiki extensions / 3WikidataRepo: Unable to "Edit pages on double click": Uncaught TypeError: Cannot call method 'click' of undefined - 10https://bugzilla.wikimedia.org/57713#c6 (10Helder) Just to clarify: the feature should work (not just not trow an error). When the user double click in a field, it sh... [13:09:07] aude: We are only talking about UI stuff currently [13:09:36] aude: Lydia_WMDE says we are not going to talk about anything else [13:09:49] ok, great [13:10:02] * aude doesn't have a good place to do hangout right now [13:10:13] so just email if there is anything important to know [13:10:35] Ok :) [13:13:13] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [13:14:52] (03CR) 10Adrian Lang: "This fixes an actual (although trivial) bug :) Please review." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 (owner: 10Adrian Lang) [13:15:54] (03CR) 10Adrian Lang: Move sites-related methods from wikibase to wikibase.sites (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [13:18:49] (03Merged) 10jenkins-bot: Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [13:20:37] (03CR) 10Adrian Lang: Inject RepoApi and config in linkitem (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144446 (owner: 10Adrian Lang) [13:26:52] 3MediaWiki extensions / 3WikidataRepo: Unable to "Edit pages on double click": Uncaught TypeError: Cannot call method 'click' of undefined - 10https://bugzilla.wikimedia.org/57713#c7 (10Thiemo Mättig) (In reply to Helder from comment #6) > When > the user double click in a field, it should enter in edit mode... [13:33:07] 3MediaWiki extensions / 3WikidataRepo: Unable to "Edit pages on double click": Uncaught TypeError: Cannot call method 'click' of undefined - 10https://bugzilla.wikimedia.org/57713 (10Helder) [13:33:11] 3MediaWiki extensions / 3WikidataRepo: Unable to "Edit pages on double click" on Wikidata - 10https://bugzilla.wikimedia.org/73649 (10Helder) 3NEW p:3Unprio s:3normal a:3Wikidata bugs From the other bug: the feature should work (not just not trow an error). When the user double click in a field, it s... [14:02:48] Hello all, let's say I'd like to get all items on wikidata where P569 (birthdate) has a specific value, what would be the sql query ? I can't figure it out :( [14:05:31] is there a direct sql access? [14:07:03] Shmias: symac: That's not possible via SQL [14:07:28] You might want to have a look at https://wdq.wmflabs.org/ though [14:08:07] Shmias : yes I have a direct access through toollabs [14:09:01] hoo, I was thinking it should be easier to do direct queries to sql, but I should use wdq too. But if it's not possible using SQL do you know how WDQ does ?? [14:09:06] That data is not accessible via SQL [14:09:22] WDQ uses an own storage for querying [14:12:30] ok, thanks for the info, will use WDQ then (I should have asked earlier, would have not lost an hour !) [14:13:08] (03PS1) 10Adrian Lang: Move wikibase.experts from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174689 [14:15:36] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/11/20 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174676 (owner: 10Tobias Gritschacher) [14:17:48] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/11/20 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174676 (owner: 10Tobias Gritschacher) [14:21:47] :) [14:22:40] 3MediaWiki extensions / 3WikidataRepo: Research usage of different skins in Wikidata community - 10https://bugzilla.wikimedia.org/73651 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs What skin is used most? How much is monobook/vector used? By which users (readers, editors, highly-... [14:22:41] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=73651 [14:22:52] aude: Adrian_WMDE is about to move some messages from the lib message file to the repo message file in wikibase.git. that shouldn't cause issues right? [14:23:29] Lydia_WMDE: Don't change message keys [14:23:33] only move en message [14:23:35] then it's fine [14:23:43] * messages [14:23:45] Cool [14:23:51] the rest will be handled by the l10n bot [14:23:52] 3MediaWiki extensions / 3WikidataRepo: Research usage of different skins in Wikidata community - 10https://bugzilla.wikimedia.org/73651#c1 (10Lydia Pintscher) Let's limit this to people active in the last 2 months. [14:29:39] (03PS1) 10Adrian Lang: Move wikibase.css and jquery.wikibase from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 [14:32:56] 3MediaWiki extensions / 3WikidataRepo: Research usage of different skins in Wikidata community - 10https://bugzilla.wikimedia.org/73651 (10tobias.gritschacher) p:5Unprio>3Normal [14:32:57] 3MediaWiki extensions / 3WikidataRepo: Research how we can maximize compatibility of a new Wikibase skin with Vector (and Monobook) - 10https://bugzilla.wikimedia.org/73652 (10tobias.gritschacher) p:5Unprio>3Normal [14:32:59] (03CR) 10Adrian Lang: [C: 04-1] "Merge immediately before doing the split" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [14:35:54] 3MediaWiki extensions / 3WikidataRepo: Implement new Wikibase Skin - 10https://bugzilla.wikimedia.org/73653 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs (probably) based on Vector [14:36:08] 3MediaWiki extensions / 3WikidataRepo: Implement new Wikibase Skin - 10https://bugzilla.wikimedia.org/73653 (10tobias.gritschacher) p:5Unprio>3Normal [14:37:55] 3MediaWiki extensions / 3WikidataRepo: Implement new Wikibase Skin - 10https://bugzilla.wikimedia.org/73653 (10tobias.gritschacher) [14:37:55] 3MediaWiki extensions / 3WikidataRepo: Research how we can maximize compatibility of a new Wikibase skin with Vector (and Monobook) - 10https://bugzilla.wikimedia.org/73652 (10tobias.gritschacher) [14:40:55] 3MediaWiki extensions / 3WikidataRepo: UI: Rename existing fingerprint* widgets - 10https://bugzilla.wikimedia.org/73655 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Their naming would not make much sense in the context of a "header-wide" fingerprint-view. [14:41:23] 3MediaWiki extensions / 3WikidataRepo: UI: Redesign header - 10https://bugzilla.wikimedia.org/73654 (10tobias.gritschacher) p:5Unprio>3Normal [14:41:54] 3MediaWiki extensions / 3WikidataRepo: UI: Rename existing fingerprint* widgets - 10https://bugzilla.wikimedia.org/73655 (10tobias.gritschacher) p:5Unprio>3Normal [14:41:55] 3MediaWiki extensions / 3WikidataRepo: UI: Redesign header - 10https://bugzilla.wikimedia.org/73654 (10tobias.gritschacher) [14:43:08] 3MediaWiki extensions / 3WikidataRepo: UI: Create new fingerprint-widget to replace header and current fingerprintlist widgets - 10https://bugzilla.wikimedia.org/73656 (10tobias.gritschacher) p:5Unprio>3Normal [14:43:25] 3MediaWiki extensions / 3WikidataRepo: UI: Redesign header - 10https://bugzilla.wikimedia.org/73654 (10tobias.gritschacher) [14:44:39] 3MediaWiki extensions / 3WikidataRepo: UI: Adjust non JS view to new fingerprint/header widget - 10https://bugzilla.wikimedia.org/73657 (10tobias.gritschacher) p:5Unprio>3Normal [14:44:39] 3MediaWiki extensions / 3WikidataRepo: UI: Redesign header - 10https://bugzilla.wikimedia.org/73654 (10tobias.gritschacher) [14:46:44] (03PS1) 10Adrian Lang: Move some messages to client or repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174693 [16:27:57] Hi [16:32:31] (03PS1) 10Aude: Add test coverage for property id formatting in ClaimsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174710 [16:34:44] (03PS1) 10Aude: Remove unused ClaimsView::getSnaksFromClaims method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174712 [16:41:30] (03CR) 10jenkins-bot: [V: 04-1] Add test coverage for property id formatting in ClaimsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174710 (owner: 10Aude) [16:47:11] (03PS2) 10Aude: Add test coverage for property id formatting in ClaimsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174710 [17:00:06] (03PS1) 10Henning Snater: Implemented sticky notification for site link sections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174719 [17:03:40] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419#c1 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/174719/ [17:10:31] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06scrutIssues from 147c2bcfe to 1408f9d52: 02http://git.io/n-iwKw [17:10:31] 13WikibaseDataModel/06scrutIssues 1408f9d52 15Thiemo Mättig: Fix some Scrutinizer issues [17:28:40] wmde/WikibaseDataModel/scrutIssues/08f9d52 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41623054 [17:49:37] 3MediaWiki extensions / 3WikidataClient: login issue with add language links widget - 10https://bugzilla.wikimedia.org/48389#c14 (10Tristan Miller) I'm still experiencing the problem. If it's been established definitively that this is due to the user's browser blocking third-party cookies, could a message t... [17:51:10] So....redirect or delete after merge? [17:52:15] Redirect imo [17:53:37] I don't like redirects on wikidata (personal opinion), so I already requested deletion. But how is the RfC going? I have not read it... [17:53:39] agree [17:53:50] [13DataValues] 15thiemowmde created 06equals (+1 new commit): 02http://git.io/2vgsDw [17:53:50] 13DataValues/06equals 14614458c 15Thiemo Mättig: Reworked all equals methods [17:55:15] [13DataValues] 15thiemowmde opened pull request #12: Reworked all equals methods (06master...06equals) 02http://git.io/nGzSPg [18:02:30] [13Number] 15thiemowmde created 06equals (+1 new commit): 02http://git.io/Hrx85g [18:02:30] 13Number/06equals 14260ed58 15Thiemo Mättig: Reworked all equals methods [18:03:16] (03CR) 10Anomie: [C: 04-1] Introduce PageTerms API module (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [18:04:43] [13Number] 15thiemowmde opened pull request #12: Reworked all equals methods (06master...06equals) 02http://git.io/y33QoA [18:16:36] [13WikibaseDataModel] 15thiemowmde comment on pull request #280 1428e612a: Use what instead? 02http://git.io/VgAZmA [18:17:15] (03PS6) 10Aude: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [18:18:39] (03CR) 10Aude: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [18:19:02] [13WikibaseDataModel] 15thiemowmde comment on pull request #280 1428e612a: The default implementation in `Entity` throws an exception. What code still calls this? 02http://git.io/xTD55w [18:23:49] [13WikidataBuildResources] 15filbertkm created 06suggester (+1 new commit): 02http://git.io/jOHzng [18:23:49] 13WikidataBuildResources/06suggester 1487b6ed4 15aude: Update property suggester to 2.0.1 [18:23:59] [13WikidataBuildResources] 15filbertkm opened pull request #12: Update property suggester to 2.0.1 (06master...06suggester) 02http://git.io/t2ES5Q [18:26:26] (03PS1) 10Aude: Factor out property link formatting from view code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174750 [18:31:14] (03PS1) 10Aude: New Wikidata Build - 2014/11/20 (update property suggester) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174756 [18:33:24] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2014/11/20 (update property suggester) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174756 (owner: 10Aude) [18:39:08] (03CR) 10jenkins-bot: [V: 04-1] Factor out property link formatting from view code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174750 (owner: 10Aude) [18:42:44] (03PS2) 10Aude: Factor out property link formatting from view code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174750 [18:44:59] (03PS2) 10Aude: New Wikidata Build - 2014/11/20 (update property suggester) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174756 [18:47:13] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2014/11/20 (update property suggester) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174756 (owner: 10Aude) [18:48:53] 3MediaWiki extensions / 3WikidataRepo: Do not load full entities when invoking LinkBegin hook - 10https://bugzilla.wikimedia.org/70767#c1 (10Aude) part of the solution to this is to avoid using Linker whenever possible. We are currently using Linker to format property id links in ClaimsView and SnakHtmlGene... [18:49:32] 3MediaWiki extensions / 3WikidataRepo: Do not load full entities when invoking LinkBegin hook - 10https://bugzilla.wikimedia.org/70767#c2 (10Aude) by not using Linker, we don't encounter this hook. [18:55:44] (03PS3) 10Aude: New Wikidata Build - 2014/11/20 (update property suggester) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174756 [19:09:18] Josve05a: the whole point of redirects is so that we have stable identifiers. deleting items that are merged into others because they are the same defetes the whole point of wikidata being a reliable source for stable identifiers :( [19:09:50] oh [19:09:58] and having stable identifiers is super important for 3rd party use like for the gene mapping that we posted about on the wmde blog [19:10:39] I see your point, but I still don't like them...so "ugly"..or something [19:10:47] heh that's fair enough [19:10:53] ugly things are important too sometimes ;-) [19:11:43] true [19:12:47] Am I folloing you on twitter Lydia_WMDE ? [19:13:10] Josve05a: i don't know ;-) i am nightrose there [19:13:15] and wikidata is wikidata [19:13:43] Wikidata I'm already folloing and...now I'm following you too [19:13:48] following* [19:13:49] :) [19:18:36] Lydia_WMDE: when are office hours or did i miss them? [19:19:18] aude: in 10 mins [19:19:29] for structured data [19:19:34] in #wikimedia-office [19:19:56] the one for wikidata is on dec 3rd [19:20:32] yay! [19:20:50] dec 3, probably can't attend unless it is early enough [19:28:46] (03PS1) 10Thiemo Mättig (WMDE): Phase out hasClaim and newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 [19:30:13] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06propertyClaims: 02http://git.io/CNRB6A [19:30:14] 13WikibaseDataModel/06propertyClaims 146e55da4 15thiemowmde: Use isEmpty [19:37:02] [13WikibaseDataModel] 15thiemowmde created 06oddTest (+1 new commit): 02http://git.io/sN2qAA [19:37:02] 13WikibaseDataModel/06oddTest 149713f2d 15Thiemo Mättig: Drop odd Entity test [19:37:21] (03CR) 10Aude: [C: 032] New Wikidata Build - 2014/11/20 (update property suggester) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174756 (owner: 10Aude) [19:39:25] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/11/20 (update property suggester) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174756 (owner: 10Aude) [19:41:34] Lydia_WMDE: I'm going to kill someone at my internet provider tomorrow [19:41:51] multichill: awww [19:41:54] [13WikibaseDataModel] 15thiemowmde opened pull request #302: Drop odd Entity test (06master...06oddTest) 02http://git.io/39hu4w [19:41:54] only kick them [19:41:56] not kill [19:41:57] ;-) [19:42:19] Or just kill their upstream :@ [19:44:48] wmde/WikibaseDataModel/oddTest/9713f2d : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41636725 [19:49:00] [13WikidataBuildResources] 15filbertkm created 06cachekey (+1 new commit): 02http://git.io/smMB6w [19:49:00] 13WikidataBuildResources/06cachekey 14db6aae8 15aude: Improve/fix sharedCacheKeyPrefix generation [19:49:15] [13WikidataBuildResources] 15filbertkm opened pull request #13: Improve/fix sharedCacheKeyPrefix generation (06master...06cachekey) 02http://git.io/dZAHyg [20:30:47] Thiemo_WMDE: jshitn doesn't like minified code. Write it out as an if-statement. [20:36:30] hello, is their an identifer called movie ? [20:37:05] for example if there is an item about a movie, and i want to link it to the full film in commons, is there a way to do so ? [20:41:03] There is a thing like "media file on commons" [20:41:22] P10 [20:43:25] that you sjoerddebruin [20:45:32] * thank [20:50:13] (03CR) 10Kaldari: [C: 04-1] Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [20:54:29] (03CR) 10Anomie: Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [20:56:57] (03PS1) 10Aude: Update Wikidata (property suggester) [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174800 [21:01:37] 3MediaWiki extensions / 3WikidataClient: Add Wikibase API module that is usable from client wikis and available as a generator & prop module - 10https://bugzilla.wikimedia.org/72729#c10 (10Nemo) As Kaldari noted, "PageTerms" is not self-explanatory. My first thought was it would contain per-page legal terms... [21:03:23] (03CR) 10Aude: [C: 032] "already tried on beta, looks good" [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174800 (owner: 10Aude) [21:05:24] (03Merged) 10jenkins-bot: Update Wikidata (property suggester) [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174800 (owner: 10Aude) [21:08:42] aude: when you have 2 minutes could you have a look at https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Stars_for_recommended_articles.3F ? it seems we missed that at some point [21:08:56] what? [21:08:57] ok [21:09:21] thx! [21:11:24] Lydia_WMDE: i see the issue. probably can deploy monday or tuesday, if that is good [21:11:36] aude: fine with me :) [21:11:40] aude: should i tell him? [21:12:07] ok [21:12:25] will do [21:35:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move wikibase.experts from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174689 (owner: 10Adrian Lang) [21:36:18] Lydia_WMDE: sjoerddebruin updated the suggester [21:36:33] I did nothing. [21:36:36] :D [21:36:38] haha [21:36:42] thanks aude :) [21:36:43] :) [21:36:52] sjoerddebruin: thanks for doing nothing as well ;-) [21:36:54] sjoerddebruin: updated the suggester :) [21:37:12] looks fine to me [21:38:25] wow, that geonames-property... [21:38:37] ? [21:38:42] hoo: Lydia_WMDE want to merge https://github.com/wmde/WikidataBuildResources/pull/12 ? [21:38:49] so it doesn't get reverted on beta [21:38:57] next build [21:39:00] Lydia_WMDE: https://www.wikidata.org/wiki/Property:P1566 [21:39:08] yay :D [21:39:12] It's pretty new and almost default in place-items. [21:39:12] aude: Now that it's live, that sounds fine with me :) [21:39:15] [13WikidataBuildResources] 15mariushoch 04deleted 06suggester at 1487b6ed4: 02http://git.io/gkFEJA [21:39:27] tried it all locally and on beta first (of course) [21:39:48] sjoerddebruin: what's wrong with it? [21:39:57] Nothing. [21:40:03] heh [21:40:03] ok [21:40:07] * aude back in ~30 min [21:40:13] laters aude [21:40:26] I'm looking for persons without first names to see if it shows up in the suggester [21:41:13] the suggestions on my item look much better now [21:41:30] * Lydia_WMDE tries some more [21:41:36] uhuh [21:41:39] bad gateway [21:41:53] Yes, I need to look at some graves because the Commonscat and image property don't showed up there. [21:41:54] who broke the wiki!!!!1111eleven? :D [21:42:00] ah [21:42:02] back [21:42:04] puh [21:42:13] On Wikidata? [21:42:18] yeah [21:42:46] ok wikimedia germany still has bad suggestions [21:42:49] esams is probably still offline [21:43:02] Lydia_WMDE: :D Read that again [21:43:11] ;-) [21:43:17] the item! [21:43:25] pavel is fine [21:44:57] Ah, here it is: https://www.wikidata.org/wiki/Q4475251 [21:45:02] First name in the suggester <3 [21:45:09] \o/ [21:45:19] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move some messages to client or repo (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174693 (owner: 10Adrian Lang) [21:45:23] So, let's pick a grave. [21:45:44] Yeah, Commonscat and image is back. <3 [21:45:49] <3 [21:46:01] ok overall this is a win then :) [21:46:38] Mhm, now it wants the gender of the grave site. [21:47:01] heh ok... [21:47:11] still way to improve [21:47:23] Yeah, by adding more relevant properties. [21:47:32] We need units. <3 [21:47:57] ack [21:48:14] talking to a student atm who will hopefully join us and do it [21:52:05] (03CR) 10Thiemo Mättig (WMDE): "Just a question, not enough for a vote." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173281 (owner: 10Henning Snater) [21:52:21] :D The entity suggester doesn't want me to add number of deaths to a cycle match anymore. :D [21:52:37] awwwwwww [21:52:38] :P [22:03:05] (03Merged) 10jenkins-bot: Move wikibase.experts from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174689 (owner: 10Adrian Lang) [22:03:07] (03Merged) 10jenkins-bot: Move some messages to client or repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174693 (owner: 10Adrian Lang) [22:21:31] aude: Back? [22:29:10] (03PS1) 10Thiemo Mättig (WMDE): Rework and drop unused code from EditEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174836 [22:32:12] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Not that there is something wrong with your implementation. It's more a question of style and personal preference (and the existing code i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174283 (https://bugzilla.wikimedia.org/73562) (owner: 10Legoktm) [22:35:51] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06cachekey: 02http://git.io/elwQ6Q [22:35:51] 13WikidataBuildResources/06cachekey 1414e5698 15aude: Check if composer config has autoloader-prefix [22:36:38] hoo: back [22:37:26] aude: ah :) [22:37:50] Do you think it's safe to deploy UpdateRepoOnDelete with the normal deploys?? [22:38:01] It will break apart if it's on a client before it's on the repo [22:38:48] aude: ^ [22:42:33] hoo: I made a bot script, now what should I do? Try get it used by wm-bot? [22:43:40] w930913: What kind of bot script? [22:44:25] hoo: Takes an argument string and translates it into useful stuff :p [22:44:44] Such as "Q42" -> "(Q42 -> Douglas Adams)" [22:45:04] hehe [22:45:12] Not sure that's wanted in this channel, but nice [22:45:23] I wanted to ahve that as an HexChat plug in [22:45:33] hoo: Or "Q42 P26" -> "(Q76 -> Barack Obama) (wife -> P26 -> Q13133 -> Michelle Obama)" [22:45:42] Er, "Q42 wife"* [22:46:17] Er, "Q76 wife"* [22:46:21] * w930913 trouts himself. [22:47:16] :D [22:47:31] Barack Obama -> wife [22:47:35] that would be a nice syntax [22:47:41] more of a playground thing, then [22:47:46] but still, I'd like it [22:49:34] JeroenDeDauw: http://9gag.com/gag/aqZ6ZAZ [22:50:02] (03PS3) 10Thiemo Mättig (WMDE): Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [22:50:07] hoo: "Barack Obama" -> "(Barack Obama -> Q13202704 | Q76)" [22:50:23] 3MediaWiki extensions / 3WikidataClient: Wrong smart keyword on Wikidata - 10https://bugzilla.wikimedia.org/58467#c5 (10Fomafix) Ok, an without name is ignored in the normal transformation from a
to a query string. Here has the for which the smart keyword is requested no name. When thi... [22:50:34] hoo: Because it returns multiple items, it can't be used further. [22:50:45] w930913: Right... forgot about that [22:51:04] So two queries for now. [22:51:38] Though could in theory add "Barack Obama 2" = "Q76" [22:56:04] (03PS1) 10Thiemo Mättig (WMDE): Remove unused use clauses and fix typo in a class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174842 [23:00:25] [13Number] 15thiemowmde created 06optUses (+1 new commit): 02http://git.io/7y62iQ [23:00:25] 13Number/06optUses 148c32c30 15Thiemo Mättig: Optimize all use clauses [23:00:40] [13Number] 15thiemowmde opened pull request #13: Optimize all use clauses (06master...06optUses) 02http://git.io/-J_Efw [23:03:28] [13WikibaseDataModelSerialization] 15thiemowmde created 06optimize2 (+1 new commit): 02http://git.io/r_IQ5w [23:03:28] 13WikibaseDataModelSerialization/06optimize2 14eb282e2 15Thiemo Mättig: Fix test method visibility [23:04:03] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #99: Fix test method visibility (06master...06optimize2) 02http://git.io/8aztHA [23:04:42] hoo: back (for a minute or so) [23:04:51] wmde/WikibaseDataModelSerialization/optimize2/eb282e2 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/41658961 [23:05:05] i am not sure and would want to manually verify if/how the job works in that case [23:05:18] else have a strategy for deploying it [23:05:36] aude: Yeah... someone would need to be around and watch closely [23:05:41] [13WikibaseDataModel] 15thiemowmde created 06optimize (+1 new commit): 02http://git.io/wLA-9g [23:05:41] 13WikibaseDataModel/06optimize 140d614bc 15Thiemo Mättig: Optimize imports [23:05:51] [13WikibaseDataModel] 15thiemowmde opened pull request #303: Optimize imports (06master...06optimize) 02http://git.io/hgZK2w [23:05:55] Also the log group changed, so a configuration change for that would be nice [23:06:02] (so that we can keep collecting logs) [23:08:01] :/ [23:08:08] aude: If we branch next week, that deploy would be the Tuesday the week after [23:08:14] i wont' be around if we deploy on dec 3 to wikipedias [23:08:16] thus, I wont be around [23:08:24] suppose i am around on tuesday [23:08:30] if i don't oversleep [23:08:53] Ok... but still someone needs to be around on Wednesday [23:08:56] not sure I can [23:08:58] yes [23:09:06] need to check with lydia and tobi [23:09:13] * aude away.... eat [23:09:20] ok [23:10:37] wmde/WikibaseDataModel/optimize/0d614bc : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41659177 [23:17:51] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Ok. Just a suggestion that can be done in the same patch, if you like, or in a following one. Please tell me what you prefer." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [23:20:40] hoo: nice [23:27:13] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06oddTest at 149713f2d: 02http://git.io/a3W7Dg [23:29:40] (03PS1) 10Thiemo Mättig (WMDE): Small clean ups in Changes related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174848 [23:32:09] hoo: Broke it out into a cgi for you, if you want to wrap it into your plugin. https://tools.wmflabs.org/cluestuff/wd/query.cgi?q=Q42%20wife%20%22died%20on%22 [23:32:35] Could also give you the python if you wanted, but then you got to do the imports and you won't get updates. [23:38:01] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Hm, now this "small" patch grew even more, but I think it's ok. Still to much to backport in my opinion. Would like to have a second look," (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [23:39:29] (03CR) 10Aude: Lazy initialize OtherProjectsSidebarGenerator in hook handlers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [23:47:05] [13WikidataBuildResources] 15thiemowmde comment on pull request #13 1414e5698: Wait, where does this variable come from? ;-) It's to late. I'm going to bed now. What about you? 02http://git.io/H0fptQ [23:50:33] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06cachekey: 02http://git.io/xl-V6g [23:50:33] 13WikidataBuildResources/06cachekey 14213a79e 15Katie Filbert: Fix getter for autoloader suffix [23:52:03] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #295 14ed7c166: This method is replacing an equivalent, though less nice and less efficiently implemented, in WB.git. Using `BestStatementsFinder` was not practical there.... 02http://git.io/L30qWA [23:53:26] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #295 14ed7c166: If you are really upset about the loop, you can always refactor the code to avoid this. You'll have some small amount duplication and additional complexity then though. I personally do not think this is worthwhile. 02http://git.io/egNezw