[00:44:35] 3MediaWiki-extensions-WikidataRepo: Use terms-lookup service in EntityID formatters - https://phabricator.wikimedia.org/T74036#786799 (10Liuxinyu970226) [00:56:05] msg- ajr Are you Ajraddatz?? [00:56:16] Fenerli1978_, yes [00:58:20] Can you all of pages in turkish Wikipedia what is made it https://tr.wikipedia.org/wiki/%C3%96zel:Katk%C4%B1lar/K%C4%B1r%C4%B1m_alkoll%C3%BC tihs user please [00:59:06] Because allof them vandalism include my user and message page [00:59:09] I can't, sorry... my translation thing interferes with reverting and it deletes the page when I do. I'd prefer to have local admins do the cleanup [00:59:21] I guess I could if there still weren't any around [01:00:10] Ok thanks we have to wait our admins. Thank you for blocking at least [01:03:10] Fenerli1978_, all cleaned up [01:04:13] Fenerli1978_, is there a page where I can contact trwiki admins? [01:06:42] I think now everyone is sleeping but you can find this list all of admins https://tr.wikipedia.org/wiki/Vikipedi:Hizmetliler#Hizmetliler_listesi [01:10:14] Can you move my message page also vandal page is https://tr.wikipedia.org/w/index.php?title=Kullan%C4%B1c%C4%B1_mesaj:%D0%A5%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%A3%D0%99%D0%99%D0%99&redirect=no [01:10:32] my original page is https://tr.wikipedia.org/wiki/Kullan%C4%B1c%C4%B1_mesaj:Fenerli1978 [01:23:22] kk [01:24:11] Fenerli1978_, done [01:26:46] Thank you so much [03:38:24] Did somebody break gerrit? Is it auto-buglinking? [03:38:36] https://gerrit.wikimedia.org/r/#/c/175774/ [07:42:07] open [07:42:12] I do not know WHAT causes it, but Widar is failing badly and it is probably the most important operational bug [07:42:31] operational because its effects are massive [07:42:53] I mailed Magnus and Lydia about this [08:09:02] no comments, no acknowledgement .... :( [08:16:52] (03PS3) 10Adrian Lang: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [08:24:56] (03CR) 10Adrian Lang: Move wikibase.css and jquery.wikibase from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [08:26:19] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [08:29:13] (03PS3) 10Adrian Lang: Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 [08:29:15] (03PS6) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [08:29:17] (03PS1) 10Adrian Lang: Pass TermLookup, not EntityLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175959 [08:30:30] (03PS2) 10Adrian Lang: Move wikibase.css and jquery.wikibase from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 [08:30:43] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [08:33:33] GerardM-: ack. [08:35:13] GerardM-: I'm almost never using it, but I just tried and it seems I cannot edit anything.. is that what you mean? I also don't see any errors, so I have no clue what's going on. Magnus might know best. [08:35:23] probably he has to look into the logs [08:36:17] (03PS5) 10Thiemo Mättig (WMDE): Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [08:38:38] Tobi_WMDE_SW_NA: the issue is apparently having hhvm and non-hhvm servers in production. i will reply to gerard's email [08:47:15] (03Abandoned) 10Adrian Lang: Introduce LabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174669 (owner: 10Adrian Lang) [09:00:04] (03CR) 10jenkins-bot: [V: 04-1] Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 (owner: 10Adrian Lang) [09:01:42] (03CR) 10jenkins-bot: [V: 04-1] Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [09:02:45] (03CR) 10jenkins-bot: [V: 04-1] Pass TermLookup, not EntityLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175959 (owner: 10Adrian Lang) [09:08:48] (03PS2) 10Adrian Lang: Pass TermLookup, not EntityLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175959 [09:54:08] (03CR) 10Daniel Kinzler: [C: 032] Pass TermLookup, not EntityLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175959 (owner: 10Adrian Lang) [09:54:15] (03PS7) 10Daniel Kinzler: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [09:55:11] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/26 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/175967 [09:56:28] (03PS1) 10Thiemo Mättig (WMDE): Rework and clean up MockRepository and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175968 [10:00:00] (03CR) 10Tobias Gritschacher: [C: 032] Improve variable naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175765 (owner: 10Jeroen De Dauw) [10:01:50] (03CR) 10Hoo man: Inject LabelLookup got use by Formatters. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [10:02:06] (03PS2) 10Thiemo Mättig (WMDE): Rework and clean up MockRepository and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175968 [10:02:08] (03PS2) 10Thiemo Mättig (WMDE): Make stuff in CachingEntityRevisionLookup private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175823 [10:03:56] 3MediaWiki-extensions-WikidataClient: Add Wikibase API module that is usable from client wikis and available as a generator & prop module - https://phabricator.wikimedia.org/T74729#787652 (10Tobi_WMDE_SW) [10:05:32] hoo: https://phabricator.wikimedia.org/T74729 <- this? [10:17:24] (03PS2) 10Thiemo Mättig (WMDE): Rename dataTypes to dataTypeStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 [10:17:52] (03Merged) 10jenkins-bot: Pass TermLookup, not EntityLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175959 (owner: 10Adrian Lang) [10:18:58] 3MediaWiki-extensions-WikidataRepo: Coordinates shown as 0°0'NFF"N, 0°0'NFF"E caused by php warning: division by zero in GeoCoordinateFormatter - https://phabricator.wikimedia.org/T75601#787664 (10hoo) [10:20:36] (03PS4) 10Daniel Kinzler: Inject LabelLookup got use by Formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 [10:20:47] (03CR) 10jenkins-bot: [V: 04-1] Inject LabelLookup got use by Formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [10:21:43] (03PS4) 10Adrian Lang: Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 [10:22:44] (03PS4) 10Thiemo Mättig (WMDE): Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [10:23:57] 3MediaWiki-extensions-WikidataRepo: Overlapping text in wb-section-heading - https://phabricator.wikimedia.org/T73514#787671 (10Sjoerddebruin) Any update on this? This is still happening. [10:25:19] (03CR) 10jenkins-bot: [V: 04-1] Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [10:26:13] (03CR) 10Thiemo Mättig (WMDE): "Addshore, this is nothing new. We are doing this exactly like that for two years now. There are dozens of usages of these classes with the" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [10:27:37] http://wikidata.beta.wmflabs.org/ [10:27:43] it even works [10:28:54] (03Merged) 10jenkins-bot: Improve variable naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175765 (owner: 10Jeroen De Dauw) [10:29:07] (03PS7) 10Thiemo Mättig (WMDE): More consistent variable naming, e.g. $languageCode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 [10:31:34] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up MockRepository and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175968 (owner: 10Thiemo Mättig (WMDE)) [10:33:08] 3MediaWiki-extensions-WikidataRepo: Overlapping text in wb-section-heading - https://phabricator.wikimedia.org/T73514#787687 (10Lydia_Pintscher) Henning is re-working the whole thing at the moment for the move into the sidebar. That should fix this. [10:38:09] (03CR) 10jenkins-bot: [V: 04-1] Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [10:40:40] (03PS5) 10Daniel Kinzler: Inject LabelLookup got use by Formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 [10:45:01] DanielK_WMDE__: https://phabricator.wikimedia.org/T74348 [10:48:36] https://phabricator.wikimedia.org/T74478 [10:54:08] (03CR) 10Adrian Lang: "How about passing the TermLookup in options?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [11:08:34] 3MediaWiki-extensions-WikidataRepo: JavaScript Documentation: ValueView - https://phabricator.wikimedia.org/T75987#787725 (10Tobi_WMDE_SW) [11:08:47] (03PS4) 10Thiemo Mättig (WMDE): Narrow EntityParserOutputGeneratorFactory interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 [11:12:10] (03PS3) 10Adrian Lang: Remove assumption that all entities have a fingerprint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175766 (owner: 10Jeroen De Dauw) [11:12:25] (03PS4) 10Adrian Lang: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [11:13:10] (03PS4) 10Adrian Lang: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [11:26:40] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [11:26:54] (03CR) 10jenkins-bot: [V: 04-1] Narrow EntityParserOutputGeneratorFactory interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 (owner: 10Thiemo Mättig (WMDE)) [11:27:38] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [11:30:21] (03PS4) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [11:32:39] (03PS6) 10Daniel Kinzler: Inject LabelLookup got use by Formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 [11:35:44] (03CR) 10Daniel Kinzler: [C: 032] Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 (owner: 10Adrian Lang) [11:35:50] (03PS5) 10Hoo man: Move UpdateRepo hook handlers into a dedicated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 [11:36:30] (03CR) 10Hoo man: Move UpdateRepo hook handlers into a dedicated class (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [11:36:51] (03CR) 10Hoo man: "Addressed Daniel's comments, manually re-tested." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [11:36:58] (03PS1) 10Thiemo Mättig (WMDE): Drop unused code from EntityViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175973 [11:37:13] (03CR) 10Daniel Kinzler: [C: 032] Remove static from WikibaseValueFormatterBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 (owner: 10Adrian Lang) [11:40:10] (03PS1) 10Thiemo Mättig (WMDE): Drop unused code from SpecialEntityDataTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175976 [11:40:25] (03CR) 10Daniel Kinzler: [C: 031] "Looks fine, but needs manual testing for the special pages, since we don't have good unit tests for them." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 (owner: 10Thiemo Mättig (WMDE)) [11:41:42] (03CR) 10Adrian Lang: [C: 031] "minor thing." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 (owner: 10Thiemo Mättig (WMDE)) [11:42:05] (03CR) 10Hoo man: [C: 031] "Looks good, only +1 to give you a moment to look at the comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 (owner: 10Thiemo Mättig (WMDE)) [11:45:10] (03CR) 10Adrian Lang: [C: 032] Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [11:45:23] (03PS3) 10Thiemo Mättig (WMDE): Clean up introduction of usage tracking service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 [11:46:16] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Rebased again. I can try to split this if you think this make the review easier. Please tell me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [11:46:54] (03CR) 10Hoo man: [C: 04-1] "Looks good, but please address Adrian's comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 (owner: 10Thiemo Mättig (WMDE)) [11:48:14] (03PS9) 10Thiemo Mättig (WMDE): Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [11:58:33] (03CR) 10Tobias Gritschacher: [V: 032] New Wikidata Build - 2014/11/26 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/175967 (owner: 10Tobias Gritschacher) [11:58:41] (03PS3) 10Adrian Lang: Use the same EntityInfo for JS and HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173275 (owner: 10Daniel Kinzler) [11:59:53] (03CR) 10Adrian Lang: "Rebased and addressed Tobi's comment." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173275 (owner: 10Daniel Kinzler) [12:01:07] (03CR) 10jenkins-bot: [V: 04-1] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [12:06:27] (03CR) 10jenkins-bot: [V: 04-1] Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 (owner: 10Adrian Lang) [12:06:37] (03CR) 10jenkins-bot: [V: 04-1] Remove static from WikibaseValueFormatterBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 (owner: 10Adrian Lang) [12:07:50] (03CR) 10jenkins-bot: [V: 04-1] Move UpdateRepo hook handlers into a dedicated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [12:08:43] (03PS4) 10Adrian Lang: Remove static from WikibaseValueFormatterBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 [12:09:03] (03PS5) 10Adrian Lang: Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 [12:13:48] (03CR) 10jenkins-bot: [V: 04-1] Drop unused code from EntityViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175973 (owner: 10Thiemo Mättig (WMDE)) [12:18:58] the oAuth issue seems to have had attention [12:19:06] it now seems stable [12:29:58] (03CR) 10jenkins-bot: [V: 04-1] Drop unused code from SpecialEntityDataTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175976 (owner: 10Thiemo Mättig (WMDE)) [12:32:00] (03CR) 10jenkins-bot: [V: 04-1] Clean up introduction of usage tracking service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [12:36:09] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [12:37:13] (03Merged) 10jenkins-bot: Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [12:37:15] (03Merged) 10jenkins-bot: Make stuff in CachingEntityRevisionLookup private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175823 (owner: 10Thiemo Mättig (WMDE)) [12:40:05] (03CR) 10Adrian Lang: [C: 032] Use the same EntityInfo for JS and HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173275 (owner: 10Daniel Kinzler) [12:40:33] (03CR) 10Adrian Lang: [C: 032] "Restoring Daniel's +2" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 (owner: 10Adrian Lang) [12:46:52] 3MediaWiki-extensions-WikidataRepo: Refactor EntityView Instantiation - https://phabricator.wikimedia.org/T75264#787892 (10adrianlang) [12:46:53] 3MediaWiki-extensions-WikidataRepo: Reuse EntityInfoBuilder arrays when generating html - https://phabricator.wikimedia.org/T64724#657078 (10adrianlang) [12:52:25] 3MediaWiki-extensions-WikidataRepo: Reuse EntityInfoBuilder arrays when generating html - https://phabricator.wikimedia.org/T64724#787919 (10adrianlang) a:3daniel https://gerrit.wikimedia.org/r/#/c/173848/ [12:52:52] 3MediaWiki-extensions-WikidataRepo: Reuse EntityInfoBuilder arrays when generating html - https://phabricator.wikimedia.org/T64724#787922 (10adrianlang) [12:56:07] [13WikibaseQuery] 15thiemowmde 04force-pushed 06protected from 14acab05f to 147fde5dc: 02http://git.io/4eruJA [12:56:07] 13WikibaseQuery/06protected 147fde5dc 15Thiemo Mättig: Fix visibility level of properties and methods [12:57:30] 3MediaWiki-extensions-WikidataRepo: Add a feature flag for Statements on Properties - https://phabricator.wikimedia.org/T75998 (10hoo) 3NEW p:3Normal a:3hoo [12:58:51] 3MediaWiki-extensions-WikidataRepo: allow statements on properties - https://phabricator.wikimedia.org/T51554#787934 (10hoo) [12:59:03] wmde/WikibaseQuery/protected/7fde5dc : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/42192038 [13:01:25] (03PS1) 10Adrian Lang: Remove @todo in phpunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175981 [13:02:34] (03CR) 10jenkins-bot: [V: 04-1] Use the same EntityInfo for JS and HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173275 (owner: 10Daniel Kinzler) [13:08:06] (03PS4) 10Adrian Lang: Use the same EntityInfo for JS and HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173275 (owner: 10Daniel Kinzler) [13:12:01] Thiemo_WMDE1: api.php?action=wbparsevalue&parser=time&values=1970-01-0 [13:16:01] 3MediaWiki-extensions-WikidataClient: Adds Wikidata support to the other projects sidebar - https://phabricator.wikimedia.org/T76002 (10Tpt) 3NEW p:3Normal a:3Tpt [13:17:16] 3MediaWiki-extensions-WikidataClient: Other projects sidebar beta feature image is PNG rather than SVG asset - https://phabricator.wikimedia.org/T73344#787986 (10Tpt) [13:17:24] https://phabricator.wikimedia.org/T65723 [13:18:53] (03Merged) 10jenkins-bot: Remove static from WikibaseValueFormatterBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174668 (owner: 10Adrian Lang) [13:23:56] (03PS7) 10Adrian Lang: Inject LabelLookup got use by Formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [13:24:14] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [13:24:41] (03PS8) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [13:25:22] 3MediaWiki-extensions-WikidataRepo: Time formatting incorrect for some languages - https://phabricator.wikimedia.org/T65723#788002 (10thiemowmde) [13:33:20] (03CR) 10jenkins-bot: [V: 04-1] Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [13:33:58] [13WikibaseDataModel] 15thiemowmde created 06slKeys (+1 new commit): 02http://git.io/-KZc6w [13:33:58] 13WikibaseDataModel/06slKeys 1451b3e9d 15Thiemo Mättig: Fix StatementList not reindexing associative arrays [13:34:59] [13WikibaseDataModel] 15thiemowmde opened pull request #311: Fix StatementList not reindexing associative arrays (06master...06slKeys) 02http://git.io/dwzEWQ [13:37:24] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06slKeys from 1451b3e9d to 1429997a9: 02http://git.io/y3cJlA [13:37:24] 13WikibaseDataModel/06slKeys 1429997a9 15Thiemo Mättig: Fix StatementList not reindexing associative arrays [13:37:43] (03PS9) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [13:38:35] jzerebecki: https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-api-tests/2858/console [13:40:00] wmde/WikibaseDataModel/slKeys/29997a9 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42195546 [13:50:49] 3MediaWiki-extensions-WikidataClient: Adds Wikidata support to the other projects sidebar - https://phabricator.wikimedia.org/T76002#788035 (10Sjoerddebruin) There is already a link to the Wikidata item in the sidebar? [13:56:37] (03CR) 10Hoo man: [C: 032 V: 032] Inject LabelLookup got use by Formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 (owner: 10Daniel Kinzler) [13:57:09] that commit message sounds weird :P [14:03:51] (03PS1) 10Adrian Lang: Add missing test resources [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175986 [14:05:40] (03PS1) 10Adrian Lang: move wikibase.api into own module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175987 [14:08:57] (03PS2) 10Adrian Lang: move wikibase.api into own module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175987 [14:12:35] (03CR) 10jenkins-bot: [V: 04-1] move wikibase.api into own module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175987 (owner: 10Adrian Lang) [14:18:02] 3MediaWiki-extensions-WikidataRepo: basic support for Wikimedia Commons - https://phabricator.wikimedia.org/T66288#788059 (10JanZerebecki) [14:20:54] 3MediaWiki-extensions-WikidataRepo: basic support for structured data on Wikimedia Commons files - https://phabricator.wikimedia.org/T66288#788066 (10JanZerebecki) [14:21:26] 3MediaWiki-extensions-WikidataRepo: basic support for structured data on Wikimedia Commons files - https://phabricator.wikimedia.org/T66288#687824 (10JanZerebecki) [14:24:06] 3MediaWiki-extensions-WikidataRepo: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#788070 (10JanZerebecki) [14:25:50] (03PS2) 10Thiemo Mättig (WMDE): Add missing test resources [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175986 (owner: 10Adrian Lang) [14:28:30] (03PS3) 10Thiemo Mättig (WMDE): Add missing test resources [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175986 (owner: 10Adrian Lang) [14:31:46] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add missing test resources [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175986 (owner: 10Adrian Lang) [14:32:55] (03CR) 10Thiemo Mättig (WMDE): [V: 032] Add missing test resources [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175986 (owner: 10Adrian Lang) [14:35:30] (03CR) 10Thiemo Mättig (WMDE): Phase out hasClaim and newClaim (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 (owner: 10Thiemo Mättig (WMDE)) [14:35:43] (03PS10) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [14:36:42] (03PS11) 10Adrian Lang: Inject EntityInfoTermLookup into ValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [14:37:21] (03PS3) 10Thiemo Mättig (WMDE): Rename dataTypes to dataTypeStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 [14:37:28] (03CR) 10Thiemo Mättig (WMDE): Rename dataTypes to dataTypeStore (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 (owner: 10Thiemo Mättig (WMDE)) [14:38:01] 3MediaWiki-extensions-WikidataClient: support mutliple repos in one client - https://phabricator.wikimedia.org/T76005 (10JanZerebecki) 3NEW p:3Triage [14:39:17] (03PS1) 10Adrian Lang: Bump data-values/javascript dependency to match Wikibase.git's [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175991 [14:39:26] 3MediaWiki-extensions-WikidataRepo: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#788104 (10JanZerebecki) [14:40:16] (03CR) 10Adrian Lang: [C: 032] Rename dataTypes to dataTypeStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 (owner: 10Thiemo Mättig (WMDE)) [14:42:10] 3Structured-Data, MediaWiki-extensions-WikidataRepo: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#788107 (10JanZerebecki) [14:42:20] (03CR) 10Thiemo Mättig (WMDE): Narrow TermSqlIndex interface to EntityId (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175803 (owner: 10Thiemo Mättig (WMDE)) [14:45:10] 3Structured-Data, MediaWiki-extensions-WikidataRepo: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#788118 (10JanZerebecki) [14:47:06] (03PS1) 10Adrian Lang: Remove dependency on wikibase resource loader module [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175994 [14:52:37] (03Merged) 10jenkins-bot: Rename dataTypes to dataTypeStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 (owner: 10Thiemo Mättig (WMDE)) [14:53:03] (03PS1) 10Adrian Lang: Shorten overly long lines [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175996 [14:54:48] (03PS1) 10Adrian Lang: Correct wrong jshint config name [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 [14:55:02] 3MediaWiki-extensions-WikidataRepo: add ability to link/refer to foreign items and properties - https://phabricator.wikimedia.org/T76007 (10JanZerebecki) 3NEW p:3Triage [14:57:08] 3MediaWiki-extensions-WikidataRepo: add ability to link/refer to foreign items and properties - https://phabricator.wikimedia.org/T76007#788135 (10JanZerebecki) [14:58:04] 3MediaWiki-extensions-WikidataRepo: add ability to link/refer to foreign items and properties - https://phabricator.wikimedia.org/T76007#788126 (10JanZerebecki) [15:20:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Bump data-values/javascript dependency to match Wikibase.git's [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175991 (owner: 10Adrian Lang) [15:21:29] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Remove dependency on wikibase resource loader module [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175994 (owner: 10Adrian Lang) [15:22:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Shorten overly long lines [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175996 (owner: 10Adrian Lang) [15:23:51] 3Structured-Data, MediaWiki-extensions-WikidataRepo: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#788196 (10JanZerebecki) [15:25:03] 3Structured-Data, MediaWiki-extensions-WikidataRepo: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#687824 (10JanZerebecki) [15:37:20] 3Structured-Data, MediaWiki-extensions-WikidataRepo: user interface for structured data on Commons - https://phabricator.wikimedia.org/T76016#788230 (10Lydia_Pintscher) [15:38:33] (03CR) 10Hoo man: [C: 032] "Good point, makes sense" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 (owner: 10Thiemo Mättig (WMDE)) [15:38:41] (03CR) 10jenkins-bot: [V: 04-1] Phase out hasClaim and newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 (owner: 10Thiemo Mättig (WMDE)) [15:38:44] 3Structured-Data, MediaWiki-extensions-WikidataRepo: figure out relationship between storing, editing and displaying structured data - https://phabricator.wikimedia.org/T76017 (10Lydia_Pintscher) 3NEW p:3Normal [15:41:39] What's all this https://phabricator.wikimedia.org/T66288#788059 [15:42:27] Nemo_bis: We're just putting some stuff we discussed in a meeting into phab [15:46:01] 3MediaWiki-extensions-WikidataRepo: Find a way to make global item ids - https://phabricator.wikimedia.org/T73996#788247 (10JanZerebecki) [15:46:17] 3MediaWiki-extensions-WikidataRepo: Find a way to make global item ids - https://phabricator.wikimedia.org/T73996#758128 (10JanZerebecki) [15:46:35] 3MediaWiki-extensions-WikidataClient: support mutliple repos in one client - https://phabricator.wikimedia.org/T76005#788249 (10JanZerebecki) [15:47:25] 3MediaWiki-extensions-WikidataRepo: add ability to link/refer to foreign items and properties - https://phabricator.wikimedia.org/T76007#788250 (10JanZerebecki) [15:55:24] (03PS2) 10Thiemo Mättig (WMDE): Phase out hasClaim and newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 [15:56:11] Ok... but it's really a mess when editing different things requires so many notifications [15:56:14] 3MediaWiki-extensions-WikidataRepo: Support new types of Entities in Wikibase Repository - https://phabricator.wikimedia.org/T75496#788264 (10JeroenDeDauw) [15:57:27] hoo: jzerebecki: stupid question, did you try to reboot the jenkins instances? [15:57:41] Katie did that on Saturday or so [15:58:10] (03PS2) 10Thiemo Mättig (WMDE): Drop unused code from SpecialEntityDataTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175976 [15:58:13] (03PS2) 10Thiemo Mättig (WMDE): Drop unused code from EntityViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175973 [15:58:52] Tobi_WMDE_SW: i didn't [15:58:53] hoo: ok, it just came too my mind that we once had problems with the scrumbugz instance that timed out, and a reboot fixed it [15:59:51] 3MediaWiki-extensions-WikidataRepo: Support new types of Entities in Wikibase Repository - https://phabricator.wikimedia.org/T75496#788280 (10JeroenDeDauw) [16:00:39] 3MediaWiki-extensions-WikidataClient: Support new types of Entities in Wikibase Client - https://phabricator.wikimedia.org/T76019#788271 (10JeroenDeDauw) [16:01:38] (03PS10) 10Daniel Kinzler: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) [16:01:45] (03PS9) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) [16:03:06] Nemo_bis: agree, the verbosity of phabricator reporting to irc is too high IMHO [16:03:27] but you could just ignore wikibugs [16:03:41] Tobi_WMDE_SW: please file bugs under the wikibugs project if you think something is being reported to IRC and shouldn't be [16:06:23] Tobi_WMDE_SW: I already ignore wikibugs; I'm subscribed to that task [16:06:31] 3MediaWiki-extensions-WikidataRepo: Create extension mechanism for Wikibase Repository - https://phabricator.wikimedia.org/T76021#788290 (10JeroenDeDauw) [16:07:02] It's not necessarily an issue of notifications, rather of how many things phabricator lets you do in one go. Many things require 5 times as many clicks and page loads in phabricator than on bugzilla, for instance. [16:08:19] (03CR) 10Hoo man: [C: 032] Phase out hasClaim and newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 (owner: 10Thiemo Mättig (WMDE)) [16:08:34] 3Structured-Data, MediaWiki-extensions-WikidataRepo, Multimedia: user interface for structured data on Commons - https://phabricator.wikimedia.org/T76016#788300 (10Gilles) [16:08:35] 3Structured-Data, MediaWiki-extensions-WikidataRepo, Multimedia: figure out relationship between storing, editing and displaying structured data - https://phabricator.wikimedia.org/T76017#788299 (10Gilles) [16:08:38] 3Structured-Data, MediaWiki-extensions-WikidataRepo, Multimedia: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#788302 (10Gilles) [16:10:10] 3MediaWiki-extensions-WikidataRepo: Create extension mechanism for Wikibase Repository - https://phabricator.wikimedia.org/T76021#788332 (10JeroenDeDauw) We could just bolt the whole pile of extension points on top of the WikibaseRepo class. Then extensions to Wikibase Repository could do something like $wikiba... [16:21:30] wow [16:21:36] This phabricator thing is spammy [16:21:40] Djeeez [16:21:50] and that jenkins thing is broken -.- [16:21:57] It sends 10x as many mails as Jenkins? [16:22:00] err [16:22:03] Buzgzilla [16:22:06] hoo: evilllll! [16:22:19] JeroenDeDauw: https://phabricator.wikimedia.org/settings/panel/emailpreferences/ [16:22:29] Ignore all the things! [16:22:31] * hoo hides [16:22:46] hoo: ty [16:25:18] https://www.mediawiki.org/wiki/Phabricator/Help#Receiving_updates_and_notifications [16:25:46] We have help! Don't be shy! Available for everybody! And it tells you everything you never wanted to know! [16:26:21] (03CR) 10jenkins-bot: [V: 04-1] Phase out hasClaim and newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 (owner: 10Thiemo Mättig (WMDE)) [16:26:23] (03CR) 10jenkins-bot: [V: 04-1] Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [16:26:25] 3MediaWiki-extensions-WikidataRepo: Fix Wikibase Serialization Tests - https://phabricator.wikimedia.org/T75886#788402 (10JanZerebecki) https://github.com/wmde/WikibaseDataModel/pull/311 [16:28:03] (03Merged) 10jenkins-bot: Phase out hasClaim and newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174775 (owner: 10Thiemo Mättig (WMDE)) [16:45:14] (03CR) 10Daniel Kinzler: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [17:25:34] 3MediaWiki-extensions-WikidataRepo: add ability to link/refer to foreign items and properties - https://phabricator.wikimedia.org/T76007#788673 (10JanZerebecki) [17:31:36] (03PS1) 10Daniel Kinzler: Language fallback for labels of referenced items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176008 [17:38:30] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: Overhaul LanguageFallbackChainFactory, use appropriate fallback depending on context. - https://phabricator.wikimedia.org/T76047 (10daniel) 3NEW p:3Triage [17:57:23] (03CR) 10Jeroen De Dauw: "Yeah sure, you might well need to do additional things to correctly tackle the TODO. It's not meant to be a full description, just a remin" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175741 (owner: 10Jeroen De Dauw) [17:57:28] (03PS3) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [17:57:46] (03PS4) 10Jeroen De Dauw: [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 [17:57:48] (03PS3) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [18:09:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [18:11:23] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [18:11:27] (03CR) 10jenkins-bot: [V: 04-1] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [18:56:52] (03CR) 10Hoo man: [C: 04-1] "This is what we want AFAIS" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176008 (owner: 10Daniel Kinzler) [19:02:19] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [19:02:51] JeroenDeDauw: Ok, feel free to shot at jenkins again [19:03:07] should be working again (although at 3/5 steam only) [19:10:24] Warning: LU_Updater::readMessages: Unable to parse messages from /var/lib/l10nupdate/mediawiki/extensions/Wikidata/vendor/data-values/data-values/DataValues.i18n.php i$ [19:10:43] Reedy: Oh for... sake [19:17:47] Reedy: Do you more details? [19:18:18] + have [19:18:39] Not really [19:18:40] Warning: LU_Updater::readMessages: Unable to parse messages from /var/lib/l10nupdate/mediawiki/extensions/Wikidata/vendor/data-values/data-values/DataValues.i18n.php in /srv/mediawiki-staging/php-1.25wmf9/extensions/LocalisationUpdate/Updater.php on line 63 [19:18:57] Validator and SemanticResultFormats have the same issue [19:19:46] hoo: At least locally (not completely up to date) DataValues.i18n.php still contains messages [19:19:49] Was it not ported to json? [19:19:52] oh, I got a suspicion [19:19:54] it was [19:20:17] shall we just remove that shim? [19:20:55] When was it changed? [19:21:07] Wondering if it might go awway... [19:21:20] oh wait... you had that on wmf9? [19:21:24] Is wmf10 fine [19:21:33] because it actually only changed for wmf10 [19:21:36] Dunno :) [19:21:40] that probably explains it then [19:41:49] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [19:42:06] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 (owner: 10Thiemo Mättig (WMDE)) [19:42:19] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [19:44:16] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [19:44:32] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [19:44:38] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175968 (owner: 10Thiemo Mättig (WMDE)) [19:45:27] 3MediaWiki-extensions-WikidataRepo: check if items without sitelinks and statements are counted in Special:Statistics - https://phabricator.wikimedia.org/T76071 (10Lydia_Pintscher) 3NEW p:3Normal [19:45:36] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [20:22:32] hashar: ping [20:22:37] We really need you :P [20:23:40] hoo: I am busy preparing an RFC discussion :D [20:24:19] crap [20:24:25] can you ping me when free? [20:24:36] We're having big trouble with our jenkinses atm [20:33:22] (03PS1) 10Hoo man: Also show Statements on Properties on non-experimental mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176050 [20:33:24] (03PS1) 10Hoo man: Add a feature flag for showing Statements on Properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 [20:33:55] (03PS2) 10Hoo man: Also show Statements on Properties in non-experimental mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176050 [20:35:41] (03PS2) 10Hoo man: Add a feature flag for showing Statements on Properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 [20:56:23] (03PS5) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [20:56:37] (03PS5) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [20:56:43] (03PS4) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [20:56:48] (03PS4) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [20:57:48] rebase ALL the thing [20:59:55] Lydia_WMDE: I have the men-item back in the first list. :) [21:00:11] But will be great if it showed up on the first position... [21:00:22] \o/ [21:00:25] ack [21:15:58] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [21:18:45] [13WikibaseDataModel] 15JeroenDeDauw created 06depsetid (+1 new commit): 02http://git.io/8w_rLQ [21:18:45] 13WikibaseDataModel/06depsetid 147435f96 15jeroendedauw: Deprecate Entity::setId [21:19:00] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #312: Deprecate Entity::setId (06master...06depsetid) 02http://git.io/aN8h4w [21:22:41] wmde/WikibaseDataModel/depsetid/7435f96 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42241794 [21:22:58] (03CR) 10jenkins-bot: [V: 04-1] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [21:24:42] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [21:25:15] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [21:29:41] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/IiIXDQ [21:29:41] 13WikibaseDataModel/06master 146223a24 15Jeroen De Dauw: Merge pull request #311 from wmde/slKeys... [21:53:54] [13WikibaseDataModel] 15JeroenDeDauw created 06langfilter (+1 new commit): 02http://git.io/w-9PNw [21:53:54] 13WikibaseDataModel/06langfilter 14ffdeea8 15jeroendedauw: Add language filter method to TermList... [21:54:00] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #313: Add language filter method to TermList (06master...06langfilter) 02http://git.io/m7_ZzA [21:55:23] [13WikibaseDataModel] 15JeroenDeDauw tagged 062.4.1 at 06master: 02http://git.io/EEc5Ug [21:56:00] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/DukoNQ [21:56:00] 13WikibaseDataModel/06master 140b2aa47 15jeroendedauw: Bump to 2.5 alpha [21:57:06] hoo: you can haz yet another filter method https://github.com/wmde/WikibaseDataModel/pull/313 :) [21:57:44] (03CR) 10Aude: [C: 04-1] "nitpick" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 (owner: 10Hoo man) [21:57:56] lolwat [21:58:02] 404 on jenkins link... [21:58:13] (03PS6) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [21:58:13] JeroenDeDauw: known [21:58:19] aude: It's private :P [21:58:22] But you'r right [21:58:26] hoo: doesn't matter [21:58:33] (03PS6) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [21:58:41] (03CR) 10Jeroen De Dauw: [WIP] Stop using deprecated methods in GenericEntityInfoBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [21:58:56] (03PS5) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [21:58:57] wmde/WikibaseDataModel/langfilter/ffdeea8 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42245290 [21:59:02] (03PS5) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [21:59:09] hoo: is the idea that we enable this on test.wikidata for 2 weeks or such? [21:59:13] or on beta? [21:59:22] aude: testwikidata [21:59:25] ok [21:59:26] next week, probably [21:59:30] ok :) [22:00:02] I'll amend tomorrow... can't really focus anymore [22:00:33] ok [22:00:41] * aude is slightly distracted with holidays [22:00:49] not doing much [22:00:51] aude: hoo: can you think of any reason why we should not deprecate the setId methods for entities? https://github.com/wmde/WikibaseDataModel/issues/310 [22:01:11] JeroenDeDauw: is it used in tests? [22:01:13] wmde/WikibaseDataModel/2.4.1/6223a24 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42245421 [22:01:24] aude: sure it is [22:01:40] aude: are there places where the ID is changed (from a set id to another set id)? [22:01:50] not that i know [22:02:08] maybe for new entities [22:02:14] Special:NewItem [22:02:19] it is created w/o id [22:02:28] then the id is set after the filters are checked and such [22:02:34] and when the entity is saved? [22:02:46] although we could change that perhaps [22:03:07] aude: That's covered [22:03:23] an id can be set after the object creation if null was passed initially [22:03:29] at least accoridng to Thiemo'S idea [22:03:38] in assignFreshId [22:03:49] hoo: that is thiemos second suggestion [22:03:52] But we have a lot of tests that do $entity2 = clone $entity; $entity2->doStuff( 'nyan' ); [22:03:53] WikiPageEntityStore [22:03:59] I think we should go with the first if possible [22:04:09] * aude doesn't object if we have a solution to handle that case [22:04:33] hoo: you can always construct a new Item or Property [22:04:56] we could even add a getCopyWithId method or so [22:05:32] yeah [22:05:49] I don't really see the benefit for our current needs now, but I also don't object [22:06:02] IMO it's not worth it, but if you feel like it could be useful, feel free to push for that [22:06:12] as long as it is good performance wise to do copy in this case [22:06:29] or benefit is sufficient [22:06:30] aude: the copy method is for cases where we currently do a clone in tests [22:06:38] hm [22:06:41] aude: that's not going to happen outside of tests, I'm fairly sure [22:06:51] ok [22:07:24] aude: Btw, there is a way to finish up that link begin stuffs [22:07:25] hoo: the reason for such a deprecation is that we do not have to support it as well in EntityDocument [22:07:33] I'll hopefully find the time to amend it tomorrow [22:07:39] hoo: go ahead [22:07:54] JeroenDeDauw: I get that... the question is, it worth it... and I'm not convinced about that [22:07:59] We need to either decide to not support what assignFreshId currently does, or to find a way to support it [22:08:01] i think it needs tests and could be made nicer [22:08:04] much nicer [22:08:22] aude: what are you talking about? What could be made nicer? [22:08:23] then note the tasks i made in phabricator for follow up things [22:08:33] JeroenDeDauw: handling of the onLinkBegin hook [22:08:37] hoo: what alternative approach do you suggest then? [22:08:37] evil hook [22:08:51] aude: is that related to what we've been talking about? [22:08:55] JeroenDeDauw: no [22:09:06] random aude! [22:09:10] :) [22:09:21] JeroenDeDauw: I think it would be ok to have a setId method... I don't really see the case to enforce a read only entity right now [22:10:33] Right. I do not think enforcing this adds that much value either. We never had a problem with it not being there [22:10:44] Howevere, we need to go in one direction [22:10:52] Either add support or deprecate [22:10:55] We cannot do nothing [22:11:32] Yeah... that's why I weakly prefer to keep it [22:11:36] but that's a weak preference [22:11:55] hoo: "keep" as in "add new method to EntityDocument"? :) [22:12:09] Yep, just add setId to it [22:16:03] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 1429997a9: This has been released 02http://git.io/Owf1Qg [22:16:53] JeroenDeDauw: Do we need a backport of that patch? [22:17:04] I'm not sure what the actual impact is [22:17:29] I don't even know where something broke, so don't ask me. Depends on the code using it [22:17:47] ok, so that means I'll have to poke Thiemo tomorrow [22:18:14] * aude returns to holiday [22:18:15] later [22:19:20] Have fun [22:19:27] don't work :P [22:19:59] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06langfilter: 02http://git.io/vPRBjg [22:19:59] 13WikibaseDataModel/06langfilter 140483860 15jeroendedauw: Add language filter method to AliasGroupList [22:24:03] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [22:24:24] [13WikibaseDataModel] 15mariushoch 04deleted 06langfilter at 140483860: 02http://git.io/U8h9HA [22:25:38] (03CR) 10jenkins-bot: [V: 04-1] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [22:25:52] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [22:25:55] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw)