[00:00:34] Why doesn't the "add links" in the sidebar link to wikidata if there are no other sitelinks? [00:02:34] Because the widget is way more user friendly? [00:03:16] How else are we supposed to find a link to Wikidata? [00:03:24] action=info or some obscure Wikidata special page? [00:03:45] There's still the link to the Wikidata item in the toolbox [00:04:09] oh, there is. Didn't notice that, I'm an idiot [00:39:36] https://test.wikidata.org/w/index.php?title=Q903&action=history&limit=2 Yay :) [00:43:57] (03CR) 10Hoo man: "Just some thoughts for tomorrow" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [00:58:27] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/m7S7Yw [00:58:27] 13WikibaseDataModel/06master 14842b3aa 15Jeroen De Dauw: Update RELEASE-NOTES.md [01:15:36] Is there a generic "code for" property? [01:16:00] with qualifier for what kind of code it is? [01:16:33] by code I mean like ISO codes (but not necessarily ISO) [05:38:07] HellHello [05:39:20] HellHello to you, too. [07:25:24] 3MediaWiki-extensions-WikidataRepo: Mono-lingual text datatype should support "no linguistic content" and "undetermined language" - https://phabricator.wikimedia.org/T72205#790562 (10Liuxinyu970226) [07:27:29] 3MediaWiki-extensions-WikidataClient: Other projects sidebar should show badges if applicable - https://phabricator.wikimedia.org/T73887#790565 (10Liuxinyu970226) [07:30:26] 3MediaWiki-extensions-WikidataRepo: Cannot enter power of ten for quantity datatype - https://phabricator.wikimedia.org/T67436#790579 (10Liuxinyu970226) [07:37:42] 3MediaWiki-extensions-WikidataClient: other projects feature broken with $wgEnableSidebarCache = true - https://phabricator.wikimedia.org/T72234#790611 (10Liuxinyu970226) [08:10:58] gi11es: any reason for the custom edit permission policy on https://phabricator.wikimedia.org/tag/structured-data/ ? [08:26:25] (03PS1) 10Adrian Lang: Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176228 [08:26:56] 3MediaWiki-extensions-WikidataRepo: Can't use tab while adding sitelinks - https://phabricator.wikimedia.org/T75642#790709 (10Nemo_bis) > Needs a release of ValueView. To be clear, do you already know what caused the bug and how to reproduce it? Because I'm not so sure, but I also noticed the same behaviour whe... [08:29:04] 3Wikimedia-Wikidata: Use structured data on Wiktionary - https://phabricator.wikimedia.org/T986#790715 (10JanZerebecki) [08:29:27] 3Wikimedia-Wikidata: Implement Phase 1: Lexicons - https://phabricator.wikimedia.org/T988#790716 (10JanZerebecki) [08:29:46] 3Wikimedia-Wikidata: Implement Phase 0: Interwiki links - https://phabricator.wikimedia.org/T987#790717 (10JanZerebecki) [08:36:12] (03PS1) 10Adrian Lang: Move ClaimHtmlGenerator to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176229 [08:39:48] (03CR) 10jenkins-bot: [V: 04-1] Move ClaimHtmlGenerator to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176229 (owner: 10Adrian Lang) [08:40:45] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176229 (owner: 10Adrian Lang) [08:40:52] [13WikibaseQuery] 15thiemowmde 04force-pushed 06protected from 147fde5dc to 14076f280: 02http://git.io/4eruJA [08:40:52] 13WikibaseQuery/06protected 14076f280 15Thiemo Mättig: Fix visibility level of properties and methods [08:43:56] wmde/WikibaseQuery/protected/076f280 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseQuery/builds/42282949 [08:52:53] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176229 (owner: 10Adrian Lang) [08:55:17] 3Wikimedia-Wikidata: jenkins job time outs - https://phabricator.wikimedia.org/T76130#790762 (10JanZerebecki) [08:57:21] 3Wikimedia-Wikidata, Continuous-Integration: jenkins job time outs - https://phabricator.wikimedia.org/T76130#790772 (10JanZerebecki) [08:58:33] [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06documentation: 02http://git.io/ry3haw [08:58:33] 13WikibaseDataModelJavaScript/06documentation 141f380b4 15snaterlicious: Reinserted @see tags [08:58:53] [13WikibaseQueryEngine] 15thiemowmde created 06dvDocs (+1 new commit): 02http://git.io/CJnJIg [08:58:53] 13WikibaseQueryEngine/06dvDocs 14f4e560d 15Thiemo Mättig: Fix namespaces in DVHandler documentation [08:59:08] [13WikibaseQueryEngine] 15thiemowmde opened pull request #139: Fix namespaces in DVHandler documentation (06master...06dvDocs) 02http://git.io/Sf0iFQ [09:01:50] [13WikibaseDataModelJavaScript] 15snaterlicious 04force-pushed 06documentation from 141f380b4 to 14271b1e6: 02http://git.io/l1xnqA [09:01:50] 13WikibaseDataModelJavaScript/06documentation 14b09ce17 15snaterlicious: Updated code documentation... [09:01:50] 13WikibaseDataModelJavaScript/06documentation 148d534e5 15snaterlicious: Replaced deprecated @type with @property [09:01:50] 13WikibaseDataModelJavaScript/06documentation 140a29dd4 15snaterlicious: Updated Fingerprint.setAliases [09:02:54] wmde/WikibaseQueryEngine/dvDocs/f4e560d : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42284216 [09:06:03] [13DataTypes] 15snaterlicious pushed 1 new commit to 06jsdocumentation: 02http://git.io/5kbmWA [09:06:03] 13DataTypes/06jsdocumentation 14210df49 15snaterlicious: Removed obsolete "exports" fields [09:08:16] wmde/DataTypes/jsdocumentation/210df49 : snaterlicious The build was broken. http://travis-ci.org/wmde/DataTypes/builds/42284665 [09:10:14] [13DataTypes] 15snaterlicious 04force-pushed 06jsdocumentation from 14210df49 to 1424bde4c: 02http://git.io/CWbrcw [09:10:14] 13DataTypes/06jsdocumentation 1424bde4c 15snaterlicious: Adjusted "exports" fields [09:13:31] [13DataTypes] 15snaterlicious closed pull request #26: Updated JavaScript code in regard to documentation (06master...06jsdocumentation) 02http://git.io/TeJDVA [09:14:07] wmde/DataTypes/jsdocumentation/24bde4c : snaterlicious The build is still failing. http://travis-ci.org/wmde/DataTypes/builds/42284935 [09:14:35] (03PS3) 10Adrian Lang: Move wikibase.css and jquery.wikibase from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 [09:14:59] [13Number] 15thiemowmde created 06numberDoc (+1 new commit): 02http://git.io/Pjk6sg [09:14:59] 13Number/06numberDoc 14562d8bb 15Thiemo Mättig: Fix broken @see in doc [09:15:19] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [09:15:37] [13Number] 15thiemowmde opened pull request #14: Fix broken @see in doc (06master...06numberDoc) 02http://git.io/FZoBzg [09:16:44] (03PS1) 10Thiemo Mättig (WMDE): Fix broken @see in Number(Un)Localizer doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176230 [09:17:48] [13DataTypes] 15snaterlicious 04force-pushed 06jsdocumentation from 1424bde4c to 146bfcce9: 02http://git.io/CWbrcw [09:17:48] 13DataTypes/06jsdocumentation 146bfcce9 15snaterlicious: Added default value [09:19:53] wmde/DataTypes/jsdocumentation/6bfcce9 : snaterlicious The build was fixed. http://travis-ci.org/wmde/DataTypes/builds/42285411 [09:23:31] Thiemo_WMDE: https://phabricator.wikimedia.org/T75601 [09:26:22] [13DataTypes] 15snaterlicious comment on pull request #26 146bfcce9: It is ok. Basically, they all export ```dataTypes``` (although some modules fill the global ```dataTypes``` object with additional functionality). The configuration is just used for the tests. It would, of course, be awesome, to have a package manager for JS and CSS files allowing us to get rid of any shiming. 02http://git.io/pmOkdw [09:28:32] [13DataValuesJavascript] 15snaterlicious comment on pull request #56 141bc5695: Is that really worth a note? That is what I remember our code architect telling us and I have done it like that always. 02http://git.io/q3VsKw [09:42:13] [13ValueView] 15snaterlicious 04force-pushed 06documentation from 14ca760cf to 142ba7898: 02http://git.io/jDqopQ [09:42:13] 13ValueView/06documentation 142ba7898 15snaterlicious: Replaced @see with @inheritdoc [09:44:02] Tobi_WMDE_SW_NA: https://gerrit.wikimedia.org/r/#/c/176232/ [09:48:30] Adrian_WMDE: looks good, I +1d. [09:48:43] I don't have rights for +2 though [09:48:44] thanks [09:48:50] Yeah, I figured [09:48:55] jzerebecki: do you have? [09:49:13] I've poked wikimedia-qa [09:49:23] let's see or wait for hashar [09:49:50] Adrian_WMDE: still feels like software-as-a-service, no? [09:49:51] :) [09:50:09] As in simple and easy or as in you don't actually control it? [09:50:24] as in not having control [09:50:47] Yeah, it does [09:51:22] 3Structured-Data, MediaWiki-extensions-WikidataRepo, Multimedia: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#790819 (10Lydia_Pintscher) [09:51:25] Tobi_WMDE_SW: no +2 there either, should i get it? [09:51:35] jzerebecki: \o/ [09:51:40] sure [09:51:41] :) [09:55:22] Tobi_WMDE_SW: that would mean regularly putting in a bit of work to do feeding and petting of zuul and jenkins... if that's fine i'd like to [09:55:53] (03PS3) 10Hoo man: Also show Statements on Properties in non-experimental mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176050 [09:55:58] jzerebecki: that's what I'm doing already. :) [09:56:07] and I think you too, right? [09:58:23] (03PS3) 10Hoo man: Add a feature flag for showing Statements on Properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 [09:58:37] (03CR) 10Hoo man: "Addressed Katie's comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 (owner: 10Hoo man) [10:01:09] (03CR) 10Adrian Lang: [C: 04-1] Add a feature flag for showing Statements on Properties (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 (owner: 10Hoo man) [10:08:33] Tobi_WMDE_SW: sorta. didn't yet do enough so that i think i should request +2, which i would assume involves also getting zuul deployment rights. [10:22:46] (03PS1) 10Adrian Lang: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 [10:26:07] (03CR) 10Hoo man: Add a feature flag for showing Statements on Properties (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 (owner: 10Hoo man) [10:26:21] (03CR) 10jenkins-bot: [V: 04-1] Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [10:29:10] (03PS4) 10Hoo man: Add a feature flag for showing Statements on Properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 [10:31:56] (03CR) 10Adrian Lang: [C: 031] "There's still an unneeded reference to global state, but at least it's in a factory." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 (owner: 10Hoo man) [10:32:07] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [10:39:35] 3MediaWiki-extensions-WikidataRepo: language links for Wiktionary - https://phabricator.wikimedia.org/T987#790849 (10Lydia_Pintscher) p:5Normal>3Low [10:40:13] 3MediaWiki-extensions-WikidataRepo: Implement Phase 1: Lexicons - https://phabricator.wikimedia.org/T988#790852 (10Lydia_Pintscher) [10:41:04] 3MediaWiki-extensions-WikidataRepo: Implement Phase 1: Lexicons - https://phabricator.wikimedia.org/T988#17063 (10Lydia_Pintscher) Before we settle on all this I'd like to have more discussions please. Wiktionary is huge and I don't feel we've spent enough time thinking it through yet to commit to one way of doi... [10:42:02] 3MediaWiki-extensions-WikidataRepo: use structured data to represent the lexical data in Wiktionary - https://phabricator.wikimedia.org/T988#790856 (10Lydia_Pintscher) [10:42:52] 3MediaWiki-extensions-WikidataRepo: Use structured data on Wiktionary - https://phabricator.wikimedia.org/T986#790857 (10Lydia_Pintscher) [11:02:07] [13DataValuesJavascript] 15snaterlicious 04force-pushed 06documentation from 141bc5695 to 144a2add0: 02http://git.io/bHQ75A [11:02:07] 13DataValuesJavascript/06documentation 144a2add0 15snaterlicious: Updated util.inherit in regard to documentation [11:07:28] (03PS1) 10Adrian Lang: Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 [11:08:13] (03CR) 10Adrian Lang: "Drop all three {Entity,Property,Item}ViewTest files, they don't do anything." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175973 (owner: 10Thiemo Mättig (WMDE)) [11:12:29] [13WikibaseDataModelSerialization] 15JanZerebecki pushed 1 new commit to 06languageFallBack: 02http://git.io/p-KLlg [11:12:29] 13WikibaseDataModelSerialization/06languageFallBack 145eaf32e 15Jan Zerebecki: retrigger ci [11:12:59] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 145eaf32e to 1477a3794: 02http://git.io/0KqFLw [11:13:18] wmde/WikibaseDataModelSerialization/languageFallBack/5eaf32e : Jan Zerebecki The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/42294369 [11:13:46] 3MediaWiki-extensions-WikidataRepo: Coordinates shown as 0°0'NFF"N, 0°0'NFF"E caused by php warning: division by zero in GeoCoordinateFormatter - https://phabricator.wikimedia.org/T75601#790884 (10thiemowmde) @JanZerebecki, we are looking at cached diffs. The issue is resolved. Proof: https://www.wikidata.org/wi... [11:16:07] wmde/WikibaseDataModelSerialization/languageFallBack/77a3794 : Jan Zerebecki The build was fixed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/42294422 [11:20:21] 3MediaWiki-extensions-WikidataRepo: Coordinates shown as 0°0'NFF"N, 0°0'NFF"E caused by php warning: division by zero in GeoCoordinateFormatter - https://phabricator.wikimedia.org/T75601#790891 (10thiemowmde) [11:20:45] (03PS3) 10Adrian Lang: Remove broken detection of multiple empty listitems in sitelinklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 [11:20:59] (03CR) 10jenkins-bot: [V: 04-1] Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 (owner: 10Adrian Lang) [11:21:46] [13Geo] 15thiemowmde created 06geoFinite (+1 new commit): 02http://git.io/IdceRw [11:21:46] 13Geo/06geoFinite 14539aa95 15Thiemo Mättig: Improve precision tests [11:22:34] [13Geo] 15thiemowmde opened pull request #39: Improve precision tests (06master...06geoFinite) 02http://git.io/lB2lKg [11:24:59] [13Geo] 15thiemowmde comment on pull request #39 14539aa95: This padded with spaces which is wrong. Falling back to `%d` is enough. 02http://git.io/NyuFgg [11:29:21] (03PS2) 10Adrian Lang: Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 [11:32:17] 3MediaWiki-extensions-WikidataRepo: New serialization code needs to support language fallback - https://phabricator.wikimedia.org/T74183#790895 (10JanZerebecki) [11:32:18] 3MediaWiki-extensions-WikidataRepo: Fix Wikibase Serialization Tests - https://phabricator.wikimedia.org/T75886#790893 (10JanZerebecki) 5Open>3Resolved a:3JanZerebecki [11:39:05] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 1477a3794 to 144f8e095: 02http://git.io/0KqFLw [11:39:05] 13WikibaseDataModelSerialization/06languageFallBack 144f8e095 15Jan Zerebecki: Support TermFallback and AliasGroupFallback. [11:39:49] (03PS1) 10Hoo man: Always use 'wikibase-statements' as statement section header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176241 [11:42:19] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 144f8e095 to 1498427f4: 02http://git.io/0KqFLw [11:42:19] 13WikibaseDataModelSerialization/06languageFallBack 14ff0eb61 15Jan Zerebecki: Require new data-model version for language fallback. [11:42:19] 13WikibaseDataModelSerialization/06languageFallBack 1498427f4 15Jan Zerebecki: Support TermFallback and AliasGroupFallback. [11:43:54] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06dvintegration: 02http://git.io/Sq64YQ [11:43:54] 13WikibaseQueryEngine/06dvintegration 1421e7f55 15Thiemo Mättig: Fix BooleanHandler for PostgreSQL [11:44:09] 3Wikimedia-Wikidata, Continuous-Integration: jenkins job time outs - https://phabricator.wikimedia.org/T76130#790905 (10hashar) I notice it takes `update.php` more than six minutes to write the interwiki tables to the sqlite database backend: 00:00:52.970 Populating default interwiki table 00:07:18.105... [11:48:53] [13WikibaseQueryEngine] 15thiemowmde created 06pgBool (+1 new commit): 02http://git.io/r_DY9w [11:48:53] 13WikibaseQueryEngine/06pgBool 145f1bdcb 15Thiemo Mättig: Fix BooleanHandler for PostgreSQL [11:54:57] wmde/WikibaseQueryEngine/pgBool/5f1bdcb : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42297494 [11:56:14] [13WikibaseQueryEngine] 15thiemowmde opened pull request #140: Fix BooleanHandler for PostgreSQL (06master...06pgBool) 02http://git.io/GXboaQ [12:04:19] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06optimize2 from 14eb282e2 to 14ce631ae: 02http://git.io/EFHclw [12:04:19] 13WikibaseDataModelSerialization/06optimize2 14ce631ae 15Thiemo Mättig: Fix test method visibility [12:06:00] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06pp from 14d966b7d to 14d6c3034: 02http://git.io/_P2hPA [12:06:00] 13WikibaseDataModelSerialization/06pp 14d6c3034 15jeroendedauw: More clearly document package private [12:09:14] wmde/WikibaseDataModelSerialization/optimize2/ce631ae : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/42298578 [12:18:45] hi, does wikidata have a query api (including geo lookup), or is it a planned feature? [12:20:06] (03PS2) 10Daniel Kinzler: Language fallback for labels of referenced items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176008 [12:21:38] ferada: it's a planned feature. there's a 3rd party tool (wdq) that provides query capability, but i think geo support is rather limited [12:24:16] DanielK_WMDE__: ah cool i think wdq might be good enough for my purposes, thanks! [13:08:41] [13ValueView] 15snaterlicious pushed 13 new commits to 06documentation: 02http://git.io/_KgWRw [13:08:41] 13ValueView/06documentation 14d2ece56 15snaterlicious: @returns -> @return [13:08:41] 13ValueView/06documentation 14e2e22cb 15snaterlicious: Reevaluated @since tags [13:08:41] 13ValueView/06documentation 14e3a909a 15snaterlicious: @license -> @licence [13:15:48] (03CR) 10Aude: [C: 032] Move ClaimHtmlGenerator to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176229 (owner: 10Adrian Lang) [13:16:19] aude: Please don't merge the next in chain [13:16:25] Don't merge conflict [13:17:59] [13ValueView] 15snaterlicious pushed 2 new commits to 06documentation: 02http://git.io/j-1HgQ [13:17:59] 13ValueView/06documentation 146d9df14 15snaterlicious: Added missing @licence and @author tags [13:17:59] 13ValueView/06documentation 145cef58e 15snaterlicious: Added missing @since tags [13:21:13] (03CR) 10Aude: [C: 032] "yay!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [13:21:20] aaah why? [13:21:27] (03CR) 10Aude: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [13:21:53] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06typednska from 14a4aa29a to 1469a6d44: 02http://git.io/tE-iSQ [13:21:53] 13WikibaseDataModelSerialization/06typednska 1469a6d44 15jeroendedauw: Added `newTypedSnakSerializer` to `SerializerFactory` [13:23:26] hoo: can i merge the statements on properties patches? [13:23:39] (03CR) 10Daniel Kinzler: [C: 032] Also show Statements on Properties in non-experimental mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176050 (owner: 10Hoo man) [13:23:53] aude: Daniel's on that [13:24:07] ok [13:24:38] (03CR) 10Aude: [C: 031] "want to merge this :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [13:25:09] can haz review https://gerrit.wikimedia.org/r/#/c/174874/ ? [13:26:18] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/27 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/176247 [13:26:20] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 2014/11/26 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/175967 (owner: 10Tobias Gritschacher) [13:26:51] (03Abandoned) 10Aude: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [13:26:59] (03Abandoned) 10Aude: Use EntityInfoTermLookup in EntityView classes [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174618 (owner: 10Aude) [13:28:10] aude: mn [13:28:11] * mh [13:28:26] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06Phpunit from 141b180da to 148db1f5b: 02http://git.io/iY6uGA [13:28:26] 13WikibaseQueryEngine/06Phpunit 148db1f5b 15Thiemo Mättig: Lowercase phpunit folder [13:29:03] https://gerrit.wikimedia.org/r/#/c/174712/ is easy chocolate [13:29:26] I'm next the chocolate now :P [13:29:41] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2014/11/27 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/176247 (owner: 10Tobias Gritschacher) [13:29:44] (03Merged) 10jenkins-bot: Move ClaimHtmlGenerator to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176229 (owner: 10Adrian Lang) [13:29:52] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06Phpunit from 148db1f5b to 146aaf7d2: 02http://git.io/iY6uGA [13:29:52] 13WikibaseQueryEngine/06Phpunit 146aaf7d2 15Thiemo Mättig: Lowercase phpunit folder [13:30:01] (03CR) 10Hoo man: [C: 032] "Unused private method" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174712 (owner: 10Aude) [13:30:25] yay :) [13:31:38] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06Phpunit from 146aaf7d2 to 1479d6726: 02http://git.io/iY6uGA [13:31:38] 13WikibaseQueryEngine/06Phpunit 1479d6726 15Thiemo Mättig: Lowercase phpunit folder [13:31:46] * aude returns to holiday... [13:32:01] wmde/WikibaseQueryEngine/Phpunit/8db1f5b : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42306050 [13:32:17] Holidays are coming, holidays are coming, holidays are coming (300x) [13:32:47] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06Phpunit from 1479d6726 to 140dd7938: 02http://git.io/iY6uGA [13:32:47] 13WikibaseQueryEngine/06Phpunit 140dd7938 15Thiemo Mättig: Lowercase phpunit folder [13:35:50] wmde/WikibaseQueryEngine/Phpunit/6aaf7d2 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42306216 [13:35:53] (03CR) 10Daniel Kinzler: [C: 032] "This feature flag is expected to be removed once statements on properties are properly rolled out." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 (owner: 10Hoo man) [13:36:16] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add TODO [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175741 (owner: 10Jeroen De Dauw) [13:38:45] (03CR) 10Daniel Kinzler: [C: 032] Always use 'wikibase-statements' as statement section header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176241 (owner: 10Hoo man) [13:40:09] wmde/WikibaseQueryEngine/Phpunit/79d6726 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42306442 [13:49:15] (03Merged) 10jenkins-bot: Also show Statements on Properties in non-experimental mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176050 (owner: 10Hoo man) [13:49:20] wmde/WikibaseQueryEngine/Phpunit/0dd7938 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42306582 [13:59:49] (03Merged) 10jenkins-bot: Remove unused ClaimsView::getSnaksFromClaims method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174712 (owner: 10Aude) [14:07:24] (03Merged) 10jenkins-bot: Add a feature flag for showing Statements on Properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176051 (owner: 10Hoo man) [14:07:26] (03PS2) 10Adrian Lang: Remove _fetchItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 [14:09:31] (03PS3) 10Adrian Lang: Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 [14:09:33] (03PS2) 10Adrian Lang: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 [14:09:56] (03CR) 10Adrian Lang: [C: 032] "Rebased, restoring aude's +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [14:09:59] (03PS1) 10Hoo man: Always use 'wikibase-statements' as statement section header [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176249 [14:10:08] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 (owner: 10Adrian Lang) [14:11:25] (03PS1) 10Hoo man: Also show Statements on Properties in non-experimental mode [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176250 [14:11:39] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176250 (owner: 10Hoo man) [14:11:47] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176249 (owner: 10Hoo man) [14:15:50] (03Merged) 10jenkins-bot: Add TODO [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175741 (owner: 10Jeroen De Dauw) [14:16:09] (03Merged) 10jenkins-bot: Always use 'wikibase-statements' as statement section header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176241 (owner: 10Hoo man) [14:16:16] (03CR) 10jenkins-bot: [V: 04-1] Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [14:17:26] (03PS4) 10Adrian Lang: Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 [14:17:28] (03PS3) 10Adrian Lang: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 [14:17:49] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [14:17:53] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 (owner: 10Adrian Lang) [14:21:44] (03CR) 10Daniel Kinzler: [C: 04-1] "should be rebased on Ia0be6bf52790a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [14:31:50] Adrian_WMDE: https://phabricator.wikimedia.org/T50389 [14:34:23] (03Merged) 10jenkins-bot: Also show Statements on Properties in non-experimental mode [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176250 (owner: 10Hoo man) [14:34:25] (03CR) 10jenkins-bot: [V: 04-1] Always use 'wikibase-statements' as statement section header [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176249 (owner: 10Hoo man) [14:38:37] (03PS1) 10Hoo man: Add a feature flag for showing Statements on Properties [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176262 [14:38:56] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176262 (owner: 10Hoo man) [14:39:12] 3MediaWiki-extensions-WikidataRepo: Special:Statistic increments number of content pages when new Item is created - https://phabricator.wikimedia.org/T76145 (10Lucie) 3NEW p:3Triage [14:44:37] 3MediaWiki-extensions-WikidataRepo: check if items without sitelinks and statements are counted in Special:Statistics - https://phabricator.wikimedia.org/T76071#791225 (10Lucie) Items count as content if they have statements. Items with sitelinks but without statements aren't counted as content. The item's stat... [14:49:48] (03Merged) 10jenkins-bot: Add a feature flag for showing Statements on Properties [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176262 (owner: 10Hoo man) [14:51:03] (03PS2) 10Hoo man: Always use 'wikibase-statements' as statement section header [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176249 [14:51:56] 3MediaWiki-extensions-WikidataRepo: allow statements on properties - https://phabricator.wikimedia.org/T51554#791231 (10hoo) [14:51:58] 3MediaWiki-extensions-WikidataRepo: Add a feature flag for Statements on Properties - https://phabricator.wikimedia.org/T75998#791230 (10hoo) [14:55:31] 3MediaWiki-extensions-WikidataRepo: check if items without sitelinks and statements are counted in Special:Statistics - https://phabricator.wikimedia.org/T76071#791234 (10Lucie) 5Open>3Resolved [14:57:16] 3MediaWiki-extensions-WikidataRepo: Research usage of different skins in Wikidata community - https://phabricator.wikimedia.org/T75651#791238 (10Lucie) [14:58:38] (03PS6) 10Daniel Kinzler: Priming the entity_usage table based on page-props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172517 (https://bugzilla.wikimedia.org/73220) [15:05:17] (03PS1) 10Adrian Lang: Rewrite completely broken EntityView tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176268 [15:09:45] (03PS1) 10Hoo man: Update Wikibase and WikibaseDataModel [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176269 [15:28:28] (03CR) 10Hoo man: [C: 032] Update Wikibase and WikibaseDataModel [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176269 (owner: 10Hoo man) [15:30:33] (03Merged) 10jenkins-bot: Update Wikibase and WikibaseDataModel [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176269 (owner: 10Hoo man) [15:32:36] jzerebecki: is this the issue you where blocked on? https://github.com/wmde/WikibaseDataModelSerialization/issues/100 [15:33:42] JeroenDeDauw: yes, just forgot to remove the wip from my pull request... [15:34:04] 3MediaWiki-extensions-WikidataRepo: Special:ItemByTitle search ignores Wikipedia redirection - https://phabricator.wikimedia.org/T44224#791288 (10Lucie) This works now. You are directly redirected to "서울특별시" (Q8684) in this case. [15:34:14] 3MediaWiki-extensions-WikidataRepo: Special:ItemByTitle search ignores Wikipedia redirection - https://phabricator.wikimedia.org/T44224#791290 (10Lucie) [15:40:44] [13WikibaseQueryEngine] 15JeroenDeDauw 04deleted 06dvDocs at 14f4e560d: 02http://git.io/B17SCA [15:42:34] [13Geo] 15JeroenDeDauw 04deleted 06geoFinite at 14539aa95: 02http://git.io/82QsXg [15:42:54] 3MediaWiki-extensions-WikidataRepo: The Wikibase-time-precision-* messages have unclear documentation - https://phabricator.wikimedia.org/T62867#791292 (10Lucie) [15:51:28] [13Number] 15JeroenDeDauw created 06bootstrap (+1 new commit): 02http://git.io/svPpzg [15:51:28] 13Number/06bootstrap 14e0689b5 15jeroendedauw: Update PHPUnit bootstrap [15:51:38] [13Number] 15JeroenDeDauw opened pull request #15: Update PHPUnit bootstrap (06master...06bootstrap) 02http://git.io/c6Xv9w [15:54:49] jzerebecki: Took a while to find out who you are. Asking for permission to a production system in a comment on your first commit to a repo looked rather odd :D [15:55:33] heh, yes :) [15:56:01] Krinkle: though i had commits in the old jjb repo [15:56:12] err jjb-config [15:56:30] OK [15:56:37] 3MediaWiki-extensions-WikidataRepo: add language fallback to entity search/suggester - https://phabricator.wikimedia.org/T76150#791311 (10Lydia_Pintscher) [15:57:10] [13WikibaseDataModel] 15JeroenDeDauw created 06bootstrap (+1 new commit): 02http://git.io/VkVoUA [15:57:10] 13WikibaseDataModel/06bootstrap 146b450d9 15jeroendedauw: Make the test bootstrap work when included from another project... [15:57:19] I don't decide things like this, but don't expect it to happen in the current environment. And shouldn't be necessary. It's trivial for Antoine or myself to compile/push. The main time is taken up by review and testing. As it's evolving rapidly and not well-tested/well-documented, I'd recommend against expanding jenkins maintenance access at the moment. [15:58:44] hoo: you are happy now https://github.com/wmde/WikibaseDataModel/pull/314 [15:58:45] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #314: Make the test bootstrap work when included from another project (06master...06bootstrap) 02http://git.io/SvpIfw [15:58:56] 3MediaWiki-extensions-WikidataRepo: Specify language fallback - https://phabricator.wikimedia.org/T38430#791320 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher [15:58:58] JeroenDeDauw: Awesome, let me test it [15:59:20] 3MediaWiki-extensions-WikidataClient: Unit tests for ExternalRecentChange - https://phabricator.wikimedia.org/T45198#791323 (10Lucie) Sill open as far as I can see. Seems like ExternalChange doesn't have unit tests either. [15:59:30] 3MediaWiki-extensions-WikidataClient: Unit tests for ExternalRecentChange - https://phabricator.wikimedia.org/T45198#791327 (10Lucie) [15:59:45] jzerebecki: Associate tasks with commits by using "Bug: ". Otherwise it is just a strange text field preventing the change-id from being interpreted as the footer (key/value footer is the last part the commit message, separated by one empty line, just like headers) [15:59:54] See also https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [16:00:57] wmde/WikibaseDataModel/bootstrap/6b450d9 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42320691 [16:03:15] 3MediaWiki-extensions-WikidataRepo: JS error when choosing a badge-item that is a deleted item - https://phabricator.wikimedia.org/T76151 (10Tobi_WMDE_SW) 3NEW p:3Triage [16:03:52] Krinkle: done. not sure how i got the idea that i needed to leave out the "Bug: ". [16:05:39] hoo: y u no mergeee? It's been sitting there for a whole 5 minutes now :<0 [16:06:04] Doesn't work for me :( [16:06:48] 3MediaWiki-extensions-WikidataRepo: can't save changes that only change case in sitelinks - https://phabricator.wikimedia.org/T48451#791466 (10Lucie) Since the sitelinks are case sensitive you can only enter the title in the same way the original sitelink title is written. So I'd close this one. [16:06:59] 3MediaWiki-extensions-WikidataRepo: can't save changes that only change case in sitelinks - https://phabricator.wikimedia.org/T48451#791468 (10Lucie) [16:07:47] 3MediaWiki-extensions-WikidataClient: login issue with add language links widget - https://phabricator.wikimedia.org/T50389#791470 (10hoo) [16:09:30] 3MediaWiki-extensions-WikidataRepo: can't save changes that only change case in sitelinks - https://phabricator.wikimedia.org/T48451#791485 (10Lucie) 5Resolved>3Open [16:14:24] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #242: Remove inheritance between Statement and Claim (06master...06statementclaimcomposition) 02http://git.io/OGOVOA [16:20:20] (03PS8) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [16:20:32] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [16:20:54] 3MediaWiki-extensions-WikidataRepo: can't save changes that only change case in sitelinks - https://phabricator.wikimedia.org/T48451#791950 (10Lucie) Tested it with "Musical" and "MusicAL" - seems to work now. [16:20:55] 3MediaWiki-extensions-WikidataRepo: can't save changes that only change case in sitelinks - https://phabricator.wikimedia.org/T48451#791951 (10Lucie) 5Open>3Resolved [16:30:55] 3MediaWiki-extensions-WikidataRepo: Wikidata recent changes summaries mix languages - https://phabricator.wikimedia.org/T56807#792021 (10Lucie) [16:31:16] 3MediaWiki-extensions-WikidataRepo: Wikidata recent changes summaries mix languages - https://phabricator.wikimedia.org/T56807#792030 (10Lucie) [16:31:18] 3MediaWiki-extensions-WikidataRepo: disallow adding sitelinks to File namespace on Commons - https://phabricator.wikimedia.org/T76155#792023 (10Lydia_Pintscher) [16:32:31] (03PS1) 10Hoo man: Also propagate moves/deletions from non-Wikibase enabled namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176290 [16:33:29] hoo: I guess it needs to go up one more dir [16:33:37] hoo: can you add ../ and see if it works? [16:34:31] JeroenDeDauw: yeah, one second [16:35:13] (03CR) 10Hoo man: "Tackled my comments in a follow-up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [16:36:05] $ phpunit -c vendor/wikibase/data-model [16:36:05] Not an entry point. [16:36:08] wtf [16:36:12] JeroenDeDauw: ^ [16:36:42] how [16:36:50] Right [16:37:01] This will work if you include it into a component like QueryEngine... [16:37:06] But if it depends on MW... [16:37:33] hoo: if you want to include it via an install that has something that depends on MW, you need to use the MW test runner I guess [16:37:58] Yeah, I don't see a way around this [16:38:43] 3MediaWiki-extensions-WikidataRepo: allow statements on properties - https://phabricator.wikimedia.org/T51554#792044 (10Lydia_Pintscher) [16:38:49] meh [16:39:38] $ php phpunit.php ../../extensions/Wikibase/vendor/wikibase/data-model/ [16:39:38] PHP Fatal error: Class 'Wikibase\Test\HashArray\HashArrayElement' not found in /var/www/html/mwt/wiki/extensions/Wikibase/vendor/wikibase/data-model/tests/unit/HashArray/HashArrayWithDuplicatesTest.php on line 23 [16:39:46] 3MediaWiki-extensions-WikidataRepo: Stop using Property::getClaims in PropertyView - https://phabricator.wikimedia.org/T75278#792045 (10Lydia_Pintscher) [16:42:29] hoo: yeah, you need to have the classes loaded. And if you have the thing installed in WB, loading the autoloader will also cause the WB entry points to be loaded, which will bail when MW is not loaded [16:43:34] 3MediaWiki-extensions-WikidataRepo: Rollout of statements on properties with old serialization code - https://phabricator.wikimedia.org/T74314#792051 (10Lydia_Pintscher) [16:43:35] 3MediaWiki-extensions-WikidataRepo: allow statements on properties - https://phabricator.wikimedia.org/T51554#792053 (10Lydia_Pintscher) [16:44:15] Thiemo_WMDE: Lydia_WMDE DanielK_WMDE__ hoo omnomnomnom? [16:44:22] [13DataValues] 15thiemowmde created 06invalidConstructor (+1 new commit): 02http://git.io/RGJ9nA [16:44:22] 13DataValues/06invalidConstructor 147294463 15Thiemo Mättig: Fix non-consistent constructor tests [16:44:28] JeroenDeDauw: not for me :) [16:44:42] JeroenDeDauw: order something? like now? then I'm in. [16:46:18] Thiemo_WMDE: yes [16:46:31] Thiemo_WMDE: you want this merged right? https://github.com/DataValues/DataValues/pull/13 [16:46:36] [13DataValues] 15JeroenDeDauw opened pull request #13: Fix non-consistent constructor tests (06master...06invalidConstructor) 02http://git.io/8Q0KSw [16:48:27] (03PS2) 10Daniel Kinzler: Use an EntityIdFormatter for statement properties [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [16:48:38] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement properties [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [16:49:15] hoo: you will just have to run the tests as follows: https://asciinema.org/a/12530 [16:49:29] But oh wait... evil Thiemo_WMDE and evil Lydia_WMDE happened... :<0 [16:49:43] muahahahaha [16:50:09] Lydia_WMDE: Thiemo_WMDE I'm just going to bring back the-real-master branch and put the cat on there! [16:50:27] JeroenDeDauw: futile! resistance is [16:50:29] :P [16:51:05] Lydia_WMDE: you are no match for the power of the Nyan-side! [16:51:14] sure am! :P [16:51:23] i have cookies [16:51:23] [citation needed] [16:51:36] [neutrality disputed] [16:52:06] [13DataValues] 15thiemowmde 04force-pushed 06invalidConstructor from 147294463 to 14698dbf1: 02http://git.io/8CiHaQ [16:52:06] 13DataValues/06invalidConstructor 14698dbf1 15Thiemo Mättig: Fix non-consistent constructor tests [16:54:14] [13Number] 15thiemowmde created 06invalidConstructor (+1 new commit): 02http://git.io/bGzBZA [16:54:14] 13Number/06invalidConstructor 1407bb783 15Thiemo Mättig: Fix non-consistent constructor tests [16:54:43] (03PS5) 10Jeroen De Dauw: [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 [16:54:45] (03PS7) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [16:54:50] (03PS7) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [16:55:01] (03PS6) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [16:55:05] (03PS6) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [16:55:50] Thiemo_WMDE: https://github.com/DataValues/Number/compare/invalidConstructor?expand=1 [16:55:51] ;p [16:55:53] [13Number] 15thiemowmde opened pull request #16: Fix non-consistent constructor tests (06master...06invalidConstructor) 02http://git.io/gEES_A [16:58:30] Thiemo_WMDE: can you follow up on https://github.com/wmde/WikibaseDataModel/issues/310 ? [16:58:50] Thiemo_WMDE: can you also answer my question here? https://github.com/wmde/WikibaseDataModel/issues/315 [16:59:16] [13DataValues] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/UiTEqg [16:59:16] 13DataValues/06master 14f666222 15Jeroen De Dauw: Merge pull request #13 from DataValues/invalidConstructor... [17:00:51] Thiemo_WMDE: http://www.lieferando.de/lieferservice-pizza-bulls-hohenstaufen-berlin#! [17:01:03] jzerebecki: food ^] [17:01:17] (03CR) 10Daniel Kinzler: [C: 04-1] "This should at least check that both ItemView and PropertyView show a section for statements, etc." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176268 (owner: 10Adrian Lang) [17:01:23] [13DataValues] 15thiemowmde 04force-pushed 06equals from 14614458c to 141bcae0c: 02http://git.io/QTM04g [17:01:23] 13DataValues/06equals 141bcae0c 15Thiemo Mättig: Reworked all equals methods [17:02:00] (03PS3) 10Daniel Kinzler: Use an EntityIdFormatter for statement properties [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [17:02:09] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement properties [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:02:50] [13Number] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/0kxdDw [17:02:50] 13Number/06master 14cde5bf3 15Jeroen De Dauw: Merge pull request #16 from DataValues/invalidConstructor... [17:03:32] (03PS4) 10Daniel Kinzler: Use an EntityIdFormatter for statement properties [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [17:03:41] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement properties [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:05:17] 3MediaWiki-extensions-WikidataClient, Wikimedia-Wikidata: Wikibase badges (tracking) - https://phabricator.wikimedia.org/T42810#792070 (10Lydia_Pintscher) [17:06:08] [13DataValues] 15thiemowmde created 06101 (+1 new commit): 02http://git.io/9U3m9A [17:06:08] 13DataValues/06101 146eafc87 15Thiemo Mättig: Release 1.0.1 [17:07:57] 3MediaWiki-extensions-WikidataRepo: JS error when choosing a badge-item that is a deleted item - https://phabricator.wikimedia.org/T76151#792072 (10Lydia_Pintscher) [17:08:53] [13Number] 15thiemowmde 04force-pushed 06numberDoc from 14562d8bb to 140df1f6b: 02http://git.io/kRmIRQ [17:08:53] 13Number/06numberDoc 140df1f6b 15Thiemo Mättig: Fix broken @see in doc [17:09:35] [13Number] 15thiemowmde 04force-pushed 06optUses from 148c32c30 to 14cfeeec3: 02http://git.io/fpcmCw [17:09:35] 13Number/06optUses 14cfeeec3 15Thiemo Mättig: Optimize all use clauses [17:10:15] [13Number] 15thiemowmde 04force-pushed 06equals from 14260ed58 to 1483d6581: 02http://git.io/a2kD5w [17:10:15] 13Number/06equals 1483d6581 15Thiemo Mättig: Reworked all equals methods [17:10:55] [13Number] 15thiemowmde 04force-pushed 06bootstrap from 14e0689b5 to 14324b777: 02http://git.io/bJlV1A [17:10:55] 13Number/06bootstrap 14324b777 15jeroendedauw: Update PHPUnit bootstrap [17:11:08] [13DataValues] 15JeroenDeDauw closed pull request #14: Release 1.0.1 (06master...06101) 02http://git.io/3uU1gA [17:20:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [17:21:01] [13WikibaseDataModel] 15JeroenDeDauw created 063.0.x-dev from 06master (+0 new commits): 02http://git.io/tGwXnQ [17:21:06] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [17:21:53] [13WikibaseDataModel] 15JeroenDeDauw reopened pull request #268: Stop Statement requiring a Claim (06master...06claimMess) 02http://git.io/pDZU6A [17:22:38] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [17:23:01] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [17:23:47] [13Common] 15thiemowmde 04force-pushed 06covers from 142427a3a to 143889d97: 02http://git.io/s__fZQ [17:23:47] 13Common/06covers 143889d97 15Thiemo Mättig: Add missing @covers tags [17:23:49] (03CR) 10jenkins-bot: [V: 04-1] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [17:25:27] [13Geo] 15thiemowmde 04force-pushed 06edgeCase from 140e95212 to 149636417: 02http://git.io/q9v6AA [17:25:27] 13Geo/06edgeCase 149636417 15Thiemo Mättig: Add edge case to GlobeCoordinateParserTest [17:25:30] wmde/WikibaseDataModel/3.0.x-dev/842b3aa : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42329308 [17:26:29] [13ValueView] 15snaterlicious pushed 1 new commit to 06documentation: 02http://git.io/T44RuQ [17:26:29] 13ValueView/06documentation 14be4e68e 15snaterlicious: Updated code documentation [17:30:06] [13ValueView] 15snaterlicious opened pull request #133: Documentation update (06master...06documentation) 02http://git.io/RPNaBw [17:32:36] [13Geo] 15thiemowmde 04force-pushed 06killGeo from 14a54a776 to 14312ee6b: 02http://git.io/x1aUoQ [17:32:36] 13Geo/06killGeo 14312ee6b 15Thiemo Mättig: Stop calling LatLong stuff GeoCoordinate [17:38:34] [13DataValues] 15thiemowmde 04force-pushed 06equals from 141bcae0c to 144af83b2: 02http://git.io/QTM04g [17:38:34] 13DataValues/06equals 144af83b2 15Thiemo Mättig: Reworked all equals methods [17:40:23] 3MediaWiki-extensions-WikidataClient: mw.wikibase: Use __index to lazy load entity contents - https://phabricator.wikimedia.org/T76156#792081 (10hoo) [17:41:13] 3MediaWiki-extensions-WikidataClient: mw.wikibase: Use __index to lazy load entity contents - https://phabricator.wikimedia.org/T76156#792081 (10hoo) [17:53:01] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06claimMess from 1462e353e to 1426448c9: 02http://git.io/z2aTgQ [17:53:01] 13WikibaseDataModel/06claimMess 1426448c9 15Thiemo Mättig: Stop Statement requiring a Claim [17:53:49] [13WikibaseDataModel] 15JeroenDeDauw created 06removeClaim (+4 new commits): 02http://git.io/Z3bgNA [17:53:49] 13WikibaseDataModel/06removeClaim 141432566 15Thiemo Mättig: Stop Statement requiring a Claim [17:53:49] 13WikibaseDataModel/06removeClaim 14aad01c6 15jeroendedauw: Make previous commit work against current master [17:53:49] 13WikibaseDataModel/06removeClaim 14e722aab 15jeroendedauw: Bump version to 3.0.x-dev [17:54:06] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #316: Remove claim (06master...06removeClaim) 02http://git.io/huPPTA [17:54:14] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #316: Remove claim (06master...06removeClaim) 02http://git.io/huPPTA [17:54:22] [13WikibaseDataModel] 15JeroenDeDauw created 06removeClaim (+4 new commits): 02http://git.io/Z3bgNA [17:54:22] 13WikibaseDataModel/06removeClaim 141432566 15Thiemo Mättig: Stop Statement requiring a Claim [17:54:22] 13WikibaseDataModel/06removeClaim 14aad01c6 15jeroendedauw: Make previous commit work against current master [17:54:23] 13WikibaseDataModel/06removeClaim 14e722aab 15jeroendedauw: Bump version to 3.0.x-dev [17:54:51] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #317: Remove claim (063.0.x-dev...06removeClaim) 02http://git.io/yTqRVg [17:55:16] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06claimMess at 1426448c9: 02http://git.io/VQf02w [18:00:18] wmde/WikibaseDataModel/removeClaim/a3fad0d : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42332172 [18:03:25] wmde/WikibaseDataModel/claimMess/26448c9 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/42332132 [18:08:42] wmde/WikibaseDataModel/removeClaim/a3fad0d : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42332272 [18:09:36] Thiemo_WMDE: REVIEEEEEEEEEEEEEEEEEEEW https://github.com/wmde/WikibaseDataModel/pull/317 [18:10:26] Not today. I wanted to leave an hour before. [18:11:03] I still don't get it why you objected my change for weeks and now doing it all yourself in an hour. [18:11:56] Thiemo_WMDE: because the things I did on top of your change negate the concerns I had [18:12:11] Not that we cant start working on a 3.0 branch but this does not make the much needed discussions obsolete. [18:12:48] Thiemo_WMDE: what discussions are you talking about? [18:13:05] All of them. [18:13:54] I'm not sure how this PR could possibly make all discussions obsolete. I can only think of a single PR that would do that: removing all the code [19:42:30] 3MediaWiki-extensions-WikidataClient: Preload labels for Lua and the parser function based on usage tracking data - https://phabricator.wikimedia.org/T76159#792133 (10hoo) [20:01:26] (03Abandoned) 10Aude: Factor out property link formatting from view code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174750 (owner: 10Aude) [20:58:27] (03PS7) 10Aude: Extract onLinkBegin hook handling into separate class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 [20:59:36] (03PS8) 10Aude: Extract onLinkBegin hook handling into separate class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 [21:06:54] (03CR) 10jenkins-bot: [V: 04-1] Extract onLinkBegin hook handling into separate class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 (owner: 10Aude) [21:09:53] (03PS9) 10Aude: Extract onLinkBegin hook handling into separate class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 [21:17:51] (03PS10) 10Aude: Extract onLinkBegin hook handling into separate class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 [21:18:05] aude: Btw, we enabled statements on properties on test today :) [21:20:25] hoo|away: yay [21:23:34] my patch for linkbegin is to cover the current code [21:23:49] then we'll want to use an entity retrieving term lookup there [21:40:45] https://www.kickstarter.com/projects/rdohms/the-amsterdamphp-elephpant :) [21:41:04] if we don't have enough at the office yet [21:50:06] (03Abandoned) 10Aude: Use SiteStoreFactory in top-level factories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174992 (owner: 10Aude) [21:57:15] How does the language fallback decide which language to fall back to? [22:13:19] I think I will just merge https://gerrit.wikimedia.org/r/#/c/174874/ if nobody puts a -2 on it