[01:12:39] https://www.wikidata.org/wiki/Q18638636 [01:12:42] no... [01:12:44] so sad [04:33:35] (03PS1) 10Ori.livneh: Instruct Composer not to prepend its autoloader [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/179867 [04:49:43] (03Abandoned) 10Ori.livneh: Instruct Composer not to prepend its autoloader [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/179867 (owner: 10Ori.livneh) [04:59:31] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/JUhp7g [04:59:31] 13WikidataBuildResources/06master 145e81f4b 15Katie Filbert: Update / fix link in readme [05:35:14] (03Draft1) 10Aude: add i18n support for ApiClientInfo module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179868 [08:47:12] (03PS2) 10Henning Snater: Moved accessing mw config variable out of entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177209 [08:50:48] (03PS2) 10Henning Snater: Implemented $.util.getDirectionality [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177213 [08:51:22] (03PS2) 10Henning Snater: Apply "lang" and "dir" attributes to aliases input boxes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 [09:47:15] Tobi_WMDE_SW: Guten Tag. I am going to upgrade composer on the wikimedia Jenkins [09:47:18] https://gerrit.wikimedia.org/r/#/c/178550/ [09:54:46] hashar: any problems to expect? [09:55:27] Tobi_WMDE_SW: some composer based job to die horribly ? :-D [09:56:11] hashar: let's hope not.. ;) [09:56:35] (03PS8) 10Thiemo Mättig (WMDE): Small clean ups in EntityParserOutputGenerator related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 [09:56:43] we will see on that patch [09:58:56] seems good [10:19:48] (03PS1) 10Thiemo Mättig (WMDE): Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 [10:40:28] (03PS2) 10Thiemo Mättig (WMDE): Clean up ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178465 [10:42:37] Tobi_WMDE_SW: https://lists.wikimedia.org/pipermail/wikidata-tech/2014-November/000674.html has been unanswered so far. can you or should someone else? [10:42:53] DanielK_WMDE: Tobi_WMDE_SW: joining daily via hangout or not? [10:56:40] Lydia_WMDE: answered. [10:56:52] Tobi_WMDE_SW: thanks! [10:58:38] Tobi_WMDE_SW, Lydia_WMDE: sorry, missed it. Will be online after lunch. [10:58:45] np [11:01:03] Tobi_WMDE_SW: the focus issue we're backporting a patch for. does that have tests now? worth opening a ticket if not? [11:02:34] Lydia_WMDE: it is very hard to write tests for element focus.. it would often fail of unrelated issues. not sure how useful it would be.. [11:02:42] ok [11:02:49] so we don't have tests currently [11:03:02] but I think there is a task for it (rather old..) [11:03:21] k [11:03:28] would need some research about how to best do it [11:03:43] k [11:04:08] we have no control about how the browser behaves on the instance the tests are running.. so it could just loose focus just because.. [11:05:00] back then we had qunit tests for focus, and we were executing them with selenium. and AFAIR they always failed [11:05:34] we still have the qunit tests but we are no longer running them with selenium.. but at least we have some tests [11:05:50] *nod* [11:05:51] thx [11:18:58] (03CR) 10Aude: [C: 032] Clean up ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178465 (owner: 10Thiemo Mättig (WMDE)) [11:22:31] can anyone open http://tinyurl.com/mythologicalRelation ? [11:24:29] nope [11:25:36] damn [11:25:53] Ugh, asking why a redirect needs to be deleted. "No need for redirect." -_- [11:25:54] i am looking for this really nice visualization of the relations of greek gods and godesses [11:26:01] based on wikidata [11:26:04] <3 [11:26:04] and i can't find it [11:26:07] :( [11:27:15] (03CR) 10Aude: [C: 032] Small clean ups in EntityParserOutputGenerator related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 (owner: 10Thiemo Mättig (WMDE)) [11:28:20] (03Merged) 10jenkins-bot: Clean up ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178465 (owner: 10Thiemo Mättig (WMDE)) [11:30:43] (03PS1) 10Aude: Remove unused method param in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179890 [11:31:01] (03Merged) 10jenkins-bot: Small clean ups in EntityParserOutputGenerator related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 (owner: 10Thiemo Mättig (WMDE)) [11:32:38] (03CR) 10Aude: [C: 032] Fall back to page title if wikibase-titletext is n/a [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179135 (owner: 10Thiemo Mättig (WMDE)) [11:32:55] (03CR) 10jenkins-bot: [V: 04-1] Fall back to page title if wikibase-titletext is n/a [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179135 (owner: 10Thiemo Mättig (WMDE)) [11:32:59] aaah [11:36:15] (03PS1) 10Aude: Defer entity deserialization [extensions/Wikibase] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179893 [11:42:35] (03PS4) 10Thiemo Mättig (WMDE): Fall back to page title if wikibase-titletext is n/a [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179135 [11:42:51] (03CR) 10jenkins-bot: [V: 04-1] Fall back to page title if wikibase-titletext is n/a [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179135 (owner: 10Thiemo Mättig (WMDE)) [11:44:42] (03PS5) 10Thiemo Mättig (WMDE): Fall back to page title if wikibase-titletext is n/a [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179135 [11:45:50] (03CR) 10Aude: [C: 032] Defer entity deserialization [extensions/Wikibase] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179893 (owner: 10Aude) [11:46:05] (03PS1) 10Aude: Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179895 [11:51:31] Hm. It's kind of stuck. https://gerrit.wikimedia.org/r/#/c/179469/ [11:51:50] sjoerddebruin: ? [11:52:00] https://wikitech.wikimedia.org/wiki/Deployments#Week_of_December_15th :) [11:52:23] Ah. :D [11:52:29] https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=138048&oldid=138027 [11:52:45] Any update on the database itself btw? [11:52:48] bad things would happen if i deployed it during the weekend [11:52:55] i think hoo was working on it [11:53:02] (03Merged) 10jenkins-bot: Defer entity deserialization [extensions/Wikibase] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179893 (owner: 10Aude) [11:53:23] Yeah, but things didn't go flawless I thought. [11:53:51] need to ask when he is around [11:54:12] But it should be great to do it this week. [11:54:18] should be possible [11:54:30] (03CR) 10Aude: [C: 032] Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179895 (owner: 10Aude) [11:54:57] Otherwise I need to wait two weeks... Am I right? :( [11:54:59] (03CR) 10Aude: [C: 032] Fall back to page title if wikibase-titletext is n/a [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179135 (owner: 10Thiemo Mättig (WMDE)) [11:55:03] yeah [12:01:27] (03Merged) 10jenkins-bot: Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179895 (owner: 10Aude) [12:01:31] (03Merged) 10jenkins-bot: Fall back to page title if wikibase-titletext is n/a [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179135 (owner: 10Thiemo Mättig (WMDE)) [12:07:23] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12/719ebb2 : daniel The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44077756 [12:33:47] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/12/15 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/179901 [12:34:10] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/12/15 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/179901 (owner: 10Tobias Gritschacher) [12:37:29] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/12/15 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/179901 (owner: 10Tobias Gritschacher) [12:59:31] (03PS1) 10Aude: Update Wikidata, update site links ui and improve page view performance [extensions/Wikidata] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179904 [13:05:14] (03CR) 10Aude: [C: 032] Update Wikidata, update site links ui and improve page view performance [extensions/Wikidata] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179904 (owner: 10Aude) [13:07:02] (03Merged) 10jenkins-bot: Update Wikidata, update site links ui and improve page view performance [extensions/Wikidata] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179904 (owner: 10Aude) [13:09:26] (03PS1) 10Daniel Kinzler: Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 [13:11:37] aude: --^ [13:12:02] hm [13:12:07] shall take a look [13:13:16] when we implement some of this stuff based on elastic, i don't want to have to implement the entire termindex interface when [13:13:53] only want to use it for part of it [13:14:09] * aude welcomes trimming though :) [13:14:18] (03CR) 10jenkins-bot: [V: 04-1] Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 (owner: 10Daniel Kinzler) [13:17:09] "interface TermIndex extends LabelConflictFinder" [13:17:23] would be a good place to start to split those [13:18:53] (03CR) 10Daniel Kinzler: "@aude: TermIndex needs splitting up, yes. TermSqlIndex needs it even more. I have started to remove some redundant cruft here: I47098dd316" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [13:20:07] aude: uh... I didn't realize the inferfaces inherit. i don't see a good reason for that. [13:20:30] * aude realizes it might have seemed a good idea at the time, back in 2012 [13:20:40] no good reason for it though [13:24:32] (03PS2) 10Aude: Apply LanguageFallback (variants) for getLabel in lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178422 [13:29:21] anyone got time to look at two translation issues? https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikibase-time-precision-Mannum/sv and https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikibase-api-no-such-sitelink/en [13:30:02] (03PS1) 10Daniel Kinzler: TermIndex should not extend LabelConflictFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 [13:30:42] (03PS2) 10Thiemo Mättig (WMDE): Rework WikibaseRepo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 [13:30:45] (03PS2) 10Daniel Kinzler: Allow filtering by term type in getTermsOfEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 [13:30:47] (03PS2) 10Daniel Kinzler: Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 [13:30:49] (03PS2) 10Daniel Kinzler: TermIndex should not extend LabelConflictFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 [13:31:24] aude: --^ [13:31:30] yay [13:32:13] but not yay for the chain becoming long :/ [13:37:40] (03CR) 10jenkins-bot: [V: 04-1] Rework WikibaseRepo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 (owner: 10Thiemo Mättig (WMDE)) [13:37:51] (03CR) 10jenkins-bot: [V: 04-1] Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 (owner: 10Daniel Kinzler) [13:38:36] (03CR) 10jenkins-bot: [V: 04-1] TermIndex should not extend LabelConflictFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 (owner: 10Daniel Kinzler) [13:42:15] (03PS1) 10Henning Snater: Removed visible white space from sitelinkview template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179910 [13:42:17] (03PS1) 10Henning Snater: sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 [13:43:05] "visible white space" oh the irony [13:43:52] (03PS3) 10Daniel Kinzler: Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 [13:43:59] (03PS2) 10Henning Snater: Removed visible white space from sitelinkview template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179910 [13:44:38] (03PS3) 10Daniel Kinzler: TermIndex should not extend LabelConflictFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 [13:50:38] (03CR) 10jenkins-bot: [V: 04-1] sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [13:52:47] (03PS3) 10Aude: Apply LanguageFallback (variants) for getLabel in lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178422 [13:53:33] Lydia_WMDE: for the translate issues, i suggest make tasks in phabricator [13:53:50] k [13:53:58] these might need some investigation to figure out best way to handle [13:54:15] like the do not translate ones [13:56:07] (03CR) 10Aude: "test case indeed fails for me if i try it on master" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178422 (owner: 10Aude) [13:56:31] we probably want to backport https://gerrit.wikimedia.org/r/#/c/178422/ [13:56:43] since it is a regression, although somewhat odd no one has reported it yet [13:58:24] (03CR) 10Aude: [C: 031] "looks good and trivial enough :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 (owner: 10Daniel Kinzler) [14:05:55] Tobi_WMDE_SW: https://phabricator.wikimedia.org/T71901 <- still relevant? if so can you clarify what this is about exactly? [14:10:43] Lydia_WMDE: yea, think it is not valid anymore [14:10:50] ok closing [14:11:05] bah you are faster :P [14:12:43] (03PS1) 10Henning Snater: Updated sitelinkview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179913 [14:13:20] (03PS2) 10Henning Snater: sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 [14:14:37] Lydia_WMDE: https://phabricator.wikimedia.org/T76244 can be closed I think [14:14:47] the remove-icon is disabled in that case [14:14:58] I have some data in RDF that I'd like to contribute to wikidata. how can I do that? [14:15:11] it's too much to add it all by hand (and bots are silly). [14:15:17] Tobi_WMDE_SW: it is disabled but i think it should be removed completely [14:15:31] it is a dead button atm that doesn't say in any way that it is one [14:15:35] (actually, triples in Turtle, not RDF) [14:15:55] I can adjust my properties to Wikidata's ontology. [14:16:45] Lydia_WMDE: don't think it should be removed [14:16:56] it gets enabled as soon as the sitelink is valid [14:17:17] then it should have a disabled state [14:17:18] would be very shaky if the remove button gets inserted suddenly [14:17:25] shown in gray or something [14:17:39] Lydia_WMDE: yeah, styling should be better [14:17:59] but that's a completely different task than the one I mentioned [14:18:45] so either the task needs to be renamed or it should be closed and a new one crated [14:18:57] i'll rename it [14:19:06] (03PS1) 10Daniel Kinzler: Cache type ahead results for short prefixes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179914 [14:23:05] (03PS4) 10Daniel Kinzler: TermIndex should not extend LabelConflictFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 [14:23:22] aude: ^-- rebased directly on master. just merge? [14:23:29] thanks [14:25:05] (03PS2) 10Henning Snater: Updated sitelinkview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179913 [14:25:14] BenB: if you want to do it yourself, you'll probably want to use a framework like pywikibot or wikidata-toolkit [14:25:25] BenB speak English here [14:25:27] though i don't know whether wikidata-toolkit supports editing yet [14:25:38] Doc_Taxon: I did [14:26:19] Doc_Taxon: o_O wikidata is a multilingual project. english is usually most useful, but by no means required. [14:26:43] meinte ich ja [14:26:54] * BenB changes to C++ as language [14:27:02] BenB hat irgendwas vor [14:27:18] DanielK_WMDE - du kannst ihm da sicher weiterhelfen [14:27:19] BenB: i'd recommend to upload your data, or a part of it, somewhere for people to look at it. then write about it on the wikidata-l mailing list. [14:27:37] Doc_Taxon: I have data about persons and places in a very specific domain that are hand-verified and that I'd like to contribute [14:27:56] contribute please! [14:28:07] DanielK_WMDE: it's currently 800 persons and 300 places, and growing. [14:28:09] ...and perhaps on https://www.wikidata.org/wiki/Wikidata:Project_chat and maybe https://www.wikidata.org/wiki/Wikidata_talk:Bots [14:28:09] with sources. [14:28:31] maybe there's a page more dedicated to data import, Lydia_WMDE may know [14:28:54] the bots page is the place to go [14:29:11] DanielK_WMDE: it's a very specific domain, so I'm not sure anybody would be interested to really look at it. [14:29:13] https://www.wikidata.org/wiki/Wikidata:Bots [14:29:30] BenB: you still need to go through the approval process there if it is a larger import [14:29:33] BenB hat irgendwie Aversionen gegen Bots [14:29:49] BenB: i'm pretty sure they would be happy to discuss mappings etc. note that wikidata's model doesn't map to rdf easily though [14:29:56] DanielK_WMDE: all I'm asking: wikidata is essentially a triple store (like RDF). there is RDF export (which is good and necessary). there should be an RDF/turtle import, too. [14:30:21] BenB: nope, it'S not a triple store. the data model is very different. there is an incomplete rdf export. [14:30:24] Doc_Taxon: yeah, a bot feel like translating C++ to English and back to C++. [14:30:36] Doc_Taxon: wikidata is a triple store, I have a triple store. [14:30:47] can't help [14:30:51] http://korrekt.org/papers/Wikidata-RDF-export-2014.pdf [14:30:52] Doc_Taxon: thanks [14:30:53] BenB: an RDF import would also be possible, but not in bulk. bulk imports into wikis break the community process. [14:31:04] (03PS3) 10Henning Snater: Updated sitelinkview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179913 [14:31:10] !admin talk to an admin [14:31:44] DanielK_WMDE: bulk and community are not enemies. [14:31:45] BenB: wikidata doesn't use rdf's data model, nor does it use a triple store. have a look at https://meta.wikimedia.org/wiki/Wikidata/Notes/Data_model_primer [14:32:15] BenB: no, of course - mass uploads etc are fine, if discussed in advanced and adjusted as appropriate [14:32:30] DanielK_WMDE: let's say I want to get the data about Star Trek from memory-alpha into wiki, and I had the rights to it. it makes no sense to manually enter every single entity and property [14:32:31] the way to leave the community in control is to make individual edits for individaul additions [14:32:33] by bot [14:33:12] BenB: of course not. you can use the editentity API. that'S what the bots use. It'S based on a JSON structure [14:33:21] (03CR) 10Aude: [C: 032] TermIndex should not extend LabelConflictFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 (owner: 10Daniel Kinzler) [14:33:24] (03PS4) 10Aude: Apply LanguageFallback (variants) for getLabel in lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178422 [14:33:25] ah, now we're getting somewhere. [14:33:38] BenB: plain imports between wikis don't work, because you need mappings for all internal ID references [14:33:48] which is why the standard wiki import is disabled for data items. [14:33:59] (03PS1) 10Thiemo Mättig (WMDE): Rework importInterlang/Properties maintainance scripts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179915 [14:34:00] DanielK_WMDE: yeah, I'd map my properties to your ontology. [14:34:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Stop using deprecated methods in importInterlang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176317 (owner: 10Jeroen De Dauw) [14:34:18] BenB: and for that editentity api, there are client side frameworks. like pywikibot. [14:35:00] DanielK_WMDE: I'd rather take a clean HTTP REST API than a framework, because that means I need to write my side in another language. [14:35:02] BenB: a lot of bots here do some sort of data mapping/importing [14:35:07] talk to the folks who run them [14:35:24] DanielK_WMDE: where is the editentity API defined and documented? [14:35:30] BenB: unless there is a framework for your language. but fair enough [14:36:11] MediaWIki's API modules are self-documenting. The documentation isn't great, but generally, wbeditentity will accept the form of input that wbgetentities returns. [14:36:44] BenB: https://www.wikidata.org/w/api.php?action=help&modules=wbeditentity [14:36:50] https://www.wikidata.org/w/api.php?action=help&modules=wbgetentities [14:37:15] BenB: the API sendbox is quite useful: https://www.wikidata.org/wiki/Special:ApiSandbox [14:37:30] note that you'll need to get an edit token from action=tokens [14:37:37] and approval from the community [14:37:42] of course [14:37:45] ;-) [14:37:49] well, not for sandbox edits [14:37:56] bit for a bulk import, definitly [14:38:02] *but [14:38:24] Tobi_WMDE_SW: https://phabricator.wikimedia.org/T71526 and https://phabricator.wikimedia.org/T71524 <- what's the status there? [14:38:25] BenB: there's also a sandbox item to play around with: https://www.wikidata.org/wiki/Q4115189 [14:39:20] or test.wikidata.org [14:39:22] aude: can we close https://phabricator.wikimedia.org/T73295? [14:39:38] Lydia_WMDE: yes [14:39:57] although i see blocking bugs not closed [14:40:19] yeah we keep them open [14:40:21] which are probalby only issues with tests [14:40:28] no need for the tracking bug anymore imho [14:40:29] (03Merged) 10jenkins-bot: TermIndex should not extend LabelConflictFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 (owner: 10Daniel Kinzler) [14:40:29] but should be looked into [14:40:31] ok [14:41:10] Lydia_WMDE: https://phabricator.wikimedia.org/T71526 can be closed i think. at least it seems the hhvm build is not failing anymore.. https://travis-ci.org/wmde/WikibaseQueryEngine [14:41:20] cool [14:41:54] (03Merged) 10jenkins-bot: Stop using deprecated methods in importInterlang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176317 (owner: 10Jeroen De Dauw) [14:41:59] (03PS4) 10Henning Snater: Updated sitelinkview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179913 [14:43:09] Lydia_WMDE: https://phabricator.wikimedia.org/T71524 still needs some work. as jzerebecki commented. [14:43:23] k [14:43:33] DanielK_WMDE: I've already found https://meta.wikimedia.org/wiki/Wikidata/Notes/Data_model_primer , but it's dead. It links to a category, so the page is gone. [14:44:31] BenB: sorry for the old link. as the page sais, it was moved to https://www.mediawiki.org/wiki/Wikibase/DataModel/Primer [14:44:49] which is not quite as up to date as it could be, but still largely correct [14:45:16] DanielK_WMDE: ah. at the bottom, it says "Category: Moved to MediaWiki", and I clicked on that link, which just gave a categoy. [14:47:05] [13WikibaseQueryEngine] 15tobijat created 06hhvm_build (+1 new commit): 02http://git.io/zaXRkg [14:47:05] 13WikibaseQueryEngine/06hhvm_build 1459ce6e2 15Tobias Gritschacher: Don't allow HHVM build to fail... [14:47:16] I've been monkey-trained to ignore these big boxes on the top of wiki pages :) [14:47:21] [13WikibaseQueryEngine] 15tobijat opened pull request #141: Don't allow HHVM build to fail (06master...06hhvm_build) 02http://git.io/cC22pQ [14:48:46] BenB: maybe start reading at the top :) [14:49:17] yea, "banner blindness"... [14:53:53] (03CR) 10Daniel Kinzler: Implementing prefetching on top of TermIndex. (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [14:57:45] (03CR) 10Aude: Implementing prefetching on top of TermIndex. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [14:58:49] (03CR) 10Aude: Implementing prefetching on top of TermIndex. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [15:09:19] (03CR) 10Daniel Kinzler: Implementing prefetching on top of TermIndex. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [15:09:50] (03CR) 10Daniel Kinzler: Implementing prefetching on top of TermIndex. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [15:12:00] anyone know what became of the idea of a Quotations project using wikidata? http://www.w3.org/wiki/WebSchemas/QuotationSchema -> https://meta.wikimedia.org/wiki/Structured_Wikiquote [15:13:02] aude, could there be more GCI tasks? I think https://phabricator.wikimedia.org/T77021 or https://phabricator.wikimedia.org/T66549 might make good ones! [15:13:11] danbrithere's a lot of things that could be improved using a structured data approach, i'm afraid we can't tackle all at once [15:13:26] hi unicodesnowman [15:13:41] hi :) [15:16:06] for javascript-related tasks, i need to talk to lydia [15:16:09] danbri: the next thing on the mid term roadmap is meta-data for media files on commons. what will come after that is not decided yet, but wiktionary is also a candidate [15:16:14] DanielK_WMDE - yup, entirely agree. I had some chat at the London Wikimania with people enthusiastic to do quotes, thought it about time I followed up (if I can find the twitter convo...) [15:16:39] i haven't heard anything since around that time. [15:16:42] I work on schema.org so I had it in mind as an example of an area where different groups might collab of common schemas [15:16:44] * danbri nods, thanks [15:16:45] it's important we can have someone review patches in a timely manner, which i'm not sure we can [15:17:05] danbri: generally, mapping vocabularies is easy, mappings structures is hard... [15:17:43] anything that needs more structure imposed by the software than what we have on wikidata will need quite a bit of coding. [15:18:44] for https://phabricator.wikimedia.org/T66549, we really don't have a version for the "build" [15:19:19] aude: just the build's commit hash? or branch name? [15:19:58] we don't show branch name but show a very old hash (for which there is a bug about) [15:20:41] https://phabricator.wikimedia.org/T74759 [15:21:02] danbri: yes, in my database, I have plenty of quotations are sources, too. [15:21:26] wmde/WikibaseQueryEngine/hhvm_build/59ce6e2 : Tobias Gritschacher The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/44092458 [15:21:31] danbri: I would absolutely need to be able to point to a specific paragraph in the work, not just the whole work, as source. [15:21:35] oh, I see [15:21:44] (sources that cite a whole book are entirely useless anyway) [15:22:05] danbri: this isn't possible right now? [15:22:48] unicodesnowman: if you want to work on https://gerrit.wikimedia.org/r/#/c/170025/1/make-wmf-branch/MakeWmfBranch.php, i would welcome that [15:23:04] it's very archaic, wmf specific script [15:23:24] i think it needs to check if "$preservedRefs[$name]" is a valid branch [15:23:34] if not, do the old behavior [15:23:36] or something [15:23:53] I'm not sure what's possible right now in wikidata. As far as schema.org schemas we have nothing yet for that use case but there's definitely interest. And folk in W3C's http://www.w3.org/annotation/ group are also v interested by this [15:25:27] BenB, danbri: wikidata citations are largely free-form, you can cite on any level. on the sownside, this means there is no schema, and not too many conventions yet. [15:25:49] unicodesnowman: or another task would be ok (preferably non-js, since i don't feel as qualified to review it or ask lydia) [15:25:49] (by "free form" i mean that you can use any combinations of properties, not "free text") [15:28:36] aude, I don't think I have a clue about that, sorry; I'll look for tasks, I'm pretty interested in wikibase after reading ray kurzweil's 'how to create a mind' [15:29:28] unicodesnowman: ok [15:35:22] (03PS1) 10Thiemo Mättig (WMDE): Rework and clean up TermIndex interfaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 [15:36:18] aude, what about https://phabricator.wikimedia.org/T66593 ? [15:36:31] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "All my comments are already fixed in my follow up Ie0d92ae. Please have a look and pick what you want, or simply +2 my patch and I will +2" (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 (owner: 10Daniel Kinzler) [15:38:07] unicodesnowman: might be good though not sure how easy [15:38:11] ask DanielK_WMDE [15:40:51] (03CR) 10Thiemo Mättig (WMDE): TermIndex should not extend LabelConflictFinder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179909 (owner: 10Daniel Kinzler) [15:41:21] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up TermIndex interfaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 (owner: 10Thiemo Mättig (WMDE)) [15:41:22] unicodesnowman: looking quickly at the code, i see we have a "SnakConstructionService" [15:41:34] that is used, in at least some api modules [15:42:00] that might be the place where it would go to handle converting the precisions [15:42:32] aude: Do you have an opinion on https://github.com/Wikidata-lib/PropertySuggester-Python/pull/15 ? If so, could you add to it, so that I can iterate over that PR later on? :) [15:42:35] Would be awesome [15:43:31] hoo: logging module sounds good to me ,though would also be ok as a follow up [15:43:38] with task added in phabricator [15:45:09] tyvm, will try to orient myself among the codebase [15:45:44] ok [15:46:05] unicodesnowman: i would definitely want daniel's opinion before you get too far [15:46:29] then can add it as a GCI task [15:46:51] (03PS1) 10Thiemo Mättig (WMDE): Drop useless docs from Store interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179937 [15:49:34] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Correct wrong jshint config name [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [15:49:52] DanielK_WMDE, when you have the time, could you please look into the difficulty of https://phabricator.wikimedia.org/T66593 and if it's be suitable as a GCI task? if so, could you please give me some pointers on a good approach? thanks :) [15:50:12] (03CR) 10Thiemo Mättig (WMDE): "It's just an other, probably more useful metric. Yes, the commit message is wrong, but if Adrian thinks this is better I'm fine with it." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [15:54:57] (03CR) 10Thiemo Mättig (WMDE): [C: 032] getEntitiesByPage: Always submit "normalize" parameter if specified [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177508 (owner: 10Henning Snater) [15:55:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 (owner: 10Henning Snater) [15:57:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Added RepoApi tests for functions not yet tested [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 (owner: 10Henning Snater) [15:58:28] (03PS11) 10Henning Snater: Removed jQuery.wikibase.claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178869 [15:58:41] aude: DanielK_WMDE: Confirmed my flights yesterday, I'm going to have Saturday and Sunday totally spare [15:58:45] + Friday evening [15:58:58] yay [15:59:05] * aude doesn't know until the last minute [16:02:05] [13WikibaseQueryEngine] 15JeroenDeDauw 04deleted 06hhvm_build at 1459ce6e2: 02http://git.io/P0x4IQ [16:07:43] (03PS2) 10Thiemo Mättig (WMDE): Rework and clean up TermIndex interfaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 [16:09:19] (03PS3) 10Thiemo Mättig (WMDE): Rework WikibaseRepo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 [16:14:45] Tobi_WMDE_SW: we updated test wikidata with changes backported on friday [16:14:52] seems some site link stuff is missing [16:14:59] https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/extensions/Wikibase,n,z [16:15:48] do we also need https://gerrit.wikimedia.org/r/#/c/176668/ https://gerrit.wikimedia.org/r/#/c/177186/ and [16:15:52] https://gerrit.wikimedia.org/r/#/c/178502/ [16:16:16] maybe https://gerrit.wikimedia.org/r/#/c/179467/ also? [16:16:32] (03CR) 10jenkins-bot: [V: 04-1] Rework WikibaseRepo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 (owner: 10Thiemo Mättig (WMDE)) [16:16:45] Henning_WMDE: do you know? [16:16:52] which patches should be in the branch? [16:17:17] aude: I don't see any sitelink patches backported.. https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/extensions/Wikibase+branch:wmf/1.25wmf12,n,z [16:17:22] ah [16:17:29] only focus stuff [16:17:31] which ones are needed? [16:17:37] aude: see my email [16:17:45] I talked to Jan on Friday about that. [16:17:51] ok [16:18:04] https://www.irccloud.com/pastebin/G8Cm4vUc [16:18:10] aude: ^^ [16:18:21] ok [16:18:40] We came to the conclusion to not backport site link changes as there was no formal approval by PM. [16:19:32] Lydia_WMDE: ^^ [16:20:01] but also the half-finished stuff was not taken out as I outlined in my email, Henning_WMDE [16:20:23] doing neither the one or the other was the worst that could be done [16:20:23] Henning_WMDE: Who's we? [16:20:48] hoo: See my comment just above. [16:21:07] You and Jan? [16:21:08] Jan said he would take out that one change. [16:21:36] hm, seems that did not happen [16:21:44] Jan and me. [16:22:19] to be not confused, i would need to manually try each patch locally (cherry picked into the branch) [16:22:51] it might be that some were already in before we brancehd? [16:23:00] Maybe [16:23:00] from Jan's reply to my email: " But Katie or Marius decide, as they would be deploying it." [16:24:54] So he just passed on... :) [16:25:17] it's okay to backport [16:25:45] just that i'll have to do later (when i get home, after eating...) and manually verify [16:25:46] Even if the cahnges are large/ risky we don't really have an option [16:25:50] yeah [16:25:53] testing locally in advance is a must, though [16:26:25] * aude was somehow confused and thought jan cherry picked the site link patches too [16:26:45] Happens :S [16:26:49] :) [16:28:17] (03CR) 10Thiemo Mättig (WMDE): Added type checks to wikibase.api.RepoApi functions (038 comments) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [16:28:23] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [16:31:07] hoo: https://gerrit.wikimedia.org/r/#/c/178422/ would also be nice to put in the branch [16:31:45] aude: Is the other patch already in? [16:31:51] The SerializationOption one [16:32:38] i think that was merged [16:32:52] Yeah, I merged it, but not sure it was before we cut the branch [16:32:58] not sure [16:35:02] (03CR) 10Hoo man: [C: 032] "Test for the Lua side of this would have been nice, but this is good enough for now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178422 (owner: 10Aude) [16:36:34] * aude eats [16:36:42] back later [16:36:48] Hopefully not that change :D [16:36:50] see you [16:36:56] cu aude [16:41:12] Lydia_WMDE: wow [16:41:19] hoo: ? [16:41:24] Your mail [16:41:28] going to be a mess :S [16:41:31] hoo: sorry :( [16:41:38] (03Merged) 10jenkins-bot: Apply LanguageFallback (variants) for getLabel in lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178422 (owner: 10Aude) [16:41:43] Maybe we should just skip wmf12 then? [16:41:44] but i fear the mess will be bigger if we deploy either of those versions [16:42:02] And built a wmf11 with perf. + Lua stuffs? [16:42:03] hoo: that's another option but we'd miss language fallbacks and property datatype [16:42:14] If stuff is small, we can backport [16:42:31] *nod* [16:42:40] we can push language fallback if necessary [16:42:46] property datatype would be good to have [16:45:33] aude: ^ [16:45:48] hoo: think doing it this way would be easier? [16:46:13] It would work w/o large breakage [16:46:25] (03PS3) 10Henning Snater: Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 [16:46:25] but aude should decide, I'm not going to have much time to work this week [16:47:00] needs to finish a university practicum stuff until Thursday [16:47:27] k [16:48:02] I might already have finished that, but the software wont run on my notebook [16:48:16] some kind of libQt segfault *rage* [16:48:28] (it's a proprietary mess) [17:00:27] oh ffs [17:01:18] (03PS3) 10Tobias Gritschacher: sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [17:01:28] looks like I need to use my netbook... [17:01:29] -.- [17:02:04] (03PS4) 10Thiemo Mättig (WMDE): Rework WikibaseRepo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 [17:03:12] (03CR) 10Tobias Gritschacher: [C: 031] "Nice!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179913 (owner: 10Henning Snater) [17:14:41] (03CR) 10Tobias Gritschacher: [C: 04-1] "It seems there is still a small problem with long page-names:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [17:20:15] (03CR) 10Henning Snater: "Works for me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [17:32:00] what do you think about the lmowiki link here: https://www.wikidata.org/wiki/Q2918584 ? is it about the same thing as other links? [17:45:34] (03CR) 10Tobias Gritschacher: "Could be dependent on the screen resolution. Tried on a 1600x900 screen. Will try on different resolutions tomorrow." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [18:31:25] Hi. [18:38:00] Any non admin user: could you check if you can edit the [[Hitler]] page? [18:43:15] Non-admins... Hm... [18:43:18] item btw ;) [18:43:56] sjoerddebruin: we need to know if the bug is exceptionnal for Dereckson or not... [18:44:08] Yeah, but let's find a non-admin... [18:45:10] I'll ask on the #wikidata-fr chan [18:45:39] s/[[Hitler]] page/[[Q352]] item [18:48:43] Can't repro the bug, other users could edit. [18:49:14] Dereckson: seems like you're the one with the problem... [18:50:18] Dereckson: as confirmed user have the same rights than autoconfirmed ones, and you were already autoconfirmed, I don't know why you couldn't edit [18:51:21] The joys of computing... [18:51:42] It's why we needed to check if the issue is reproducible or not before to open a ticket. [20:12:36] aude: Lydia_WMDE: So... what are you going to do with the branch? I'm not seeing any backports [20:13:40] hoo: if we can revert to the old site links ui, that might be best [20:13:44] * aude looking [20:18:56] :( [20:20:28] sjoerddebruin: better than something incomplete [20:20:43] Yeah, but it always sounds :( [20:20:47] :/ [20:27:08] aude: Would be nice to get it out to test tonight [20:27:16] so that we can play with it on beta for a bit tomorrow [20:27:37] I'll be around for the train tomorrow, but probably only standby (doing other stuff... unless something breaks) [20:27:44] ok [21:23:29] (03CR) 10Daniel Kinzler: Allow filtering by term type in getTermsOfEntities (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 (owner: 10Daniel Kinzler) [22:49:45] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12b/8ee18cb : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44145518 [22:55:29] Lydia_WMDE: hoo i am lookign at what changes to exclude on the branch [22:56:09] seems not practical to find all of the changes to remove and cleanly revert for site links ui [22:56:19] and error prone [22:56:33] ok [22:56:39] so we go with old branch? [22:56:40] staying on the old branch but cherry pickign things in we want is also challenging [22:56:51] mpfh [22:56:52] damn [22:56:58] old branch still has loading hundreds of entities for labels [22:57:32] i foudn the point where the site link ui change was first introduced [22:57:58] we might be able to pick maybe the build from the day before, which at least has some of the performance things [22:58:24] ok [22:58:32] and might be able to cherry pick a few key things there [22:58:38] do you think it'd help you to go through them with tobi together tomorrow? [22:58:40] what i suggest, otherwise old branch [22:58:45] ok [22:58:47] it might [22:58:51] that's fine with me [22:58:58] i tried reverting but get conflicts [22:59:02] *nod* [22:59:18] yikes [22:59:18] ok [22:59:25] * aude see if i can get this ready for swat [22:59:28] aude: Can we get that branch finished tonight [22:59:35] yes [22:59:58] :) [23:00:00] <3 [23:00:06] in the future (i realize not nicest for working), maybe big ui changes can go on a branch? [23:00:15] and then be merged when ready? [23:00:24] so we avoid this in the future [23:00:41] yeah the issue was a lot of refactoring for this but you are right this is a pita [23:00:48] we should consider that [23:22:04] * aude is going to flood the channel :/ [23:22:23] mostly things already backported [23:22:25] give it to us! :P [23:22:30] :) [23:23:26] https://gerrit.wikimedia.org/r/#/c/175987/ is the commit before sitelinks change, so is the base [23:30:14] * aude manually verifying [23:30:29] \o/ [23:30:43] hope the focus fixes can go in [23:34:01] aude: They can [23:34:07] I already merged them for the wmf12 branch [23:34:10] the original one [23:34:27] hoo: if they are clean onto the point i am taking for this branch [23:34:38] probably can somehow [23:34:51] here comes the spam [23:34:51] mh, they should... I think they were small and not touching much [23:34:55] good [23:35:02] (03PS1) 10Aude: Initialize claims on entities whenever a claimlistview exists [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180050 [23:35:04] (03PS1) 10Aude: Add messages for Statement on Property related edit summaries [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180051 [23:35:06] (03PS1) 10Aude: Add getApiBasedValueFormatterConstructor dependency on wikibase [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180052 [23:35:08] (03PS1) 10Aude: Don't load all sites for LangLinkHandler [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180053 [23:35:10] (03PS1) 10Aude: Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180054 [23:35:12] (03PS1) 10Aude: Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180055 [23:35:14] (03PS1) 10Aude: Reduce other projects sidebar initialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180056 [23:35:16] (03PS1) 10Aude: Clone cached tables before returning them to users in mw.wikibase [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180057 [23:35:18] (03PS1) 10Aude: Cache the "otherProjectsLinks" setting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180058 [23:35:20] (03PS1) 10Aude: USE INDEX(wb_epp_entity) in EntityPerPageTable::listEntities [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180059 [23:35:22] (03PS1) 10Aude: Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180060 [23:35:24] (03PS1) 10Aude: No language fallback when serializing wbEntity. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180061 [23:35:26] (03PS1) 10Aude: Introduce DataType for refs to Properties. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180062 [23:35:28] (03PS1) 10Aude: Don't instantiate ParserAfterParseHookHandler for interface msg parse [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180063 [23:35:30] (03PS1) 10Aude: Defer entity deserialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180064 [23:35:32] (03PS1) 10Aude: Use same SidebarHookHandlers instance during request [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180065 [23:35:34] (03PS1) 10Aude: Use one instance of SerializationOptions in WikibaseLuaBindings [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180066 [23:35:36] (03PS1) 10Aude: Avoid fatal in ParserAfterParser hook handling [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180067 [23:35:38] (03PS1) 10Aude: Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180068 [23:36:36] https://gerrit.wikimedia.org/r/#/c/178999/ is not a clean cherry pick but would like it in [23:36:45] should be easy [23:37:11] Yep... and that class has tests [23:37:11] (03PS1) 10Aude: Apply LanguageFallback (variants) for getLabel in lua [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180069 [23:37:29] these are all the performance things [23:37:47] that are clean enough to put in (e.g. LinkBegin is too much to try to put in) [23:38:12] but includes reusing EntityInfo for term lookup [23:38:56] should be good enough for now [23:39:06] most important part was to fix sites on client, and that's mostly done [23:39:16] sure [23:39:35] especially as itwiki wants it default now [23:39:44] and rumors, frwiki wants it [23:39:56] the beta feature [23:40:02] We didn't see any issues on ruwiki with that, so should be fine [23:40:08] yeah [23:40:58] * aude waits for jenkins [23:41:03] this might take a while :/ [23:42:45] heh, yeah :P [23:43:35] (03CR) 10Aude: [C: 032] Initialize claims on entities whenever a claimlistview exists [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180050 (owner: 10Aude) [23:43:48] (03CR) 10Aude: [C: 032] Add messages for Statement on Property related edit summaries [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180051 (owner: 10Aude) [23:43:59] (03CR) 10Aude: [C: 032] Don't load all sites for LangLinkHandler [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180053 (owner: 10Aude) [23:44:24] (03CR) 10Aude: [C: 032] Add getApiBasedValueFormatterConstructor dependency on wikibase [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180052 (owner: 10Aude) [23:47:02] (03CR) 10Aude: [C: 032] Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180054 (owner: 10Aude) [23:47:25] (03CR) 10Aude: [C: 032] Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180055 (owner: 10Aude) [23:47:34] (03CR) 10Aude: [C: 032] Reduce other projects sidebar initialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180056 (owner: 10Aude) [23:48:37] (03CR) 10Aude: [C: 032] Clone cached tables before returning them to users in mw.wikibase [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180057 (owner: 10Aude) [23:49:22] (03Merged) 10jenkins-bot: Initialize claims on entities whenever a claimlistview exists [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180050 (owner: 10Aude) [23:50:58] (03Merged) 10jenkins-bot: Add messages for Statement on Property related edit summaries [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180051 (owner: 10Aude) [23:52:00] (03CR) 10Aude: [C: 032] Cache the "otherProjectsLinks" setting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180058 (owner: 10Aude) [23:53:14] (03CR) 10Aude: [C: 032] USE INDEX(wb_epp_entity) in EntityPerPageTable::listEntities [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180059 (owner: 10Aude) [23:54:38] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12c/208b308 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44147571 [23:55:44] (03Merged) 10jenkins-bot: Add getApiBasedValueFormatterConstructor dependency on wikibase [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180052 (owner: 10Aude) [23:55:46] (03Merged) 10jenkins-bot: Don't load all sites for LangLinkHandler [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180053 (owner: 10Aude) [23:55:49] (03Merged) 10jenkins-bot: Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180054 (owner: 10Aude) [23:55:51] (03CR) 10jenkins-bot: [V: 04-1] Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180055 (owner: 10Aude) [23:55:53] (03CR) 10jenkins-bot: [V: 04-1] Reduce other projects sidebar initialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180056 (owner: 10Aude) [23:55:55] (03CR) 10jenkins-bot: [V: 04-1] Clone cached tables before returning them to users in mw.wikibase [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180057 (owner: 10Aude) [23:55:57] (03CR) 10jenkins-bot: [V: 04-1] Cache the "otherProjectsLinks" setting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180058 (owner: 10Aude) [23:55:59] (03CR) 10jenkins-bot: [V: 04-1] USE INDEX(wb_epp_entity) in EntityPerPageTable::listEntities [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180059 (owner: 10Aude) [23:56:44] meh [23:56:47] jenkins bot is lying [23:57:15] (03CR) 10Hoo man: [C: 032 V: 032] Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180055 (owner: 10Aude) [23:58:26] aaaa [23:58:35] * aude trying to get the focus patches in