[00:02:54] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#972502 (10Smalyshev) I am logged in, language is English. [00:07:19] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#972517 (10Addshore) Okay! This now sounds very odd! :D Any chance you could take and upload a screenshot? [00:27:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#972539 (10Smalyshev) {F28271} [00:29:57] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#972540 (10Smalyshev) If I log out, the "31 September" still shows. [01:18:58] 3MediaWiki-API, Wikidata, MediaWiki-Page-editing: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#972630 (10aaron) @daniel: what do you think of https://gerrit.wikimedia.org/r/184463. Would be hard to build off? I'd really like to get stashing on again, since it saves 3... [06:29:55] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Automatically drop redundant sitelink to redirect when merging in wbmergeitems api module - https://phabricator.wikimedia.org/T85347#972796 (10petr.matas) >>! In T85347#970670, @Addshore wrote: > The case you have just described should not / can not happen. It... [06:41:08] 3Wikidata, Wikidata.org: JS error: "unrecognized expression: unsupported pseudo: wikibase-statementview" on old revisions of items - https://phabricator.wikimedia.org/T85804#972798 (10petr.matas) Adding jquery.wikibase.entityview as a dependency to https://www.wikidata.org/wiki/MediaWiki:Gadgets-definition shoul... [07:27:53] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Data type on Property page is formatted slightly strange on test.wikidata - https://phabricator.wikimedia.org/T86618#972823 (10aude) [07:46:23] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#972847 (10Addshore) All I was miss understanding the issue, I thought that literally only "31 September" was showing. The DataValue in questions is as follows and should in... [07:46:48] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#972848 (10Addshore) p:5Triage>3Normal [08:14:32] 3MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§, Wikidata: AuthorityControl gadget broken with Wikibase (Uncaught TypeError: undefined is not a function) - https://phabricator.wikimedia.org/T86155#972915 (10aude) I updated the gadget (synced new code from Wikidata) and tried to apply the ch... [08:16:26] Lydia_WMDE: It's too wide here. http://gyazo.com/a7aaa340b0e58f93cca67e83b160635b [08:17:07] sjoerddebruin: mpfh. noted [08:17:08] thx [08:17:33] Hope it can be fixed before the deploy tonight... [08:18:14] not sure tbh. will have to see [08:18:19] 3Wikidata.org, Wikidata: JS error: "unrecognized expression: unsupported pseudo: wikibase-statementview" on old revisions of items - https://phabricator.wikimedia.org/T85804#972921 (10aude) adding jquery.wikibase.entityview seems to work (at least no longer get the js error, though nothing linked). ps: some add... [08:18:22] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#972922 (10Smalyshev) Yes, that's what I meant, sorry my explanation was a bit confusing. [08:18:26] it should only happen if your window is rather narrow [08:18:30] so rare hopefully [08:18:38] still need to fix of course [08:18:52] Seems like the hardcoded width of .wikibase-sitelinkgrouplistview is the problem [08:19:25] k [08:19:41] Henning_WMDE: Tobi_WMDE_SW ^ [08:22:11] sjoerddebruin: hmm, volunteers to help re-seed WDQ? :) [08:22:22] (03PS1) 10Adrian Lang: Fix various spaces and some trailing commas in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184576 [08:22:28] haven’t scripted it, not sure if I’ll get the time to this week [08:22:48] YuviPanda: hm, what can I do? [08:23:07] sjoerddebruin: it’s mostly just a small set of commands to execute + a lot of waiting (few hours) [08:23:18] sjoerddebruin: are you comfortable with the commandline? do you have a labs account? [08:24:09] Sort of... I think I've got one... [08:24:41] [13WikibaseDataModelJavaScript] 15adrianheine pushed 1 new commit to 06master: 02http://git.io/7fWT2Q [08:24:41] 13WikibaseDataModelJavaScript/06master 144a72249 15Adrian Heine né Lang: Merge pull request #18 from wmde/remoteExtPathParts... [08:24:41] sjoerddebruin: let me know what it is and I can get you started :) [08:24:47] [13WikibaseDataModelJavaScript] 15adrianheine 04deleted 06remoteExtPathParts at 146d29061: 02http://git.io/chzv9g [08:30:55] (03CR) 10Adrian Lang: "PlainEntityIdFormatter it is. EntityIdValueFormatter is implemented by PlainEntityIdFormatter via ValueFormatterBase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180431 (owner: 10Adrian Lang) [08:31:29] (03PS2) 10Adrian Lang: Correct type hint from ValueFormatter to EntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183233 [08:31:31] (03PS2) 10Adrian Lang: Introduce EntityIdFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180431 [08:35:51] (03CR) 10jenkins-bot: [V: 04-1] Correct type hint from ValueFormatter to EntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183233 (owner: 10Adrian Lang) [08:36:02] (03CR) 10Henning Snater: [C: 032] Fix various spaces and some trailing commas in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184576 (owner: 10Adrian Lang) [08:37:45] (03PS1) 10Henning Snater: entitytermsview: Fix table header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 [08:40:38] (03Merged) 10jenkins-bot: Fix various spaces and some trailing commas in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184576 (owner: 10Adrian Lang) [08:47:59] YuviPanda: sended you a query. [08:48:42] sjoerddebruin: yeah some internet troubles on laptop I'll brb [08:48:59] ok [09:20:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: Unit Localization - https://phabricator.wikimedia.org/T86528#973007 (10adrianheine) I know I made this point several times, but I haven't seen it addressed or debunked yet, so I'll continue to do so: I think we limit ourselves by not allowing us to write... [09:23:36] 3Wikibase-JavaScript-Api, Wikidata, Wikidata-Sprint-2015-01-08§: Fix Job for running QUnit tests on Jenkins - https://phabricator.wikimedia.org/T86176#962893 (10adrianheine) @krinkle @hashar started reviewing this. [09:28:12] 3Wikidata, MediaWiki-extensions-WikibaseRepository: update documentation of js data model - https://phabricator.wikimedia.org/T75606#973031 (10JanZerebecki) [09:34:29] Tobi_WMDE_SW: quite a few tasks with patches that are not in the sprint: https://phabricator.wikimedia.org/maniphest/query/wTLlJe_Snwu2/ a few of them being worked on in this sprint [09:39:04] jzerebecki: "being worked on" in the sense of "being reviewed"? [09:39:32] jzerebecki: as in the patch was created by someone in the office in this sprint [09:40:35] what do you think, might as well add it to the sprint? [09:40:40] Tobi_WMDE_SW: ^ [09:41:29] 3Wikidata: Make it possible to force a protocol in the populateSitesTable.php maintenance script - https://phabricator.wikimedia.org/T85755#973057 (10JanZerebecki) [09:43:40] 3DataValues-JavaScript, Wikidata: Remove "index" related options from claim related jQuery.wikibase.***view widgets - https://phabricator.wikimedia.org/T58050#973061 (10JanZerebecki) [09:46:21] 3Wikidata-Sprint-2015-01-08§, Wikidata, MediaWiki-extensions-WikibaseRepository: New serialization code needs to support language fallback - https://phabricator.wikimedia.org/T74183#973064 (10JanZerebecki) [09:48:06] 3Wikidata, MediaWiki-extensions-WikibaseRepository: deep copy of Entity is made when calling Revision::getContent() - https://phabricator.wikimedia.org/T74158#973067 (10JanZerebecki) [09:48:55] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Implement Entity::copy more efficiently - https://phabricator.wikimedia.org/T78266#973075 (10JanZerebecki) [09:49:42] removed patch-for-review from those where any linked patches were merged [09:50:16] jzerebecki: for urgent bug fixes this is not necessary [09:51:44] jzerebecki: I guess you then better close the relkated task than remove the patch-to-review tag [09:52:33] http://wikidata.beta.wmflabs.org/wiki/Special:RecentChanges is sad :( [09:53:48] reeeeview https://gerrit.wikimedia.org/r/#/c/184330/ ! [09:53:56] !merge 184330 [09:53:56] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/184330/ [10:09:05] (03PS1) 10Adrian Lang: Add jscs and npm config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184591 [10:09:46] Henning_WMDE: ^^ [10:14:24] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Why pass information twice, it's already there as far as I can see. Could be that I'm just confused." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) (owner: 10Aude) [10:22:20] 3Wikidata, Wikidata-Sprint-2015-01-08§, MediaWiki-extensions-WikibaseRepository: Move JS and PHP view code to separate repo - https://phabricator.wikimedia.org/T75020#973122 (10adrianheine) https://gerrit.wikimedia.org/r/#/c/180431/ and https://gerrit.wikimedia.org/r/#/c/180450/. After that, Wikibase\Repo\View s... [10:23:30] (03CR) 10Daniel Kinzler: Fix undefined EntityId in BufferingTermLookup (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) (owner: 10Aude) [10:32:48] (03PS8) 10Aude: Fix undefined EntityId in BufferingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) [10:33:02] 3Wikidata, MediaWiki-extensions-WikibaseRepository: update documentation of js data model - https://phabricator.wikimedia.org/T75606#973131 (10JanZerebecki) Generating the documentation is the next step. [10:33:27] (03CR) 10Aude: Fix undefined EntityId in BufferingTermLookup (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) (owner: 10Aude) [10:34:39] (03CR) 10Adrian Lang: [C: 032] Removed toolbarcontroller toolbar restrictions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180423 (owner: 10Henning Snater) [10:36:24] 3Wikimedia-Site-requests, Wikidata: Convert all `sites` tables to use https URLs - https://phabricator.wikimedia.org/T85754#973134 (10JanZerebecki) [10:36:26] 3Wikidata: Make it possible to force a protocol in the populateSitesTable.php maintenance script - https://phabricator.wikimedia.org/T85755#973133 (10JanZerebecki) 5Open>3Resolved [10:37:20] (03Merged) 10jenkins-bot: Removed toolbarcontroller toolbar restrictions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180423 (owner: 10Henning Snater) [10:40:36] (03CR) 10Aude: [C: 04-1] Add summary for Special:ItemDisambiguation and Special:GoToLinkedPage (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183490 (https://phabricator.wikimedia.org/T86165) (owner: 10Lucie Kaffee) [10:44:08] 3MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§, Wikidata: Have multi-line descriptions - https://phabricator.wikimedia.org/T86192#973137 (10adrianheine) [10:45:20] 3MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§, Wikidata: Have multi-line descriptions - https://phabricator.wikimedia.org/T86192#963109 (10adrianheine) [10:48:15] (03PS4) 10Adrian Lang: Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) (owner: 10Henning Snater) [10:48:24] (03CR) 10jenkins-bot: [V: 04-1] Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) (owner: 10Henning Snater) [10:56:28] jzerebecki: https://gerrit.wikimedia.org/r/#/c/184002/1 [11:01:28] 3Wikibase-JavaScript-Api, Wikidata, Wikidata-Sprint-2015-01-08§: Fix Job for running WBJSAPI QUnit tests on Jenkins - https://phabricator.wikimedia.org/T86176#973163 (10adrianheine) [11:05:27] YuviPanda: Still connection problems? [11:13:29] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I could +2 this because it does what it should do, but I miss a test and I'm not happy with some method signatures and implementation deta" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) (owner: 10Aude) [11:22:33] 3Wikidata, Wikimedia-Site-requests: Convert all `sites` tables to use https URLs - https://phabricator.wikimedia.org/T85754#973187 (10JanZerebecki) The original problem was that it did choke on the redirect from http to https instead of following it. Which is probably OK for this use case. Using https URLs will... [11:34:45] 3Wikidata, Wikimedia-Site-requests: Convert all `sites` tables to use https URLs - https://phabricator.wikimedia.org/T85754#973191 (10hoo) The only problem we had was that URLs in the sitelink view (on repo) suddenly became https (instead of protocol relative), that could pose a problem for users that aren't abl... [12:06:09] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant) - https://phabricator.wikimedia.org/T74590#973231 (10adrianheine) These are all not present in neither of core/includes/Names.php, Cldr, UniversalLanguageSelector/data/lan... [12:07:30] 3MediaWiki-extensions-WikibaseRepository, Wikidata: monolingual text does not accept sr-cyrl and a number of other language codes - https://phabricator.wikimedia.org/T74126#973233 (10adrianheine) This issue has nothing to do with the Norwegian languages, because they are not supported by either of the data sourc... [12:10:57] 3MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§, Wikidata: AuthorityControl gadget broken with Wikibase (Uncaught TypeError: undefined is not a function) - https://phabricator.wikimedia.org/T86155#973237 (10Tobi_WMDE_SW) @aude: https://test.wikidata.org/wiki/MediaWiki:Gadget-AuthorityContro... [12:12:39] 3MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§, Wikidata: AuthorityControl gadget broken with Wikibase (Uncaught TypeError: undefined is not a function) - https://phabricator.wikimedia.org/T86155#973238 (10Tobi_WMDE_SW) Ok, seems the changes are applied partially. The part for getReference... [12:22:10] [13ValueView] 15adrianheine created 06uls (+1 new commit): 02http://git.io/JhtcJA [12:22:10] 13ValueView/06uls 1432dc6bc 15Adrian Heine: Use same languages as the Wikibase backend does... [12:24:16] [13ValueView] 15adrianheine 04force-pushed 06uls from 1432dc6bc to 14dceacfc: 02http://git.io/3x0sag [12:24:16] 13ValueView/06uls 14dceacfc 15Adrian Heine: Use same languages as the Wikibase backend does... [12:24:35] [13ValueView] 15adrianheine opened pull request #144: Use same languages as the Wikibase backend does (06master...06uls) 02http://git.io/Y7_rTw [12:35:44] 3MediaWiki-extensions-WikibaseRepository, Wikidata: monolingual text does not accept sr-cyrl and a number of other language codes - https://phabricator.wikimedia.org/T74126#973286 (10adrianheine) https://github.com/wmde/ValueView/pull/144 makes the language lists used by the frontend and the backend match. That... [12:36:04] 3MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Sprint-2015-01-08§: monolingual text does not accept sr-cyrl and a number of other language codes - https://phabricator.wikimedia.org/T74126#973288 (10adrianheine) [12:44:47] lbenedix... [12:46:23] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Data type on Property page is formatted slightly strange on test.wikidata - https://phabricator.wikimedia.org/T86618#973305 (10Lydia_Pintscher) p:5Triage>3Normal [12:48:20] 3MediaWiki-Page-editing, MediaWiki-API, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#973317 (10daniel) @aaron I'm afraid that patch doesn't address the actual problem: yes, you can get around the serialization update if you rely on global state. But if you... [12:52:59] (03PS2) 10Henning Snater: entitytermsview: Fix table header and toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 [12:53:10] (03CR) 10jenkins-bot: [V: 04-1] entitytermsview: Fix table header and toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 (owner: 10Henning Snater) [12:54:58] Is that correct? [12:55:19] (03PS5) 10Henning Snater: Rearranged entity view header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183498 [12:55:26] aude: https://www.youtube.com/watch?v=7fQaj31Wtko [12:55:29] (03PS5) 10Henning Snater: Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) [12:55:35] (03PS3) 10Henning Snater: Implemented link to toggle language list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184340 (https://phabricator.wikimedia.org/T86193) [12:55:38] :) [12:59:01] (03PS3) 10Henning Snater: entitytermsview: Fix table header and toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 [12:59:11] Tobi_WMDE_SW: https://test.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js [12:59:24] they updated the gadget considerably that the initialization logic is completely different [12:59:31] think i got it right now [13:00:19] aude: think Henning_WMDE needs to check that [13:00:24] ok [13:00:41] Henning_WMDE: poke ;) [13:00:49] :D [13:01:09] they have if ( claimId === 'P368' ) { hardcoded [13:01:17] would be nice if that was better [13:02:49] 3MediaWiki-extensions-WikibaseRepository, Wikidata: UI should get list of supported languages from the backend, via dedicated resource loader module - https://phabricator.wikimedia.org/T78007#973337 (10adrianheine) Terms currently are silently limited to UI languages, since you only get the input controls for UI... [13:03:18] 3Wikidata.org, Wikidata: JS error: "unrecognized expression: unsupported pseudo: wikibase-statementview" on old revisions of items - https://phabricator.wikimedia.org/T85804#973341 (10aude) updated the gadget code more on test.wikidata https://test.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js the har... [13:03:58] Hm, looks like the ban isn't working. [13:07:10] aude: Tobi_WMDE_SW: I do not understand that new init routine. Does not really appear to make sense to just delay initialization by waiting for an API call to get all the claims that are on the page already... inheriting the assumptions that all of the page is initialized after the API request returned... [13:07:54] apparently that's how it works now [13:08:05] o_O [13:08:15] If they think that is the best way - not gonna hold them back. :) [13:08:19] that's an odd assumption to make.. [13:08:23] heh [13:09:40] *waves* [13:09:51] :) [13:14:34] !nyan | addshore [13:14:34] addshore: ~=[,,_,,]:3 [13:15:54] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#973355 (10Addshore) Okay, so when entering "31 September 1949" through the Frontend in an edit and saved it is formatted as "1 October 1949" and correctly saved as "+000000... [13:16:41] Did I ever say I hate dates and time? :D [13:18:55] * aude thought addshore loves dates :) [13:21:23] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Bad dates (like September 31) in some entries - https://phabricator.wikimedia.org/T85296#973379 (10Addshore) Indeed editing through the API allows this! See my test edit at https://www.wikidata.org/w/index.php?title=Q4115189&diff=187799522&oldid=187799194 [[... [13:23:27] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Wikibase API allows adding impossible dates such as "31 September 2014" - https://phabricator.wikimedia.org/T85296#973381 (10Addshore) [13:24:06] aude: you are incorrect :P [13:24:13] heh [13:24:36] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Data type on Property page is formatted slightly strange on test.wikidata - https://phabricator.wikimedia.org/T86618#973383 (10adrianheine) HTML class changed from wb-datatype(-value) to wikibase-propertyview-datatype(-value). I suppose the CSS was not adapted. [13:31:27] (03PS1) 10Aude: Add smoke test in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 [13:32:09] Smoke test? :O [13:32:44] else there might be fire.... [13:35:20] aude: a cozy wood fire I hope? [13:35:37] (03PS2) 10Addshore: Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [13:38:29] (03PS4) 10Henning Snater: entitytermsview: Fix table header and toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 [13:41:54] aude: JeroenDeDauw sjoerddebruin http://www.midwesternmac.com/sites/midwesternmac.com/files/devops-define-roles.jpg [13:42:05] :D [13:43:02] addshore: hehehe... [13:44:29] addshore: congraturations, you have just made an addition to my entropy folder [13:44:47] * YuviPanda stares at addshore [13:44:50] :D [13:44:57] sjoerddebruin: am back, but have to go again now :( probably won’t be able to do it today [13:45:21] YuviPanda: Tomorrow? [13:45:51] sjoerddebruin: yeah [13:45:55] I’m moving cities again tonight [13:45:58] will be stabler tomorrow [13:46:12] (03PS1) 10Henning Snater: Removed table of content bar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184629 [13:46:20] Ok. [13:48:18] 3MediaWiki-extensions-WikibaseRepository, Wikidata: UI should get list of supported languages from the backend, via dedicated resource loader module - https://phabricator.wikimedia.org/T78007#973424 (10adrianheine) Actually, the views work with `wgULSLanguages` (UI languages), but fall back on $.uls.data.languag... [13:57:16] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #334 146f21c3f: Ah, so you are putting the documentation of what the field means in the subclass here because that is where the field is defined? The issue with that is that you have the base class docs know about a subclass that it does not depend on. That is confusing for someone who is just interested in the base class. Because of this I think it's much better to document this in the de [14:03:33] 3Wikimedia-Site-requests, Wikidata: Convert all `sites` tables to use https URLs - https://phabricator.wikimedia.org/T85754#973440 (10JanZerebecki) Example from original report: https://www.wikidata.org/wiki/Q18636241 [14:03:36] 3MediaWiki-extensions-WikibaseRepository, Wikidata: UI should get list of supported languages from the backend, via dedicated resource loader module - https://phabricator.wikimedia.org/T78007#973441 (10adrianheine) [14:03:51] 3MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Sprint-2015-01-08§: monolingual text does not accept sr-cyrl and a number of other language codes - https://phabricator.wikimedia.org/T74126#973442 (10adrianheine) [14:03:56] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Mono-lingual text datatype should support "no linguistic content" and "undetermined language" - https://phabricator.wikimedia.org/T72205#973443 (10adrianheine) [14:04:04] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant) - https://phabricator.wikimedia.org/T74590#973444 (10adrianheine) [14:07:46] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Determine list of available languages in a uniform way - https://phabricator.wikimedia.org/T78006#973472 (10adrianheine) I rearranged the various tasks around this feature. This is now the tracking bug for a) supporting the same set of languages everywhere in t... [14:08:24] 3MediaWiki-extensions-WikibaseClient, Wikidata, Wikidata-Sprint-2015-01-08§: Use ArticleEditUpdates hook for usage tracking, instead of ParserAfterParse - https://phabricator.wikimedia.org/T86308#973476 (10JanZerebecki) [14:08:39] (03CR) 10Aude: Fix undefined EntityId in BufferingTermLookup (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) (owner: 10Aude) [14:08:40] aude: what initialization routine are we going to use now? the on on test? can we then also adjust this on beta please? [14:08:53] Tobi_WMDE_SW: what is on test [14:08:56] (03PS9) 10Aude: Fix undefined EntityId in BufferingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) [14:08:58] it seems on beta the gadget is not loaded/broken with debug=false (according to the tests) [14:09:08] perhaps that would fix it.. [14:09:14] what is on beta would be reverting their changes on wikidata [14:09:30] ok, so can we change it on beta? [14:09:34] sure [14:09:44] 3MediaWiki-extensions-WikibaseRepository, Wikidata: UI should get list of supported languages from the backend, via dedicated resource loader module - https://phabricator.wikimedia.org/T78007#973481 (10adrianheine) [14:09:45] should I just copy-paste from test? [14:09:49] Tobi_WMDE_SW: why are you in the kitchen? [14:10:05] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Determine list of available languages in a uniform way - https://phabricator.wikimedia.org/T78006#973488 (10adrianheine) [14:10:10] JeroenDeDauw: was sitting too long already today [14:10:38] Tobi_WMDE_SW: the gadget now uses statements on properties instead of hard coded list [14:10:41] Tobi_WMDE_SW: there is a max sitting time? [14:11:03] aude: that's great also [14:11:05] i had to add a statement for each property on test.wikidata that i wanted to be linked [14:11:21] aude: what statement is that? [14:11:22] and then there is a hard coded line [14:11:29] 'formattedURL' or such [14:11:38] https://test.wikidata.org/wiki/Property:P368 [14:12:17] aude: ok, so there seems to be a bit more work necessary for making it also work on beta.. [14:12:27] there is [14:13:17] "The class SqlStore has a coupling between objects value of 45." [14:13:19] #wat [14:14:41] (03PS10) 10Aude: Fix undefined EntityId in BufferingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) [14:14:53] (03CR) 10Adrian Lang: [V: 04-1] "Needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [14:16:41] (03CR) 10Aude: [C: 04-1] "jenkins should have failed here" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [14:17:05] 3MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2014-12-09§, Wikidata, Wikidata-Sprint-2015-01-08§: Remove-toolbar not disabled during save - https://phabricator.wikimedia.org/T76849#973495 (10adrianheine) Is there a change for this? [14:18:25] where's the Lydia_WMDE ? [14:18:45] 3MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Sprint-2015-01-08§: Batched label query for watchlists and recent changes - https://phabricator.wikimedia.org/T74310#973505 (10adrianheine) [14:18:47] aude: evil meeting in the big room closest to here [14:18:48] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Implement caching for TermLookup - https://phabricator.wikimedia.org/T76339#973502 (10adrianheine) 5Open>3Resolved a:3adrianheine Seems to be done. [14:18:56] * aude doesn't think https://phabricator.wikimedia.org/T86522 should be "considered for the next sprint" since beta is broken etc [14:19:18] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Efficient entity label lookup (tracking) - https://phabricator.wikimedia.org/T75087#973517 (10adrianheine) [14:19:19] should be added to this sprint [14:19:19] 3MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Sprint-2015-01-08§: Batched label query for watchlists and recent changes - https://phabricator.wikimedia.org/T74310#973513 (10adrianheine) 5Open>3Resolved a:3adrianheine Apparently done. [14:19:20] 3MediaWiki-extensions-WikibaseRepository, Wikidata: batch label lookups for onLinkBegin hook handling - https://phabricator.wikimedia.org/T76394#973516 (10adrianheine) [14:21:06] aude: in meetinng in big room [14:21:06] (03CR) 10Daniel Kinzler: Introduce EntityIdFormatter interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180431 (owner: 10Adrian Lang) [14:21:15] heh, ok [14:21:44] [13Diff] 15JeroenDeDauw created 06phpmd (+1 new commit): 02http://git.io/n-uSiQ [14:21:44] 13Diff/06phpmd 144df8b5d 15jeroendedauw: Add initial PHPMD support and have the CI run it against src/ [14:22:12] [13Diff] 15JeroenDeDauw opened pull request #30: Add initial PHPMD support and have the CI run it against src/ (06master...06phpmd) 02http://git.io/7jguwA [14:24:04] wmde/Diff#114 (phpmd - 4df8b5d : jeroendedauw): The build passed. [14:24:04] Change view : https://github.com/wmde/Diff/commit/4df8b5d8f4fe [14:24:04] Build details : http://travis-ci.org/wmde/Diff/builds/46856247 [14:25:15] (03PS2) 10Aude: Add smoke test in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 [14:26:27] (03CR) 10Adrian Lang: [C: 031] Introducing changes subscription infrastructure. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183839 (https://phabricator.wikimedia.org/T86184) (owner: 10Daniel Kinzler) [14:27:57] (03CR) 10jenkins-bot: [V: 04-1] Add smoke test in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [14:32:00] Tobi_WMDE_SW: https://github.com/wmde/Diff/pull/30 [14:32:52] jzerebecki: Thiemo_WMDE ^^ [14:34:43] Tobi_WMDE_SW: copied site id gadget to https://test.wikidata.org/wiki/MediaWiki:Gadget-SiteIdToInterwiki.js [14:34:56] aude: great! thx [14:34:56] it's enabled / default but doesn't seem to do anything [14:34:59] does it work? [14:35:00] not great [14:35:03] hm [14:35:05] does it work for you? [14:35:28] https://test.wikidata.org/wiki/Q16 [14:35:41] aude: ill try [14:35:45] ok [14:35:52] want to have it ready for wikidata [14:36:53] now it works [14:37:12] * aude blames caching [14:38:24] [13Diff] 15thiemowmde comment on pull request #30 144df8b5d: A limit of "under 10" methods per class? I find that extreme and not helpful. Can we please raise this? 02http://git.io/dAa7qw [14:38:30] aude: yeah, now it works for me too [14:39:03] there is a brief "flash" of the full extended ids [14:39:17] then they are short [14:39:41] aude: don't see it but remember seeing it on beta once [14:39:56] don't think it's a problem [14:40:00] Henning_WMDE: ? [14:40:01] it's ok [14:40:11] [13Diff] 15thiemowmde comment on pull request #30 144df8b5d: `$id` is an absolutely valid variable name. A "configured minimum length" of 3 is not helpful. Please don't let us start adding such weird suppress tags all over our code base. 02http://git.io/mgt4kg [14:43:13] Some flash under certain circumstances is not avoidable because the JS is initialized on the static HTML rendered already. [14:43:27] Has anyone tried "edit" -> "cancel"? [14:43:28] [13Diff] 15JeroenDeDauw comment on pull request #30 144df8b5d: I was under the impression this was really about public methods and the docs just forget to mention that. I tested now and this is wrong. It's about all methods. In which case I agree with you that this is not a good rule with value 10. It discourages splitting up methods. 02http://git.io/o2GN2A [14:44:04] Resets to full ids for me [14:44:16] :( [14:44:21] Henning_WMDE: just recognized this as well [14:44:29] is it an issue with the gadget? [14:44:39] also when adding a sitelink and clicking save [14:45:09] happens here :/ [14:45:14] when adding a link [14:46:51] (03PS3) 10Aude: Add smoke test in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 [14:49:40] (03CR) 10jenkins-bot: [V: 04-1] Add smoke test in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [14:58:17] [13Diff] 15JeroenDeDauw comment on pull request #30 144df8b5d: I did not think about `$id`. You are right that we have way to many valid usecases for the rule to be enabled then. This applies to any rule - if we need to add ignore tags to many valid usecases, then we should not enable the rule. 02http://git.io/2OIx0A [15:08:55] [13Diff] 15JeroenDeDauw 04force-pushed 06phpmd from 144df8b5d to 14cd8bb7f: 02http://git.io/WgE76A [15:08:55] 13Diff/06phpmd 14cd8bb7f 15jeroendedauw: Add initial PHPMD support and have the CI run it against src/ [15:12:50] [13WikibaseDataModel] 15thiemowmde comment on pull request #334 146f21c3f: > you are putting the documentation of what the field means in the subclass here... 02http://git.io/Uuu5iA [15:13:46] [13WikibaseDataModel] 15thiemowmde comment on pull request #334 146f21c3f: > document this in the derivative.... 02http://git.io/hLmd6w [15:13:48] (03PS2) 10Daniel Kinzler: Use ArticleEditUpdates hook for usage tracking [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) [15:16:33] (03CR) 10Daniel Kinzler: [C: 032] Narrow RdfBuilder interfaces as much as possible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176725 (owner: 10Thiemo Mättig (WMDE)) [15:17:04] (03CR) 10Daniel Kinzler: [V: 04-1] "needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [15:17:57] (03CR) 10Aude: [C: 04-1] "nitpick" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [15:18:24] (03CR) 10Aude: Use ArticleEditUpdates hook for usage tracking (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [15:19:28] (03Merged) 10jenkins-bot: Narrow RdfBuilder interfaces as much as possible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176725 (owner: 10Thiemo Mättig (WMDE)) [15:19:41] (03CR) 10Aude: Use ArticleEditUpdates hook for usage tracking (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [15:19:44] Could someone at the Wikidata-project to https://phabricator.wikimedia.org/T86673, search is still borked. [15:21:31] sjoerddebruin: add ? [15:21:44] https://phabricator.wikimedia.org/tag/wikidata/ [15:22:10] at > add [15:22:27] https://phabricator.wikimedia.org/T75737 (if you can do the js hack) [15:22:33] else, i can [15:22:46] Could try that. [15:22:48] ok [15:22:57] * aude hopes that gets fixed soon [15:23:16] It's even the 6th option!!!!! [15:23:21] heh [15:23:29] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem doesn't say in what language the label and description would be - https://phabricator.wikimedia.org/T86673#973763 (10Sjoerddebruin) [15:26:56] https://phabricator.wikimedia.org/T86522 should not be "considered for next sprint" [15:27:01] since beta is broken [15:27:06] this sprint :) [15:28:00] 3Wikidata-Sprint-2015-01-08§, Wikidata, MediaWiki-extensions-WikibaseRepository: Argument 1 passed to BufferingTermLookup::getBufferKey() must be an instance of Wikibase\DataModel\Entity\EntityId, null given - https://phabricator.wikimedia.org/T86522#973769 (10aude) [15:28:44] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #334 146f21c3f: > Yes and no. The sentence here is true with and without the subclass.... 02http://git.io/3JmQYw [15:35:43] jzerebecki: https://github.com/wmde/Diff/pull/30 [15:38:38] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #334 146f21c3f: I just saw the derivative has an `$actualLanguageCode` field. So it seems "actual" is used for two different things then? 02http://git.io/6J53fQ [15:39:46] aude: Tobi_WMDE_SW_NA: Since I am unable to change the global gadget on beta, I changed the gadget here: http://wikidata.beta.wmflabs.org/w/index.php?title=User%3ASiteIdToInterwikiCode%2Fcommon.js&diff=83136&oldid=81048 [15:44:19] (03CR) 10Daniel Kinzler: [V: 04-1] "needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180498 (owner: 10Thiemo Mättig (WMDE)) [15:46:19] (03PS2) 10Daniel Kinzler: Rework importInterlang/Properties maintainance scripts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179915 (owner: 10Thiemo Mättig (WMDE)) [15:46:27] Henning_WMDE: updated it on test.wikidata and looks good [15:46:37] cool! [15:46:57] * aude let tobi take care of beta [15:55:50] (03PS4) 10Aude: Add smoke test in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 [15:59:24] (03CR) 10jenkins-bot: [V: 04-1] Add smoke test in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [16:05:00] (03CR) 10Aude: [C: 04-2] "this is not failing in the way i expect" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [16:07:05] (03CR) 10Daniel Kinzler: Use ArticleEditUpdates hook for usage tracking (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [16:07:06] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: Unit Localization - https://phabricator.wikimedia.org/T86528#973849 (10Snaterlicious) I my opinion, specifically developing for Wikidata would be opening Pandora's box. We already have rather awkward Wikidata-specifics in the the code (Calendar types refer... [16:07:33] aude: --^^ [16:08:39] [13WikibaseDataModel] 15thiemowmde comment on pull request #334 146f21c3f: > Where in this concept is a "request" present?... 02http://git.io/OR-qCA [16:10:47] (03CR) 10Aude: Use ArticleEditUpdates hook for usage tracking (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [16:15:06] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #334 146f21c3f: > The documentation should say how it's supposed to be used.... 02http://git.io/bnFl7Q [16:15:08] (03CR) 10Aude: "it fails on travis the way i expect, and also locally with a fresh install (using example settings)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [16:26:56] (03PS1) 10Anomie: Remove long-deprecated ApiBase::getVersion() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184680 (https://phabricator.wikimedia.org/T35287) [16:38:07] jzerebecki: DanielK_WMDE: omnomnom? [16:40:31] Hi [17:07:21] Is "Date of Taxon Name Publication" supposed to be a qualifier of Taxon name? [17:10:26] Does it show up in the suggestions? [17:10:33] That's most of the times a good sign. [17:11:00] Don't think so [17:11:18] I've been adding it as a standalone reference, and I don't think that matters much [17:11:23] *statement [17:13:54] Seems like it needs to be a separate one. [17:16:40] Fair enough [17:16:56] Succu has been adding it as a qualifier [17:17:06] That's why I wondered [17:23:20] 3Wikidata-Sprint-2015-01-08§, Wikidata, MediaWiki-extensions-WikibaseRepository: Argument 1 passed to BufferingTermLookup::getBufferKey() must be an instance of Wikibase\DataModel\Entity\EntityId, null given - https://phabricator.wikimedia.org/T86522#973994 (10daniel) Strange that this didn't show up in manual t... [17:38:20] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974014 (10ori) @daniel Can you explain why this work needs to be done synchronously, blocking the user? [17:44:41] (03CR) 10Legoktm: [C: 032] Remove long-deprecated ApiBase::getVersion() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184680 (https://phabricator.wikimedia.org/T35287) (owner: 10Anomie) [17:50:25] (03Merged) 10jenkins-bot: Remove long-deprecated ApiBase::getVersion() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184680 (https://phabricator.wikimedia.org/T35287) (owner: 10Anomie) [17:55:44] (03CR) 10Daniel Kinzler: [C: 032] Fix undefined EntityId in BufferingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) (owner: 10Aude) [18:08:09] Lydia_WMDE: http://altlasten.lutz.donnerhacke.de/mitarb/lutz/usenet/yesterday.html [18:10:10] (03Merged) 10jenkins-bot: Fix undefined EntityId in BufferingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184330 (https://phabricator.wikimedia.org/T86522) (owner: 10Aude) [18:14:31] Lydia_WMDE: https://meta.wikimedia.org/wiki/Grants:PEG/Europeana/GLAMwiki_Toolset#Prepare_for_structured_metadata [18:14:50] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/184627/ [18:15:00] any idea what is wrong there? [18:15:31] i expect results like https://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/jobs/46869028 [18:17:09] DanielK_WMDE: https://phabricator.wikimedia.org/T86305 [18:24:04] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974085 (10daniel) @ori: simply be cause there is currently no mechanism (as far as I know) for extensions to provide deferred updated. Only some specific hard-coded update... [18:25:02] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974086 (10ori) @daniel, thanks for clarifying. Could you also explain (in practical terms) what are the updates being performed? [18:32:34] 3MediaWiki-API, MediaWiki-Page-editing, Wikidata: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#974114 (10daniel) On the client wiki, we are tracking which page uses which data item, by inserting rows into the wbc_entity_usage table. On the repo, we do similar trackin... [18:56:28] aude: no idea, fails "correctly" for me locally. code looks good too. [18:57:22] aude: the only way I can see it fail is if the label is already buffered. Which shouldn't happen, because you create a new entity [18:57:48] hm [18:59:05] (03CR) 10Daniel Kinzler: "Yea, can't figure it out either at the moment." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [18:59:25] oh, wait. [19:00:10] i have an idea [19:03:23] aude: afaik, jenkins rebases against master before running tests. so that would be why there is no error - it's fixed in master. but... then, why does it fail? if i rebase against master, the test passes. [19:03:58] (03CR) 10Daniel Kinzler: "After rebasing against master, the test passes (as it should)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184627 (owner: 10Aude) [19:05:21] it failed "incorrectly" before the fix was merged [19:05:33] i know [19:05:41] no idea why [19:06:09] i was hoping that the "incorrect" fauilure would happen after the rebase. but it doesn't. i can't reproduce it [19:06:21] intersting [19:06:49] shall do more debugging... want to be sure the test correctly and reliably would catch the issue [19:07:28] not on jenkins, apparently :/ [19:07:36] oh, hm... [19:07:55] aude: does it happen on travis using mysql? [19:08:03] no idea why that would make a difference, but... [19:08:35] i tried with sqlite and mysql [19:08:44] travis does both and also correctly [19:08:49] huh [19:11:38] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Suggesters on EntitiesWithout* don't work anymore - https://phabricator.wikimedia.org/T86647#974213 (10Lydia_Pintscher) [19:12:10] deploy time [19:12:26] gonna see about automating / improving parser cache expiry [19:12:36] seriously annoying [19:12:44] jzerebecki: is it ok to use TermFallback now? [19:12:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem doesn't say in what language the label and description would be - https://phabricator.wikimedia.org/T86673#974219 (10Lydia_Pintscher) p:5Triage>3Normal [19:13:00] (and shouldn't it be called FallbackTerm?) [19:18:35] aude: will you let me know when it is ok to make announcement? [19:18:44] ok [19:21:26] What a great deploy again [19:21:30] Labels are not short yet [19:21:32] merge is broken [19:22:32] sjoerddebruin: caches [19:24:02] yeah purging a page fixes it [19:24:08] * Lydia_WMDE hates caches [19:24:45] seems ok to me [19:24:50] idk about merge [19:25:46] yeah now it looks fine for me on random page as well [19:25:53] sjoerddebruin: merge ok after purge? [19:26:29] Yes, but I need to do it on every page again. [19:26:53] sjoerddebruin: i needed to do that too but that is fine now here [19:27:01] aude: did you poke the cache? [19:27:13] Oh, and "&uselang=nl" in the url every time. [19:27:41] sjoerddebruin: can you try setlang? [19:28:07] Tried that, didn't work. [19:29:00] "(‎Muutettu [fr]-nimi: 1 tableau)" [19:29:04] what's that 1? [19:29:14] sjoerddebruin: mpfh ok [19:29:22] 3Wikidata, MediaWiki-Parser: Add hook for extensions to bump or expire parser cache - https://phabricator.wikimedia.org/T86694#974303 (10aude) 3NEW [19:29:23] sjoerddebruin: will look into it further [19:29:27] Also random dropdown in the sidebar every time. [19:29:28] Stryn: where? [19:29:40] Lydia_WMDE: poked [19:29:45] aude: thx [19:29:49] https://www.wikidata.org/w/index.php?title=Q3928305&diff=187865228&oldid=161983108 see summary [19:29:54] sjoerddebruin: random dropdown? [19:30:00] Stryn: looking [19:30:24] https://phabricator.wikimedia.org/T86694 is what we need to do this in a more proper way [19:30:25] Yes, a language dropdown. [19:30:34] so that users don't notice (normally) [19:30:42] "(‎Added link to [fiwiki]: 1 RKI" [19:31:12] Oo [19:31:14] indeed [19:31:20] basically everywhere in recent changes [19:31:23] * aude notes the site links don't work nicely with my preview gadget [19:31:23] yep [19:31:24] Can't save statements here. https://www.wikidata.org/w/index.php?title=Q14666552 [19:31:26] After purge. [19:31:33] aude: can you have a look at recent changes? [19:31:48] sjoerddebruin: looking [19:31:48] "null" when try to add a reference to it. [19:32:17] sjoerddebruin: i can add a statement - trying reference [19:32:31] what is wrong? [19:32:36] with recent change [19:32:42] aude: 1 at the beginning of each change [19:32:58] https://www.dropbox.com/s/xrasf754itrsy8i/Schermafdruk%202015-01-13%2020.32.54.png?dl=0 :/ [19:33:18] oh [19:33:40] sjoerddebruin: trying in firefox [19:33:49] This is Safari btw. [19:33:55] ok [19:34:05] same on https://test.wikidata.org/wiki/Special:RecentChanges [19:34:56] and in history :) https://www.wikidata.org/w/index.php?title=Q4115189&action=history [19:35:17] ugh [19:35:20] Note: It is happening for all edits, including edits made before I guess you deployed [19:35:35] strange [19:35:36] sjoerddebruin: it is working for me in firefox too. could you try an incognito window or different browser please? [19:36:13] Icognito works, could be a script then. [19:36:19] Lydia_WMDE: sjoerddebruin I can also add statements and everything fine [19:36:36] [Error] Failed to load resource: the server responded with a status of 404 (Not Found) (null, line 0) https://www.wikidata.org/w/null?title=User:Bene*/userwarn.js&action=raw&ctype=text/javascript [19:37:08] * aude has only authority control gadget [19:37:34] aha! [19:37:45] This doesn't seem good. https://www.dropbox.com/s/8qa8kn0lbfk9een/Schermafdruk%202015-01-13%2020.37.37.png?dl=0 [19:37:46] there's some problems with gadgets it seems [19:38:13] yeah [19:39:03] ahahhahahaa [19:39:17] "Use of "wgUserLanguage" is deprecated. Use mw.config instead." Huh? [19:40:10] sjoerddebruin: use [19:40:20] mw.config.get( 'wgFooBar' ); [19:40:47] * aude enbles all gadgets [19:40:56] omg the preview gadget :o [19:42:01] I dont have any gadget Errors, only warnings [19:42:55] same here [19:43:34] Whole thing is borked at my side. [19:44:40] sjoerddebruin: which gadgets and with what errors? [19:46:07] TypeError: mw.config.get(...) is null index.php:11 [19:46:09] TypeError: namespace is null [19:46:27] the "1" seems to be an issue simply with display [19:46:29] in what gadget? [19:46:35] Stryn: it's null then :p [19:47:04] I have too many gadgets on, but at least the clock is not working [19:47:14] soon my head in null :) [19:47:18] is* [19:47:36] Stryn: your knowledge has always been null ;) [19:47:49] I know, thanks for reminding :) [19:48:02] My head is full of wgUserLanguage [19:48:52] Oh, seems like it's a global thing. [19:49:23] ? [19:49:45] Upload wizard etc. were also broken. [19:49:59] Fixed now on Commons [19:50:07] Where else was it broken? [19:50:14] We disabled HotCat on Commons to fix it. [19:52:52] Jup, hotcat it is. [19:54:06] Okay, now: the entity suggester seems broken Lydia_WMDE [19:54:32] -.- [19:54:34] looking [19:54:40] Only message in the console left is "Use of "wgUserName" is deprecated. Use mw.config instead." [19:55:11] that shouldn't influence the suggester [19:55:56] sjoerddebruin: ok confirmed. also not working for me [19:55:59] aude: ^ [19:56:22] no errors in console [19:56:40] hmmm [20:01:40] aude: let me know if you need help from daniel or jan. they're both sitting in the office with me still [20:01:56] oO [20:02:03] What happened? (tl;dr please) [20:02:20] 1s 1s everywhere [20:02:25] looks like https://github.com/Wikidata-lib/PropertySuggester/pull/111 is in the branch [20:02:25] mwahahahahaaa [20:03:24] some incompatibility between https://gerrit.wikimedia.org/r/#/c/182467/ and our horrible untested onFormat code is to blame for the "1" s [20:03:56] hoo|away: suggester doesn't work and we have 1s in the edit summaries everywhere [20:04:02] should be easy to fix, although the code is somewhat difficult to understand [20:04:30] (03PS1) 10Daniel Kinzler: Return Term object from LabelLookup. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184727 (https://bugzilla.wikimedia.org/86180) [20:04:30] * aude will continue looking at the edit summaries if someone looks at the suggester [20:04:33] or other way around [20:08:49] aude: looking into 1s in edit summary [20:09:33] jzerebecki: ok [20:09:47] it's on the onFormat hook [20:10:25] $pre appears to be false instead of '' [20:13:26] probably just making Linker and onFormat consistent would fix, although neither are very nice code [20:17:57] is there a place where up-to-data Wikidata data model is described? [20:21:19] *up-to-date [20:21:35] SMalyshev: unfortunately not. on our todo list to get that done [20:21:52] aude: Doh [20:22:00] ? [20:22:02] Is that patch I merged recently on the branach? [20:22:05] Lydia_WMDE: ok, thanks, then the next question - where is the most up-to-date one? :) [20:22:19] The one about summary format stuff? [20:22:30] sjoerddebruin: Michiel started removing rijksmonumenten [20:22:37] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: Unit Localization - https://phabricator.wikimedia.org/T86528#974443 (10Smalyshev) The idea of localized units is great, however I wonder about the following things. Let's say we express quantities in all kinds of different units, so if we have a property f... [20:22:40] hoo: what was it supposed to do? [20:22:45] SMalyshev: looking [20:22:46] multichill: Not the items I hope... [20:22:53] SMalyshev: looking at the code itself is probably the best bet ;p [20:23:01] Lydia_WMDE: Handle what Katie described above, I think [20:23:02] https://gerrit.wikimedia.org/r/159327 [20:23:05] https://www.wikidata.org/w/index.php?title=Q17342544&curid=18939167&diff=187876233&oldid=187514943 [20:23:23] ok [20:23:46] addshore: which code would that be? [20:24:01] SMalyshev: https://github.com/wmde/WikibaseDataModel [20:24:10] SMalyshev: https://www.mediawiki.org/wiki/Wikibase/DataModel/Primer is the most up-to-date documentation i think but yeah code is best [20:24:50] hoo: ah [20:25:17] makes sense [20:25:29] and makes sense why the issue does not happen on master [20:26:23] * aude is almost 100% that fixes [20:26:33] \o/ [20:27:44] (03PS1) 10Aude: Update FormatAutocomments hook for I36c3a9e5 [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184734 [20:27:54] addshore: not completely sure how to use that code though. E.g. if I want to know which data types exist and what each of the types can represent - where would I find that? [20:28:16] not all data types are part of the data model [20:28:21] most are not (?) [20:28:49] there is WikibaseDataTypeBuilders in wikibase lib [20:29:12] and dataTypes setting in lib [20:29:17] aude: where can I find the wikibase lib? [20:29:18] SMalyshev: https://www.wikidata.org/wiki/Special:ListDatatypes [20:29:34] https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikibase/94acf038462d7e1d9a04b0388a9716e3dcf158e9/lib [20:29:35] addshore: do you have time to look at the merge gadget being broken by chance? [20:29:43] Lydia_WMDE: maybe :P [20:29:55] where is it reported broken? [20:30:00] * aude continues looking at property suggester [20:30:05] addshore: aha, thanks. Where this list comes from? Is it supported by any code? [20:30:17] addshore: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#New_interface [20:30:21] (03CR) 10jenkins-bot: [V: 04-1] Update FormatAutocomments hook for I36c3a9e5 [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184734 (owner: 10Aude) [20:30:24] addshore: and sjoerddebruin was having issues too [20:30:45] SMalyshev: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/specials/SpecialListDatatypes.php [20:30:58] that is generated by lots of i18n messages [20:32:46] the JS make no request for the suggester unless on types [20:33:07] addshore: so do I get it right that data types are hardcoded here: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/WikibaseDataTypeBuilders.php and that's the primary source? [20:33:19] https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/WikibaseDataTypeBuilders.php#L91 [20:33:38] SMalyshev: yes [20:33:44] addshore: aha, thanks [20:34:02] Lydia_WMDE: I just managed to merge with the gadget fine :) Will keep and eye on the page [20:34:12] addshore: thanks! [20:35:11] Lydia_WMDE: can you think of a sutible place to redirect https://www.wikidata.org/wiki/Wikidata:Development to? [20:35:27] addshore: not really tbh [20:35:34] contact the dev team? [20:35:43] best i can think of [20:35:45] but not nice [20:35:53] hmm, you also have https://meta.wikimedia.org/wiki/Wikidata/Development [20:36:09] the suggester problem exists on beta test and live [20:36:29] Does the beta site have a suggester database then? [20:36:34] addshore: yeah that is still on my kill list as well [20:36:54] sjoerddebruin: same as the main site [20:36:59] ah [20:37:02] so no useful suggestions [20:37:35] Wikidata:Inteoduction? or just delete it? ;p [20:37:54] *Introduction [20:37:57] i'd say delete [20:39:34] we have value view 0.10 now [20:39:56] sjoerddebruin: even if the suggester db is empty, the request is not sent, so it is the same problem [20:40:04] ok [20:40:11] very likely the problem is an incompatibility [20:41:18] removed event parameter from search() [20:42:27] done Lydia_WMDE ;p [20:42:46] another question: is there a list of all wikis that can appear in sitelinks somewhere? [20:43:11] addshore: <3 [20:43:23] is there perhaps a gadget which can restore the looks of Wikidata before the past changes in interface? more horrible seems impossible [20:43:31] SMalyshev: all the ones you see in the sidebar plus commons and wikidata itself [20:43:48] SMalyshev: sites table in the database [20:43:51] Romaine: no :P [20:43:52] or wb.sites.getSites() in the console [20:43:53] Lydia_WMDE: no, I mean something I can use in the code [20:43:55] :( [20:44:02] there should be an api module for this, but not yet [20:44:12] aude: aha, ok. does it change often? [20:44:19] every few months [20:44:21] only when we add a new wikipedia or wiki [20:44:25] until we have all wikimedia wikis [20:44:28] or support a new site group on wikidata [20:44:34] Romaine: http://assets.diylol.com/hfs/e7d/1de/1ed/resized/obama-meme-generator-we-are-not-afraid-of-change-79ef6a.jpg?1339724506.jpg [20:44:38] e.g. we added wikinews in september [20:45:04] addshore: changes are not a problem, that it is made more difficult to edit properly, that is the problem [20:45:22] each new version makes it harder for users from Wikipedia to edit Wikidata items [20:47:05] addshore: https://www.wikidata.org/w/index.php?title=MediaWiki_talk:Gadget-Merge.js&diff=0&oldid=187627693 [20:47:13] *looks* [20:47:28] Lydia_WMDE: What evil changes did you unleash on us this week? [20:47:39] multichill: all of them -.- [20:47:58] 3MediaWiki-Core-Team, Wikidata, wikidata-query-service: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#974503 (10Smalyshev) May also be related to T86528 [20:49:03] This week the layout the system I use at work for handling tickets, projects etc got a completely new interface (no functional changes). [20:49:11] Some people really freaked out! :P [20:49:22] 3MediaWiki-Core-Team, Wikidata, wikidata-query-service: Deploy a Wikidata complex query service into production - https://phabricator.wikimedia.org/T85159#974508 (10Smalyshev) [20:49:24] it is more harder to update/add things too [20:49:24] 3MediaWiki-Core-Team, Wikidata, wikidata-query-service: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#974507 (10Smalyshev) 5Open>3Resolved [20:51:07] Romaine: how is it harder? [20:51:11] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Automatically drop redundant sitelink to redirect when merging in wbmergeitems api module - https://phabricator.wikimedia.org/T85347#974512 (10Addshore) But the case will still never be able to happen on Wikidata..? [20:52:08] it is now a very small field where I have to add something [20:52:39] why don't we have a Q6 ? [20:52:39] ok, every few months is frequent enough to make it something other than hardcoded [20:52:43] looks like there are a few compatiblity changes needed in the suggester [20:52:47] and Q7 and Q ? [20:52:58] Q9* [20:52:59] and it looks confusing [20:53:20] I don't see a deletion on the journals [20:53:22] SMalyshev: we probably will forget to update [20:53:33] There's Q666 though [20:53:49] Harmonia_Amanda: we skipped some ids [20:53:55] suppose depends how it's done for query [20:54:01] when we created the first items [20:54:07] it is a very tiny field where everything has to be squized in [20:54:09] I see that but why? [20:54:22] site list could be cached for some period of time [20:55:17] and the full page name is now hidden for a part [20:55:20] aude: yes, but probably not worth bothering, since the query service doesn't talk to the DB it's better to make it so it doesn't assume anything [20:55:24] Harmonia_Amanda: we entered a few ids initially and the counter skipped those ids you mentioned during that process [20:56:33] SMalyshev: then some script or thing we can run to update the query service [20:56:41] it can pull from the api or whatever [20:56:53] Lydia_WMDE: it's tempting to use these ids now ^^ [20:56:58] if /when we have one [20:57:04] Harmonia_Amanda: heh not possible [20:57:09] I like how Q404 doesn't exist. [20:57:14] :D [20:58:20] !q 1234 [20:58:20] https://www.wikidata.org/wiki/Q1234 [20:58:39] Ehm [20:58:41] !q 12345 [20:58:41] https://www.wikidata.org/wiki/Q12345 [20:59:10] <3 [21:00:14] ok i am going home now. back in 30 minutes. don't burn down the house in the meantime ;-) [21:00:39] ce would never do that! [21:00:51] JohnFLewis would do [21:01:21] * Stryn hides [21:01:28] we would, maybe, sand it up [21:01:49] with buckets full of sand [21:01:56] but never burning it [21:02:09] well maybe JohnFLewis :p [21:18:11] (03PS3) 10JanZerebecki: Use ArticleEditUpdates hook for usage tracking [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [21:20:26] got the fix for the suggester (i think) [21:20:32] works on test.wikidata [21:20:54] Lydia_WMDE: What happened with the edit summaries? [21:21:02] Created claim: 1 collection (P195): [21:21:06] 1 collection? Huh? [21:21:35] Oh, caching [21:22:05] No, where does that 1 come from? [21:23:15] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem doesn't say in what language the label and description would be - https://phabricator.wikimedia.org/T86673#974584 (10Addshore) The language keys that could be used here are: ``` "wikibase-label-edit-placeholder-language-aware": "enter a label i... [21:24:19] ugh [21:24:38] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem doesn't say in what language the label and description would be - https://phabricator.wikimedia.org/T86673#974589 (10Addshore) [21:24:44] addshore: Nice. [21:24:50] there are no qunit tests for the suggester :/ [21:25:17] and if they were, would need to be setup with travis and in the build [21:27:35] https://github.com/Wikidata-lib/PropertySuggester/issues/113 (does that instead go in phabricator?) [21:27:36] (03CR) 10JanZerebecki: [C: 032] Use ArticleEditUpdates hook for usage tracking [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [21:27:47] \o/ [21:29:19] aaaah, the extra variable is still there :/ [21:29:41] * aude doesn't care that much but [21:30:06] :D [21:30:22] aude: if your talking about the summaries I think thats been there for a long time [21:30:37] Wat doen we met zulke situaties https://www.wikidata.org/wiki/Q17372797 multichill? Klik maar eens op het rijksmonumentnummer. [21:30:51] it is in the hook, so removing it is even worse I think... [21:33:02] addshore: the "1" has been there for a long time? [21:34:52] *wonders why his skins on this local install have all died... [21:35:06] re [21:35:07] (03Merged) 10jenkins-bot: Use ArticleEditUpdates hook for usage tracking [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184002 (https://phabricator.wikimedia.org/T86308) (owner: 10Daniel Kinzler) [21:35:44] multichill: edit summaries are being fixed :) [21:36:26] https://github.com/Wikidata-lib/PropertySuggester/pull/112 [21:36:37] !merge https://github.com/Wikidata-lib/PropertySuggester/pull/112 :) [21:36:37] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/https://github.com/Wikidata-lib/PropertySuggester/pull/112/ [21:36:44] hah [21:36:49] :D [21:36:54] jzerebecki: ^ [21:36:59] hoo: ^ [21:37:20] then need to prepare a tag [21:37:36] or prepare for trouble [21:37:41] :D [21:37:47] * Lydia_WMDE hands sjoerddebruin a cookie [21:37:55] Lydia_WMDE: no permission :P [21:38:00] No, you need to make it double you idiot! :( [21:38:07] jzerebecki: on the repo? i can change that [21:38:18] Lydia_WMDE: yes, please [21:38:22] sjoerddebruin: two cookies? [21:38:27] jzerebecki: which username? [21:38:29] *facepalm* [21:38:31] Done [21:38:39] hoo: <3 [21:38:55] hah and i managed to get home just in time before the rain \o/ [21:38:55] chocolates for hoo! [21:39:04] * aude will have to bring some to SF [21:39:12] :) [21:39:12] heh :D :) [21:40:05] where did jan go :( [21:40:17] Net split took him :P [21:40:25] ah [21:40:50] anyone know his github account? [21:40:51] On the other side of the freenode :D [21:40:56] hehe [21:41:21] Lydia_WMDE: JanZerebecki [21:41:32] k [21:41:54] jzerebecki: invited you [21:43:04] https://github.com/Wikidata-lib/PropertySuggester/pull/114 [21:43:20] * sjoerddebruin is still save! [21:43:33] Lydia_WMDE: heh the fnord between the freenodes ate my message. thx. [21:44:14] jzerebecki: did you manually test daniel's patch for the hook? [21:44:16] sjoerddebruin: you can never be sure about that ;-) [21:44:45] would like to cherry pick into the branch but want to double check it [21:44:49] aude: nope [21:44:55] ok [21:44:57] * aude doing [21:45:20] sjoerddebruin: besides the suggester and edit summary do you still see any other issue? [21:45:41] Translations would be fixed Thursday? [21:45:59] which ones? [21:46:06] or which string? [21:46:20] The sitelink-headers. They are still long. [21:46:33] let me look [21:46:50] (in Dutch) [21:47:07] (03PS1) 10Addshore: Add language hint placeholders in SpecialNewEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) [21:47:23] ok same in de [21:47:30] (03PS2) 10Addshore: Add language hint placeholders in SpecialNewEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) [21:47:41] (03PS3) 10Addshore: Add language hint placeholders in SpecialNewEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) [21:48:13] well, if you look in a page history at qqx the 1 is there (ie. not started appearing in the past hours) [21:49:04] ok i am preparing a deployment post-mortem email [21:50:01] aude: look in a page history at qqx, its there is lots of past edits [21:50:50] (03CR) 10Sjoerddebruin: [C: 031] Add language hint placeholders in SpecialNewEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) (owner: 10Addshore) [21:51:11] Never saw such a quick response on a "bug" [21:52:07] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem doesn't say in what language the label and description would be - https://phabricator.wikimedia.org/T86673#974627 (10Addshore) {F28518} [21:52:16] Lydia_WMDE: also don't forget about https://test.wikidata.org/wiki/MediaWiki:Gadget-SiteIdToInterwiki.js [21:53:16] Need to import that, aude, Lydia_WMDE? [21:53:16] aude: ohhhh you are right! [21:53:20] i totally forgot that [21:53:27] sjoerddebruin: yes please :) [21:53:34] Does it needs attribution? [21:53:50] no the person who wrote it would rather not be attributed [21:53:52] ok [21:54:05] :) [21:56:00] aude, Lydia_WMDE: done [21:56:05] \o/ [21:56:07] thanks [21:56:10] * Lydia_WMDE tests [21:56:31] Oh, forgot the label. [21:57:16] sweet [21:57:19] works [21:58:05] one sucky thing though is that the full name still shows until page is loaded [21:58:08] and then jumps [21:58:08] ok [21:58:20] something to improve still [21:58:21] JavaScript, duh [21:58:24] :D [22:00:18] Lydia_WMDE: What is a good label for the setting? [22:00:44] hmmmm Site ID to Interwiki? [22:00:47] (I've not added it to hidden, so people who don't like it can disable it) [22:00:50] we couldn't come up with something better [22:00:55] yeah [22:01:47] Or aude. [22:02:28] NOT YUVI!!!! [22:03:02] :P [22:03:52] ''Site ID to interwiki:'' converts the site ID to interwiki style in the sitelinks section (example: enwiki > en) [22:04:30] replaces* [22:04:50] sounds good [22:05:14] ''Site ID to interwiki:'' replaces the site ID with the interwiki code in the sitelinks section (example: enwiki > en) [22:06:25] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#974671 (10JanZerebecki) No, I don't think unit localization matters for any WDQ service as it is only about how to format them (though that might for a fancy query builder or some... [22:08:33] 3Wikidata, MediaWiki-Parser: Add hook for extensions to bump or expire parser cache - https://phabricator.wikimedia.org/T86694#974673 (10Lydia_Pintscher) p:5Triage>3Normal [22:09:24] ok issues i have for the post mortem: gadget jumping, 1 in edit summaries, caching issues, translations [22:09:27] anything i missed? [22:10:03] Translation request for https://www.wikidata.org/wiki/MediaWiki:Gadget-SiteIdToInterwiki would be great [22:10:22] 3Wikidata, MediaWiki-Parser: Add hook for extensions to bump or expire parser cache - https://phabricator.wikimedia.org/T86694#974676 (10Legoktm) https://www.mediawiki.org/wiki/Manual:Hooks/PageRenderingHash maybe? [22:10:52] sjoerddebruin: meaning? [22:10:58] ? [22:11:12] what would you like translated? how does it work? sorry not familiar with translation for gadgets [22:11:27] Don't know if we can add gadgets to the translate extension [22:11:58] not sure either [22:12:11] I think I saw one lately. [22:13:02] https://www.wikidata.org/wiki/MediaWiki:Linkshere [22:15:08] It's easy now, Lydia_WMDE [22:15:23] hmm? [22:15:34] sorry i am clearly not at the top of my abilities today -.- [22:15:53] i should go and make some hot chocolate [22:15:53] I hope https://www.wikidata.org/w/index.php?title=Special:Translate&group=page-MediaWiki%3AGadget-SiteIdToInterwiki&action=translate will point people to their own language. [22:15:59] \o/ [22:22:03] (03CR) 10Legoktm: Add language hint placeholders in SpecialNewEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) (owner: 10Addshore) [22:22:41] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#974706 (10Smalyshev) @JanZerebecki right, so we need to figure out how to efficiently represent this, because indexes can not work with values expressed in different units. Right... [22:24:06] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#974710 (10Lydia_Pintscher) I think the idea is to do the conversion when the data gets into the query index and then query only on homogenous data. [22:31:17] * aude wonders if the change notification jobs are working correctly [22:31:51] aude: dispatching to client? [22:31:57] i can look into that in a few [22:32:12] i don't see anything in the logs about it [22:32:29] but please don't purge https://fr.wikivoyage.org/wiki/Saas-Fee [22:32:32] should have no links now [22:32:47] https://en.wikivoyage.org/wiki/Saas-Fee should have no french link [22:32:58] and it's on my watchlist and not appearing [22:33:48] it works on wikipedia still [22:34:30] Ahhh, yet another wiki for me to have an account on. I love SUL. [22:34:53] :D [22:37:52] https://phabricator.wikimedia.org/T86714 [22:38:20] (03CR) 10Hashar: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) (owner: 10Addshore) [22:39:26] thx [22:39:54] * aude will prepare the other things for swat [22:40:14] I had to restart Zuul, all events lost :( [22:40:14] then we need to look into usage tracking and this more tomorrow (if i don't fix tonight) [22:40:39] aude: we owe you chocolate [22:41:03] mmmm :) [22:41:15] wish we caught this sooner :/ [22:41:25] * aude had the wrong setting until just now [22:41:35] wrong/default [22:46:11] 3MediaWiki-extensions-WikibaseClient, Wikidata: Argument 1 passed to UsageAspectTransformer::transformPageEntityUsages() must be an instance of PageEntityUsages, integer given - https://phabricator.wikimedia.org/T86714#974743 (10Lydia_Pintscher) p:5Triage>3Unbreak! [22:46:14] (03CR) 10Aude: "recheck" [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184734 (owner: 10Aude) [22:53:11] aude: did you find the issue with the edit summaries? [22:54:08] https://www.wikidata.org/wiki/Q42 <- are identifiers linked for you at the bottom? for me only the first one is linked [22:54:29] (03CR) 10Aude: [C: 032] Update FormatAutocomments hook for I36c3a9e5 [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184734 (owner: 10Aude) [22:54:34] DanielK_WMDE: yes [22:54:49] but the change notification jobs appear broken :( [22:55:12] i think https://phabricator.wikimedia.org/T86714 might be trivial(ish) to fix [22:55:25] but not sure what page aspect to give in this case [22:55:31] or usage * [22:55:41] laggy laggy freenode [22:57:11] addshore: https://www.wikidata.org/wiki/Q42 <- are identifiers linked for you there? for me only the first one is [22:57:19] purging doesn't help [22:57:52] addshore: Lydia_WMDE same here [22:58:15] (03CR) 10Addshore: Add language hint placeholders in SpecialNewEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) (owner: 10Addshore) [22:58:16] i would try to go ahead and apply the changes from https://test.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js [22:58:50] https://www.wikidata.org/wiki/Q102425 looks fine [22:58:51] note that there is one line hardcoded that needs to be adjusted [22:58:52] london doesn't [22:58:54] strange [22:58:55] oh [22:59:00] could be timing issue [22:59:06] not sure [22:59:13] oh my god... I sent that message decade ago... [22:59:21] haha [22:59:25] https://www.wikidata.org/wiki/Q60 doesn't have links [22:59:41] except for the first [22:59:47] aude: think the changes on test will fix it? [22:59:52] (03Merged) 10jenkins-bot: Update FormatAutocomments hook for I36c3a9e5 [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184734 (owner: 10Aude) [23:00:20] not totally sure, but are eventually needed and shouldn't break [23:00:32] ok [23:00:34] since they work on test. [23:00:38] they should be ok [23:00:58] just be careful about the hardcoded line [23:01:15] * Lydia_WMDE looks at addshore :D [23:01:21] (sorry) [23:01:33] if ( claimId === 'P368' ) { [23:02:00] should instead be if ( claimId === 'P1630' ) { on wikidata [23:04:01] aude: good find, thanks! [23:05:52] (03PS1) 10Aude: Update Wikidata, fix suggester and autocomment formatting [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184797 [23:07:38] aude: If you want to SWAT later on, please keep the freenode maint. window in mind [23:09:45] ? [23:11:08] -mquin- [Global Notice] And we are done, thanks for bearing with us. There will be a services outage at around 0000 UTC (just under two hours from this notice) which is expected to last between 15 and 30 minutes. [23:11:10] aude: ^ [23:11:21] If I'm not mistaken that's SWAT time [23:11:22] oh noes [23:11:57] (03CR) 10Aude: [C: 032] Update Wikidata, fix suggester and autocomment formatting [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184797 (owner: 10Aude) [23:12:19] services outage should not matter, no? [23:12:22] that is chanserv and so on [23:12:37] Lydia_WMDE: You sure? [23:12:45] services is a broad term... [23:12:46] 80% [23:13:08] they usually use it for chanvers, nickserv, memoserv and co [23:13:50] -.- [23:14:08] (03Merged) 10jenkins-bot: Update Wikidata, fix suggester and autocomment formatting [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184797 (owner: 10Aude) [23:14:09] "23:39:56 <+mquin> HevvyMetal: The really noisy bit is over, but we're expecting to lose NickServ and freinds for a few minutes in about an hour and a half" [23:14:10] But thanks for clarifying [23:14:12] Freenode-channel [23:20:18] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#974806 (10Smalyshev) @Lydia_Pintscher sounds good, but that means every unit should have definition of which unit it converts too and how to convert it. Maybe as part of T77978. [23:30:24] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#974814 (10Lydia_Pintscher) Yeah agreed. And for the units where we don't have conversions we can only offer querying for them as they are anyway.