[06:48:11] 3Wikidata, Pywikibot-delinker: Delinker should delink and replace images on Wikidata too - https://phabricator.wikimedia.org/T66794#985192 (10Steinsplitter) 5stalled>3Resolved a:3Steinsplitter See https://www.wikidata.org/wiki/Special:Contributions/CommonsDelinker Please flag bot if needed. [06:48:26] 3Wikidata, Pywikibot-delinker: Delinker should delink and replace images on Wikidata too - https://phabricator.wikimedia.org/T66794#985195 (10Steinsplitter) a:5Steinsplitter>3None [09:06:32] [13WikibaseDataModel] 15thiemowmde comment on pull request #342 14b6ea356: @JeroenDeDauw: So instead of answering my question you did this https://github.com/wmde/WikibaseDataModel/commit/1a9577ff102137de52033c36efa423ccf079c35b, which is incorrect from my perspective, since the parameter is not "optional". You can not skip the parameter and call `new Property( new PropertyId( 'P1' ), 'string' )`.... 02http://git.io/safwrw [09:17:33] [13WikibaseDataModel] 15thiemowmde 04force-pushed 063.0.x-dev from 14e991166 to 14155cca0: 02http://git.io/tGwXnQ [09:17:33] 13WikibaseDataModel/063.0.x-dev 14155cca0 15jeroendedauw: Remove deprecated EntityId::getPrefixedId [09:38:43] [13WikibaseDataModel] 15thiemowmde created 06fpNaming (+1 new commit): 02http://git.io/t9m9yQ [09:38:43] 13WikibaseDataModel/06fpNaming 149c6937c 15Thiemo Mättig: Rename Fingerprint to EntityTerms [09:40:32] [13WikibaseDataModel] 15thiemowmde opened pull request #343: Rename Fingerprint to EntityTerms (063.0.x-dev...06fpNaming) 02http://git.io/A5TFog [09:41:15] wmde/WikibaseDataModel/fpNaming/9c6937c : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/47498013 [09:50:13] (03PS2) 10Thiemo Mättig (WMDE): Use 'property' string constant to avoid dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 [09:50:40] (03PS2) 10Thiemo Mättig (WMDE): Use 'item' string constant to avoid dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177239 [10:13:22] anyone able to check those edits? seems suspicious https://www.wikidata.org/w/index.php?title=Q9143&diff=0&oldid=180143011 [10:15:26] [rollbacked] [10:21:15] (03PS9) 10Thiemo Mättig (WMDE): Optimize use sections and docs in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [10:29:10] (03PS9) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [10:32:15] (03CR) 10jenkins-bot: [V: 04-1] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [10:41:08] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Api Undeletion error for items that have a sitelink used elsewhere to be improved. - https://phabricator.wikimedia.org/T87072#985301 (10Lydia_Pintscher) a:5Lydia_Pintscher>3None [10:44:47] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Diff of a qualifier shows the value of the new property instead of the old property - https://phabricator.wikimedia.org/T87096#985317 (10Lydia_Pintscher) p:5Low>3High [10:47:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Wikidata: [edit] links should not print - https://phabricator.wikimedia.org/T87108#985322 (10Lydia_Pintscher) [11:08:45] thx sjoerddebruin [11:09:10] Oh, yes. [11:16:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: SpecialPage for wbcreateredirect - https://phabricator.wikimedia.org/T87114#985342 (10Lydia_Pintscher) p:5Triage>3Low [11:16:11] 3Wikidata, MediaWiki-extensions-WikibaseRepository: SpecialPage for wbcreateredirect - https://phabricator.wikimedia.org/T87114#984182 (10Lydia_Pintscher) [11:16:12] (03PS11) 10Thiemo Mättig (WMDE): Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [11:17:22] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Getting Special:EntityData fails if a slash is appended to the URL - https://phabricator.wikimedia.org/T87143#985348 (10Lydia_Pintscher) p:5Triage>3Normal [11:20:00] (03PS1) 10Henning Snater: Renamed claimlistview to statementlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185817 [11:20:02] (03PS1) 10Henning Snater: Renamed claimgrouplistview to statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185818 [11:20:04] (03PS1) 10Henning Snater: Renamed claimgrouplabelscroll to statementgrouplabelscroll [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185819 [11:20:13] (03CR) 10jenkins-bot: [V: 04-1] Renamed claimlistview to statementlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185817 (owner: 10Henning Snater) [11:20:17] (03CR) 10jenkins-bot: [V: 04-1] Renamed claimgrouplistview to statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185818 (owner: 10Henning Snater) [11:20:21] (03CR) 10jenkins-bot: [V: 04-1] Renamed claimgrouplabelscroll to statementgrouplabelscroll [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185819 (owner: 10Henning Snater) [11:20:29] (03PS10) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [11:21:23] (03Abandoned) 10Thiemo Mättig (WMDE): Remove slashes from HTML elements that aren't allowed to be empty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167175 (owner: 10Thiemo Mättig (WMDE)) [11:21:48] DanielK_WMDE: jzerebecki: JeroenDeDauw: are we fine with this? https://phabricator.wikimedia.org/T86833 [11:22:21] (03PS3) 10Thiemo Mättig (WMDE): [WIP] API test for label/description conflicts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147140 [11:24:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] API test for label/description conflicts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147140 (owner: 10Thiemo Mättig (WMDE)) [11:25:15] (03PS2) 10Henning Snater: Renamed claimgrouplistview to statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185818 [11:25:19] (03CR) 10jenkins-bot: [V: 04-1] Renamed claimgrouplistview to statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185818 (owner: 10Henning Snater) [11:25:46] (03PS9) 10Henning Snater: Consolidated RankSelector widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179136 [11:31:36] 3MediaWiki-Core-Team, wikidata-query-service, Wikidata: Wikidata Query - add license - https://phabricator.wikimedia.org/T86833#985371 (10daniel) What dependencies does this have, what libraries does it use? Is it all JVM code, or does this involve PHP code too? WikiDataToolkit is Apache2, so making this Apache2... [11:50:07] (03CR) 10JanZerebecki: [C: 04-2] "> It does reduce dependencies on the class level." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 (owner: 10Thiemo Mättig (WMDE)) [11:51:03] (03CR) 10JanZerebecki: [C: 04-2] "Same reasoning as dependency." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177239 (owner: 10Thiemo Mättig (WMDE)) [11:58:42] (03CR) 10Henning Snater: "Feels more like a work-around. The problem might rather be that when self._updateMenu() is called from the "eachchange" event handler atta" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181056 (https://phabricator.wikimedia.org/T55476) (owner: 10Thiemo Mättig (WMDE)) [12:26:00] (03CR) 10Henning Snater: "Please add a comment to the code why two input elements end up having assigned the name "search" and why the hidden input element has to b" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174387 (https://bugzilla.wikimedia.org/58467) (owner: 10Thiemo Mättig (WMDE)) [13:13:40] (03PS1) 10Henning Snater: Renamed ClaimsView to StatementGroupListView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185822 [13:13:44] (03CR) 10jenkins-bot: [V: 04-1] Renamed ClaimsView to StatementGroupListView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185822 (owner: 10Henning Snater) [13:26:48] 3MediaWiki-Core-Team, wikidata-query-service, Wikidata: Wikidata Query - add license - https://phabricator.wikimedia.org/T86833#985429 (10Manybubbles) Its all JVM code. Iirc that GPL apache incompatibility is something the apache foundation disputes but I'm not sure. If we accept that incompatibility then it mu... [13:31:24] (03PS1) 10Henning Snater: Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 [13:31:29] (03CR) 10jenkins-bot: [V: 04-1] Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 (owner: 10Henning Snater) [13:32:40] (03PS2) 10Henning Snater: Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 [13:32:44] (03CR) 10jenkins-bot: [V: 04-1] Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 (owner: 10Henning Snater) [13:48:14] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2015/01/19 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/185826 [13:51:21] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2015/01/19 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/185826 (owner: 10Tobias Gritschacher) [14:45:21] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "You don't have to like it. That's no reason to block this patch, not even with a -1 and clearly not with a -2 (merging it will not break a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 (owner: 10Thiemo Mättig (WMDE)) [14:55:13] (03CR) 10JanZerebecki: [C: 04-1] "Looks good besides inline comment. Also as you say still needs manual testing." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010) (owner: 10Daniel Kinzler) [14:59:02] (03CR) 10Thiemo Mättig (WMDE): "PS: If we ever make this configurable (as planned and already mentioned in some TODOs and FIXMEs) these types must be string constants any" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 (owner: 10Thiemo Mättig (WMDE)) [15:05:37] 3Wikidata: document xml schema for sites definition - https://phabricator.wikimedia.org/T87183#985534 (10Lydia_Pintscher) 3NEW [15:06:08] I was looking at Wikidata:Events, are there really no planned right now? [15:06:32] 3Wikidata: document xml schema for sites definition - https://phabricator.wikimedia.org/T87183#985541 (10Lydia_Pintscher) [15:06:42] (03PS1) 10Thiemo Mättig (WMDE): Replace some string comparisons with instanceof [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185832 [15:09:03] 3Wikidata, MediaWiki-Sites, MediaWiki-Maintenance-scripts: Maintenance script for exporting site definitions. - https://phabricator.wikimedia.org/T87178#985545 (10Lydia_Pintscher) [15:10:09] 3Wikidata, MediaWiki-Sites, MediaWiki-Maintenance-scripts: Maintenance script for importing site definitions. - https://phabricator.wikimedia.org/T87176#985549 (10Lydia_Pintscher) [15:11:05] JanAinali_WMSE: you mean the wiki page? it is a bit out of date unfortunately [15:11:13] upcoming: [15:11:18] mediawiki dev summit [15:11:21] europeana tech [15:11:25] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Updated claimlistview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185166 (owner: 10Henning Snater) [15:11:28] mediawiki hackathon [15:11:30] wikimania [15:11:37] those i know about at least [15:12:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Updated claimgrouplistview code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185168 (owner: 10Henning Snater) [15:13:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] statementview toolbar definition: Updated naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185410 (owner: 10Henning Snater) [15:13:48] (03PS3) 10Daniel Kinzler: Update wbc_entity_usage upon page deletion. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010) [15:14:33] Wikidata on GLAM WIKI 2015? :) [15:15:02] hopefully! [15:15:21] <3 [15:15:32] Will you come to the Netherlands? :) [15:17:01] hope so at some point again [15:17:06] no idea when/for what yet though [15:19:59] Oh, nice! [15:28:19] Byt the way, does WMDE have any Wikidata related merchandise or products that WMSE could buy? [15:28:35] *cough* t-shirts *cough* [15:33:11] heard something about that on the latest office hour ;) [15:35:46] (03CR) 10Daniel Kinzler: Update wbc_entity_usage upon page deletion. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010) (owner: 10Daniel Kinzler) [15:36:30] (03CR) 10Daniel Kinzler: [V: 031] "Manually tested now (found and fixed a bug: $title->getArticleID is already 0 when ArticleDeleteComplete runs)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010) (owner: 10Daniel Kinzler) [15:36:38] jzerebecki: --^ [15:37:16] Lydia_WMDE: is there anything we can send JanAinali_WMSE? [15:38:09] JanAinali_WMSE: we have some stuff yes. send me an email with what kind of event it is and what you need and i can see what we can do [15:41:27] (03PS10) 10Thiemo Mättig (WMDE): Consolidated RankSelector widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179136 (owner: 10Henning Snater) [15:42:14] (03PS4) 10Daniel Kinzler: Update wbc_entity_usage upon page deletion. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010) [15:44:05] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Consolidated RankSelector widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179136 (owner: 10Henning Snater) [15:47:10] (03Merged) 10jenkins-bot: Consolidated RankSelector widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179136 (owner: 10Henning Snater) [15:49:09] (03PS7) 10Thiemo Mättig (WMDE): Updated RankSelector code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179138 (owner: 10Henning Snater) [15:49:30] (03PS6) 10Thiemo Mättig (WMDE): statementview: Removed _statement variable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179422 (owner: 10Henning Snater) [15:49:43] (03CR) 10JanZerebecki: [C: 032] Update wbc_entity_usage upon page deletion. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010) (owner: 10Daniel Kinzler) [15:49:57] Missing: JSON dumps. Reward: one cookie. <3 [15:50:57] Oo [15:51:16] jzerebecki: json dumps seem to be gone. did you see anything on ops list? [15:51:51] Lydia_WMDE: Right now it is not for a specific event, but we have an externally funded grant in which we are supposed to use €950 for wikidata merchandise and I wanted to hear if there are any available or if we need to create something new. [15:52:09] ah [15:52:19] well we have stickers and tshirt and notebooks [15:52:34] they all have the wikidata logo [15:52:42] Lydia_WMDE: nothing related on ops@ , but a patch from hoo in that area recently was merged.... [15:52:44] so probably easiest if you just print them locally? [15:52:53] jzerebecki: hmmmmm [15:53:09] (03PS4) 10Thiemo Mättig (WMDE): Have statementview inherit from EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179458 (owner: 10Henning Snater) [15:54:21] (03Merged) 10jenkins-bot: Update wbc_entity_usage upon page deletion. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010) (owner: 10Daniel Kinzler) [15:59:40] Lydia_WMDE: Yeah, that might be easier [16:08:20] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #342 14b6ea356: Just fix it then. The README is documentation, and this never required RFCs to modify 02http://git.io/NbyrLA [16:15:40] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Have statementview inherit from EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179458 (owner: 10Henning Snater) [16:17:15] (03PS2) 10Daniel Kinzler: Show fallback language on item links. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185554 (https://phabricator.wikimedia.org/T85105) [16:17:51] jzerebecki: ---^ [16:18:12] (03Merged) 10jenkins-bot: Have statementview inherit from EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179458 (owner: 10Henning Snater) [16:18:51] (03PS1) 10Thiemo Mättig (WMDE): Drop space between date and calendar name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185838 [16:19:02] (03PS2) 10Thiemo Mättig (WMDE): claimlistview: Removed obsolete _listItemWidget member [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185162 (owner: 10Henning Snater) [16:27:35] [13WikibaseDataModel] 15thiemowmde comment on pull request #342 14b6ea356: So you want me to revert to the wording you complained about? Sorry, but no. This is not a way forward. I still don't know what the problem was that made you changed it. 02http://git.io/8Wo9qA [16:29:18] (03PS4) 10Thiemo Mättig (WMDE): Updated claimlistview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185166 (owner: 10Henning Snater) [16:29:29] (03PS2) 10Thiemo Mättig (WMDE): Updated claimgrouplistview code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185168 (owner: 10Henning Snater) [16:29:38] (03PS2) 10Thiemo Mättig (WMDE): statementview toolbar definition: Updated naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185410 (owner: 10Henning Snater) [16:29:49] (03PS2) 10Thiemo Mättig (WMDE): statementview: Not triggering "change" event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185411 (owner: 10Henning Snater) [16:33:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] statementview: Not triggering "change" event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185411 (owner: 10Henning Snater) [16:35:15] (03Merged) 10jenkins-bot: Updated claimlistview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185166 (owner: 10Henning Snater) [16:44:20] (03CR) 10Daniel Kinzler: [C: 04-1] "generally sensible, but please split and re-consider as discussed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [16:45:10] (03PS3) 10Thiemo Mättig (WMDE): Removed table of content bar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184629 (https://phabricator.wikimedia.org/T84913) (owner: 10Henning Snater) [16:45:23] (03PS2) 10Thiemo Mättig (WMDE): Renamed FingerprintView to EntityTermsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184856 (owner: 10Henning Snater) [16:45:47] (03PS3) 10Thiemo Mättig (WMDE): entitytermsview: Inject link to help page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (owner: 10Henning Snater) [16:47:30] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Looks good, but:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) (owner: 10Henning Snater) [16:49:20] (03CR) 10Daniel Kinzler: [C: 04-2] "I agree with Jan: constants are better (better to document, less error prone) than literals. The logical dependency is already there: some" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 (owner: 10Thiemo Mättig (WMDE)) [16:52:32] (03CR) 10Daniel Kinzler: "Not sure about this one..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185832 (owner: 10Thiemo Mättig (WMDE)) [16:55:23] (03CR) 10Thiemo Mättig (WMDE): "As before, no argument (actually, there is only one argument, and I don't consider it valid) given is a reason for a -2. Why are these few" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 (owner: 10Thiemo Mättig (WMDE)) [16:57:27] (03CR) 10Daniel Kinzler: "I'm really scared about how bad our tests for special pages are. The fact that some broken tests were accepted in the past doesn't mean we" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181902 (owner: 10Multichill) [16:58:46] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Removed table of content bar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184629 (https://phabricator.wikimedia.org/T84913) (owner: 10Henning Snater) [17:00:35] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Renamed FingerprintView to EntityTermsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184856 (owner: 10Henning Snater) [17:08:52] (03CR) 10Daniel Kinzler: [C: 032] Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [17:12:07] (03Merged) 10jenkins-bot: Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [17:13:53] (03CR) 10Thiemo Mättig (WMDE): "> I would check the type constant if filtering by item type - code that does this does not need to know or care about the fact that there " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185832 (owner: 10Thiemo Mättig (WMDE)) [17:18:53] (03CR) 10Daniel Kinzler: [C: 031] "Looks fine; No +2 yet because it would be good to have a fix for PropertySuggester in the pipeline first. Link it here, and I'll merge thi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 (owner: 10Thiemo Mättig (WMDE)) [17:20:29] Just ordered 10000 stickers with the Wikidata logo :D [17:20:39] \o/ [17:21:02] €950? :) [17:21:28] (03PS2) 10Thiemo Mättig (WMDE): Fix entitysearch to support Firefox smart keyword [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174387 (https://bugzilla.wikimedia.org/58467) [17:22:08] Only €140! [17:26:40] Lydia_WMDE, sjoerddebruin: json dump generation was just started. [17:27:44] :) [17:28:35] (03PS1) 10Thiemo Mättig (WMDE): Don't abbreviate WikibaseRepo with $repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185841 [17:32:33] (03CR) 10Daniel Kinzler: [C: 04-1] "mostly an improvement, but some bits are unclear, see comments." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [17:34:13] (03CR) 10Hoo man: [C: 032] "No-op" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185841 (owner: 10Thiemo Mättig (WMDE)) [17:35:44] (03PS1) 10Thiemo Mättig (WMDE): Drop unused use clauses from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185842 [17:36:44] (03Merged) 10jenkins-bot: Don't abbreviate WikibaseRepo with $repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185841 (owner: 10Thiemo Mättig (WMDE)) [17:38:35] (03PS2) 10Thiemo Mättig (WMDE): Drop unused use clauses from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185842 [17:39:07] (03PS1) 10Thiemo Mättig (WMDE): Drop unused use clauses from Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185843 [17:39:28] (03PS1) 10Thiemo Mättig (WMDE): Drop unused use clauses from Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185844 [17:44:44] (03CR) 10Daniel Kinzler: [C: 04-1] "new TemplateFactory( TemplateRegistry::getDefaultInstance() ) was bad, but hiding the call to TemplateRegistry::getDefaultInstance() in t" (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180498 (owner: 10Thiemo Mättig (WMDE)) [17:55:10] [13WikibaseDataModel] 15brightbyte comment on pull request #272 147a384c8: So *all* aliases come from the same fallback? That doesn't make sense to me. The application should be free to choose how fallabck is applied to aliases - e.g. all aliases from all applicable fallback languages could be collected. In that case, the the actual language and source language can be different for each alias. 02http://git.io/sUBGHA [18:30:23] (03PS1) 10Thiemo Mättig (WMDE): Add missing/fix documentations in Client/Lib/Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185845 [18:33:23] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "One outcome of the discussion we just had: All test related changes in this and the following patch are probably ok. I will resubmit them " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 (owner: 10Thiemo Mättig (WMDE)) [18:33:25] thanks jzerebecki [18:39:58] what is the best place to read about how to use Wikidata Toolkit? [18:43:43] SMalyshev: https://www.mediawiki.org/wiki/Wikidata_Toolkit [18:44:13] hoo: yes, I've seen that but it doesn't really explain how to use it (unless I missed something) [18:45:17] SMalyshev: Markus Krötzsch gave a presentation about it at Wikimania. Maybe you can find the slides / video [18:45:47] SMalyshev: but on the page hoo linked to, there's a "how to use" section, with ocde examples [18:45:56] is that not what you are looking for? [18:46:27] SMalyshev: what kind of "use" do you want to learn about? [18:48:27] DanielK_WMDE: some general overview of the architecture, components and what I use for which task. I.e., if I want to read JSON dump, which API I use? What if I want partial dump? What I get as a result from this API? etc. [18:50:07] (03CR) 10Thiemo Mättig (WMDE): "See comments." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180498 (owner: 10Thiemo Mättig (WMDE)) [18:54:41] examples are good, but they describe only what the example does, not all that API could or should do [18:56:17] SMalyshev: never used it, but do the apidocs help there?: https://wikidata.github.io/Wikidata-Toolkit/ [18:57:35] jzerebecki: to some measure, but it doesn't really explain how to use things, it just shows the API definitions [18:57:47] e.g. this is the kind of docs I'd ideally look for: http://www.tinkerpop.com/docs/3.0.0.M6/ [19:05:17] public void registerEntityDocumentProcessor(EntityDocumentProcessor entityDocumentProcessor, String model, boolean onlyCurrentRevisions) - what "model" argument does? [19:09:55] SMalyshev: the apidocs should tell you that. complain on github about crappy documentation :) [19:10:27] DanielK_WMDE: the docs say: model - the content model that the processor is registered for; it will only be notified of revisions in that model; if null is given, all revisions will be processed whatever their model [19:10:41] SMalyshev: that thing process a mediawiki xml dump, right? so maybe it's a content model id that is used for filtering [19:10:52] i.e. "model is the name of the model". but what is that model thing? [19:11:11] SMalyshev: that's a MediaWiki concept [19:11:15] DanielK_WMDE: it is supposed to process all kinds of dumps - xml, json, etc. [19:11:54] DanielK_WMDE: so where could I find which models there are and what I can/should put as that argument? [19:11:58] SMalyshev: well, "model" refers to the content models in the XML. The JSON has entity types, not content models. [19:12:18] DanielK_WMDE: so for JSON dump it should be ignored? [19:12:23] SMalyshev: https://www.mediawiki.org/wiki/Manual:ContentHandler for the general idea [19:13:15] Wikibase uses "wikibase-item" for items and "wikibase-property" for properties [19:13:29] the corresponding entity type identifiers are "item" and "property". [19:13:38] But I can't give two there [19:13:55] SMalyshev: i don't know how they handle that in json dumps. maybe the use the entity type there. it's a bit confusing [19:14:31] SMalyshev: if you look at an XML dump, it has a tag. that's what the documentation says the model param refers to [19:14:41] i have no idea what they do with it when processing JSON [19:14:48] ok, got it, thanks [19:15:22] SMalyshev: basically, the content model identifier tells mediawiki what content handler to use for a given revision blob. [19:15:28] it's revision meta data [19:15:51] the entity type is a property of the entity object that is created by unserializing the entity blob using the correct handler [19:15:58] ah, so I don't care about it probably since in json dump there's no data that is not of thr right type [19:16:17] but you still need to distingush between items and properties [19:16:34] but maybe you can do that later *shrug* [19:17:12] anyway, off for today [19:17:19] DanielK_WMDE: thanks [19:25:26] (03PS1) 10Thiemo Mättig (WMDE): Add constructor to TemplateRegistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185846 [19:43:34] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Rework and cleanup ApiWikibase and subclasses (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [19:59:56] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See comments." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185554 (https://phabricator.wikimedia.org/T85105) (owner: 10Daniel Kinzler) [20:05:25] Is it possible to move all pubmed and doi references from wikipedia to wikidata so they don't grossly pollute the text of wikipedia articles with their metadata details? I understand that Templates can be used in wikipedia, but it's not good enough, or clean enough as using wikidata. It's also a super waste of time for anyone to have to fill in the metadata [20:05:25] for a reference, given that all i should minimally need to enter is a pmid, pmcid, doi, etc. and maximally some quoted text. [20:27:16] (03CR) 10Thiemo Mättig (WMDE): "Like so? https://github.com/Wikidata-lib/PropertySuggester/pull/115" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 (owner: 10Thiemo Mättig (WMDE)) [20:32:54] [13WikibaseDataModel] 15thiemowmde comment on pull request #272 147a384c8: I think it's not helpful to discuss this on a closed pull request. Please open a ticket. 02http://git.io/jDqnsg [21:00:03] RandIter: technology wise it is possible. currently on the condition that the page is linked to the wikidata item that has the reference and that the information to display the refrence is fully on wikidata. the first condition is soon gone when arbitrary access is enabled. [21:02:46] question about JsonDumpFileProcessor: in wikidata JSON dump, the dump looks like one huge array which contains entities as elements [21:02:53] how JsonDumpFileProcessor deals with that? [21:06:17] SMalyshev: no idea about that exact class, but in general i heard it works like an event based parse, i.e. it can process one entity before reading the full dump file. [21:07:02] jzerebecki: but how it knows when the entity begins/ends? I see in code it just uses Jackson but that doesn't know about entities [21:07:23] so it'd just see [ and think it's a beginning of JSON object, right? [21:09:03] the tests in https://github.com/Wikidata/Wikidata-Toolkit/tree/v0.3.0/wdtk-dumpfiles/src/test/resources/testSamples have different format [21:11:54] SMalyshev: possibly it assumes the dump is valid json, and check that after it hits the respective closing ] if it is an item or property and deals accordingly, perhaps it is even event based to lower leves so it might checks the entity type before having read further in the stream [21:12:37] jzerebecki: I don't see any code to that effect in https://github.com/Wikidata/Wikidata-Toolkit/blob/v0.3.0/wdtk-dumpfiles/src/main/java/org/wikidata/wdtk/dumpfiles/JsonDumpFileProcessor.java - any idea where that could be? [21:18:41] SMalyshev: the code reads to me as if it reads one entity at a time [21:19:02] so it can not be applied to JSON dump as is? [21:22:25] SMalyshev: yes it can and it is AFIK designed for that, because the parser gets to a one full entity via the iterator and then that creates as an object, the decision for which type it becomes is in https://github.com/Wikidata/Wikidata-Toolkit/blob/v0.3.0/wdtk-datamodel/src/main/java/org/wikidata/wdtk/datamodel/json/jackson/JacksonTermedDocument.java [21:27:56] jzerebecki: i look forward to an example with a pmid, perhaps with arbitrary access enabled. [21:34:06] jzerebecki: I see, thanks [21:34:35] you're welcome [21:40:55] hoo: hey do you intent to do a SWAT tomorrow? [21:42:10] No... I'm totally not up to date, so no idea [21:42:32] json dumps went awry tonight :S [21:47:33] hoo: yup -mtime -71 -delete instead of +71 deleted newer instead of older dumps. fixed script. new run was started a few hours ago. [21:47:43] Anyone here to fix a problem https://simple.wikipedia.org/wiki/Talk:Richard_Benson_(musician) - the IP is right. Changing the entry on wikidata gets me an error :) [21:49:47] jzerebecki: Yikes... so someone applied my untested script untested... fun time [21:49:48] s [21:50:51] hoo: there are 2 patches waiting on the branch and one more waiting for manual cherry pick for fixing parts of usage tracking, it seems the sentiment was to do that during a SWAT [21:52:45] jzerebecki: Do we care to restore the old dumps or probably not, I guess? [21:57:44] hoo: there was nothing in your patch about it being untested. it had +1 by others, otherwise i would have not given the go ahead on deploying it. besides it was deployed 5 days ago. :) [21:59:13] hoo: do you know of an easy way to restore them? I don't know of anyone who really needs the old ones. [21:59:34] Well, I should the last one on labs at least [21:59:39] not sure about older ones [21:59:42] I keep deleting them at will [21:59:53] * should have [22:03:26] hoo: if the dump apears soon it is probably not worth it. do you know how long it usually takes? [22:03:35] 11-11h [22:04:50] Barras: what error do you get [22:06:49] jzerebecki: sorry, already closed the page. Something that the item is already in use. [22:11:20] Barras: first go to the wikidata item linked to that page on simple, delete the link to simple then do what you tried before [22:13:14] jzerebecki: https://github.com/wmde/WikibaseDataModel/pull/341 [22:19:02] jzerebecki: Thanks. Did that now, however the linking for that name is a mess. I'd almost bet that I now made it even worse ;) [22:26:26] Barras: seems all the statements on the item linked to the not-singer on en is about the singer... [22:26:34] "23:15, 19 January 2015‎ Barras (talk | contribs)‎ . . (11,603 bytes) (-105)‎ . . (‎Removed link to [enwiki]: Richard Benson (singer))" [22:29:18] jzerebecki: I think I got it fixed now. [22:30:30] Barras: nope. the first problem might be that someone added (singer) to the not-singer on wikidata [22:31:33] * Barras remembers the good old days, when he was able to really fix those problems... unlike nowadays. [22:35:16] Hi, what is the correct process to request a review of a deleted page to have it reincluded? Do I just create a discussion page with my argument? [22:38:56] mutualadvantage: AFAIR we don't have a project page for that [22:40:09] You could probably use https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard though [22:41:03] hoo: thx