[00:17:46] (03CR) 10Hoo man: [C: 032] Drop unused code from and clean up Subscription classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186747 (owner: 10Thiemo Mättig (WMDE)) [00:20:21] (03Merged) 10jenkins-bot: Drop unused code from and clean up Subscription classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186747 (owner: 10Thiemo Mättig (WMDE)) [00:34:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (https://phabricator.wikimedia.org/T86191) (owner: 10Henning Snater) [00:36:03] (03PS10) 10Siebrand: entitytermsview: Inject link to help page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (https://phabricator.wikimedia.org/T86191) (owner: 10Henning Snater) [00:41:06] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#995554 (10Jc3s5h) I am unable to find any tool that promises to return the data in exactly the form it is stored in the Wikidata databa... [00:41:34] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184340 (https://phabricator.wikimedia.org/T86193) (owner: 10Henning Snater) [00:46:41] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183498 (owner: 10Henning Snater) [01:28:01] 3Wikidata, CirrusSearch: Restore interwiki (sister projects) results in search queries - https://phabricator.wikimedia.org/T46420#995596 (10Nemo_bis) [01:34:33] 3Wikidata, CirrusSearch: Restore interwiki (sister projects) results in search queries - https://phabricator.wikimedia.org/T46420#995606 (10Nemo_bis) [06:32:14] [13Common] 15addshore closed pull request #16: Simplify constructor code (06master...06tiiiny) 02http://git.io/FGed [07:46:26] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#995846 (10Snaterlicious) There is a behaviour difference: Description input is a textarea while the others are single-line input elements. Please provide how beha... [07:50:55] 3Wikidata, MediaWiki-extensions-WikibaseRepository: configure link for in other languages box should be a proper red link - https://phabricator.wikimedia.org/T87566#995849 (10Snaterlicious) The change was patch set 5 of https://gerrit.wikimedia.org/r/#/c/184907/5 and received a -1. If reset to that patch set, wh... [07:56:05] (03PS14) 10Henning Snater: Rearranged entity view header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183498 [07:57:37] (03PS15) 10Henning Snater: Rearranged entity view header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183498 [07:58:53] 3Wikidata, MediaWiki-extensions-WikibaseRepository: JS error when cancelling entity terms edit mode - https://phabricator.wikimedia.org/T87575#995861 (10Snaterlicious) Fixed in change set 15 of https://gerrit.wikimedia.org/r/#/c/183498/. [07:59:20] (03PS10) 10Henning Snater: Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) [08:06:28] (03PS11) 10Henning Snater: Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) [08:07:31] 3Wikidata, MediaWiki-extensions-WikibaseRepository: new lines in description - https://phabricator.wikimedia.org/T87578#995864 (10Snaterlicious) Should be fixed as of patch set 11 in https://gerrit.wikimedia.org/r/#/c/183866/. [08:08:06] (03PS8) 10Henning Snater: Implemented link to toggle language list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184340 (https://phabricator.wikimedia.org/T86193) [08:08:54] (03PS11) 10Henning Snater: entitytermsview: Fix table header and toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 (https://phabricator.wikimedia.org/T86520) [08:12:04] (03PS7) 10Henning Snater: Removed table of content bar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184629 (https://phabricator.wikimedia.org/T84913) [08:12:28] (03PS6) 10Henning Snater: Renamed FingerprintView to EntityTermsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184856 [08:12:35] (03PS11) 10Henning Snater: entitytermsview: Inject link to help page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (https://phabricator.wikimedia.org/T86191) [08:22:53] (03PS12) 10Henning Snater: entitytermsview: Inject link to help page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (https://phabricator.wikimedia.org/T86191) [08:24:02] 3Wikidata, MediaWiki-extensions-WikibaseRepository: configure link is not consistently shown/hidden - https://phabricator.wikimedia.org/T87563#995865 (10Snaterlicious) Fixed as of patch set 12 of https://gerrit.wikimedia.org/r/#/c/184907/. [08:30:12] 3Wikidata, MediaWiki-extensions-WikibaseRepository: caching difference between current language in top header and current language in in other languages box - https://phabricator.wikimedia.org/T87580#995866 (10Snaterlicious) Does that occur after purging the page cache? [08:34:03] (03CR) 10Henning Snater: [C: 032] Fix entitysearch to support Firefox smart keyword [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174387 (https://bugzilla.wikimedia.org/58467) (owner: 10Thiemo Mättig (WMDE)) [08:36:37] (03Merged) 10jenkins-bot: Fix entitysearch to support Firefox smart keyword [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174387 (https://bugzilla.wikimedia.org/58467) (owner: 10Thiemo Mättig (WMDE)) [08:51:24] (03PS1) 10Henning Snater: Fixed copyright notification [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186944 [09:01:19] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#995871 (10thiemowmde) We had some legacy code (not necessarily PHP, also JavaScript) that padded the year to 11 digits. Other code pads... [09:14:25] 3Wikidata, MediaWiki-extensions-WikibaseRepository: wrong cursor for "I accept these terms for my future edits. Do not show this message again." in in other languages box - https://phabricator.wikimedia.org/T87568#995875 (10Snaterlicious) https://gerrit.wikimedia.org/r/#/c/186944/ [09:14:40] [13Time] 15thiemowmde created 06tValDoc (+1 new commit): 02http://git.io/FGwr [09:14:40] 13Time/06tValDoc 14844df8b 15Thiemo Mättig: Fix outdated TimeValue documentation [09:16:37] [13Time] 15thiemowmde opened pull request #29: Fix outdated TimeValue documentation (06master...06tValDoc) 02http://git.io/FGrY [09:16:47] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#995876 (10thiemowmde) https://github.com/DataValues/Time/pull/29 [09:23:22] [13WikibaseDataModel] 15adrianheine comment on pull request #350 1439808f0: What about `$actualLanguageCode === null`. Can happen, too, apparently. 02http://git.io/FGo5 [09:23:54] 3Wikidata, DataValues: DataValue Time recognizes the ISO date value not very well in Korean language. - https://phabricator.wikimedia.org/T85324#995882 (10Revi) Now I tried to add [[ https://www.wikidata.org/wiki/Property:P571 | P571 ]] as 2011-04-19 (19th Apri, 2011) to [[ https://www.wikidata.org/wiki/Q483286... [09:24:05] (03CR) 10Adrian Lang: "Thanks! I think merging this now is sensible, though, since we would otherwise have to wait for a new dm release." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186166 (owner: 10Adrian Lang) [09:27:01] [13ValueView] 15adrianheine comment on pull request #151 144d0d4ee: Done. 02http://git.io/FGKj [09:27:16] [13ValueView] 15adrianheine comment on pull request #151 144d0d4ee: No, it's not allowed to be null. 02http://git.io/FG6T [09:27:42] [13ValueView] 15adrianheine pushed 1 new commit to 06uls: 02http://git.io/FG6O [09:27:42] 13ValueView/06uls 14dfcdbc1 15Adrian Heine: Better name for ContentLanguages instance [10:03:45] (03CR) 10Adrian Lang: Implemented statementgroupview widget (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186228 (https://phabricator.wikimedia.org/T87320) (owner: 10Henning Snater) [10:04:10] (03CR) 10Adrian Lang: "Needs browser tests change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185817 (owner: 10Henning Snater) [10:04:44] (03CR) 10Adrian Lang: "Following tests fail for me:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185817 (owner: 10Henning Snater) [10:06:11] (03CR) 10Adrian Lang: Implemented statementgroupview widget (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186228 (https://phabricator.wikimedia.org/T87320) (owner: 10Henning Snater) [10:06:42] [13DataValuesJavascript] 15thiemowmde created 06padding (+1 new commit): 02http://git.io/FGQK [10:06:42] 13DataValuesJavascript/06padding 143a6eee8 15Thiemo Mättig: Do not pad year on the client [10:10:53] [13DataValuesJavascript] 15thiemowmde opened pull request #59: Do not pad year on the client (06master...06padding) 02http://git.io/FG7Q [10:25:19] 3Wikidata, DataValues: DataValue Time recognizes the ISO date value not very well in Korean language. - https://phabricator.wikimedia.org/T85324#995892 (10thiemowmde) Note that "2011-04-19" is not a valid ISO timestamp our current parser setup can recognize as an ISO timestamp. It must be "+2011-04-19T00:00:00Z"... [10:31:25] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 1439808f0: Do you understand that I think this could be a problem? Why should knowledge about the API be baked into the DataModel? @JeroenDeDauw recently blocked me for exactly that reason in #334. 02http://git.io/FGAF [10:34:14] Thiemo_WMDE: https://de.wikipedia.org/wiki/Benutzer_Diskussion:Codeispoetry/Archiv6#code_cosmetica Wo liegt deine Variante nochmal? [10:40:05] [13WikibaseDataModel] 15adrianheine comment on pull request #350 1439808f0: But the other way round, why should anybody use this? What does `new TermFallback( 'en', 'text', 'en' )` express? 02http://git.io/FGhK [10:41:23] (03CR) 10Thiemo Mättig (WMDE): Drop unused use clauses from Repo (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185844 (owner: 10Thiemo Mättig (WMDE)) [10:46:50] 3Wikidata, MediaWiki-extensions-WikibaseRepository: wrong cursor for "I accept these terms for my future edits. Do not show this message again." in in other languages box - https://phabricator.wikimedia.org/T87568#995895 (10Lydia_Pintscher) [10:58:08] [13DataValuesJavascript] 15adrianheine comment on pull request #59 143a6eee8: `length` 02http://git.io/FZUX [10:58:20] [13DataValuesJavascript] 15adrianheine comment on pull request #59 143a6eee8: `String( Math.abs( number ) )` 02http://git.io/FZU7 [11:00:41] [13DataValuesJavascript] 15adrianheine comment on pull request #43 148a41e66: Why is it crucial? 02http://git.io/FZTK [11:04:38] 3Wikidata, wikidata-query-service: Update links/refs Data model according to discussed on MW Summit - https://phabricator.wikimedia.org/T87627#995906 (10Lydia_Pintscher) [11:04:50] (03PS2) 10Lydia Pintscher: Fixed copyright notification [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186944 (https://phabricator.wikimedia.org/T87568) (owner: 10Henning Snater) [11:06:17] uhm [11:06:45] most people will just try YYYY-MM-DD, not +YYYY-MM-DDT00:00:00Z [11:14:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Wikidata edits do not update "page watched" icon - https://phabricator.wikimedia.org/T87640#995908 (10Lydia_Pintscher) [11:15:57] (03PS12) 10Thiemo Mättig (WMDE): Make stuff private, fix docs and optimize use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [11:16:06] (03CR) 10Thiemo Mättig (WMDE): Make stuff private, fix docs and optimize use sections in Repo (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [11:18:39] [13WikidataBrowserTests] 15snaterlicious created 06claimtostatement (+2 new commits): 02http://git.io/FZmQ [11:18:39] 13WikidataBrowserTests/06claimtostatement 14ba18d0e 15snaterlicious: Renamed claimlistview to statementlistview [11:18:39] 13WikidataBrowserTests/06claimtostatement 14dac6210 15snaterlicious: Renamed claimgrouplistview to statementgrouplistview [11:21:00] [13WikidataBrowserTests] 15snaterlicious opened pull request #37: Renamed claim*listview to statement*listview (06master...06claimtostatement) 02http://git.io/FZYD [11:21:31] [13DataValuesJavascript] 15thiemowmde comment on pull request #43 148a41e66: It was when I played around with my version. Since this is hard/impossible to test I'm afraid to change my version (the only one that works for sure, as far as I know) to something else. 02http://git.io/FZYd [11:21:32] 3Wikidata, MediaWiki-extensions-WikibaseRepository: User interface displays false birth and death dates - https://phabricator.wikimedia.org/T87312#995918 (10Lydia_Pintscher) [11:22:36] [13DataValuesJavascript] 15thiemowmde pushed 1 new commit to 06padding: 02http://git.io/FZOm [11:22:36] 13DataValuesJavascript/06padding 14db027b2 15thiemowmde: Fix typo [11:23:43] Thiemo_WMDE: https://phabricator.wikimedia.org/T58090#989900 [11:24:21] [13DataValuesJavascript] 15thiemowmde comment on pull request #59 14db027b2: Type conversion via `'' + ...` is very common in JavaScript. I don't like calling constructors like they are functions. 02http://git.io/FZOK [11:24:37] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Wikidata edits do not update "page watched" icon - https://phabricator.wikimedia.org/T87640#995921 (10Lydia_Pintscher) p:5Triage>3Normal [11:24:46] [13DataValuesJavascript] 15thiemowmde comment on pull request #59 14db027b2: Ouch. Done. 02http://git.io/FZOy [11:24:59] (03PS3) 10Henning Snater: Renamed claimlistview to statementlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185817 [11:25:05] (03PS4) 10Henning Snater: Renamed claimgrouplistview to statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185818 [11:25:11] (03PS3) 10Henning Snater: Renamed claimgrouplabelscroll to statementgrouplabelscroll [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185819 [11:25:16] (03PS3) 10Henning Snater: Renamed ClaimsView to StatementGroupListView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185822 [11:25:21] (03PS4) 10Henning Snater: Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 [11:29:00] [13WikibaseDataModel] 15JanZerebecki comment on pull request #350 1439808f0: No even before this change the is_string check should prevent that. 02http://git.io/FZ3S [11:33:36] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 1439808f0: I suggest to implement well tested `isFallback` and `isTransliteration` (and maybe `isVariant`) methods instead of throwing exceptions. In the given example all these methods will return `false`. So yes, this means you can have a TermFallback object that is *not* a fallback. I find this much more convenient: Code that constructs Term objects does not need complicated `if` con [11:42:44] (03PS3) 10Thiemo Mättig (WMDE): Suggester visibility depend on spinner visibility [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181056 (https://phabricator.wikimedia.org/T55476) [11:45:50] [13WikidataBrowserTests] 15snaterlicious 04force-pushed 06claimtostatement from 14dac6210 to 1401af208: 02http://git.io/FZcO [11:45:50] 13WikidataBrowserTests/06claimtostatement 1401af208 15snaterlicious: Renamed claimgrouplistview to statementgrouplistview [11:46:37] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06exception-on-nonsense-fallback from 1439808f0 to 14499e8d2: 02http://git.io/Fmfn [11:46:37] 13WikibaseDataModel/06exception-on-nonsense-fallback 14499e8d2 15Jan Zerebecki: [WIP] Throw exception on creation of nonsensical Fallbacks... [11:50:18] wmde/WikibaseDataModel/exception-on-nonsense-fallback/499e8d2 : Jan Zerebecki The build is still failing. http://travis-ci.org/wmde/WikibaseDataModel/builds/48471916 [11:56:59] [13DataValuesJavascript] 15adrianheine comment on pull request #59 14db027b2: I don't think of `String` as a constructor since nobody ever uses it that way. On the other hand, it clearly states what you are trying to do. 02http://git.io/FZl4 [11:57:03] (03CR) 10Henning Snater: [C: 032] Suggester visibility depend on spinner visibility [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181056 (https://phabricator.wikimedia.org/T55476) (owner: 10Thiemo Mättig (WMDE)) [11:58:17] (03PS1) 10Adrian Lang: Fix QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186948 [11:59:21] (03Merged) 10jenkins-bot: Suggester visibility depend on spinner visibility [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181056 (https://phabricator.wikimedia.org/T55476) (owner: 10Thiemo Mättig (WMDE)) [12:00:13] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 14499e8d2: Huh? Why "was"? What does "used" mean? 02http://git.io/FZ8W [12:01:19] (03CR) 10Henning Snater: [C: 032] Fix QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186948 (owner: 10Adrian Lang) [12:04:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] statementgrouplistview: Added value() function (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186337 (owner: 10Henning Snater) [12:07:17] Henning_WMDE: cucumber features/statements_item.feature:17 # Scenario: Adding a statement of type item [12:07:19] cucumber features/statements_string.feature:17 # Scenario: Adding a statement of type string [12:07:21] cucumber features/statements_string.feature:17 # Scenario: Adding a statement of type string [12:07:23] cucumber features/statements_string.feature:40 # Scenario: Adding a statement of type string and reload page [12:18:52] (03PS5) 10Henning Snater: Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 [12:27:38] [13WikidataBrowserTests] 15snaterlicious 04force-pushed 06claimtostatement from 1401af208 to 1434b5e03: 02http://git.io/FZcO [12:27:38] 13WikidataBrowserTests/06claimtostatement 1434b5e03 15snaterlicious: Renamed claimgrouplistview to statementgrouplistview [12:29:03] 3Wikidata, Wikidata.org: Wikidata search problems (tracking) - https://phabricator.wikimedia.org/T46529#995971 (10Tobi_WMDE_SW) [12:35:06] (03CR) 10Adrian Lang: [C: 032] Renamed claimlistview to statementlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185817 (owner: 10Henning Snater) [12:35:12] (03CR) 10Adrian Lang: [C: 032] Renamed claimgrouplistview to statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185818 (owner: 10Henning Snater) [12:35:17] (03CR) 10Adrian Lang: [C: 032] Renamed claimgrouplabelscroll to statementgrouplabelscroll [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185819 (owner: 10Henning Snater) [12:35:24] (03CR) 10Adrian Lang: [C: 032] Renamed ClaimsView to StatementGroupListView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185822 (owner: 10Henning Snater) [12:35:31] (03CR) 10Adrian Lang: [C: 032] Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 (owner: 10Henning Snater) [12:36:16] [13WikidataBrowserTests] 15adrianheine pushed 1 new commit to 06master: 02http://git.io/FZVs [12:36:16] 13WikidataBrowserTests/06master 1461d4d97 15Adrian Heine né Lang: Merge pull request #37 from wmde/claimtostatement... [12:38:48] (03Merged) 10jenkins-bot: Renamed claimlistview to statementlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185817 (owner: 10Henning Snater) [12:40:40] (03Merged) 10jenkins-bot: Renamed claimgrouplistview to statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185818 (owner: 10Henning Snater) [12:41:32] (03Merged) 10jenkins-bot: Renamed claimgrouplabelscroll to statementgrouplabelscroll [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185819 (owner: 10Henning Snater) [12:41:41] (03Merged) 10jenkins-bot: Renamed ClaimsView to StatementGroupListView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185822 (owner: 10Henning Snater) [12:41:59] (03Merged) 10jenkins-bot: Removed pointless 'wikibase-statementview' wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185824 (owner: 10Henning Snater) [12:42:09] (03PS2) 10Henning Snater: Fix QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186948 (owner: 10Adrian Lang) [12:45:12] (03CR) 10Adrian Lang: [C: 032] "retrigger jenkins." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186948 (owner: 10Adrian Lang) [12:47:24] (03Merged) 10jenkins-bot: Fix QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186948 (owner: 10Adrian Lang) [13:04:30] (03PS2) 10Adrian Lang: Fixed statementview._getReferences [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186764 (https://phabricator.wikimedia.org/T87567) (owner: 10Henning Snater) [13:04:53] (03PS7) 10Henning Snater: Implemented statementgroupview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186228 (https://phabricator.wikimedia.org/T87320) [13:06:32] (03CR) 10Thiemo Mättig (WMDE): [C: 031] SnakTypeSelector: Remove 'javascript:void(0);' href [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186755 (owner: 10Henning Snater) [13:07:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Removed obsolete documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186765 (owner: 10Henning Snater) [13:16:07] (03PS4) 10Lucie Kaffee: Change to "Wikibase" on Special:SpecialPages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186179 (https://phabricator.wikimedia.org/T86153) [13:17:55] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Updated listview.ListItemAdapter documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186754 (owner: 10Henning Snater) [13:18:48] (03CR) 10Adrian Lang: [C: 032] "I'll add a test." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186764 (https://phabricator.wikimedia.org/T87567) (owner: 10Henning Snater) [13:20:54] (03Merged) 10jenkins-bot: Fixed statementview._getReferences [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186764 (https://phabricator.wikimedia.org/T87567) (owner: 10Henning Snater) [13:21:02] https://phabricator.wikimedia.org/sprint/board/1011/ [13:22:09] (03PS1) 10Adrian Lang: Add qunit test for bug T87567 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186952 [13:22:18] Henning_WMDE: ^^ [13:26:47] 3Wikidata, MediaWiki-extensions-WikibaseRepository: redesign statement section - https://phabricator.wikimedia.org/T87316#996000 (10adrianheine) [13:27:42] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Updated listview documentation (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186751 (owner: 10Henning Snater) [13:30:16] (03CR) 10JanZerebecki: [C: 032] Change to "Wikibase" on Special:SpecialPages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186179 (https://phabricator.wikimedia.org/T86153) (owner: 10Lucie Kaffee) [13:30:59] [13WikidataBrowserTests] 15snaterlicious created 06statementgroupview from 06master (+0 new commits): 02http://git.io/FZdG [13:32:09] [13WikidataBrowserTests] 15snaterlicious pushed 1 new commit to 06statementgroupview: 02http://git.io/FZd1 [13:32:09] 13WikidataBrowserTests/06statementgroupview 1474f66c3 15snaterlicious: Adapt to implementation of statementgroupview [13:33:04] [13WikidataBrowserTests] 15snaterlicious opened pull request #38: Adapt to implementation of statementgroupview (06master...06statementgroupview) 02http://git.io/FZdh [13:33:19] (03Merged) 10jenkins-bot: Change to "Wikibase" on Special:SpecialPages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186179 (https://phabricator.wikimedia.org/T86153) (owner: 10Lucie Kaffee) [13:41:53] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] snaklistview: Updated documentation (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186783 (owner: 10Henning Snater) [13:42:46] (03PS8) 10Adrian Lang: Implemented statementgroupview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186228 (https://phabricator.wikimedia.org/T87320) (owner: 10Henning Snater) [13:43:31] (03CR) 10Adrian Lang: "Removed a try-catch block." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186228 (https://phabricator.wikimedia.org/T87320) (owner: 10Henning Snater) [13:46:23] (03CR) 10Henning Snater: [C: 032] Add qunit test for bug T87567 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186952 (owner: 10Adrian Lang) [13:47:54] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See comment, +2 otherwise." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186760 (owner: 10Henning Snater) [13:48:47] (03PS2) 10Henning Snater: snaklistview: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186783 [13:48:53] (03CR) 10jenkins-bot: [V: 04-1] snaklistview: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186783 (owner: 10Henning Snater) [13:49:18] (03Merged) 10jenkins-bot: Add qunit test for bug T87567 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186952 (owner: 10Adrian Lang) [13:49:50] (03PS3) 10Henning Snater: Updated snakview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186760 [13:49:55] (03CR) 10jenkins-bot: [V: 04-1] Updated snakview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186760 (owner: 10Henning Snater) [13:54:19] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks good for me, but I have a question, see comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186786 (owner: 10Henning Snater) [13:54:53] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Updated snakview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186760 (owner: 10Henning Snater) [13:55:22] (03CR) 10Thiemo Mättig (WMDE): [C: 032] snaklistview: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186783 (owner: 10Henning Snater) [13:57:05] (03PS9) 10Adrian Lang: Implemented statementgroupview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186228 (https://phabricator.wikimedia.org/T87320) (owner: 10Henning Snater) [13:57:21] [13DataValuesJavascript] 15thiemowmde comment on pull request #59 14db027b2: I consider this personal preference and hope it's not a reason for a -1? 02http://git.io/Fnve [13:59:35] [13DataValuesJavascript] 15adrianheine comment on pull request #59 14db027b2: No and no :) We have no consensus on that, so -1 wouldn't be appropriate. Having it in our code style guide would make sense, though. 02http://git.io/Fnvh [14:03:40] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/FnJj [14:03:40] 13ValueView/06master 140832ec8 15thiemowmde: Merge pull request #151 from wmde/uls... [14:09:51] [13ValueView] 15thiemowmde created 06012 (+1 new commit): 02http://git.io/Fnko [14:09:51] 13ValueView/06012 14fc9a595 15Thiemo Mättig: Release 0.12.0 [14:11:06] (03PS3) 10Adrian Lang: statementgrouplistview: Added value() function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186337 (owner: 10Henning Snater) [14:11:24] Henning_WMDE: features/statements_item.feature:17 [14:14:13] (03CR) 10Adrian Lang: statementgrouplistview: Added value() function (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186337 (owner: 10Henning Snater) [14:14:24] (03PS3) 10Adrian Lang: Renamed wb-listview to wikibase-listview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186750 (owner: 10Henning Snater) [14:15:14] (03CR) 10Adrian Lang: [C: 031] "Browser tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186750 (owner: 10Henning Snater) [14:15:37] (03PS3) 10Adrian Lang: Updated listview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186751 (owner: 10Henning Snater) [14:16:23] (03PS3) 10Adrian Lang: listview: Moved value setting logic to _setOption [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186752 (owner: 10Henning Snater) [14:17:17] (03CR) 10Adrian Lang: [C: 032] listview: Moved value setting logic to _setOption [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186752 (owner: 10Henning Snater) [14:17:27] (03PS4) 10Adrian Lang: listview: Removed NativeEventHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186753 (owner: 10Henning Snater) [14:17:39] (03PS3) 10Adrian Lang: Updated listview.ListItemAdapter documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186754 (owner: 10Henning Snater) [14:17:48] (03PS3) 10Adrian Lang: snakview: Removed NativeEventHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186758 (owner: 10Henning Snater) [14:18:24] (03PS4) 10Adrian Lang: Updated snakview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186760 (owner: 10Henning Snater) [14:18:36] (03PS4) 10Adrian Lang: snaktypeselector: Removed NativeEventHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186761 (owner: 10Henning Snater) [14:18:48] (03PS2) 10Adrian Lang: Removed obsolete documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186765 (owner: 10Henning Snater) [14:18:57] (03PS2) 10Adrian Lang: referenceview: Removed NativeEventHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186766 (owner: 10Henning Snater) [14:19:04] (03PS2) 10Adrian Lang: snaklistview: Removed NativeEventHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186767 (owner: 10Henning Snater) [14:19:11] (03PS2) 10Adrian Lang: Renamed wb-snaklistview to wikibase-snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186772 (owner: 10Henning Snater) [14:19:18] (03PS2) 10Adrian Lang: Renamed wb-snakview/wb-snak to wikibase-snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186773 (owner: 10Henning Snater) [14:19:25] (03PS2) 10Adrian Lang: Renamed wb-referenceview to wikibase-referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186779 (owner: 10Henning Snater) [14:19:32] (03PS3) 10Adrian Lang: snaklistview: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186783 (owner: 10Henning Snater) [14:19:38] (03PS3) 10Adrian Lang: snaklistview: Removed getSnakList() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186784 (owner: 10Henning Snater) [14:19:47] (03PS2) 10Adrian Lang: Consolidated snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186786 (owner: 10Henning Snater) [14:20:51] (03CR) 10Adrian Lang: [C: 031] "Browser tests are not completely fixed yet. Otherwise, it's fine." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186228 (https://phabricator.wikimedia.org/T87320) (owner: 10Henning Snater) [14:25:33] [13WikidataBrowserTests] 15snaterlicious 04force-pushed 06statementgroupview from 1474f66c3 to 149fef559: 02http://git.io/FZdG [14:25:33] 13WikidataBrowserTests/06statementgroupview 149fef559 15snaterlicious: Adapt to implementation of statementgroupview [14:29:13] (03PS13) 10Thiemo Mättig (WMDE): Make stuff private, fix docs and optimize use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [14:47:13] 3Wikidata, Wikidata.org: Script not responding or item opens very slow - https://phabricator.wikimedia.org/T87502#996065 (10Lydia_Pintscher) [14:47:16] 3Wikidata, MediaWiki-extensions-WikibaseRepository: [UI] Front-end performance: Improve loading time of items - https://phabricator.wikimedia.org/T56098#996066 (10Lydia_Pintscher) [14:54:11] [13Diff] 15thiemowmde created 06notNull (+1 new commit): 02http://git.io/Fn0j [14:54:11] 13Diff/06notNull 14cd16e56 15Thiemo Mättig: Remove null from properties that can't be null [14:54:31] [13Diff] 15thiemowmde opened pull request #32: Remove null from properties that can't be null (06master...06notNull) 02http://git.io/FnE3 [14:57:22] wmde/Diff#125 (notNull - cd16e56 : Thiemo Mättig): The build passed. [14:57:22] Change view : https://github.com/wmde/Diff/commit/cd16e56bd6b8 [14:57:22] Build details : http://travis-ci.org/wmde/Diff/builds/48492463 [15:12:45] (03PS1) 10Henning Snater: Added basic snakview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186955 [15:19:37] [13Diff] 15thiemowmde pushed 1 new commit to 06mdLimits: 02http://git.io/FnX0 [15:19:37] 13Diff/06mdLimits 148fb7572 15Thiemo Mättig: Revert loop change [15:40:34] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06exception-on-nonsense-fallback from 14499e8d2 to 14d70bc65: 02http://git.io/Fmfn [15:40:34] 13WikibaseDataModel/06exception-on-nonsense-fallback 14d70bc65 15Jan Zerebecki: [WIP] Throw exception on creation of nonsensical Fallbacks... [15:44:50] wmde/WikibaseDataModel/exception-on-nonsense-fallback/d70bc65 : Jan Zerebecki The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/48498044 [15:47:47] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06exception-on-nonsense-fallback from 14d70bc65 to 146e6f779: 02http://git.io/Fmfn [15:47:47] 13WikibaseDataModel/06exception-on-nonsense-fallback 146e6f779 15Jan Zerebecki: [WIP] Throw exception on creation of nonsensical Fallbacks... [15:48:39] [13WikibaseDataModel] 15JanZerebecki comment on pull request #350 146e6f779: Changed, is that better? 02http://git.io/Fnxt [16:05:38] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06exception-on-nonsense-fallback from 146e6f779 to 1485c2f5a: 02http://git.io/Fmfn [16:05:38] 13WikibaseDataModel/06exception-on-nonsense-fallback 1485c2f5a 15Jan Zerebecki: [WIP] Throw exception on creation of nonsensical Fallbacks... [16:05:57] /win 25 [16:15:01] (03PS3) 10Henning Snater: Consolidated snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186786 [16:15:09] (03PS2) 10Henning Snater: Added basic snakview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186955 [16:18:59] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#996109 (10Jc3s5h) In reply to thiemowmde, P570 (Date of death; the same argument applies to P569, Date of birth) |has datatype TimeValu... [16:22:51] (03PS6) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 [16:26:21] (03PS1) 10Henning Snater: Added snakview.value() QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186959 [16:50:02] (03PS3) 10Thiemo Mättig (WMDE): Introduce WikibaseRepo::getTemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185986 [16:58:49] (03PS1) 10Thiemo Mättig (WMDE): Fix outdated doc in EntityViewPlaceholderExpanderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186960 [17:04:59] [13Diff] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/FcMC [17:04:59] 13Diff/06master 1452132ea 15Marius Hoch: Merge pull request #32 from wmde/notNull... [17:05:41] 400 Diff commits :D [17:06:24] (03PS4) 10Thiemo Mättig (WMDE): Introduce WikibaseRepo::getTemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185986 [17:07:17] [13Time] 15addshore closed pull request #29: Fix outdated TimeValue documentation (06master...06tValDoc) 02http://git.io/FGrY [17:15:36] (03CR) 10Hoo man: [C: 032] Add missing/fix documentations in Client/Lib/Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185845 (owner: 10Thiemo Mättig (WMDE)) [17:18:03] (03Merged) 10jenkins-bot: Add missing/fix documentations in Client/Lib/Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185845 (owner: 10Thiemo Mättig (WMDE)) [17:18:17] (03PS1) 10Henning Snater: Consolidated snakview value() and snak() function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186963 [17:19:36] (03PS1) 10Thiemo Mättig (WMDE): Replace TemplateRegistry::getDefaultInstance with WikibaseRepo factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186964 [17:21:44] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#996188 (10Addshore) I agree with the above. Either we fix it so all dates presented by Wikibase are actually ISO 8601 compliant or jus... [18:05:01] [13WikibaseDataModel] 15thiemowmde created 06subEquals (+1 new commit): 02http://git.io/FCnf [18:05:01] 13WikibaseDataModel/06subEquals 14b3f6a25 15Thiemo Mättig: Make Term::equals robust against subclasses [18:07:49] [13WikibaseDataModel] 15thiemowmde opened pull request #351: Make Term::equals robust against subclasses (06master...06subEquals) 02http://git.io/FCCe [18:08:29] wmde/WikibaseDataModel/subEquals/b3f6a25 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/48518127 [18:15:40] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06subEquals from 14b3f6a25 to 149c3b6ce: 02http://git.io/FC4z [18:15:40] 13WikibaseDataModel/06subEquals 149c3b6ce 15Thiemo Mättig: Make Term::equals robust against subclasses [18:31:13] [13WikibaseDataModel] 15JanZerebecki pushed 1 new commit to 06master: 02http://git.io/FCaZ [18:31:13] 13WikibaseDataModel/06master 14b7da738 15Jan Zerebecki: Merge pull request #351 from wmde/subEquals... [18:31:27] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#996335 (10Addshore) [18:31:43] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 1485c2f5a: Inconsistent punctuation, better remove everywhere. 02http://git.io/FCar [18:33:11] 3Wikidata, DataValues: DataValue Time recognizes the ISO date value not very well in Korean language. - https://phabricator.wikimedia.org/T85324#996337 (10Addshore) 2011-4-19 is clearly the 19th of April 2011, so why not parse this too? [18:34:07] (03CR) 10Hoo man: "Or... just make this a Wikibase setting?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) (owner: 10Hoo man) [18:40:24] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Please provide human readable timestamps in api response - https://phabricator.wikimedia.org/T87074#996360 (10Addshore) An alternative would be to do something similar to core, ie. do one query (get a list of entities) as some sort of generator and also run ano... [18:56:52] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 1485c2f5a: One of the later two `if`s is redundant and can be removed. What about these checks and messages:... 02http://git.io/FCPv [18:56:58] [13Diff] 15thiemowmde 04deleted 06notNull at 14cd16e56: 02http://git.io/FCXV [19:00:49] (03CR) 10Hoo man: "MediaWiki's LoadBalancer class can give us that, if we want it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) (owner: 10Hoo man) [19:14:18] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 1498427f4 to 147cf345b: 02http://git.io/0KqFLw [19:14:18] 13WikibaseDataModelSerialization/06languageFallBack 147cf345b 15Jan Zerebecki: Support TermFallback and AliasGroupFallback. [19:14:48] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 147cf345b: Done. 02http://git.io/FCh2 [19:15:05] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 147cf345b: Done. 02http://git.io/FCh1 [19:16:26] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 147cf345b: Done. 02http://git.io/FChS [19:16:27] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 147cf345b: Done. 02http://git.io/FChF [19:34:57] (03PS1) 10Thiemo Mättig (WMDE): Make stuff private by default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186987 [23:43:04] in fact, i have discussed with stats how to make the data model flexible enough to support "standalone", reusable references [23:43:13] addshore: yes, i have second thoughts, and plans to change how references are handled [23:43:17] in fact, i have discussed with stats how to make the data model flexible enough to support "standalone", reusable references [23:43:50] i think we want references to live as top level elements in entities, so they can be re-used per-page, just like on wikipedia [23:43:56] Interesting, I also thought of 2 alternative and probably slightly better ways to deal with references now! Would love to discuss :) [23:44:42] The two ways I see it are 1) references are simply entities and thus claims can point to a reference and all the reference information is reusable everywhere [23:44:47] over beet at the office? though i'll probably be talking to people about archcom stuff [23:44:58] hehe, start a mail thread in the next few days? [23:45:03] sure [23:45:17] ping me if i don't react though [23:45:28] The one thing I would like to see addresses is that entities themselves should be able to have references / something to prove their notability without actually having claims [23:46:19] hhhhmmmmmm.... not sure about that [23:46:20] Possibly alternative to what I was above is that an item has a collection of references, and those referencescan then be refered to from claims / statements [23:46:28] gah typing.. [23:46:31] use case? [23:47:13] Well in the case of wikidata, if I have an item with no statements, or an item waiting on a datatype for example there is no way to show it is notable in a structure way, closest there is currently is posting on the talkpage [23:47:37] something that has been hapening on WD is items being deleted due to not being notable, when they clearly are notable but there is nothing in the datamodel able to reflect that [23:47:44] i doubt that there is really no meaningful statement you can add [23:47:47] like "URL". [23:48:01] potentially