[00:33:57] (03PS17) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 [02:44:52] (03CR) 10Jeroen De Dauw: Implement RDF export for items and RDF dumps (Turtle only for now) (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [02:45:10] (03CR) 10Jeroen De Dauw: [C: 04-1] Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [06:12:42] (03CR) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [08:45:38] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Qualifiers disappear when adding them together with creating a statement - https://phabricator.wikimedia.org/T90400#1058339 (10matej_suchanek) It happens when you edit more than one statement at the same moment. [09:08:09] [13Diff] 15thiemowmde created 06bool (+1 new commit): 02http://git.io/AwMo [09:08:09] 13Diff/06bool 14d57f301 15Thiemo Mättig: Favor shortcut "bool" in PHPDoc tags [09:09:34] [13Diff] 15thiemowmde opened pull request #34: Favor shortcut "bool" in PHPDoc tags (06master...06bool) 02http://git.io/AwMp [09:10:48] wmde/Diff#131 (bool - d57f301 : Thiemo Mättig): The build passed. [09:10:48] Change view : https://github.com/wmde/Diff/commit/d57f3014815d [09:10:48] Build details : http://travis-ci.org/wmde/Diff/builds/51802983 [09:21:28] [13Diff] 15thiemowmde created 06integer (+1 new commit): 02http://git.io/Aw9m [09:21:28] 13Diff/06integer 141cc90a5 15Thiemo Mättig: Favor shortcut "int" in PHPDoc tags [09:22:15] [13Diff] 15thiemowmde opened pull request #35: Favor shortcut "int" in PHPDoc tags (06master...06integer) 02http://git.io/Aw9B [09:24:23] wmde/Diff#133 (integer - 1cc90a5 : Thiemo Mättig): The build passed. [09:24:23] Change view : https://github.com/wmde/Diff/commit/1cc90a540d50 [09:24:23] Build details : http://travis-ci.org/wmde/Diff/builds/51804361 [09:25:03] [13WikibaseDataModel] 15thiemowmde created 06double (+1 new commit): 02http://git.io/AwHt [09:25:03] 13WikibaseDataModel/06double 14762f6cf 15Thiemo Mättig: Favor float over alias double [09:26:44] [13WikibaseDataModel] 15thiemowmde opened pull request #389: Favor float over alias double (06master...06double) 02http://git.io/AwHi [09:29:00] wmde/WikibaseDataModel/double/762f6cf : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/51804664 [09:30:26] [13Diff] 15thiemowmde created 06composerMd (+1 new commit): 02http://git.io/AwQb [09:30:26] 13Diff/06composerMd 143cb3a8b 15Thiemo Mättig: Re-enable disabled PHPMD rules [09:30:38] [13Diff] 15thiemowmde opened pull request #36: Re-enable disabled PHPMD rules (06master...06composerMd) 02http://git.io/Aw7U [09:31:43] [13Diff] 15Krinkle comment on commit 14acd15a0: Yes. 02http://git.io/Aw7B [09:34:26] [13Diff] 15thiemowmde 04force-pushed 06mdLimits from 148fb7572 to 14738c151: 02http://git.io/Aw53 [09:34:26] 13Diff/06mdLimits 14738c151 15Thiemo Mättig: Allow running phpmd separately [09:35:31] wmde/Diff#135 (composerMd - 3cb3a8b : Thiemo Mättig): The build passed. [09:35:31] Change view : https://github.com/wmde/Diff/commit/3cb3a8b9be6f [09:35:31] Build details : http://travis-ci.org/wmde/Diff/builds/51805092 [09:38:38] [13Diff] 15thiemowmde 04force-pushed 06mdLimits from 14738c151 to 14c02a230: 02http://git.io/Aw53 [09:38:38] 13Diff/06mdLimits 14c02a230 15Thiemo Mättig: Allow running phpmd separately [09:39:45] wmde/Diff#137 (mdLimits - 738c151 : Thiemo Mättig): The build has errored. [09:39:45] Change view : https://github.com/wmde/Diff/compare/8fb75729789c...738c151cec44 [09:39:45] Build details : http://travis-ci.org/wmde/Diff/builds/51805428 [09:42:14] [13Diff] 15thiemowmde 04force-pushed 06deprecated from 142b1835f to 1435ab480: 02http://git.io/Awdx [09:42:14] 13Diff/06deprecated 1435ab480 15Thiemo Mättig: Make @deprecated tags more descriptive [09:44:09] [13Diff] 15thiemowmde created 06noVendor (+1 new commit): 02http://git.io/AwFE [09:44:09] 13Diff/06noVendor 14e836f1d 15Thiemo Mättig: Don't access vendor/bin in composer ci [09:45:24] [13Diff] 15thiemowmde opened pull request #37: Don't access vendor/bin in composer ci (06master...06noVendor) 02http://git.io/AwF9 [09:46:28] [13Diff] 15thiemowmde 04force-pushed 06noVendor from 14e836f1d to 14ab0cead: 02http://git.io/Awb3 [09:46:28] 13Diff/06noVendor 14ab0cead 15Thiemo Mättig: Don't access vendor/bin in composer ci [09:47:11] [13WikibaseDataModel] 15thiemowmde created 06noVendor (+1 new commit): 02http://git.io/Awbu [09:47:12] 13WikibaseDataModel/06noVendor 14121e0a1 15Thiemo Mättig: Don't access vendor/bin in composer ci [09:47:26] [13WikibaseDataModel] 15thiemowmde opened pull request #390: Don't access vendor/bin in composer ci (06master...06noVendor) 02http://git.io/Awb2 [09:55:03] wmde/Diff#143 (noVendor - e836f1d : Thiemo Mättig): The build has errored. [09:55:03] Change view : https://github.com/wmde/Diff/commit/e836f1d65f0d [09:55:03] Build details : http://travis-ci.org/wmde/Diff/builds/51806321 [09:58:16] wmde/Diff#145 (noVendor - ab0cead : Thiemo Mättig): The build passed. [09:58:16] Change view : https://github.com/wmde/Diff/compare/e836f1d65f0d...ab0cead3a624 [09:58:16] Build details : http://travis-ci.org/wmde/Diff/builds/51806511 [09:59:56] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06nullIdParser from 1469dd9bf to 1434affc3: 02http://git.io/HlKjUA [09:59:56] 13WikibaseDataModel/06nullIdParser 1434affc3 15Thiemo Mättig: More specific exception messages in DispatchingEntityIdParser [10:01:30] wmde/WikibaseDataModel/noVendor/121e0a1 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/51806609 [10:07:29] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06nullIdParser from 1434affc3 to 14e96c023: 02http://git.io/HlKjUA [10:07:29] 13WikibaseDataModel/06nullIdParser 14e96c023 15Thiemo Mättig: More specific exception messages in DispatchingEntityIdParser [10:15:46] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06dupeCode: 02http://git.io/ArfT [10:15:46] 13WikibaseDataModel/06dupeCode 149461a0e 15Thiemo Mättig: protected [10:18:11] wmde/WikibaseDataModel/dupeCode/9461a0e : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/51809129 [10:33:01] [13Diff] 15thiemowmde created 06arrays (+1 new commit): 02http://git.io/ArIm [10:33:01] 13Diff/06arrays 14c4cdb5f 15Thiemo Mättig: More specific array type hints/docs [10:34:16] [13Diff] 15thiemowmde opened pull request #38: More specific array type hints/docs (06master...06arrays) 02http://git.io/ArIi [10:35:37] wmde/Diff#147 (arrays - c4cdb5f : Thiemo Mättig): The build passed. [10:35:37] Change view : https://github.com/wmde/Diff/commit/c4cdb5f68b58 [10:35:37] Build details : http://travis-ci.org/wmde/Diff/builds/51810743 [10:39:31] [13Diff] 15thiemowmde created 06phpFails (+1 new commit): 02http://git.io/ArtR [10:39:31] 13Diff/06phpFails 144ed757a 15Thiemo Mättig: Simplify DiffOpTest::instanceProvider a bit [10:40:24] [13Diff] 15thiemowmde opened pull request #39: Simplify DiffOpTest::instanceProvider a bit (06master...06phpFails) 02http://git.io/ArtF [10:42:09] wmde/Diff#149 (phpFails - 4ed757a : Thiemo Mättig): The build passed. [10:42:09] Change view : https://github.com/wmde/Diff/commit/4ed757a75c77 [10:42:09] Build details : http://travis-ci.org/wmde/Diff/builds/51811252 [10:56:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Feature switch for using subscription mechanism for change propagation. - https://phabricator.wikimedia.org/T88419#1058516 (10daniel) a:5daniel>3None unassigning, pushed. [11:02:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: h1 underline does not extend full width of wikibase-entityview-main - https://phabricator.wikimedia.org/T90426#1058535 (10aude) 3NEW [11:07:55] 10Wikidata, 10§ Wikidata-Sprint-2015-02-03, 5Patch-For-Review: spec of how timevalue works and is supposed to work - https://phabricator.wikimedia.org/T88438#1058546 (10thiemowmde) 1. The timestamp is stored in the **calendar model** indicated by the URI and not converted to Gregorian. This decision was made... [11:34:32] (03PS1) 10Thiemo Mättig (WMDE): Simplify 5-digit-year regex in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192295 [11:37:04] (03CR) 10jenkins-bot: [V: 04-1] Simplify 5-digit-year regex in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192295 (owner: 10Thiemo Mättig (WMDE)) [11:38:19] (03CR) 10Daniel Kinzler: Implement RDF export for items and RDF dumps (Turtle only for now) (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [11:48:08] (03PS1) 10Thiemo Mättig (WMDE): Test years with leading zeros in DateTimeParserTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192297 [11:49:56] (03CR) 10Daniel Kinzler: [C: 04-1] "A few comments, but nothing critical." (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [11:51:34] (03CR) 10jenkins-bot: [V: 04-1] Test years with leading zeros in DateTimeParserTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192297 (owner: 10Thiemo Mättig (WMDE)) [12:06:51] (03PS1) 10Thiemo Mättig (WMDE): Rework and fix issues in DateTimeParserTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192300 [12:09:14] (03PS1) 10Aude: Adjust edit buttons and h1 header css in entitytermsview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192301 (https://phabricator.wikimedia.org/T89956) [12:09:32] (03CR) 10jenkins-bot: [V: 04-1] Rework and fix issues in DateTimeParserTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192300 (owner: 10Thiemo Mättig (WMDE)) [12:10:17] is there a API query to get only Q1633802 (25978 Katerudolph) or other asteroid ? [12:11:22] (03CR) 10jenkins-bot: [V: 04-1] Adjust edit buttons and h1 header css in entitytermsview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192301 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [12:12:38] what, is jenkins broken? [12:13:13] PHP Fatal error: Class 'FormatJson' not found [12:13:14] fun [12:14:00] https://wdq.wmflabs.org/api?q=claim%5B31:3863%5D ansers all asteroids, but I couldn't get with property "25978".. [12:14:01] :D [12:15:53] magewhopper: Property 25978? [12:17:30] sjoerddebruin: it's asteroid No. [12:17:52] !p 25978 [12:17:52] https://www.wikidata.org/wiki/Property:P25978 [12:21:25] not that mean, we seems not have property as asteroid No. is there a property as series No.? [12:24:02] magewhopper: I thought P528 was intended to use with that. [12:24:25] It's included within https://www.wikidata.org/wiki/Template:Astronomical_objects_properties [12:24:58] Examples: https://www.wikidata.org/wiki/Q4658 [12:26:11] * aude rage at DanielK_WMDE ! [12:27:13] you fix https://phabricator.wikimedia.org/T88254 .... if you can do better [12:27:56] how would you fix? [12:28:02] sjoerddebruin: Ooh seems hard work ! thanks! [12:28:06] (03PS2) 10Lucie Kaffee: Update json dump documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191907 (https://phabricator.wikimedia.org/T87329) [12:30:38] (03CR) 10jenkins-bot: [V: 04-1] Update json dump documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191907 (https://phabricator.wikimedia.org/T87329) (owner: 10Lucie Kaffee) [12:36:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7I18n: wikibase-setlabeldescriptionaliases-introfull needs GENDER support and qqq documentation - https://phabricator.wikimedia.org/T90431#1058667 (10Amire80) 3NEW [12:38:12] (03PS3) 10Lucie Kaffee: Update json dump documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191907 (https://phabricator.wikimedia.org/T87329) [12:40:37] (03CR) 10jenkins-bot: [V: 04-1] Update json dump documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191907 (https://phabricator.wikimedia.org/T87329) (owner: 10Lucie Kaffee) [12:46:41] (03CR) 10Daniel Kinzler: [C: 04-1] "Looks sane, and gets rid of a lot of duplicate code. Some thoughts and comments inline. CR-1 for unclear scope of the new renderer class." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189415 (https://phabricator.wikimedia.org/T48160) (owner: 10Hoo man) [12:48:48] 10Wikibase-DataModel, 10Wikidata: create documentation of php data model - https://phabricator.wikimedia.org/T75604#1058704 (10Snaterlicious) {F45608} Added DataTypes::DataType. [13:14:03] (03PS1) 10Thiemo Mättig (WMDE): Add fail-safe for YYYY-00-00 to DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192306 (https://phabricator.wikimedia.org/T87574) [13:16:27] (03CR) 10jenkins-bot: [V: 04-1] Add fail-safe for YYYY-00-00 to DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192306 (https://phabricator.wikimedia.org/T87574) (owner: 10Thiemo Mättig (WMDE)) [13:17:27] What to do with redirects to global userpages? https://www.wikidata.org/w/index.php?title=User:DGarry_(WMF)&redirect=no [13:21:46] Let it be [13:22:42] Or edit to point to Meta, as it was a rename [13:23:06] Anyway, it shows up in https://www.wikidata.org/wiki/Special:BrokenRedirects [13:23:22] Not a problem here, but imagine that on a large project... [13:23:23] Yeah I figured that was the concern [13:24:02] Should I create a task for that? [13:24:08] Interwiki redirects don't show up, do they [13:25:02] Those show up a soft redirects I thought [13:25:46] Keeping track of the inconsistency is fine [13:26:03] Dunno what's worth doing about it though [13:32:45] (03PS1) 10Thiemo Mättig (WMDE): Fix detection of 3-digit YYY-MM-DD in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192307 [13:34:34] (03CR) 10jenkins-bot: [V: 04-1] Fix detection of 3-digit YYY-MM-DD in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192307 (owner: 10Thiemo Mättig (WMDE)) [13:35:19] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Tracking: Wikidata watchlist integration (tracking) - https://phabricator.wikimedia.org/T90435#1058757 (10daniel) 3NEW [13:40:53] (03PS1) 10Thiemo Mättig (WMDE): Add more tests with leading zeros [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192308 [13:42:45] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: Wikipedia RSS feeds show Wikidata changes very confusingly. - https://phabricator.wikimedia.org/T88254#1058771 (10daniel) [13:42:45] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Incorrect links for external changes in client watchlist atom and rss feeds - https://phabricator.wikimedia.org/T90392#1058772 (10daniel) [13:43:06] (03CR) 10jenkins-bot: [V: 04-1] Add more tests with leading zeros [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192308 (owner: 10Thiemo Mättig (WMDE)) [13:43:32] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Incorrect links for external changes in client watchlist atom and rss feeds - https://phabricator.wikimedia.org/T90392#1057463 (10daniel) [13:43:33] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Testme: RSS feed missing Wikidata edit summaries - https://phabricator.wikimedia.org/T78493#1058776 (10daniel) [13:43:34] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]) - https://phabricator.wikimedia.org/T46874#1058777 (10daniel) [13:43:35] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: Wikipedia RSS feeds show Wikidata changes very confusingly. - https://phabricator.wikimedia.org/T88254#1007192 (10daniel) [13:43:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Wikidata edits should be recognizable in the watchlist API module - https://phabricator.wikimedia.org/T47082#1058778 (10daniel) [13:43:37] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Tracking: Wikidata watchlist integration (tracking) - https://phabricator.wikimedia.org/T90435#1058773 (10daniel) [13:45:35] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Incorrect links and empty diff in client recentchanges rss and atom feeds - https://phabricator.wikimedia.org/T90393#1058781 (10aude) [13:46:13] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Testme: Recent changes RSS feed missing Wikidata edit summaries / diff and incorrect links - https://phabricator.wikimedia.org/T78493#1058783 (10aude) [13:47:08] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Recent changes RSS feed missing Wikidata edit summaries / diff and incorrect links - https://phabricator.wikimedia.org/T78493#846779 (10aude) [13:48:25] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Improve usage tracking granularity to avoid irrelevant changes from being shown in watchlist. - https://phabricator.wikimedia.org/T90436#1058786 (10daniel) 3NEW [13:49:00] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Improve usage tracking granularity to avoid irrelevant changes showing in the watchlist. - https://phabricator.wikimedia.org/T90436#1058786 (10daniel) [13:50:40] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Recent changes RSS feed missing Wikidata edit summaries / diff and incorrect links - https://phabricator.wikimedia.org/T78493#1058796 (10daniel) [13:50:41] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: Wikipedia RSS feeds show Wikidata changes very confusingly. - https://phabricator.wikimedia.org/T88254#1058795 (10daniel) [13:51:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Tracking: Wikidata watchlist integration (tracking) - https://phabricator.wikimedia.org/T90435#1058797 (10daniel) [13:51:37] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Consolidate localization of edit summaries on repo and client. - https://phabricator.wikimedia.org/T47279#1058798 (10daniel) [13:57:11] DanielK_WMDE: aude: Seen https://phabricator.wikimedia.org/T90405 ? [13:57:29] That was spamming the logs [13:57:52] hmmm, that's new to me [13:58:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: HttpError from line 359 of EntityDataRequestHandler.php - https://phabricator.wikimedia.org/T90270#1058803 (10JanZerebecki) This might be an actual internal error. Where is that error from? https://www.wikidata.org/wiki/Special:EntityData/Q13529975.json a... [13:58:23] MessageUpdateJob? [13:58:30] No idea what that is [13:59:05] like it's trying to do secondary updates also? [13:59:11] doEditUpdates [13:59:16] which already were done [13:59:25] yeah, I guess so [13:59:37] * aude doesn't have Translate installed currently [13:59:54] In the end we just need to make things more robust against double invocations and things like that [13:59:59] yep [14:00:13] even then, it shouldn't trip over a duplicate key... i'll investigate [14:00:26] ok :) [14:00:31] * aude is looking at https://phabricator.wikimedia.org/T90430 [14:00:45] MessageUpdateJob sais " Job for updating translation pages." [14:00:59] i don't actually see FormatJson in HashBagOStuff so not sure what's going on [14:01:08] interaction with the translate extension, once more [14:01:20] i'm starting to be really annoyied by that thing [14:01:25] :/ [14:01:34] DanielK_WMDE: Starting? :D [14:01:37] Have you ever used it [14:01:42] annoyd. annoyed. whatever [14:01:47] * aude installed it at one point [14:01:48] hoo: i.... tried... [14:02:06] had to disable it for some reason (phpunit test failures?) [14:02:15] sanity? [14:03:47] has if ( !defined( 'MW_PHPUNIT_TEST' ) ) { require_once "$IP/extensions/BetaFeatures/BetaFeatures.php"; } [14:04:00] Funniest thing is vandalism there... it can take minutes to properly clean that up, while it only took the vandal a few moments to insert [14:04:07] same thing for central auth [14:04:25] Problem with CentralAuth and unit tests is that it wants a shared database [14:04:30] yeah [14:04:34] but the test stuff can't clone theses shared tables [14:04:44] should be solveable, but no one tried, yet [14:04:49] yep [14:08:12] lovely, i get a fatal error if i run php maintenance/install.php [14:08:20] and haven't run composer install yet [14:08:26] Yeah, that's known [14:08:30] I bet there's a bug for that [14:08:34] probably [14:08:47] should at least be a more friendly error and not fatal + stack trace [14:08:50] (03PS1) 10Thiemo Mättig (WMDE): Major rewrite of DateTimeParser::getValueWithFixedYearLengths [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192313 [14:09:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: InvalidArgumentException from line 57 of SuggestionGenerator.php - https://phabricator.wikimedia.org/T90269#1058815 (10JanZerebecki) https://www.wikidata.org/w/api.php?action=wbsgetsuggestions&search=xyz123&context=item&format=json&language=en&type=propert... [14:10:12] i don't actually see a bug [14:11:03] (03CR) 10jenkins-bot: [V: 04-1] Major rewrite of DateTimeParser::getValueWithFixedYearLengths [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192313 (owner: 10Thiemo Mättig (WMDE)) [14:11:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: InvalidArgumentException from line 57 of SuggestionGenerator.php - https://phabricator.wikimedia.org/T90269#1058816 (10aude) @JanZerebecki could have been a timing issue, such as with a new item. i think these were all newly created items. [14:13:50] (03PS1) 10Thiemo Mättig (WMDE): Trim leading zeros from 5+ digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192314 [14:15:38] (03CR) 10jenkins-bot: [V: 04-1] Trim leading zeros from 5+ digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192314 (owner: 10Thiemo Mättig (WMDE)) [14:18:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: InvalidArgumentException from line 57 of SuggestionGenerator.php - https://phabricator.wikimedia.org/T90269#1058832 (10JanZerebecki) I think that means this happened shortly after the item was created and because of slave lag wasn't visible to the suggeste... [14:21:15] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: SqlUsageTracker: Duplicate entry for key 'eu_entity_id' - https://phabricator.wikimedia.org/T90405#1058835 (10daniel) a:3daniel [14:21:35] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: SqlUsageTracker: Duplicate entry for key 'eu_entity_id' - https://phabricator.wikimedia.org/T90405#1057876 (10daniel) add to sprint [14:29:32] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: SqlUsageTracker: Duplicate entry for key 'eu_entity_id' - https://phabricator.wikimedia.org/T90405#1058847 (10daniel) From looking at the code in UsageUpdater, SqlUsageTracker, and UsageTableUpdater, it seems like this should... [14:30:28] (03PS1) 10Daniel Kinzler: Ignore duplicate key conflicts when inserting into wbc_entity_usage. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192316 (https://phabricator.wikimedia.org/T90405) [14:30:49] (03PS1) 10Thiemo Mättig (WMDE): Rename DateTimeParser to PhpDateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192317 [14:30:49] hoo, aude: --^ [14:32:39] (03CR) 10jenkins-bot: [V: 04-1] Ignore duplicate key conflicts when inserting into wbc_entity_usage. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192316 (https://phabricator.wikimedia.org/T90405) (owner: 10Daniel Kinzler) [14:32:54] * aude is installing new packages and it's rebuilding all my maps stuff (mapnik...) [14:32:57] time for coffee [14:33:46] Yay, broken tests [14:33:50] Known? [14:34:08] (03CR) 10jenkins-bot: [V: 04-1] Rename DateTimeParser to PhpDateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192317 (owner: 10Thiemo Mättig (WMDE)) [14:38:19] [13Time] 15thiemowmde created 06timeIsoFormatter (+1 new commit): 02http://git.io/Aoul [14:38:19] 13Time/06timeIsoFormatter 14d56b7d4 15Thiemo Mättig: Drop dead code from TimeFormatter [14:38:35] hoo: yea, looking. no idea.... Class 'FormatJson' not found in /mnt/jenkins-workspace/workspace/mwext-Wikibase-repo-tests/includes/objectcache/HashBagOStuff.php on line 87 [14:38:52] FormatJSon is not used in HashBagOfStuff. [14:38:59] There is, in fact, no code in line 87. [14:39:09] yeah, that's weird [14:39:51] hashar isn't around... [14:40:30] [13Time] 15thiemowmde opened pull request #38: Drop dead code from TimeFormatter (06master...06timeIsoFormatter) 02http://git.io/AozG [14:46:12] hoo, aude: i think we can go past jenkins for the key conflict fix, it's a one-liner. [14:47:24] (03CR) 10Hoo man: [C: 032 V: 032] Ignore duplicate key conflicts when inserting into wbc_entity_usage. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192316 (https://phabricator.wikimedia.org/T90405) (owner: 10Daniel Kinzler) [14:47:27] Ok [14:47:30] backport worthy? [14:47:32] :) [14:47:37] how bad is it spamming? [14:47:52] your call. [14:48:17] actually... do backport [14:48:28] it may prevent entries from being entered into the tracking table [14:48:35] * aude would like https://gerrit.wikimedia.org/r/#/c/192296/ reviewed [14:49:25] it's annoying to see the error + stacktrace when i load a repo page here [14:49:28] aude: Trivial :) [14:49:31] yay [14:50:02] $ grep -c UsageTrackerException exception.log [14:50:02] 0 [14:50:12] seems like it hasn't been a problem today [14:51:01] $ zgrep -c UsageTrackerException archive/exception.log-20150223.gz [14:51:01] 11 [14:51:17] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/191499/ [14:51:37] hoo: not a big issue then [14:51:43] aude: Looked at that... but how can it cause taht error? [14:51:55] hoo: strict standards [14:52:15] aude: I mean the FormatJson one [14:52:18] oh [14:52:19] no idea [14:53:27] wikimedia/mediawiki-extensions-Wikibase/master/0ce9082 : daniel The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/51836802 [14:53:41] hoo: might be something cached on jenkins instance [14:53:45] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: SqlUsageTracker: Duplicate entry for key 'eu_entity_id' - https://phabricator.wikimedia.org/T90405#1058880 (10hoo) 5Open>3Resolved [14:53:50] apc cache broken [14:53:55] aude: Very well possible [14:54:05] outdated/ inconsistent class map [14:54:10] we clone mediawiki core differently than (almost) everyone else [14:54:14] for wikibase jobs [14:54:47] someone could probably poke at those things, if they have right permissions [14:54:51] on the boxes [14:55:27] few people have [14:55:33] Krinkle, hashar [14:55:43] maybe ^d [14:55:54] :/ [14:56:02] lego is getting access but not yet [14:56:10] and might not be around yet [14:56:34] All us-folks (but hashar) [14:56:53] afaik krinkle is not in the us now [14:57:31] see him around sometimes in our hours [14:57:32] mh... maybe "contint-admins:" would be enough access [14:57:36] those are quite some people [14:57:38] maybe [14:57:53] but again mostly people in the us [14:58:02] :/ [14:58:18] Reedy: Here at any chance? [14:58:28] unlikely [14:58:30] Reedy: can you help? jenkins seems stuck on a strange issue, it fails for all things wikibase. the error message is nonsense. [14:58:55] aude: You could ask for access, hopefully wont be such a mess as my permission request for dumps [14:59:11] but I don't really feel like asking for more access now :P [14:59:28] not sure i know enough what i'm doing [14:59:44] even though helped setup wikidata-jenkins [15:00:55] Having access doesn't mean you have to act [15:01:02] true [15:01:07] could at least look :) [15:04:57] [13Time] 15thiemowmde created 06isoParser (+1 new commit): 02http://git.io/AoPf [15:04:57] 13Time/06isoParser 14ea725e5 15Thiemo Mättig: Rename TimeParser to IsoDateTimeParser [15:09:53] [13Time] 15thiemowmde opened pull request #39: Rename TimeParser to IsoDateTimeParser (06master...06isoParser) 02http://git.io/Ao15 [15:17:25] wow... people are loading complete entities in Lua just to access the id :P [15:17:27] 10Wikidata, 10§ Wikidata-Sprint-2015-02-03, 5Patch-For-Review: spec of how timevalue works and is supposed to work - https://phabricator.wikimedia.org/T88438#1058979 (10Jc3s5h) thiemowmde's comment of Monday, Feb. 23, 11:07 seems to only consider parsers and validators known to the development team. Maybe it... [15:17:42] hoo: o_O [15:17:55] omg [15:38:57] (03CR) 10Daniel Kinzler: [C: 04-1] "The design looks good, found some minor issues with the implementation." (0324 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [15:39:44] 24 comments, wow [15:40:20] hoo: it's a complex class, from scratch... [15:40:26] no big issues though [15:40:37] except maybe the behavior when passing an empty list of ids. [15:40:45] Not entirely from scratch... much of that is duplication with the EntityRevisionLookup [15:40:51] (please have a test case for that) [15:40:59] ugh duplication :/ [15:41:01] yea, i know, recognized some of the code [15:41:39] 10Wikidata, 10§ Wikidata-Sprint-2015-02-03, 5Patch-For-Review: spec of how timevalue works and is supposed to work - https://phabricator.wikimedia.org/T88438#1059026 (10thiemowmde) > only consider parsers and validators known to the development team. I'm describing what the development team decided, what's... [15:41:40] aude: no direct duplication. covering both use cases with the same code added a lot of complexity. [15:41:46] hm [15:41:47] it's better to have these separate [15:42:36] otherwise, you get a lot of if/then/else multi-option multi-purpose crap [15:44:03] the other one was convenient to use, but the code was hell [15:44:14] (earlier patch sets) [15:49:25] [13WikibaseDataModel] 15thiemowmde 04deleted 06fallBackDocs at 1437f6124: 02http://git.io/AKf2 [15:56:08] DanielK_WMDE: Any chance you can have a look at the one outstanding Capiunto change at some point? [15:56:17] That's the only thing blocking a deployment to beta [15:56:25] would be nice to have that merged when I'm back from exams [15:56:55] hoo: looking at your langlinks page currently [15:57:04] ok [15:57:05] trying to go through all the big old changes today & tomorrow [15:57:11] $wgResourceLoaderMaxQueryLength = 4096; [16:02:23] [13WikibaseDataModel] 15thiemowmde created 06actualLangCode (+1 new commit): 02http://git.io/AKLr [16:02:23] 13WikibaseDataModel/06actualLangCode 145729e7e 15Thiemo Mättig: More descriptive Term/AliasGroup docs [16:04:49] [13WikibaseDataModel] 15thiemowmde opened pull request #391: More descriptive Term/AliasGroup docs (06master...06actualLangCode) 02http://git.io/AKtd [16:07:23] wmde/WikibaseDataModel/actualLangCode/5729e7e : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/51846683 [16:11:26] Lots of work since the start of this year. https://www.wikidata.org/w/index.php?title=Wikidata:The_Game/Flagged_items&diff=199253867&oldid=185215860 [16:15:09] (03CR) 10Hoo man: "Various replies, would be great to get some answers so that I can amend" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189415 (https://phabricator.wikimedia.org/T48160) (owner: 10Hoo man) [16:18:09] sjoerddebruin: trying to clean my own backlog but many of these items are orphaned afters hoo bot's edits [16:18:21] Yeah, just finished my own backlog. [16:18:22] so I don't know if they should be kept [16:18:35] Orphaned? [16:18:57] I meant they have no sitelinks [16:19:03] Yeah, or redirects. [16:19:14] these too [16:20:48] Or wrong way of merging. :/ https://www.wikidata.org/w/index.php?title=Q656093&action=history [16:22:38] It's common, should we put a notice when the user tries to remove a sitelink? [16:23:03] there is for newbies [16:24:23] I wonder why there's still so many manual merges then [16:25:21] the notice doesn't suggest the correct way of merging... maybe worth including [16:26:24] Merge- or move-gadget. Other stuff is highly annoying. [16:28:48] You can use the Special page, but that's too slow for me [16:29:12] hah https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/51836804 [16:29:29] sqlite + php 5.3 [16:29:42] hoo: DanielK_WMDE ^ [16:29:55] of course, i had to upgrade my php :/ [16:30:08] but only on 5.3? [16:30:13] apparently so [16:30:36] i could probably easily switch back [16:30:39] mh... I still have a server running 5.3, but I doubt I have an up to date mediawiki on it [16:30:44] just a symlink, basically [16:32:11] Date: Mon Dec 16 21:41:17 2013 +0000 [16:32:17] that's not exactly up to date :P [16:38:48] * aude tries vagrant [16:39:25] doesn't look as simple to downgrade, though doable if i must [16:39:48] but vagrant has 5.5.9 [16:41:24] You guys are aware that the error that shows up when you want to restore a version but a site link is already used in a other item, shows in plain text (showing the html)? [16:42:50] sjoerddebruin: i'm not aware, please file it on phabricator :) [16:42:52] sjoerddebruin: I've seen this myself and vaguely remember it [16:43:01] Will search Phab first. [16:43:01] not sure we have a bug, just file one [16:43:15] on https://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/builds/51849387, it passes except strange error for sqlite + hhvm [16:43:42] the bug you mean has been filled even twice [16:44:16] Seems like a page not visit often by devs. :P [16:44:30] matej_suchanek: Do you have links? [16:44:35] yes, https://phabricator.wikimedia.org/T84890 and the second one [16:45:04] Okay. [16:45:05] [13WikibaseDataModel] 15thiemowmde created 06refListconst# (+1 new commit): 02http://git.io/AK2L [16:45:05] 13WikibaseDataModel/06refListconst# 14e6835a9 15Thiemo Mättig: Fix ReferenceList accepting anything [16:45:37] (03CR) 10Daniel Kinzler: [C: 032 V: 031] "The code looks sensible, and appears to work as intended." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://phabricator.wikimedia.org/T61391) (owner: 10Hoo man) [16:45:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7I18n: The messages Wikibase-validator-sitelink-conflict and Wikibase-undo-title show HTML when used as an error after trying to reset an item page - https://phabricator.wikimedia.org/T85340#1059180 (10Sjoerddebruin) Can confirm this, can somebody fix th... [16:46:09] Weird to see it triaged "normal". [16:46:42] sjoerddebruin: Oh, ther eis a bug [16:46:50] [13WikibaseDataModel] 15thiemowmde opened pull request #392: Fix ReferenceList accepting anything (06master...06refListconst#) 02http://git.io/AKam [16:46:59] Yup. [16:47:15] sjoerddebruin: I'll have a look [16:47:40] *insert common Lydia emoticon* [16:48:08] hoo: maybe similar to https://phabricator.wikimedia.org/T68043 [16:48:11] Insert some cat content, developers like cat content [16:48:34] :) [16:48:42] matej_suchanek: Can remember seeing HTML in those notices and also in the client widget for adding links. [16:48:47] matej_suchanek: That was JavaScript issue... although it seems similar it's not :P [16:49:08] (03Merged) 10jenkins-bot: Always link to the repo if we don't have any language links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://phabricator.wikimedia.org/T61391) (owner: 10Hoo man) [16:49:23] wmde/WikibaseDataModel/refListconst#/e6835a9 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/51852754 [16:50:19] (03CR) 10Hoo man: "bug has been fixed in the mean time.. abandon?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182655 (https://phabricator.wikimedia.org/T85752) (owner: 10Gerrit Patch Uploader) [16:51:07] jenkins gate and submit approved.... https://gerrit.wikimedia.org/r/#/c/168632/ [16:51:12] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 7Performance: Insert link item for adding language links in PHP - https://phabricator.wikimedia.org/T63391#1059204 (10hoo) 5Open>3Resolved a:3hoo https://gerrit.wikimedia.org/r/168632 has been merged. [16:51:18] jenkins is not broken anymore? [16:51:34] Maybe not? [16:51:44] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: Insert link item for adding language links in PHP - https://phabricator.wikimedia.org/T63391#1059208 (10hoo) [16:51:54] (03PS2) 10Aude: Adjust edit buttons and h1 header css in entitytermsview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192301 (https://phabricator.wikimedia.org/T89956) [16:52:20] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Not allowed attributes on the edit link - https://phabricator.wikimedia.org/T85752#1059210 (10hoo) [16:53:32] hi, having something that looks like a CORS problem [16:53:44] the wikibase repo cannot edit certain fields [16:53:47] just a random guess, maybe https://gerrit.wikimedia.org/r/#/c/192296/ was the issue and fixed it [16:53:55] maybe confused apc or something weird [16:54:07] daniel's patch was merged before that [16:54:25] aude: Given that we're speaking of PHP 5.3... could be... [16:54:29] yeah [16:54:42] anyway, rebased one of my patches and shall see [16:54:48] despens: Can you be more specific, please? What exactly does not work for you? [16:54:51] (03CR) 10Fomafix: "When the bug is fixed on an other way this change can abandoned." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182655 (https://phabricator.wikimedia.org/T85752) (owner: 10Gerrit Patch Uploader) [16:54:52] the repo interface makes this call: https://catalog.rhizome.org//api.php?action=wbgetentities&format=json&origin=https%3A%2F%2Fcatalog%2Erhizome%2Eorg&ids=P35&languages=en [16:55:06] which is answered with a 403 [16:55:35] the repo? [16:55:45] How old is your Wikibase version? [16:55:46] i think we uses php strict [16:55:56] [13WikibaseDataModel] 15thiemowmde opened pull request #393: Merge master into 3.0.x-dev (063.0.x-dev...06master) 02http://git.io/AKKq [16:55:57] hoo: yes, when i want to edit a field of type Commons [16:56:04] i just git-pulled the latest version [16:56:05] (03Abandoned) 10Hoo man: Remove not allowed attributes from edit link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182655 (https://phabricator.wikimedia.org/T85752) (owner: 10Gerrit Patch Uploader) [16:56:34] the request doesn't send along the required "origin" header field, so api.php doesn't allow access [16:56:47] I wonder why it sets the origin field [16:56:55] on repo we just use a plain mw.Api for the requests [16:57:01] jenkins approves of my rebase [16:57:02] and that never sets an origin parameter [16:57:03] it sets origin in params, but not in header [16:57:13] only very old Wikibase version were "smarter" than that [16:57:42] is there something else that i need to do but doing 'git pull'? [16:57:48] aude: didn't EventLogging do some weird stuff with Json? [16:58:05] I remember something like taht vaguely... on errors [16:58:34] hoo: i usually do git pull, composer update, the run the update.php maintenance script [16:58:36] but we wouldn't have event logging on travis [16:58:46] oh, of course, yes [16:58:51] and probably not these jenkins jobs [16:59:10] i've seen something about strict when running tests [17:00:45] despens: mh... store.ApiEntityStore? [17:01:17] * aude happy anyway when one bug fix magically fixes another bug :) [17:01:21] as seems to be [17:01:26] Yeah :) [17:01:42] aude: Maybe the file change purged APC for that file? [17:01:46] hoo: ? is that a database table? [17:01:50] could be [17:01:53] no, a JavaScript module [17:02:05] wb.store.ApiEntityStore [17:03:11] hoo: ok, what to do with it? it has a method called 'createFunction' apparently :) [17:03:21] though bad apc cache on travis + jenkins? [17:03:26] anyway, seems fixed [17:03:51] despens: It has an injected repoApi... I wonder how that can have an origin parameter set [17:04:12] how can I check? [17:04:32] Deprecated configuration setting "strict" used [17:04:48] 10Wikidata, 10§ Wikidata-Sprint-2015-02-03, 5Patch-For-Review: spec of how timevalue works and is supposed to work - https://phabricator.wikimedia.org/T88438#1059279 (10Jc3s5h) >>! In T88438#1059026, @thiemowmde wrote: >> only consider parsers and validators known to the development team. > > I'm describing... [17:06:36] filbertkm/mediawiki-extensions-Wikibase/master/698a3d2 : aude The build passed. http://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/builds/51853558 [17:06:44] :) [17:07:26] despens: Ok, seems like this has changed [17:07:30] wikimedia/mediawiki-extensions-Wikibase/master/e0c5a4d : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/51853686 [17:07:43] if your settings are incorrect we indeed try to use cors for the local domain [17:10:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: wikidata qunit test on labs-vagrant have errors - https://phabricator.wikimedia.org/T90459#1059315 (10JanZerebecki) 3NEW [17:10:51] despens: Check your wgServer etc. settings [17:10:58] 10Wikidata, 10Datasets-General-or-Unknown, 6operations: Wikidata dumps contain old-style serialization. - https://phabricator.wikimedia.org/T74348#1059331 (10ArielGlenn) Hello? Any wikidata dumps consumers on this ticket? Otherwise I'll ask in xmlatadumps-l. [17:11:04] maybe you have www in there in some places but not in others? [17:12:42] 10Wikidata, 10§ Wikidata-Sprint-2015-02-03, 5Patch-For-Review: spec of how timevalue works and is supposed to work - https://phabricator.wikimedia.org/T88438#1059340 (10thiemowmde) Perfect, thank you very much! The `calendartime` field is, as far as I can tell, a planned extension that was never implemented... [17:18:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: h1 underline does not extend full width of wikibase-entityview-main - https://phabricator.wikimedia.org/T90426#1059373 (10Aklapper) [17:19:01] 10Wikidata, 5Patch-For-Review: Edit button in heading overlaps alias text - https://phabricator.wikimedia.org/T89956#1059374 (10Aklapper) [17:28:44] (03PS1) 10Hoo man: Don't implicitly parse messages passed to OutputPage::addWikiText [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192344 (https://phabricator.wikimedia.org/T85340) [17:29:56] Maybe message should warn if toString gets called... [17:30:16] I've seen this hide problems so often [17:32:26] (03CR) 10Daniel Kinzler: [C: 04-1] "Looks fine, except that it's unclear if the system message containing the localized calendar names is intended to be raw HTML." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188400 (owner: 10Thiemo Mättig (WMDE)) [17:35:08] (03CR) 10Daniel Kinzler: [C: 032] Use named precision constant [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189001 (owner: 10Thiemo Mättig (WMDE)) [17:37:26] (03CR) 10Daniel Kinzler: [C: 032] Don't implicitly parse messages passed to OutputPage::addWikiText [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192344 (https://phabricator.wikimedia.org/T85340) (owner: 10Hoo man) [17:37:46] (03Merged) 10jenkins-bot: Use named precision constant [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189001 (owner: 10Thiemo Mättig (WMDE)) [17:39:42] (03Merged) 10jenkins-bot: Don't implicitly parse messages passed to OutputPage::addWikiText [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192344 (https://phabricator.wikimedia.org/T85340) (owner: 10Hoo man) [17:40:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7I18n: The messages Wikibase-validator-sitelink-conflict and Wikibase-undo-title show HTML when used as an error after trying to reset an item page - https://phabricator.wikimedia.org/T85340#1059459 (10hoo) 5Open>3Resolved a:3hoo >>! In T85340#1059... [17:43:23] hoo: i added $wgCrossSiteAJAXdomains = array( '*.rhizome.org' ); [17:43:31] but that doesn't change anything [17:43:47] No, that's not the problem [17:43:47] is this CORS? i don't see any preflight requests [17:44:06] Some setting makes Wikibase believe it needs to use CORS there [17:44:16] but jQuery is smarter and doesn't use cors [17:44:22] i see! [17:44:29] so you get a mixture of the origin parameter but no the header [17:45:02] could this be the dreaded sites table? [17:45:30] hi [17:45:33] I'm pretty sure it's a setting [17:45:33] I'm here now [17:45:52] Anyway... I'm away for food [17:46:08] DanielK_WMDE: Would be nice, if you could reply to my replies on the lua consolidation [17:48:23] 10Wikidata, 10§ Wikidata-Sprint-2015-02-03, 5Patch-For-Review: spec of how timevalue works and is supposed to work - https://phabricator.wikimedia.org/T88438#1059500 (10Jc3s5h) In response to thiemowmde's post of Mon., Feb. 23, 17:21, I suggest that rather than marking //calendartime// obsolete, we mark it r... [17:48:55] hoo|away: we are discussing it now :) [17:49:00] bikeshedding... [17:52:58] is there a way to find out how the repo frontend decides to include the origin parameter in a request? [17:55:15] what part of the wb javascript makes this call to the api? [17:59:43] (03PS1) 10Thiemo Mättig (WMDE): Show raw badge id instead of failing in DiffView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192352 [18:05:47] (03CR) 10Daniel Kinzler: "HTH" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189415 (https://phabricator.wikimedia.org/T48160) (owner: 10Hoo man) [18:06:57] despens: It's a little complicated [18:07:29] You want to make sure your wgServer and wgScriptPath are correct [18:07:45] i have checked these configs and they look fine to me: [18:08:08] $wgServer = "https://catalog.rhizome.org"; [18:08:24] $wgScriptPath = ""; [18:08:30] $wgArticlePath = "/w/$1"; [18:09:10] i just noticed a double slash in the request string: https://catalog.rhizome.org//api.php?action=wbgetentities&format=json&origin=https%3A%2F%2Fcatalog%2Erhizome%2Eorg&ids=P35&languages=en [18:09:23] after the domain name [18:10:07] Yeah, that's not nice, but shouldn't be a problem [18:10:12] despens: that's possible, but not the recommended setup; in particular, your script directory overlaps (contains) your (cirtual) article directory, which isn't good practice. [18:10:47] despens: best practice is having the script path be /w/, and the article path be /wiki/ [18:10:59] DanielK_WMDE: could that lead to the CORS confusion tho? [18:11:07] despens: can you give me the value of mw.config.get( 'wbRepo' ) (on any item page) [18:11:25] despens: works for wikipedia, doesn't it? [18:12:06] hoo: http://dpaste.com/2VNX9SF [18:12:08] despens: but my comments are unrelated to what you are discussing with hoo. except that the fact that the script path is empty my invite some interresting edge cases [18:14:01] despens: Oh, doh [18:14:05] you hit a stupid bug there [18:14:25] we assume that everything until the last // is a protocol [18:14:31] but that's not true :P [18:14:56] oh :) [18:15:29] hoo: nice catch! [18:15:33] but where does the double slash come from? [18:15:47] despens: We append /api.php to the scriptpath [18:16:06] so it *is* triggered by an edge case cause by an empty script path :) [18:16:11] ok, so here is the edge case ... [18:16:28] noooo [18:16:38] for testing, set the script path to "." [18:17:01] but that should still work [18:17:09] wgServer is not supposed to end on a slash [18:17:42] hoo: re Capiunto: Lego sais it should use addModulesStyles, not addModules. Want to change that, while you are at it? [18:17:54] DanielK_WMDE: Didn't I already? [18:18:26] $this->getParser()->getOutput()->addModuleStyles( 'capiunto.infobox.main' ) [18:18:30] hoo: .... [18:18:38] apparently i was looking at thej wrong version, sorry [18:18:43] got confused by the rebase or something [18:18:55] despens: Dah.... I hate how we do setting [18:19:03] hoo: $wgServer is slashless here [18:19:06] your client's 'repoUrl' setting [18:19:07] (03CR) 10Daniel Kinzler: [C: 032] Conditionally add the "capiunto.infobox.main" RL module [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163065 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [18:19:13] does it end on a slahs? [18:19:23] Because that's assumed to be == $wgServer [18:19:39] hoo: but it's called url, so it actually *should* end in a / :) [18:19:58] woah, that's old [18:20:05] DanielK_WMDE: grmbl [18:20:09] :P [18:20:13] :D [18:20:33] In production it doesn't [18:20:53] yea, probably the code wouldn't like it [18:20:54] i did mw.config.set('wbRepo', { url: "https://catalog.rhizome.org/", scriptPath: ".", articlePath: "/w/$1" }) [18:20:56] i was just going by the name [18:21:08] but the request is still double slash [18:21:31] it might be some url consolidation is detecting the useless dot [18:21:32] despens: You need to remove the slash sever side [18:21:35] in you LocalSettings [18:21:53] Should be save, we also don't have it in WMF produciton [18:22:06] hoo: we should have code to normalize this stuff [18:23:01] (03CR) 10jenkins-bot: [V: 04-1] Conditionally add the "capiunto.infobox.main" RL module [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163065 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [18:23:42] test failures are unrelated Scribunto failures [18:25:20] hoo: i don't have trailing slashes anywhere, and if i put '.' into $wgScriptPath, disaster strikes, no resources apart from the html are loaded from the server [18:25:42] not even the skin css [18:26:41] despens: Look into the client setting I posted above [18:26:42] please [18:27:04] javascript? [18:27:12] WikibaseClient [18:27:25] (03PS1) 10Hoo man: Make protocol removing in getLocationAgnosticMwApi non greedy [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/192362 [18:27:49] (03CR) 10jenkins-bot: [V: 04-1] Make protocol removing in getLocationAgnosticMwApi non greedy [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/192362 (owner: 10Hoo man) [18:28:19] * hoo rages about unrelated failures today [18:28:25] (03PS1) 10Thiemo Mättig (WMDE): Fix broken undo error message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192364 (https://phabricator.wikimedia.org/T85340) [18:29:29] (03CR) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [18:29:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7I18n: The messages Wikibase-validator-sitelink-conflict and Wikibase-undo-title show HTML when used as an error after trying to reset an item page - https://phabricator.wikimedia.org/T85340#1059685 (10thiemowmde) 5Resolved>3Open The headline is stil... [18:30:11] (03CR) 10Smalyshev: "Daniel, tests are not finished yet. PRODUCE_ALL is OK since it covers all other modes, but not everything is tested yet. Be ready for upda" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [18:30:42] (03CR) 10Hoo man: [V: 032] "Test failures are unrelated." [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163065 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [18:34:23] hoo: i don't understand what you mean. LocalSettings? [18:34:59] There's a file called LocalSettings.php in the root folder of your wiki install [18:35:02] Can you open it? [18:35:06] DanielK_WMDE: https://phabricator.wikimedia.org/T90114 [18:35:07] yes [18:35:42] Ok, look for a client setting called repoUrl there [18:35:51] $wgWbClientSettings['repoUrl'] or so [18:36:24] m| [18:36:41] I think it's all $wgWbSettings these days. Didn't we deprecate $wgWbClientSiettings a while back? [18:36:52] DanielK_WMDE: The other way around [18:37:51] DanielK_WMDE: looks like I'll have to do a serious refactoring of RdfBuilderTest, otherwise it'll be unmanageable... [18:38:33] hoo: thanks! that was it [18:38:48] SMalyshev: yes... but this is really an indicator for the fact that RdfBuilder itself should eb refactored. More separate units under test, less complexity in the tests. [18:38:54] however, can i use my own uploaded images here from my local wiki? [18:38:57] smaller classes, smaller methods -> simpelr tests [18:39:26] it shows files from wiki commons, but not my own [18:39:36] DanielK_WMDE: not sure about separate tests, since all the tests do the same - build graph, check graph. But I'll split data generation in smaller functions [18:39:59] despens: commonsMedia isn't flexible enough for that, I'm afraid [18:39:59] e.g. getTestGraphs() won't have all the code anymore [18:40:05] didn't I tell you that before [18:40:41] hoo: you said it might not work, yes [18:40:55] now i know ;) [18:44:56] despens: you can set up one of your wikis as the file repository for all the wikis in your "farm". [18:45:30] despens: https://www.mediawiki.org/wiki/Manual:$wgForeignFileRepos [18:45:46] DanielK_WMDE: thnX0rz [18:45:57] 10Wikidata, 10MediaWiki-extensions-Capiunto, 5Patch-For-Review: performance review for Capiunto - https://phabricator.wikimedia.org/T71540#1059757 (10hoo) 5Open>3Resolved Resolved all issues pointed out here (especially the preprocessing). [18:46:15] Wohooooo for that :P [18:46:25] DanielK_WMDE: will the repo interface draw from it then tho? [18:50:29] (03PS2) 10Thiemo Mättig (WMDE): Fix HtmlTimeFormatter for negative years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188397 [18:50:31] (03PS2) 10Thiemo Mättig (WMDE): HtmlTimeFormatter should display unknown calendar models [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188400 [18:51:10] (03CR) 10Thiemo Mättig (WMDE): "I inlined the pretty trivial method and made use of it by adding an exists check." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188400 (owner: 10Thiemo Mättig (WMDE)) [18:51:43] multichill: Ik zag je stamboomproject. Ben je bezig met scripts ofzo? [18:53:10] waar valt daar iets over te zien ? [18:53:37] GerardM-: Er is nog niet veel te zien. [18:53:51] https://www.wikidata.org/wiki/Wikidata:WikiProject_Genealogy :P [18:54:42] (03CR) 10jenkins-bot: [V: 04-1] HtmlTimeFormatter should display unknown calendar models [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188400 (owner: 10Thiemo Mättig (WMDE)) [18:54:42] DanielK_WMDE: i already set $wgUseInstantCommons = false for a long time. so i guess the commons data type doesn't respect $wgForeignFileRepos[] [18:54:44] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "See suggestion in comment. We can merge this as it is, please decide." (031 comment) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/192362 (owner: 10Hoo man) [18:54:46] ik vind het ook leuk om daar wat van toe te voegen ... ziet er leuk uit in Reasonator [18:54:59] DanielK_WMDE: source of the java script somewhere? [18:55:35] de code van Magnus is modulair [18:57:11] (03CR) 10Thiemo Mättig (WMDE): "Or https://gist.github.com/jlong/2428561 ... is that worth it?" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/192362 (owner: 10Hoo man) [18:58:40] Thiemo_WMDE: Wow... that's awesomely simple [18:58:48] GerardM-: Toch jammer dat ik nooit de stamboom kan zien van Willem-Alexander etc., een limiet zou fijn zijn. [18:58:50] But I don't think we need it [18:59:02] DanielK_WMDE: might be possible to inject another url via gadget [18:59:08] But still, thanks for pointing that out, I'm sure that can come in handy at some point [18:59:20] ask and ye will be given [18:59:55] despens: oh, you mean for COmmonsMedia? Yea, I'm afraid that isn't very flexible. You may be able to force a URL somewhere... [19:00:07] GerardM-: Ik heb al maanden echter geen nieuwe feature in de Reasonator gezien. Verwacht ook niks. [19:00:33] DanielK_WMDE: is there a js source available for the commons media repo interface? [19:00:44] despens: seems to be hardcoded in jquery.ui.suggester.js and jquery.ui.commonssuggester.js [19:00:50] seems to be purely a frontend issue [19:00:54] should be configurable i guess [19:00:57] Ik heb ook niets gevraagd [19:01:30] despens: all source is available, otherwise you couldn't run it :) [19:01:34] DanielK_WMDE: No, also in lib/includes/formatters/CommonsLinkFormatter.php [19:01:49] The two above are for editing [19:01:53] that one is the actual formatter [19:01:56] yea, you are right [19:02:08] DanielK_WMDE: yes, it is just so much source, don't know where to look :) [19:02:08] despens: just grep for commons.wikimedia.org [19:02:20] DanielK_WMDE: ! [19:02:24] but use grep -l [19:02:33] if you ignore tests and files that are not js or php, it should just be three [19:02:38] yea [19:02:54] or better, ack-grep --php --js [19:03:22] yeah, ack is awesome :D [19:03:35] had to teach it about json though [19:04:02] http://beyondgrep.com/ In case anyone doesn't know it [19:04:05] weet je er werd geroepen .. "we gaan dat in Mobile doen " [19:07:48] (03PS2) 10Hoo man: Fix broken undo error message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192364 (https://phabricator.wikimedia.org/T85340) (owner: 10Thiemo Mättig (WMDE)) [19:08:10] (03PS3) 10Hoo man: Fix broken undo error message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192364 (https://phabricator.wikimedia.org/T85340) (owner: 10Thiemo Mättig (WMDE)) [19:11:41] (03CR) 10Hoo man: Fix broken undo error message (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192364 (https://phabricator.wikimedia.org/T85340) (owner: 10Thiemo Mättig (WMDE)) [19:11:56] (03PS2) 10Thiemo Mättig (WMDE): Fix detection of 3-digit YYY-MM-DD in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192307 [19:11:58] (03PS2) 10Thiemo Mättig (WMDE): Add fail-safe for YYYY-00-00 to DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192306 (https://phabricator.wikimedia.org/T87574) [19:12:00] (03PS2) 10Thiemo Mättig (WMDE): Add more tests with leading zeros [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192308 [19:12:02] (03PS2) 10Thiemo Mättig (WMDE): Simplify 5-digit-year regex in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192295 [19:12:04] (03PS2) 10Thiemo Mättig (WMDE): Major rewrite of DateTimeParser::getValueWithFixedYearLengths [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192313 [19:12:06] (03PS2) 10Thiemo Mättig (WMDE): Test years with leading zeros in DateTimeParserTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192297 [19:12:08] (03PS2) 10Thiemo Mättig (WMDE): Trim leading zeros from 5+ digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192314 [19:12:10] (03PS2) 10Thiemo Mättig (WMDE): Rename DateTimeParser to PhpDateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192317 [19:12:12] (03PS2) 10Thiemo Mättig (WMDE): Rework and fix issues in DateTimeParserTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192300 [19:14:04] (03CR) 10Hoo man: "I guess this should be merged as is." (031 comment) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/192362 (owner: 10Hoo man) [19:14:35] sjoerddebruin: Hee, kwam die van hall er nog ergens in een rapportje uit? [19:14:49] multichill: ? [19:15:14] sjoerddebruin: https://www.wikidata.org/wiki/User_talk:Multichill#Vraagje [19:15:32] Ehm ja, bij de verdachte data van Pasleim. [19:15:38] (ouder dan 130 jaar) [19:16:01] https://www.wikidata.org/wiki/User:Pasleim/Implausible/age [19:17:37] Ben wat met stamboompjes aan het spelen, best leuk [19:17:47] Ja, daar vroeg ik dus net al naar. [19:18:44] Oh, ja, sorry, gemist sjoerddebruin. Kwam binnen, laptop aan en toen gaan koken [19:18:48] Geen ping gehad [19:18:52] :/ [19:19:00] Ik vroeg of je ook bezig was met gerelateerde scripts. [19:19:28] Nee, ik heb een tijdje geleden wel wat infoboxen leeggehaald volgens mij, maar daar was de score wat mager [19:19:34] (03CR) 10jenkins-bot: [V: 04-1] Test years with leading zeros in DateTimeParserTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192297 (owner: 10Thiemo Mättig (WMDE)) [19:19:45] Puur een aantal lijnen handmatig gedaan om te zien hoe dat ging [19:20:02] Het is veels teveel edits eigenlijk [19:20:08] Vooral als je alles netjes wil sourcen [19:20:12] GerardM-: did you ever blog about wdq? [19:20:20] (03CR) 10Thiemo Mättig (WMDE): Make protocol removing in getLocationAgnosticMwApi non greedy (031 comment) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/192362 (owner: 10Hoo man) [19:20:21] Naja, ik had het meer over scripts die lijstjes spugen. [19:20:30] hi YuviPanda|zzz, back from holidayzz? [19:20:37] I did but not recently [19:20:42] multichill: yes! although working on IST now [19:20:44] I should and I did not [19:20:46] GerardM-: can you link? [19:20:52] Lijstjes om in Wikidata te zetten of lijstjes gebaseerd op Wikidata? [19:21:01] oh [19:21:01] ok [19:21:17] http://ultimategerardm.blogspot.nl/2014/12/wikidata-wdq-with-load-balancing.html is the latest [19:21:22] YuviPanda|zzz: As in Indian time? [19:21:22] Nou ja, een lijstje met waarschijnlijke familieleden, op basis van interne links. [19:21:59] Indien de interne link voor zoveel procent overeenkomt met de paginanaam en tevens niet gelinkt is in het Wikidata-item, pleur hem ergens neer. [19:22:02] https://www.wikidata.org/w/index.php?title=Q13564530&curid=15239047&diff=199257868&oldid=184638692 <- hier loopt wel al een bot voor [19:22:19] Ja, voor het inversen loopt een bot. [19:22:41] nice [19:22:42] multichill: ken je https://tools.wmflabs.org/wikidata-todo/linked_items.php [19:22:43] it’s not updating right now [19:22:44] and I can’t actually look at the code since I don’t really know C++ [19:22:44] and magnus is busy with real life [19:23:13] yuvi as I understand it, the process is broken [19:23:15] (03CR) 10Thiemo Mättig (WMDE): Fix broken undo error message (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192364 (https://phabricator.wikimedia.org/T85340) (owner: 10Thiemo Mättig (WMDE)) [19:23:15] Wel eens gezien GerardM-, wat kan ik daar precies mee? [19:23:33] the waiting is for you to load the latest dump I understand [19:23:36] YuviPanda|zzz: You can still import dumps? [19:23:50] lijstjes in WIkipedia importeren in WIkidata [19:24:10] sjoerddebruin it is for importing into WDQ [19:24:19] yeah [19:24:37] (03PS2) 10Thiemo Mättig (WMDE): Do not display meaningless Z in DateTime diffs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191634 [19:24:43] (03PS2) 10Thiemo Mättig (WMDE): Always pad year to 4 digits in DateTime diffs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191640 [19:24:46] GerardM-: nope, it is supposed to update from the API, and the code is broken. so even if I update from the API (which I will), it will be stale until the next API dump [19:24:49] (03PS2) 10Thiemo Mättig (WMDE): Use actual minus sign for timestamp in DateTime diffs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191641 [19:25:17] GerardM-: Reply here please so sjoerddebruin can also see it [19:25:18] (03PS2) 10Thiemo Mättig (WMDE): Make stuff in SpecialNewEntity private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191659 [19:25:31] let me find the instructions to import dumps I sent magnus [19:25:31] gebruik dat voor het importeren van prijzen in Wikidata (als ze als een lijstje in Wikipedia staan) [19:25:47] Inclusief jaartal? [19:25:52] when the latest dump is in there Magnus may have another look [19:25:58] he will not until that time [19:26:09] as I understand it the process is broken at the Wikidata end [19:26:41] what process? [19:26:54] https://phabricator.wikimedia.org/P325 [19:26:58] and multichill has access to the project :D [19:27:34] * YuviPanda|zzz makes multichill projectadmin [19:27:39] aaaaahhh [19:27:42] so even if you can’t do the import, delegate someone to? [19:27:51] My work week is 3 days this week and than workshop in Bern [19:27:55] actually [19:28:38] so, nobody feels really responsible for maintaining the wdq instance, is that it? [19:28:39] fun times :) [19:28:52] DanielK_WMDE: well, it’s puppetized and runs fine :) [19:28:56] or is magnus just blocked somehow? [19:29:02] it requires constant feeding once a week [19:29:12] doesn't sound too bad [19:29:24] DanielK_WMDE: and it’s also multithreaded C++ code that I’m personally afraid to touch [19:29:37] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix property name in WikibaseContentLanguages (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191559 (owner: 10Adrian Lang) [19:29:45] YuviPanda|zzz: who wouldn't be [19:29:47] GerardM-: right, so multichill has projectadmin now, and there are instructions too :D [19:29:52] it might reach out and swallow your soul [19:30:04] DanielK_WMDE: yup, yup! so there’s a bug causing it to not update, and nobody wants to touch it because multithreaded C++ [19:30:35] sounds like a task for magnus [19:31:03] yup, but he’s busy with personal IRL tasks atm [19:31:15] I’m mostly putting out all these info so that GerardM- has someone who is not me to bug :) [19:31:40] (am on a phone connection on a bus, might drop off any time) [19:31:44] Max might have fun finding the bug :P [19:33:11] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "An improvement for sure. I would like to double-check some details." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191907 (https://phabricator.wikimedia.org/T87329) (owner: 10Lucie Kaffee) [19:34:12] I’m going to sleep now [19:34:21] sleep well ... :) [19:34:40] DanielK_WMDE: I could of course just add you to the project ;-) [19:35:05] multichill: you can. in fact, add aude and hoo, too. [19:35:14] no promise i'll do anything. but having access won't hurt [19:36:00] +1 [19:36:29] multichill: maybe mail us a link, so we even know the name of the project, and how to log in :P [19:36:57] DanielK_WMDE: You assume I know that [19:37:20] we should make YuviPanda write a mail to all of us, then :) [19:37:38] multichill, GerardM-: Enige idee wat we als overlijdensdatum hier moeten neerzetten? https://nl.wikipedia.org/wiki/Johannes_Sachariassen [19:38:26] sjoerddebruin: de Nederlandse Wikipedia doet niet aan categorieen voor overlijdensjaar [19:38:35] geen idee immers geen interesse [19:38:55] multichill: DanielK_WMDE I did pastebin it [19:39:06] Ik vraag dit in een Wikidata-kanaal, dan bedoel ik natuurlijk een statement op Wikidata. [19:39:16] https://phabricator.wikimedia.org/P325 [19:39:23] (03CR) 10Daniel Kinzler: [C: 04-1] "Nice refactoring, thanks!" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183233 (owner: 10Adrian Lang) [19:39:54] DanielK_WMDE: https://wikitech.wikimedia.org/wiki/Nova_Resource:Wdq-mm/SAL [19:40:25] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "In general I agree that max-width should be replaced with a padding. Then it's possible to reset the one and only max-with in user CSS and" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192301 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [19:40:30] hoo, DanielK_WMDE: i had to change two hard coded urls and the suggester showed me local uploads. that was easy. [19:41:14] despens: awsome! If you feel up to it, make it configurable, and submit the patch to gerrit :) [19:43:54] would love to! i think i don't know enough about where this configuration is available and where it is set by the user [19:45:10] where would the user express that they don't want to use commons or what commons they want? [19:52:27] despens: all config comes from $wgWbRepoSettings. Defaults are in Wikibase.default.php. [19:53:06] How these settings are made available in JS i'm not sure, but it should be easy enough to find out, if you follow the path of repoURL from the settings array to the client side JS. [19:53:38] DanielK_WMDE: question: are we supposed to export deprecated statements too in the dump? [19:54:13] I'd say so [19:54:55] we are supposed to get rid of them in other means [19:58:47] 10Wikidata, 10§ Wikidata-Sprint-2015-02-03, 5Patch-For-Review: spec of how timevalue works and is supposed to work - https://phabricator.wikimedia.org/T88438#1060091 (10daniel) @Js3s5h: Just a note about Julian dates in ISO format: Wikipedia sais: >ISO 8601 fixes a reference calendar date to the Gregorian c... [19:58:58] SMalyshev: in the fully reified dump, yes [19:59:24] 10Wikidata, 10Continuous-Integration: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1060104 (10JanZerebecki) Currently all the HTTP responses inside that jobs have size 0, i.e. no content. Probably should add the apache error log to the build artifacts to be... [19:59:25] DanielK_WMDE: ok, thanks. Just making sure :) [20:00:42] 10Wikidata, 10Wikimedia-Site-requests: Convert all `sites` tables to use https URLs - https://phabricator.wikimedia.org/T85754#1060118 (10tomasz) [20:13:06] aude: forking Wikibase? :) [20:14:58] (03CR) 10Aude: "I am splitting this into two patches, one for each bug, and adjusting per Thiemo's suggestion." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192301 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [20:15:14] JeroenDeDauw: of course :) [20:15:44] [13Diff] 15JeroenDeDauw comment on pull request #36 143cb3a8b: Considering this counts private methods, I rather not decrease this 02http://git.io/Aila [20:15:58] (03PS3) 10Aude: Make h1 header css in entitytermsview full width [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192301 (https://phabricator.wikimedia.org/T90426) [20:16:28] [13Diff] 15JeroenDeDauw comment on pull request #36 143cb3a8b: It's excluded above no? 02http://git.io/Ail5 [20:18:10] [13Diff] 15JeroenDeDauw closed pull request #39: Simplify DiffOpTest::instanceProvider a bit (06master...06phpFails) 02http://git.io/ArtF [20:19:38] [13Diff] 15JeroenDeDauw comment on pull request #38 14c4cdb5f: I'm not a big fan of adding param docs for test methods in most cases 02http://git.io/Ai4Y [20:19:48] [13Diff] 15JeroenDeDauw 04deleted 06arrays at 14c4cdb5f: 02http://git.io/Ai48 [20:20:24] [13Diff] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/Ai4S [20:20:24] 13Diff/06master 147a6d1e0 15Jeroen De Dauw: Merge pull request #37 from wmde/noVendor... [20:21:19] [13Time] 15JeroenDeDauw comment on pull request #39 14ea725e5: Needs updating 02http://git.io/AiBZ [20:23:40] what is the best way to install easyRdf? Shouldn't it be installed when running composer? [20:26:51] despens: it should, i think [20:26:52] despens: composer [20:29:54] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/Aiu5 [20:29:54] 13WikibaseDataModel/06master 14c5ed4db 15Jeroen De Dauw: Merge pull request #390 from wmde/noVendor... [20:31:33] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06dupeCode at 149461a0e: 02http://git.io/AizS [20:32:13] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06actualLangCode at 145729e7e: 02http://git.io/AigG [20:33:45] (03CR) 10Daniel Kinzler: [C: 04-1] Do not display meaningless Z in DateTime diffs (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191634 (owner: 10Thiemo Mättig (WMDE)) [20:33:52] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #393: Merge master into 3.0.x-dev (063.0.x-dev...06master) 02http://git.io/AKKq [20:36:03] (03CR) 10Daniel Kinzler: [C: 04-1] Always pad year to 4 digits in DateTime diffs (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191640 (owner: 10Thiemo Mättig (WMDE)) [20:37:13] (03CR) 10Daniel Kinzler: [C: 032] Use actual minus sign for timestamp in DateTime diffs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191641 (owner: 10Thiemo Mättig (WMDE)) [20:41:35] 10MediaWiki-extensions-WikibaseRepository: RdfBuilder - https://phabricator.wikimedia.org/T90484#1060256 (10despens) 3NEW [20:42:08] 10MediaWiki-extensions-WikibaseRepository: RdfBuilder error on trying to getLanguageCode() - https://phabricator.wikimedia.org/T90484#1060268 (10despens) [20:46:52] (03CR) 10Daniel Kinzler: "even simpler..." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192295 (owner: 10Thiemo Mättig (WMDE)) [20:49:45] 10Wikidata, 7Performance: Migrate all relevant Lua modules from mw.wikibase.getEntity to mw.wikibase.getEntityObject - https://phabricator.wikimedia.org/T88950#1060279 (10Ricordisamoa) >>! In T88950#1056777, @Ricordisamoa wrote: >>>! In T88950#1056773, @Lydia_Pintscher wrote: >> That'd be nice. Can link https:... [20:56:15] (03CR) 10Daniel Kinzler: [C: 032] Fix HtmlTimeFormatter for negative years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188397 (owner: 10Thiemo Mättig (WMDE)) [20:58:13] (03CR) 10Daniel Kinzler: [C: 031] "Looks good, now make Jenkins happy :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188400 (owner: 10Thiemo Mättig (WMDE)) [20:58:49] (03Merged) 10jenkins-bot: Fix HtmlTimeFormatter for negative years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188397 (owner: 10Thiemo Mättig (WMDE)) [21:06:30] sjoerddebruin: http://www.genealogics.org/descendtext.php?personID=I00423049&tree=LEO&generations= gezien? [21:06:38] Wel grappig om daar opeens Escher tegen te komen [21:06:58] Inderdaad. [21:07:03] Zulke familiebanden zijn leuk om te weten. [21:10:11] Veel van die familiebanden zijn natuurlijk vrij onzichtbaar terwijl dat waarschijnlijk een hoop invloed heeft gehad [21:11:23] student/student van is ook nuttig [21:13:05] Zeker. Hebben we al goede voorbeelden hoe dat netjes te doen? [21:15:52] Wat precies? [21:17:23] Student van [21:18:21] nn [21:18:35] ... [21:19:54] @seen multichill [21:20:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: investigate how language fallbacks can be done in entity search - https://phabricator.wikimedia.org/T88441#1060400 (10daniel) I investigate this "top down", from the API entry point to the database. These are the things th... [21:20:57] Base: He left about 15s before you entered [21:21:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: investigate how language fallbacks can be done in entity search - https://phabricator.wikimedia.org/T88441#1060401 (10daniel) a:3daniel [21:21:27] oh so that's why wm-bot said he's here back when I asked him on ##Base [21:21:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: investigate how language fallbacks can be done in entity search - https://phabricator.wikimedia.org/T88441#1011673 (10daniel) I consider this done. Any comments? [21:32:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: investigate how language fallbacks can be done in entity search - https://phabricator.wikimedia.org/T88441#1060477 (10aude) for searching, i would like to be able to 'fallback' more generously to more languages. For examp... [21:33:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-02-03: investigate how language fallbacks can be done in entity search - https://phabricator.wikimedia.org/T88441#1060481 (10aude) the details Daniel gives about SearchEntities seem generally good though. I am more concerned abou... [21:38:21] 10MediaWiki-extensions-WikibaseRepository: Make Wikibase Repo work with a customs File collection, not only wikimedia commons - https://phabricator.wikimedia.org/T90492#1060506 (10despens) 3NEW a:3despens [21:54:50] (03PS1) 10Aude: Fix overlap of edit button and aliases text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192459 (https://phabricator.wikimedia.org/T89956) [21:59:31] quick, easy review for hoo or someone :) https://gerrit.wikimedia.org/r/#/c/192462/ [21:59:40] should have done that patch earlier ... :/ [21:59:54] oh [21:59:59] tomorrow, still? [22:00:01] yeah [22:00:51] * aude hopes we can pull in localisation updates when we get them, if the automatic updates are still not working [22:00:56] Localization update should push it out tonight, so at least English should be there [22:01:02] yeah [22:01:18] not sure if the update actually works... it says it succeeded but don't think it does [22:01:21] unless it got fixed [22:01:40] mh... might still be broken [22:01:51] :/ [22:01:56] We should check that before the deploy tomorrow [22:02:02] yeah [22:02:44] I'm probably not going to be around very long tomorrow evening, but I can do the Wednesday deploy, if needed [22:03:01] that's fine (and i am around all week) [22:03:32] Nice :) [22:03:49] Also next week for the branch deploy? [22:04:03] need to talk to lydia and tobi [22:04:20] people can see it on beta now, but has some rough edges imho to polish [22:04:47] But we already have quite some backlog of things I want to have out :S [22:04:53] UpdateRepo fixes [22:04:59] yeah :/ [22:05:08] The Lua stuff we already announced, ... [22:05:53] maybe we can polish things up tomorrow [22:06:09] ...if my css things help at all, etc :) [22:06:12] Hopefully [22:56:05] (03PS18) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 [23:06:17] (03CR) 10Daniel Kinzler: "@Stas: oh, if you not don yet, fine :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:08:29] (03CR) 10Smalyshev: "@Daniel I think now I'm done." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:12:13] (03CR) 10Hoo man: [C: 04-1] Implement RDF export for items and RDF dumps (Turtle only for now) (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:14:40] (03CR) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:15:39] (03CR) 10Daniel Kinzler: Implement RDF export for items and RDF dumps (Turtle only for now) (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:21:32] (03CR) 10Aude: Implement RDF export for items and RDF dumps (Turtle only for now) (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:26:46] (03CR) 10Hoo man: "re" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:32:06] (03CR) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [23:38:43] (03PS19) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 [23:40:40] (03PS20) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 [23:45:38] (03CR) 10Aude: Implement RDF export for items and RDF dumps (Turtle only for now) (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev)