[00:52:09] 10Wikidata: Implement (dump) formatter for quantities with units based on URIs - https://phabricator.wikimedia.org/T92382#1111776 (10Krenair) [01:56:15] PROBLEM - check if wikidata.org dispatch lag is higher than 2 minutes on wikidata is CRITICAL: HTTP CRITICAL: HTTP/1.1 200 OK - pattern not found - 1459 bytes in 0.431 second response time [02:11:01] (03CR) 10Jeroen De Dauw: [C: 032] Simplify overcomplicated getInstance methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195295 (owner: 10Thiemo Mättig (WMDE)) [02:11:06] (03CR) 10Jeroen De Dauw: [C: 032] Get rid of SerializerBaseTest::getClass [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195558 (owner: 10Thiemo Mättig (WMDE)) [02:15:35] wikimedia/mediawiki-extensions-Wikibase/master/ab93997 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54041078 [02:18:51] (03Merged) 10jenkins-bot: Get rid of SerializerBaseTest::getClass [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195558 (owner: 10Thiemo Mättig (WMDE)) [02:23:06] wikimedia/mediawiki-extensions-Wikibase/master/72c7d62 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54041636 [02:32:47] (03PS1) 10Jeroen De Dauw: Remove myself from the TravisCI email notification list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196142 [02:46:50] (03PS1) 10Legoktm: Testing, ignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196144 [02:50:03] (03CR) 10jenkins-bot: [V: 04-1] Testing, ignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196144 (owner: 10Legoktm) [02:53:15] (03PS2) 10Legoktm: Testing, ignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196144 [02:57:11] (03CR) 10jenkins-bot: [V: 04-1] Testing, ignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196144 (owner: 10Legoktm) [03:05:04] (03PS2) 10AYUSH GARG: WikibaseRepository: updating long technical strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193808 (https://phabricator.wikimedia.org/T41259) [03:24:55] (03PS3) 10Legoktm: Testing, ignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196144 [03:27:49] (03CR) 10jenkins-bot: [V: 04-1] Testing, ignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196144 (owner: 10Legoktm) [03:34:44] so something is overriding the error_reporting in the client [03:44:59] (03PS1) 10Jeroen De Dauw: Fix ClaimDifferTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196151 [03:45:59] (03PS2) 10Jeroen De Dauw: Fix ClaimDifferTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196151 [03:46:45] (03CR) 10Jeroen De Dauw: [C: 04-2] Remove myself from the TravisCI email notification list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196142 (owner: 10Jeroen De Dauw) [03:50:46] (03PS1) 10Jeroen De Dauw: Fix type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196152 [03:52:27] (03PS1) 10Jeroen De Dauw: Add fixme for LSP violation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196153 [03:58:44] 10MediaWiki-extensions-WikibaseRepository: Remove binding to ValueValidators component from EntityValidator - https://phabricator.wikimedia.org/T92474#1112055 (10JeroenDeDauw) 3NEW [04:04:14] (03PS2) 10Jeroen De Dauw: Address LSP violations in EntityValidator implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196153 [04:06:05] (03PS1) 10Jeroen De Dauw: Test Jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196154 [04:08:45] (03CR) 10jenkins-bot: [V: 04-1] Test Jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196154 (owner: 10Jeroen De Dauw) [04:16:18] (03Abandoned) 10Jeroen De Dauw: Test Jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196154 (owner: 10Jeroen De Dauw) [04:45:07] 10Wikidata, 10Code-Review: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1112162 (10Legoktm) How about we start small and begin with the Wikidata.org and WikimediaBadges extensions that are currently packaged in the "Wikidata" build: * https://git... [04:56:45] RECOVERY - check if wikidata.org dispatch lag is higher than 2 minutes on wikidata is OK: HTTP OK: HTTP/1.1 200 OK - 1442 bytes in 0.275 second response time [05:59:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow statements on properties - https://phabricator.wikimedia.org/T51554#1112205 (10Bugreporter) Is this bug still needed? [07:19:08] Nemo_bis: http://ultimategerardm.blogspot.nl/2015/03/auto-translations-lets-talk-man-and.html [07:25:53] * nikki wonders if you're trying to say that "actor" is wrong [08:52:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1112313 (10adrianheine) A slightly related thing: Currently you cannot expand without JS enabled, which means if you don't have working JS, the box might just not be there.... [08:52:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: investigate solutions for items with a large number of aliases - https://phabricator.wikimedia.org/T87579#1112314 (10Snaterlicious) Stuff I wanted to write down for quite some time regarding... [09:40:14] [13DataValuesJavascript] 15adrianheine closed pull request #66: Fix inconsistency in MINUTES (06master...06minutes) 02http://git.io/xMmD [09:57:56] Adrian_WMDE: are you also taking a look at https://github.com/wmde/DataValuesJavascript/pull/72 ? [09:58:10] we would be able to close https://phabricator.wikimedia.org/T89243 then [09:58:17] OK, I'll do that [09:58:42] I'd stay remote, today, if that's okay [09:58:51] Adrian_WMDE: sure! [10:01:41] [13DataValuesJavascript] 15adrianheine pushed 1 new commit to 06master: 02http://git.io/piwt [10:01:41] 13DataValuesJavascript/06master 14e8093d0 15Adrian Heine né Lang: Merge pull request #72 from wmde/donCallMeIso... [10:06:44] hi [10:08:12] i believe this entity has been vandalised: https://www.wikidata.org/wiki/Q133823 [10:09:12] (03PS3) 10Adrian Lang: Also load wikibase.ui.entityViewInit on read-only entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 [10:09:29] (03CR) 10Adrian Lang: Also load wikibase.ui.entityViewInit on read-only entities (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 (owner: 10Adrian Lang) [10:11:11] shmias: How so? [10:12:28] the english description is "ovulo" [10:13:08] shmias: fix it? :) [10:13:20] which seems to have nothing to do with the topic [10:13:25] yeah [10:13:39] for some reason this page chrushes my chrome compleatly [10:13:58] oh [10:14:01] completly [10:14:04] that might be a font issue [10:14:05] whatever^^ [10:14:07] known chrome issue [10:14:13] i'll fix it for you [10:14:20] Lydia_WMDE: thank you [10:15:15] Lydia_WMDE: is there a special font now? [10:15:16] It's been there since October... [10:15:40] shmias: no but chrome doesn't deal well with some special characters [10:15:43] i just recently updated my OSX to a preview version [10:15:47] yeah [10:15:54] let me search for the ticket [10:16:25] its ok [10:16:29] thanks [10:16:48] shmias: https://phabricator.wikimedia.org/T88478 [10:18:13] [13Diff] 15thiemowmde created 06equals (+1 new commit): 02http://git.io/pi6U [10:18:13] 13Diff/06equals 14cf04919 15Thiemo Mättig: Add Diff::equals [10:21:12] [13Diff] 15thiemowmde opened pull request #41: Add Diff::equals (06master...06equals) 02http://git.io/piiJ [10:21:16] (03CR) 10Adrian Lang: Edit References along with Statement (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190799 (https://phabricator.wikimedia.org/T87759) (owner: 10Henning Snater) [10:21:39] wmde/Diff#158 (equals - cf04919 : Thiemo Mättig): The build passed. [10:21:39] Change view : https://github.com/wmde/Diff/commit/cf049194a511 [10:21:39] Build details : http://travis-ci.org/wmde/Diff/builds/54074467 [10:23:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1112494 (10adrianheine) I realized that we probably can skip step 3. (and remove most of `wbUsedEntities` right now) since we... [10:23:49] 10Wikidata, 5Patch-For-Review: Comparing Diff objects fails on certain environments - https://phabricator.wikimedia.org/T92487#1112497 (10thiemowmde) 3NEW [10:26:38] (03PS3) 10Thiemo Mättig (WMDE): Fix ClaimDifferTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196151 (https://phabricator.wikimedia.org/T92487) (owner: 10Jeroen De Dauw) [10:27:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Allow list of available languages to be configurable - https://phabricator.wikimedia.org/T86182#1112516 (10adrianheine) What's currently missing is the actual configuration interface. I wrot... [10:27:26] multichill: http://tools.wmflabs.org/autolist/index.php?language=nl&project=wikipedia&category=&depth=12&wdq=claim%5B1749%5D&mode=undefined&statementlist=&run=Run&label_contains=&label_contains_not=&chunk_size=10000 [10:29:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Migrate current selenium tests to cucumber - https://phabricator.wikimedia.org/T55849#1112521 (10adrianheine) >>! In T55849#1103629, @adrianheine wrote: > Are there still unmigrated tests? Yes, there are. They are at https://github.com/wmde/W... [10:30:10] (03PS1) 10Thiemo Mättig (WMDE): Fix ClaimDifference::equals implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196193 (https://phabricator.wikimedia.org/T92487) [10:33:04] 10Wikidata, 5Patch-For-Review: Comparing Diff objects fails on certain environments - https://phabricator.wikimedia.org/T92487#1112524 (10thiemowmde) [10:34:38] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Double-checked and confirmed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196151 (https://phabricator.wikimedia.org/T92487) (owner: 10Jeroen De Dauw) [10:37:19] (03Merged) 10jenkins-bot: Fix ClaimDifferTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196151 (https://phabricator.wikimedia.org/T92487) (owner: 10Jeroen De Dauw) [10:40:03] 10Wikidata, 5Patch-For-Review: Comparing Diff objects fails on certain environments - https://phabricator.wikimedia.org/T92487#1112534 (10daniel) Holy shit. Gotta love PHP. [10:40:11] [13Diff] 15thiemowmde comment on pull request #41 14cf04919: This single line is the relevant test for [T92487](https://phabricator.wikimedia.org/T92487). 02http://git.io/piMF [10:41:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Wikidata edits do not update "page watched" icon - https://phabricator.wikimedia.org/T87640#1112535 (10adrianheine) Could someone verify? [10:42:58] [13WikidataBrowserTests] 15tobijat 04deleted 06ranksnak_refactor at 14c3535aa: 02http://git.io/piDR [10:43:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Wikidata edits do not update "page watched" icon - https://phabricator.wikimedia.org/T87640#1112538 (10DSGalaktos) Seems to be working now! Thanks! [10:43:28] [13WikidataBrowserTests] 15adrianheine pushed 1 new commit to 06master: 02http://git.io/piDo [10:43:28] 13WikidataBrowserTests/06master 14671f8b2 15Adrian Heine né Lang: Merge pull request #58 from wmde/geo_T88543... [10:43:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Migrate current selenium tests to cucumber - https://phabricator.wikimedia.org/T55849#1112541 (10adrianheine) [10:43:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Browsertests for geo value input - https://phabricator.wikimedia.org/T88543#1112539 (10adrianheine) 5Open>3Resolved [10:43:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Browsertests for currently used datavalues (tracking) - https://phabricator.wikimedia.org/T55845#1112542 (10adrianheine) [10:43:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Browsertests for geo value input - https://phabricator.wikimedia.org/T88543#1014421 (10adrianheine) p:5High>3Normal [10:44:18] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Comparing Diff objects fails on certain environments - https://phabricator.wikimedia.org/T92487#1112546 (10thiemowmde) [10:44:33] (03PS2) 10Thiemo Mättig (WMDE): Fix ClaimDifference::equals implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196193 (https://phabricator.wikimedia.org/T92487) [10:46:16] wikimedia/mediawiki-extensions-Wikibase/master/f23ad49 : jeroendedauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54076579 [10:46:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Wikidata edits do not update "page watched" icon - https://phabricator.wikimedia.org/T87640#1112550 (10DSGalaktos) Hm, doesn’t work when removing statements or references (but does wo... [10:55:34] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1112565 (10adrianheine) Two of the last three qunit jobs failed with databas... [11:08:23] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Technical-Debt: Code coverage extremely low - technical debt - https://phabricator.wikimedia.org/T44510#1112582 (10adrianheine) PHPUnit just gave me 79.18% code lines coverage on client. Worst offenders are UpdateRepo/, modules/, recentchanges/. [11:12:00] (03PS4) 10Daniel Kinzler: Mock services for SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194516 (https://phabricator.wikimedia.org/T92375) [11:12:05] (03PS4) 10Daniel Kinzler: Supply edit token when testing special pages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) [11:12:14] (03PS6) 10Daniel Kinzler: Data provider for testing SpecialSetLabelDescritionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194524 [11:12:21] (03PS3) 10Daniel Kinzler: Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 [11:13:54] 10Wikidata, 10DataTypes, 7Need-volunteer: DataTypes should pass jshint - https://phabricator.wikimedia.org/T63601#1112587 (10adrianheine) 5Open>3Invalid a:3adrianheine We don't use the DataTypes project on gerrit currently. [11:14:40] (03CR) 10Daniel Kinzler: "I'd prefer dumpJson.php and dumpRdf.php to be separate entry points, instead of modes of a single script. The main reason is that they can" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 (owner: 10Smalyshev) [11:15:02] (03PS5) 10Daniel Kinzler: Refactor tests to be data-driven [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194750 (owner: 10Smalyshev) [11:15:14] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Remove time conversion logic from JavaScript code - https://phabricator.wikimedia.org/T89243#1112593 (10Tobi_WMDE_SW) 5Open>3Resolved [11:15:15] 10Wikidata, 7Tracking: Bugs related to time datatype - https://phabricator.wikimedia.org/T87764#1112594 (10Tobi_WMDE_SW) [11:17:57] Lydia_WMDE: https://www.mediawiki.org/wiki/Wikidata_deployment#wmf.2F1.25wmf22 [11:18:15] we should put list of changes there [11:18:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Wikidata edits do not update "page watched" icon - https://phabricator.wikimedia.org/T87640#1112600 (10Lydia_Pintscher) It's not deployed yet so if you are testing on wikidata.org it'... [11:20:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: SubProperty mechanism - https://phabricator.wikimedia.org/T61680#1112605 (10Lydia_Pintscher) [11:20:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Improve the listing and classification of properties - https://phabricator.wikimedia.org/T59843#1112604 (10Lydia_Pintscher) [11:20:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow statements on properties - https://phabricator.wikimedia.org/T51554#1112601 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher No. Done indeed. Thanks for poking :) [11:22:08] (03PS4) 10Daniel Kinzler: Fixmes and cleanup for the rdf-export patch. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195642 [11:24:01] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/195642/4 [11:24:58] (03CR) 10Aude: [C: 032] Fix type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196152 (owner: 10Jeroen De Dauw) [11:25:40] (03CR) 10Daniel Kinzler: [C: 031] "Works as designed. Will +2 once the follow-up with the FIXMEs also has a +2, so they can go in together." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [11:26:29] (03CR) 10Aude: [C: 032] Address LSP violations in EntityValidator implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196153 (owner: 10Jeroen De Dauw) [11:26:42] [13ValueView] 15tobijat created 060.14.0_release (+1 new commit): 02http://git.io/piN7 [11:26:42] 13ValueView/060.14.0_release 1458e10ad 15Tobias Gritschacher: Release 0.14.0 [11:27:06] (03CR) 10Daniel Kinzler: [C: 032] "This makes understanding the tests for the RDF builder a lot simpler." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194750 (owner: 10Smalyshev) [11:27:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ClaimDifferTest::testDiffClaims failures on travis - https://phabricator.wikimedia.org/T92453#1112608 (10aude) https://gerrit.wikimedia.org/r/#/c/196151/ (merged) [11:27:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ClaimDifferTest::testDiffClaims failures on travis - https://phabricator.wikimedia.org/T92453#1112609 (10aude) 5Open>3Resolved [11:27:42] (03Merged) 10jenkins-bot: Fix type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196152 (owner: 10Jeroen De Dauw) [11:28:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: In edit mode of entitytermsview, it's not always very obvious where focus is - https://phabricator.wikimedia.org/T92447#1112611 (10Lydia_Pintscher) [11:28:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1112610 (10Lydia_Pintscher) [11:29:49] (03Merged) 10jenkins-bot: Address LSP violations in EntityValidator implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196153 (owner: 10Jeroen De Dauw) [11:30:16] 10Wikidata: Implement (dumb) formatter for quantities with units based on URIs - https://phabricator.wikimedia.org/T92382#1112618 (10Lydia_Pintscher) [11:33:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Documentation, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1112626 (10Snaterlicious) Fisch and me reassesed the diagramm. {F84544} The bould... [11:37:22] (03PS3) 10Thiemo Mättig (WMDE): Move direction applying to inner element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193803 (owner: 10Ebrahim) [11:37:23] (03PS1) 10Thiemo Mättig (WMDE): Move lang attribute from wikibase-sitelinkview to wikibase-sitelinkview-pagename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196203 [11:38:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: In edit mode, labels in entitytermsview box should line wrap like descriptions do - https://phabricator.wikimedia.org/T92489#1112631 (10aude) 3NEW [11:38:25] [13ValueView] 15adrianheine pushed 1 new commit to 06master: 02http://git.io/piph [11:38:25] 13ValueView/06master 14c61d341 15Adrian Heine né Lang: Merge pull request #164 from wmde/0.14.0_release... [11:39:03] (03CR) 10Daniel Kinzler: "Please don't check in Wikidata-specific data, especially not data that is dynamically generated, like create_wdq_constraints_from_template" [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/194509 (owner: 10Jonaskeutel) [11:41:01] sjoerddebruin: Wat is dat? Parlement ding? [11:42:11] (03PS1) 10Thiemo Mättig (WMDE): Drop unused paramaters from wikibase-sitelinkview template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196204 [11:42:39] (03CR) 10jenkins-bot: [V: 04-1] Move lang attribute from wikibase-sitelinkview to wikibase-sitelinkview-pagename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196203 (owner: 10Thiemo Mättig (WMDE)) [11:42:44] (03CR) 10Daniel Kinzler: [C: 04-1] Cross-check and constraint report special pages should be working, tests uncomplete, but the existing ones should run [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/194509 (owner: 10Jonaskeutel) [11:44:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: In edit mode, labels in entitytermsview box should line wrap like descriptions do - https://phabricator.wikimedia.org/T92489#1112639 (10aude) [11:44:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1112638 (10aude) [11:47:06] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "PS3 is an accidental rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193803 (owner: 10Ebrahim) [11:47:34] (03CR) 10Aude: [C: 032] Add white background to overlapping edit buttons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195951 (https://phabricator.wikimedia.org/T89956) (owner: 10Thiemo Mättig (WMDE)) [11:49:25] (03CR) 10Daniel Kinzler: "Code style and documentation." (036 comments) [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/194509 (owner: 10Jonaskeutel) [11:50:18] multichill: Ja [11:50:38] (03Merged) 10jenkins-bot: Move direction applying to inner element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193803 (owner: 10Ebrahim) [11:50:51] Hij snapt het nu. :) https://www.wikidata.org/w/index.php?title=User_talk:Magnus_Manske&curid=2231923&diff=203573750&oldid=203570231 [11:51:32] (03Merged) 10jenkins-bot: Add white background to overlapping edit buttons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195951 (https://phabricator.wikimedia.org/T89956) (owner: 10Thiemo Mättig (WMDE)) [11:53:21] (03CR) 10Thiemo Mättig (WMDE): [V: 032] "Missing whitespace in a comment? This is bollocks." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196203 (owner: 10Thiemo Mättig (WMDE)) [11:58:19] (03CR) 10Adrian Lang: [C: 04-1] "No, that's our coding style." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196203 (owner: 10Thiemo Mättig (WMDE)) [12:03:24] (03CR) 10Daniel Kinzler: "More coding style issues." (0312 comments) [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/194509 (owner: 10Jonaskeutel) [12:04:09] (03CR) 10Daniel Kinzler: "On a positive note: the code seems to be structured pretty well, and has good test coverage. Awesome!" [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/194509 (owner: 10Jonaskeutel) [12:07:18] (03PS1) 10Thiemo Mättig (WMDE): Disable JSCS requireSpaceAfterLineComment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196208 [12:11:08] (03CR) 10jenkins-bot: [V: 04-1] Disable JSCS requireSpaceAfterLineComment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196208 (owner: 10Thiemo Mättig (WMDE)) [12:16:24] [13ValueView] 15tobijat tagged 060.14.0 at 06master: 02http://git.io/pPIB [12:28:04] (03CR) 10Tobias Gritschacher: "Reference: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196203 (owner: 10Thiemo Mättig (WMDE)) [12:48:30] 10Wikidata, 10Code-Review: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1112735 (10JanZerebecki) That is a good idea as those two are not registered at packagist.org so for them the blocker task is not one. [12:51:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Create a special page to query for badges - https://phabricator.wikimedia.org/T72209#1112736 (10He7d3r) This came up again on ptwiki. https://pt.wikipedia.org/wiki/WP:Coordenação_robótica#Predefini.C3.A7.C3.B5es_substitu.C3.ADdas_pelo_Wi... [12:56:21] Is it possible to use Wikidata Query editor for badges? [12:56:27] https://wdq.wmflabs.org/wdq/ [12:57:41] I would like to get a list of items which have a sitelink to e.g. enwiki which has a specified badge [12:57:56] (to workaround https://phabricator.wikimedia.org/T72209) [12:58:03] 10Wikidata: Implement (dumb) formatter for quantities with units based on URIs - https://phabricator.wikimedia.org/T92380#1112748 (10Lydia_Pintscher) [12:58:04] 10Wikidata: Implement (dumb) formatter for quantities with units based on URIs - https://phabricator.wikimedia.org/T92382#1112747 (10Lydia_Pintscher) [12:58:07] (03CR) 10Thiemo Mättig (WMDE): "No, it's not "our" style. Or how do you explain the hundreds and hundreds of comments with no space in "our" code base?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196203 (owner: 10Thiemo Mättig (WMDE)) [12:58:26] 10Wikidata: Implement (dumb) formatter for quantities with units based on URIs - https://phabricator.wikimedia.org/T92380#1109299 (10Lydia_Pintscher) [12:58:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Unit support (tracking) - https://phabricator.wikimedia.org/T77977#1112752 (10Lydia_Pintscher) [13:02:04] 10Wikidata, 10Code-Review: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1112759 (10aude) WikimediaBadges and Wikidata.org would be good to start with and can't imagine objections to moving those. I would also like PropertySuggester in gerrit. we... [13:02:45] Lydia_WMDE: https://phabricator.wikimedia.org/T74907#1112759 [13:03:01] would need that communicated with the students but think we should do soonish [13:05:10] 10Wikidata, 10Wikimedia-Hackathon-2015: Wikidata activities at the Wikimedia Hackathon 2015 - https://phabricator.wikimedia.org/T92270#1112764 (10Qgil) [13:06:20] 10Wikidata, 10Wikimedia-Hackathon-2015: Wikidata activities at the Wikimedia Hackathon 2015 - https://phabricator.wikimedia.org/T92270#1104415 (10Qgil) [13:09:24] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1112805 (10JanZerebecki) How do you know they failed because of the database locked errors? They too show the... [13:14:08] (03PS2) 10Thiemo Mättig (WMDE): Disable JSCS requireSpaceAfterLineComment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196208 [13:15:16] (03CR) 10Thiemo Mättig (WMDE): "Tobi wrote: "Reference: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Comments"." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196208 (owner: 10Thiemo Mättig (WMDE)) [13:15:19] (03CR) 10Thiemo Mättig (WMDE): "@Tobi: See my comment at I239a8e9." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196203 (owner: 10Thiemo Mättig (WMDE)) [13:18:22] Thiemo_WMDE: ping https://gerrit.wikimedia.org/r/#/c/195642/ [13:19:59] sjoerddebruin: Working, so not paying too much attention. Looked at mix and mix, you can click yourself crazy now on the auto matched items [13:20:39] Date of birth and date of death are included in both so that makes it very very easy [13:21:08] DanielK_WMDE_: https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2012-10-15/Technology_report [13:36:02] (03CR) 10Daniel Kinzler: [C: 032] Simplify SectionEditLinkGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194305 (owner: 10Adrian Lang) [13:38:35] (03Merged) 10jenkins-bot: Simplify SectionEditLinkGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194305 (owner: 10Adrian Lang) [13:41:45] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: language fallback - https://phabricator.wikimedia.org/T76216#1112902 (10Lydia_Pintscher) [13:41:46] 10Wikidata: Limit usage of user-specific language fallback - https://phabricator.wikimedia.org/T90615#1112903 (10Lydia_Pintscher) [13:43:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: add language fallback to entity search/suggester - https://phabricator.wikimedia.org/T76150#1112914 (10Lydia_Pintscher) p:5Normal>3High [13:45:43] [13WikidataBrowserTests] 15WMDE-Fisch created 06statments_refactor (+5 new commits): 02http://git.io/pP2t [13:45:43] 13WikidataBrowserTests/06statments_refactor 1402604d3 15WMDE-Fisch: refactored xpath to css [13:45:43] 13WikidataBrowserTests/06statments_refactor 140bcd894 15WMDE-Fisch: renamed statement where should named claim [13:45:43] 13WikidataBrowserTests/06statments_refactor 140cb92ca 15WMDE-Fisch: refactored unnecessary code [13:52:11] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #62: refactored statments to wait for elements (06master...06statments_refactor) 02http://git.io/pPV3 [13:53:23] (03CR) 10Daniel Kinzler: [C: 04-1] "I like the approach and structure. Got a lot of nitpicks." (0314 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194342 (owner: 10Adrian Lang) [13:55:16] [13WikidataBrowserTests] 15WMDE-Fisch created 06auth_refactor (+1 new commit): 02http://git.io/pPwu [13:55:16] 13WikidataBrowserTests/06auth_refactor 141466f8f 15WMDE-Fisch: refactored @browser usage and when_present [13:56:26] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #63: refactored authority conrol feature to wait for elements (06master...06auth_refactor) 02http://git.io/pPwp [13:57:39] (03CR) 10Daniel Kinzler: [C: 031] "PHP code seems ready to merge, can't vouch for the JS side, though it also looks sane." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 (owner: 10Adrian Lang) [13:57:49] Thiemo_WMDE: merge? ---^ [13:58:03] * aude is reviewing it [13:58:11] if it's the entityview factory thing [13:58:33] see some scary code, but maybe not new in the patch [13:58:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Documentation, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1112965 (10JanZerebecki) I don't see the semantic difference between qualifying the... [14:00:55] aude: new scary code? [14:02:13] yeah, in javascripts [14:02:32] relying on variables created in Wikibase.hooks.php [14:03:06] (03CR) 10Aude: [C: 04-1] "at minimum, want a little bit more documentation regarding user languages and why the code is way it is." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [14:04:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: UI should get list of supported languages from the backend, via dedicated resource loader module - https://phabricator.wikimedia.org/T78007#1112977 (10JanZerebecki) The proposal in T78007#10... [14:10:18] [13WikidataBrowserTests] 15WMDE-Fisch created 06evil_browser (+1 new commit): 02http://git.io/pPPc [14:10:19] 13WikidataBrowserTests/06evil_browser 147e45305 15WMDE-Fisch: get rid of several @browser calls [14:12:07] (03PS1) 10Tobias Gritschacher: Include ValueView version 0.14.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196219 [14:15:06] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06evil_browser: 02http://git.io/pP1q [14:15:06] 13WikidataBrowserTests/06evil_browser 1440f30e2 15WMDE-Fisch: removed self. references -.- [14:16:21] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #64: get rid of several @browser calls (06master...06evil_browser) 02http://git.io/pP1M [14:17:23] (03CR) 10Aude: [C: 031] "I don't see anything problematic (compatibility-wise, at least for the property suggester) in the new tagged version, and the changes look" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196219 (owner: 10Tobias Gritschacher) [14:18:39] [13WikidataBrowserTests] 15WMDE-Fisch closed pull request #64: get rid of several @browser calls (06master...06evil_browser) 02http://git.io/pP1M [14:24:39] (03CR) 10Daniel Kinzler: [C: 04-1] "Agree in principle, but I have questions." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194531 (owner: 10Thiemo Mättig (WMDE)) [14:26:14] (03CR) 10Daniel Kinzler: [V: 04-1] "Needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193806 (owner: 10Thiemo Mättig (WMDE)) [14:27:56] [13WikidataBrowserTests] 15WMDE-Fisch 04force-pushed 06evil_browser from 1440f30e2 to 1475c76e7: 02http://git.io/pP9x [14:27:56] 13WikidataBrowserTests/06evil_browser 1475c76e7 15WMDE-Fisch: get rid of several @browser calls [14:29:52] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #65: get rid of several @browser calls (06master...06evil_browser) 02http://git.io/pPHi [14:33:16] (03CR) 10Daniel Kinzler: [C: 032] Test for HTML injection in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192544 (owner: 10Thiemo Mättig (WMDE)) [14:36:32] (03Merged) 10jenkins-bot: Test for HTML injection in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192544 (owner: 10Thiemo Mättig (WMDE)) [14:37:03] (03CR) 10Daniel Kinzler: [C: 032] Drop outdated TODO from TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194111 (owner: 10Thiemo Mättig (WMDE)) [14:39:36] (03CR) 10Daniel Kinzler: [C: 032] Make TimeDetailsFormatter echo invalid values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194911 (owner: 10Thiemo Mättig (WMDE)) [14:43:12] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #57 14b17c7a6: Sorry, I was reviewing the code on a small 11 inch screen, and looks like github does not display diffs correctly in some cases, indenting looked completely broken. 02http://git.io/pPNm [14:44:40] (03CR) 10Daniel Kinzler: [C: 04-1] "The functionality is fine, but this is Black Magic (tm) code, I'd like more comments. Not a blocker, CR-1 for attention." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192313 (owner: 10Thiemo Mättig (WMDE)) [14:46:05] (03CR) 10Daniel Kinzler: [C: 032] Make PhpDateTimeParser fail if PHP changes the year [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193817 (owner: 10Thiemo Mättig (WMDE)) [14:46:32] (03PS8) 10Adrian Lang: Introduce wikibase.view.ViewFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) [14:49:20] (03CR) 10Adrian Lang: Introduce wikibase.view.ViewFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [14:50:06] (03CR) 10Daniel Kinzler: [C: 04-1] "This patch seems to re-do part of what Icdba60235440f9 does." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193819 (owner: 10Thiemo Mättig (WMDE)) [14:50:47] (03CR) 10Aude: "would need to look more closely at the rest of the code before giving +2" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [14:53:30] (03CR) 10Daniel Kinzler: [C: 031] "Seems fine, going by the test cases." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193833 (owner: 10Thiemo Mättig (WMDE)) [14:55:41] echo new ArrayObject( array( 1 ) ) == new ArrayObject( array( 2 ) ); [14:56:52] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Comparing Diff objects fails on certain environments - https://phabricator.wikimedia.org/T92487#1113096 (10thiemowmde) Nailed down to the most minimal test case: `echo new ArrayObject( array( 1 ) ) == new ArrayObject( array( 2 ) );` My PHP 5.3 thi... [14:59:19] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Comparing Diff objects fails on certain environments - https://phabricator.wikimedia.org/T92487#1113112 (10JanZerebecki) Yes, this issue does not exist in the following versions. Debian: PHP 5.6.6-2 (cli) (built: Feb 24 2015 10:07:30) Upstream deb... [15:02:54] (03PS1) 10Thiemo Mättig (WMDE): Add fail-safe assertions to ClaimDifferTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196228 (https://phabricator.wikimedia.org/T92487) [15:07:20] 10Wikidata, 10DataValues: Move Wikibase components from GitHub to Gerrit - https://phabricator.wikimedia.org/T92279#1113144 (10thiemowmde) I consider code being scattered around an issue. Trying to work with these components gets messy fast, see T92268. Having all DataValues in one repository introduces only... [15:12:28] (03CR) 10Adrian Lang: Completely rework SectionEditLinkGenerator (0314 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194342 (owner: 10Adrian Lang) [15:13:44] (03PS4) 10Adrian Lang: Completely rework SectionEditLinkGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194342 [15:13:46] (03PS4) 10Adrian Lang: Also load wikibase.ui.entityViewInit on read-only entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 [15:13:53] (03CR) 10JanZerebecki: [C: 032] Fix ClaimDifference::equals implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196193 (https://phabricator.wikimedia.org/T92487) (owner: 10Thiemo Mättig (WMDE)) [15:15:14] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Code looks good. But I have not run it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 (owner: 10Adrian Lang) [15:17:39] (03CR) 10Aude: "I get "Unknown dependency: wikibase.view.ViewFactory" error, which I think is related to how the view "component" is initialized and inclu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [15:17:42] (03CR) 10Adrian Lang: [C: 04-1] "Coding style is not a waste of time, and I'm very surprised to hear that from you, since you care a lot about coding style. I find it extr" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196208 (owner: 10Thiemo Mättig (WMDE)) [15:18:19] (03CR) 10Aude: "is view only used by repo? or also by client?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [15:19:09] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1113158 (10adrianheine) Sorry. It's way done in the mw-debug-www.log build artifact. [15:19:19] (03Merged) 10jenkins-bot: Fix ClaimDifference::equals implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196193 (https://phabricator.wikimedia.org/T92487) (owner: 10Thiemo Mättig (WMDE)) [15:20:48] (03CR) 10Adrian Lang: [C: 032] Include ValueView version 0.14.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196219 (owner: 10Tobias Gritschacher) [15:21:22] (03CR) 10JanZerebecki: [C: 04-1] "Suggested additional comment to add inline." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196228 (https://phabricator.wikimedia.org/T92487) (owner: 10Thiemo Mättig (WMDE)) [15:22:24] (03CR) 10Adrian Lang: "Thanks for checking with the build. How does the build include our stuff? view is only used by repo." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [15:23:34] (03Merged) 10jenkins-bot: Include ValueView version 0.14.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196219 (owner: 10Tobias Gritschacher) [15:24:10] (03PS1) 10Aude: Include WikibaseView directly in repo entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196238 [15:25:15] (03CR) 10Aude: "see https://gerrit.wikimedia.org/r/#/c/196238/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [15:26:42] (03CR) 10Aude: "@adrian we explicitly load these things, based on wmf config or are pulled in via composer." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [15:27:06] (03CR) 10Adrian Lang: [C: 031] "Seems alright to me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196238 (owner: 10Aude) [15:34:28] (03PS1) 10Adrian Lang: Try to set wgResourceLoaderMaxQueryLength for jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 [15:34:35] ^^ jzerebecki let's see [15:38:38] Works [15:38:40] https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/7719/console [15:39:02] :) [15:39:26] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking: Allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#1113216 (10Lydia_Pintscher) We just discussed this. The remaining blocker for a rollout on non... [15:39:36] Finally, an actual error :) [15:39:59] jzerebecki: I'll run the jenkins job locally and debug these issues [15:40:22] Adrian_WMDE: no same error as before [15:40:56] same error as before? [15:41:08] 15:37:18 Warning: 20/3922 assertions failed (75631ms) Use --force to continue. [15:41:16] Adrian_WMDE: even though - Installing data-values/value-view (0.14.0), so what your change did not effect it? [15:42:17] Ah, you mean the qunit errors [15:42:20] hum, that's strange [15:42:22] Adrian_WMDE: yea the same as in https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit-experiment/11/consoleFull (that job has the querylength set) [15:43:29] it worked for me without focus on the browser window :( [15:44:08] which means the phantomjs behaviour is different than that [15:44:18] Adrian_WMDE: try reproducing with phantomjs? [15:44:31] Ah, jeez [15:46:03] phantomjs probably does not support document.hidden [15:47:32] Sucks [15:48:17] (03PS1) 10Daniel Kinzler: Document heuristics for identifying the year in a date string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196247 [15:49:31] (03CR) 10Daniel Kinzler: [C: 032] "Added a follow-up for the comments I wanted: I517796bffc7b." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193833 (owner: 10Thiemo Mättig (WMDE)) [15:50:47] (03CR) 10Daniel Kinzler: [C: 032] "Added a follow-up for the comments I wanted: I517796bffc7b. Can go in now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192313 (owner: 10Thiemo Mättig (WMDE)) [15:51:15] (03PS4) 10Daniel Kinzler: Trim leading zeros from 5+ digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192314 (owner: 10Thiemo Mättig (WMDE)) [15:51:47] (03CR) 10Daniel Kinzler: [V: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192317 (owner: 10Thiemo Mättig (WMDE)) [15:52:54] jzerebecki: I'll have a look at phantomjs to find out what it can [15:54:01] (03Merged) 10jenkins-bot: Major rewrite of DateTimeParser::getValueWithFixedYearLengths [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192313 (owner: 10Thiemo Mättig (WMDE)) [16:01:23] 10Wikidata, 6ArchCom, 10Wikimedia-Hackathon-2015: Wikidata architecture review and feedback - https://phabricator.wikimedia.org/T92505#1113311 (10daniel) 3NEW a:3Lydia_Pintscher [16:05:55] (03CR) 10JanZerebecki: [C: 032] WikibaseRepository: updating long technical strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193808 (https://phabricator.wikimedia.org/T41259) (owner: 10AYUSH GARG) [16:09:10] (03Merged) 10jenkins-bot: WikibaseRepository: updating long technical strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193808 (https://phabricator.wikimedia.org/T41259) (owner: 10AYUSH GARG) [16:09:17] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking: Allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#1113358 (10greg) Thanks Lydia! Is there a task that tracks just the usage tracking rollout bit... [16:14:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7I18n, and 2 others: Messages with long technical strings are hard to translate - https://phabricator.wikimedia.org/T41259#1113379 (10JanZerebecki) 5Open>3Resolved a:3AYUSH [16:17:20] (03CR) 10Smalyshev: [C: 032] "looks good" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195642 (owner: 10Daniel Kinzler) [16:24:13] (03CR) 10Krinkle: "Note, per JSCS documentation, a rule can be disabled using "null". There's no need to duplicate the whole preset. Use "preset": "wikimedia" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196208 (owner: 10Thiemo Mättig (WMDE)) [16:29:45] (03CR) 10Krinkle: "A space after // is part of our coding style. That's part of the JSCS preset and part of the status quo in most of our JavaScript code." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196208 (owner: 10Thiemo Mättig (WMDE)) [16:37:26] DanielK_WMDE_: so I've +2ed your fixme patch, we still have to make the tickets for it but otherwise I think that'd good and I can work on those once I'm done with migrating badges & values patches [16:38:17] it'd be easier if we had it merged though because we have 3 separate patches now and incremental ones need all three [16:38:22] someone want to merge https://gerrit.wikimedia.org/r/#/c/194317/ and https://gerrit.wikimedia.org/r/#/c/195939/ ? [16:38:32] they already have +2 from thiemo but then jenkins was broken [16:39:02] (03CR) 10Daniel Kinzler: [C: 032] "ok, let's move" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [16:39:28] \o/ for rdf :) [16:39:54] woohoo! [16:40:53] SMalyshev: the data-drive test one also has a +2 already. you should be able to rebase the remaining ones in a few minutes. [16:41:08] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking: Allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#1113458 (10Lydia_Pintscher) @greg: That'd be T49288. [16:41:10] with the data driven tests, it should be a lot easier for me to review the remaining patches [16:41:35] DanielK_WMDE_: will the other patches merge automatically (the ones that are +ed)? [16:41:38] +2ed [16:42:11] yes [16:42:20] if they can be patched in cleanely [16:43:09] (03PS5) 10Daniel Kinzler: Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [16:43:11] (03PS4) 10Daniel Kinzler: Remove width from .wikibase-sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194317 (https://phabricator.wikimedia.org/T91501) (owner: 10Aude) [16:45:10] (03Merged) 10jenkins-bot: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (owner: 10Smalyshev) [16:45:13] (03Merged) 10jenkins-bot: Refactor tests to be data-driven [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194750 (owner: 10Smalyshev) [16:45:15] (03CR) 10jenkins-bot: [V: 04-1] Fixmes and cleanup for the rdf-export patch. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195642 (owner: 10Daniel Kinzler) [16:45:46] DanielK_WMDE_: looks like the fixmes one needs a rebase [16:45:54] bah [16:52:34] SMalyshev: gerrit is dog slow again, a pain to work with. it's a really curious issue [16:53:34] (03PS5) 10Daniel Kinzler: Fixmes and cleanup for the rdf-export patch. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195642 [16:53:42] SMalyshev: --^ [16:54:32] (03CR) 10Smalyshev: [C: 032] Fixmes and cleanup for the rdf-export patch. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195642 (owner: 10Daniel Kinzler) [16:55:04] https://phabricator.wikimedia.org/T92513 [16:55:33] DanielK_WMDE_: and https://gerrit.wikimedia.org/r/#/c/195980/ - can you look at this one too? [16:55:43] that's the dump one I moved out [16:56:37] ah, wait, I see you commented on it, let me check [16:57:24] (03Merged) 10jenkins-bot: Fixmes and cleanup for the rdf-export patch. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195642 (owner: 10Daniel Kinzler) [16:57:52] (03CR) 10Smalyshev: "There's a bunch of maintenance code that is still shared but I can make them both extend DumpEntities or something like that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 (owner: 10Smalyshev) [16:59:25] DanielK_WMDE_: I'm not sure how to handle it best though since all that dumpEntites does is dependent on options, and for options you need Maintenance [16:59:39] so would making the common class be fine? [17:00:31] SMalyshev: a common base class would be ok i think. [17:01:55] DanielK_WMDE_: will do after the meeting then [17:04:51] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap: track entity usage on client pages - https://phabricator.wikimedia.org/T49288#1113563 (10greg) [17:08:06] 10Wikidata: Implement each "flavor" of RDF in a separate class. - https://phabricator.wikimedia.org/T92515#1113575 (10daniel) [17:08:15] aude: does someone have to approve https://phabricator.wikimedia.org/T74907#1112759 or can we just be bold? [17:09:09] property suggester needs communication with the students who work on it [17:09:11] so not yet [17:09:25] WikimediaBadges and Wikidata.org though? [17:09:38] the others, maybe a ticket for those specifically [17:09:46] and we can document and agree how exactly we want to do [17:09:49] ok [17:10:06] e.g. just hosting the extensions on gerrit and still pull them into the build via composer (for now) [17:10:28] eh, I'd rather just deploy them as normal extensions [17:10:32] and then maybe integrating our build on a more higher, grand level into a wmf deployment build [17:10:35] :/ [17:10:44] maybe [17:11:42] it's nice to run composer update and it pull things in without having to do manually [17:12:03] 10Wikidata: Implement separate RDF generators for each value type - https://phabricator.wikimedia.org/T92517#1113596 (10daniel) 3NEW [17:12:09] and while these things depend on wikibase master, maybe instead have versions defined [17:12:22] well, neither of them have been touched in months [17:12:23] needs thought [17:12:26] true [17:12:31] jzerebecki: the Patch Of Doom was merged a few minutes ago. [17:12:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: investigate solutions for items with a large number of aliases - https://phabricator.wikimedia.org/T87579#1113614 (10Lydia_Pintscher) I think we should narrow it down to: * floating * tradit... [17:12:50] the property suggester is one where version is important [17:13:10] DanielK_WMDE_: yes that was positively received at the meeting [17:13:17] :) [17:13:29] yes, which is why I don't want to do that one first :) [17:13:35] ok [17:13:56] let's make a ticket to start for the other two [17:14:11] * legoktm is writing one :) [17:14:13] ok [17:15:47] DanielK_WMDE_: rdf patch or which one? [17:15:52] 10Wikidata: Move Wikidata.org and WikimediaBadges extensions to gerrit - https://phabricator.wikimedia.org/T92520#1113634 (10Legoktm) 3NEW [17:16:26] thanks [17:17:05] i don't think anyone would object to move them to gerrit part [17:17:11] 10Wikidata: Improve meta-data handling in RDF-Output - https://phabricator.wikimedia.org/T92521#1113652 (10daniel) 3NEW [17:17:23] how to integrate might need thought (either with composer-merge plugin or something) [17:17:44] legoktm: aude: agreed but let's have our discussion on the bigger topic first which is scheduled for this sprint [17:17:52] ok [17:17:59] and communicate it to the people actually committing to those extensions besides us [17:18:02] yep [17:18:09] benestar etc [17:18:12] Lydia_WMDE: sounds good. [17:18:12] yeah [17:19:54] 10Wikidata: Add test case for output of stubs for "mentioned" entities in RDF output - https://phabricator.wikimedia.org/T92522#1113666 (10daniel) 3NEW a:3Smalyshev [17:20:35] 10Wikidata, 10Continuous-Integration, 7Jenkins: PHP fatal errors are not visible in jenkins output in mwext-Wikibase-client-tests job - https://phabricator.wikimedia.org/T92397#1113674 (10Legoktm) [17:22:53] (03CR) 10Aude: [C: 031] "looks ok to me now and happy to see this change (and the follow up)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194342 (owner: 10Adrian Lang) [17:23:10] 10Wikidata, 10Continuous-Integration, 7Jenkins: PHP fatal errors are not visible in jenkins output in mwext-Wikibase-client-tests job - https://phabricator.wikimedia.org/T92397#1113684 (10Legoktm) Hmm, is something in client messing with the output buffer? I grepped for "ob_" but didn't see anything client-r... [17:23:14] (03CR) 10Aude: [C: 031] "nitpick about comment, but otherwise looks good." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 (owner: 10Adrian Lang) [17:23:42] 10Wikidata: Implement fast sequential RDF output generation - https://phabricator.wikimedia.org/T92523#1113687 (10daniel) 3NEW a:3daniel [17:24:31] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: Implement fast sequential RDF output generation - https://phabricator.wikimedia.org/T92523#1113687 (10daniel) [17:25:00] Lydia_WMDE: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Wikibase+branch:master+topic:css,n,z [17:25:21] 2 of them are stuck and just need submit or retrigger gate and submit [17:27:01] Adrian_WMDE: if you're still around and reviewing it'd be awesome if you could have a look at https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Wikibase+branch:master+topic:css,n,z as those are the remaining issues bevore we can roll out new header to beta [17:27:04] and ask for testing [17:27:10] still around [17:27:16] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: Implement fast sequential RDF output generation - https://phabricator.wikimedia.org/T92523#1113703 (10daniel) bla #§_Wikidata-Sprint-Current ydflgkasdfölgk [17:28:48] ok, gimme 10 minutes to finish what I'm doing [17:30:24] (03CR) 10JanZerebecki: [C: 032] Include WikibaseView directly in repo entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196238 (owner: 10Aude) [17:31:42] \o/ [17:32:44] (03PS3) 10Smalyshev: Add dump implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 [17:33:25] (03PS4) 10Smalyshev: Add dump implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 [17:34:27] (03Merged) 10jenkins-bot: Include WikibaseView directly in repo entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196238 (owner: 10Aude) [17:40:29] (03PS5) 10Smalyshev: Add dump implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 [17:42:02] (03PS6) 10Smalyshev: Add dump implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 [17:42:22] DanielK_WMDE_: on https://phabricator.wikimedia.org/T92397#1112624 did you mean "would be write errors to a log file" (not not)? [17:42:23] DanielK_WMDE_: I think the dump patch should be good now [17:45:02] (03PS7) 10Smalyshev: Add dump implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 [17:45:20] (03PS5) 10Adrian Lang: Also load wikibase.ui.entityViewInit on read-only entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 [17:45:26] thank Adrian_WMDE [17:45:49] (03CR) 10Adrian Lang: Also load wikibase.ui.entityViewInit on read-only entities (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 (owner: 10Adrian Lang) [17:46:19] aude: Which is the most important change? [17:47:07] all of them :) [17:47:16] 2 are just stuck in gerrit but have +2 [17:47:24] yay! a wikidata-dump made it! [17:47:44] one that fixes site links is good to have but not a new bug [17:47:47] am i understanding it correctly that creating the dump took a month? [17:48:17] sticknode is a bug but maybe not critical at this point [17:49:02] auto width for entitytermsview might be more a matter of taste and design [17:49:22] dennyvrandecic_: really? [17:50:10] eoe [17:50:12] wow* [17:50:44] (03CR) 10Adrian Lang: [C: 032] "per thiemo." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194317 (https://phabricator.wikimedia.org/T91501) (owner: 10Aude) [17:51:12] (03CR) 10Adrian Lang: [C: 032] "per thiemo." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [17:52:06] aude: that's how I read https://dumps.wikimedia.org/wikidatawiki/20150307/ [17:52:24] (03CR) 10Adrian Lang: [C: 032] Fix reset of _initialAttributes.width in jquery sticknode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195987 (owner: 10Aude) [17:52:28] dennyvrandecic_: mentioned that https://phabricator.wikimedia.org/T88728#1113812 [17:52:35] dump started February 7, finished March 4 [17:52:40] maybe can get more attention [17:53:24] thx [17:53:37] (03Merged) 10jenkins-bot: Remove width from .wikibase-sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194317 (https://phabricator.wikimedia.org/T91501) (owner: 10Aude) [17:54:11] (03CR) 10Daniel Kinzler: [C: 04-1] "Missing RdfDumpGeneratorTest" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 (owner: 10Smalyshev) [17:54:43] wikimedia/mediawiki-extensions-Wikibase/master/624126f : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54122655 [17:55:28] DanielK_WMDE_: is the code there ok? if yes, I'll look into the test [17:56:06] (03Merged) 10jenkins-bot: Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [17:56:09] build broken on hhvm-nightly [17:56:29] apparently [17:56:39] and core also [17:56:57] it's with the rdf stuff [17:56:58] (03Merged) 10jenkins-bot: Fix reset of _initialAttributes.width in jquery sticknode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195987 (owner: 10Aude) [17:57:09] SMalyshev: DanielK_WMDE_: https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/54122661 [17:57:11] https://travis-ci.org/wikimedia/mediawiki on mysql [17:57:48] seems like unicode normalization issues or something like that [17:58:13] which is bad because i've found real bugs with mysql + mediawiki by looking at mediawiki on travis [17:58:22] and now we ignore / don't have such tests [17:59:12] and for rdf, wikibase, not sure how to fix except to put time to investigate [18:01:21] (03PS3) 10Smalyshev: Implement badges support for RDF export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192504 [18:03:15] (03CR) 10jenkins-bot: [V: 04-1] Implement badges support for RDF export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192504 (owner: 10Smalyshev) [18:03:48] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap: track entity usage on client pages - https://phabricator.wikimedia.org/T49288#1113865 (10jeremyb-phone) [18:05:55] (03PS4) 10Smalyshev: Implement badges support for RDF export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192504 [18:05:59] 414 Request-URI Too Large [18:06:02] fun [18:09:14] (03CR) 10Adrian Lang: [V: 04-1] "Looks quite good imho. Unfortunately, now the terms edit button collides with .wikibase-entitytermsforlanguagelistview-description, i. e. " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196011 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [18:11:18] (03CR) 10Aude: "they collide with me anyway, without this patch." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196011 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [18:11:36] (03CR) 10Aude: "for me*" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196011 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [18:12:04] Adrian_WMDE: something weird is going on with unicode there [18:12:29] Adrian_WMDE: which PHP version is this? [18:12:36] SMalyshev: hhvm [18:12:37] hhvm nightly [18:13:09] ahh.... I imagine that may be the reason. it probably messes up unicode somewhere... [18:13:26] this is a new(ish) issue [18:14:35] the problem is easyrdf is doing the encoding... so if there's incompatibility there we'd have to patch easyrdf :( [18:15:00] or get rid of that dependency [18:15:13] although would be nice to fix... [18:16:43] aude: getting rid of easyrdf is longer term goal, but it'll take some work [18:16:48] yeah [18:17:16] * DanielK_WMDE_ is pretty confident [18:17:53] (03CR) 10JanZerebecki: [C: 032] Implement badges support for RDF export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192504 (owner: 10Smalyshev) [18:18:22] check this out: http://3v4l.org/tGl5f [18:18:25] Adrian_WMDE: i get quite a lot of qunit failures because of "Unfinished animations:" [18:18:33] That's ULS [18:18:37] it's probably something wrong with my setup [18:18:40] Adrian_WMDE: aharoni [18:18:44] aa [18:18:46] AH [18:18:49] so utf8_decode is broken on hhvm :( [18:19:06] since 3.5.0 apparently [18:19:14] also https://phabricator.wikimedia.org/P390 about language codes [18:19:17] classy [18:19:44] SMalyshev: :( [18:19:51] aude: Yeah, test depending on your UI language. Must be english. Also, you need CLDR, I guess [18:20:16] i have cldr [18:20:32] and my language is english [18:20:33] mh, ok [18:21:03] that should work [18:21:52] also, looks like easyrdf encoding things wrong maybe... it assumes everything is iso-8859-1. so we have both ends broken :( [18:22:22] \u00D1\u0081 aren't valid russian chars [18:24:28] SMalyshev: it does?! wtf?? [18:24:42] one more reason to get rid of it [18:25:05] i'm making good progress. rdr will take longer, but i have a good idea of how to do it nicely. [18:25:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: wikibase.getLanguageNameByCode: wikibase.getLanguageNameByCode() qunit test failure - https://phabricator.wikimedia.org/T92532#1113955 (10aude) 3NEW [18:25:29] DanielK_WMDE_: i'll check if I can have a quick fix for it [18:26:22] The content encoding of N-Triples is always UTF-8 (http://www.w3.org/TR/n-triples/#sec-literals) [18:27:11] (03CR) 10Aude: [C: 032] "looks good now, and tried this out manually and ran qunit tests myself" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [18:27:29] unfortunately utf8_encode works only with iso-8859-1 which php manual does say but easyrdf ignores :( [18:27:48] should be using iconv [18:28:39] this is our own copy, right [18:28:48] we can optionally change stuff [18:29:04] Adrian_WMDE: I'll look into how to make it better [18:30:45] (03Merged) 10jenkins-bot: Introduce wikibase.view.ViewFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [18:31:33] wikidata stores everything in utf-8 too, right? [18:37:23] let's see what hhvm fols say: https://github.com/facebook/hhvm/issues/5010 [18:37:32] *folks [18:43:25] SMalyshev: yea, everything is utf8. and we have our own fork of easyrdf [18:44:00] then we don't need their encoding at all, we can just dump the strings... I'll make a patch for easyrdf and the tests [18:44:17] is easyrdf in gerrit too? [18:48:06] github i think [18:48:32] SMalyshev: https://github.com/Wikidata/easyrdf_lite [18:48:39] that's our fork [18:48:46] DanielK_WMDE_: so should I make a pull there? [18:48:52] SMalyshev: check upstream, maybe it was fixed. the fork isn't really maintained [18:49:09] yes. and if it's not fixed upstream, there too [18:49:34] SMalyshev: upstream is https://github.com/njh/easyrdf [18:49:47] DanielK_WMDE_: well, upstream has different code. Let me see if it works better [18:50:27] SMalyshev: we could just update the fork. all it does is deletre most of easyrdf, and just keep what is needed for serialization. [18:52:09] DanielK_WMDE_: ok, the new code overencodes a bit but at least the output is not broken. not sure how it'd do in hhvm though [18:52:17] but I'll make a pull [18:57:04] DanielK_WMDE_: https://github.com/Wikidata/easyrdf_lite/pull/4 [18:57:07] [13easyrdf_lite] 15smalyshev opened pull request #4: fix utf encoding issues (06master...06fix_encoding) 02http://git.io/pMfW [18:58:34] wikimedia/mediawiki-extensions-Wikibase/master/ef4fd02 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54133055 [19:11:09] (03PS1) 10Smalyshev: Fix broken UTF-8 encoding. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196304 [19:12:30] DanielK_WMDE_, Adrian_WMDE: i've made a test patch which can be used after the easyrdf pull is merged [19:13:55] Also see: https://lists.wikimedia.org/pipermail/wikidata-l/2014-December/005052.html [19:14:00] probably an old issue [19:14:03] (03CR) 10jenkins-bot: [V: 04-1] Fix broken UTF-8 encoding. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196304 (owner: 10Smalyshev) [19:15:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Upstream: N-Triples encoding for RDF output uses invalid escaping - https://phabricator.wikimedia.org/T76854#1114243 (10Smalyshev) See https://github.com/Wikidata/easyrdf_lite/pull/4 and https://gerrit.wikimedia.org/r/196304 [19:15:51] (03PS2) 10Smalyshev: Fix broken UTF-8 encoding. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196304 [19:16:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Upstream: N-Triples encoding for RDF output uses invalid escaping - https://phabricator.wikimedia.org/T76854#1114253 (10Smalyshev) p:5Normal>3High [19:18:41] (03CR) 10jenkins-bot: [V: 04-1] Fix broken UTF-8 encoding. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196304 (owner: 10Smalyshev) [19:19:32] so, who can patch up easyrdf_lite? [19:25:32] sjoerddebruin: Parlement gaat wel hard zeg [19:26:00] multichill: Ik wil het eigenlijk nog af hebben deze week, zodat ie mee kan worden genomen bij de entity suggester database update volgende week [19:27:46] Gisteren was het 40 matches, hoeveel nu wel niet? [19:33:07] sjoerddebruin: [20:27:56] Gisteren was het 40 matches, hoeveel nu wel niet? [19:33:37] 1500 +_ [19:36:34] Wel prijsschieten zeg. Kon net 50 items in een keer matchen [19:47:10] sjoerddebruin: Ok, no more auto matches [19:47:31] :O [19:47:41] Can you flush them out? [19:48:40] sjoerddebruin: ^^ [19:48:51] How do you mean? [19:50:26] Nevermind, that happens right away now [19:52:36] multichill: The game mode works better for the remaining ones. [19:56:52] sjoerddebruin: Yeah, that works quite well! :-D [19:57:17] Not always, but some of them. [19:58:44] It uses different searching I think... [20:09:19] Ik vraag mij wel af hoe sommige niet door huskyr zijn gevonden. [20:12:09] wikimedia/mediawiki-extensions-Wikibase/master/0a8a3ae : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54138177 [20:17:02] (03PS7) 10Daniel Kinzler: Fast RDF emitter [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [20:17:26] sjoerddebruin: Sommige hebben geen id [20:18:23] (03CR) 10jenkins-bot: [V: 04-1] Fast RDF emitter [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [20:23:45] SMalyshev: me, DanielK_WMDE_, JeroenDeDauw [20:23:54] I think everybody in WMDE [20:24:56] Adrian_WMDE: ok, so somebody please take a look, this should also fix the existing issue with Ntriples output [20:27:20] Adrian_WMDE: this one: https://phabricator.wikimedia.org/T76854 [20:28:33] multichill: Ik krijg bij een opeens http://www.montesquieu-instituut.nl/id/viq0ghg7fpzt/e_r_ewald_engelen in beeld [20:28:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Upstream: N-Triples encoding for RDF output uses invalid escaping - https://phabricator.wikimedia.org/T76854#1114620 (10Smalyshev) [20:28:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#1114619 (10Smalyshev) [20:29:03] Redirect http://www.parlement.com/id/viq0ghg7fpzt [20:29:05] sjoerddebruin: Wat bedoel je? [20:29:08] owh! [20:29:17] Wel gewoon toevoegen? [20:32:07] Tja, doe maar denk ik [20:41:48] [13ValueView] 15adrianheine created 06betterVisible (+1 new commit): 02http://git.io/pMFC [20:41:48] 13ValueView/06betterVisible 1437de8f8 15Adrian Heine: Handle browsers which cannot focus in test cases... [20:43:39] [13ValueView] 15adrianheine opened pull request #165: Handle browsers which cannot focus in test cases (06master...06betterVisible) 02http://git.io/pMbY [20:45:03] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25: Make ValueView qunit tests independent of focus. - https://phabricator.wikimedia.org/T91376#1114675 (10adrianheine) We have a tag, but unfortunately the fix does not work for PhantomJS. https://github.com/wmde/ValueView/pull/165 does, though. [20:45:13] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25: Make ValueView qunit tests independent of focus. - https://phabricator.wikimedia.org/T91376#1114677 (10adrianheine) 5Resolved>3Open [20:45:15] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1114678 (10adrianheine) [20:50:28] wikimedia/mediawiki-extensions-Wikibase/master/2c1c2e6 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54153631 [21:05:45] sjoerddebruin: Are you goig to create the missing people when you're done matching? [21:05:58] multichill: Yes, with proper sourcing. [21:06:46] That would be nice [21:09:06] sjoerddebruin: With all the recent edit-a-thons I was wondering if we could use Wikidata for easy writing lists [21:09:19] It's possible. [21:09:25] So instead of making some list of links on Wikipedia, make items on Wikidata with some basic info [21:09:55] But creating multiple items is still quite a pain [21:10:12] Well, I'm used to it. :P [21:10:45] For example it would be nice to have an item for every person in http://resources.huygens.knaw.nl/vrouwenlexicon [21:10:47] multichill: isn't that what Gather/Collections is about? [21:10:59] Maybe? Lik? [21:11:01] *link? [21:11:46] https://www.mediawiki.org/wiki/Extension:Gather – also, as part of my WikiProject X, I'd like to streamline the process for generating worklists. Any input you have on that would be helpful. [21:14:05] harej: I think the big question if you can formulate a work list as a query [21:14:16] Like, a Wikidata query? [21:14:31] "give me every European MP without an article in Dutch" [21:14:33] Like that [21:14:43] That's easy to have as a work list [21:14:50] More curated lists are harder [21:15:02] Yes, but I say have *all* the lists :D [21:15:29] Can you post your request on https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_X so I don't forget? [21:16:42] Me? I don't have a request ;-) [21:18:20] Well I went and recorded your idea anyway: https://www.wikidata.org/w/index.php?title=Wikidata%3AWikiProject_X&diff=203675546&oldid=200551401 [21:18:21] :D [21:19:07] :-) [21:24:18] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap: track entity usage on client pages - https://phabricator.wikimedia.org/T49288#1114893 (10Eloquence) Per roadmap policy, please provide a rough ETA no later than two weeks from now or remove this project from the roadmap if you think it will remain...