[00:14:38] (03PS1) 10Hoo man: Show labels in edit summaries on history/diff pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) [00:17:07] (03PS2) 10Hoo man: Show labels in edit summaries on history/diff pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) [07:33:33] (03CR) 10Tobias Gritschacher: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [07:37:26] (03CR) 10Tobias Gritschacher: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [07:37:33] (03CR) 10Tobias Gritschacher: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201063 (owner: 10Hoo man) [07:41:21] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityIdPlainLinkFormatter for SummaryFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [07:45:01] [13Time] 15tobijat pushed 1 new commit to 06master: 02http://git.io/jd8K [07:45:01] 13Time/06master 1479fae9a 15Tobi Gritschacher: Merge pull request #39 from DataValues/isoParser... [08:12:19] [13WikibaseDatabase] 15thiemowmde created 06coveralls (+1 new commit): 02http://git.io/jduF [08:12:19] 13WikibaseDatabase/06coveralls 14f39e683 15Thiemo Mättig: Drop .coveralls.yml [08:13:30] [13WikibaseDatabase] 15thiemowmde opened pull request #63: Drop .coveralls.yml (06master...06coveralls) 02http://git.io/jdzT [08:15:07] wmde/WikibaseDatabase/coveralls/f39e683 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDatabase/builds/56686618 [08:16:28] (03PS1) 10Thiemo Mättig (WMDE): Drop .coveralls.yml [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201145 [08:32:12] (03CR) 10Thiemo Mättig (WMDE): "> For the same reason ISO disallows years with less than four digits" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200210 (owner: 10Daniel Kinzler) [08:36:14] (03CR) 10Adrian Lang: "A diff has and old and a new ›side‹, but these ›sides‹, but a ›side‹ does not have to have a snak. The oldest snak is the oldest snak in t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187384 (owner: 10Thiemo Mättig (WMDE)) [08:36:39] (03CR) 10Adrian Lang: "-but these ›sides‹" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187384 (owner: 10Thiemo Mättig (WMDE)) [08:37:33] [13Common] 15thiemowmde 04force-pushed 06030 from 14eb8dc50 to 14d13de71: 02http://git.io/hAzs [08:37:33] 13Common/06030 14d13de71 15Thiemo Mättig: Prepare 1.0.0 release [08:41:11] (03CR) 10Adrian Lang: "I wonder if we couldn't just make EntityIdLinkFormatter not strip the namespace." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [08:41:28] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [08:41:53] (03CR) 10Adrian Lang: "There will be a lot more :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200860 (owner: 10Adrian Lang) [08:42:19] (03CR) 10Aude: [C: 04-1] "these need a manual rebase, due to merge conflict in the composer.json file :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200832 (owner: 10Adrian Lang) [08:42:53] (03CR) 10Daniel Kinzler: "I really don't have strong feelings about this. We are generally quite strict about input validation, and it seems sensible to be strict a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200210 (owner: 10Daniel Kinzler) [08:43:57] [13Geo] 15thiemowmde 04force-pushed 06edgeCase from 149636417 to 14b7c6d0f: 02http://git.io/q9v6AA [08:43:57] 13Geo/06edgeCase 14b7c6d0f 15Thiemo Mättig: Add edge case to GlobeCoordinateParserTest [08:46:22] [13Interfaces] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/jd6o [08:46:22] 13Interfaces/06master 1488c8622 15Thiemo Mättig: Prepare 1.0.0 release [08:46:22] 13Interfaces/06master 144778a64 15Thiemo Mättig: Merge pull request #11 from DataValues/100... [08:47:14] (03CR) 10Adrian Lang: [C: 032] "Nice." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200882 (https://phabricator.wikimedia.org/T94119) (owner: 10Hoo man) [08:50:12] (03PS2) 10Adrian Lang: Add language fallback for badge labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200848 (https://phabricator.wikimedia.org/T94552) [08:50:14] (03PS3) 10Adrian Lang: Move Wikibase\Template to view/src/Template/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200831 [08:50:16] (03PS3) 10Adrian Lang: Move Wikibase\Template to Wikibase\View\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200832 [08:50:18] (03PS2) 10Adrian Lang: Move Wikibase\Repo\View files to view/src [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200825 [08:50:20] (03PS3) 10Adrian Lang: Move Wikibase\Repo\View to Wikibase\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200826 [08:50:41] (03CR) 10Adrian Lang: "Manually rebased (composer.json)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200825 (owner: 10Adrian Lang) [08:50:47] (03CR) 10Adrian Lang: "Manually rebased (composer.json)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200826 (owner: 10Adrian Lang) [08:50:56] (03CR) 10Adrian Lang: "Manually rebased (composer.json)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200831 (owner: 10Adrian Lang) [08:51:05] (03CR) 10Adrian Lang: "Manually rebased (composer.json)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200832 (owner: 10Adrian Lang) [08:51:20] (03CR) 10Adrian Lang: "Manually rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200848 (https://phabricator.wikimedia.org/T94552) (owner: 10Adrian Lang) [08:51:28] (03Merged) 10jenkins-bot: Use wgPageName to construct a mw.Title in linkItem init [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200882 (https://phabricator.wikimedia.org/T94119) (owner: 10Hoo man) [08:55:00] (03CR) 10Adrian Lang: [C: 031] Drop .coveralls.yml [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201145 (owner: 10Thiemo Mättig (WMDE)) [08:56:02] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06optionalTime from 141b40ada to 14a6b13f9: 02http://git.io/hJ57 [08:56:02] 13DataValuesJavascript/06optionalTime 14a6b13f9 15Thiemo Mättig: Optional hour:minute, second and timezone in TimeValue [08:58:30] Tobi_WMDE_SW: around today? [08:58:36] [13Number] 15thiemowmde 04force-pushed 06getParserClass from 1412826e6 to 1498f8796: 02http://git.io/x5oI [08:58:36] 13Number/06getParserClass 1498f8796 15Thiemo Mättig: Replace dead code with LogicException [08:58:49] aude: yes [08:58:56] we need a new tag of https://github.com/wmde/DataValuesJavascript/releases [08:59:04] that doesn't include the breaking changes [08:59:11] that causes https://phabricator.wikimedia.org/T94674 [08:59:46] we could make 0.6.3 that fixes that (and 0.6.2 is bad, but leave it) [09:00:04] [13Serialization] 15thiemowmde 04force-pushed 06bootstrap from 14e91cf93 to 14c58237e: 02http://git.io/jd1F [09:00:04] 13Serialization/06bootstrap 14c58237e 15Thiemo Mättig: Drop composer update from test bootstrap [09:03:48] aude: not sure what exactly you mean.. 0.6.2 contains a breaking change? [09:04:53] jzerebecki released it yesterday [09:04:53] yeah [09:05:16] removal of mw.ext.dataValues [09:05:29] think he accidentally made the tag from master instead of from a branch [09:05:50] * aude just wants to fix this [09:06:55] Thiemo_WMDE: why are you poking at Wikibase Database? AFAIK we have no use for this component ATM [09:07:16] aude: ok, from what branch should it be made? [09:08:28] We don't usually have branches [09:08:40] JeroenDeDauw: The PR is a reminder. Feel free to ignore it for now. [09:08:53] [13DataValuesJavascript] 15tobijat created 06release0.6.2 (+2 new commits): 02http://git.io/jSs3 [09:08:53] 13DataValuesJavascript/06release0.6.2 147a016c4 15Adrian Heine: Don't explicitly depend on jquery.qunit... [09:08:53] 13DataValuesJavascript/06release0.6.2 147d8fbd1 15Jan Zerebecki: Release 0.6.2 [09:09:26] aude: Adrian_WMDE: so making a release based on https://github.com/wmde/DataValuesJavascript/tree/release0.6.2 would work? [09:09:34] I don't have the overview [09:10:02] That would work, yeah [09:10:09] Tobi_WMDE_SW: 0.6.1 ? [09:10:16] based on that [09:10:41] Adrian_WMDE: basically, i would make a branch from 0.6.1, cherry pick stuff [09:10:42] and tag [09:10:48] and then delete branch [09:10:48] aude: Adrian_WMDE: please decide yourself and check back with jzerebecki [09:11:19] IMHO 0.6.3 should contain the stuff jzerebecki wanted to have in 0.6.2 [09:11:26] We want to have a point release which is 0.6.1+qunit change [09:11:39] I think that's what you just posted [09:11:55] feel free to tag [09:11:56] We can force it over 0.6.2, or call it 0.6.3 [09:12:13] oh Tobi_WMDE_SW hello :) [09:12:23] HI hashar [09:12:27] Tobi_WMDE_SW: zeljkof and I have been looking at the slow run of browsertests [09:13:02] seems the WikidataTests are suffering from the issue of having a 20-30 secs delay before each scenario. That would explain the 3hours+ run time [09:13:30] Adrian_WMDE: guten Morgen :) [09:13:52] Adrian_WMDE: https://gerrit.wikimedia.org/r/201062 What do you mean strip the namespace? [09:14:11] We never strip namespaces anywhere as that would break the linking [09:14:43] hoo: Currently EntityIdLinkFormatter does [[PAGETITLE|SERIALIZATION]] [09:14:53] yes [09:15:27] I wonder if we couldn't just make it [[PAGETITLE]] [09:15:27] Currently, the only visible change that would introduce is not stripping ›Property:‹ [09:15:41] [13Time] 15thiemowmde 04force-pushed 06timeFormatterCal2 from 14edaf292 to 14c617841: 02http://git.io/pQaF [09:15:41] 13Time/06timeFormatterCal2 14c617841 15Thiemo Mättig: Fix outdated calendar logic in TimeFormatter [09:16:13] Adrian_WMDE: Yes... but you initially changed that, so I guess you had a reason to [09:16:27] undoing that would essentially mean reverting your change AFAIS [09:16:32] hashar: Maybe you'd want to know that I won't bother you for the next few months :) [09:17:17] Adrian_WMDE: have you ? :D [09:17:38] Adrian_WMDE: I have been rather busy with some CI infrastructure stuff so I have barely looked at review requests for jobs :/ [09:18:04] for the browser test slowness, you guys might want to subscribe to the task https://phabricator.wikimedia.org/T92613 "It takes about 20 seconds just to start a Sauce Labs browser" [09:18:29] hoo: Depends on what MessageParameterFormatter needs. My change was about using an EntityIdFormatter in MessageParameterFormatter; My approach was to modify the EntityIdFormatter to match what MessageParamaterFormatter had previously [09:18:43] hoo: Which broke SummaryFormatter. [09:19:30] Ok... so what shall we do about MessageParameterFormatter? And what about other usages of the formatters? [09:19:38] hoo: So now I would try the other approach and keep the EntityIdLinkFormatter as it is (which will fix SummaryFormatter) and check if it breaks MessageParameterFormatter; if it does, we need to different formatters; if it doesn't, yeah! [09:20:07] [13Time] 15thiemowmde 04force-pushed 06tvAgain from 14e62b6a9 to 148565ded: 02http://git.io/jd5k [09:20:07] 13Time/06tvAgain 148565ded 15Thiemo Mättig: More TimeValue tests [09:20:16] hashar: Apparently I didn't bother you enough. But except for WikibaseJavaScriptApi stuff got merged quite quickly. [09:20:50] Adrian_WMDE: I can do that and see what happens, if you want [09:20:57] That would be great :) [09:21:07] I'd like to get away with only one of these formatters, if possible [09:22:16] yeah, taht would be nicer [09:22:18] hashar: thx, I 'm subscribed to the ticket already and following the topic with great interest.. would be really nice to be able to sped things up a bit [09:22:36] Adrian_WMDE: great! [09:23:15] Tobi_WMDE_SW: in short if you look for an element with something like: a( :some_id_name, href: /regex/ ) [09:23:43] hashar: But if you want to have another look at that one, that would be a nice goodbye present https://gerrit.wikimedia.org/r/#/c/180418/ :) [09:23:57] Tobi_WMDE_SW: what happens is that the webdriver query the browser for all A element. Then page-objects/watir/webdriver ends up asking FOR EACH element the 'href' attribute to be able to do the regex match [09:24:28] Tobi_WMDE_SW: so if you have 200 A elements on the page, you end up doing 200 queries over the network to SauceLabs. Which is: (1) dumb (2) slow [09:24:48] hashar: indeed [09:25:11] hashar: and wikidata has a lot of them! [09:25:59] but mainly on large items, which isn't the case for most of the tests [09:26:17] but still, doing these requests seem pointless [09:26:57] Adrian_WMDE: How do I assess whether MessageParameterFormatter is fine? [09:27:01] The tests pass [09:27:55] Tobi_WMDE_SW: yeah. We gotta fix page-objects / watir / webdriver or whatever is causing it [09:28:08] Uhm, dunno. Find out what it does and verify manually? I have no clue what that even is [09:29:01] Adrian_WMDE: Ok, will try [09:29:54] Adrian_WMDE: I will let Timo handle it [09:30:42] [13Time] 15thiemowmde 04force-pushed 06formatterConsts from 146e220fb to 14cfaa61f: 02http://git.io/jdbV [09:30:42] 13Time/06formatterConsts 14cfaa61f 15Thiemo Mättig: Stop using formatter constants in parsers [09:32:50] Adrian_WMDE: "…is already used by item Item:Q120. You may remove it from Item:Q120…" that's how the stuff looks in the UI after that on my local repo that has items outside NS0 [09:33:33] Mh [09:33:40] Maybe we just want to have two formatters [09:33:54] Maybe [09:34:34] Would like to have opinions from aude and DanielK_WMDE_ on that [09:34:39] ack [09:35:01] Or maybe on link begin should just discard display text... but that sounds evil [09:36:41] [13DataValuesJavascript] 15filbertkm created 060.6.3 (+2 new commits): 02http://git.io/jdA0 [09:36:41] 13DataValuesJavascript/060.6.3 14b94587e 15Adrian Heine: Don't explicitly depend on jquery.qunit... [09:36:41] 13DataValuesJavascript/060.6.3 14d82d54b 15aude: Update README for 0.6.3 [09:36:59] i'll wait for jan, but https://github.com/wmde/DataValuesJavascript/commits/0.6.3 [09:37:17] if no objections, will tag that [09:37:27] get no js errors now [09:39:34] (03PS10) 10Daniel Kinzler: Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 [09:44:10] hoo: what's the issue with the EntityIdFormatter? [09:44:34] DanielK_WMDE_: T93804 [09:44:40] DanielK_WMDE_: We use it for SummaryFormatter (the thing that converts Summary objects to use in edit summaries) [09:44:55] !bug T93804 [09:45:09] does the bot handle phabricator things? [09:45:12] In the summaries we *need* links without display text as we want the onLinkBegin stuff to add a label to them [09:45:16] !phab T93804 [09:45:40] But in other places we want to have links like [[Item:Q1|Q1]] [09:45:53] Now the question is: Have two formatters? [09:46:05] See also https://gerrit.wikimedia.org/r/201062 [09:49:02] hoo: we already have 6 or so EntityIdFormatters [09:49:06] sure, add another, why not :) [09:49:33] but, uh... when is the MessageParameterFormatter applied? which language would it use for the label? [09:50:04] MessageParameterFormatter is what we use to localize errors (exceptions) from the API to show them in the UI [09:50:19] so that one doesn't get mangled afterwards to include labels [09:53:59] hoo: i'm trying to understand when and where the link in question is even generated. [09:54:13] DanielK_WMDE_: In MessageParameterFormatter? [09:54:27] no, that one isn't an issue, right? it behaves correctly? [09:54:57] i mean the links in the edit summary. is it in the auto-summary or the auto-comment?... [09:56:09] DanielK_WMDE_: In the link begin handling stuff [09:56:29] hoo: SummaryFormatter::formatIfEntityId [09:56:38] Oh that [09:56:48] the SummaryFormatter gets an EntityIdFormatter injected [09:56:52] Yep [09:56:53] that should be where it's all happening [09:57:25] hoo: the ticket asks for the label to be shown. The patch shows the full page title. I don't see how they are related, or why we would show the full page title. [09:57:26] My patch makes it require the new formatter explicitly [09:57:39] the tickets is about edit summaries [09:58:17] yes. "edit summary doesn't show label of property when changing claims" [09:58:54] Well, if we have a link like [[Item:Q1]] in an edit summary our link magic will add the label to it [09:59:14] labels. the patch does nothign with lables, as far as i can tell... [09:59:25] but if we set a display text ourselves (like [[Item:Q1|Q1]] or even [[Q1|Q1]]) the link begin stuff will not alter the links [09:59:28] oh, true, the magic thingy does that [09:59:33] as they already have a user display text [10:00:00] Yep, see also my other (totally unrelated patch) to that [10:00:37] hoo: i'm not very happy to *force* the specific EntityIdFormatter on the SUmmaryFormatter [10:00:55] Why? It only really works with that formatter [10:01:05] Not semantically, yes [10:01:18] but in the end it only does its job correctly with that formatter [10:01:44] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-01T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/201156 [10:05:55] hoo: if, how and when the links get magically replaced is nothing the SummaryFormatter should know or care about. [10:06:01] it should use whatever id formatter you give it [10:06:25] the code that constructs the SummaryFormatter can and should know about it. It's application level knowledge [10:06:58] [13DataValuesJavascript] 15filbertkm tagged 060.6.3 at 060.6.3: 02http://git.io/jFkn [10:07:13] [13DataValuesJavascript] 15filbertkm 04deleted 060.6.3 at 14d82d54b: 02http://git.io/jFku [10:07:40] DanielK_WMDE_: Mh ok [10:08:07] How can we make sure that's not happening again? Shall I just add comments there and ask for caution? [10:08:15] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-04-01T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/201156 (owner: 10WikidataBuilder) [10:08:23] (03CR) 10Daniel Kinzler: [C: 04-1] Introduce EntityIdPlainLinkFormatter for SummaryFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [10:09:03] (03CR) 10Daniel Kinzler: "@Adrian: I'm pretty sure there are cases when we want to strip the namespace." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [10:10:30] DanielK_WMDE_: hoo: Just to be clear: There are only two users of wikitext EntityIdFormatters: SummaryFormatter and MessageParameterFormatter [10:13:19] Adrian_WMDE: oh, i thought we also uise that in EntityIdValueFormatter, for rendering in wikitext on the client? [10:15:07] DanielK_WMDE_: No, that get's either a EntityIdLabelFormatter or even an EntityIdHtmlLinkFormatter [10:15:32] [13Time] 15thiemowmde 04force-pushed 06redone from 1440c715c to 14c4f3513: 02http://git.io/bKQt [10:15:32] 13Time/06redone 140819589 15Thiemo Mättig: Major rewrite of TimeParser [10:15:32] 13Time/06redone 1410a5529 15Thiemo Mättig: Basic range checks [10:15:32] 13Time/06redone 143269ace 15Thiemo Mättig: More strict parsing for years <60 [10:16:39] Maybe the MessageParameter stuff would work fine with an EntityIdLabelFormatter? [10:16:41] (03CR) 10Aude: [C: 032] "let's get these merged :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200825 (owner: 10Adrian Lang) [10:17:05] That way we could get rid of the [[Item:Q1|Q1]] formatter [10:17:11] DanielK_WMDE_: Adrian_WMDE ^ [10:17:13] (03CR) 10Aude: [C: 032] Move Wikibase\Repo\View to Wikibase\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200826 (owner: 10Adrian Lang) [10:17:25] (03CR) 10Aude: [C: 032] Move Wikibase\Template to view/src/Template/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200831 (owner: 10Adrian Lang) [10:17:35] (03CR) 10Aude: [C: 032] Move Wikibase\Template to Wikibase\View\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200832 (owner: 10Adrian Lang) [10:18:14] hoo: Does the EntityIdLabelFormatter produce wikitext? We still want to link, right [10:18:58] Adrian_WMDE: Seems it doesn't... nevermind, then [10:20:09] [13Time] 15thiemowmde 04force-pushed 06formatterConsts from 14cfaa61f to 1411bea50: 02http://git.io/jdbV [10:20:09] 13Time/06formatterConsts 1411bea50 15Thiemo Mättig: Stop using formatter constants in parsers [10:20:33] (03CR) 10Aude: Add language fallback for badge labels (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200848 (https://phabricator.wikimedia.org/T94552) (owner: 10Adrian Lang) [10:21:10] hoo: neither EntityIdLabelFormatter nor EntityIdHtmlLinkFormatter would work for creating wikitext links. We'd need one that does [[Item:Q1|label]]. I'm afraid we currently don't generate links there at all. we should, otherwise users will hack it in. [10:21:30] hoo: but that's for Lua etc. For the SUmmaryFormatter, you are right, I think.... [10:22:01] (03Merged) 10jenkins-bot: Move Wikibase\Repo\View files to view/src [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200825 (owner: 10Adrian Lang) [10:22:42] (03Merged) 10jenkins-bot: Move Wikibase\Repo\View to Wikibase\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200826 (owner: 10Adrian Lang) [10:22:45] (03Merged) 10jenkins-bot: Move Wikibase\Template to view/src/Template/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200831 (owner: 10Adrian Lang) [10:22:45] [13Time] 15thiemowmde 04force-pushed 06timeFormatterCal2 from 14c617841 to 1494769b6: 02http://git.io/pQaF [10:22:45] 13Time/06timeFormatterCal2 1494769b6 15Thiemo Mättig: Fix outdated calendar logic in TimeFormatter [10:22:50] hoo: so, I agree we can replace the [[Item:Q1|Q1]] formatter with one that does just [[Item:Q1]]. [10:23:12] i still don't like the concrete formater to be hardwired in SummaqryFormatter though [10:23:18] Ok... I'll polish my patch in a bit with your suggestion (and fix the tests) [10:23:27] Yeah, will fix that [10:23:35] (03Merged) 10jenkins-bot: Move Wikibase\Template to Wikibase\View\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200832 (owner: 10Adrian Lang) [10:23:47] does anyone want to look at https://gerrit.wikimedia.org/r/#/c/200543/ or its alternative? [10:23:59] hoo: as to preventing the issue from happening again - perhaps add a comment in the id formatter itself, as well as in the SummaryFormatter. [10:24:02] css issue in the site links section [10:25:34] that sounds sane, yes [10:25:45] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/200543/ [10:25:55] prop = Property(self.repo, id=pid) [10:26:02] * aude is making a branch soon [10:26:02] prop.type [10:26:07] AttributeError: APISite instance has no attribute 'getPropertyType' [10:26:10] What am I doing wrong+ [10:26:13] aude: Please wait for the formatter stuff [10:27:38] hoo: not too long [10:27:48] making a branch for beta at least [10:27:51] errr build* [10:28:15] aude: Ok, will do it now then and finish my review later [10:28:23] ok [10:28:38] [13DataValuesJavascript] 15thiemowmde created 06readme063 (+1 new commit): 02http://git.io/jFOE [10:28:38] 13DataValuesJavascript/06readme063 14f4de703 15Thiemo Mättig: Update README.md [10:29:00] [13DataValuesJavascript] 15thiemowmde opened pull request #77: Update README.md (06master...06readme063) 02http://git.io/jFOV [10:30:17] [13DataValuesJavascript] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/jF3J [10:30:17] 13DataValuesJavascript/06master 14ae01032 15Thiemo Mättig: Merge pull request #77 from wmde/readme063... [10:34:43] (03CR) 10JanZerebecki: [C: 032] Stop WikiPageEntityStoreTest from leaking into the real DB [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201063 (owner: 10Hoo man) [10:36:34] https://gerrit.wikimedia.org/r/#/c/198228/ would be nice to have reviewed [10:36:53] * aude can take a look if no one else wants to [10:37:56] I can take a look, but verifying it manually usually is a little hard to me (I have no knowledge in any single rtl languages) [10:37:59] (03CR) 10Aude: [C: 032] Move wikibase.view JS into subdirectory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200860 (owner: 10Adrian Lang) [10:38:05] hoo: ok [10:38:54] (03PS1) 10Adrian Lang: Move wikibase.view JS tests into subdirectory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201160 [10:38:55] more concerned if the things adrian pointed out are adequately fixed now [10:38:56] (03PS1) 10Adrian Lang: Move entityChangers from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201161 [10:38:58] (03PS1) 10Adrian Lang: Move jquery/ from repo to view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201162 [10:39:00] (03PS1) 10Adrian Lang: Move jquery.ui from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201163 [10:39:02] (03PS1) 10Adrian Lang: Move wikibase.store from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201164 [10:39:04] (03PS1) 10Adrian Lang: Move wikibase.ValueViewBuilder from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201165 [10:39:05] wow [10:39:25] (03CR) 10jenkins-bot: [V: 04-1] Move jquery.ui from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201163 (owner: 10Adrian Lang) [10:39:31] (03CR) 10jenkins-bot: [V: 04-1] Move wikibase.store from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201164 (owner: 10Adrian Lang) [10:39:38] (03CR) 10jenkins-bot: [V: 04-1] Move wikibase.ValueViewBuilder from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201165 (owner: 10Adrian Lang) [10:40:02] (03Merged) 10jenkins-bot: Stop WikiPageEntityStoreTest from leaking into the real DB [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201063 (owner: 10Hoo man) [10:40:37] (03CR) 10Hoo man: Introduce EntityIdPlainLinkFormatter for SummaryFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [10:40:46] (03PS2) 10Hoo man: Introduce EntityIdPlainLinkFormatter for SummaryFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) [10:41:49] (03PS2) 10Adrian Lang: Move wikibase.ValueViewBuilder from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201165 [10:41:51] (03PS2) 10Adrian Lang: Move wikibase.store from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201164 [10:41:53] (03PS2) 10Adrian Lang: Move entityChangers from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201161 [10:41:55] (03PS2) 10Adrian Lang: Move wikibase.view JS tests into subdirectory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201160 [10:41:57] (03PS2) 10Adrian Lang: Move jquery.ui from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201163 [10:41:59] (03PS2) 10Adrian Lang: Move wikibase.view JS into subdirectory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200860 [10:42:01] (03PS2) 10Adrian Lang: Move jquery/ from repo to view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201162 [10:43:21] (03PS3) 10Adrian Lang: Add language fallback for badge labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200848 (https://phabricator.wikimedia.org/T94552) [10:43:37] (03CR) 10Adrian Lang: Add language fallback for badge labels (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200848 (https://phabricator.wikimedia.org/T94552) (owner: 10Adrian Lang) [10:45:00] (03CR) 10Aude: Better handling of bidi content on entity terms table (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [10:47:44] aude: Do you want the bidirectional content patch in the branch? [10:48:09] the formatter stuff just passed jenkins and is ready for review, btw [10:51:03] hoo: ideally [10:51:33] (03PS3) 10Adrian Lang: Move wikibase.ValueViewBuilder from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201165 [10:51:35] (03PS3) 10Adrian Lang: Move wikibase.store from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201164 [10:51:37] (03PS1) 10Adrian Lang: Move wikibase.RevisionStore from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201167 [10:52:32] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200860 (owner: 10Adrian Lang) [10:53:43] (03CR) 10Adrian Lang: [C: 031] "Great" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [10:55:57] * aude finds https://phabricator.wikimedia.org/T90893 annoying [10:56:09] will try to make a priority to look at later today or tomorrow [10:58:04] (03CR) 10Adrian Lang: [C: 032] "Per Aude." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200860 (owner: 10Adrian Lang) [11:02:28] hehe https://com.google/ [11:02:48] (03Merged) 10jenkins-bot: Move wikibase.view JS into subdirectory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200860 (owner: 10Adrian Lang) [11:02:55] (03CR) 10Hoo man: "RE to aude, haven't looked at the rest, yet." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:04:32] addshore: :D [11:05:08] aude: Would be nice to have that context in mw.messages (like we have in PHP), but that's not that easy given how we propagate messages to JS via RL [11:05:14] Want to create a bug? [11:06:17] * mw.message( 'foo' ) [11:12:03] (03PS3) 10Hoo man: Introduce EntityIdPlainLinkFormatter for SummaryFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) [11:12:15] (03CR) 10Hoo man: Introduce EntityIdPlainLinkFormatter for SummaryFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [11:12:51] (03PS4) 10Hoo man: Introduce EntityIdPlainLinkFormatter for SummaryFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) [11:13:24] (03CR) 10Hoo man: "Fixed the typo pointed out, corrected the commit summary." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [11:19:29] aude: Lydia_WMDE: https://www.wikidata.org/wiki/Q11693341?uselang=he If you click on the edit link for terms there, what happens? [11:19:51] for me it works just fine, but after a bit I'm getting redirected to the special page... wtf [11:19:59] (03CR) 10Adrian Lang: [C: 032] Introduce EntityIdPlainLinkFormatter for SummaryFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [11:20:08] (03PS1) 10Adrian Lang: Move wikibase.getLanguageNameByCode from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201168 [11:20:10] (03PS1) 10Adrian Lang: Move wikibase.templates from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201169 [11:20:36] Repo is clean now [11:25:15] (03PS11) 10Hoo man: Better handling of bidi content on entity terms table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:25:34] (03CR) 10Daniel Kinzler: [C: 031] "looks good, needs manual verification" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [11:25:45] (03CR) 10Hoo man: "Locally rebased (went through just fine, without manual intervention)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:27:29] (03CR) 10Hoo man: [C: 032] "Would be nice if mw.msg/ mw.message could tell us what language it's using... but for now I think this is good enough." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:27:44] (03Merged) 10jenkins-bot: Introduce EntityIdPlainLinkFormatter for SummaryFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201062 (https://phabricator.wikimedia.org/T93804) (owner: 10Hoo man) [11:27:58] jgit apparently isn't able to resolve file move when rebasing... cgit didn't have a problem with that [11:30:10] (03CR) 10Daniel Kinzler: [C: 04-1] "The code looks good, but it assumes that Julian dates are stored unconverted in entity data. This isn't the case, and the jury is still ou" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [11:30:31] (03CR) 10jenkins-bot: [V: 04-1] Better handling of bidi content on entity terms table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:34:27] that npm failure looks bogus [11:34:32] there are only 2 lines [11:35:12] (03PS12) 10Hoo man: Better handling of bidi content on entity terms table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:35:35] (03CR) 10Hoo man: "Removed an empty line to make jenkins happy" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:36:57] (03CR) 10Hoo man: [C: 032] Better handling of bidi content on entity terms table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:37:19] (03CR) 10Daniel Kinzler: Factor database access out of WikiPageEntityRevisionLookup (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200209 (owner: 10Hoo man) [11:37:34] hoo: want to fix the whitespace? this is good to merge otherwise [11:38:15] DanielK_WMDE_: Yes, will do [11:39:43] Adrian_WMDE: i think subclassing is ok for the UsageAccumulator stuff https://gerrit.wikimedia.org/r/#/c/191336/4 [11:40:01] What exactly is your -1 for? if you don't see major issues, i'd just merge this [11:40:04] DanielK_WMDE_: I don't :P [11:40:22] ok, in it goes... [11:40:26] I don't see major issues, it's just not how I think this is done best [11:40:47] That referred to ›i think subclassing is ok for the UsageAccumulator stuff‹ [11:40:49] (03CR) 10Daniel Kinzler: [C: 032] "Subclassing is probably fine in this case." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191336 (owner: 10Thiemo Mättig (WMDE)) [11:41:43] (03Merged) 10jenkins-bot: Better handling of bidi content on entity terms table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [11:42:32] (03CR) 10Daniel Kinzler: "Note sure it'S uncontroversial to remove the question mark from "The time is always saved internally in the Proleptic Gregorian format"." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200845 (https://phabricator.wikimedia.org/T66084) (owner: 10Thiemo Mättig (WMDE)) [11:42:46] (03Merged) 10jenkins-bot: Consolidate duplicate code in UsageAccumulator classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191336 (owner: 10Thiemo Mättig (WMDE)) [11:43:37] aude: As far as I'm aware we're ready to branch! [11:43:47] (03PS3) 10Hoo man: Factor database access out of WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200209 [11:43:53] (03PS11) 10Daniel Kinzler: Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) [11:43:55] (03CR) 10Hoo man: Factor database access out of WikiPageEntityRevisionLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200209 (owner: 10Hoo man) [11:44:01] (03PS1) 10Adrian Lang: Move jquery.wikibase from lib/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201170 [11:44:09] (03CR) 10Hoo man: "Added missing space" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200209 (owner: 10Hoo man) [11:44:11] (03CR) 10jenkins-bot: [V: 04-1] Move jquery.wikibase from lib/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201170 (owner: 10Adrian Lang) [11:44:24] You'd definitely want https://gerrit.wikimedia.org/r/201170 in for backports hoo aude [11:45:38] Adrian_WMDE: Ok... I'm convinced, no go convince jenkins :D [11:45:41] * now [11:46:40] hoo: I'll convince jenkins as soon as the underlying changes are merged, otherwise jenkins will have to run the tests 10 times more [11:47:15] Ok, I'll go through them all [11:47:22] (03CR) 10Daniel Kinzler: [C: 032] Factor database access out of WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200209 (owner: 10Hoo man) [11:51:09] (03CR) 10Hoo man: [C: 032] Move wikibase.view JS tests into subdirectory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201160 (owner: 10Adrian Lang) [11:52:24] hoo: are all adrian's thing in? [11:52:26] (03Merged) 10jenkins-bot: Factor database access out of WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200209 (owner: 10Hoo man) [11:52:33] aude: By far not [11:52:42] :/ [11:53:03] * aude would hate to try to fix a bug and cherrypick after https://gerrit.wikimedia.org/r/#/c/201170/ [11:53:17] That's what I meant [11:53:21] yeah [11:53:32] aude: git is surprisingly good at applying patches to moved fiels [11:53:45] I'm going through all of them now... but that's going to take some time [11:54:09] Adrian_WMDE: any chance for the unit selector to happen before you vanish?... [11:54:32] hahah! [11:54:42] DanielK_WMDE_: That's in two hours and it's not even in the sprint?! [11:55:23] Adrian_WMDE: Two hours sonds a bit tight ;) I'm only asking because you asked me about it last week. That got my hopes up [11:55:30] *sigh* [11:55:46] (03CR) 10Hoo man: [C: 032] Move entityChangers from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201161 (owner: 10Adrian Lang) [11:56:23] i'm off now, will be back in about 7 hours... [11:56:37] aude: https://www.wikidata.org/wiki/Q11693341?uselang=ar Can you edit the terms there? Or are you as well getting redirected to the special pages [11:57:06] DanielK_WMDE_: That was about priorization for when I'm gone [11:57:26] hoo: i think we had this issue before [11:57:33] there is a bug for it afaik [11:57:40] can't believe it's not fixed [12:03:33] i cannot find the bug but pretty sure there was one [12:03:57] Maybe Lydia knows? [12:04:18] (03CR) 10Hoo man: [C: 032] Move jquery/ from repo to view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201162 (owner: 10Adrian Lang) [12:04:25] i don't remember any bug about this no [12:04:48] i would file a new bug [12:05:02] if someone manages to find the old one, they can be merged [12:08:10] (03Merged) 10jenkins-bot: Move wikibase.view JS tests into subdirectory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201160 (owner: 10Adrian Lang) [12:08:14] (03Merged) 10jenkins-bot: Move entityChangers from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201161 (owner: 10Adrian Lang) [12:08:34] (03Merged) 10jenkins-bot: Move jquery/ from repo to view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201162 (owner: 10Adrian Lang) [12:09:06] rebasing [12:09:23] (03PS4) 10Adrian Lang: Move wikibase.ValueViewBuilder from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201165 [12:09:25] (03PS4) 10Adrian Lang: Move wikibase.store from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201164 [12:09:27] (03PS2) 10Adrian Lang: Move wikibase.RevisionStore from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201167 [12:09:29] (03PS3) 10Adrian Lang: Move jquery.ui from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201163 [12:09:31] (03PS2) 10Adrian Lang: Move wikibase.getLanguageNameByCode from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201168 [12:09:33] (03PS2) 10Adrian Lang: Move wikibase.templates from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201169 [12:09:35] (03PS2) 10Adrian Lang: Move jquery.wikibase from lib/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201170 [12:09:37] (03PS1) 10Adrian Lang: Move wikibase.utilities from lib/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201174 [12:09:39] (03PS1) 10Adrian Lang: Rename jquery.wikibase-shared to jquery.wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201175 [12:13:23] https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/Single/2015-04-01#/media/File:Giant_monster_cat.jpg :) [12:14:43] * hoo prefers kittens :D [12:14:52] heh [12:15:22] (03CR) 10Hoo man: [C: 032] Move jquery.ui from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201163 (owner: 10Adrian Lang) [12:17:26] can reproduce bug on https://test.wikidata.org/wiki/Q22?uselang=ar [12:17:28] but not locally [12:19:01] (03CR) 10Hoo man: [C: 032] Move wikibase.store from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201164 (owner: 10Adrian Lang) [12:19:05] (03CR) 10Thiemo Mättig (WMDE): "I removed the question mark because it's non-informative. It doesn't even say *WHAT* exactly is in question. Who put it there by the way? " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200845 (https://phabricator.wikimedia.org/T66084) (owner: 10Thiemo Mättig (WMDE)) [12:21:58] aude: Is hhvm able to optimize these: "return call_user_func( function() { … }" [12:22:13] (03Merged) 10jenkins-bot: Move jquery.ui from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201163 (owner: 10Adrian Lang) [12:22:30] hoo: no idea [12:22:30] I remember something about that not being nice to hhvm [12:22:38] But can't really remember exactly [12:24:19] (03PS7) 10Adrian Lang: Edit References along with Statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190799 (https://phabricator.wikimedia.org/T87759) (owner: 10Henning Snater) [12:24:42] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190799 (https://phabricator.wikimedia.org/T87759) (owner: 10Henning Snater) [12:26:19] (03Merged) 10jenkins-bot: Move wikibase.store from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201164 (owner: 10Adrian Lang) [12:27:17] (03CR) 10Hoo man: [C: 032] Move wikibase.ValueViewBuilder from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201165 (owner: 10Adrian Lang) [12:28:30] (03CR) 10Hoo man: [C: 032] Move wikibase.RevisionStore from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201167 (owner: 10Adrian Lang) [12:30:54] (03PS8) 10Adrian Lang: Edit References along with Statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190799 (https://phabricator.wikimedia.org/T87759) (owner: 10Henning Snater) [12:31:12] (03CR) 10Hoo man: [C: 032] Move wikibase.getLanguageNameByCode from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201168 (owner: 10Adrian Lang) [12:31:20] (03Merged) 10jenkins-bot: Move wikibase.ValueViewBuilder from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201165 (owner: 10Adrian Lang) [12:33:36] (03CR) 10Hoo man: [C: 032] Move wikibase.templates from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201169 (owner: 10Adrian Lang) [12:33:38] (03Merged) 10jenkins-bot: Move wikibase.RevisionStore from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201167 (owner: 10Adrian Lang) [12:34:25] hi [12:34:38] hi JeanBono [12:36:45] (03Merged) 10jenkins-bot: Move wikibase.getLanguageNameByCode from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201168 (owner: 10Adrian Lang) [12:38:31] (03Merged) 10jenkins-bot: Move wikibase.templates from repo/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201169 (owner: 10Adrian Lang) [12:38:42] I'm adding some 19th century french architects on Wikidata ; when I use the "sex or gender" property, I have to scroll down many items to find the correct "male" choice [12:38:58] is there a way to have this item on top of the list ? [12:40:09] can someone get me the total number of sitelinks? [12:40:16] (03CR) 10Hoo man: [C: 032] Move jquery.wikibase from lib/ to view/ (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201170 (owner: 10Adrian Lang) [12:41:02] WDQ has 42904902 [12:41:25] hoo: ack. [12:43:35] (03CR) 10Hoo man: [C: 032] Move wikibase.utilities from lib/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201174 (owner: 10Adrian Lang) [12:43:45] (03Merged) 10jenkins-bot: Move jquery.wikibase from lib/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201170 (owner: 10Adrian Lang) [12:43:59] (03CR) 10Adrian Lang: [C: 04-1] Edit References along with Statement (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190799 (https://phabricator.wikimedia.org/T87759) (owner: 10Henning Snater) [12:43:59] Lydia_WMDE, Harmonia_Amanda told me to ask you about it [12:44:01] (03CR) 10Thiemo Mättig (WMDE): "I think it's not the job of this validation step to apply the convenience-padding we talked about. https://github.com/DataValues/Time/pull" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200210 (owner: 10Daniel Kinzler) [12:44:23] sjoerddebruin: can you give me the magic link to get this number out of it? :D [12:44:29] https://wdq.wmflabs.org/stats [12:44:33] Ok, I think that was all we need for now, right? [12:44:42] JeanBono: we're working on that yes [12:44:51] Lydia_WMDE: thank you [12:44:56] sjoerddebruin: thanks! [12:46:13] thank you [12:47:12] aude: Adrian_WMDE: Enough for the branch? Or do you need/ want the next in chain as well? [12:47:43] wikibase-shared is basically never touched [12:47:44] (03Merged) 10jenkins-bot: Move wikibase.utilities from lib/ to view/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201174 (owner: 10Adrian Lang) [12:47:47] Adrian_WMDE: link? [12:47:54] So I doubt we get difficult cherry-picks there [12:48:01] ah, that [12:48:04] Ok :) [12:55:52] (03PS3) 10Thiemo Mättig (WMDE): Major refactoring of ClaimDifferenceVisualizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187384 [12:57:14] hoo: making new build for beta now [12:57:25] ok :) [12:58:03] Removing wikibase/easyrdf_lite (0.8.1) [12:58:24] (03CR) 10Thiemo Mättig (WMDE): "I understand, but find this highly confusing. Which is the reason why my original patch made these two parameters nullable everywhere and " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187384 (owner: 10Thiemo Mättig (WMDE)) [12:58:28] Removing? Didn't you create a build from scratch? [12:58:40] easyrdf is removed [12:58:57] now we have purtle [12:58:59] (03PS1) 10Aude: New Wikidata build - 01/04/2015 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/201180 [12:58:59] :) [12:59:03] (03CR) 10JanZerebecki: [C: 032] Drop .coveralls.yml [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201145 (owner: 10Thiemo Mättig (WMDE)) [12:59:09] Yeah, I know... but why was it there before, are you reusing the build from last time? [12:59:25] we haven't had a new build on beta for more than a week [12:59:42] (03CR) 10JanZerebecki: "Checked: This repo is not listed on https://coveralls.io/r/wikimedia/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201145 (owner: 10Thiemo Mättig (WMDE)) [13:03:57] (03Merged) 10jenkins-bot: Drop .coveralls.yml [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201145 (owner: 10Thiemo Mättig (WMDE)) [13:12:26] (03CR) 10Aude: [C: 032] New Wikidata build - 01/04/2015 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/201180 (owner: 10Aude) [13:15:59] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 2015-04-01T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/201156 (owner: 10WikidataBuilder) [13:16:26] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 2015-03-28T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/200294 (owner: 10WikidataBuilder) [13:16:30] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 2015-03-29T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/200341 (owner: 10WikidataBuilder) [13:16:34] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 2015-03-30T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/200517 (owner: 10WikidataBuilder) [13:16:38] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 2015-03-31T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/200836 (owner: 10WikidataBuilder) [13:16:53] :( [13:17:12] * aude hopes caching isn't a problem on beta this time [13:18:09] Did they fix the bug? [13:18:35] (03PS3) 10Adrian Lang: Refactor badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200144 [13:18:37] (03PS5) 10Adrian Lang: Use EntityIdPlainFormatter in badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199296 [13:18:39] (03PS4) 10Adrian Lang: Introduce wikibase.entityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199295 [13:18:41] (03PS1) 10Adrian Lang: [WIP] Use API for formatting in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201182 (https://phabricator.wikimedia.org/T88426) [13:19:13] (03CR) 10Adrian Lang: "Manually rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199295 (owner: 10Adrian Lang) [13:19:20] (03CR) 10Adrian Lang: "Manually rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199296 (owner: 10Adrian Lang) [13:19:27] (03CR) 10Adrian Lang: "Manually rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200144 (owner: 10Adrian Lang) [13:19:55] hoo: no [13:20:11] Adrian_WMDE: Will those reduce the number of entities we need to get from store in the UI? [13:20:22] * aude was told we could do evil hacks or restart varnish on beta [13:20:30] as needed [13:20:31] Yeah, ok [13:20:47] (03Merged) 10jenkins-bot: New Wikidata build - 01/04/2015 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/201180 (owner: 10Aude) [13:21:48] [13WikibaseDataModel] 15thiemowmde created 06idCoverage (+1 new commit): 02http://git.io/jbsj [13:21:48] 13WikibaseDataModel/06idCoverage 1485ffd3a 15Thiemo Mättig: Increase test coverage for id classes [13:22:33] [13WikibaseDataModel] 15thiemowmde opened pull request #422: Increase test coverage for id classes (06master...06idCoverage) 02http://git.io/jbGs [13:23:12] (03CR) 10jenkins-bot: [V: 04-1] Introduce wikibase.entityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199295 (owner: 10Adrian Lang) [13:24:33] wmde/WikibaseDataModel/idCoverage/85ffd3a : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/56719219 [13:24:37] hoo: Nope [13:24:51] (03CR) 10jenkins-bot: [V: 04-1] Use EntityIdPlainFormatter in badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199296 (owner: 10Adrian Lang) [13:24:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use API for formatting in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201182 (https://phabricator.wikimedia.org/T88426) (owner: 10Adrian Lang) [13:24:55] (03CR) 10jenkins-bot: [V: 04-1] Refactor badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200144 (owner: 10Adrian Lang) [13:26:21] In the end, it will stop fetching entities and just format via API; so, not less API interaction, but less entity fetching [13:27:09] mh, ok [13:28:28] beta looks slightly odd [13:28:34] * aude assumes caching [13:28:54] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200543 (https://phabricator.wikimedia.org/T92431) (owner: 10Adrian Lang) [13:29:00] (03CR) 10jenkins-bot: [V: 04-1] Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200543 (https://phabricator.wikimedia.org/T92431) (owner: 10Adrian Lang) [13:29:48] (03Abandoned) 10Thiemo Mättig (WMDE): Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197121 (https://phabricator.wikimedia.org/T92431) (owner: 10Thiemo Mättig (WMDE)) [13:30:35] (03PS2) 10Adrian Lang: [WIP] Use API for formatting in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201182 (https://phabricator.wikimedia.org/T88426) [13:30:37] (03PS4) 10Adrian Lang: Refactor badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200144 [13:30:39] (03PS6) 10Adrian Lang: Use EntityIdPlainFormatter in badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199296 [13:30:41] (03PS5) 10Adrian Lang: Introduce wikibase.entityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199295 [13:33:33] * aude wonders if beta updated completely yet [13:35:38] (03PS2) 10Thiemo Mättig (WMDE): Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200543 (https://phabricator.wikimedia.org/T92431) (owner: 10Adrian Lang) [13:36:23] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200543 (https://phabricator.wikimedia.org/T92431) (owner: 10Adrian Lang) [13:45:28] (03Merged) 10jenkins-bot: Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200543 (https://phabricator.wikimedia.org/T92431) (owner: 10Adrian Lang) [13:46:00] (03PS1) 10Adrian Lang: Remove superfluous statementview::cancelEditing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201187 [13:51:12] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/jbun [13:51:12] 13WikibaseDataModel/06master 141ca5f0c 15Marius Hoch: Merge pull request #422 from wmde/idCoverage... [13:51:42] http://wikidata.beta.wmflabs.org/wiki/Q16505?debug=true [13:51:54] the suggestions are larger than normal [13:51:58] values + properties [13:52:42] * aude purged the caches [13:53:09] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think this was done on purpose. Labels and descriptions can be 250 characters long. So can aliases. Imagine a box with two or more langu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200316 (https://phabricator.wikimedia.org/T93807) (owner: 10Ricordisamoa) [13:55:03] wmde/WikibaseDataModel/master/1ca5f0c : Marius Hoch The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/56723569 [13:57:41] Move .ui-ooMenu inside .mw-body-content -> font size is good [13:57:47] ok [13:57:54] What is div.suggestions, though? [13:57:57] (03CR) 10Hoo man: [C: 04-1] "Overall improvement over the status quo, no big (design) problems. Would be nice to get my style nitpicks fixed (like not using qualified " (0340 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [13:58:06] That took me ages [13:58:08] It's right above .ui-ooMenu [13:58:50] no idea [13:59:11] hoo: Wow [13:59:21] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Rename jquery.wikibase-shared to jquery.wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201175 (owner: 10Adrian Lang) [13:59:29] aude: *shrug* div.suggestions is hard-coding the font-size [13:59:34] ugh [13:59:44] i don't see that [13:59:46] -_- [13:59:51] now i do [14:01:23] (03Merged) 10jenkins-bot: Rename jquery.wikibase-shared to jquery.wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201175 (owner: 10Adrian Lang) [14:01:42] (03CR) 10Hoo man: "Unused getters, I mean" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [14:02:53] also, the "notifications" bubble is not styled correctly [14:03:17] "Warning: You are not logged in...." [14:03:51] TypeError: wb.datamodel.Fingerprint is not a constructor FingerprintDeserializer.js:26:0 [14:03:53] on beta [14:04:04] ooo [14:04:10] not here [14:04:10] Firefox [14:04:13] That's strange [14:04:21] Didn't see that in firefox [14:04:24] Impossible, even... well RL should prevent that [14:04:27] hoo: Do you have spam filters? [14:04:45] ad block plus and several other filtering addons, yes [14:04:47] hoo: spam blockers, I mean. and stuff like that. [14:04:51] Uncaught TypeError: undefined is not a function [14:04:54] when adding a site link [14:04:59] hoo: They probably filter fingerprint.js [14:05:18] Adrian_WMDE: Mh :S [14:06:27] ah ok, ad block issue indeed (probably the privacy list or so) [14:06:39] oh, that [14:06:43] fingerprint.js is just a bad name, I guess [14:06:45] adblock does not like fingerprint [14:06:53] o_O [14:06:55] But why does that show up in the request url? [14:07:03] bits [14:07:17] mh... possible [14:10:24] anyway, the styling of the suggester is not so nice [14:10:32] but don't think a blocker to making deployment build [14:10:43] who knows, it's a quirk of beta [14:10:46] maybe [14:12:16] Oh, beta has debug mode enabled [14:12:16] that make sense [14:12:16] but... why? [14:12:16] Yeah, I had thse problems with debug mode before, but never without it [14:12:58] caching, although i poked stuff [14:13:14] only wikidata stuff [14:17:41] Is Wikidata slow? [14:18:16] sjoerddebruin: Caching in Amsterdam has been disabled due to a maintenance [14:18:25] window [14:18:33] :( [14:18:35] Why don't they announce that stoof? [14:18:49] There is something I hate most in my life and that is waiting. [14:19:32] sjoerddebruin: Why should they? If everything goes right stuff is just a little slower [14:19:51] I don't call 15 seconds a little slower. [14:20:00] Ok, that's to much [14:20:03] packet loss? [14:20:10] seems fast to me [14:20:23] yeah, it's ok for me as well [14:21:07] It's happening when I want to add a statement. The value search thing [14:21:26] but it's going with up and downs [14:24:31] (03PS1) 10Aude: New deployment build - wmf/1.25wmf24 [extensions/Wikidata] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201194 [14:31:19] hoo: did someone start the production rdf dump? with that https://phabricator.wikimedia.org/T93658#1163823 [14:31:43] (03CR) 10Aude: [C: 032] New deployment build - wmf/1.25wmf24 [extensions/Wikidata] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201194 (owner: 10Aude) [14:32:30] jzerebecki: I doubt it... Why do you think so? [14:33:32] hoo: _joe_ might have done it because by my understanding it was requested on monday in the wdq sync meeting [14:33:50] It will just run for ages [14:33:55] the deployed code is way to slow [14:34:08] or someone might have asked you [14:35:28] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf24/dfa5a2c : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/56727886 [14:35:40] Nothing running on any of the 3 snapshot hosts [14:35:54] jzerebecki: Btw, https://phabricator.wikimedia.org/T94277 [14:35:54] hoo: just seeing if it runs at all and a partial run might already be of valued. are the logfiles? [14:35:59] there [14:36:15] jzerebecki: If the person starting it collected them, yes [14:36:28] exceptions (and fatals, if on a zend host) are also collected [14:36:57] hoo: i meant could you check if the logfiles were created? [14:37:05] nice @ hhvm migration [14:37:31] they're not [14:37:51] thx [14:37:52] only json log files around on (on snapshot1003) [14:38:02] Could check the others, but that's the host of choice for this [14:40:28] hoo: i wonder if might be worth it to manually try to run the rdf dump with the group0 deployment version instead of group1. do you think that is ok to do? [14:40:57] I can have it run over testwikidata, sure [14:41:07] (03Merged) 10jenkins-bot: New deployment build - wmf/1.25wmf24 [extensions/Wikidata] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201194 (owner: 10Aude) [14:41:09] testwikidata is tiny [14:41:22] also over the real wikidata by doing evil things to mw1017 if needed (on Thursday) [14:41:35] hehe [14:41:52] no i mean use code for testwikidata but the db wikidata [14:42:01] jzerebecki: Yep, that's what I meant [14:42:21] should be doable if people can't wait until tuesday [14:42:21] wait for the new code to go live for testwikidata, manipulate mw1017 to thing Wikidata is group0, run the script, profit [14:42:30] * think, even [14:43:27] hoo: isn't just /srv/mediawiki/multiversion/MWScript.php what decides which code to call for the dump so we don't need to manipulate mw1017 ? [14:44:04] jzerebecki: Oh well, guess that would also work [14:52:34] DanielK_WMDE_: In the new dump naming scheme we have wikidatawiki/entities/20150401/full.json ? [14:52:44] (I only care baout the json dump for now) [14:54:19] (03CR) 10Ricordisamoa: "Do you suggest to wrap only descriptions leaving labels and aliases as-is?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200316 (https://phabricator.wikimedia.org/T93807) (owner: 10Ricordisamoa) [14:57:47] Lydia_WMDE: ^ do you know? [14:58:20] i think so [15:01:07] * aude annoyed that i can't reproduce the css issues on beta [15:01:14] not even when using the build [15:06:30] [13WikibaseDataModel] 15thiemowmde created 06snakTests (+1 new commit): 02http://git.io/jNUP [15:06:30] 13WikibaseDataModel/06snakTests 1447d0f2d 15Thiemo Mättig: Drop abstract SnakObjectTest base class [15:11:14] [13WikibaseDataModel] 15thiemowmde opened pull request #423: Drop abstract SnakObjectTest base class (06master...06snakTests) 02http://git.io/jNkj [15:15:41] (03CR) 10Thiemo Mättig (WMDE): "In my opinion, labels and descriptions should not be different. I suggest to keep the truncation with an ellipsis for aliases." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200316 (https://phabricator.wikimedia.org/T93807) (owner: 10Ricordisamoa) [15:19:11] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "The only difference to the base class is that this here returns something, but this return value is never used." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201187 (owner: 10Adrian Lang) [15:23:24] (03PS3) 10Thiemo Mättig (WMDE): Suppress redundant newlines in SearchTextGenerators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188833 [15:23:26] (03PS3) 10Thiemo Mättig (WMDE): Rename EntitySearchTextGenerator to FingerprintSearchTextGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188829 [15:24:36] (03Merged) 10jenkins-bot: Remove superfluous statementview::cancelEditing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201187 (owner: 10Adrian Lang) [15:28:04] (03PS2) 10Thiemo Mättig (WMDE): Introduce FormatterLabelLookupFactory::OPT_ constants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197011 [15:28:31] (03PS3) 10Thiemo Mättig (WMDE): Introduce FormatterLabelLookupFactory::OPT_ constants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197011 [15:31:33] (03CR) 10Thiemo Mättig (WMDE): Use mocks in HtmlTimeFormatterTest (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197115 (owner: 10Thiemo Mättig (WMDE)) [15:31:47] (03PS2) 10Thiemo Mättig (WMDE): Use mocks in HtmlTimeFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197115 [16:32:55] hmmm http://wikidata.beta.wmflabs.org/wiki/Special:Preferences is unstyled for me [16:34:44] jquery.ui.core styles appear to be loaded after gadgets and other ext* stuff [16:43:44] good morning [16:53:27] *waves at dennyvrandecic* [16:53:48] jeeh freebase is dead [16:54:25] we prefer the term "writability challenged" [16:54:57] .... [16:54:57] (you know, like most websites ;) [16:59:46] * aude playing pacman on google maps :) [16:59:47] aude: dont do itt! It'll absorb hours of your time :/ [16:59:47] hah [16:59:47] addshore: aude: ohh, so agreed! it is more fun on a huge screen, btw [17:01:56] lol [17:02:14] lol? [17:02:27] [18:59:18] we prefer the term "writability challenged" [17:03:21] Lydia is always following it seems... even when she's not [17:03:30] :P [17:03:37] :P [17:03:38] yes [17:04:18] How did you even see that... according to your timeout you weren't even connected at that time :D [17:04:39] hoo: i'd like all the info in the path repeated in the actual file name, since that is preserved after download. [17:05:02] I'd also put the date first in the hierarchy, *if* we can make all the dumps in there consistent. [17:05:12] otherwise, put it last. [17:05:19] DanielK_WMDE_: Ok, good that you mention that *now* (am still working on it) [17:05:45] thought i wrote that on phab? maybe not... [17:07:41] netsplit? [17:07:51] DanielK_WMDE_: Could be that I missed that [17:09:01] So that would eg. make 20150401-full.json for a dump created today [17:10:27] DanielK_WMDE_: Lydia_WMDE: ^ Can you confirm that [17:10:45] k [17:15:26] hoo: i'd make that wikidata-20150501-full.json [17:15:34] not sure what "full" means here. all entities? [17:15:44] yeah [17:15:49] we have several things regarding dumps that we call "full". [17:15:53] "all" may be better [17:15:58] Ok [17:16:04] and also repeat the wiki in the file name? [17:16:24] hoo: yea... imaging you are downloading dumps from several sources. [17:16:28] *imagine [17:17:03] ok, so wikidata-20150401-full.json [17:17:28] wikidata-20150401-all.json [17:17:29] doh [18:07:17] DanielK_WMDE_: hey, do you know what is the status of the date storage thing? Is it decided it'll be stored in gregorian? [18:14:14] (03CR) 10Smalyshev: "ok, I can do the switch. The problem is the tests - if you change the switch, you'll have to change the tests. Also, if dates are Gregoria" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [18:40:42] Interesting, it would appear a bit of London is currently on fire.... underground..... electrical fire.. [19:12:18] SMalyshev: I'd also like to know, for mapping the Freebase data for upload [19:16:17] dennyvrandecic: I was assuming the discussion is going to converge somewhere but looks like it's not moving so maybe I should send a ping on the email [19:18:33] thx. I'll omit dates for now. [19:18:37] ok, i will not omit them for movie releases. that would be overtly cautious :) [19:20:34] SMalyshev, dennyvrandecic: we are investigating, but it takes time since it has to be doen manually in many cases, and the fact that half the team is off over the easter hilidays doesn't help. [19:21:11] DanielK_WMDE_: so do we have any time point where we would expect to have some decision on this? [19:21:12] I hope we will at least have decent data by next week. [19:21:48] ok, so let's talk next week [19:23:08] SMalyshev: i'm online for a couple of hours for the archcom session. [19:23:43] won't do much coding tonight, but if there's anything urgent to discuss or review, i can do that in about two hours [19:23:55] DanielK_WMDE_: cool, what do you think of this one: https://gerrit.wikimedia.org/r/#/c/200274/ [19:24:31] DanielK_WMDE_: also, would love more feedback on this one: https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format/Proposal [19:25:48] (03CR) 10Daniel Kinzler: "The cleanest way to have this switchable is to implement each behavior in a separate class (julian support could be in a subclass ob the g" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [19:27:47] SMalyshev: i commented on the "remove version" on several days ago [19:28:12] but once more, it's not really a coding decision, but a strategic decision, really. [19:28:25] DanielK_WMDE_: ah, sorry, missed it (gerrit is spectacularly unhelpful in showing comment status :( [19:28:56] yes, thaqt's true. i often ask people to just always give a -1 just to get my attention. [19:29:01] would that be ok for you? [19:29:17] DanielK_WMDE_: yes esp. if you think the patch needs change [19:29:50] in this case, the patch is fine, but there's a product level strategic decision to be made [19:29:53] DanielK_WMDE_: but I think it's time we start arriving at some decision about the versions, etc. Should we make a mail thread on it? [19:30:13] DanielK_WMDE_: I agree, but not sure how to initiate making one [19:30:15] i prefer phabricator over mails [19:30:25] easier to track status [19:31:15] SMalyshev: file a phab ticket against the wikidata project. poke lydia about it avery now and then. that should get the decision made, or at least organised and scheduled. [19:31:38] SMalyshev: regarding the prefixes... i don't care that much. but on a related note, i think that data types should be URIs. They are part of our vocabulary. [19:33:00] DanielK_WMDE_: which data types? Like "string"? [19:33:10] for properties? [19:33:24] like "string" and "url", yes [19:33:45] we can make them wikibase:String and wikibase:Url instead [19:33:55] SMalyshev: hm, for the version in the uri, there already is a ticket, right? but it still "looks" like a technical discussion. Maybe the title should be "Decide whether we want a version in our schema uri" or some such [19:34:06] SMalyshev: yes, that's what i mean [19:34:26] DanielK_WMDE_: yeah that ticket is too technical and generic. I'll create a new one [19:37:14] great [20:11:46] (03PS1) 10Sumit: README Changed [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/201270 (https://phabricator.wikimedia.org/T93127) [20:13:53] sjoerddebruin: http://vocab.getty.edu/tgn/7007048 is ook best leuk [20:27:23] multichill: voor wat? [20:27:38] Zoals Geonames [20:27:44] Authority control op locaties [20:27:47] hm [20:27:50] Locatie namen om precies te zijn [20:29:03] sjoerddebruin: Dit wordt weer veel door musea gebruikt dus als wij ook links hebben is het weer gemakkelijker data te importeren en te koppelen [20:38:05] multichill: Staat er al een verzoek open? :) [20:38:22] Voor importeren of mix'n'match? [20:40:20] Property... [20:41:18] Die is a aangemaakt [20:41:43] ah, ok.. [20:41:47] beiden dan... [20:41:59] https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P1667 <-erg zielig nog [20:42:52] Dat vind ik altijd zo jammer, dat mensen zulke dingen aanvragen maar niet er massaal mee aan de slag gaan [20:43:06] Zo zijn er handenvol properties die maar 20 keer gebruikt zijn... [20:45:55] Ja, dat is wel zonde ja! [20:46:15] Ik vraag Magnus wel ff [20:57:48] sjoerddebruin: https://www.wikidata.org/wiki/Property:P1669 <- zucht [20:59:01] Guala, IRC is still alived [20:59:23] Algun español? English talk somebody? [21:00:29] SrGeneroso: Just ask and you might get an answer ;-) [21:02:00] Na, just chillin. Fishing somebody with some chat time to spare [21:02:38] What time is where you are? [21:02:53] DC [21:03:09] 23:00 here, Madrid Spain [21:04:09] well, a question, just arrived to wikidata. Who is going here the most?, Coders, editors, noobs? [21:07:25] sjoerddebruin: https://www.wikidata.org/wiki/User_talk:Magnus_Manske#Filling_the_Getty nn [21:08:50] SrGeneroso: all of them and more [21:09:26] yeah [21:09:29] lazowik's [21:09:31] benestar's [21:09:44] damn, *lazowiks, benestars [21:09:54] nyanz [21:10:14] Googlers, hehe [21:10:44] a lot of WMDEs [21:11:16] oh, we shouldn't forget about bots [21:11:51] SrGeneroso: un poco español [21:11:52] poco poco [21:12:29] poquísimo [21:12:31] Hello everybody! [21:13:14] Does anybody know why mw.wikibase.getEntityObject( ID ) doesn't work? [21:13:35] Welcome, chh at ip-89-177-72-4.net.upcbroadband.cz [21:13:51] angus: I have no idea [21:14:17] you should ask JeroenDeDauw [21:14:30] he's the frontend guru here [21:15:54] ok thanks [21:15:54] JeroenDeDauw: Do you know why mw.wikibase.getEntityObject( ID ) doesn't work? [21:17:59] well, but if anybody else also knows, please share ;) [21:18:57] it's a big obstacle to the generalized use of wikidata in wikis [21:33:38] ups, sorry, away off this tab for a while [21:34:04] It's nices to see IRC working as I remember 10 years ago [21:34:30] I was researching about wiki for a documental porpouse and end here, maybe nostalgia [21:35:38] So I discover data, what do you guys can tell me about it? [21:37:10] SrGeneroso: just go ahead and ask your question. if you want to read up on wikidata, https://www.wikidata.org/wiki/Wikidata:Introduction is a good site [21:41:47] aude: Is this new: When I click edit for terms the cancel link is overlaying the Wikipedia header slightly [21:42:16] Ok... mh, maybe I just didn't notice this before [21:53:44] hoo: what browser? [21:53:58] Firefox [21:54:09] hm [21:54:42] Works with webkit [21:54:55] Now it also works in Firefox [21:54:58] weird [21:55:21] can't reproduce [22:01:13] aude: It's fine for me now as well, so nevermind [22:01:22] ok [22:02:00] * aude waits for scap etc to finish [22:02:18] see if test.wikidata has the same css issues as beta [22:08:02] 10Wikidata: Uncaught Error: Unknown dependency: mw.ext.dataValues - https://phabricator.wikimedia.org/T94674#1172286 (10aude) 5Open>3Resolved [22:12:12] SMalyshev: Do you mind me laying hands on your puppet change for rdf dumps? [22:12:24] hoo: sure, feel free to [22:12:41] Awesome :) [22:12:43] I just put it there to give it a start [22:13:15] I'm confident we can keep stuff in place by the time the branch is deployed [22:13:47] If you want, I can also already start a test run (outside of the dump infrastructure) with the real wikidata today/ tomorrow [22:17:56] hoo: that would be great [22:18:26] SMalyshev: Would it be ok to only create on shard or would that not be very useful? [22:18:30] * one [22:19:31] I don't know what's fast but still useful to you... 1/8? 1/6? ... [22:19:32] one shard would not be too useful for queries I'm afraid as ti won't have all data... maybe just as testing it runs ok but even then it still could fail on data from other shards [22:19:41] True [22:19:53] I don't know how fast the code is right now [22:20:06] do you have an estimate at hands (compared to the json dumps) [22:20:08] (03CR) 10Jdlrobson: [C: 032] README Changed [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/201270 (https://phabricator.wikimedia.org/T93127) (owner: 10Sumit) [22:21:33] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1172347 (10Jdlrobson) [22:21:35] 10Wikidata, 10MobileFrontend-Feature-requests, 5Patch-For-Review: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1172345 (10Jdlrobson) 5Open>3Resolved Looks good to me. Thanks a bunch! :) [22:33:50] 10Wikidata, 10MobileFrontend-Feature-requests, 5Patch-For-Review: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1130019 (10Jdlrobson) [22:35:10] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#831845 (10Jdlrobson) I've now setup https://phabricator.wikimedia.org/project/profile/1158/ so we can start s... [22:54:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Styling in the entity suggester has large fonts and other things not quite right on beta - https://phabricator.wikimedia.org/T94699#1172429 (10aude) [22:56:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Styling in the entity suggester has large fonts and other things not quite right on beta - https://phabricator.wikimedia.org/T94699#1170396 (10aude) test.wikidata has the new branch now and appears unaffected by this issue. in some ways it's even more ann... [23:23:21] SMalyshev: Ok, calling it a day... I'll probably take the dump script for a walk around Wikidata tomorrow to see if there are any critical bugs that would need to be fixed before this can go live [23:23:21] hoo: cool, thanks