[07:04:15] <sjoerddebruin>	 multichill: Good morning. Fixed the moviemeter movies...
[08:02:16] <benestar>	 !nyanreview https://github.com/wmde/WikibaseDataModelServices/pull/2 | addshore 
[08:02:16] <wm-bot>	 addshore: ~=[,,_,,]:3 .oO(review!!!) https://github.com/wmde/WikibaseDataModelServices/pull/2
[08:02:39] <benestar>	 addshore: http://korrekt.org/page/Note:Wikidata_on_the_Moon
[08:04:07] <sjoerddebruin>	 benestar: Is his site running a MediaWiki version from 2010!?!
[08:04:23] <benestar>	 ask Markus ;)
[08:04:38] <benestar>	 http://korrekt.org/page/Special:Version <- obviously
[08:04:45] <sjoerddebruin>	 Doesn't sound safe to me. :)
[08:37:48] <JeroenDeDauw>	 Oh, SMW 1.5.6
[08:37:59] <JeroenDeDauw>	 I know some XSS this thing has ;p
[08:38:30] <sjoerddebruin>	 !evil JeroenDeDauw 
[08:38:30] <wm-bot>	 JeroenDeDauw is eeeeeevil >:(
[08:39:33] <JeroenDeDauw>	 sjoerddebruin: well thank you good sir
[08:40:11] <JeroenDeDauw>	 addshore: benestar: why the 'Statement' subns for the guid gen stuff?
[08:40:40] <JeroenDeDauw>	 I'm not comlaining about it, just wondering what the reasoning behind it is
[08:41:10] <JeroenDeDauw>	 Think it's kinda hard to find the best organization upfront, which is not a big deal since we can still change it before release
[08:41:52] <benestar>	 JeroenDeDauw: because they are Statement guids?
[08:42:10] <benestar>	 agree that we should think about it once we have more stuff in there
[08:42:49] <JeroenDeDauw>	 benestar: well, then you could have Services\Statement\Guid\ as ns as well, since they are GUIDs... or Services\Statement\Guid\Generators\ ;p
[08:43:00] <benestar>	 heh :O
[08:43:17] <benestar>	 we could also do Services\Guid, doesn't really matter to me
[08:43:24] <benestar>	 let's see how grouping works best
[08:43:31] <JeroenDeDauw>	 That is kinda more odd :)
[09:42:16] <DanielK_WMDE>	 Lydia_WMDE, Tobi_WMDE_SW_NA: i'd like to join the daily via hangout in a minute
[09:49:33] <DanielK_WMDE>	 frimelle, Thiemo_WMDE: ping me for the daily
[09:52:07] <frimelle>	 DanielK_WMDE sorry, we saw it too late! :( 
[09:53:00] <DanielK_WMDE>	 hrmph. well then, you'll have to do without my dazzeling insights ;)
[09:54:54] <benestar>	 DanielK_WMDE: setting up hangout would've taken longer than the whole daily :P
[09:57:38] <DanielK_WMDE>	 benestar: but if you had, the daily would have taken longer :)
[09:57:57] <DanielK_WMDE>	 actually, joining the hangout should take about 20 sec. ok, 1 minute with the external mic
[10:04:29] <addshore>	 DanielK_WMDE: you may be interested in https://gerrit.wikimedia.org/r/#/c/221592/2
[10:21:15] <DanielK_WMDE>	 addshore: nice!
[11:44:49] <JeroenDeDauw>	 benestar: addshore Thiemo_WMDE https://phabricator.wikimedia.org/T104187 < any disagreement with that list?
[12:05:25] <Thiemo_WMDE>	 JeroenDeDauw: Responded.
[12:45:07] <nikki>	 is https://phabricator.wikimedia.org/T102148 supposed to be fixed now?
[12:46:35] <nikki>	 'cause I just tried to add an english alias to a property but can't because it complains about the japanese label
[14:09:11] <sjoerddebruin>	 aude: More reports that https://phabricator.wikimedia.org/T98471 is still happening
[15:22:33] <addshore>	 JeroenDeDauw: there is a pull req up in serialization!
[15:22:53] <motdd>	 hi all
[15:26:42] <JeroenDeDauw>	 addshore: https://phabricator.wikimedia.org/T104187
[15:26:52] <JeroenDeDauw>	 addshore: will haz a look
[15:40:05] <JeroenDeDauw>	 benestar: you win one free internets for actually pointing out the package public issue in that PR
[15:40:33] <benestar>	 JeroenDeDauw: \o/
[16:35:34] <nikki>	 sjoerddebruin: that hasn't been deployed yet has it? when I asked last week lydia originally said thursday but then said it's actually the thursday after
[16:35:46] <sjoerddebruin>	 Hm
[16:35:56] <nikki>	 (so the one coming up)
[16:36:17] <nikki>	 it's still annoying as hell either way :/
[17:01:05] <multichill>	 sjoerddebruin: I see the first constraint violation reports for movie meter
[17:11:52] <sjoerddebruin>	 multichill: Yeah, I've fixed the movies.
[17:21:45] <nikki>	 what should I do with https://www.wikidata.org/wiki/Q17984051? it's basically https://www.wikidata.org/wiki/Q16503 except they can't be merged... if I leave it like that, it's weird that the equivalent pages in the same language aren't on the same item, if I move all the same language ones to the same item, it'll break the interwiki links
[17:35:30] <Lydia_WMDE>	 someone might want to keep an eye on https://www.wikidata.org/wiki/Q185696 as well
[17:35:47] <Lydia_WMDE>	 *someone else
[17:36:21] <Lydia_WMDE>	 eh sorry
[17:36:24] <Lydia_WMDE>	 https://www.wikidata.org/wiki/Q1050649 is the one i meant
[17:43:44] * nikki will watch out for it
[17:45:56] <benestar>	 hey addshore :)
[17:51:49] <benestar>	 jzerebecki: https://gerrit.wikimedia.org/r/#/c/221653/
[17:54:23] <addshore>	 hi benestar 
[17:55:19] <benestar>	 !merge 221653 | addshore 
[17:55:19] <wm-bot>	 addshore: merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/221653/
[17:57:27] <addshore>	 gimmie 2 secs
[18:04:54] <addshore>	 benestar: I presume view/resources/wikibase/wikibase.css goes nowhere near mobile then?
[18:05:38] <benestar>	 addshore: should've tested that :P
[18:05:48] <benestar>	 but doesn't because it doesn't have target => mobile
[18:58:21] <Nemo_bis>	 Andrew Mabbett likes https://tools.wmflabs.org/bambots/PageTools.php?wiki=itwiki&page=Cesare+Beccaria but I'm not sure what's the point
[19:04:33] <sjoerddebruin>	 Design from the past.
[19:04:48] <sjoerddebruin>	 ORCID-pushing: check
[19:16:48] <addshore>	 benestar|cloud: probably going to head home in a bit
[20:00:22] <Amir1>	 multichill: hey around?
[20:00:33] <Amir1>	 https://www.wikidata.org/wiki/Special:Contributions/Dexbot
[20:00:44] <multichill>	 Amir1: Yup, just cleaning out some last paintings before going to bed
[20:00:54] <Amir1>	 :)
[20:01:04] <Amir1>	 It's awesome
[20:01:13] <Amir1>	 what you do is awesome
[20:01:44] <multichill>	 Nice, the lists :-)
[20:04:24] <multichill>	 Amir1: I just broke the 80.000 paintings milstone
[20:05:35] <Amir1>	 I will start helping soon
[20:31:56] <addshore>	 benestar|cloud: back ;P
[20:43:01] <addshore>	 benestar|cloud: are you going to poke it or shall i?
[21:05:30] <benestar>	 addshore: hey, online now :)
[21:05:35] <addshore>	 ohia ;p
[21:05:42] <benestar>	 how you prefer ;)
[21:06:45] <addshore>	 benestar: I'll let you poke it
[21:06:54] <addshore>	 also good spot with the mehtod I added @deprecated to :P
[21:07:58] <benestar>	 addshore: shall I just create a pull request on top of that branch and you merge it?
[21:08:20] <addshore>	 yeh you could do!, or just push straight to the branch
[21:08:36] <addshore>	 the first I guess would be technically nicer, as then I would merge your stuff and you would merge mine nd yours
[21:08:44] <benestar>	 (y)
[21:09:35] * aude waves :)
[21:11:11] * addshore waves at aude
[21:11:24] <aude>	 addshore: how's the office?
[21:11:30] <addshore>	 officey :D
[21:11:36] <aude>	 :)
[21:11:41] <aude>	 are we still on 0.5?
[21:11:45] <aude>	 ;)
[21:13:07] <benestar>	 aude: for sure :P
[21:13:13] * benestar also waves at aude 
[21:13:17] <aude>	 heh
[21:14:21] <benestar>	 addshore: you forgot @licence tags :O
[21:14:31] <addshore>	 bah, the repo has a licence right?
[21:14:33] <benestar>	 not releasing your work under GNU GPL :P
[21:14:49] * benestar added them
[21:15:07] <addshore>	 :p
[21:16:42] <benestar>	 we should have some static Assert::stuff class
[21:16:54] <benestar>	 just weird to copy those assertion methods over and over again
[21:16:59] <aude>	 benestar: we do
[21:17:06] <aude>	 daniel's new library
[21:17:15] <benestar>	 aude: but not in DataModelSerialization :S
[21:17:35] <benestar>	 is it a standalone lib?
[21:17:37] <aude>	 https://github.com/wmde/assert
[21:17:40] <aude>	 afaik
[21:17:45] <aude>	 it is standalone
[21:17:53] <Reedy>	 JeroenDeDauw: PHP 5.3 4 lyf
[21:17:58] <benestar>	 MIT o.O
[21:18:19] <Reedy>	 reedy@terbium:~$ php -v
[21:18:19] <Reedy>	 PHP 5.3.10-1ubuntu3.18+wmf1 with Suhosin-Patch (cli) (built: Apr 20 2015 20:25:25)
[21:18:32] <aude>	 Reedy: and imagescalers
[21:18:37] <aude>	 and other random stuff afaik
[21:18:39] <Reedy>	 ja
[21:18:49] <Reedy>	 I was just doing it generally that we are still using it
[21:18:50] <Reedy>	 :)
[21:18:55] <aude>	 yep
[21:19:04] <aude>	 unfortunately
[21:20:11] <benestar>	 aude: I have no access to edit it :S
[21:20:43] <aude>	 me neither apparently
[21:20:53] * aude rage to tob
[21:20:54] <aude>	 i
[21:21:13] <addshore>	 Reedy: we love 5.3
[21:21:30] <addshore>	 benestar: to edit what?
[21:21:40] * Reedy edits addshores degree
[21:21:48] <benestar>	 addshor: no push access to that repo (wmde/Assert)
[21:21:48] <benestar>	 *e
[21:21:56] <aude>	 https://github.com/wmde/Assert/blob/master/README.md
[21:21:59] <benestar>	 we should definitely use that lib
[21:22:02] <aude>	 says "fork and edit"
[21:22:05] <addshore>	 do I have any?
[21:22:24] <addshore>	 I have access apparently
[21:22:32] * addshore edits Reedy's right arm
[21:28:18] <benestar>	 addshore: "The alias group serialization should only contain 1 element" <- wtf??
[21:28:20] <benestar>	 are you sure that is correct?
[21:29:24] <benestar>	 just wtf?
[21:29:37] <benestar>	 can't we just do that language mapping inside of an AliasGroupListView?
[21:29:45] <addshore>	 benestar: yes
[21:30:02] <benestar>	 and let the AliasGroupViewDeserializer only deal with the array inside?
[21:30:21] <addshore>	 it is currently awkwardly array( 'en' => array( array( 'lang' => 'en', 'value' => 'Foo' ) ) ) etc
[21:30:22] <benestar>	 $fingerprint->getAliasGroups()->setGroup(
[21:30:22] <benestar>	 				$this->aliasGroupDeserializer->deserialize(
[21:30:22] <benestar>	 					array( $requestedLanguage => $aliasesPerLanguageSerialization )
[21:30:22] <benestar>	 				)
[21:30:22] <benestar>	 			);
[21:30:33] * benestar doesn't think that's right
[21:30:57] <addshore>	 Yeh, this is why I was going to add the AliasGroupList stuff too
[21:31:04] <addshore>	 kill fingerprint!
[21:31:07] <benestar>	 you just confused some levels of abstraction there I guess :P
[21:31:14] * benestar gives addshore a trout :P
[21:31:59] <addshore>	 #eats trout for dinner
[21:32:10] <benestar>	 :D
[21:32:27] <benestar>	 addshore: so are there some places where you actually get array( 'en' => array( array( 'lang' => 'en', 'value' => 'Foo' ) ) )?
[21:32:47] * aude wants somewhat less abstraction in serializers
[21:32:53] <addshore>	 benestar: I dont follow?
[21:33:18] <aude>	 or more deferred serialization
[21:33:22] <aude>	 and/or
[21:33:24] <benestar>	 addshore: I think we should just use an AliasGroupListDeserializer
[21:33:27] <addshore>	 where as TermList objects dont specifically have language, only the terms do, the aliasgroups do have a language
[21:33:32] <benestar>	 aude: how do you mean?
[21:33:45] <benestar>	 addshore: yes, but AliasGroupLists dont
[21:33:53] <benestar>	 AliasGroups are on the same level as Terms
[21:34:01] <addshore>	 benestar: gimmie a sec, I'll look at the code im trying to replace again ;P
[21:34:02] <benestar>	 and AliasGroupLists on the same level as TermLists
[21:34:10] <benestar>	 should I do it?
[21:34:15] <benestar>	 just working on it...
[21:34:15] <aude>	 benestar: generally that's how we got in trouble with the preformance problems, causing us to superprotect Q183
[21:34:21] <aude>	 performance*
[21:34:35] <addshore>	 aude: whats the bigest performance hit right now?
[21:35:01] <aude>	 addshore: i'm not sure what exactly (we should analyze more)
[21:35:10] <addshore>	 +1 for that
[21:35:13] <benestar>	 maybe we should be able to tell ItemDeserializer what exactly to deserialize
[21:35:22] <aude>	 we fixed a bunch of misc. stuff back in ~sept/oct
[21:35:42] <aude>	 but never really fixed the issue, except got hhvm which bought us more room
[21:35:47] <benestar>	 or even better, don't deserialize a whole item if only the label in one language is needed
[21:35:58] <benestar>	 -> use TermLookups instead
[21:36:02] * aude not looked at what you are doing with terms + serializers
[21:36:13] <aude>	 benestar: true
[21:36:15] <benestar>	 aude: it's nothing special, just moving some code
[21:36:31] <benestar>	 so there won't be much change in performance
[21:36:45] * aude cautions too many objects
[21:37:00] <aude>	 if we are replacing objects, then cool :)
[21:37:17] <addshore>	 benestar: yeh that should be fine
[21:37:20] <benestar>	 aude: yes, actually also removing objects ;)
[21:37:24] <aude>	 ok :)
[21:37:39] <benestar>	 because Fingerprint will die and we will have direct interfaces instead
[21:37:44] <benestar>	 ie. one abstraction less
[21:37:54] <benestar>	 and we want to start doing this in Serializers this time
[21:37:58] <nikki>	 aude: your last comment on https://phabricator.wikimedia.org/T102148 says it was deployed to wikidata, does that mean it shouldn't be happening now?
[21:38:19] <benestar>	 nikki: depends if the caches are up to date
[21:39:05] <addshore>	 benestar: ill take a look at your PR in the morning :)
[21:39:31] <nikki>	 earlier I was trying to add "parts" as an english alias to https://www.wikidata.org/wiki/Property:P527 and it said "Property P1012 already has label "以下を含む" associated with language code ja."
[21:39:47] <benestar>	 addshore: sure, but don't change your PR anymore :P
[21:39:52] <benestar>	 because now I rely on it
[21:40:13] <addshore>	 mmwhahahahahaaa
[21:40:22] <benestar>	 nikki: ignore my comment, I misread the bug message
[21:40:42] <benestar>	 nikki: it means that now all conflicts are detected correctly
[21:40:54] <benestar>	 which doesn't mean all conflicts are resolved yet :S
[21:41:00] <nikki>	 ah
[21:41:10] <aude>	 nikki: shouldn't happen
[21:41:57] <benestar>	 slow hotel internet is slow
[21:42:31] <aude>	 nikki: errr, i think the constraint is enforced now
[21:42:41] <benestar>	 nikki: I've added an underscore to the ja label and now it works
[21:42:59] <benestar>	 however, I don't think this is the way we should fix constraint violations, just wanted to make the property editable again
[21:43:34] <nikki>	 thanks
[21:43:51] <aude>	 i think for now, the violations need to be fixed per benestar
[21:43:54] <nikki>	 I successfully added the alias I wanted, so I'm happy at least :P
[21:43:56] <aude>	 but also agree, this is not ideal
[21:44:10] * aude hopes there are not too many violations
[21:44:18] * benestar fears there might be a few
[21:44:41] <aude>	 then we need a list of them and fix
[21:44:50] * aude doesn't have better idea
[21:44:55] <benestar>	 aude: create a SPARQL query :D
[21:44:57] <hoo>	 aude: Did you create a branch?
[21:45:00] <aude>	 hoo: no
[21:45:07] * aude is on holidays 
[21:45:13] <hoo>	 I went on a rage earlier today and redid parts of my house wiring
[21:45:21] <hoo>	 I have cat 5 in my room now
[21:45:23] <benestar>	 https://www.mediawiki.org/wiki/Wikibase/Indexing/SPARQL_Query_Examples#Aliases_of_properties_which_are_used_more_than_once
[21:45:24] <hoo>	 took me hours
[21:45:30] <aude>	 hoo: a cat :)
[21:45:43] <hoo>	 :D Well, I still lack *that* kind of cat
[21:45:47] <aude>	 lol
[21:46:05] <benestar>	 aude: is the alias uniqueness also deployed already?
[21:46:14] <aude>	 benestar: don't think so
[21:46:32] <benestar>	 because then we will have quite many issues
[21:46:42] <aude>	 yeah
[21:46:55] <benestar>	 159 to be precisely
[21:47:03] <aude>	 would be nice if the changeop or whatever only didn't allow new violations
[21:47:11] <aude>	 but not block editing otherwise
[21:47:23] <aude>	 like we do for statements, generally
[21:47:51] <benestar>	 aude: maybe, but I don't think we should put too much effort into that. It's only a temp issue
[21:47:58] <aude>	 was about to say that
[21:48:16] <aude>	 it's probably easier to make a list and fix them, then spend developer time on this
[21:48:36] * benestar checks label conflicst
[21:48:47] <jdlrobson>	 anyone around?
[21:48:55] <benestar>	 jdlrobson: yep
[21:48:58] <jdlrobson>	 my vagrant instance just exploded with Call to undefined method Wikibase\DataModel\Statement\StatementList::getWithPropertyId() and I have no idea why :(
[21:49:03] <benestar>	 what's up?
[21:49:29] <hoo>	 jzerebecki: ping
[21:49:40] <jdlrobson>	 I have a vagrant instance with Wikidata and PageBanner extension installed and I can't get the page banners to work anymore :-/ keen to review some of codezees code
[21:49:48] <benestar>	 argh https://www.wikidata.org/wiki/Property:P1926 still appears in blazegraph :S
[21:50:03] <benestar>	 jdlrobson 
[21:50:15] <benestar>	 we had a breaking change renaming getWithPropertyId to getByPropertyId
[21:50:29] <benestar>	 perhaps PageBAnners needs to adopt that change
[21:50:54] <jdlrobson>	 benestar: no deprecation notices?!
[21:51:00] <benestar>	 stupid me insisted on consistent method naming :P
[21:51:07] <aude>	 jdlrobson: composer update?
[21:51:22] <benestar>	 jdlrobson: release notes... but no deprecation as it is a simple rename
[21:51:53] <aude>	 benestar: ykes
[21:51:55] <aude>	 yikes*
[21:51:56] <jdlrobson>	 benestar: yup that's the issue
[21:52:08] * aude hopes other extensions are not using the old method
[21:52:10] <jdlrobson>	 you should use wfDeprecate for this sort of thing i just wasted 30 mins :)
[21:52:16] <benestar>	 the funny thing is, I trapped myself with that in one of my tools :P
[21:52:54] <benestar>	 jdlrobson: yeah, looking on it now it is a really stupid thing :S
[21:53:13] <jdlrobson>	 mm still have this error
[21:53:18] <jdlrobson>	 must be something else doing it too..
[21:53:49] <benestar>	 jdlrobson: be happy, there will be some more breaking changes in the DataModel perhaps :P
[21:54:07] <jdlrobson>	 please do use wfDeprecate in future though
[21:54:12] <jdlrobson>	 and give time for devs to update
[21:54:17] <jdlrobson>	 which patch introduced the issue?
[21:54:25] <benestar>	 jdlrobson: we can't because we don't require mediawiki to be installed
[21:54:41] <benestar>	 however, we will add @deprecated tags and put it into the release notes
[21:55:00] <benestar>	 jdlrobson: https://github.com/wmde/WikibaseDataModel/blob/master/RELEASE-NOTES.md
[21:55:10] <jdlrobson>	 isn't wfDeprecate a composer module now (cc legoktm )
[21:56:18] <benestar>	 jdlrobson: doesn't your IDE support @deprecated tags?
[21:56:56] <jdlrobson>	 benestar: i'm not developing this so i'm not using an IDE for it
[21:57:06] <jdlrobson>	 i don't use IDE's in general
[21:57:43] <benestar>	 not sure about the wfDeprecate thing but in general we have to be more careful with announcing breaking changes in future
[21:59:07] <benestar>	 can I haz generics plox?
[21:59:16] <Reedy>	 generic viagra?
[22:07:37] <legoktm>	 jdlrobson: it's not
[22:08:46] <legoktm>	 benestar: trigger_error('FooBar is deprecated', E_USER_DEPRECATED)
[22:10:06] <benestar>	 legoktm: thx, though not sure if that is !nyan approved /ping JeroenDeDauw 
[22:11:18] <legoktm>	 benestar: if you have $wgDevelopmentWarnings = true, that's what wfDeprecated() does underneath
[22:19:52] <benestar>	 addshore: will continue fixing your PR tomorrow :)
[22:20:10] <benestar>	 you did some great stuff and stopped kind of in the middle of everything :P
[22:20:33] <benestar>	 gn8
[22:31:07] <addshore>	 :D
[22:48:50] <Reedy>	 JeroenDeDauw: https://phabricator.wikimedia.org/T86081