[00:21:47] !nyan | JeroenDeDauw [00:21:47] JeroenDeDauw: ~=[,,_,,]:3 [08:35:19] Guten Tag! [08:36:05] I was giving a quick demo of Wikidata, I wondered how we can get all items that are subclass of a property. In this case https://www.wikidata.org/wiki/Q19833835 "Wikidata property for authority control for substances" [08:40:38] benestar: :P [08:40:50] had any more thoughts about the serialization issues? [08:48:47] addshore: no great idea yet, sorry :( [08:48:54] but merged some of your stuff ;) [08:49:06] did you :o * looks* [08:51:22] so you did! [08:51:42] so benestar how about we fall backt o the idea of actually injecting / adding stuff to serialization instead of [08:52:06] actually I merged one commit and the other is still in the queue [08:52:50] so how about the serializer factory also takes a collection of injectors (or something) and these injectors act on specific object and add some serialization ;P [08:53:05] maybe I should make a draft and see what people think... [08:56:02] addshore: hmm, not sure if we want to make the serializers that complicated... [08:56:16] however, we will perhaps need that if we want to do serialization in a clean way [08:56:30] I also thought about some options for deserialization to filter by language or property id [08:56:40] that would also help us when performance issues occur [08:56:53] let me think about something nice [09:02:15] benbe the start of the chain is now at https://gerrit.wikimedia.org/r/#/c/223254/ ;) [09:05:18] think I still want to add more xml tests :/ [09:09:50] * benestar starts getting cofused by the different review chains /o\ [09:09:58] its all in one :p [09:12:37] addshore: so you now switched the order? o.O [09:12:44] can you please separate the labels thing from the references stuff? [09:13:13] I think "Use DM Serialization in RB for labels & Descs" doesn't depend on the refactoring of the references test [09:13:13] ;) maybe :D labels is before the references stuff (references is last in the chain, followed by claims) neither of which are ready [09:13:45] * benestar now is completely confused [09:13:48] the test stuff should ideally go in before I touch anything that might break stuff, :D [09:14:07] labels stuff depends on resultbuilder::addclaims which depends on the setreferences test [09:15:29] There, I -1ed Use DM Serialization in RB for labels & Descs :D [09:15:40] need to write more xml tests first [09:15:50] hmm, ok [09:33:18] benestar: EditFilterHookRunner [09:33:20] as well! [09:34:25] addshore: yes [09:34:27] all the evil singletons [09:35:08] huh, is it no longer possible to add sitelinks to wikidata pages? [09:36:22] nikki: huh? O_o [09:38:41] yeah, try adding a link to https://www.wikidata.org/wiki/Category:User_mn-N from https://www.wikidata.org/wiki/Q6490303, I used to be able to type "wikidata" in the other sites section, but now nothing happens [09:39:34] it seems it does still work if I do it the other way round and link to the item via the "add links" link on the category [10:07:26] benestar: https://gerrit.wikimedia.org/r/#/c/223258/ is broken ;) [10:07:52] i know [10:07:54] :P [10:16:04] benestar: WTF? [10:16:52] gehts noch? [10:16:55] Thiemo_WMDE: sorry, this shouldn't escalate but without any discussion stuff shouldn't be merged if someone has concerns [10:17:36] ich bin grad saumäßig angepisst. [10:18:20] what prevents you from passing null as a parameter to the WikibaseRepo factory method? [10:18:22] du zettelst einen krieg an. [10:18:29] das geht gar nicht. [10:18:35] self-merges gehn gar nicht. [10:18:46] merges über -2 gehen aber auch garnicht [10:18:58] und wir haben uns auch noch darüber unterhalten, wie man miteinander umgeht. was soll das? [10:20:42] einen revert via self-merg rein prügeln ist für mich grad ein totschlagargument. ich kann heute nicht mehr mit dir reden, fürchte ich. [10:23:50] da war kein -2 als ich mein +2 gegeben habe. du must das gesehen haben. dein -2 sagt mir, dass du mir nicht vertraust, dass dir meine entscheidung egal ist, dass du mir eins auswischen willst, dass du mir beweisen willst dass du genauso viel macht hast wie ich. reine provokation. [10:24:50] Thiemo_WMDE: nein das stimmt nicht [10:25:03] ich hab mein -1 gegeben bevor ich gesehen hab, dass du +2 gedrückt hast [10:25:22] und dann dachte ich, um darüber vernünftig diskutieren zu können, sollte man den merge abbrechen und ggf nochmal mergen [10:25:34] das hast du dann leider missverstanden [10:26:03] wahrscheinlich hätt ich das einfach alles so laufen lassen sollen und im nachhinein meine Verbesserung vorschlagen -.- [10:26:13] Thiemo_WMDE: ich war glaub ich auch zu schnell, sorry :( [10:28:13] addshore: let's introduce global state only where it is already called global state [10:29:01] Thiemo_WMDE: nimmst du meine Entschuldigung an? Es tut mir wirklich leid -.- [10:54:00] addshore: still around? [11:16:53] benestar: leaving soon [11:16:59] k [11:17:34] addshore: should RequestContext::getMain rather be called inside of WikibaseRepo or in the callers of WikibaseRepo::getDefaultInstance() [11:17:49] jzerebecki: Thiemo_WMDE http://pastebin.com/58jfeqbr would be great to get this stuff merged before this gets any more complicated [11:48:03] addshore Thiemo_WMDE are you ok with moving RequestContext::getMain calls to WikibaseRepo and make that the central place of evil global stateness? [11:50:45] Right now I just want the Quality stuff merged so that it isnt broken [11:54:20] all that is getting way too complicated for me -.- [11:58:37] Which is why we shouldn't block small things that make big things easier ;) [11:59:12] anyway, it wont all be fixed until all 6 are merged ;) [11:59:37] sure but I don't think it's the best idea if I continue to merge stuff :S [15:04:51] are any native german speakers around? [15:05:42] https://www.wikidata.org/wiki/Wikidata:Tours/Items/de#Gratulation.21 says "Rede mit jemand im ive chat auf IRC" which doesn't seem right (if nothing else the "l" seems to have gone missing), but I'm not sure what would be best... "im Live-Chat"? [15:26:20] nikki: maybe it is better now :) [15:26:29] Jonas_WMDE: https://www.mediawiki.org/wiki/Gerrit/%2B2 [16:46:10] jzerebecki: danke :D [17:07:02] Almost all done http://tools.wmflabs.org/mix-n-match/?mode=catalog_details&catalog=55 [19:40:45] hallo daar [19:43:52] hallodaar: Hallo... [19:44:45] ik wist niet dat dit nog bestond :-) [19:45:27] Het aantal bewerkingen is alleen maar gestegen. [20:04:11] sjoerddebruin: Moet ik nlwp ook maar meteen meenemen? https://www.wikidata.org/wiki/Special:Contributions/BotMultichill :P [20:04:52] Door die Hongaar bedacht ik me dat er nog wel wat andere talen te doen waren [20:06:26] multichill: Ik weet niet hoe groot de achterstand is [20:13:35] sjoerddebruin: https://nl.wikipedia.org/wiki/Categorie:Wikipedia:Co%C3%B6rdinaten_niet_op_Wikidata <- huge [20:13:45] Mwah. [20:23:15] sjoerddebruin: Ok. Completed. The remaining pages in https://nl.wikipedia.org/wiki/Categorie:Wikipedia:Co%C3%B6rdinaten_niet_op_Wikidata are not connected to Wikidata [20:23:28] I can create new items with a bot, but I know you like to do that and do it more complete [20:23:42] Probably some graveyards without looking... [20:23:53] Ah, and churches.. [20:24:20] Yup, https://nl.wikipedia.org/wiki/Pastorie_Sint-Antoniusparochie has a Wikidata item [20:24:24] You just have to find it [20:24:56] Found it [20:25:13] But I'm busy as always... https://www.wikidata.org/w/index.php?title=Q20017675&type=revision&diff=227298045&oldid=226530835 [20:28:25] Nice. Any idea how this is sjoerddebruin https://www.wikidata.org/wiki/User:Wikidatist ? [20:28:35] Was wondering too. [20:29:10] What was the name of the Dutch guy again who lives in Ireland? Eddy something? [20:29:30] Nah, doesn't seem a person for Wikidata to me. [20:30:17] Who ever he or she is: Seems to be doing useful stuff and staying out of trouble [22:18:28] JeroenDeDauw: https://gerrit.wikimedia.org/r/223459