[01:04:02] quiddity: https://gerrit.wikimedia.org/r/175168 [01:22:52] ragesoss, oh, hmmm, I think (but am not sure) that we might be talking about different things. [01:22:53] (PageTriage component/extension's gerrit and bugzilla tickets get piped to #wikimedia-corefeatures so you may want to join and discuss there.) [01:22:53] If I understand correctly (?), there are two completely different tools involved: [01:22:53] 1) There's the popout sidebar thing that is screenshot throughout https://en.wikipedia.org/wiki/Wikipedia:Page_Curation/Help which enables a "Review" with comments. Only users with "Reviewer" flag get that interface. [01:22:53] 2) There's Patrolled Edits, which puts the small wikilink in the bottom-right corner that says "[Mark this page as patrolled]" (documented at https://www.mediawiki.org/wiki/Help:Patrolled_edits ) [01:22:56] I /think/ that Echo is sending the same notification for both. What we want, is for it to not send any notification for #2.Patrolled Edits. [01:22:59] -- [01:23:01] ["Confusing names. It's one of our areas of expertise."] [01:23:28] but i could also be completely wrong. [03:50:14] Quiddity: it's true, same notif for both... But that's because it does the same thing via either method. And, I argue, it's not useful in either case. [03:51:28] I'm not sure about page-curation, but I agree it could/should be removed from Patrolled Edits. [03:52:51] That patch only removes the case where the page-curation (or mark as patrolled) doesn't tag any issues... [03:53:08] Which is not at all useful to know. [03:56:20] ah, ok, so it does cover Patrolled Edits, too. I wasn't sure if another patch was needed for that. :) (I've starred the patch. We should probably leave an explanation at https://www.mediawiki.org/wiki/Extension_talk:PageTriage when it gets merged.) [03:56:40] (at minimum*) [03:57:13] * quiddity goes back to not working, and this glass of wine. >.> [03:57:31] Yeah... I would have filed a bug to explain/discuss... But migration. [03:58:02] * ragesoss gets another beer, eyes a joint.