[14:59:59] Did dropping all those _old tables have a significant impact on the amount of disk space used across the mysql cluster? [15:01:20] nope [15:01:30] but table == descriptor == resources [15:02:15] also less operational overhead - it takes a second per table to upgrade mysql version [15:02:45] Always nice to get tech debt cleaned up eventually :) [15:02:58] 5000 tables per 150 hosts is a lot of times saved for me [15:03:11] :) [15:03:38] it will also simplify table data checking [15:03:41] so all wins [15:03:55] Was just flicking through some of the other drop tickets... Few more tables to go, but I suspect the net win of removing them isn't anywhere as wide as the _old tables [15:04:17] agree [15:04:49] but please note that a single table per wiki is 900 tables [15:05:04] oh yeah, I'm quite well aware :) [15:05:12] :-) [15:05:15] The other tickets don't have tables on every wiki etc [15:05:22] there are some [15:05:28] so it's > 1 and < 900 etc [15:06:23] https://phabricator.wikimedia.org/T115982 [15:06:51] that is 2500 [15:07:26] also old tables nobody cares about are a vector for data leaks [15:08:05] I would really vote for properly archiving old wikis rather than keeping them on the same hosts, specially if they are small ones [15:08:32] old in what sense? "deleted"? or just "closed"? [15:08:56] both, anything that doesn't require live querying [15:09:04] if closed means read only, they are active to me [15:09:09] Yeah, it does [15:09:17] then, not those [15:09:25] Deleted wikis should be good to be archived [15:09:36] Some of those have been moved offsite etc [15:09:43] I wonder if I can help elicit some answers about some of these tickets so you know you can go ahead with them... [15:09:50] but closed dbs should be maintaned in the same way [15:10:19] otherwise mediawiki is updated and they would fall behind [15:11:39] please do, you may know the history of some extensions better than some people [15:12:31] Unfortunately, some of the authors, even still at the WMF aren't the most responsive on tickets [15:12:35] we should also make a rule to delete/archive tables for extensions discontinued - but obviouly those are the least maintened ones [15:14:15] well, I can relate- I have so many tons of todo, that if it is not breaking wikedia, it is not on my short-term list [15:14:56] the only reason I am looking at this is because due to the chain of blockers, it is blocking more important things [15:34:35] If they're ready to go, can I move them to backlog from triage? [15:40:29] which one? [15:42:07] https://phabricator.wikimedia.org/T54924 can just be done [15:42:58] https://phabricator.wikimedia.org/T57676 too [15:44:28] Hopefully, the AFT indexes and tables can all just go too... [15:54:04] Which would mean 19 tables from enwiki [16:24:12] please ad a comment on the tickets saying that you are ok with it and add, if relevant, any involved people [16:24:32] I've added to the backlog [16:24:36] *them [16:26:20] I'm doing the digging on the AFT sutff :)