[04:37:51] 10DBA, 10Operations, 10ops-codfw: db2127 memory errors - https://phabricator.wikimedia.org/T262247 (10Marostegui) 05Open→03Resolved Host was repooled Thank you Papaul! [04:51:17] 10DBA, 10Cloud-Services, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), 10Platform Team Initiatives (MCR Schema Migration), and 2 others: Apply updates for MCR, actor migration, and content migration, to production wikis. - https://phabricator.wikimedia.org/T238966 (10Marostegui) [05:12:36] 10DBA, 10DiscussionTools, 10OWC2020, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] What is the process for creating a table to store thread subsriptions? - https://phabricator.wikimedia.org/T260372 (10Marostegui) @JTannerWMF the process of creating a table is sort of split into two, I would say. The fir... [05:16:01] 10DBA, 10Community-Tech, 10Expiring-Watchlist-Items: Watchlist Expiry: Release plan [rough schedule] - https://phabricator.wikimedia.org/T261005 (10Marostegui) Thanks for the heads up @ifried. Those wikis are ok by me! [06:15:47] Good morning: [06:16:01] Amir1 o/ [06:16:06] https://usercontent.irccloud-cdn.com/file/SnJzZj4w/image.png [06:16:19] hahahahahaha [06:18:26] 10DBA, 10decommission-hardware: decommission es2014.codfw.wmnet - https://phabricator.wikimedia.org/T262889 (10Marostegui) 05Stalled→03Open [06:18:43] 10DBA, 10decommission-hardware: decommission es2014.codfw.wmnet - https://phabricator.wikimedia.org/T262889 (10Marostegui) [06:20:53] 10DBA, 10decommission-hardware, 10Patch-For-Review: decommission es2014.codfw.wmnet - https://phabricator.wikimedia.org/T262889 (10Marostegui) [07:26:08] 10DBA, 10decommission-hardware, 10Patch-For-Review: decommission es2014.codfw.wmnet - https://phabricator.wikimedia.org/T262889 (10Marostegui) mysql stopped. Giving it 24h before decommissioning this host. [08:18:20] 10DBA, 10decommission-hardware: decommission es2014.codfw.wmnet - https://phabricator.wikimedia.org/T262889 (10Marostegui) [08:18:34] jynus: wmfmariadbpy v0.5 is deployed. [08:18:49] sobanski: here's the release tag w/ description: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/wmfmariadbpy/+/refs/tags/v0.5 [08:18:57] thanks! [08:39:28] jynus: i have not touched backup*/dbprov* as wmfmariadbpy on those hosts is not managed by puppet: https://debmonitor.wikimedia.org/packages/python3-wmfmariadbpy [08:51:18] sorry, I didn't get that last thing [08:51:51] jynus: python3-wmfmariadbpy is installed on some backup* and dbprov* hosts. i'm guessing this was done manually, as puppet does not install it there [08:52:02] so i haven't touched those hosts [08:52:13] I see, I think it was a test for my packages that pulled it as a dependency [08:52:25] don't worry, it will be handled by puppet, indirectly [08:52:48] by installing the backup debs that will require those as needed [08:52:53] if it's indirect, /etc/wmfmariadbpy/section_ports.csv won't be created [08:52:59] mmm [08:53:11] then it needs to be add to puppet indeed [08:53:13] you should use the `wmfmariadbpy` puppet module [08:53:15] * kormat nods [08:53:33] I will amend https://gerrit.wikimedia.org/r/c/operations/puppet/+/628163 [08:53:37] thanks for the heads up [08:53:41] np :) [08:57:05] jynus: i'd suggest a wmfbackups profile that includes `profile::mariadb::wmfmariadbpy` [08:57:51] 10DBA: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10LSobanski) Creating custom forms requires submitting a request to Phabricator admins via https://phabricator.wikimedia.org/maniphest/task/edit/form/17/?projects=Phabricator. [08:58:12] kormat I will do that [08:58:22] 10DBA: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10LSobanski) [08:58:30] but it leaves me a bad sense it doesn't feel right [08:58:41] there is an explicit dependency on package [08:58:48] but a hidden dependency on config [08:59:09] sure, it will be fixed on puppet, but not sure it will be the most elegant way [08:59:31] I think it all comes from the deployment duality of puppet vs debian [08:59:48] 10Blocked-on-schema-change, 10DBA, 10Operations, 10User-Kormat: Schema change to make change_tag.ct_rc_id unsigned - https://phabricator.wikimedia.org/T259831 (10Kormat) [09:01:19] 10Blocked-on-schema-change, 10DBA, 10Operations, 10User-Kormat: Schema change to make change_tag.ct_rc_id unsigned - https://phabricator.wikimedia.org/T259831 (10Kormat) [09:13:44] wait, but will profile::mariadb::wmfmariadbpy install the cli script stoo? [09:14:18] I only want the library and the config (sections) [09:15:09] yeah let's add a third role option for this [09:15:24] +1 [09:15:31] I can work on it to save you time [09:15:34] unless you want to [09:16:55] no it's ok, i got it. [09:17:40] I think this is a great example of the advantages of the module- only the module will have to be changed in this case [09:18:17] which ideally would make the possiblity of unintended effects [09:21:33] does wmfmariadbpy have a wikitech page, or a section on mariadb? [09:21:42] because if not, I will start creating one [09:21:58] i don't know of one [09:21:58] documenting these little things which start to be non-obvious [09:22:27] I will start a wmfmariadbpy one [09:22:51] and link all docs that exist about the scripts there, those I think exist in some shape [09:23:38] will do the same for wmfbackups once I finish deployment [09:24:06] 10DBA: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10LSobanski) [09:24:12] thank you very much for your support on this, kormat, it helped me a lot [09:24:45] as a heads up, I will start deploying the new packages today, slowly [09:25:05] which packages? [09:25:12] backups [09:25:17] gotcha - thanks [09:25:26] 10DBA: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10LSobanski) [09:25:37] 10DBA: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10LSobanski) [09:25:37] I will add you to the relevant patches when they are rewritten [09:25:43] you as in both of you [09:26:04] 10DBA: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10LSobanski) [09:26:12] I had this ready last week, but I though last thing you wanted is backups breaking while I was away :-D [09:26:23] *thought [09:28:00] one last question, kormat, how you deal with multiple distros: will you branch away the debian dir like riccardo, or something else? I realized that I cannot really handle it properly in a single branch (I think) [09:28:23] no it's all a single branch [09:28:40] let me see [09:28:49] jynus: what in most cases we do is just override the changelog entry and rebuild [09:28:50] if there's anything distro-specific in the code, the code will detect and handle it as necessary [09:28:56] I have a bash script that does that on deneb [09:29:03] volans: interesting [09:29:14] i have a bash script on deneb that works for the single-branch approach [09:29:24] indeed it is only the changelog that creates problems for me, not the rest of the code [09:29:33] ~kormat/bin/simplebuild on deneb [09:29:41] that is also interesting, thanks kormat [09:29:43] ~volans/spicerack-release too [09:29:49] will look at both your ways [09:29:57] and will figure something [09:30:32] i looked at volans' one, and decided it was too complicated :) [09:30:42] (plus it assumes `debian/` is in a separate branch) [09:31:58] ture [09:31:59] *true [09:34:32] let's just say that my first 0.1 realease wouldn't make M*ritz happy, will fix on 0.2 [09:47:24] jynus: FYI: https://gerrit.wikimedia.org/r/c/operations/software/+/629067 added 2 very useful scripts for depooling and repooling db instances. [09:48:24] the repool one in particular is a huge timesaver [09:48:47] thanks, I will have a deeper look later [09:48:55] they indeed look like useful [09:49:47] there was no automation done regarding dbctl, I started but never produced anything [09:50:19] not sure if it will be eventually done and integrated into switchover.py or maybe orchestrator will arrive earlier [10:12:06] kormat: and we both made a mistake on patch [10:12:09] will send amend [10:18:54] kormat: should be a simple +1: https://gerrit.wikimedia.org/r/c/operations/puppet/+/629080/2/modules/wmfmariadbpy/types/role.pp [10:19:08] jynus: ohh, crap, right :) [10:19:18] my fault mainly [10:19:32] I think I am acustomed to have everything to change on the same file [10:19:53] but on the otherside, it mean it IS useful, it caught the error nicely [10:20:38] and before, we would have to grep for it on all source code, so I see it as a win [10:21:43] yeah agreed [10:31:37] 10DBA, 10Patch-For-Review: Productionize es20[26-34] and es10[26-34] - https://phabricator.wikimedia.org/T261717 (10Marostegui) es2032 has been pooled into es1 es2033 has been pooled into es2 es2034 has been pooled into es3 Next steps will be to depool the old ones, make any of these master (this is a noop) a... [10:31:55] 10DBA, 10Patch-For-Review: Productionize es20[26-34] and es10[26-34] - https://phabricator.wikimedia.org/T261717 (10Marostegui) [10:46:18] 10DBA, 10PM: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10Aklapper) IIUC author affiliation might also be wanted. The Security team has form 75 which offers an `Author Affiliation` field. I'm not sure how the same field could be introduced/"shown" on tasks which at some... [11:04:27] I am going to purposedly fail the backup check on s1-eqiad, to verify it is working as intended [11:05:22] it is downtimed [11:12:22] 10DBA, 10decommission-hardware: decommission es2014.codfw.wmnet - https://phabricator.wikimedia.org/T262889 (10Marostegui) [11:12:25] 10DBA, 10Patch-For-Review: Productionize es20[26-34] and es10[26-34] - https://phabricator.wikimedia.org/T261717 (10Marostegui) [11:13:03] It failed as expected "dump for s1 at eqiad taken more than 8 days ago: Most recent backup 2020-09-08 02:38:16" [11:13:19] I will now do a size check failure before putting things back to normal [11:17:38] "Last dump for s1 at eqiad (db1139.eqiad.wmnet:3311) taken on 2020-09-22 01:34:19 is 15 GB, but previous one was 148 GB, a change of 90.0%" [11:17:49] putting things back in place [11:56:43] marostegui: this schema change for s2/eqiad did not go as i expected, and i don't understand [11:56:59] it seems to have.. worked? [11:57:22] haha [11:57:38] kormat: did it go thru labsdb fine too? [11:57:48] yeah. this makes no sense [11:58:06] see? it is not that bad [11:58:14] 10DBA, 10CheckUser: Monitor the growth of CheckUser tables thanks to the addition of login data - https://phabricator.wikimedia.org/T261999 (10Marostegui) [11:58:19] uh huh *looks unconvinced* [11:58:45] 10DBA, 10CheckUser: Monitor the growth of CheckUser tables thanks to the addition of login data - https://phabricator.wikimedia.org/T261999 (10Marostegui) 05Open→03Resolved I think we are good - closing [11:58:48] kormat: and replication still working everywhere, right? [11:59:10] apparently so, yeah [11:59:23] good news! [11:59:23] i don't like it. it doesn't feel right [11:59:37] maybe you had a great teacher [11:59:47] please, let's be realistic [12:00:22] ok: the best teacher? [12:00:41] 10Blocked-on-schema-change, 10DBA, 10Operations, 10User-Kormat: Schema change to make change_tag.ct_rc_id unsigned - https://phabricator.wikimedia.org/T259831 (10Kormat) [12:00:42] ah, i think this is a language issue [12:00:54] marostegui: the word you're actually looking for is 'adequate' [12:01:00] haha [12:01:11] kormat: don't tent the devil... :-D or manuel will task you with upgrading labsdbs to buster [12:01:16] *tempt [12:01:40] kormat: don't worry, you'll soon get into an schema change that implies changing triggers on sanitariums, or doing different alters depending on the wiki's age [12:01:47] * kormat winces [12:01:50] see? [12:43:29] tendril looks broken, I am investigating, no help needed at this point [12:44:07] ah, it is the delete from the huge global_status_log [12:44:41] marostegui: SNAFU [12:45:37] I will give it some more minutes [12:46:02] ok, it is back [12:48:04] Tomorrow morning I will clean up that table a bit more aggresively when there is no one online [12:50:31] It has grown a lot again: Rows: 9481409918 [12:51:30] * volans hopes the id is bigint :-P [12:54:08] that number might not be super exact as I did a show table status :) [12:54:14] but yeah, I will clean it up tomorrow [12:56:43] 273G total [12:56:44] XD [12:58:15] 10DBA: tendril_purge_global_status_log_5m and global_status_log needs more frequent purging - https://phabricator.wikimedia.org/T252331 (10Marostegui) `global_status_log` has grown a lot already: 273G total `global_status_log_5m` seems "under" control: 56G total I will purge them tomorrow, anyways. Maybe the pu... [13:31:13] 10DBA, 10Cloud-Services, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), 10Platform Team Initiatives (MCR Schema Migration), and 2 others: Apply updates for MCR, actor migration, and content migration, to production wikis. - https://phabricator.wikimedia.org/T238966 (10Marostegui) [13:42:01] jynus: i think it'll be easier if i write a PoC CR to show what i'm thinking of re: https://gerrit.wikimedia.org/r/c/operations/puppet/+/629114/ [13:42:36] ok [13:43:06] but please don't merge files in modules/profile/manifests/mariadb/backup/* [13:43:15] they are very different from each other [13:43:35] the fact that they install a wmfbackup package is just a coincidence [13:46:33] 10DBA: tendril_purge_global_status_log_5m and global_status_log needs more frequent purging - https://phabricator.wikimedia.org/T252331 (10Marostegui) So the purging is actually working and `global_status_log_5m` is under control more or less with similar numbers as the ones at T252331#6165038: ` root@db1115.eqi... [13:48:44] 10DBA, 10Cloud-Services, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), 10Platform Team Initiatives (MCR Schema Migration), and 2 others: Apply updates for MCR, actor migration, and content migration, to production wikis. - https://phabricator.wikimedia.org/T238966 (10Marostegui) s3 codfw progress [] db2127... [13:51:58] jynus: https://gerrit.wikimedia.org/r/c/operations/puppet/+/629118 [13:56:51] wrong window [13:57:11] ah :) [13:57:20] I totally lost my IRC muscle memory :( [13:57:28] i've just set it to -2 to prevent accidental mering [13:57:30] *merging [13:58:14] I don't get it [13:58:24] kormat: thanks [13:58:45] the class wmfbackups sure, that is something as I said I plan to do [13:59:12] kormat, sobanski: for this kind of thing you can set it WIP [13:59:13] but I don't understand why we need a role there, they will be just separarate files [13:59:26] fromt he menu top-right with the 3 vertical dots [13:59:31] volans: that prevents review feedback [13:59:36] not true [13:59:43] it's just cumbersome [13:59:55] when you go to review you can publish without removing the WIP [14:00:00] not intuitive but possible [14:00:25] jynus: just updated, i forgot to remove the existing require_package [14:00:33] jynus: what role are you referring to? [14:00:39] and the require profile::mariadb::wmfmariadbpy as I said, it probably was just me forgetting adding it [14:00:48] Wmfbackup::Role [14:02:01] volans: oh? i've been told by people that when i set WIP they can't enter comments [14:02:46] so aside from the role thing, that was mostly what I planned to do [14:03:07] kormat: clearly you trust the wrong people :-P [14:03:32] jynus: using a variable to select which wmfbackups packages to install means we only need to put the dependency from wmfbackups to wmfmariadbpy in a single place (the profile i added) [14:03:46] kormat: but not all profiles depend on it [14:03:49] only one [14:03:56] actually [14:04:02] I think it is 2 out of 3 [14:04:29] i don't know what packages you have in wmfbackups, or what their current/future dependencies are [14:04:45] what's wrong with having several includes? [14:04:55] I would understand if they had a lot of code, but includes? [14:05:25] basically, I would like to logically separate what you call "wmfbackup profiles" [14:05:44] because they have very different use cases [14:06:20] I just happened to install 1 package each from the same repo [14:07:45] not convinced we should add all packages that depend on wmfmariadb on the same profile, even if completely logically separated [14:10:00] "what's wrong with having several includes" - what are you referring to? [14:10:28] I don't see the usefulness of Wmfbackup::Role [14:10:48] i've updated the CR to cover a second profile, which hopefully will explain it [14:10:58] they are currently 3 separate profiles that are independent [14:11:14] and only 1 depends on wmfmariadbpy, which will get its include (if it is not already there) [14:12:16] we will add 3 different classes for each one, just ignore they start all with wmfbackups, they are separate packages [14:12:19] "they are currently 3 separate profiles" - what profiles are you referring to? [14:13:01] puppet/modules/profile/manifests/mariadb/backup$ ls [14:13:07] bacula.pp check.pp mydumper.pp snapshot.pp transfer.pp [14:14:31] ok, i see 5 profiles there - which are the "3 separate profiles" that you're referring to? [14:14:40] ok, one is split in 3 [14:14:54] but you get the idea, the more the better, as they do all 1 thing and 1 thing only [14:15:55] we can move them outside of mariadb, but that is a minor issue [14:17:37] still I don't see what is the gain of Wmfbackup::Role when you say it is so "common dependencies are defined once" [14:17:46] as i see it, the 'check.pp' profile needs the `wmfbackups-check` package installed, which doesn't currently depend on wmfmariadbpy, but as mentioned in your original CR it may do so soon [14:17:47] but only 1 package/profile depends on it [14:17:58] transfer.pp needs wmfmariadbpy already [14:18:50] transfer.pp does need it, and it is enforced there, isn't it? [14:19:11] if it is not, it would be a mistake on my side [14:19:27] we add it, and that's all [14:19:51] no, it's not enforced there [14:19:57] then we add it [14:19:59] this is what i'm talking about [14:20:03] it's too easy to miss this [14:20:04] easay fix [14:21:14] as I said at https://gerrit.wikimedia.org/r/c/operations/puppet/+/629114/1/modules/profile/manifests/mariadb/backup/check.pp the patch is 1 line [14:21:40] that's missing the point [14:21:51] we should make it ~impossible to do the wrong thing, especially when it's so easy to do that [14:22:03] it is impossible to make it impossible :-D [14:22:10] you had the same mistake a few patches earlier [14:22:20] forgot to add it to the "role" [14:22:55] also I am follwing the style guide "If a profile needs another one as a precondition, it must be listed with a require ::profile::foo at the start of the class, but profile cross-dependencies should be mostly avoided." [14:23:32] or will be, once I add it back [14:26:19] this is the initial patch: https://gerrit.wikimedia.org/r/c/operations/puppet/+/629136 [14:26:35] I will move it to a different class or profile name at a later time [14:27:53] I think from your point of view this is if () {install mariadb-client} else {mariadb-server} [14:28:27] but the difference is deeper than that, and they shouldn't be mixed on the same profile, as all other install requirements are as important as the package [16:42:43] 10DBA, 10Community-Tech, 10Expiring-Watchlist-Items: Watchlist Expiry: Release plan [rough schedule] - https://phabricator.wikimedia.org/T261005 (10ifried) [16:42:59] 10DBA, 10Community-Tech, 10Expiring-Watchlist-Items: Watchlist Expiry: Release plan [rough schedule] - https://phabricator.wikimedia.org/T261005 (10ifried) [18:49:23] 10DBA, 10PM: Update the DBA task tracking workflow - https://phabricator.wikimedia.org/T263463 (10mmodell) The field will show on any task that has a value for the field. We'd have to use a task type or a herald rule to make that show up I think since it's normally hidden. [20:48:09] 10DBA, 10Operations, 10Performance-Team, 10Platform Engineering, 10User-Kormat: Remove sections from db configs - https://phabricator.wikimedia.org/T263127 (10daniel) Contributions queries are somewhat special, we may want to keep them separate in case we want special indexes or sharding. [22:45:13] 10DBA, 10Operations, 10ops-codfw, 10Patch-For-Review, 10User-Kormat: db2125 crashed - mgmt iface also not available - https://phabricator.wikimedia.org/T260670 (10Papaul) Dear Papaul Tshibamba, This e-mail is to update you on the status of your Dell Service Request. Current Status: The Dell replacemen...