[02:02:36] 10Africa-Wikimedia-Developers, 10MediaWiki-Special-pages, 10Easy, 10Patch-For-Review: Special:Version produces warning when there's an open_basedir restriction, when checking for $wgGitBin - https://phabricator.wikimedia.org/T74445#4021536 (10RazeSoldier) I push a patch. https://gerrit.wikimedia.org/r/#/c/... [11:29:16] 10Africa-Wikimedia-Developers, 10Developer-Relations: Africa Wikimedia Developers Leaderboard Monthly Statistics for the year 2018 - https://phabricator.wikimedia.org/T184192#4021969 (10rosalieper) [12:57:45] 10Africa-Wikimedia-Developers, 10Developer-Relations: Africa Wikimedia Developers IRC general meeting #4 - https://phabricator.wikimedia.org/T185803#4022033 (10D3r1ck01) [20:29:29] africanhope: Welcome :) [20:29:47] Zppix: Hey! :) [20:29:54] d3r1ck: Welcome man [20:30:34] lol I meant Hello man* [20:30:41] Yup! [20:30:47] Got a patch to review :) [20:30:56] on Github right? [20:31:00] yes! :D [20:31:26] I am it right now, we should speed things up and get the repo moved onto gerrit :) [20:32:28] by the way thanks for the unit test you added [20:33:42] africanhope: Yup! [20:33:57] I'm still adding unit test, we should have 100% coverage :D [20:35:05] d3r1ck: You moved several steps ahead, I was about to ask you about test coverage for methods others than routes handlers [20:35:33] I Just refreshed the PR and saw your latest commit [20:36:06] Yeah, I'm adding tests for UD methods now [20:38:35] What do you mean by UD? [20:38:56] Should I review and merge it or wait for additional commits? [20:43:01] User Defined :) [20:43:11] Just wait for 1 more commit for now :D [20:43:24] If the PR is not good, you can request for improvement or decline it :D [20:47:23] Duh! already merged [20:49:51] Another up and running, just 1 commit actually africanhope [20:49:53] :D [20:50:00] d3r1ck: Seen one more PR, are you done? [20:50:05] Ops, I've already merged it :D [20:50:13] lol, np [20:50:15] It's okay, sorry to bother you :) [20:50:28] So did you manage to run the unit tests? [20:50:39] I'm using "nosetests" [20:50:45] africanhope: ^ [20:51:57] not yet, still looking at the Issues created [20:52:04] Ohh okay! :) [20:52:28] africanhope: But do you think the UnitTests is a good idea? [20:52:52] You mean python3-nose dependency or the Unit test concept? [20:53:27] as for the concept it's more than important but a matter of good practice, and I am more than happy to see that implemented in this project [20:54:35] :) [20:54:43] So I was talking about the application having some unit tests [20:55:08] That will save us some time in the future when adding more features and you know, testing the application in case of any issues that arise :) [20:55:43] Yes having that is a great idea, it should even serve as a common practice for future projects [20:58:53] Okay, thanks for endorsing :) [21:02:24] you've done great on the issues [21:02:40] I'll take time tomorrow to add few that I have in my mind [21:05:45] Okay! Feel free to add as more issues as you want [21:05:59] So about the Gerrit repo, when do you think we should do it? [21:06:03] Later? [21:06:06] africanhope: ^ [21:15:30] d3r1ck: I think we'll fix the 6 existing issues and move the repo to Gerrit [21:16:22] I won't add extra issues, or many only one or two [21:17:23] Okay cool :) [21:27:34] africanhope: Maybe you can update the app on Toolforge? [21:34:40] yeah I'll do a pull [21:36:42] pulled and restarted k8s [21:37:01] by the way, is it necessary to restart k8s? [21:50:00] I think no need for that [21:50:19] paladox: Does one need to restart the k8s service when new files are added to a directory? [21:50:24] Zppix: ^ [21:50:37] d3r1ck hmm, maybe, though not sure. [21:50:41] * paladox dosen't use k8s [22:01:41] Okay! thanks paladox [22:04:21] Yes [22:04:29] d3r1ck: [22:04:43] Thanks Zppix [22:14:46] np [22:16:36] africanhope: Zppix answered your question :) [22:16:54] africanhope: a quick way to do it is kubectl delete pods --all [22:17:30] Zppix: thank you [22:18:13] the thing is last time I ran into a situation where jinja files (HTML) did not seem updated [22:18:38] I had to restart k8s, but was not sure k8s was to blame