[08:27:48] (03PS2) 10Dalba: pagegenerators._handle_recentchanges: Do not request for reversed the results [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [08:28:45] (03PS3) 10Dalba: pagegenerators._handle_recentchanges: Do not request for reversed results [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [08:48:00] (03CR) 10Zhuyifei1999: [C: 031] "LGTM" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [08:54:40] (03CR) 10Dalba: "Tests are passing OK: https://travis-ci.org/5j9/pywikibot-core/builds/417827702" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [10:24:32] (03CR) 10Xqt: [C: 032] pagegenerators._handle_recentchanges: Do not request for reversed results [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [10:25:24] (03PS4) 10Dalba: pagegenerators._handle_recentchanges: Do not request for reversed results [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [10:28:06] (03PS1) 10Framawiki: [L10N] Update families files [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453676 [10:30:34] (03CR) 10Framawiki: [C: 032] [L10N] Update families files [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453676 (owner: 10Framawiki) [10:33:11] (03Merged) 10jenkins-bot: [L10N] Update families files [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453676 (owner: 10Framawiki) [10:35:34] (03CR) 10jenkins-bot: [L10N] Update families files [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453676 (owner: 10Framawiki) [10:39:20] (03CR) 10Dalba: "Sorry, I hadn't noticed the +2 and submitted another patch with a minor refactoring." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [11:18:01] 10Africa-Wikimedia-Developers, 10User-D3r1ck01: Coding convention and style in the awmd-stats tool - https://phabricator.wikimedia.org/T202229 (10D3r1ck01) [11:19:03] 10Africa-Wikimedia-Developers, 10User-D3r1ck01: Coding convention and style in the awmd-stats tool - https://phabricator.wikimedia.org/T202229 (10D3r1ck01) [11:24:13] 10Africa-Wikimedia-Developers: Populate / Build up the contributors.json file for awmd-stats tool with contributor details - https://phabricator.wikimedia.org/T202230 (10D3r1ck01) [11:29:28] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) [11:33:55] 10Africa-Wikimedia-Developers: Rank users contributions (for a particular month) in the awmd-stats tool - https://phabricator.wikimedia.org/T202232 (10D3r1ck01) [11:38:12] 10Africa-Wikimedia-Developers: Expand awmd-stats tool for use by other event organizers in the Wikimedia movement - https://phabricator.wikimedia.org/T202233 (10D3r1ck01) [12:04:09] 10Africa-Wikimedia-Developers, 10Patch-For-Review: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) p:05Triage>03Normal [12:07:33] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) [12:09:25] 10Africa-Wikimedia-Developers: Setup Jenkins CI for awmd-stats tool - https://phabricator.wikimedia.org/T202234 (10D3r1ck01) [12:09:48] 10Africa-Wikimedia-Developers, 10User-D3r1ck01: Coding convention and style in the awmd-stats tool - https://phabricator.wikimedia.org/T202229 (10D3r1ck01) p:05Triage>03Normal [13:45:26] africanhope, welcome to the party, join me! :) [13:45:56] d3r1ck: ahaha, glad to see you're enjoying the Sunday [13:46:23] I saw a rain of PRs dropping [13:46:27] Ohhhh [13:46:30] Well [13:47:19] oh the repo has been imported to Gerrit [13:47:23] awesome! [13:47:43] When was the request granted? I checked two days ago if I am right [13:50:45] I think so too [13:52:02] d3r1ck: Great! by the way, did you import the issues manually or have you used any kind of automatic import to Phabricator [13:52:27] Nope, I did it manually since we had just a few (say like 4 or something) [13:53:30] Ah nice, good job [13:54:22] :+1: [13:54:52] I won't join you today as it is Sunday :P but it's really cool that things are moving as planned. We can now work on Phab/Gerrit and scale the tool up [13:55:23] I'll archive the github repo and call it a day [13:59:46] Okay :) [14:04:56] {{Done}} the repo has been archived! [14:08:24] * d3r1ck nods [14:36:44] (03CR) 10Xqt: [C: 032] pagegenerators._handle_recentchanges: Do not request for reversed results [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [14:39:23] (03Merged) 10jenkins-bot: pagegenerators._handle_recentchanges: Do not request for reversed results [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [14:41:49] (03CR) 10jenkins-bot: pagegenerators._handle_recentchanges: Do not request for reversed results [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445392 (https://phabricator.wikimedia.org/T199199) (owner: 10Zhuyifei1999) [17:02:03] (03PS1) 10Dalba: Skip test_category_cf on Pyhton 2.7 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453786 (https://phabricator.wikimedia.org/T202238) [18:09:05] 10Africa-Wikimedia-Developers: Setup Jenkins CI for awmd-stats tool - https://phabricator.wikimedia.org/T202234 (10D3r1ck01) a:03D3r1ck01 [18:09:14] 10Africa-Wikimedia-Developers: Setup Jenkins CI for awmd-stats tool - https://phabricator.wikimedia.org/T202234 (10D3r1ck01) p:05Triage>03Normal [18:35:16] (03CR) 10Xqt: Skip test_category_cf on Pyhton 2.7 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453786 (https://phabricator.wikimedia.org/T202238) (owner: 10Dalba) [18:37:09] (03Abandoned) 10Xqt: In return statement of RecentChangesPageGenerator if rcstart > rcend then reverse = True and when rcstart < rcend then reverse = False [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445956 (https://phabricator.wikimedia.org/T199199) (owner: 10AdityaJ) [18:38:56] (03PS2) 10Dalba: Revert "pywikibot.tools.chars: Update and simplify the code" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453786 (https://phabricator.wikimedia.org/T202238) [18:46:21] (03PS1) 10Dalba: Merge "pagegenerators._handle_recentchanges: Do not request for reversed results" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453818 [18:49:06] (03CR) 10jerkins-bot: [V: 04-1] Merge "pagegenerators._handle_recentchanges: Do not request for reversed results" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453818 (owner: 10Dalba) [18:49:40] (03PS3) 10Dalba: Revert "pywikibot.tools.chars: Update and simplify the code" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453786 (https://phabricator.wikimedia.org/T202238) [18:50:33] (03Abandoned) 10Dalba: Merge "pagegenerators._handle_recentchanges: Do not request for reversed results" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453818 (owner: 10Dalba) [18:53:03] 10Africa-Wikimedia-Developers, 10Patch-For-Review, 10User-D3r1ck01: Setup Jenkins CI for awmd-stats tool - https://phabricator.wikimedia.org/T202234 (10D3r1ck01) [18:56:04] paladox: Hey! Good at Jenkins CI ain't you? [18:56:09] Need a helping hand :) [19:14:16] d3r1ck: hi, I’m currently on the London eye :) [19:17:06] Hmmm... [19:17:15] Okay, so I'll poke you some other time? [19:17:28] paladox: ^ [19:29:40] (03CR) 10D3r1ck01: [C: 031] Refactor ext to fix onAlternateMailerHook() hook handler [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 (owner: 10D3r1ck01) [19:40:52] 10Africa-Wikimedia-Developers, 10Easy: Populate / Build up the contributors.json file for awmd-stats tool with contributor details - https://phabricator.wikimedia.org/T202230 (10D3r1ck01) [19:42:18] 10Africa-Wikimedia-Developers, 10Easy: Populate / Build up the contributors.json file for awmd-stats tool with contributor details - https://phabricator.wikimedia.org/T202230 (10D3r1ck01) [19:51:49] africanhope: And you'll now join the party? [19:52:23] d3r1ck: lol Sunday man, Sunday [19:52:32] Alright! [19:52:47] I usually use my weekends (sometimes) to volunteer :) [19:53:06] But no problem, if you join the party when it's over, you can always throw another [19:53:51] africanhope: So the repo is now solid in terms of structure, you'll enjoy it :) [19:54:47] I have no doubt, I haven't checked it out thoroughly but knowing your prowess I am sure it looks super fine :P [19:55:48] africanhope: Not super :D [19:55:51] Just "fine" [19:56:35] One key thing we need to keep an eye on is "unit tests" [19:56:44] We aim at 100% coverage [19:57:54] Indeed [19:59:58] Current coverate [20:00:00] Name Stmts Miss Cover [20:00:03] ------------------------------------------- [20:00:08] awmdstats/__init__.py 1 0 100% [20:00:08] awmdstats/app.py 64 1 98% [20:00:08] awmdstats/settings.py 10 10 0% [20:00:13] awmdstats/utils.py 75 1 99% [20:00:13] manage.py 8 8 0% [20:00:14] tests/__init__.py 0 0 100% [20:00:16] tests/conftest.py 6 0 100% [20:00:19] tests/test_app.py 38 0 100% [20:00:21] ------------------------------------------- [20:00:24] TOTAL 202 20 90% [20:00:24] So when one adds a functionality, he/she should just write a test case for it :) [20:00:30] africanhope: ^ [20:01:07] how did you get those stats? [20:01:15] https://github.com/pytest-dev/pytest-cov [20:01:27] It may not be 100% accurate but that's a recommended tool :) [20:01:46] It's a coverage tool for pytest [20:02:52] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10samuelguebo) [20:02:58] africanhope: https://pypi.org/project/pytest-cov/ [20:03:26] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10samuelguebo) [20:03:39] nice tool, I documented the Phab task with it [20:04:08] It might serve as a reference for anyone that comes along and feels like working on that [20:04:43] or working on anything related to the project as we want to make it mandatory to include test for any new feature [20:04:53] Sure! Thanks [20:05:18] One should also use "pytest" to run unit tests [20:06:16] Yeah maybe we should specify it as part of the readme or anywhere else [20:07:14] Sure [20:07:19] The doc had been updated, see this [20:07:21] https://github.com/wikimedia/labs-tools-awmd-stats [20:08:51] africanhope: Repo is now on Gerrit so you'll have to use the gerrit way to get the repo now :) [20:10:31] oh man, I need to get my head around it, lots of good stuffs happened :) [20:10:48] get your head around what africanhope ? [20:11:36] the new structure of files, I took a quick look and saw some very nice improvements [20:11:48] nice? :D [20:14:56] I just hope it makes things get better :) [20:16:25] It surely does [20:19:52] Okay, let's see how it goes [20:20:05] africanhope: So the name of the database folder has changed from "db" to "database" [20:20:30] That's self explanatory, nice [20:20:32] So in production, change it when you update production but hey, make sure to test before updating on production [20:20:50] And maybe we can tag this as a release due to the refactoring etc :D [20:21:18] africanhope: We already have 2 releases: https://github.com/wikimedia/labs-tools-awmd-stats/releases [20:21:29] We can work on this and tag to v2.0? [20:30:10] 10Africa-Wikimedia-Developers, 10Easy: Populate / Build up the contributors.json file for awmd-stats tool with contributor details - https://phabricator.wikimedia.org/T202230 (10D3r1ck01) [20:44:03] africanhope: ^? [20:47:39] * africanhope is concurring on all the above [20:48:59] :D [20:49:11] Okay, copy that! [21:00:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/453837 (owner: 10L10n-bot) [21:09:28] * d3r1ck checks out! [21:15:43] (03CR) 10Xqt: [C: 032] Revert "pywikibot.tools.chars: Update and simplify the code" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453786 (https://phabricator.wikimedia.org/T202238) (owner: 10Dalba) [21:18:09] (03Merged) 10jenkins-bot: Revert "pywikibot.tools.chars: Update and simplify the code" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453786 (https://phabricator.wikimedia.org/T202238) (owner: 10Dalba) [21:20:37] (03CR) 10jenkins-bot: Revert "pywikibot.tools.chars: Update and simplify the code" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453786 (https://phabricator.wikimedia.org/T202238) (owner: 10Dalba) [21:21:08] (03CR) 10Legoktm: [C: 032] Refactor ext to fix onAlternateMailerHook() hook handler [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 (owner: 10D3r1ck01) [21:25:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/453851 (owner: 10L10n-bot) [21:25:52] (03CR) 10jerkins-bot: [V: 04-1] Refactor ext to fix onAlternateMailerHook() hook handler [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 (owner: 10D3r1ck01) [22:08:48] d3r1ck: yep, you can ask if you want and I can answer later [22:08:56] (If I know the answer) :) [22:09:03] I’m just on holiday for 2 weeks now