[08:41:36] d3r1ck: Hi man [10:08:22] (03CR) 10Xqt: [C: 04-1] Have decisions on Wikidata confirmed in interwikidata.py (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/449740 (https://phabricator.wikimedia.org/T134499) (owner: 10Matěj Suchánek) [10:12:51] (03CR) 10Xqt: pagegenerators.py: Avoid applying two uniquifying filters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/454198 (https://phabricator.wikimedia.org/T199615) (owner: 10Dalba) [10:15:19] (03PS4) 10Xqt: [IMPR] improve hash method for BasePage and Link [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453576 [10:17:37] (03CR) 10Xqt: "> As a tuple. Not two arguments." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453576 (owner: 10Xqt) [10:33:53] (03PS2) 10Xqt: [IMPR] template parameter is a Page object already [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445767 [10:43:33] (03PS3) 10Xqt: [IMPR] template parameter is a Page object already [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445767 [10:47:55] (03CR) 10Xqt: [bugfix] Fix the extended user-config extraction regex (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/309965 (https://phabricator.wikimedia.org/T145371) (owner: 10Xqt) [10:52:53] (03CR) 10Matěj Suchánek: [C: 04-1] Have decisions on Wikidata confirmed in interwikidata.py (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/449740 (https://phabricator.wikimedia.org/T134499) (owner: 10Matěj Suchánek) [10:56:11] * d3r1ck checks-in [11:02:33] (03PS1) 10Xqt: [cleanup] cleanup config2.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 [11:19:52] (03CR) 10Xqt: Have decisions on Wikidata confirmed in interwikidata.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/449740 (https://phabricator.wikimedia.org/T134499) (owner: 10Matěj Suchánek) [11:20:32] africanhope: I saw your ping, sorry I was still sleeping [11:20:41] But I'm around now, hope you're doing great? [11:21:14] Yeah sleeping is one of the most beautiful things we can enjoy in this life [11:29:37] :) [11:30:12] Added few UD tests, about to push the patch [11:30:33] pytest says all things are good [11:34:49] \o/ [11:44:50] (03PS1) 10African Hope: Added some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) [11:48:14] d3r1ck: Its kind of strange, I had created a separate branch, but seems like it's pushing to master [11:50:06] The topic is "test-ud-methods" [11:50:16] Which is fine, when it merges, it'll go to master :) [11:50:18] Is that a reference to the branch? [11:50:53] "topic" just seemed unclear to me [11:51:43] when you're doing reviewing and merging I'll do a pull on the production version [11:52:14] aside writing UD tests, I have doing a bunch of tests this morning as you suggested [11:53:28] (03CR) 10D3r1ck01: [C: 04-1] "Thanks for the patch, some fixes :)" (035 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [11:53:57] africanhope: Yeah, so topic in this case I think just means the branch you made the commit from [11:54:11] Maybe paladox can better explain, he's our Gerrit guru here :) [11:54:29] africanhope: Did you test well before updating production? [11:54:42] Okay, sorry I just saw your last message now [11:54:54] So how did the test go? Bad, Good, normal etc? [11:55:04] yep, topic can be used if you have mutiple changes you can merge them together (i am not sure if we enabled that). [11:55:11] or you could use the hashtag feature [11:55:21] :) [11:55:54] paladox: thanks for clarifications [11:56:10] your welcome :) [11:56:19] d3r1ck: tests where fine, nothing red popped up :) [11:56:21] you can use topic to link changes [11:56:54] africanhope: Jenkins has CI tests to do apart from running unit tests [11:57:02] Let's wait for Jenkins :) [11:57:11] Yeah let's Jerkins do its stuff [11:57:33] let* [11:57:47] (03CR) 10D3r1ck01: [C: 04-1] "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [11:58:16] (03CR) 10jerkins-bot: [V: 04-1] Added some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [11:58:25] africanhope: You see now? :) [11:58:34] Yeah [11:58:49] Check the console logs [11:58:51] by the way, what editor do you use? I have regular issues with spaecs [11:58:56] spaces* [12:00:16] something wrong with flake8, have no clue [12:00:37] ahhh [12:00:38] lol [12:00:49] I've moved from Sublime [12:00:53] I now use Atom :) [12:01:07] But it's not the editor, we just have to get to know the guidelines [12:01:12] Follow the CCs :) [12:01:36] When I was doing the refactoring, it took me hell lot of time to get pass all the CC errors [12:01:47] Atom here too [12:02:04] From that experience, it's now in my head. I can see CC errors before Jenkins even flag them :) [12:02:21] I'm sure, after this experience, you'll definitely be a pro :D [12:03:02] africanhope: So here is it [12:03:02] Will work on that during my next break [12:03:04] 11:58:03 ./tests/test_utils.py:39:32: E202 whitespace before ')' [12:03:06] 11:58:03 ./tests/test_utils.py:39:73: E261 at least two spaces before inline comment [12:03:08] 11:58:03 ./tests/test_utils.py:39:91: E501 line too long (116 > 90 characters) [12:03:10] 11:58:03 ./tests/test_utils.py:47:91: E501 line too long (104 > 90 characters) [12:03:12] 11:58:03 ./tests/test_utils.py:54:36: E261 at least two spaces before inline comment [12:03:14] Sure, no problem sir! [12:03:14] Yeah I spotted them [12:03:21] \o/ [12:03:31] You have edited my patch right? [12:03:49] Just wondering if I need to do a pull or something to have the version you edited [12:03:57] africanhope: No [12:04:05] I've not edited [12:04:09] I just left some comments [12:04:22] So you can just fix them and work directly on the same branch [12:04:36] Except you wish to use the "git review -d 455146" [12:04:46] To work directly on that specific change etc. [12:06:06] good [12:06:29] d3r1ck: any tip for the line too long issue [12:06:44] I don't wont to have a two lines comment man [12:08:03] Okay [12:08:13] So that is Python's Pep8 E501 [12:08:28] https://lintlyci.github.io/Flake8Rules/rules/E501.html [12:08:38] https://stackoverflow.com/questions/18685184/pep8-e501-line-too-long-error [12:08:43] Well I'll probably have to split into two lines after all [12:08:45] You could make the comment shorter [12:08:48] Okay [12:08:54] You have all the powers :) [12:09:21] That's been told to me several times this week [12:09:35] Ahhhhh! That only proves we're all humans :) [12:09:42] Probably with some level of connected energy [12:09:44] Mainly because I faced power failure issues [12:09:50] :D [12:09:50] lol [12:10:17] * d3r1ck throws his drink [12:10:20] ok, I fixed the typos and ran a pytest just in case lol [12:10:30] africanhope: Okay! [12:10:43] So one thing for sure is that "Testing" is a religion and should always be done [12:10:59] So running "pytest -v" will help us know if we've not broken a code unit :) [12:11:19] * d3r1ck always runs unit tests before submitting a PS [12:11:37] paladox: I can feel some changes in the new UI of Gerrit [12:11:44] Seems upstream is doing great! [12:11:51] Kudos to you :) [12:12:11] Yep :) [12:12:17] (03PS2) 10African Hope: Added some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) [12:12:36] Well upstream did the UI changes [12:13:18] d3r1ck: Hope Jerkins will be happy this time [12:13:24] Will be back in few hours [12:13:36] Okay! [12:13:40] paladox: :) [12:21:48] (03CR) 10Dalba: pagegenerators.py: Avoid applying two uniquifying filters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/454198 (https://phabricator.wikimedia.org/T199615) (owner: 10Dalba) [12:22:56] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [12:23:21] (03CR) 10jerkins-bot: [V: 04-1] Added some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [12:42:39] (03CR) 10Matěj Suchánek: [C: 04-1] Have decisions on Wikidata confirmed in interwikidata.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/449740 (https://phabricator.wikimedia.org/T134499) (owner: 10Matěj Suchánek) [13:37:12] (03PS3) 10African Hope: Added some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) [13:38:10] d3r1ck: do you manually type Patch Set n: \n recheck ? [13:38:39] I meant for Jenkins to be triggered [13:43:21] (03CR) 10African Hope: "Patch Set 3:" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [13:51:48] (03CR) 10Xqt: [C: 032] pagegenerators.py: Avoid applying two uniquifying filters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/454198 (https://phabricator.wikimedia.org/T199615) (owner: 10Dalba) [13:52:43] (03CR) 10African Hope: "Patch Set 3:" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [13:53:09] (03CR) 10African Hope: "Patch Set 3:" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [13:54:16] (03CR) 10African Hope: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [13:54:37] (03Merged) 10jenkins-bot: pagegenerators.py: Avoid applying two uniquifying filters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/454198 (https://phabricator.wikimedia.org/T199615) (owner: 10Dalba) [13:55:54] africanhope: Yes in this case [13:56:06] So I'm just doing recheck to recall Jenkins' attention to that PS [13:56:25] But the repo should trigger Jenkins CI upon patch submission by defualt [13:56:28] *default [13:56:57] lol I wrote a bunch of mistakes in the comment [13:57:12] africanhope: Also, you need to be in the list of users who can do "recheck" etc [13:57:16] africanhope: mistakes? Where? [13:57:35] in the patch comments, lot of "Recheck" there [13:57:52] (03CR) 10jenkins-bot: pagegenerators.py: Avoid applying two uniquifying filters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/454198 (https://phabricator.wikimedia.org/T199615) (owner: 10Dalba) [13:58:06] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [13:58:46] :) [13:58:52] Jenkins is happy with the patch right now! [13:59:52] africanhope: Reviewing the patch now! [14:00:44] next time I'll just ping you to trigger jenkins [14:01:21] Ohh, like I said, no need for that, Jenkins should be triggered by default, if it doesn't, then we'll see what to do [14:01:30] (03CR) 10D3r1ck01: "Few more minor fixes" (032 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [14:01:30] africanhope: A few more fixes and the patch is good to go? [14:03:54] so two spaces after #? [14:04:07] I think so, check the comment :) [14:04:15] But it also depends on the use-case :) [14:04:32] some comments before methods have two spaces after # some just don't [14:05:51] africanhope: This is just an alignment issue I think [14:05:55] # Past month with no data: [14:05:57] # https://tools.wmflabs.org/awmd-stats/contributor/Rosalieper/2018-04. [14:06:13] Agree [14:06:21] Just so that the "h" in the link aligns with the "P" in the Past ... [14:06:36] Then the imports to be fashionable :D [14:07:26] (03PS4) 10African Hope: Added some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) [14:07:51] yeah the import are fashionable now [14:09:55] \o/ [14:13:39] (03CR) 10D3r1ck01: "Sorry, thought you had fixed this, just 1 more little issue :)" (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [14:14:00] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [14:17:42] (03PS5) 10African Hope: Add some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) [14:18:43] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [14:20:29] (03CR) 10D3r1ck01: [C: 032] Add some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [14:20:59] (03Merged) 10jenkins-bot: Add some unit tests for UD methods [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/455146 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [14:22:02] (03CR) 10Dalba: [cleanup] cleanup config2.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 (owner: 10Xqt) [14:22:05] 10Africa-Wikimedia-Developers: Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T202231 (10D3r1ck01) [15:10:45] (03PS1) 10Xqt: [cleanup] move code parts from create_user_config to copy_sections [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455179 [15:14:45] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] move code parts from create_user_config to copy_sections [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455179 (owner: 10Xqt) [15:17:19] (03PS2) 10Xqt: [cleanup] cleanup config2.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 [15:23:34] (03CR) 10Xqt: [cleanup] cleanup config2.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 (owner: 10Xqt) [15:29:47] (03CR) 10Dalba: [cleanup] cleanup config2.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 (owner: 10Xqt) [15:31:40] (03PS2) 10Xqt: [cleanup] move code parts from create_user_config to copy_sections [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455179 [15:34:59] (03PS3) 10Xqt: [cleanup] cleanup config2.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 [15:36:03] (03PS3) 10Xqt: [cleanup] move code parts from create_user_config to copy_sections [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455179 [15:38:40] (03CR) 10Dalba: [C: 032] [cleanup] cleanup config2.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 (owner: 10Xqt) [15:41:37] (03Merged) 10jenkins-bot: [cleanup] cleanup config2.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 (owner: 10Xqt) [15:44:16] (03CR) 10jenkins-bot: [cleanup] cleanup config2.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455139 (owner: 10Xqt) [18:49:22] (03CR) 10Framawiki: [cleanup] move code parts from create_user_config to copy_sections (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/455179 (owner: 10Xqt) [18:52:59] (03CR) 10Framawiki: [C: 031] [IMPR] template parameter is a Page object already [pywikibot/core] - 10https://gerrit.wikimedia.org/r/445767 (owner: 10Xqt) [18:54:41] (03CR) 10Framawiki: [C: 032] [IMPR] improve hash method for BasePage and Link [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453576 (owner: 10Xqt) [18:56:27] (03CR) 10Framawiki: [C: 031] Allow bot parameter in set_redirect_target [pywikibot/core] - 10https://gerrit.wikimedia.org/r/336882 (owner: 10Matěj Suchánek) [18:57:17] (03Merged) 10jenkins-bot: [IMPR] improve hash method for BasePage and Link [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453576 (owner: 10Xqt) [19:00:03] (03CR) 10jenkins-bot: [IMPR] improve hash method for BasePage and Link [pywikibot/core] - 10https://gerrit.wikimedia.org/r/453576 (owner: 10Xqt)