[05:36:10] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/457451 (owner: 10D3r1ck01) [05:43:57] (03Merged) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/457451 (owner: 10D3r1ck01) [05:55:55] (03CR) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/457451 (owner: 10D3r1ck01) [07:00:28] (03PS1) 10Dalba: pywikibot.page.Link.langlinkUnsafe: Set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) [07:02:34] (03PS2) 10Dalba: pywikibot.page.Link.langlinkUnsafe: Set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) [07:04:32] (03CR) 10Matěj Suchánek: Allow bot parameter in set_redirect_target (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/336882 (owner: 10Matěj Suchánek) [07:04:46] (03PS3) 10Dalba: pywikibot.page.Link.langlinkUnsafe: Set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) [07:08:24] (03PS4) 10Dalba: pywikibot.page.Link.langlinkUnsafe: Set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) [07:08:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/458370 (owner: 10L10n-bot) [07:23:45] (03PS5) 10Dalba: page.Link.langlinkUnsafe: Always set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) [07:39:01] (03PS6) 10Dalba: page.Link.langlinkUnsafe: Always set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) [08:01:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/458405 (owner: 10L10n-bot) [09:12:14] (03PS1) 10Xqt: [fix] Skip test_no_params() for status 503 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) [09:26:07] (03CR) 10Dalba: "I seems that this error might happen in any of the QueryStringParamsTestCase methods. Wouldn't it be better to add a class decorator (or u" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) (owner: 10Xqt) [09:34:44] (03PS2) 10Xqt: [fix] Skip test_no_params() for status 503 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) [09:37:19] (03CR) 10jerkins-bot: [V: 04-1] [fix] Skip test_no_params() for status 503 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) (owner: 10Xqt) [09:54:05] (03PS3) 10Xqt: [fix] Skip test_no_params() for status 503 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) [09:57:52] (03CR) 10Xqt: [C: 032] page.Link.langlinkUnsafe: Always set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) (owner: 10Dalba) [09:58:03] (03CR) 10jerkins-bot: [V: 04-1] [fix] Skip test_no_params() for status 503 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) (owner: 10Xqt) [10:00:26] (03Merged) 10jenkins-bot: page.Link.langlinkUnsafe: Always set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) (owner: 10Dalba) [10:02:51] (03CR) 10jenkins-bot: page.Link.langlinkUnsafe: Always set _namespace to a Namespace object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458359 (https://phabricator.wikimedia.org/T203491) (owner: 10Dalba) [10:19:31] (03PS19) 10Xqt: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/428143 (https://phabricator.wikimedia.org/T192706) [10:41:31] (03PS1) 10Xqt: [doc] Update doc for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 [10:51:47] (03PS20) 10Xqt: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/428143 (https://phabricator.wikimedia.org/T192706) [10:53:42] (03PS4) 10Xqt: [fix] Skip test_no_params() for status 503 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) [10:58:29] (03CR) 10Dalba: [doc] Update doc for makecat.py (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [11:42:16] (03PS2) 10Xqt: [doc] Update doc for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 [11:49:01] (03CR) 10Xqt: [doc] Update doc for makecat.py (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [12:27:20] (03PS1) 10Xqt: [cleanup] cleanup script code [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458491 [12:30:13] (03CR) 10Dalba: [C: 032] [cleanup] cleanup script code [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458491 (owner: 10Xqt) [12:32:49] (03Merged) 10jenkins-bot: [cleanup] cleanup script code [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458491 (owner: 10Xqt) [12:35:27] (03CR) 10jenkins-bot: [cleanup] cleanup script code [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458491 (owner: 10Xqt) [13:49:02] (03PS1) 10Xqt: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 [13:49:55] (03PS2) 10Xqt: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 [13:52:28] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 (owner: 10Xqt) [13:58:08] (03PS1) 10Xqt: [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 [13:59:22] (03PS3) 10Xqt: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 [14:00:45] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 (owner: 10Xqt) [14:01:54] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 (owner: 10Xqt) [14:06:02] (03PS4) 10Xqt: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 [14:08:35] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 (owner: 10Xqt) [14:13:59] (03PS5) 10Xqt: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 [14:16:01] (03PS2) 10Xqt: [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 [14:35:37] (03CR) 10Dalba: [doc] Update doc for makecat.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [15:16:40] (03CR) 10Xqt: [doc] Update doc for makecat.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [15:39:00] (03PS3) 10Xqt: [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 [16:01:17] (03CR) 10Dalba: [C: 04-1] "I'm getting the following error when trying to build the docs:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [16:04:26] (03CR) 10Dalba: [C: 04-1] "BTW, I had the body of the script (except the docstring) commented out to avoid the crash during build." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [16:16:16] (03PS1) 10Xqt: [doc] Enable documentation generated for makecat.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458527 (https://phabricator.wikimedia.org/T203675) [16:21:14] (03CR) 10Xqt: "> I'm getting the following error when trying to build the docs:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [16:23:33] (03PS3) 10Xqt: [doc] Update doc for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 [16:28:41] (03CR) 10Dalba: [IMPR] Simplify needcheck method (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 (owner: 10Xqt) [16:33:53] (03CR) 10Dalba: [C: 032] [doc] Enable documentation generated for makecat.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458527 (https://phabricator.wikimedia.org/T203675) (owner: 10Xqt) [16:42:47] (03CR) 10Dalba: [C: 032] [IMPR] Improvements for makecat.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 (owner: 10Xqt) [16:46:30] (03Merged) 10jenkins-bot: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 (owner: 10Xqt) [16:49:08] (03CR) 10jenkins-bot: [IMPR] Improvements for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458506 (owner: 10Xqt) [17:25:28] (03PS1) 10Saurab0512: test gerrit review commit [extensions/examples] - 10https://gerrit.wikimedia.org/r/458540 [17:25:34] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/458540 (owner: 10Saurab0512) [17:35:35] (03CR) 10Aklapper: "Saurab0512: Hi. How did you find out about gerrit.wikimedia.org ?" [extensions/examples] - 10https://gerrit.wikimedia.org/r/458540 (owner: 10Saurab0512) [17:36:27] (03Abandoned) 10Aklapper: test gerrit review commit [extensions/examples] - 10https://gerrit.wikimedia.org/r/458540 (owner: 10Saurab0512) [20:01:07] (03CR) 10African Hope: [C: 032] "Good work! In the future, we should consider creating a third sh file that will trigger install-deps.sh and generate_docs.sh to fire the w" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/456139 (owner: 10D3r1ck01) [20:01:33] (03Merged) 10jenkins-bot: docs: Semi-automate how the docs will be generated and kept [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/456139 (owner: 10D3r1ck01) [20:02:50] d3r1ck: Patch review [20:02:59] Patch reviewed* [20:03:04] * d3r1ck thanks africanhope [20:03:43] You've done some nice stuffs there. I left a suggestion in the comment [20:05:07] (03CR) 10D3r1ck01: "> Patch Set 2: Code-Review+2" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/456139 (owner: 10D3r1ck01) [20:05:20] africanhope: Saw it :) [20:05:27] And just replied, it's a great idea [20:05:39] Wondering the plan to that :), we can talk about it :) [20:06:38] africanhope: Will you deploy the patch today? Or maybe we schedule deployment during weekends? [20:10:04] Once merged I will pull and run a last test locally before deploying to production [20:10:28] Wait a min, want to submit a quick patch now to link to the docs on the interface :) [20:10:30] please [20:10:42] Sure, I can hold off [20:11:53] (03CR) 10African Hope: [C: 032] "> > Patch Set 2: Code-Review+2" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/456139 (owner: 10D3r1ck01) [20:13:21] So have we agreed on filing a ticket or what? [20:16:01] d3r1ck: ^^ [20:16:31] africanhope: I think so, so we always remember there is a task around :) [20:22:49] d3r1ck: I am creating the ticket right now. But the maintenance repository doesn't meet our need to simplify things. I am more in favor of adjusting/ renaming the existing install-deps.sh [20:22:54] Your guess? [20:23:06] Okay [20:27:24] 10Africa-Wikimedia-Developers: Merge install-deps.sh and generate_docs.sh into a single file - https://phabricator.wikimedia.org/T203713 (10samuelguebo) [20:30:18] (03PS1) 10D3r1ck01: Link to the docs on the app interface [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458585 [20:32:10] africanhope: You're up for review [20:32:18] https://gerrit.wikimedia.org/r/458585 [20:33:03] (03PS2) 10D3r1ck01: Link to the docs on the app interface [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458585 [20:33:44] After that, you can deploy I'm sure :) [20:33:48] africanhope: ^^ [20:35:27] 10Africa-Wikimedia-Developers: Merge install-deps.sh and generate_docs.sh into a single file - https://phabricator.wikimedia.org/T203713 (10D3r1ck01) @samuelguebo, you mean regenerate right? Since I think the docs are already in the repo? I think regenerate in case of any changes whose docs are not yet into the... [20:43:26] (03CR) 10D3r1ck01: [C: 032] Link to the docs on the app interface [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458585 (owner: 10D3r1ck01) [20:43:49] (03Merged) 10jenkins-bot: Link to the docs on the app interface [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458585 (owner: 10D3r1ck01) [20:45:29] africanhope: Have a look at this: http://tools.wmflabs.org/wlm-stats/ :) [20:45:42] also, you can update the tool on server now [20:46:40] nice stats tools, this one is nice too: https://tools.wmflabs.org/wikiloves/ [20:47:02] Do you think there can be some takeaways from the above tools? [20:48:15] (will run some test locally before deploying to prod) [20:48:18] africanhope: I think so if we want to. I've looked at the source code :) [20:48:24] africanhope: Okay, sure! [21:01:23] I have pip as alias for pip3, yet I get an error [21:01:26] ./generate_docs.sh: line 7: pip: command not found [21:01:26] ./generate_docs.sh: line 10: pycco: command not found [21:02:14] Hmmm... both needs to be installed via the install-deb.sh [21:03:25] Ahh just pip is installed [21:03:40] So we need to also make sure that pycco is installed [21:03:43] I leave that to you africanhope [21:04:19] this ain't the issue I think, but I can handle it [21:04:52] I remember that I once edited install-deps to use pip3 as a fallback when pip is not installed [21:04:55] Okay, I go to sleep :) [21:05:02] lol [21:05:06] Okay, good night! [21:05:09] * d3r1ck checks out! [21:05:14] Cheers [21:47:22] 10Africa-Wikimedia-Developers: Merge install-deps.sh and generate_docs.sh into a single file - https://phabricator.wikimedia.org/T203713 (10samuelguebo) [21:47:55] 10Africa-Wikimedia-Developers: Merge install-deps.sh and generate_docs.sh into a single file - https://phabricator.wikimedia.org/T203713 (10samuelguebo) @D3r1ck01, yes, in this case regenerate is more appropriate. [22:49:31] (03PS1) 10African Hope: Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) [23:06:18] (03PS2) 10Krinkle: Improve keyboard focus outline appearance [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE) [23:06:28] (03CR) 10Krinkle: [C: 032] Improve keyboard focus outline appearance [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE) [23:12:38] (03PS2) 10African Hope: Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) [23:15:41] (03CR) 10VolkerE: "Just saw that again, will make a follow-up now…" [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE) [23:24:17] (03Merged) 10jenkins-bot: Improve keyboard focus outline appearance [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE)