[01:24:12] (03CR) 10Krinkle: [C: 04-1] Add README.md file to the repository (031 comment) [extensions/examples] - 10https://gerrit.wikimedia.org/r/454598 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [06:03:33] (03PS1) 10Dalba: textlib._tag_pattern: Do not mistake self-closing tags with start tag [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458636 (https://phabricator.wikimedia.org/T203568) [06:47:47] (03PS2) 10Dalba: textlib._tag_pattern: Do not mistake self-closing tags with start tag [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458636 (https://phabricator.wikimedia.org/T203568) [06:49:41] (03PS3) 10Dalba: textlib._tag_pattern: Do not mistake self-closing tags with start tag [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458636 (https://phabricator.wikimedia.org/T203568) [07:11:23] (03PS2) 10Xqt: [doc] Enable documentation generated for makecat.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458527 (https://phabricator.wikimedia.org/T203675) [07:14:17] (03CR) 10Xqt: [C: 032] textlib._tag_pattern: Do not mistake self-closing tags with start tag [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458636 (https://phabricator.wikimedia.org/T203568) (owner: 10Dalba) [07:16:58] (03Merged) 10jenkins-bot: textlib._tag_pattern: Do not mistake self-closing tags with start tag [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458636 (https://phabricator.wikimedia.org/T203568) (owner: 10Dalba) [07:19:30] (03CR) 10jenkins-bot: textlib._tag_pattern: Do not mistake self-closing tags with start tag [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458636 (https://phabricator.wikimedia.org/T203568) (owner: 10Dalba) [07:20:41] (03PS4) 10Xqt: [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 [07:29:20] (03CR) 10Dalba: [C: 032] [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 (owner: 10Xqt) [07:31:43] (03CR) 10Dalba: [C: 032] [doc] Enable documentation generated for makecat.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458527 (https://phabricator.wikimedia.org/T203675) (owner: 10Xqt) [07:34:24] (03Merged) 10jenkins-bot: [doc] Enable documentation generated for makecat.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458527 (https://phabricator.wikimedia.org/T203675) (owner: 10Xqt) [07:35:37] (03Merged) 10jenkins-bot: [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 (owner: 10Xqt) [07:36:22] (03CR) 10Dalba: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [07:36:52] (03CR) 10jenkins-bot: [doc] Enable documentation generated for makecat.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458527 (https://phabricator.wikimedia.org/T203675) (owner: 10Xqt) [07:39:16] (03CR) 10jenkins-bot: [IMPR] Simplify needcheck method [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458508 (owner: 10Xqt) [07:42:24] (03CR) 10Dalba: [C: 032] [doc] Update doc for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [07:45:05] (03Merged) 10jenkins-bot: [doc] Update doc for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [07:47:36] (03CR) 10jenkins-bot: [doc] Update doc for makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458473 (owner: 10Xqt) [08:14:33] 10Africa-Wikimedia-Developers, 10Developer-Advocacy: Google Code-In Program 2018 Interested Mentors from Africa - https://phabricator.wikimedia.org/T203068 (10BamLifa) [08:38:51] (03PS1) 10Xqt: [IMPR] Change option shortcuts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458727 [09:38:53] (03PS1) 10Xqt: [IMPR] Use bot instance instead of bot class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458749 [09:41:31] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Use bot instance instead of bot class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458749 (owner: 10Xqt) [09:56:04] (03PS2) 10Xqt: [IMPR] Use bot instance instead of bot class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458749 [10:33:33] Hello d3r1ck: I left something for you to review yesterday [10:41:39] (03PS1) 10Xqt: [IMPR] Use input_choice with makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458774 [10:59:29] (03CR) 10Dalba: [IMPR] Change option shortcuts (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458727 (owner: 10Xqt) [11:09:01] (03CR) 10Xqt: [IMPR] Change option shortcuts (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458727 (owner: 10Xqt) [11:23:34] (03PS2) 10Xqt: [IMPR] Change option shortcuts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458727 [11:27:03] (03CR) 10Dalba: [C: 032] [IMPR] Change option shortcuts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458727 (owner: 10Xqt) [11:29:31] (03PS3) 10Xqt: [IMPR] Use bot instance instead of bot class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458749 [11:30:16] (03Merged) 10jenkins-bot: [IMPR] Change option shortcuts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458727 (owner: 10Xqt) [11:32:46] (03CR) 10jenkins-bot: [IMPR] Change option shortcuts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458727 (owner: 10Xqt) [11:33:01] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Use bot instance instead of bot class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458749 (owner: 10Xqt) [11:43:42] (03PS4) 10Xqt: [IMPR] Use bot instance instead of bot class [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458749 [11:52:10] (03PS2) 10Xqt: [IMPR] Use input_choice with makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458774 [11:54:30] africanhope: Okay, I'll have a look :) [11:55:02] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [12:07:38] (03CR) 10D3r1ck01: "One thing I noticed is after the documentation generation, it overwrites some text that I had fixed. Have a look at them and adjust." (0315 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [12:07:44] africanhope: reviewed [12:08:02] (03CR) 10D3r1ck01: [C: 04-1] Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [12:11:45] 10Africa-Wikimedia-Developers, 10Developer-Advocacy: Google Code-In Program 2018 Interested Mentors from Africa - https://phabricator.wikimedia.org/T203068 (10D3r1ck01) p:05Normal>03High [12:50:02] (03PS1) 10Xqt: [IMPR] Improvements fo MakeCatBot.include() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458792 [12:56:49] (03CR) 10D3r1ck01: [C: 04-1] Refactor installation bash script (032 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [13:53:59] (03PS3) 10African Hope: Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) [13:56:14] (03PS4) 10African Hope: Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) [13:56:52] d3r1ck: That should be okay now [14:10:32] (03PS1) 10Dvorapa: [bugfix] Fix doc error introduced in cca2d26a97f5 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458821 (https://phabricator.wikimedia.org/T187009) [14:22:14] (03CR) 10Xqt: [C: 032] [bugfix] Fix doc error introduced in cca2d26a97f5 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458821 (https://phabricator.wikimedia.org/T187009) (owner: 10Dvorapa) [14:23:19] (03PS1) 10Dalba: Remove cryptography from requirements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) [14:24:36] (03PS2) 10Dalba: Remove cryptography from requirements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) [14:26:07] (03Merged) 10jenkins-bot: [bugfix] Fix doc error introduced in cca2d26a97f5 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458821 (https://phabricator.wikimedia.org/T187009) (owner: 10Dvorapa) [14:28:18] Okay, so should we go by the name "installation.sh" script? [14:28:22] africanhope: ^^ [14:28:30] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [14:28:34] (03CR) 10jenkins-bot: [bugfix] Fix doc error introduced in cca2d26a97f5 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458821 (https://phabricator.wikimedia.org/T187009) (owner: 10Dvorapa) [14:29:12] I did not come up with any more self explanatory name lol [14:29:27] Any idea is welcome [14:29:38] d3r1ck: ^^ [14:29:56] (03CR) 10D3r1ck01: "Minor fix" (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [14:30:11] Okay, just some minor fix in the commit message [14:30:35] What if we call it `setup.sh`? [14:30:54] africanhope: ^^ [14:31:22] I saw your comment d3r1ck, also `setup.sh` sounds cooler [14:31:33] africanhope: Really? if so, we can call it setup then? [14:33:23] (03PS5) 10African Hope: Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) [14:33:51] d3r1ck: could you take another look? [14:34:45] d3r1ck: wait, a typo [14:34:54] in the README [14:35:27] Okay, waiting..... [14:35:51] (03PS6) 10African Hope: Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) [14:36:48] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [14:37:02] reviewing... [14:38:11] (03CR) 10D3r1ck01: [C: 032] Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [14:38:38] (03Merged) 10jenkins-bot: Refactor installation bash script [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458607 (https://phabricator.wikimedia.org/T203713) (owner: 10African Hope) [14:39:25] 10Africa-Wikimedia-Developers, 10Patch-For-Review: Merge install-deps.sh and generate_docs.sh into a single file - https://phabricator.wikimedia.org/T203713 (10D3r1ck01) Thanks for fixing this @samuelguebo [14:39:35] 10Africa-Wikimedia-Developers, 10Patch-For-Review: Merge install-deps.sh and generate_docs.sh into a single file - https://phabricator.wikimedia.org/T203713 (10D3r1ck01) 05Open>03Resolved a:03D3r1ck01 [14:39:49] 10Africa-Wikimedia-Developers, 10Patch-For-Review: Merge install-deps.sh and generate_docs.sh into a single file - https://phabricator.wikimedia.org/T203713 (10D3r1ck01) a:05D3r1ck01>03samuelguebo [14:40:16] africanhope: You're up for deployment :) [14:56:16] nice [14:57:25] restarting k8s [14:57:56] production is up [14:58:08] d3r1ck: nice work my friend [14:58:25] Nice work to you africanhope :) [14:59:49] that auto documentation and the test are really nice features [14:59:52] (03PS1) 10Xqt: [IMPR] Improvements from makecat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458831 [15:05:34] africanhope: Thank you :) [15:05:41] (03CR) 10Xqt: "what about" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) (owner: 10Dalba) [15:05:45] For the docs generation part, it's not yet complete, but we'll fix it [15:05:53] tests are always good :) [15:06:09] Thanks for deploying africanhope. I'm tempted to ask for access to the tool but I won't [15:06:16] I wish to be a non-deployer :D [15:08:28] ahah well when you'll want I'll grant access to the tf server [15:08:50] (will probably look at the doc cause I don't remember how :P) [15:18:40] :) [15:41:54] 10Africa-Wikimedia-Developers, 10Developer-Advocacy: Google Code-In Program 2018 Interested Mentors from Africa - https://phabricator.wikimedia.org/T203068 (10Aklapper) I don't know if there is a dedicated mailing list for #Africa-Wikimedia-Developers so this is a heads-up: Please check https://lists.wikimedi... [15:52:46] 10Africa-Wikimedia-Developers, 10Developer-Advocacy: Google Code-In Program 2018 Interested Mentors from Africa - https://phabricator.wikimedia.org/T203068 (10samuelguebo) Thanks @Aklapper, we'll make sure to check it out. Also, you might use african-wikimedia-developers@lists.wikimedia.org, our dedicated mail... [15:54:03] 10Africa-Wikimedia-Developers, 10Developer-Advocacy: Google Code-In Program 2018 Interested Mentors from Africa - https://phabricator.wikimedia.org/T203068 (10Aklapper) Meh, I should have checked the list of mailing lists, sorry. Noted, I'll also spam that list now! :D :D [16:13:25] (03CR) 10Dalba: "> Patch Set 2:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) (owner: 10Dalba) [16:13:27] (03PS3) 10Dalba: Remove cryptography from requirements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) [16:16:07] (03CR) 10Dalba: Remove cryptography from requirements (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) (owner: 10Dalba) [16:25:13] (03CR) 10Dalba: Remove cryptography from requirements (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) (owner: 10Dalba) [16:31:36] (03PS1) 10African Hope: Style menu links [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458843 [16:33:10] d3r1ck: I added minor changes to the menu: +icons and css [16:54:50] (03CR) 10Dalba: Remove cryptography from requirements (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) (owner: 10Dalba) [16:55:32] (03PS4) 10Dalba: Remove cryptography from requirements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) [18:48:54] (03CR) 10D3r1ck01: Style menu links (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458843 (owner: 10African Hope) [18:49:10] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458843 (owner: 10African Hope) [18:50:05] africanhope: \o/ [18:50:07] Reviewing now! [18:55:56] (03PS5) 10Dalba: Remove cryptography<2.3 from python<=2.7.6 requirements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) [18:56:12] (03CR) 10Dalba: "This change is ready for review." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) (owner: 10Dalba) [19:10:53] (03CR) 10Framawiki: [fix] Skip test_no_params() for status 503 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458465 (https://phabricator.wikimedia.org/T203637) (owner: 10Xqt) [19:12:40] (03CR) 10Framawiki: [C: 031] Remove cryptography<2.3 from python<=2.7.6 requirements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/458823 (https://phabricator.wikimedia.org/T203435) (owner: 10Dalba) [19:25:58] (03PS1) 10Jayprakash12345: Convert &action=recreatedata in OOUI [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/458875 (https://phabricator.wikimedia.org/T203839) [19:27:55] (03CR) 10jerkins-bot: [V: 04-1] Convert &action=recreatedata in OOUI [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/458875 (https://phabricator.wikimedia.org/T203839) (owner: 10Jayprakash12345) [19:30:07] (03CR) 10jerkins-bot: [V: 04-1] Convert &action=recreatedata in OOUI [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/458875 (https://phabricator.wikimedia.org/T203839) (owner: 10Jayprakash12345) [19:31:56] (03PS2) 10African Hope: Style menu links [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458843 [19:32:54] d3r1ck: I saw you comment and edited the message [19:45:17] :) [19:56:49] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458843 (owner: 10African Hope) [20:00:07] (03PS1) 10Jayprakash12345: Convert Special:DeleteCargoTable in OOUI [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/458885 (https://phabricator.wikimedia.org/T203839) [20:10:59] (03CR) 10D3r1ck01: [C: 032] Style menu links [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458843 (owner: 10African Hope) [20:11:27] (03Merged) 10jenkins-bot: Style menu links [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/458843 (owner: 10African Hope) [20:27:16] * d3r1ck checks out