[05:27:42] (03PS1) 10Dalba: Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 [05:30:01] (03CR) 10jerkins-bot: [V: 04-1] Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [05:30:47] (03PS2) 10Dalba: Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 [06:00:02] (03CR) 10Zhuyifei1999: [C: 031] Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [06:32:30] (03CR) 10Xqt: "diff_checker seems obsolete then after your flake8 plugin." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [06:42:57] (03CR) 10Xqt: Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [06:50:22] (03PS3) 10Dalba: Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 [06:55:06] (03CR) 10Dalba: "> Patch Set 2:" (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [06:58:13] (03PS3) 10Xqt: [tests] Add flake8-regex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/447452 [06:58:26] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add flake8-regex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/447452 (owner: 10Xqt) [07:10:18] (03PS4) 10Xqt: [tests] Add flake8-regex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/447452 [07:10:31] (03CR) 10Xqt: [C: 032] Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [07:11:08] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add flake8-regex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/447452 (owner: 10Xqt) [07:13:12] (03Merged) 10jenkins-bot: Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [07:14:58] (03CR) 10jenkins-bot: Use flake8-no-u-prefixed-strings to prevent usage of u-prefixed strings [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464097 (owner: 10Dalba) [07:37:58] (03PS5) 10Xqt: [tests] Add flake8-regex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/447452 [07:38:42] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add flake8-regex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/447452 (owner: 10Xqt) [08:09:49] * d3r1ck checks in! [08:32:32] (03CR) 10Dalba: [C: 032] [tests] Set fast_finish: true [pywikibot/core] - 10https://gerrit.wikimedia.org/r/463735 (https://phabricator.wikimedia.org/T186323) (owner: 10Xqt) [08:34:45] (03Merged) 10jenkins-bot: [tests] Set fast_finish: true [pywikibot/core] - 10https://gerrit.wikimedia.org/r/463735 (https://phabricator.wikimedia.org/T186323) (owner: 10Xqt) [08:36:37] (03CR) 10jenkins-bot: [tests] Set fast_finish: true [pywikibot/core] - 10https://gerrit.wikimedia.org/r/463735 (https://phabricator.wikimedia.org/T186323) (owner: 10Xqt) [08:38:26] (03CR) 10Dalba: [tests] Run L10N tests on Travis only once for each patch (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/462912 (https://phabricator.wikimedia.org/T191632) (owner: 10Xqt) [08:41:58] (03PS37) 10Dvorapa: [IMPR] Get rid of requirements files [pywikibot/core] - 10https://gerrit.wikimedia.org/r/434356 (https://phabricator.wikimedia.org/T193476) [08:46:49] (03CR) 10Xqt: "Hm, there is something wrong now after line 22" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/463735 (https://phabricator.wikimedia.org/T186323) (owner: 10Xqt) [08:49:41] (03CR) 10Xqt: ">" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/462912 (https://phabricator.wikimedia.org/T191632) (owner: 10Xqt) [09:02:46] (03CR) 10Dalba: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/463735 (https://phabricator.wikimedia.org/T186323) (owner: 10Xqt) [11:27:34] (03PS3) 10Nikhil-nk: Add StartDate/Datetime and EndDate/Datetime data type [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/462725 [11:28:46] 10Google-Code-in-2018, 10FormWizard, 10FormWizard-Gadget: Remove getRapidGrantsProbox() from javascript module - https://phabricator.wikimedia.org/T204655 (10Aklapper) Not a beginner task [[ https://www.mediawiki.org/wiki/Google_Code-in/Mentors#Task_template | by definition ]]. :) [11:37:40] (03CR) 10Nikhil-nk: "> Did you remove the "Rating" type from this patch? That's fine -" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/462725 (owner: 10Nikhil-nk) [12:26:14] 10Google-Code-in-2018, 10Readers-Web-Backlog, 10TextExtracts, 10Need-volunteer, 10Patch-For-Review: Current version of text extracts list compatibility with 1.29 but uses 1.30 code - https://phabricator.wikimedia.org/T205916 (10TheDJ) We should really have some CI linting on issues like this. Happens way... [12:39:05] 10Google-Code-in-2018, 10Growth-Team, 10Thanks: Write unit tests for Thanks JS modules - https://phabricator.wikimedia.org/T160267 (10Aklapper) @D3r1ck01: On the GCI site, I've split this into two tasks so students do not collide with choosing which tests to work on, set the category to QA as this is about t... [12:40:06] 10Africa-Wikimedia-Developers, 10Google-Code-in-2018, 10goodfirstbug: "Home" link of AWMD stats tool (sometimes) uses HTTP [Not Secure] protocol instead of HTTPS - https://phabricator.wikimedia.org/T202577 (10Aklapper) [12:41:35] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Fix issues found by flake8 - https://phabricator.wikimedia.org/T203951 (10Urbanecm) [12:41:54] 10Africa-Wikimedia-Developers, 10Google-Code-in-2018, 10goodfirstbug: "Home" link of AWMD stats tool (sometimes) uses HTTP [Not Secure] protocol instead of HTTPS - https://phabricator.wikimedia.org/T202577 (10Aklapper) [13:15:37] 10Google-Code-in-2018, 10Growth-Team, 10Thanks: Write unit tests for Thanks JS modules - https://phabricator.wikimedia.org/T160267 (10D3r1ck01) Thanks so much @Aklapper. Indeed this will solve the collision problem you highlighted :) [13:19:27] (03PS1) 10Dalba: Merge "[tests] Set fast_finish: true" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464145 [13:19:29] (03PS1) 10Dalba: .appveyor.yml: Fix and cleanup the matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464146 [13:20:04] (03Abandoned) 10Dalba: Merge "[tests] Set fast_finish: true" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464145 (owner: 10Dalba) [13:21:24] (03PS2) 10Dalba: .appveyor.yml: Fix and cleanup the matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464146 [13:24:55] (03PS3) 10Dalba: .appveyor.yml: Fix and cleanup the matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464146 [13:25:50] (03PS4) 10Dalba: .appveyor.yml: Fix and cleanup the matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464146 [13:51:04] (03PS1) 10D3r1ck01: [IMPR] Update CoC file for the repository [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464153 [14:01:20] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @subbu & @tgr - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:16:23] opentechno: Hey, would you be part of the IRC meeting today in less than an hour? [14:16:31] It's in the #wikimedia-tech channel :) [14:16:49] Cc r054l13 [14:16:51] need help on this task: https://phabricator.wikimedia.org/T135267 [14:17:09] d3r1ck: of course [14:17:13] opentechno: Cool, so that would be a good place to ask for help [14:17:24] We've got very experience people that can advice on the task :) [14:17:51] opentechno: What exactly do you want help on? You know you need to be precise so others can help you out right? [14:18:54] 10Africa-Wikimedia-Developers, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-LanguageSelector, 10goodfirstbug: Update LanguageSelector for AuthManager - https://phabricator.wikimedia.org/T135267 (10D3r1ck01) [14:19:15] d3r1ck: How understand the description of task and fix it? [14:19:40] opentechno: Okay, so let's try here and if we're stuck, we can ask on the advice channel :) [14:20:01] So there is a MediaWiki version 1.26 [14:20:48] Before that version, there was a MW hook used called AddNewAccount that was used in the AuthManager [14:21:31] But since the hook has been replaced in 1.26 and above, it's advice that the LocalUserCreated hook should now be used I think [14:21:51] opentechno: Here is the new hook, https://www.mediawiki.org/wiki/Manual:Hooks/LocalUserCreated [14:22:15] Previous hook was, https://www.mediawiki.org/wiki/Manual:Hooks/AddNewAccount but it's deprecated now [14:22:37] opentechno: So the old hook is only used for backward compatibility [14:23:58] opentechno: Poking around the LS codebase, I think here is where you have to work, https://gerrit.wikimedia.org/g/mediawiki/extensions/LanguageSelector/+/b5646a1315bdff2dac02d599abd30013e8435b0d/LanguageSelector.php#76 [14:24:17] And fix this too, https://gerrit.wikimedia.org/g/mediawiki/extensions/LanguageSelector/+/b5646a1315bdff2dac02d599abd30013e8435b0d/LanguageSelector.php#340 [14:24:26] opentechno: Does my explanation help? [14:25:44] 10Africa-Wikimedia-Developers, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-LanguageSelector, 10goodfirstbug: Update LanguageSelector for AuthManager - https://phabricator.wikimedia.org/T135267 (10D3r1ck01) [14:25:55] opentechno: I've updated the task description a little :) [14:27:06] In case things are still cloudy, I think we've got the #wikimedia-tech channel to try but please do some work in trying to understand first before you pitch questions [14:27:36] opentechno: I think specific questions are very likely to be answered than such general questions :) [14:27:57] d3r1ck: Okay [14:28:03] But we can spend that extra time here dissecting the issue :D [14:28:07] * d3r1ck grins [14:48:50] d3r1ck: I will start to work on the tasks Pywikibot like it is a Python-based fralework and it's the program language that I study [14:50:30] d3r1ck: And after hacker MediaWiki Core and extensions then fix also bugs [14:51:20] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @subbu & @tgr - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:29:53] africanhope: When we start with pywikibot is it we do we have to install it in the same folder as the mediawki core? [15:31:13] opentechno: pywikibot is a different animal, as you know it is in Python. For the sake of consistency I would not put it within the same repository as the core [15:31:27] opentechno: moving it somewhere else would be ideal. [15:33:57] opentechno: Okay! [15:34:49] africanhope: okay [15:35:48] d3r1ck: I have posted a message in the channel #wikimedia-tech but I have not received of answer [15:37:11] Hmmm.... opentechno, could you try something out first and get a specific question to ask when stuck? [15:40:19] d3r1ck: Okay [15:40:29] Cool! [15:49:16] opentechno: Could you add some information about yourself to this page? [15:49:18] https://www.mediawiki.org/w/index.php?title=User:Opentechno&action=edit&redlink=1 [15:49:28] So that other GCI folks can read about you? [15:49:51] You can use the wiki markup on my page here: https://www.mediawiki.org/wiki/User:Alangi_Derick, as a template to build yours up :) [15:50:02] Let's try to avoid red links :) [15:51:40] d3r1ck: Thanks you very much [15:51:53] Don't mention, anytime :) [16:01:25] 10Google-Code-in-2018, 10Readers-Web-Backlog, 10TextExtracts, 10Need-volunteer, 10Patch-For-Review: Current version of text extracts list compatibility with 1.29 but uses 1.30 code - https://phabricator.wikimedia.org/T205916 (10Jdlrobson) Thanks @TheDJ what would such linting look like? Shall we open a t... [16:10:50] 10Google-Code-in-2018, 10Readers-Web-Backlog, 10TextExtracts, 10Need-volunteer, 10Patch-For-Review: Current version of text extracts list compatibility with 1.29 but uses 1.30 code - https://phabricator.wikimedia.org/T205916 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson [16:38:16] (03CR) 10Matěj Suchánek: Added support for lexemes and forms (039 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/461372 (owner: 10Rua) [17:02:17] (03CR) 10Dvorapa: [C: 032] .appveyor.yml: Fix and cleanup the matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464146 (owner: 10Dalba) [17:05:03] (03Merged) 10jenkins-bot: .appveyor.yml: Fix and cleanup the matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464146 (owner: 10Dalba) [17:06:55] (03CR) 10jenkins-bot: .appveyor.yml: Fix and cleanup the matrix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/464146 (owner: 10Dalba) [17:21:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/464224 (owner: 10L10n-bot) [18:13:38] 10Google-Code-in-2018, 10FormWizard, 10FormWizard-Gadget: Fix incorrect documentation comment for configData in MediaWiki's FormWizard extension - https://phabricator.wikimedia.org/T204662 (10Aklapper) [18:39:29] 10Africa-Wikimedia-Developers, 10Google-Code-in-2018: [Recurring] Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T205450 (10Aklapper) [18:48:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/464280 (owner: 10L10n-bot) [19:49:30] 10Google-Code-in-2018, 10Continuous-Integration-Config: Add yourself to the Jenkins whitelist in Gerrit to trigger testing unit test failures or code style issues yourself - https://phabricator.wikimedia.org/T200778 (10Aklapper) [19:59:41] 10Google-Code-in-2018, 10MobileFrontend, 10Readers-Web-Backlog, 10Need-volunteer: MobileFrontend throws away warnings and other data from action=parse - https://phabricator.wikimedia.org/T86210 (10Jdlrobson) [20:01:06] 10Google-Code-in-2018, 10Lexicographical data, 10Wikidata, 10Software-Licensing, 10goodfirstbug: https://www.wikidata.org/wiki/Special:Version/License/WikibaseLexeme says "No detailed licence information was found" - https://phabricator.wikimedia.org/T204938 (10Aklapper) [20:02:47] 10Google-Code-in-2018, 10MobileFrontend, 10Readers-Web-Backlog, 10Wikimedia-Site-requests, and 2 others: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10Jdlrobson) p:05Low>03Normal [20:03:45] 10Google-Code-in-2018, 10MobileFrontend, 10Readers-Web-Backlog, 10Wikimedia-Site-requests, and 2 others: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10Jdlrobson) [22:01:27] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @bawolff - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [22:25:22] 10Google-Code-in-2018, 10MobileFrontend, 10Readers-Web-Backlog, 10MinervaNeue (3rd party support): Anonymous CTAs for section edit links are broken for 3rd parties - https://phabricator.wikimedia.org/T205351 (10Jdlrobson) 05Open>03declined Looks like we plan to remove this code as part of T205382. [22:51:30] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @bawolff - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [23:15:32] * d3r1ck checks out