[00:00:12] d3r1ck hi, gerrit 2.16 comes out on novemeber 14th! [00:41:40] (03CR) 10Samwilson: "Oh no worries, I just thought I'd check it hadn't fallen through the cracks. :-)" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/466840 (https://phabricator.wikimedia.org/T200054) (owner: 10Samwilson) [02:44:38] (03PS1) 10JJMC89: Prevent touch from creating pages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 [02:53:29] (03PS2) 10JJMC89: [FIX] Prevent touch from creating pages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) [05:22:05] (03PS3) 10JJMC89: [FIX] Prevent touch from creating pages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) [05:23:57] (03CR) 10jerkins-bot: [V: 04-1] [FIX] Prevent touch from creating pages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) (owner: 10JJMC89) [05:27:22] (03PS4) 10JJMC89: [FIX] Prevent touch from creating pages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) [05:57:28] (03PS2) 10Rosalieper: Refactor repo to use Wikimedia's JS coding convention As per [[mw:Manual:Coding_conventions/JavaScript#Linting]]. [labs/tools/Commons-twitter-bot] - 10https://gerrit.wikimedia.org/r/464478 (https://phabricator.wikimedia.org/T190163) [08:28:56] paladox: \o/ [08:30:17] (03CR) 10D3r1ck01: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) (owner: 10JJMC89) [08:33:28] (03CR) 10D3r1ck01: [FIX] Prevent touch from creating pages (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) (owner: 10JJMC89) [09:05:04] Derick,am waiting for your review on my pull request [11:22:32] 10Google-Code-in-2018, 10Goatification, 10International-Developer-Events, 10Wikimedia-Technical-Conference-2018: GCI: Racconicorn Racoonmendations Sticker - https://phabricator.wikimedia.org/T207973 (10siyam-_-) F27115296 [11:22:53] 10Google-Code-in-2018, 10Goatification, 10International-Developer-Events, 10Wikimedia-Technical-Conference-2018: GCI: Racconicorn Racoonmendations Sticker - https://phabricator.wikimedia.org/T207973 (10siyam-_-) {F27115296} [11:27:10] 10Google-Code-in-2018, 10Goatification, 10International-Developer-Events, 10Wikimedia-Technical-Conference-2018: GCI: Racconicorn Racoonmendations Sticker - https://phabricator.wikimedia.org/T207973 (10RazShuty) OMG I love this phab ticket! it's phabulous !!! [11:27:33] (03CR) 10Xqt: "Could you explain this patch a bit" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) (owner: 10JJMC89) [11:33:59] (03CR) 10Bartosz Dziewoński: [C: 032] Remove obsolete Special:Preferences styles after its transformation to OOUI [skins/Vector] - 10https://gerrit.wikimedia.org/r/472088 (https://phabricator.wikimedia.org/T208923) (owner: 10VolkerE) [11:34:26] (03CR) 10Xqt: [C: 031] [FIX] Prevent touch from creating pages (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472374 (https://phabricator.wikimedia.org/T193833) (owner: 10JJMC89) [11:35:49] 10Pywikibot, 10Patch-For-Review: page.touch can recreate a deleted page - https://phabricator.wikimedia.org/T193833 (10Xqt) a:03JJMC89 [11:41:03] (03Merged) 10jenkins-bot: Remove obsolete Special:Preferences styles after its transformation to OOUI [skins/Vector] - 10https://gerrit.wikimedia.org/r/472088 (https://phabricator.wikimedia.org/T208923) (owner: 10VolkerE) [12:17:43] 10Google-Code-in-2018, 10VisualEditor, 10I18n, 10Patch-For-Review: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) Since both Math and language variants are kind of a pain to set up, and the issue only occurs in... [16:05:51] 10Google-Code-in-2018, 10VisualEditor, 10I18n, 10Patch-For-Review: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10takidelfin) | `vertical-align:top;` | `vertical-align: middle` | | ------------------------- | -----------... [16:13:14] 10Google-Code-in-2018, 10VisualEditor, 10I18n, 10Patch-For-Review: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) I think both look okay, but apparently we usually align long labels to the top, see e.g. checkbo... [19:03:09] 10Google-Code-in-2018, 10Bouquet, 10CSS, 10Patch-For-Review, 10goodfirstbug: Overlapping of bullet points with the text in Advanced Search - https://phabricator.wikimedia.org/T205177 (10Gopavasanth) a:03takidelfin [19:06:16] 10Google-Code-in-2018, 10VisualEditor, 10I18n, 10Patch-For-Review: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) Final version of the patch: | | Long label | Short label | | -- | -- |... [19:51:47] 10Pywikibot: Unicode traceback in weblinkchecker.py - https://phabricator.wikimedia.org/T209094 (10Phuzion) [19:56:40] 10Pywikibot: weblinkchecker.py: TypeError: 'unicode' object is not callable - https://phabricator.wikimedia.org/T209094 (10zhuyifei1999) [20:01:05] 10Pywikibot: weblinkchecker.py: TypeError: 'unicode' object is not callable - https://phabricator.wikimedia.org/T209094 (10zhuyifei1999) This is a #regression from 482a453. CC @D3r1ck01. [20:02:20] (03PS1) 10Zhuyifei1999: weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) [20:05:48] (03CR) 10D3r1ck01: weblinkchecker.py: Don't call 'url', a unicode object (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:06:47] (03CR) 10D3r1ck01: "git submodule update --init --recursive" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:09:20] 10Pywikibot, 10Patch-For-Review: weblinkchecker.py: TypeError: 'unicode' object is not callable - https://phabricator.wikimedia.org/T209094 (10D3r1ck01) > This is a #regression from 482a453. CC @D3r1ck01. Yup, :( [20:09:25] (03CR) 10Zhuyifei1999: "I'm trying to fix that. And no, `git submodule --init --recursive` won't do." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:10:18] (03CR) 10D3r1ck01: "> I'm trying to fix that. And no, `git submodule --init --recursive` won't do." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:10:29] (03PS2) 10Zhuyifei1999: weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) [20:14:16] 10Google-Code-in-2018, 10Audiences-QA, 10MinervaNeue, 10Accessibility, and 5 others: Download icon is causing invalid HTML - https://phabricator.wikimedia.org/T205359 (10nray) [20:14:31] (03PS3) 10D3r1ck01: weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:14:56] (03PS4) 10Zhuyifei1999: weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) [20:15:00] (03CR) 10D3r1ck01: "@Zhuyifei1999, fixed!" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:15:27] (03CR) 10D3r1ck01: "Rebasing will not solve the issue, I've fixed it :)" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:17:18] 10Google-Code-in-2018, 10Audiences-QA, 10MinervaNeue, 10Accessibility, and 5 others: Download icon is causing invalid HTML - https://phabricator.wikimedia.org/T205359 (10nray) Lgtm! Tested on chrome desktop and mobile (android), was able to see the spinner, download button worked, and html is valid. [20:17:21] (03CR) 10Zhuyifei1999: "I would have fixed this by myself... Did some combination of `git checkout HEAD^ scripts/i18n`, `git add scripts/i18n`, and `git submodule" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:18:30] (03CR) 10D3r1ck01: "> I would have fixed this by myself... Did some combination of `git checkout HEAD^ scripts/i18n`, `git add scripts/i18n`, and `git submodu" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:19:28] (03CR) 10Zhuyifei1999: "Honestly, I know what rebase, checkout, submodule, etc. are. I would appreciate it if you don't sound like I'm a newbie to git." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:21:17] (03CR) 10D3r1ck01: "> Honestly, I know what rebase, checkout, submodule, etc. are. I would appreciate it if you don't sound like I'm a newbie to git." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:21:38] 10Google-Code-in-2018, 10Audiences-QA, 10MinervaNeue, 10Accessibility, and 5 others: Download icon is causing invalid HTML - https://phabricator.wikimedia.org/T205359 (10nray) a:05nray>03None [20:22:44] (03CR) 10Zhuyifei1999: "Ok then :). Sorry for misunderstanding." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [20:30:26] 10Google-Code-in-2018, 10MinervaNeue, 10Readers-Web-Backlog, 10Technical-Debt: Remove client side code inside initEditLink in resources/skins.minerva.scripts/init.js - https://phabricator.wikimedia.org/T206262 (10Arcayn) a:03Arcayn [20:49:47] 10Pywikibot, 10Pywikibot-weblinkchecker.py, 10Patch-For-Review, 10Pywikibot-network: weblinkchecker.py slows down (itself, OS) to freeze after a while reaching 100% of RAM - https://phabricator.wikimedia.org/T185561 (10zhuyifei1999) (still waiting for upstream release) [20:54:00] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [21:00:47] 10Pywikibot, 10Pywikibot-pagegenerators.py: APIError: too-many-titles with -start: page generator - https://phabricator.wikimedia.org/T209111 (10Framawiki) [21:01:32] 10Google-Code-in-2018, 10Wikidata, 10Documentation, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), and 2 others: Typo in docstring of wikibase js file causes file to be miscategorised in doc.wikimedia.org - https://phabricator.wikimedia.org/T207386 (10Mvolz) 05Open>03Resolved [21:01:44] 10Google-Code-in-2018, 10Wikidata, 10Documentation, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10goodfirstbug: Typo in docstring of wikibase js file causes file to be miscategorised in doc.wikimedia.org - https://phabricator.wikimedia.org/T207386 (10Mvolz) [21:02:26] 10Pywikibot, 10Pywikibot-pagegenerators.py: APIError: too-many-titles with -start: page generator - https://phabricator.wikimedia.org/T209111 (10Framawiki) [21:05:27] 10Google-Code-in-2018, 10Wikidata, 10Documentation, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10goodfirstbug: Typo in docstring of wikibase js file causes file to be miscategorised in doc.wikimedia.org - https://phabricator.wikimedia.org/T207386 (10Mvolz) Done and deployed: https://doc.wikimedia.org/Wi... [21:06:57] 10Google-Code-in-2018, 10VisualEditor, 10I18n, 10Patch-For-Review, 10User-Ryasmeen: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) 05Open>03Resolved a:03takidelfin [21:23:58] 10Pywikibot, 10Patch-For-Review, 10Regression: weblinkchecker.py: TypeError: 'unicode' object is not callable - https://phabricator.wikimedia.org/T209094 (10Framawiki) [21:28:35] (03CR) 10Framawiki: weblinkchecker.py: Don't call 'url', a unicode object (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [21:49:48] 10Pywikibot, 10Pywikibot-pagegenerators.py: APIError: too-many-titles with -start: page generator - https://phabricator.wikimedia.org/T209111 (10Framawiki) Same error as bot user: ` tools.framabot@tools-bastion-02:~$ ./pwb.py version Pywikibot: [https] r-pywikibot-core.git (7ea6fba, g1, 2018/11/05, 17:45:43,... [23:27:25] (03PS5) 10Zhuyifei1999: [bugfix] weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) [23:34:27] 10Pywikibot, 10Pywikibot-weblinkchecker.py, 10Patch-For-Review, 10Pywikibot-network: weblinkchecker.py slows down (itself, OS) to freeze after a while reaching 100% of RAM - https://phabricator.wikimedia.org/T185561 (10zhuyifei1999) 05Open>03stalled [23:50:43] (03CR) 10Framawiki: [C: 032] [bugfix] weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [23:52:27] (03Merged) 10jenkins-bot: [bugfix] weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [23:54:17] (03CR) 10jenkins-bot: [bugfix] weblinkchecker.py: Don't call 'url', a unicode object [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472523 (https://phabricator.wikimedia.org/T209094) (owner: 10Zhuyifei1999) [23:59:03] 10Google-Code-in-2018, 10VisualEditor, 10I18n, 10User-Ryasmeen: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10Petar.petkovic)