[02:16:37] (03PS1) 10JJMC89: [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 [02:52:40] 10Google-Code-in-2018, 10MediaWiki-extensions-OAuthAuthentication, 10Test-Coverage, 10User-Zoranzoki21: OAuthAuthentication extension is missing @covers tags - https://phabricator.wikimedia.org/T195151 (10Zoranzoki21) a:03Zoranzoki21 [03:04:01] (03PS2) 10JJMC89: [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 [06:33:06] (03CR) 10Xqt: [IMPR] Allow use of action=purge API parameters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [06:35:52] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: TestIsbnWikibaseBot.test_isbn_format is failing with TypeError - https://phabricator.wikimedia.org/T208484 (10Xqt) p:05High>03Normal Doesn’t occur anymore [07:15:39] (03CR) 10JJMC89: [IMPR] Allow use of action=purge API parameters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [09:39:05] (03CR) 10D3r1ck01: "Thanks for the reviews @Volker :)" (039 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [09:39:40] (03PS10) 10D3r1ck01: Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 [09:42:24] (03CR) 10Xqt: [C: 04-1] [IMPR] Allow use of action=purge API parameters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [09:43:53] (03CR) 10Xqt: [C: 04-1] [IMPR] Allow use of action=purge API parameters (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [09:43:57] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [10:25:51] (03PS1) 10Xqt: Use issue_deprecation_warning to deprecate option [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472866 [10:42:08] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-Documentation, 10Pywikibot-tests: Doc source and destination directories cannot be identical since Sphinx 1.8.0 - https://phabricator.wikimedia.org/T204189 (10Dvorapa) The issue was resolved in rstcheck 3.3.1, hopefully we can switch on a combination rstcheck >=... [13:03:12] 10Google-Code-in-2018, 10MediaWiki-extensions-Scribunto: Add a unit test to Scribunto testing it is not vulnerable to CVE-2014-5461 - https://phabricator.wikimedia.org/T209232 (10Bawolff) [14:10:35] (03CR) 10Framawiki: [C: 031] Add .vscode in .gitignore [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472748 (owner: 10Zoranzoki21) [14:12:21] (03CR) 10Framawiki: [doc] Update HISTORY.rst (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472764 (owner: 10Xqt) [14:15:13] (03CR) 10Framawiki: [C: 032] Use issue_deprecation_warning to deprecate option [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472866 (owner: 10Xqt) [14:17:12] (03Merged) 10jenkins-bot: Use issue_deprecation_warning to deprecate option [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472866 (owner: 10Xqt) [14:18:51] (03CR) 10jenkins-bot: Use issue_deprecation_warning to deprecate option [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472866 (owner: 10Xqt) [15:44:11] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10Jdlrobson) @takidelfin the display is correct on mobile but it should look like this on tablet and desktop (>=72... [16:05:10] 10Google-Code-in-2018, 10Refreshed, 10CSS, 10Patch-For-Review: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 (10Gopavasanth) @Shreyasminocha There are few minor things encountered after testing your patch, **Before testing: ** {F27185727} *... [18:18:49] (03PS3) 10JJMC89: [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 [18:18:57] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [18:23:03] (03PS4) 10JJMC89: [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 [18:23:11] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [18:37:34] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) umm, so that padding is expected? But I did it previously D: [18:38:33] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10D3r1ck01) This is what I see; {F27189236} {F27189235} [19:06:22] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) yep, there is 1 px padding :/ I really don't understand what is the expected behavior. Do you want c... [19:10:00] (03CR) 10VolkerE: [C: 032] Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [19:15:31] (03Merged) 10jenkins-bot: Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [19:15:44] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) | `>=1000px` | `>=720px` | `<720px` | | -------------- | ------------- | ----------- | | {F27190778}... [19:18:41] (03CR) 10jenkins-bot: Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [19:47:35] (03PS5) 10JJMC89: [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 [19:47:44] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [20:08:24] 10Google-Code-in-2018, 10Refreshed, 10CSS, 10Patch-For-Review: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 (10Shreyasminocha) Urbanecm and I couldn't reproduce Gopa's first bullet point (as discussed in #wikimedia-dev) and I addressed the sec... [20:08:43] 10Google-Code-in-2018, 10Refreshed, 10CSS, 10Patch-For-Review: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 (10Shreyasminocha) a:05Shreyasminocha>03None [20:08:47] (03PS6) 10JJMC89: [IMPR] Allow use of action=purge API parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 [20:12:15] (03CR) 10JJMC89: "Sorry for the PS noise" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/472864 (owner: 10JJMC89) [20:18:45] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10Jdlrobson) No. The padding is different on mobile. Mobile needs to look like: {F27192162} (>=720px) like this:... [20:21:37] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) umm.... but that is how it looks actually. [20:23:51] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10D3r1ck01) @Jdlrobson, that means the actual behavior on the task description is not a bug right? Because that is... [21:00:33] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Split preferences from TrackerProfile model to simplify preferences logic - https://phabricator.wikimedia.org/T208680 (10Urbanecm) 05Open>03Resolved [21:50:47] 10Google-Code-in-2018, 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) @Legoktm Can you mentor this too for #google-code-in-2018? [21:50:53] 10Google-Code-in-2018, 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [22:29:47] 10Google-Code-in-2018, 10WMCZ-Tracker: Add --no-pull option to support/deploy script - https://phabricator.wikimedia.org/T206617 (10Urbanecm) I imported the task as https://codein.withgoogle.com/tasks/6333808543531008/ and I will mentor it. [22:38:22] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Do not display field description repeatedly in edit_ticket/create_ticket - https://phabricator.wikimedia.org/T206104 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/5339191949918208/ and I will mentor it. [22:38:38] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Write tests for notifications - https://phabricator.wikimedia.org/T203979 (10Urbanecm) [22:39:08] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Write tests for notifications - https://phabricator.wikimedia.org/T203979 (10Urbanecm) a:03Urbanecm Need to figure out why tests are failing. [22:39:29] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Add --no-pull option to support/deploy script - https://phabricator.wikimedia.org/T206617 (10Urbanecm) [23:08:34] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10Jdlrobson) The bug only exists with tablet. The issue is the paddi ng under reading preferences. Mobile should s...