[00:28:20] (03CR) 10jenkins-bot: build: Update devDependencies [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473034 (owner: 10Esanders) [00:32:06] (03CR) 10jenkins-bot: Remove obsolete aliases from closures [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473033 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [06:11:33] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 23.0.0 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473327 (owner: 10Libraryupgrader) [08:13:05] (03CR) 10Xqt: proofreadpage.py: insert support for googleOCR (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/446973 (owner: 10Mpaa) [08:43:10] (03CR) 10Thiemo Kreuz (WMDE): tests: Add unit tests for SpamlistLookup::factory() (035 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [11:06:24] 10Google-Code-in-2018, 10Collaboration-Community-Engagement, 10CommRel-Documentation, 10Growth-Team, and 2 others: Create a guided tour about StructuredDiscussions - https://phabricator.wikimedia.org/T112757 (10Aklapper) @Trizek-WMF: For GCI this would need steps for a contributor what's expected, where an... [11:15:20] 10Google-Code-in-2018, 10Collaboration-Community-Engagement, 10CommRel-Documentation, 10Growth-Team, and 2 others: Create a guided tour about StructuredDiscussions - https://phabricator.wikimedia.org/T112757 (10Trizek-WMF) @Aklapper, at the moment @SBisson will review the task to see if we create multiple... [11:17:40] (03CR) 10D3r1ck01: "Thanks for your review @Thiemo :) Much appreciated :)" (035 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [11:18:35] (03PS7) 10D3r1ck01: tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 [15:01:24] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:33:26] 10Google-Code-in-2018, 10MediaWiki-Installer: Running DatabaseUpdater::purgeCache via WebInstaller should handle exceptions more gracefully - https://phabricator.wikimedia.org/T209341 (10LukBukkit) a:03LukBukkit [15:51:24] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [17:14:27] d3r1ck GWTUI is being removed today! [17:14:33] not at the wmf but upstream. [17:14:37] :( [17:14:44] thats a good thing :) [17:14:50] Ohh really? [17:15:06] But won't that cause issues instead? What is the replacement? [17:15:23] polygerrit [17:15:26] is the replacement [17:18:06] Cool! :) [17:18:11] At the upstream level? [17:18:16] Then soon at the wmf level right? [17:18:45] yep [17:18:53] we will get it at wmf with gerrit 3.0 [17:25:06] paladox: Nice! [17:25:16] And you'll be a demi god right? :D [17:25:24] huh? [17:25:28] demi god? [17:29:36] :D [17:29:52] Don't worry, just kidding but maybe I'm serious? [17:44:29] 10Google-Code-in-2018, 10MediaWiki-Internationalization, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06): Add Eastern Pwo language (kjp) to Names.php - https://phabricator.wikimedia.org/T203908 (10Nikerabbit) Could someone have a look at {T209338}? [17:54:00] d3r1ck gwtui has been removed now! [17:54:01] https://gerrit-review.googlesource.com/c/gerrit/+/116790 [17:55:31] Wow [17:55:40] I love that PollyGerrit UI [18:19:41] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Add --no-pull option to support/deploy script - https://phabricator.wikimedia.org/T206617 (10Urbanecm) 05Open>03Resolved a:03Immogmog123 [18:33:56] 10Google-Code-in-2018, 10MinervaNeue (Desktop), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid errors - https://phabricator.wikimedia.org/T193505 (10ovasileva) [18:51:16] 10Google-Code-in-2018, 10MediaWiki-Core-Tests, 10Readers-Web-Backlog, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 2 others: Forbid use of $.each, $.map, $.isArray in core JavaScript code - https://phabricator.wikimedia.org/T200877 (10Esanders) Yes - this is the same as the GitHub issue. [18:56:20] 10Google-Code-in-2018, 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10SEO, 10goodfirstbug: Outputting 'β` on every page, not only on beta, as part of the logo is disadvantageous - https://phabricator.wikimedia.org/T208185 (10Jdlrobson) a:03Bjornskjald [18:57:49] 10Google-Code-in-2018, 10MediaWiki-Core-Tests, 10Readers-Web-Backlog, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 2 others: Forbid use of $.each, $.map, $.isArray in core JavaScript code - https://phabricator.wikimedia.org/T200877 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson Remaini... [18:58:01] 10Google-Code-in-2018, 10MediaWiki-Core-Tests, 10Readers-Web-Backlog, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 2 others: Forbid use of $.each, $.map, $.isArray in core JavaScript code - https://phabricator.wikimedia.org/T200877 (10Jdlrobson) [20:15:14] 10Africa-Wikimedia-Developers, 10goodfirstbug: Populate the contributors.json file in awmd-stats tool with contributors details - https://phabricator.wikimedia.org/T202230 (10D3r1ck01) [20:27:58] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Ack name isn't displayed in on /ticket/<id>/edit/<ack_name>/add/ and /ticket/<ticket id>/edit/acks/<ack id>/delete/ - https://phabricator.wikimedia.org/T209417 (10Urbanecm) [20:29:30] <wikibugs> 10goodfirstbug, 10MediaWiki-Cache, 10MediaWiki-Database, 10MediaWiki-General-or-Unknown, 10Performance-Team: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10jlinehan) Seems to be a problem with the RevisionStore implementation of getRevisionByTitl... [20:36:15] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Ack name isn't displayed in <title> on /ticket/<id>/edit/<ack_name>/add/ and /ticket/<ticket id>/edit/acks/<ack id>/delete/ - https://phabricator.wikimedia.org/T209417 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/6515980453806080/... [20:37:33] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Ack name isn't displayed in <title> on /ticket/<id>/edit/<ack_name>/add/ and /ticket/<ticket id>/edit/acks/<ack id>/delete/ - https://phabricator.wikimedia.org/T209417 (10Urbanecm) [20:53:38] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Tracker returns 500 instead of 404 when trying to edit non-existent ticket in admin - https://phabricator.wikimedia.org/T209340 (10Urbanecm) I imported it as https://codein.withgoogle.com/tasks/5782264412635136/ and I will mentor it. [21:11:19] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow users to watch grants - https://phabricator.wikimedia.org/T209538 (10Urbanecm) [21:11:34] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Squash TicketWatcher and TopicWatcher models - https://phabricator.wikimedia.org/T208659 (10Urbanecm) 05Open>03Resolved [21:12:06] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Clicking anywhere on notification row in watch.html form should cause the checkbox to be checked - https://phabricator.wikimedia.org/T209281 (10Urbanecm) 05Open>03Resolved [21:16:28] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow users to watch grants - https://phabricator.wikimedia.org/T209538 (10Urbanecm) I imported this task as https://codein.withgoogle.com/tasks/5999632707485696/ and I will mentor it. [21:40:23] <wikibugs> 10Google-Code-in-2018, 10MediaWiki-extensions-Other, 10Patch-For-Review, 10Test-Coverage: Numbertext extension is missing @covers tags - https://phabricator.wikimedia.org/T195149 (10Legoktm) 05Open>03Resolved a:03rafidaslam [21:41:04] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Wrap `editingold` in a warning box to make it more visible - https://phabricator.wikimedia.org/T202248 (10Jdforrester-WMF) 05Open>03Resolved a:03LukBukkit Thank you! This will get deployed to production in the... [21:41:18] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-General-or-Unknown: Wrap `editingold` in a warning box to make it more visible - https://phabricator.wikimedia.org/T202248 (10Jdforrester-WMF) [21:45:13] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Patch-For-Review, and 2 others: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous - https://phabricator.wikimedia.org/T208185 (10Jdlrobson) [21:46:26] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Tracker returns 500 instead of 404 when trying to edit non-existent ticket in admin - https://phabricator.wikimedia.org/T209340 (10rafidaslam) a:03rafidaslam I'll work on this (claimed on gci) [21:49:12] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-General-or-Unknown: Wrap `editingold` in a warning box to make it more visible - https://phabricator.wikimedia.org/T202248 (10D3r1ck01) > @d3r1ck, please mark it as done on the GCI site as I can't. :-) This was done as CR+2 is not a blocker for approving GC... [21:54:11] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Ack name isn't displayed in <title> on /ticket/<id>/edit/<ack_name>/add/ and /ticket/<ticket id>/edit/acks/<ack id>/delete/ - https://phabricator.wikimedia.org/T209417 (10Urbanecm) 05Open>03Resolved a:03Arcayn [22:13:12] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-General-or-Unknown: Wrap `editingold` in a warning box to make it more visible - https://phabricator.wikimedia.org/T202248 (10LukBukkit) Thanks for reviewing this so fast. It's really exciting to get code into production although it's just a small change. ^^ [22:40:07] <wikibugs> (03PS16) 10Mpaa: proofreadpage.py: insert support for googleOCR [pywikibot/core] - 10https://gerrit.wikimedia.org/r/446973